/irc-logs / mozilla / #accessibility / 2011-12-02 / end

Options:

  1. # Session Start: Fri Dec 02 00:00:00 2011
  2. # Session Ident: #accessibility
  3. # [00:34] * Joins: aaronlev (aaronlev@moz-9058091D.bstnma.fios.verizon.net)
  4. # [00:34] * ChanServ sets mode: +o aaronlev
  5. # [00:39] <@firebot> trev.saunders@gmail.com requested review from roc@ocallahan.org for attachment 578428 on bug 705983.
  6. # [00:40] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=705983 nor, --, ---, nobody, NEW, Firefox a11y is not enabled on GNOME if config.use_system_prefs.accessibility is false (default)
  7. # [00:42] * Joins: jaws (u2871@moz-160C58C6.com)
  8. # [00:43] <jaws> hey everybody
  9. # [00:44] <@tbsaunde> jaws: hi
  10. # [00:44] * iamjessklein-away is now known as jess
  11. # [00:45] <jaws> is someone available to do a feedback pass on the patch for bug 693014?
  12. # [00:45] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=693014 nor, --, ---, nobody, NEW, HTML5 <video controls> "click to play/pause" doesn't respect event.preventDefault standard
  13. # [00:45] * Joins: victorporof (victorporo@DCE93940.AB163232.79933D60.IP)
  14. # [00:47] <@tbsaunde> jaws: davidb might depending on what he's up to, but its well into the evening for him already
  15. # [00:47] <jaws> ok, i'll add him for the feedback request. thanks
  16. # [00:49] <@tbsaunde> np
  17. # [00:49] <@tbsaunde> mgorse: around?
  18. # [00:49] <@tbsaunde> mgorse: I'm thinking it might make sense to just drop the pref service stuff from the patch in bug 693343 and land it pdq
  19. # [00:49] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=693343 maj, --, ---, trev.saunders, ASSI, accessibility always disabled in GNOME 3 unless GNOME_ACCESSIBILITY is set
  20. # [00:53] * Quits: @aaronlev (aaronlev@moz-9058091D.bstnma.fios.verizon.net) (Quit: aaronlev)
  21. # [01:02] * khuey|away is now known as khuey
  22. # [01:36] * Joins: davidb_ (davidb@moz-976CD2.dsl.bell.ca)
  23. # [01:36] * Quits: davidb_ (davidb@moz-976CD2.dsl.bell.ca) (Input/output error)
  24. # [01:39] * Joins: nhirata (nhirata.bu@moz-2A9C9106.hsd1.ca.comcast.net)
  25. # [01:42] * jess is now known as iamjessklein-away
  26. # [02:20] <@firebot> hub@mozilla.com requested review from surkov.alexander@gm ail.com for attachment 578444 on bug 689105.
  27. # [02:20] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=689105 maj, --, ---, hub, NEW, Accessibility in main window broken for VoiceOver, VO doesn't see anything but the title bar and its
  28. # [02:50] * khuey is now known as khuey|away
  29. # [02:54] * Quits: ehsan (ehsan@F2D29657.F60B0462.67AC9B1.IP) (Input/output error)
  30. # [03:01] * jaws is now known as jaws|away
  31. # [03:08] * Joins: aaronlev (aaronlev@moz-9058091D.bstnma.fios.verizon.net)
  32. # [03:08] * ChanServ sets mode: +o aaronlev
  33. # [03:40] * Quits: nhirata (nhirata.bu@moz-2A9C9106.hsd1.ca.comcast.net) (Ping timeout)
  34. # [03:43] * Joins: nhirata (nhirata.bu@moz-2A9C9106.hsd1.ca.comcast.net)
  35. # [03:45] <@firebot> trev.saunders@gmail.com requested review from surkov.alexander@gm ail.com for attachment 578474 on bug 705983.
  36. # [03:45] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=705983 maj, --, ---, nobody, NEW, Firefox a11y is not enabled on GNOME if config.use_system_prefs.accessibility is false (default)
  37. # [03:57] * Quits: @davidb (davidb@31ABB91E.F7EBA23.C3C3A9D0.IP) (Quit: bye)
  38. # [04:10] * Quits: @hub (hub@21B7B9F2.B87E9213.6E712CE2.IP) (Ping timeout)
  39. # [04:26] * Quits: @aaronlev (aaronlev@moz-9058091D.bstnma.fios.verizon.net) (Quit: aaronlev)
  40. # [04:34] <@firebot> trev.saunders@gmail.com granted review for attachment 577845 on bug 658272.
  41. # [04:35] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=658272 nor, --, ---, surkov.alexander, ASSI, Implement figure and figcaption accessibility
  42. # [04:44] <@firebot> roc@ocallahan.org granted review for attachment 578428 on bug 705983.
  43. # [04:44] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=705983 maj, --, ---, nobody, NEW, Firefox a11y is not enabled on GNOME if config.use_system_prefs.accessibility is false (default)
  44. # [04:51] * Joins: hub (hub@moz-E2FCA694.figuiere.net)
  45. # [04:51] * ChanServ sets mode: +o hub
  46. # [05:05] * Joins: surkov (surkov@140BA2CF.1993F3A0.5D3F4C44.IP)
  47. # [05:05] * ChanServ sets mode: +o surkov
  48. # [05:25] * Quits: @surkov (surkov@140BA2CF.1993F3A0.5D3F4C44.IP) (Ping timeout)
  49. # [05:26] <@firebot> surkov.alexander@gmail.com denied review for attachment 578444 on bug 689105.
  50. # [05:26] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=689105 maj, --, ---, hub, NEW, Accessibility in main window broken for VoiceOver, VO doesn't see anything but the title bar and its
  51. # [05:59] <@firebot> trev.saunders@gmail.com granted review for attachment 577875 on bug 706067.
  52. # [05:59] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=706067 nor, --, ---, surkov.alexander, ASSI, Make takeFocus work on widget items
  53. # [06:00] <@firebot> surkov.alexander@gmail.com requested review from ginn.chen@oracle.co m for attachment 578428 on bug 705983.
  54. # [06:00] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=705983 maj, --, ---, nobody, NEW, Firefox a11y is not enabled on GNOME if config.use_system_prefs.accessibility is false (default)
  55. # [06:01] <@firebot> surkov.alexander@gmail.com requested review from ginn.chen@oracle.co m for attachment 578474 on bug 705983.
  56. # [06:53] * Quits: aleiva (gloob@moz-FBC526A7.euler.es) (Client exited)
  57. # [08:10] * Joins: silvia (Adium@moz-E17E202D.dyn.iinet.net.au)
  58. # [08:17] <@firebot> marco.zehe@googlemail.com granted review for attachment 578327 on bug 591363.
  59. # [08:17] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=591363 nor, --, ---, bolterbugz, NEW, (in)visible state is not always correct?
  60. # [09:03] * Joins: gloob (gloob@moz-FBC526A7.euler.es)
  61. # [09:04] * gloob is now known as aleiva
  62. # [09:08] * Quits: silvia (Adium@moz-E17E202D.dyn.iinet.net.au) (Quit: Leaving.)
  63. # [09:18] * Quits: @hub (hub@moz-E2FCA694.figuiere.net) (Ping timeout)
  64. # [12:14] * Quits: victorporof (victorporo@DCE93940.AB163232.79933D60.IP) (Quit: victorporof)
  65. # [12:24] <@firebot> mak77@bonardo.net changed the Status on bug 706834 from ASSIGNED to RESOLVED.
  66. # [12:24] <@firebot> mak77@bonardo.net set the Resolution field on bug 706834 to FIXED.
  67. # [12:24] <@firebot> mak77@bonardo.net changed the Target Milestone on bug 706834 from --- to mozilla11.
  68. # [12:24] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=706834 cri, --, mozilla11, surkov.alexander, RESO FIXED, Crash in nsXULTreeAccessible::TreeViewChanged
  69. # [12:58] * Joins: victorporof (victorporo@F84E8E02.A00C134E.79933D60.IP)
  70. # [13:42] * khuey|away is now known as khuey
  71. # [13:56] * Joins: surkov (surkov@DD563F5.F78D7EEB.34044A7F.IP)
  72. # [13:56] * ChanServ sets mode: +o surkov
  73. # [13:58] <@firebot> surkov.alexander@gmail.com requested approval-mozilla-aurora from the wind for attachment 578278 on bug 706834.
  74. # [13:58] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=706834 cri, --, mozilla11, surkov.alexander, RESO FIXED, Crash in nsXULTreeAccessible::TreeViewChanged
  75. # [14:19] <@firebot> surkov.alexander@gmail.com requested review from trev.saunders@gmail .com for attachment 578327 on bug 591363.
  76. # [14:19] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=591363 nor, --, ---, bolterbugz, NEW, (in)visible state is not always correct?
  77. # [15:04] * Quits: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP) (Ping timeout)
  78. # [15:21] <@tbsaunde> surkov: any particular reason you want me to review bug 591363?
  79. # [15:21] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=591363 nor, --, ---, bolterbugz, NEW, (in)visible state is not always correct?
  80. # [15:23] <@surkov> tbsaunde: the patch is not unambiguous and not trivial, that might be nice if you look in deep at this part code
  81. # [15:25] <@tbsaunde> surkov: ok, its not code I'm terribly familiar with though, and not really sure I understand the constrants on what we want to do that well
  82. # [15:26] <@tbsaunde> (it seems like there are some weird ones like that background tab thing)
  83. # [15:26] <@surkov> tbsaunde: basically we want expose our invisible and offscreen states close to ATK spec
  84. # [15:27] <@tbsaunde> ok
  85. # [15:27] <@tbsaunde> I'm not familiar with what atk says either, but will go look
  86. # [15:27] <@surkov> yep, that piece of code could require you to do some serious thinking, I'm sorry but I'm trying to make you to not miss any serious patch :)
  87. # [15:28] <@tbsaunde> its ok
  88. # [15:29] <@tbsaunde> though the idea of making me not miss any serious patch makes me shiver a little
  89. # [15:30] * Joins: jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP)
  90. # [15:30] * ChanServ sets mode: +o jprmc
  91. # [15:37] * Joins: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP)
  92. # [15:41] * iamjessklein-away is now known as jess
  93. # [15:47] <@surkov> tbsaunde: do you ldap account?
  94. # [15:51] * Joins: davidb (davidb@F2D29657.F60B0462.67AC9B1.IP)
  95. # [15:51] * ChanServ sets mode: +qo davidb davidb
  96. # [15:51] <@tbsaunde> surkov: not quiet yet, should be soon though I'd think
  97. # [15:52] <@davidb> heyo!
  98. # [15:52] <@surkov> davidb: hi
  99. # [15:52] <@tbsaunde> surkov: why?
  100. # [15:54] <@surkov> tbsaunde: this week we voted to grant you a peer rights, so congrats, you passed :) I need to update the owners page, I think ldap is used for that.
  101. # [15:54] <@davidb> tbsaunde: congratulations :)
  102. # [15:55] <@davidb> well deserved.
  103. # [15:56] <@tbsaunde> surkov: davidb thanks!
  104. # [15:56] <@surkov> yw
  105. # [15:56] * @davidb dances
  106. # [15:57] <@surkov> sorry for saying that between this and then :) I'd liked to update the page first of all, to make it official
  107. # [15:57] <@davidb> surkov: I missed the back scroll, is there a snag?
  108. # [15:58] <@tbsaunde> np
  109. # [15:58] <@surkov> davidb: I just asked if trevor has ldap account
  110. # [15:58] <@surkov> I tried his email he used for checking but it doesn't work, it says this email is not in database
  111. # [15:58] <@surkov> maybe I should file a bug on that
  112. # [15:58] <@davidb> hmm
  113. # [15:59] <@davidb> surkov: yeah, or try to find someone on irc
  114. # [15:59] <@surkov> on which one?
  115. # [15:59] <@davidb> gavin would be good but he's west coast
  116. # [15:59] <@surkov> I joined to #siteplanning which is supposed for mozilla.org stuffs but only one unfamiliar person there :)
  117. # [16:00] <@davidb> surkov: i wonder if gerv might know
  118. # [16:00] <@surkov> could you ask around please?
  119. # [16:00] <@davidb> sure
  120. # [16:01] <@surkov> btw, you use different email for bugzilla but you're email is at mozilla.com, that's a problem in general
  121. # [16:01] <@davidb> yeah it can be a pita
  122. # [16:05] <@davidb> a guest just arrived (a11y guy) i'm going to give him a quick tour
  123. # [16:05] <@davidb> surkov: can you describe how it is a problem (i'm aware of 1 or 2 issues but they aren't show stoppers)
  124. # [16:05] * Quits: @davidb (davidb@F2D29657.F60B0462.67AC9B1.IP) (Quit: davidb)
  125. # [16:07] * bwinton_away is now known as bwinton
  126. # [16:26] * Joins: davidb (davidb@F2D29657.F60B0462.67AC9B1.IP)
  127. # [16:26] * ChanServ sets mode: +qo davidb davidb
  128. # Session Close: Fri Dec 02 16:31:17 2011
  129. #
  130. # Session Start: Fri Dec 02 16:31:17 2011
  131. # Session Ident: #accessibility
  132. # [16:31] * Disconnected
  133. # [16:32] * Attempting to rejoin channel #accessibility
  134. # [16:32] * Rejoined channel #accessibility
  135. # [16:32] * Topic is '"build the web for everyone" | release schedule: http://mzl.la/LNc0W'
  136. # [16:32] * Set by davidb on Wed Jul 20 16:22:07
  137. # [16:36] * Joins: aaronlev (aaronlev@moz-CDA191A6.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com)
  138. # [16:36] * ChanServ sets mode: +o aaronlev
  139. # [16:53] * Joins: clown (clown@67828CC7.C1A51174.9D42CF23.IP)
  140. # [17:07] * tbsaunde is now known as tbsaunde|afk
  141. # [17:11] <gavin> davidb: ?
  142. # [17:12] <@davidb> oh hi gavin, i think we figured it out. despot is no longer used for peer/owner module edits correct?
  143. # [17:12] <gavin> tbsaunde|afk does have an ldap account afaict: tsaunders@m.c
  144. # [17:12] <gavin> right, despot is no longer used for anything aside from some cvs access controls
  145. # [17:12] <gavin> and ldap isn't needed for the peer list either
  146. # [17:12] <gavin> just edit https://wiki.mozilla.org/Modules/All
  147. # [17:12] * Quits: nhirata (nhirata.bu@moz-2A9C9106.hsd1.ca.comcast.net) (Quit: nhirata)
  148. # [17:17] * Quits: @surkov (surkov@DD563F5.F78D7EEB.34044A7F.IP) (Quit: surkov)
  149. # [17:19] <@davidb> gavin: yep ty
  150. # [17:32] * Joins: davidb_ (davidb@31ABB91E.F7EBA23.C3C3A9D0.IP)
  151. # [18:07] * Quits: clown (clown@67828CC7.C1A51174.9D42CF23.IP) (Connection reset by peer)
  152. # [18:07] * Joins: clown (clown@67828CC7.C1A51174.9D42CF23.IP)
  153. # [18:10] <clown> firebot: davidb_ ?
  154. # [18:10] <@firebot> clown: Sorry, I've no idea what 'davidb_' might be.
  155. # [18:11] * Quits: ehsan (ehsan@moz-A6FE435.build.sjc1.mozilla.com) (Input/output error)
  156. # [18:20] * Joins: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com)
  157. # [18:21] * @eeejay waves urbanely
  158. # [18:24] * Joins: ehsan (ehsan@moz-A6FE435.build.sjc1.mozilla.com)
  159. # [18:24] * Quits: ehsan (ehsan@moz-A6FE435.build.sjc1.mozilla.com) (Input/output error)
  160. # [18:27] * Joins: ehsan (ehsan@moz-A6FE435.build.sjc1.mozilla.com)
  161. # [18:28] <davidb_> heyo
  162. # [18:39] * Quits: ehsan (ehsan@moz-A6FE435.build.sjc1.mozilla.com) (Input/output error)
  163. # [19:02] * khuey is now known as khuey|away
  164. # [19:04] * khuey|away is now known as khuey
  165. # [19:10] * Joins: ehsan (ehsan@moz-A6FE435.build.sjc1.mozilla.com)
  166. # [19:18] * jaws|away is now known as jaws
  167. # [19:30] * Quits: ehsan (ehsan@moz-A6FE435.build.sjc1.mozilla.com) (Input/output error)
  168. # [19:32] * Joins: ehsan (ehsan@moz-A6FE435.build.sjc1.mozilla.com)
  169. # [19:32] <@eeejay> firebot, how come you don't announce changes to bug 698823
  170. # [19:32] <@eeejay> ?
  171. # [19:33] <@firebot> eeejay: Sorry, I've no idea what 'how come you don't announce changes to bug 698823' might be.
  172. # [19:33] <@eeejay> how convenient
  173. # [19:42] * Joins: hub (hub@21B7B9F2.B87E9213.6E712CE2.IP)
  174. # [19:42] * ChanServ sets mode: +o hub
  175. # [19:48] <@aaronlev> s/firebot/siri ?
  176. # [19:50] <@davidb> firebot: bug 698823
  177. # [19:50] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=698823 nor, --, mozilla10, eitan, NEW, Introduce virtual cursor/soft focus functionality to a11y API
  178. # [19:50] * @davidb pets firebot
  179. # [19:50] <@firebot> yay
  180. # [19:50] <@eeejay> hehe
  181. # [19:56] <@davidb> eeejay: firebot doesn't usually update the channel regarding comments
  182. # [19:56] <@davidb> just state changes, including patch state
  183. # [19:56] <@eeejay> oh, makes sense
  184. # [19:58] * tbsaunde|afk is now known as tbsaunde
  185. # [19:58] <@tbsaunde> gavin: huh, seems its active enough to let me log in to people, but not use intranet /me thought that ldap account was completely inactive
  186. # [20:00] * Quits: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com) (Quit: nhirata)
  187. # [20:01] <gavin> tbsaunde: are you still an employee/contractor?
  188. # [20:02] * Joins: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com)
  189. # [20:02] <gavin> oh, are you a former intern?
  190. # [20:02] <@davidb> gavin: he is a former intern, now contractor until July when he is full time
  191. # [20:02] <gavin> if you're a contractor you should have access to intranet
  192. # [20:03] <@davidb> i think there is a gap while the set up contractor status
  193. # [20:04] <@tbsaunde> davidb: yeah, that's what I figured
  194. # [20:04] <@tbsaunde> I just wasn't aware someone had started fliping those bits yet :)
  195. # [20:04] <@davidb> heh
  196. # [21:14] <@firebot> bmo@edmorley.co.uk changed the Status on bug 706335 from ASSIGNED to RESOLVED.
  197. # [21:14] <@firebot> bmo@edmorley.co.uk set the Resolution field on bug 706335 to FIXED.
  198. # [21:14] <@firebot> bmo@edmorley.co.uk changed the Target Milestone on bug 706335 from --- to mozilla11.
  199. # [21:14] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=706335 maj, --, mozilla11, surkov.alexander, RESO FIXED, Accessible text breaks when quoting header is removed from plain text reply
  200. # [21:29] * Quits: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com) (Quit: nhirata)
  201. # [21:31] * Joins: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com)
  202. # [21:31] <@tbsaunde> davidb: accessible->Role() == foo || accessible->Role() == bar really?!
  203. # [21:36] * Joins: bz (bzbarsky@moz-69B5879F.bstnma.fios.verizon.net)
  204. # [21:36] <bz> ok, so
  205. # [21:36] <bz> nsAccDocManager
  206. # [21:36] <bz> this is a distinct object from nsAccessibilityService, right?
  207. # [21:36] <bz> what's its lifetime normally?
  208. # [21:38] <@tbsaunde> bz: no, there the same
  209. # [21:39] <bz> hmm
  210. # [21:39] <@tbsaunde> bz: class nsAccessibilityService : public nsAccDocManager,
  211. # [21:39] <bz> ah
  212. # [21:39] <bz> I see
  213. # [21:39] <bz> ok
  214. # [21:39] <bz> thanks
  215. # [21:39] * bz digs
  216. # [21:40] <bz> any idea about that assert I mentioned?
  217. # [21:41] <@tbsaunde> bz: looking, not immediately
  218. # [21:43] <@tbsaunde> bz: do you have a stack?
  219. # [21:44] <bz> tbsaunde: sure, one sec
  220. # [21:45] <bz> gah
  221. # [21:45] <bz> copy/paste not working so much
  222. # [21:45] <bz> this is under WillRefresh on the notificationcontroller
  223. # [21:46] <bz> Calling ContentInsertion::Process
  224. # [21:46] <bz> calling ProcessContentInserted
  225. # [21:46] <bz> calling UpdateTree
  226. # [21:46] <bz> calling UpdateTreeInternal
  227. # [21:46] <bz> calling CacheChildrenInSubtree
  228. # [21:46] <bz> calling EnsureChildren
  229. # [21:46] <@tbsaunde> ok
  230. # [21:50] <@firebot> hub@mozilla.com requested review from surkov.alexander@gm ail.com for attachment 578684 on bug 689105.
  231. # [21:50] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=689105 maj, --, ---, hub, NEW, Accessibility in main window broken for VoiceOver, VO doesn't see anything but the title bar and its
  232. # [21:54] <@davidb> tbsaunde: oh yeah, i was gonna change that, but i wonder if the compiler does it for me
  233. # [21:55] <@tbsaunde> davidb: uh, the compiler would have to prove that Role() doesn't mutate anything that would effect what it returns the next time
  234. # [21:56] <@davidb> indeed
  235. # [21:57] <@davidb> tbsaunde: i'll fix all nits. how is the review going?
  236. # [21:57] * @davidb finds the bug
  237. # [21:58] <@tbsaunde> davidb: I found some ugh, that's a general thing I don't like, but other than that I have no idea about correctness yet
  238. # [21:59] <@tbsaunde> bz: so, somehow we are creating an accessible inserting it into the cache then proccessing an insertion that causes us to find the already cached accessible when we should be creating a new one and try to insert the existing one instead of a newly created one.
  239. # [21:59] <@tbsaunde> which I guess is sort of obvious and not really useful
  240. # [21:59] <bz> tbsaunde: ok. Can that leak? ;)
  241. # [22:00] <@tbsaunde> hmm, interesting question, I've never had to think about that before
  242. # [22:02] <@davidb> hub: do you want a phone?
  243. # [22:02] <@davidb> you are good at filing bugs after all :) there is the push for testing
  244. # [22:03] <@davidb> (or was that tweet just about pricing in general)
  245. # [22:04] <@davidb> !seen hhillen
  246. # [22:04] <@firebot> hhillen was last seen 10 days, 5 hours, 7 minutes and 26 seconds ago, saying 'Hi davidb ' in #accessibility.
  247. # [22:06] <bz> tbsaunde: quite honestly, my temptation is to disable this a11y test and see if that makes things green
  248. # [22:06] * jess is now known as iamjessklein-away
  249. # [22:06] <bz> tbsaunde: and if so, to push that for now....
  250. # [22:06] <@hub> davidb: I was just looking at it. I believe it is too big for my taste and I'm good with the Nexus One
  251. # [22:07] <@davidb> same
  252. # [22:07] <@hub> I thought the N9 was expensive, it actually isn't that much
  253. # [22:07] <@hub> I was curious to see how much the Galaxy Nexus was given that BHell has the exclusivity
  254. # [22:07] <@tbsaunde> bz: ok, I'll leave that up to Alex / davidb
  255. # [22:08] <@davidb> i understand the temptation
  256. # [22:08] <@davidb> bz: could you wait until Monday?
  257. # [22:09] <@davidb> (or weekend)
  258. # [22:09] <@davidb> i'm not up to date on what you are landing except for perf improvement.
  259. # [22:09] <@davidb> which is very important of course.
  260. # [22:09] <bz> I'm not landing it yet
  261. # [22:10] <bz> I'm still trying to get it to pass tests
  262. # [22:10] <@davidb> ok
  263. # [22:10] <bz> I can certainly wait till Monday
  264. # [22:10] * bz is still debugging this leak
  265. # [22:10] <@davidb> (thank you)
  266. # [22:11] * Quits: victorporof (victorporo@F84E8E02.A00C134E.79933D60.IP) (Ping timeout)
  267. # [22:14] <@tbsaunde> bz: so, I'm not immediately seeing how reparenting an accessible would result in a leak, but that's code scares me a little so...
  268. # [22:20] <bz> tbsaunde: ok
  269. # [22:21] * khuey is now known as khuey|away
  270. # [22:32] <bz> ok
  271. # [22:32] <bz> so the acc service adds itself as an event lister on documents?
  272. # [22:38] <@tbsaunde> bz: through nsAccDocManager I think so
  273. # [22:39] <bz> but it relies on the document destructors to remove itself?
  274. # [22:39] <bz> (and doesn't hold any strong refs to those documents, I assume)
  275. # [22:39] <@tbsaunde> hmm, let me look
  276. # [22:43] <@tbsaunde> bz: so, nsAccDocManager has a nsRefHashTable<nsPtrHashKey<const nsIDocument>, nsDocumentAccessible>
  277. # [22:44] <bz> ok
  278. # [22:44] <bz> that's not a strong ref
  279. # [22:44] <bz> to the document
  280. # [22:44] <@tbsaunde> ok
  281. # [22:44] <bz> ok
  282. # [22:44] * bz keeps digging
  283. # [22:44] <bz> wish our leak tools worked on windows. :(
  284. # [22:45] <@tbsaunde> yeah, that would be nice
  285. # [22:48] * Parts: clown (clown@67828CC7.C1A51174.9D42CF23.IP)
  286. # [22:59] * Quits: @davidb (davidb@F2D29657.F60B0462.67AC9B1.IP) (Quit: davidb)
  287. # [23:13] * Quits: davidb_ (davidb@31ABB91E.F7EBA23.C3C3A9D0.IP) (Ping timeout)
  288. # [23:16] * Quits: @aaronlev (aaronlev@moz-CDA191A6.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com) (Quit: aaronlev)
  289. # [23:16] * Joins: aaronlev (aaronlev@moz-CDA191A6.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com)
  290. # [23:16] * ChanServ sets mode: +o aaronlev
  291. # [23:16] * Quits: @aaronlev (aaronlev@moz-CDA191A6.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com) (Quit: aaronlev)
  292. # [23:46] * bwinton is now known as bwinton_away
  293. # [23:57] * iamjessklein-away is now known as jess
  294. # Session Close: Sat Dec 03 00:00:00 2011

The end :)