/irc-logs / mozilla / #accessibility / 2011-12-10 / end
Options:
- # Session Start: Sat Dec 10 00:00:00 2011
- # Session Ident: #accessibility
- # [00:02] * bwinton is now known as bwinton_away
- # [00:04] * Quits: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP) (Ping timeout)
- # [00:08] * Joins: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP)
- # [00:15] * Quits: Mana (Mana@moz-9745CC7.adsl.alicedsl.de) (Quit: Verlassend)
- # [00:32] * Quits: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP) (Ping timeout)
- # [00:33] <firebot> hub@mozilla.com changed the Status on bug 510024 from NEW to RESOLVED.
- # [00:33] <firebot> hub@mozilla.com set the Resolution field on bug 510024 to INVALID.
- # [00:33] <firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=510024 nor, --, ---, nobody, RESO INVALID, Remove unnecessary casts in nsAccessibleWrap.mm
- # [00:38] * Joins: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP)
- # [00:54] * Quits: ehsan (ehsan@F2D29657.F60B0462.67AC9B1.IP) (Connection reset by peer)
- # [00:58] * Quits: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP) (Ping timeout)
- # [01:05] * Joins: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP)
- # [01:07] * khuey is now known as khuey|away
- # [01:19] * khuey|away is now known as khuey
- # [01:19] * Joins: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP)
- # [01:20] * Quits: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP) (Ping timeout)
- # [01:26] * Joins: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP)
- # [01:41] * Quits: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com) (Quit: nhirata)
- # [01:46] * Joins: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com)
- # [01:49] * Quits: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Input/output error)
- # [02:13] * Quits: @hub (hub@21B7B9F2.B87E9213.6E712CE2.IP) (Ping timeout)
- # [02:34] * Joins: sye (sye@moz-74427DD7.fbx.proxad.net)
- # [02:35] * Parts: sye (sye@moz-74427DD7.fbx.proxad.net) (Quitte)
- # [02:48] * Quits: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP) (Ping timeout)
- # [02:48] * Joins: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP)
- # [03:02] * Quits: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com) (Quit: nhirata)
- # [03:11] * Quits: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP) (Ping timeout)
- # [03:17] * Joins: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP)
- # [03:48] * Quits: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP) (Ping timeout)
- # [03:54] * Joins: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP)
- # [04:07] * khuey is now known as khuey|away
- # [04:11] * Quits: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP) (Ping timeout)
- # [04:17] * Joins: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP)
- # [04:25] * Quits: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP) (Ping timeout)
- # [04:26] * khuey|away is now known as khuey
- # [04:31] * Joins: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP)
- # [04:50] * Quits: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP) (Ping timeout)
- # [04:51] * Joins: svg-newbie (Mibbit@moz-16D8AADC.hsd1.mi.comcast.net)
- # [04:51] * Parts: svg-newbie (Mibbit@moz-16D8AADC.hsd1.mi.comcast.net)
- # [04:56] * Joins: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP)
- # [06:08] * khuey is now known as khuey|away
- # [08:26] * Joins: jhk_ (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [08:40] * Quits: jhk_ (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [09:03] * Quits: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP) (Ping timeout)
- # [09:05] * Joins: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP)
- # [10:25] * Joins: jhk_ (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [11:27] * Quits: jhk_ (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [11:31] * Joins: jhk_ (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [12:35] <firebot> trev.saunders@gmail.com cancelled review?(surkov.alexander@gm ail.com) for attachment 553784 on bug 648265.
- # [12:35] <firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=648265 nor, --, ---, trev.saunders, NEW, provide dexcomed table interface version
- # [12:42] * khuey|away is now known as khuey
- # [12:43] <@tbsaunde|afk> jhk_: I'm going through your last patch for bug 673689 around?
- # [12:43] <firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=673689 nor, --, ---, jigneshhk1992, NEW, introduce namespace role
- # [12:43] * tbsaunde|afk is now known as tbsaunde
- # [12:44] <jhk_> tbsaunde: yeah
- # [12:44] <@tbsaunde> jhk_: so, first in atk/nsMaiInterfaceTable.cpp there's two calls to nsAccUtils::ROle() you should keep comparing against xpcom roles there
- # [12:46] <@tbsaunde> jhk_: then in atk/nsMaiInterfaceText.cpp there is Role atkRole = atkRoleMap[accessible->NativeRole()] that should stay PRUint32
- # [12:47] * Joins: Flyingmana (Mana@moz-9745CC7.adsl.alicedsl.de)
- # [12:47] <@tbsaunde> the purpose of that array is to convert elements of the enum role to the atk roles, so there's no reason to believe an element of the array is an element of the roles enum
- # [12:51] <@tbsaunde> jhk_: next, atkRoleMap is defined as static const PRUint32 it shouldn't be static, and the type should be AtkRole (you didn't change it, just something to clean up along the way)
- # [12:53] <jhk_> which file?
- # [12:53] <@tbsaunde> next thing, in base/AccGroupInfo.cpp you didn't fixthe order of includes
- # [12:53] <@tbsaunde> atk/nsRoleMap.h
- # [12:53] <jhk_> okay
- # [12:56] <@tbsaunde> jhk_: again in AccGroupInfo.cpp near line 132 the if should fit on one line
- # [12:59] <jhk_> All done upto last comment.
- # [13:01] <@tbsaunde> jhk_: ok, then in AccGrouPInfo::IsConceptualParent() it looks like some of those ifs could take a line less
- # [13:02] <jhk_> ya I was thinking same thing
- # [13:04] <@tbsaunde> jhk_: maybe AccGroupInfo::BaseRole() too
- # [13:05] <@tbsaunde> jhk_: in base/NotificationController.cpp you didn't fix include ordering
- # [13:07] <@tbsaunde> jhk_: then in ROles.h leave a blank line after the brace for the end of role namespace
- # [13:11] <@tbsaunde> jhk_: then in nsARIAGridAccessible.cpp in SetARIASelected() the if with three role checks and the one testing nsAccUtils::IsARIASelected()
- # [13:13] <@tbsaunde> then again nsARIAGridCellAccessible::GetTable()
- # [13:14] <@tbsaunde> and GetColumnIndex()
- # [13:17] <@tbsaunde> nsARIAGridCellAccessible::GetAttributesInternal() second if
- # [13:18] <@tbsaunde> and the third
- # [13:21] <jhk_> done
- # [13:23] <@tbsaunde> ok, thanks, a lot of this just looks good :)
- # [13:25] <jhk_> tbsaunde : Uploading latest patch in min.
- # [13:26] <@tbsaunde> jhk_: I still have more comments for the rest of this one so hold on :)
- # [13:26] <jhk_> ok
- # [13:26] <@tbsaunde> jhk_: in nsAccessibilityService.cpp 1087 the if should fit on one line
- # [13:27] <@tbsaunde> jhk_: did you find the other bugs I talked about yesterday?
- # [13:28] <@tbsaunde> again line 1138
- # [13:29] <jhk_> Is that about Bug 539683
- # [13:29] <firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=539683 nor, --, ---, nobody, NEW, defunct object methods should return CO_E_OBJECTNOTCONNECTED
- # [13:30] <@tbsaunde> jhk_: it would be great if you fixed that one yup
- # [13:31] <jhk_> not sure if I can do that. but will try.
- # [13:31] <@tbsaunde> jhk_: ok :) I'll help if you have questions
- # [13:32] <@tbsaunde> jhk_: nsAccessible::GetRole() should take a PRUint32* not a Role* because its xpcom method
- # [13:33] * Quits: jhk_ (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [13:33] <@tbsaunde> also don't change what *aRole is initially set to in that method
- # [13:33] * Joins: jhk_ (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [13:38] <@tbsaunde> jhk_: just before you dropped out
- # [13:38] <@tbsaunde> jhk_: nsAccessible::GetRole() should take a PRUint32* not a Role* because its xpcom method and shouldn't use role::foo
- # [13:39] <jhk_> ya I got that. in nsaccessiblityservice.cpp there are 2 if of which we can't get rid of . crossing 80 limits
- # [13:39] <jhk_> line 1138
- # [13:41] <@tbsaunde> jhk_: ok, I though we might be able to but ok
- # [13:41] <@tbsaunde> thx
- # [13:42] * Quits: victorporof (victorporo@DCE93940.AB163232.79933D60.IP) (Quit: victorporof)
- # [13:43] <@tbsaunde> jhk_: nsAccessible::NativeRole() fits on one line right?
- # [13:44] <jhk_> ya
- # [13:48] <@tbsaunde> jhk_: for bug 539683 if you don't have a windows machine to build on I can look for other bugs, we have a bunch
- # [13:48] <firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=539683 nor, --, ---, nobody, NEW, defunct object methods should return CO_E_OBJECTNOTCONNECTED
- # [13:48] <jhk_> others will be good.
- # [13:49] <jhk_> not using windows.
- # [13:53] <@tbsaunde> jhk_: ok, me too
- # [14:00] <jhk_> tbsaunde : review done?
- # [14:02] <@tbsaunde> jhk_: no, went off to find you bugs :)
- # [14:02] <@tbsaunde> jhk_: how about bug 539694?
- # [14:03] <firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=539694 nor, --, ---, nobody, NEW, accessible objects should have private copy constructor
- # [14:03] <@tbsaunde> or bug 706134
- # [14:03] <firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=706134 nor, --, ---, nobody, NEW, ARIA listitem shouldn't expose selectable state and pick up aria-selected and aria-checked
- # [14:04] <@tbsaunde> jhk_: or bug 689540 isn't really windows only
- # [14:04] <firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=689540 nor, P3, ---, nobody, NEW, Expose IA2 margin- object attributes
- # [14:06] <jhk_> picking 2nd for now.
- # [14:06] <jhk_> ;)
- # [14:06] <@tbsaunde> ok :)
- # [14:06] <jhk_> after that 539694
- # [14:07] <@tbsaunde> jhk_: sorry, its a really long patch :)
- # [14:07] <@tbsaunde> the roles one I mean
- # [14:08] <jhk_> no prob. any way I was learning.
- # [14:09] <@tbsaunde> jhk_: nsDocAccessible::MaybeNotifyOfValueChange() that if should fit on one line
- # [14:11] <@tbsaunde> jhk_: in base/nsFormControlAccessible.cpp the order of the headers should be nsFormControlAccessible.h blank line Roles.h blank line other headers
- # [14:15] <jhk_> I think in previous files we used same. this one need only order change i guess
- # [14:16] <@tbsaunde> jhk_: in nsTextAccessible.cpp put a blank line between the two includes
- # [14:16] <@tbsaunde> the include for that files header should be seperate from the general a11y headers
- # [14:17] <jhk_> so states.h and role.h will together
- # [14:18] <@tbsaunde> yes
- # [14:19] <@tbsaunde> html/nsHTMLCanvasAccessible.cpp too
- # [14:19] <jhk_> all files have states.h with other includes. so I have to modify all of them
- # [14:21] <@tbsaunde> well, if states.h is in a weird spot now we can fix that later
- # [14:22] <jhk_> ok
- # [14:22] <@tbsaunde> in nsHTMLTextFieldAccessible::NativeRole() remove the braces around the if but leave a blank line
- # [14:28] <@tbsaunde> jhk_: nsHTMLLinkAccessible::NativeRole() you should change to return role::LINK
- # [14:36] <@tbsaunde> jhk_: nsHTMLTableAccessible::IsProbablyForLayout() don't brace the if
- # [15:00] * khuey is now known as khuey|away
- # [15:04] <@tbsaunde> jhk_: either don't change nsXULButtonAccessible::ContainerWIdget() or change it to be return x ? mParent : nsnull;
- # [15:05] <@tbsaunde> actually, no forget that
- # [15:12] <@tbsaunde> jhk_: the if in nsXULListCellAccessible::GetColumnIndex() could take fewer lines :)
- # [15:13] * khuey|away is now known as khuey
- # [15:21] <@tbsaunde> jhk_: you didn't change what nsXULTabAccessible::NativeRole() returns
- # [15:22] <@tbsaunde> nsXULTabsAccessible and nsXULTabPannelAccessible too
- # [15:23] <@tbsaunde> I think its just all the ones in that file :)
- # [15:26] <@tbsaunde> jhk_: in nsXULTreeAccessible::NativeRole() there's no reason to have () around role::foo
- # [15:27] <@tbsaunde> same for nsXULTreeItemAccessible
- # [15:30] <@tbsaunde> jhk_: nsXULTreeGridAccessible::NativeRole() too
- # [15:30] <@tbsaunde> and that's it, thanks!
- # [15:30] <@tbsaunde> stuff already looks a lot nicer :)
- # [15:31] <jhk_> yup that's it :) thanks!
- # [15:33] <@tbsaunde> jhk_: yw! thanks for doing it
- # [15:36] * Quits: jhk_ (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [15:38] * Joins: jhk_ (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [15:41] <firebot> jigneshhk1992@gmail.com cancelled review?(surkov.alexander@gm ail.com) for attachment 580381 on bug 673689.
- # [15:41] <firebot> jigneshhk1992@gmail.com requested review from surkov.alexander@gm ail.com for attachment 580645 on bug 673689.
- # [15:41] <firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=673689 nor, --, ---, jigneshhk1992, NEW, introduce namespace role
- # [15:42] * Quits: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com) (Client exited)
- # Session Close: Sat Dec 10 16:01:33 2011
- #
- # Session Start: Sat Dec 10 16:01:33 2011
- # Session Ident: #accessibility
- # [16:01] * Disconnected
- # [16:02] * Attempting to rejoin channel #accessibility
- # [16:02] * Rejoined channel #accessibility
- # [16:02] * Topic is '"build the web for everyone" | release schedule: http://mzl.la/LNc0W'
- # [16:02] * Set by davidb on Thu Dec 08 15:12:17
- # [16:28] * Joins: peteb-away (ptbrunet@moz-4B8864B.austin.res.rr.com)
- # [16:36] <@tbsaunde> jhk_: does that patch build locally for you? if so I think its time we see if the tryserver has any problems with
- # [16:37] <jhk_> lets tryserver do it.
- # [16:37] <@tbsaunde> huh?
- # [16:39] <jhk_> you can just check it.
- # [16:40] <jhk_> If there is not conflicts
- # [16:43] * Joins: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP)
- # [16:43] <jhk_> tbsaunde : btw , how you check the code that is working , runs properly or not. any tools for that.
- # [16:44] <jhk_> accessibility one.
- # [16:47] <@tbsaunde> I'm not sure I understand what your asking about
- # [16:49] <@tbsaunde> do you mean our code?
- # [16:49] <jhk_> ya
- # [16:49] * Quits: Flyingmana (Mana@moz-9745CC7.adsl.alicedsl.de) (Ping timeout)
- # [16:50] * Joins: Flyingmana (Mana@moz-9745CC7.adsl.alicedsl.de)
- # [16:50] <@tbsaunde> we have a bunch of tests in accessible/tests
- # [16:50] <jhk_> oh ok
- # [16:50] <jhk_> thats what i am asking for
- # [16:50] <@tbsaunde> you run them with make mochitest-a11y
- # [16:52] <jhk_> It will take 2 hrs more. just downloaded new source. I have changed other stuff too.
- # [16:52] <jhk_> Is it working with you.
- # [16:52] <jhk_> that patch.
- # [16:55] <@tbsaunde> jhk_: building now
- # [17:02] <@tbsaunde> jhk_: some how you had . instead of , for a couple of the roles in Role.h
- # [17:03] <jhk_> mean?
- # [17:04] <@tbsaunde> you had list = 33. which isn't valid, it should be list = 33,
- # [17:04] <jhk_> oh its upto 44
- # [17:05] <jhk_> 45
- # [17:05] <jhk_> sorry!
- # [17:05] <@tbsaunde> np
- # [17:15] <jhk_> any this else pop out?
- # [17:15] <@tbsaunde> what?
- # [17:16] <jhk_> any other fault
- # [17:17] <jhk_> I think there shouldn't be any more . we have manually checked out all the things.
- # [17:19] <@tbsaunde> there's an issue with nsAccessible not being in the mozilla::a11y namespace that I'm playing with now
- # [17:39] * Quits: jhk_ (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [17:55] * Joins: Flyingmana_ (Mana@moz-838D21EC.adsl.alicedsl.de)
- # [17:56] * Quits: Flyingmana (Mana@moz-9745CC7.adsl.alicedsl.de) (Ping timeout)
- # [17:57] * Joins: jhk_ (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [19:02] * Quits: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP) (Ping timeout)
- # [19:08] * Joins: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP)
- # [19:21] * iamjessklein-away is now known as jess
- # [19:23] * jess is now known as iamjessklein-away
- # [19:31] * khuey is now known as khuey|away
- # [19:51] * Quits: jhk_ (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [20:18] * Joins: ehsan_ (ehsan@F0B20A8D.8458880F.57F33CED.IP)
- # [20:25] * Quits: ehsan_ (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Ping timeout)
- # [20:27] * Joins: ehsan_ (ehsan@F0B20A8D.8458880F.57F33CED.IP)
- # [20:28] * Quits: ehsan_ (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Ping timeout)
- # [20:41] * Joins: ehsan_ (ehsan@F0B20A8D.8458880F.57F33CED.IP)
- # [21:01] * Quits: ehsan_ (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Input/output error)
- # [21:02] * Joins: ehsan_ (ehsan@F0B20A8D.8458880F.57F33CED.IP)
- # [21:04] * Quits: ehsan_ (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Ping timeout)
- # [21:05] * Joins: ehsan_ (ehsan@F0B20A8D.8458880F.57F33CED.IP)
- # [21:06] * Quits: ehsan_ (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Input/output error)
- # [21:12] * Joins: ehsan_ (ehsan@F0B20A8D.8458880F.57F33CED.IP)
- # [21:12] * Quits: ehsan_ (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Input/output error)
- # [21:13] * Joins: jhk_ (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [21:14] * khuey|away is now known as khuey
- # [21:21] * Joins: ehsan_ (ehsan@F0B20A8D.8458880F.57F33CED.IP)
- # [21:22] * Quits: ehsan_ (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Input/output error)
- # [21:34] * bwinton_away is now known as bwinton
- # [21:47] * Quits: jhk_ (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [21:49] * bwinton is now known as bwinton_away
- # [22:57] * Quits: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Input/output error)
- # [23:37] * Quits: peteb-away (ptbrunet@moz-4B8864B.austin.res.rr.com) (Client exited)
- # Session Close: Sun Dec 11 00:00:00 2011
The end :)