/irc-logs / mozilla / #accessibility / 2011-12-10 / end

Options:

  1. # Session Start: Sat Dec 10 00:00:00 2011
  2. # Session Ident: #accessibility
  3. # [00:02] * bwinton is now known as bwinton_away
  4. # [00:04] * Quits: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP) (Ping timeout)
  5. # [00:08] * Joins: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP)
  6. # [00:15] * Quits: Mana (Mana@moz-9745CC7.adsl.alicedsl.de) (Quit: Verlassend)
  7. # [00:32] * Quits: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP) (Ping timeout)
  8. # [00:33] <firebot> hub@mozilla.com changed the Status on bug 510024 from NEW to RESOLVED.
  9. # [00:33] <firebot> hub@mozilla.com set the Resolution field on bug 510024 to INVALID.
  10. # [00:33] <firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=510024 nor, --, ---, nobody, RESO INVALID, Remove unnecessary casts in nsAccessibleWrap.mm
  11. # [00:38] * Joins: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP)
  12. # [00:54] * Quits: ehsan (ehsan@F2D29657.F60B0462.67AC9B1.IP) (Connection reset by peer)
  13. # [00:58] * Quits: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP) (Ping timeout)
  14. # [01:05] * Joins: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP)
  15. # [01:07] * khuey is now known as khuey|away
  16. # [01:19] * khuey|away is now known as khuey
  17. # [01:19] * Joins: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP)
  18. # [01:20] * Quits: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP) (Ping timeout)
  19. # [01:26] * Joins: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP)
  20. # [01:41] * Quits: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com) (Quit: nhirata)
  21. # [01:46] * Joins: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com)
  22. # [01:49] * Quits: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Input/output error)
  23. # [02:13] * Quits: @hub (hub@21B7B9F2.B87E9213.6E712CE2.IP) (Ping timeout)
  24. # [02:34] * Joins: sye (sye@moz-74427DD7.fbx.proxad.net)
  25. # [02:35] * Parts: sye (sye@moz-74427DD7.fbx.proxad.net) (Quitte)
  26. # [02:48] * Quits: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP) (Ping timeout)
  27. # [02:48] * Joins: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP)
  28. # [03:02] * Quits: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com) (Quit: nhirata)
  29. # [03:11] * Quits: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP) (Ping timeout)
  30. # [03:17] * Joins: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP)
  31. # [03:48] * Quits: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP) (Ping timeout)
  32. # [03:54] * Joins: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP)
  33. # [04:07] * khuey is now known as khuey|away
  34. # [04:11] * Quits: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP) (Ping timeout)
  35. # [04:17] * Joins: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP)
  36. # [04:25] * Quits: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP) (Ping timeout)
  37. # [04:26] * khuey|away is now known as khuey
  38. # [04:31] * Joins: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP)
  39. # [04:50] * Quits: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP) (Ping timeout)
  40. # [04:51] * Joins: svg-newbie (Mibbit@moz-16D8AADC.hsd1.mi.comcast.net)
  41. # [04:51] * Parts: svg-newbie (Mibbit@moz-16D8AADC.hsd1.mi.comcast.net)
  42. # [04:56] * Joins: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP)
  43. # [06:08] * khuey is now known as khuey|away
  44. # [08:26] * Joins: jhk_ (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
  45. # [08:40] * Quits: jhk_ (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
  46. # [09:03] * Quits: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP) (Ping timeout)
  47. # [09:05] * Joins: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP)
  48. # [10:25] * Joins: jhk_ (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
  49. # [11:27] * Quits: jhk_ (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
  50. # [11:31] * Joins: jhk_ (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
  51. # [12:35] <firebot> trev.saunders@gmail.com cancelled review?(surkov.alexander@gm ail.com) for attachment 553784 on bug 648265.
  52. # [12:35] <firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=648265 nor, --, ---, trev.saunders, NEW, provide dexcomed table interface version
  53. # [12:42] * khuey|away is now known as khuey
  54. # [12:43] <@tbsaunde|afk> jhk_: I'm going through your last patch for bug 673689 around?
  55. # [12:43] <firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=673689 nor, --, ---, jigneshhk1992, NEW, introduce namespace role
  56. # [12:43] * tbsaunde|afk is now known as tbsaunde
  57. # [12:44] <jhk_> tbsaunde: yeah
  58. # [12:44] <@tbsaunde> jhk_: so, first in atk/nsMaiInterfaceTable.cpp there's two calls to nsAccUtils::ROle() you should keep comparing against xpcom roles there
  59. # [12:46] <@tbsaunde> jhk_: then in atk/nsMaiInterfaceText.cpp there is Role atkRole = atkRoleMap[accessible->NativeRole()] that should stay PRUint32
  60. # [12:47] * Joins: Flyingmana (Mana@moz-9745CC7.adsl.alicedsl.de)
  61. # [12:47] <@tbsaunde> the purpose of that array is to convert elements of the enum role to the atk roles, so there's no reason to believe an element of the array is an element of the roles enum
  62. # [12:51] <@tbsaunde> jhk_: next, atkRoleMap is defined as static const PRUint32 it shouldn't be static, and the type should be AtkRole (you didn't change it, just something to clean up along the way)
  63. # [12:53] <jhk_> which file?
  64. # [12:53] <@tbsaunde> next thing, in base/AccGroupInfo.cpp you didn't fixthe order of includes
  65. # [12:53] <@tbsaunde> atk/nsRoleMap.h
  66. # [12:53] <jhk_> okay
  67. # [12:56] <@tbsaunde> jhk_: again in AccGroupInfo.cpp near line 132 the if should fit on one line
  68. # [12:59] <jhk_> All done upto last comment.
  69. # [13:01] <@tbsaunde> jhk_: ok, then in AccGrouPInfo::IsConceptualParent() it looks like some of those ifs could take a line less
  70. # [13:02] <jhk_> ya I was thinking same thing
  71. # [13:04] <@tbsaunde> jhk_: maybe AccGroupInfo::BaseRole() too
  72. # [13:05] <@tbsaunde> jhk_: in base/NotificationController.cpp you didn't fix include ordering
  73. # [13:07] <@tbsaunde> jhk_: then in ROles.h leave a blank line after the brace for the end of role namespace
  74. # [13:11] <@tbsaunde> jhk_: then in nsARIAGridAccessible.cpp in SetARIASelected() the if with three role checks and the one testing nsAccUtils::IsARIASelected()
  75. # [13:13] <@tbsaunde> then again nsARIAGridCellAccessible::GetTable()
  76. # [13:14] <@tbsaunde> and GetColumnIndex()
  77. # [13:17] <@tbsaunde> nsARIAGridCellAccessible::GetAttributesInternal() second if
  78. # [13:18] <@tbsaunde> and the third
  79. # [13:21] <jhk_> done
  80. # [13:23] <@tbsaunde> ok, thanks, a lot of this just looks good :)
  81. # [13:25] <jhk_> tbsaunde : Uploading latest patch in min.
  82. # [13:26] <@tbsaunde> jhk_: I still have more comments for the rest of this one so hold on :)
  83. # [13:26] <jhk_> ok
  84. # [13:26] <@tbsaunde> jhk_: in nsAccessibilityService.cpp 1087 the if should fit on one line
  85. # [13:27] <@tbsaunde> jhk_: did you find the other bugs I talked about yesterday?
  86. # [13:28] <@tbsaunde> again line 1138
  87. # [13:29] <jhk_> Is that about Bug 539683
  88. # [13:29] <firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=539683 nor, --, ---, nobody, NEW, defunct object methods should return CO_E_OBJECTNOTCONNECTED
  89. # [13:30] <@tbsaunde> jhk_: it would be great if you fixed that one yup
  90. # [13:31] <jhk_> not sure if I can do that. but will try.
  91. # [13:31] <@tbsaunde> jhk_: ok :) I'll help if you have questions
  92. # [13:32] <@tbsaunde> jhk_: nsAccessible::GetRole() should take a PRUint32* not a Role* because its xpcom method
  93. # [13:33] * Quits: jhk_ (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
  94. # [13:33] <@tbsaunde> also don't change what *aRole is initially set to in that method
  95. # [13:33] * Joins: jhk_ (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
  96. # [13:38] <@tbsaunde> jhk_: just before you dropped out
  97. # [13:38] <@tbsaunde> jhk_: nsAccessible::GetRole() should take a PRUint32* not a Role* because its xpcom method and shouldn't use role::foo
  98. # [13:39] <jhk_> ya I got that. in nsaccessiblityservice.cpp there are 2 if of which we can't get rid of . crossing 80 limits
  99. # [13:39] <jhk_> line 1138
  100. # [13:41] <@tbsaunde> jhk_: ok, I though we might be able to but ok
  101. # [13:41] <@tbsaunde> thx
  102. # [13:42] * Quits: victorporof (victorporo@DCE93940.AB163232.79933D60.IP) (Quit: victorporof)
  103. # [13:43] <@tbsaunde> jhk_: nsAccessible::NativeRole() fits on one line right?
  104. # [13:44] <jhk_> ya
  105. # [13:48] <@tbsaunde> jhk_: for bug 539683 if you don't have a windows machine to build on I can look for other bugs, we have a bunch
  106. # [13:48] <firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=539683 nor, --, ---, nobody, NEW, defunct object methods should return CO_E_OBJECTNOTCONNECTED
  107. # [13:48] <jhk_> others will be good.
  108. # [13:49] <jhk_> not using windows.
  109. # [13:53] <@tbsaunde> jhk_: ok, me too
  110. # [14:00] <jhk_> tbsaunde : review done?
  111. # [14:02] <@tbsaunde> jhk_: no, went off to find you bugs :)
  112. # [14:02] <@tbsaunde> jhk_: how about bug 539694?
  113. # [14:03] <firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=539694 nor, --, ---, nobody, NEW, accessible objects should have private copy constructor
  114. # [14:03] <@tbsaunde> or bug 706134
  115. # [14:03] <firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=706134 nor, --, ---, nobody, NEW, ARIA listitem shouldn't expose selectable state and pick up aria-selected and aria-checked
  116. # [14:04] <@tbsaunde> jhk_: or bug 689540 isn't really windows only
  117. # [14:04] <firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=689540 nor, P3, ---, nobody, NEW, Expose IA2 margin- object attributes
  118. # [14:06] <jhk_> picking 2nd for now.
  119. # [14:06] <jhk_> ;)
  120. # [14:06] <@tbsaunde> ok :)
  121. # [14:06] <jhk_> after that 539694
  122. # [14:07] <@tbsaunde> jhk_: sorry, its a really long patch :)
  123. # [14:07] <@tbsaunde> the roles one I mean
  124. # [14:08] <jhk_> no prob. any way I was learning.
  125. # [14:09] <@tbsaunde> jhk_: nsDocAccessible::MaybeNotifyOfValueChange() that if should fit on one line
  126. # [14:11] <@tbsaunde> jhk_: in base/nsFormControlAccessible.cpp the order of the headers should be nsFormControlAccessible.h blank line Roles.h blank line other headers
  127. # [14:15] <jhk_> I think in previous files we used same. this one need only order change i guess
  128. # [14:16] <@tbsaunde> jhk_: in nsTextAccessible.cpp put a blank line between the two includes
  129. # [14:16] <@tbsaunde> the include for that files header should be seperate from the general a11y headers
  130. # [14:17] <jhk_> so states.h and role.h will together
  131. # [14:18] <@tbsaunde> yes
  132. # [14:19] <@tbsaunde> html/nsHTMLCanvasAccessible.cpp too
  133. # [14:19] <jhk_> all files have states.h with other includes. so I have to modify all of them
  134. # [14:21] <@tbsaunde> well, if states.h is in a weird spot now we can fix that later
  135. # [14:22] <jhk_> ok
  136. # [14:22] <@tbsaunde> in nsHTMLTextFieldAccessible::NativeRole() remove the braces around the if but leave a blank line
  137. # [14:28] <@tbsaunde> jhk_: nsHTMLLinkAccessible::NativeRole() you should change to return role::LINK
  138. # [14:36] <@tbsaunde> jhk_: nsHTMLTableAccessible::IsProbablyForLayout() don't brace the if
  139. # [15:00] * khuey is now known as khuey|away
  140. # [15:04] <@tbsaunde> jhk_: either don't change nsXULButtonAccessible::ContainerWIdget() or change it to be return x ? mParent : nsnull;
  141. # [15:05] <@tbsaunde> actually, no forget that
  142. # [15:12] <@tbsaunde> jhk_: the if in nsXULListCellAccessible::GetColumnIndex() could take fewer lines :)
  143. # [15:13] * khuey|away is now known as khuey
  144. # [15:21] <@tbsaunde> jhk_: you didn't change what nsXULTabAccessible::NativeRole() returns
  145. # [15:22] <@tbsaunde> nsXULTabsAccessible and nsXULTabPannelAccessible too
  146. # [15:23] <@tbsaunde> I think its just all the ones in that file :)
  147. # [15:26] <@tbsaunde> jhk_: in nsXULTreeAccessible::NativeRole() there's no reason to have () around role::foo
  148. # [15:27] <@tbsaunde> same for nsXULTreeItemAccessible
  149. # [15:30] <@tbsaunde> jhk_: nsXULTreeGridAccessible::NativeRole() too
  150. # [15:30] <@tbsaunde> and that's it, thanks!
  151. # [15:30] <@tbsaunde> stuff already looks a lot nicer :)
  152. # [15:31] <jhk_> yup that's it :) thanks!
  153. # [15:33] <@tbsaunde> jhk_: yw! thanks for doing it
  154. # [15:36] * Quits: jhk_ (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
  155. # [15:38] * Joins: jhk_ (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
  156. # [15:41] <firebot> jigneshhk1992@gmail.com cancelled review?(surkov.alexander@gm ail.com) for attachment 580381 on bug 673689.
  157. # [15:41] <firebot> jigneshhk1992@gmail.com requested review from surkov.alexander@gm ail.com for attachment 580645 on bug 673689.
  158. # [15:41] <firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=673689 nor, --, ---, jigneshhk1992, NEW, introduce namespace role
  159. # [15:42] * Quits: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com) (Client exited)
  160. # Session Close: Sat Dec 10 16:01:33 2011
  161. #
  162. # Session Start: Sat Dec 10 16:01:33 2011
  163. # Session Ident: #accessibility
  164. # [16:01] * Disconnected
  165. # [16:02] * Attempting to rejoin channel #accessibility
  166. # [16:02] * Rejoined channel #accessibility
  167. # [16:02] * Topic is '"build the web for everyone" | release schedule: http://mzl.la/LNc0W'
  168. # [16:02] * Set by davidb on Thu Dec 08 15:12:17
  169. # [16:28] * Joins: peteb-away (ptbrunet@moz-4B8864B.austin.res.rr.com)
  170. # [16:36] <@tbsaunde> jhk_: does that patch build locally for you? if so I think its time we see if the tryserver has any problems with
  171. # [16:37] <jhk_> lets tryserver do it.
  172. # [16:37] <@tbsaunde> huh?
  173. # [16:39] <jhk_> you can just check it.
  174. # [16:40] <jhk_> If there is not conflicts
  175. # [16:43] * Joins: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP)
  176. # [16:43] <jhk_> tbsaunde : btw , how you check the code that is working , runs properly or not. any tools for that.
  177. # [16:44] <jhk_> accessibility one.
  178. # [16:47] <@tbsaunde> I'm not sure I understand what your asking about
  179. # [16:49] <@tbsaunde> do you mean our code?
  180. # [16:49] <jhk_> ya
  181. # [16:49] * Quits: Flyingmana (Mana@moz-9745CC7.adsl.alicedsl.de) (Ping timeout)
  182. # [16:50] * Joins: Flyingmana (Mana@moz-9745CC7.adsl.alicedsl.de)
  183. # [16:50] <@tbsaunde> we have a bunch of tests in accessible/tests
  184. # [16:50] <jhk_> oh ok
  185. # [16:50] <jhk_> thats what i am asking for
  186. # [16:50] <@tbsaunde> you run them with make mochitest-a11y
  187. # [16:52] <jhk_> It will take 2 hrs more. just downloaded new source. I have changed other stuff too.
  188. # [16:52] <jhk_> Is it working with you.
  189. # [16:52] <jhk_> that patch.
  190. # [16:55] <@tbsaunde> jhk_: building now
  191. # [17:02] <@tbsaunde> jhk_: some how you had . instead of , for a couple of the roles in Role.h
  192. # [17:03] <jhk_> mean?
  193. # [17:04] <@tbsaunde> you had list = 33. which isn't valid, it should be list = 33,
  194. # [17:04] <jhk_> oh its upto 44
  195. # [17:05] <jhk_> 45
  196. # [17:05] <jhk_> sorry!
  197. # [17:05] <@tbsaunde> np
  198. # [17:15] <jhk_> any this else pop out?
  199. # [17:15] <@tbsaunde> what?
  200. # [17:16] <jhk_> any other fault
  201. # [17:17] <jhk_> I think there shouldn't be any more . we have manually checked out all the things.
  202. # [17:19] <@tbsaunde> there's an issue with nsAccessible not being in the mozilla::a11y namespace that I'm playing with now
  203. # [17:39] * Quits: jhk_ (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
  204. # [17:55] * Joins: Flyingmana_ (Mana@moz-838D21EC.adsl.alicedsl.de)
  205. # [17:56] * Quits: Flyingmana (Mana@moz-9745CC7.adsl.alicedsl.de) (Ping timeout)
  206. # [17:57] * Joins: jhk_ (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
  207. # [19:02] * Quits: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP) (Ping timeout)
  208. # [19:08] * Joins: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP)
  209. # [19:21] * iamjessklein-away is now known as jess
  210. # [19:23] * jess is now known as iamjessklein-away
  211. # [19:31] * khuey is now known as khuey|away
  212. # [19:51] * Quits: jhk_ (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
  213. # [20:18] * Joins: ehsan_ (ehsan@F0B20A8D.8458880F.57F33CED.IP)
  214. # [20:25] * Quits: ehsan_ (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Ping timeout)
  215. # [20:27] * Joins: ehsan_ (ehsan@F0B20A8D.8458880F.57F33CED.IP)
  216. # [20:28] * Quits: ehsan_ (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Ping timeout)
  217. # [20:41] * Joins: ehsan_ (ehsan@F0B20A8D.8458880F.57F33CED.IP)
  218. # [21:01] * Quits: ehsan_ (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Input/output error)
  219. # [21:02] * Joins: ehsan_ (ehsan@F0B20A8D.8458880F.57F33CED.IP)
  220. # [21:04] * Quits: ehsan_ (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Ping timeout)
  221. # [21:05] * Joins: ehsan_ (ehsan@F0B20A8D.8458880F.57F33CED.IP)
  222. # [21:06] * Quits: ehsan_ (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Input/output error)
  223. # [21:12] * Joins: ehsan_ (ehsan@F0B20A8D.8458880F.57F33CED.IP)
  224. # [21:12] * Quits: ehsan_ (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Input/output error)
  225. # [21:13] * Joins: jhk_ (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
  226. # [21:14] * khuey|away is now known as khuey
  227. # [21:21] * Joins: ehsan_ (ehsan@F0B20A8D.8458880F.57F33CED.IP)
  228. # [21:22] * Quits: ehsan_ (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Input/output error)
  229. # [21:34] * bwinton_away is now known as bwinton
  230. # [21:47] * Quits: jhk_ (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
  231. # [21:49] * bwinton is now known as bwinton_away
  232. # [22:57] * Quits: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Input/output error)
  233. # [23:37] * Quits: peteb-away (ptbrunet@moz-4B8864B.austin.res.rr.com) (Client exited)
  234. # Session Close: Sun Dec 11 00:00:00 2011

The end :)