/irc-logs / mozilla / #accessibility / 2011-12-27 / end
Options:
- # Session Start: Tue Dec 27 00:00:00 2011
- # Session Ident: #accessibility
- # [01:01] * Quits: nhirata (nhirata.bu@moz-2A9C9106.hsd1.ca.comcast.net) (Quit: nhirata)
- # [01:04] * Joins: nhirata (nhirata.bu@moz-2A9C9106.hsd1.ca.comcast.net)
- # [01:18] * khuey is now known as khuey|away
- # [01:20] * khuey|away is now known as khuey
- # [01:54] * Joins: mdcurran (mick@moz-C48DC1F2.static.tpgi.com.au)
- # [02:26] * Quits: Hixie (ianh@moz-E9FB2A6A.no) (Quit: leaving)
- # [02:26] * Joins: Hixie (ianh@moz-E9FB2A6A.no)
- # [02:30] * Quits: Hixie (ianh@moz-E9FB2A6A.no) (Quit: leaving)
- # [02:33] * Joins: Hixie (ianh@moz-E9FB2A6A.no)
- # [06:42] * khuey is now known as khuey|away
- # [06:53] <@firebot> johan.charlez@gmail.com cancelled feedback?(gavin.sharp@gmail .com) for attachment 584346 on bug 713052.
- # [06:53] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=713052 nor, --, ---, nobody, UNCO, Add preference for disabling ALT-clicks to save links.
- # [09:56] * Quits: @hub (hub@83874EA1.EB7C1AF9.6F478678.IP) (Ping timeout)
- # [10:32] * nhirata is now known as nhirata|zZz
- # [12:05] * Joins: victorporof (victorporo@moz-801CDEAC.botosani.city-net.ro)
- # [13:48] * Quits: victorporof (victorporo@moz-801CDEAC.botosani.city-net.ro) (Quit: victorporof)
- # [14:08] * khuey|away is now known as khuey
- # [14:31] * Quits: mdcurran (mick@moz-C48DC1F2.static.tpgi.com.au) (Ping timeout)
- # [17:12] * Quits: nhirata|zZz (nhirata.bu@moz-2A9C9106.hsd1.ca.comcast.net) (Quit: nhirata|zZz)
- # [18:10] * Joins: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com)
- # [18:24] * Quits: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com) (Connection reset by peer)
- # [18:25] * Joins: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com)
- # [18:38] * Joins: victorporof (victorporo@moz-801CDEAC.botosani.city-net.ro)
- # [19:07] <@eeejay> tbsaunde, thanks for the review, i'll get to it now.
- # [19:10] <@tbsaunde> eeejay: yw, sorry it took a while
- # [19:13] <@eeejay> tbsaunde, what do you mean by vim line? isn't the line with the tab width, etc. a vim line?
- # [19:13] <@tbsaunde> eeejay: there's one for emacs, and one for vim
- # [19:14] <@eeejay> oh
- # [19:14] <@tbsaunde> eeejay: see either the style guide for gecko, or say atk/nsAccessibleWrap.cpp
- # [19:15] <@eeejay> tbsaunde, ah, gotcha. looks like none of the idls have it
- # [19:16] <@tbsaunde> eeejay: wouldn't suprise me :/
- # [19:16] <@tbsaunde> all the files accept atk/ are a mess of having one or none or both
- # [19:34] * Joins: hub (hub@83874EA1.EB7C1AF9.6F478678.IP)
- # [19:34] * ChanServ sets mode: +o hub
- # [19:40] * Quits: victorporof (victorporo@moz-801CDEAC.botosani.city-net.ro) (Quit: victorporof)
- # [20:23] * Quits: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com) (Quit: nhirata)
- # [20:25] * Joins: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com)
- # [20:40] * Quits: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com) (Quit: nhirata)
- # [20:50] * Joins: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com)
- # [22:24] <@eeejay> hey tbsaunde, you around?
- # [22:26] <@tbsaunde> eeejay: yo, yeah
- # [22:26] <@eeejay> tbsaunde, somewhere in your review you point to where an opject could get freed before we are done with it, and you offer an alternative
- # [22:27] <@eeejay> tbsaunde, wouldn't it be enough to use nsRefPtr, so it would automatically increase and decrease the refcount?
- # [22:28] <@tbsaunde> eeejay: that works
- # [22:28] <@eeejay> tbsaunde, cool
- # [22:28] <@eeejay> tbsaunde, i never heard of forget() before
- # [22:28] <@tbsaunde> eeejay: but AddRef / Release on xpcom objects are virtual, so you generally want to avoid calling them when you don't need to
- # [22:29] <@eeejay> tbsaunde, gotcha
- # [22:29] <@tbsaunde> eeejay: if you work with this stuff a bit it becomes worth reading nsAutoPtr / nsCOMptr .h
- # [22:30] <@eeejay> cool
- # [22:31] <@eeejay> tbsaunde, ok. good point. it is unfortuante that a really simple swap needs so much dancing
- # [22:33] <@tbsaunde> eeejay: as I said .swap might work for you
- # [22:33] <@tbsaunde> but I'm not sure how to name things recently
- # [22:33] <@tbsaunde> err, reasonably
- # [22:34] <@tbsaunde> also, welcome to xpcom :\
- # [22:45] <@eeejay> didn't read any code, but it is also curios that release() etc. are virtual as opposed to the actual free method, since release() just needs to decrement an integer.
- # [22:51] <@tbsaunde> eeejay: well, it might do more or less than that
- # [22:51] * Quits: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com) (Quit: nhirata)
- # [22:52] <@tbsaunde> eeejay: it sort of makes sense, but it is also sort of silly
- # [22:52] <@eeejay> tbsaunde, i got this fat xpcom book here i haven't read yet
- # [22:53] <@eeejay> maybe i should get educated
- # [22:54] <@tbsaunde> eeejay: is there a book O>O
- # [22:54] <@tbsaunde> O.O even
- # [22:54] <@eeejay> tbsaunde, interested? lemme find a link
- # [22:54] <@tbsaunde> in any case its pretty much MS COM which I'm sure there are books for
- # [22:55] <@tbsaunde> eeejay: why not? :)
- # [22:55] <@eeejay> yeah, that is what i mean
- # [22:55] <@eeejay> Essential Com by Don Box
- # [22:55] <@eeejay> http://www.amazon.com/exec/obidos/ASIN/0201634465
- # [22:56] <@tbsaunde> thx
- # [22:58] * Joins: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com)
- # [22:58] <@tbsaunde> eeejay: fwiw I've learned what I know by reading stuff from xpcom/ and our code
- # [22:59] <@eeejay> tbsaunde, yeah. probably easiest
- # [22:59] <@tbsaunde> I'll also gues there are large parts of that book that aren't very useful like remote COM unless you want to start helping with windows :)
- # [23:02] <@eeejay> tbsaunde, no, it's ok!
- # [23:05] <@tbsaunde> eeejay: heh
- # Session Close: Wed Dec 28 00:00:00 2011
The end :)