/irc-logs / mozilla / #accessibility / 2012-01-10 / end
Options:
- # Session Start: Tue Jan 10 00:00:02 2012
- # Session Ident: #accessibility
- # [00:17] * Quits: @jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP) (Ping timeout)
- # [00:41] * Joins: jprmc (jprmc@CAC64D5C.5BCEC6DB.DA78B690.IP)
- # [00:41] * ChanServ sets mode: +o jprmc
- # [01:20] * Quits: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp) (Quit: mike5w3c)
- # [01:23] * Quits: Flyingmana (Mana@moz-D2AB1C0E.adsl.alicedsl.de) (Ping timeout)
- # [01:23] * Quits: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com) (Quit: nhirata)
- # [01:25] * Joins: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com)
- # [01:34] * Quits: ehsan (ehsan@F2D29657.F60B0462.67AC9B1.IP) (Input/output error)
- # [01:54] * Quits: @jprmc (jprmc@CAC64D5C.5BCEC6DB.DA78B690.IP) (Ping timeout)
- # [02:09] * Joins: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp)
- # [02:16] * Quits: @davidb (davidb@moz-5E2C9899.eng.wind.ca) (Ping timeout)
- # [02:18] * Joins: ehsan (ehsan@moz-7D6E2170.cpe.net.cable.rogers.com)
- # [02:30] * Quits: ehsan (ehsan@moz-7D6E2170.cpe.net.cable.rogers.com) (Input/output error)
- # [02:51] * Quits: silvia (Adium@13A1E76C.497EC1B8.5EFB9497.IP) (Quit: Leaving.)
- # [03:10] * Joins: silvia (Adium@13A1E76C.497EC1B8.5EFB9497.IP)
- # [03:12] * Quits: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com) (Quit: nhirata)
- # [03:55] * Joins: Jamie (jamie@moz-CA26021.jantrid.net)
- # [03:56] * Quits: @hub (hub@21B7B9F2.B87E9213.6E712CE2.IP) (Input/output error)
- # [04:18] * Joins: hub (hub@moz-E2FCA694.figuiere.net)
- # [04:18] * ChanServ sets mode: +o hub
- # [04:19] * Quits: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp) (Quit: mike5w3c)
- # [04:30] * Joins: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp)
- # [05:15] * Quits: @hub (hub@moz-E2FCA694.figuiere.net) (Input/output error)
- # [05:37] * Quits: silvia (Adium@13A1E76C.497EC1B8.5EFB9497.IP) (Ping timeout)
- # [05:38] * Quits: Jamie (jamie@moz-CA26021.jantrid.net) (Connection reset by peer)
- # [05:38] * Joins: Jamie (jamie@moz-CA26021.jantrid.net)
- # [05:48] * Joins: silvia (Adium@13A1E76C.497EC1B8.5EFB9497.IP)
- # [06:21] * Quits: Jamie (jamie@moz-CA26021.jantrid.net) (Ping timeout)
- # [06:25] * Joins: Jamie (jamie@moz-CA26021.jantrid.net)
- # [06:35] * Quits: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp) (Quit: mike5w3c)
- # [07:07] * Quits: Jamie (jamie@moz-CA26021.jantrid.net) (Connection reset by peer)
- # [07:07] * Joins: Jamie (jamie@moz-CA26021.jantrid.net)
- # [07:07] * Joins: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp)
- # [07:10] * Quits: Jamie (jamie@moz-CA26021.jantrid.net) (Connection reset by peer)
- # [07:12] * Joins: Jamie (jamie@moz-CA26021.jantrid.net)
- # [07:18] * Quits: Jamie (jamie@moz-CA26021.jantrid.net) (Ping timeout)
- # [07:22] * Joins: Jamie (jamie@moz-CA26021.jantrid.net)
- # [07:45] * Joins: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP)
- # [07:47] * Quits: Jamie (jamie@moz-CA26021.jantrid.net) (Ping timeout)
- # [07:51] * Quits: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Input/output error)
- # [07:59] * Quits: @firebot (firebot@moz-67BF9FE6.carolina.res.rr.com) (Ping timeout)
- # [08:05] * Joins: MarcoZ (marco.zehe@moz-97ABA480.dip.t-dialin.net)
- # [08:05] * ChanServ sets mode: +o MarcoZ
- # [08:10] <@MarcoZ> Hi all!
- # [08:23] * Joins: firebot (firebot@moz-67BF9FE6.carolina.res.rr.com)
- # [08:23] * ChanServ sets mode: +o firebot
- # [08:23] * Quits: silvia (Adium@13A1E76C.497EC1B8.5EFB9497.IP) (Quit: Leaving.)
- # [08:56] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [09:24] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Ping timeout)
- # [09:31] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [09:32] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [09:33] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [09:38] * Joins: ender (ender@70FD65AB.A9EF973E.DA8F3662.IP)
- # [09:40] * Quits: ender (ender@70FD65AB.A9EF973E.DA8F3662.IP) (Quit: Leaving)
- # [10:22] * Quits: sgimeno (santiago.g@A922400D.48362F18.BCC03455.IP) (Client exited)
- # [10:27] * Joins: sgimeno (santiago.g@A922400D.48362F18.BCC03455.IP)
- # [10:31] * Joins: silvia (Adium@moz-7033BBBB.dyn.iinet.net.au)
- # [11:33] * Quits: @MarcoZ (marco.zehe@moz-97ABA480.dip.t-dialin.net) (Ping timeout)
- # [11:34] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [12:14] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [12:26] * khuey|away is now known as khuey
- # [12:36] * khuey is now known as khuey|away
- # [12:36] * khuey|away is now known as khuey
- # [13:12] * khuey is now known as khuey|away
- # [13:31] * khuey|away is now known as khuey
- # [14:03] * khuey is now known as khuey|away
- # [14:06] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [14:18] * khuey|away is now known as khuey
- # [14:28] * khuey is now known as khuey|away
- # [14:40] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [14:49] * Joins: jprmc (jprmc@moz-7F2FF3EB.cpe.net.cable.rogers.com)
- # [14:49] * ChanServ sets mode: +o jprmc
- # [15:00] * khuey|away is now known as khuey
- # [15:08] * Quits: silvia (Adium@moz-7033BBBB.dyn.iinet.net.au) (Quit: Leaving.)
- # [15:10] * Joins: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP)
- # [15:13] * Joins: davidb (davidb@F2D29657.F60B0462.67AC9B1.IP)
- # [15:13] * ChanServ sets mode: +qo davidb davidb
- # [15:15] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Ping timeout)
- # [15:15] * Joins: clown (clown@67828CC7.C1A51174.9D42CF23.IP)
- # [15:17] * Joins: askalski (akuda@moz-6A36EC49.ip.abpl.pl)
- # [15:21] * Joins: Flyingmana (Mana@moz-2B82660C.adsl.alicedsl.de)
- # [15:26] <askalski> hi, is it normal, that there has been no update in mozilla cental for a week?
- # [15:26] <askalski> is it like all the patches are applied in some kind of longer cycle I don'y know about
- # [15:26] <askalski> ?
- # [15:28] * Quits: askalski (akuda@moz-6A36EC49.ip.abpl.pl) (Quit: Wychodzi)
- # [15:37] * khuey is now known as khuey|away
- # [15:38] <@tbsaunde> epic comment is epic
- # [15:51] * Joins: MarcoZ (marco.zehe@moz-97ABA480.dip.t-dialin.net)
- # [15:51] * ChanServ sets mode: +o MarcoZ
- # [15:51] * Joins: askalski (akuda@moz-6A36EC49.ip.abpl.pl)
- # [15:52] <@tbsaunde> askalski: I'm about 100% sure stuff has landed on m-c every day this past week
- # [15:53] <@tbsaunde> askalski: if pull is say there's nothing new that's really odd
- # [16:05] <askalski> tbsaunde, : I just assumed that "update" is the same as in SVN, "hg pull" brings some news, thanks
- # [16:05] <askalski> tbsaunde: I really should catch up with hg :)
- # [16:07] <@tbsaunde> askalski: or git unless you hate yourself ;)
- # [16:14] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [16:14] <@MarcoZ> Hi all!
- # [16:16] <askalski> hi1
- # [16:21] <@davidb> hi hi hi
- # [16:22] <@MarcoZ> davidb: tbsaunde: askalski: Anything special you want on the agenda for tomorrow's meeting?
- # [16:23] <@davidb> perhaps chrome tests
- # [16:23] <@davidb> that's more round-table-ish
- # [16:25] <@MarcoZ> davidb: Yeah I was going to want to talk to you about that anyway, since you asked me directly.
- # [16:25] <@MarcoZ> https://wiki.mozilla.org/Accessibility/Meetings/2012-01-11
- # [16:25] <@MarcoZ> is the current version of the agenda.
- # [16:26] <@MarcoZ> davidb: I'm getting confused about the test harnesses we have. I thought we were doing browser chrome tests now. But that's 4 years ago that we created the harness, so I'm unsure about which of our various chrome or browser or whatever harnesses this is based on.
- # [16:27] <@davidb> oh I mean full browser tests, not just the lightweight chrome harness we have now
- # [16:27] <@davidb> so we'd be running firefox.
- # [16:27] <@davidb> I'm not sure of the lingo.
- # [16:30] * Quits: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com) (Ping timeout)
- # [16:30] * Quits: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Input/output error)
- # [16:34] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [16:34] * Joins: aaronlev (aaronlev@moz-CDA191A6.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com)
- # [16:34] * ChanServ sets mode: +o aaronlev
- # [16:36] * Joins: hub (hub@83874EA1.EB7C1AF9.6F478678.IP)
- # [16:36] * ChanServ sets mode: +o hub
- # [16:37] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [16:40] <@davidb> hi aaronlev
- # [16:40] <@davidb> hi hub
- # [16:40] <@davidb> all
- # [16:40] <@aaronlev> hi
- # [16:40] <@davidb> hey jhk
- # [16:40] <@hub> hi
- # [16:40] <@davidb> aaronlev: how's the google hacking going?
- # [16:40] <@tbsaunde> hmm, so if we kill nsIAccessNodethen what do we static cast this to in ISimpleDOMNode::get_localInterface()
- # [16:40] <jhk> devidb : Hi
- # [16:41] <@tbsaunde> hi
- # [16:41] <@aaronlev> it'll go well when i get focused
- # [16:41] <@davidb> aaronlev: ok, I won't ping you :)
- # [16:42] <@tbsaunde> is aaronlev at google now?
- # [16:42] <@aaronlev> i'm freelancing
- # [16:42] <@aaronlev> working on webkit at the moment
- # [16:42] <@aaronlev> davidb :) true true
- # [16:42] * khuey|away is now known as khuey
- # [16:43] <@davidb> tbsaunde: he's doing some work for them yeah
- # [16:44] <@MarcoZ> Hi aaronlev, hub!
- # [16:44] <@aaronlev> hi MarcoZ
- # [16:44] <@tbsaunde> ok, interesting
- # [16:46] <@davidb> it would be fantastic if this led to closer a11y behaviour across two decent browsers
- # [16:46] * khuey is now known as khuey|away
- # [16:49] <@MarcoZ> two or maybe even three, if the Webkit work also flows back to Safari.
- # [16:52] <@davidb> tbsaunde: before I change it to an early bail (bug 716589), are you sure that's what you prefer? The method is rather short and we'll end up with two return nsnull statements.
- # [16:53] <@aaronlev> MarcoZ: most of the iaccessible2 work is really in chromium, and i'm not sure if that will really change
- # [16:53] <@tbsaunde> davidb: I think so
- # [16:53] <@davidb> hokeydokey
- # [16:53] <@tbsaunde> davidb: its kind of silly I gues, but I really hate those nested ifs five levels deep
- # [16:54] <@davidb> this one is two i think
- # [16:54] <@davidb> oh right
- # [16:54] <@davidb> 4
- # [16:54] <@davidb> 3
- # [16:54] <@davidb> even
- # [16:54] <@davidb> i mean odd ;)
- # [16:55] * Joins: hhillen (hhillen@moz-81563C98.ip.telfort.nl)
- # [16:55] <@davidb> tbsaunde: if I add curly braces will that haunt you at night?
- # [16:55] * @davidb doesn't add them
- # [16:55] <@tbsaunde> why would you?
- # [16:55] <@tbsaunde> then you'd have
- # [16:55] <@tbsaunde> if (!foo) {
- # [16:56] <@tbsaunde> return nsnull;
- # [16:56] <@tbsaunde> }
- # [16:56] <@tbsaunde>
- # [16:56] <@tbsaunde> nsIBaz* baz = blah;
- # [16:56] <@MarcoZ> and a review nit from tbsaunde. :)
- # [16:56] <@MarcoZ> aaronlev: Ah I see!
- # [16:56] <@tbsaunde> and that's really silly
- # [16:57] <@tbsaunde> MarcoZ: huh?
- # [16:58] <@davidb> compiler warning: too many curly braces are silly!
- # [16:58] <@MarcoZ> tbsaunde: Curly braces around single line blocks. ;)
- # [16:58] <@MarcoZ> Sheesh, I really don't see how these tests work, in content/ for example. Some of them are in "unit" folders which look very different from our chrome tests.
- # [16:59] <@MarcoZ> And I don't see how we can make our tests work in that environment.
- # [16:59] <@davidb> tbsaunde: it is very subjective. if you always add curly braces your mind becomes trained to rely on them. it really requires less thought.
- # [16:59] <@davidb> but it isn't a battle I would fight
- # [17:00] <@tbsaunde> ok, I would have thought Alex already trained you out of that ;)
- # [17:01] <@davidb> lol, i did too much C++ in my formative years
- # [17:01] <@davidb> i tried to train Alex into it.
- # [17:01] <@davidb> that went well.
- # [17:01] <@tbsaunde> heh
- # [17:04] * @davidb warms his hands over his compiler
- # [17:04] <@davidb> hi hhillen
- # [17:04] <hhillen> hi davidb
- # [17:05] <@davidb> MarcoZ: i created one of those tests before.
- # [17:05] <@davidb> best to chat with dao or someone
- # [17:07] * khuey|away is now known as khuey
- # [17:07] <@davidb> MarcoZ: if we make it part of browser tests we'll want to make sure ours come at the end, since they invoke a11y
- # [17:07] <@davidb> or
- # [17:07] <@davidb> we could run the whole suite again with a11y on, and add ours
- # [17:08] <@davidb> i had a discussion about this on a bug
- # [17:08] * davidb is now known as davidb|mtg
- # [17:08] <@MarcoZ> davidb|mtg: That's why we kept them separate and created our own harness for them.
- # [17:09] <@davidb|mtg> maybe our harness should be FF
- # [17:09] <@MarcoZ> Maybe.
- # [17:09] <@MarcoZ> I don't know how much change that would require to all our existing tests, though.
- # [17:11] <@davidb|mtg> MarcoZ: who helped create our harness, was it clint?
- # [17:13] <@hub> C++ should have mandatory curly braces
- # [17:17] <@tbsaunde> hub: false :p
- # [17:17] <@MarcoZ> I agree with hub.
- # [17:17] <@MarcoZ> davidb|mtg: Robcee did help with that. Surkov did the impl, Robcee did the review.
- # [17:18] <@davidb|mtg> really!?
- # [17:18] * davidb|mtg is now known as davidb
- # [17:18] <@davidb> he's here in toronto
- # [17:18] <@davidb> this week
- # [17:18] <@MarcoZ> davidb: Yes, when i started, robcee was still working in QA doing test development.
- # [17:19] <@davidb> ok
- # [17:19] <@MarcoZ> davidb: I believe one of the reasons was that, for access to the accessibility APIs, we need elevated privileges.
- # [17:19] <@davidb> yes
- # [17:19] <@MarcoZ> davidb: That's why we didn't do regular browser tests because these can't access nsIAccessible.
- # [17:19] <@davidb> MarcoZ: I smell something like a Q1/Q2 goal.
- # [17:19] <@MarcoZ> davidb: If it is technically possible to do it....
- # [17:19] * Joins: ehsan (ehsan@F2D29657.F60B0462.67AC9B1.IP)
- # [17:20] <@davidb> it is software
- # [17:22] <@tbsaunde> I thought the point of at least one of mochitest-browser-chrome or mochitest-chrome was that it ran js as chrome code?
- # [17:23] <@davidb> probably
- # [17:24] <@MarcoZ> tbsaunde: Right. But for some tests, we need a "real" browser environment, and are not supposed to do it via xul:tabbrowser any more.
- # [17:25] <@MarcoZ> tbsauSee bug 715847 for the reason why we're discussing this.
- # [17:26] <@MarcoZ> tbsaunde: See bug 715847 why we're discussing this.
- # [17:29] <@tbsaunde> MarcoZ: yeah, I saw that before, I knew that part
- # [17:31] * @tbsaunde tends to take the atitude that people who want to change API's should fix all existing users in the tree
- # [17:31] <@tbsaunde> atleast if they want to get rid of the old one
- # [17:31] <@davidb> that is a fair position.
- # [17:32] <@davidb> In this case, there is no promise to users.
- # [17:32] <@tbsaunde> oh?
- # [17:32] <@davidb> yeah tabbrowser doesn't come with a warranty, sadly.
- # [17:33] <@davidb> we've had to do tacky things to get it to work in the past
- # [17:33] <@davidb> hacky
- # [17:33] <@tbsaunde> interesting, I certainly wasn't around when the tests where written assuming its behavior
- # [17:33] <@davidb> i came just after
- # [17:33] <@davidb> but in my time it has seen fragility.
- # [17:33] <@davidb> the cost has been non zero.
- # [17:34] <@tbsaunde> yeah
- # [17:34] <@davidb> if we can test a fuller browser i think that is a win
- # [17:35] <@tbsaunde> it doesn't seem like a really hard problem though, either we stick tests on the end of mochitest-browser-chrome or we use that setup in a seperate job to run our own tests
- # [17:35] <@davidb> ye;
- # [17:35] <@davidb> yep
- # [17:36] <@tbsaunde> it'll take work of course
- # [17:36] <@davidb> i had one running on the end of browser-chrome tests locally
- # [17:36] <@davidb> i called the test zzz-foo*
- # [17:37] <@davidb> so it showed up at the end
- # [17:37] <@davidb> that was 1000 years ago though
- # [17:37] <@davidb> i'll go bug spelunking later - hopefully i attached a patch somewhere
- # [17:40] <@tbsaunde> doesn't the list of directories / order of tests in Makefiles matter?
- # [17:40] * @tbsaunde recognizes neither of us is the one to ask
- # [17:41] <@davidb> yeah, not ready to go too active on this yet
- # [17:45] <@tbsaunde> davidb: wantto review a patch for bug 672507? I dropped the part Alex wasn't sure about
- # [17:45] <khuey> the order of the directories matters
- # [17:46] <khuey> the order of tests does not
- # [17:47] <@davidb> khuey: thanks
- # [17:47] <@davidb> tbsaunde: i want to, but not sure i have time to give it a proper review. go ahead and request in case i do.
- # [17:48] <@davidb> tbsaunde: unless you want me to review just a small part.
- # [17:55] <@tbsaunde> davidb: other than maybe getting Marco to review the trivial test changes I'm not sure who can be reasonably asked to do it :/
- # [17:55] <@davidb> go ahead - i'll try
- # [17:55] * davidb is now known as davidb|afk
- # [17:57] * khuey is now known as khuey|away
- # [18:04] * Joins: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com)
- # [18:04] * Quits: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com) (Input/output error)
- # [18:05] * Joins: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com)
- # [18:24] * Quits: @hub (hub@83874EA1.EB7C1AF9.6F478678.IP) (Input/output error)
- # [18:29] * Joins: richardschwerdtfeger (richardsch@moz-130F1494.lightspeed.austtx.sbcglobal.net)
- # [18:36] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [18:41] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [18:45] * Joins: hub (hub@21B7B9F2.B87E9213.6E712CE2.IP)
- # [18:45] * ChanServ sets mode: +o hub
- # [18:53] * Quits: hhillen (hhillen@moz-81563C98.ip.telfort.nl) (Quit: hhillen)
- # [19:01] * davidb|afk is now known as davidb
- # [19:07] * Quits: @aaronlev (aaronlev@moz-CDA191A6.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com) (Ping timeout)
- # [19:09] <@hub> tbsaunde: re bug 716935, accessibility isn't enabled by default on Mac, still
- # [19:09] <@hub> tbsaunde: that's part of my goals.
- # [19:09] <@davidb> hub: does the suite pass for you locally? i think the caret tests fail for me.
- # [19:09] <@hub> davidb: I don't run it
- # [19:09] <@tbsaunde> hub: yes, I know that to be the state for m-c, but we have in the past had the branch have a different config
- # [19:10] <@hub> davidb: I don't know how to run them
- # [19:10] <@davidb> i'm talking about make -C objdir/ mochitest-a11y
- # [19:10] <@davidb> it would be good to fix 'em
- # [19:10] <@davidb> even ifdef them out for MAC as a starting point
- # [19:10] <@tbsaunde> davidb: I re landed your disable tests, stuff was failing on debug before I did
- # [19:10] <@hub> let's try
- # [19:10] <@davidb> tbsaunde: oh good. when?
- # [19:10] <@davidb> hub: you can't touch your keyboard/mouse while they run
- # [19:11] <@davidb> or at least, no promises, if you do.
- # [19:11] <@tbsaunde> davidb: doesn't mac have xvfb?
- # [19:11] <@davidb> tbsaunde: i've not used it
- # [19:11] <@tbsaunde> davidb: one over the weekend, then one this morning when I realized that half didn't apply
- # [19:11] <@hub> davidb: so I can't IRC
- # [19:11] <@hub> and I can't say yes to the various alerts popping
- # [19:11] <@hub> :-(
- # [19:12] <@davidb> i believe this is so
- # [19:12] <@davidb> tbsaunde: ok thanks
- # [19:12] <@davidb> tbsaunde: where did you land them?
- # [19:12] <@tbsaunde> davidb: accessibility, which I'm thinking I'll merge to m-c today
- # [19:12] <@davidb> oh ok
- # [19:13] <@davidb> tbsaunde: i'm going to push my crash fix to inbound
- # [19:13] <@tbsaunde> go ahead
- # [19:13] <@hub> they don't pass
- # [19:14] <@tbsaunde> want to fix some of our random oranges now? ;)
- # [19:15] * Joins: aaronlev (aaronlev@moz-CDA191A6.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com)
- # [19:15] * ChanServ sets mode: +o aaronlev
- # [19:21] * Quits: @MarcoZ (marco.zehe@moz-97ABA480.dip.t-dialin.net) (Quit: l8er)
- # [19:32] * Joins: hhillen (hhillen@moz-2A42E9B3.upc-d.chello.nl)
- # [19:33] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Ping timeout)
- # [19:45] <@eeejay> davidb, hub, sorry!
- # [19:45] <@davidb> heheh
- # [19:56] <@hub> eeejay: it is free now
- # [20:10] * Quits: hhillen (hhillen@moz-2A42E9B3.upc-d.chello.nl) (Quit: hhillen)
- # [20:56] * Quits: askalski (akuda@moz-6A36EC49.ip.abpl.pl) (Ping timeout)
- # [20:57] * Joins: askalski (akuda@moz-6A36EC49.ip.abpl.pl)
- # [21:10] <@tbsaunde> davidb: it ==?
- # [21:34] <@davidb> tbsaunde: the a11y vidyo room
- # [21:34] <@davidb> we've been using it for some small quick meetings
- # [21:35] <@tbsaunde> oic
- # [21:42] * Quits: victorporof (victorporo@BCAA178E.F4308271.4873E54D.IP) (Quit: Leaving...)
- # [21:57] * Joins: silvia (Adium@moz-7033BBBB.dyn.iinet.net.au)
- # [22:02] * khuey|away is now known as khuey
- # [22:06] * Parts: clown (clown@67828CC7.C1A51174.9D42CF23.IP)
- # [22:06] <@davidb> 7 meetings down, 1 more to go! (but that's at my 9pm)
- # [22:06] <@davidb> oh 8.
- # [22:08] * @davidb beings patch review
- # [22:08] <@hub> davidb: ouch
- # [22:09] <@davidb> it is a price worth paying
- # [22:10] <@davidb> tbsaunde: has that patch addressed surkov's comments thus far?
- # [22:10] <@tbsaunde> davidb: I can give you more stuff to review if you want ;)
- # [22:10] <@davidb> bring it
- # [22:11] <@tbsaunde> davidb: iirc his main issue was that he didn't want to move non xpcom metods off nsAccessNode in that bug and I don't move any of them
- # [22:11] <@davidb> ok
- # [22:12] <@tbsaunde> but now that the interfaces are mreged I think its become pretty clear nsAccessNode should go
- # [22:12] * @davidb nods
- # [22:13] <@davidb> doesn't ISimpleDOM require it?
- # [22:13] <@davidb> (which should also go)
- # [22:15] <@tbsaunde> my proposal is to make ISimpleDOMNode a tearoff thing in the case the nsIContent* its for has an accessible
- # [22:15] <@tbsaunde> but it needs more tought
- # [22:16] <@tbsaunde> actually I think I did move one non xpcom method to nsAccessible because it was the easiest way to fix compiler confusion between a virtual function and a different non-virtual one
- # [22:16] * khuey is now known as khuey|away
- # [22:26] <@tbsaunde> yeah, there's a little bit of code that needs to be factored out, but I think puling ISimpleDOM off nAccessNode is fairly possible
- # [22:27] <@davidb> good
- # [22:29] <@tbsaunde> davidb: yeah, it'll be nice to make nsAccessible smaller
- # [22:30] <@davidb> tbsaunde: do you have about:memory on your plate?
- # [22:31] <@tbsaunde> no real plans there
- # [22:31] <@tbsaunde> you?
- # [22:32] <@davidb> no
- # [22:33] <@hub> there is that bug https://bugzilla.mozilla.org/show_bug.cgi?id=672504
- # [22:33] <@hub> but apparently it won't make it smaller
- # [22:35] <@tbsaunde> davidb: in any case I suspect the cache effects may be more important
- # [22:36] <@davidb> I can't believe it is 4:29pm EST
- # [22:40] <@davidb> ok have a good 1
- # [22:40] * Quits: @davidb (davidb@F2D29657.F60B0462.67AC9B1.IP) (Quit: davidb)
- # [22:54] <@hub> I still need a checkin for bug 714976
- # [23:02] * Joins: geo|pto (geo@moz-E31CD2CB.mozilla.org)
- # [23:02] * geo|pto is now known as geo
- # [23:07] <@tbsaunde> hub: weird, I thought edmorley wasdoing pretty regular checkin needed runs
- # [23:08] * Joins: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com)
- # [23:18] * Quits: @aaronlev (aaronlev@moz-CDA191A6.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com) (Quit: aaronlev)
- # [23:18] * Quits: askalski (akuda@moz-6A36EC49.ip.abpl.pl) (Quit: Wychodzi)
- # [23:18] * Joins: aaronlev (aaronlev@moz-CDA191A6.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com)
- # [23:18] * ChanServ sets mode: +o aaronlev
- # [23:24] * Quits: geo (geo@moz-E31CD2CB.mozilla.org) (Ping timeout)
- # [23:48] * Quits: @aaronlev (aaronlev@moz-CDA191A6.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com) (Quit: aaronlev)
- # Session Close: Wed Jan 11 00:00:01 2012
The end :)