/irc-logs / mozilla / #accessibility / 2012-01-12 / end

Options:

  1. # Session Start: Thu Jan 12 00:00:01 2012
  2. # Session Ident: #accessibility
  3. # [00:00] <@askalski> tbsaunde, I know I can force a precompiler to expand everything so I can see it
  4. # [00:00] <@tbsaunde> you have a list of macro invocations in a file FOO(quz, bar, baz)\nFOO(aaa, bb, cc)...
  5. # [00:01] <@tbsaunde> then, you defined that macro differently in a couple different places
  6. # [00:01] <@tbsaunde> see the files I mentioned as a real example of this
  7. # [00:01] <@tbsaunde> want to try doing the same thing with states?
  8. # [00:02] <@tbsaunde> see accessible/src/base/States.h accessible/atk/nsStateMap.h
  9. # [00:02] <@askalski> right now I'm looking for the files...
  10. # [00:02] <@tbsaunde> I'm not sure how much you can do on windows or macro, but you should be able to apply the same trick here.
  11. # [00:03] <@tbsaunde> *mac
  12. # [00:03] <@tbsaunde> I haven't filed a bug for that yet, but if someone is going to work on it I can
  13. # [00:04] <@askalski> still looking for the file. either eclipse does not reflect the file hierarchy (which would be weird, because what other hier would it follow?) or ...
  14. # [00:05] <@tbsaunde> which file?
  15. # [00:05] <@askalski> nsGkAtimList.h
  16. # [00:05] <@askalski> it's not in accessible, right?
  17. # [00:06] <@askalski> ok, content/base/src/
  18. # [00:06] <@askalski> got it
  19. # [00:06] <@tbsaunde> yeah, cool
  20. # [00:07] <@askalski> there is no nsGkAtomList.cpp, at least in that dir
  21. # [00:08] <@tbsaunde> no, there's never a AtomList.cpp oonly FooAtomList.h
  22. # [00:08] <@tbsaunde> it wouldn't make sense for there to be a cpp
  23. # [00:08] <@askalski> I got states.h, nsGkAtomList.h, nsGkAtoms.h and nsGkAtoms.cpp
  24. # [00:08] <@askalski> what should I look now on
  25. # [00:10] <@tbsaunde> see what nsGkAtomList.{h,cpp} do with the list, and consider how you could make States.h like nsGkAtomList.h
  26. # [00:14] <@askalski> ah, so you want to wrap the code from states.h into a macro, right?
  27. # [00:15] <@tbsaunde> yeah, the only thing it that header is constants though
  28. # [00:15] <@tbsaunde> so just wrap each constant
  29. # [00:16] <@askalski> into same macro, or write a new one?
  30. # [00:16] <@askalski> and why are there no comas/semicolons in nsGkAtomList.h?
  31. # [00:16] <@askalski> and what do you do to expand a macro
  32. # [00:16] <@askalski> (because eclipse failed with this one)
  33. # [00:17] <@tbsaunde> note that there are several definitions of that macro
  34. # [00:17] <@tbsaunde> so, the expansion depends on where you include it
  35. # [00:18] <@askalski> what worries me, is that I see no "include" in nsGkAtomList.h
  36. # [00:18] <@tbsaunde> you should add a new macro that does what we want
  37. # [00:18] <@askalski> ah I see
  38. # [00:18] <@askalski> it's included to nsGkAtoms.h instead
  39. # [00:18] <@tbsaunde> yup
  40. # [00:19] <@tbsaunde> probably more than one time too
  41. # [00:19] <@askalski> that brings the risk of including it using differnet macro definitions
  42. # [00:20] <@tbsaunde> there's no ',' or ';' in the list because it doesn't need to be valid C / C++ until the macro is expanded
  43. # [00:20] <@askalski> right, you're right
  44. # [00:20] <@askalski> ok. so I should write my own macro and turn "states.h" into a list of invocations of that macro, right?
  45. # [00:20] <@tbsaunde> yup
  46. # [00:20] <@askalski> OK
  47. # [00:21] <@tbsaunde> including it with different definitions of the macro is the point :)
  48. # [00:21] <@askalski> tbsaunde, the point you will have to tell me someday
  49. # [00:21] <@askalski> right now it's after midnight, and I think I should go to sleep
  50. # [00:21] <@askalski> and do macro tomorrow morning
  51. # [00:22] <@askalski> btw, should I call it the same way then?
  52. # [00:22] <@askalski> GK_ATOM?
  53. # [00:22] <@askalski> so you can re-use the list with different definitions?
  54. # [00:23] <@askalski> the macro I need to create
  55. # [00:24] <@tbsaunde> no, call it STATE()
  56. # [00:24] <@tbsaunde> yeah, you can reuse the list with multiple definitions
  57. # [00:24] <@tbsaunde> good night :)
  58. # [00:25] <@askalski> bye
  59. # [00:26] * Quits: @askalski (akuda@moz-6A36EC49.ip.abpl.pl) (Quit: Wychodzi)
  60. # [00:31] * Joins: Jamie (jamie@moz-CA26021.jantrid.net)
  61. # [00:49] * Joins: mike5w3c (MikeS@moz-C6ADF93D.pool.e-mobile.ne.jp)
  62. # [01:03] * khuey is now known as khuey|away
  63. # [01:03] * khuey|away is now known as khuey
  64. # [01:39] * Joins: geo (geo@moz-E31CD2CB.mozilla.org)
  65. # [01:41] * Joins: davidb (davidb@moz-6F9F653A.dsl.bell.ca)
  66. # [01:41] * ChanServ sets mode: +qo davidb davidb
  67. # [01:42] <@davidb> !seen Jamie
  68. # [01:42] <@firebot> jamie was last seen 5 weeks, 14 hours, 33 minutes and 28 seconds ago, saying 'this is breaking NVDA's command to get out of embedded objects' in #accessibility.
  69. # [01:46] <@tbsaunde> davidb: he's here :)
  70. # [01:46] <@davidb> doh!
  71. # [01:46] <@davidb> Jamie: ping
  72. # [01:46] <@tbsaunde> 18:25 -!- Jamie [jamie@moz-CA26021.jantrid.net] has joined #accessibility
  73. # [01:47] <@davidb> I though firebot would tell me that
  74. # [01:47] <@davidb> thanks
  75. # [01:47] <@tbsaunde> davidb: don't think firebot mentions the last time he someone join or quiet, not sure why though
  76. # [01:47] <@tbsaunde> yw
  77. # [01:51] * @davidb goes afk for about 30 mins
  78. # [01:51] * davidb is now known as davidb|afk
  79. # [01:52] * khuey is now known as khuey|away
  80. # [02:07] * Quits: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com) (Ping timeout)
  81. # [02:10] * Quits: mike5w3c (MikeS@moz-C6ADF93D.pool.e-mobile.ne.jp) (Quit: mike5w3c)
  82. # [02:20] * Quits: @jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP) (Ping timeout)
  83. # [02:24] * Quits: silvia (Adium@13A1E76C.497EC1B8.5EFB9497.IP) (Quit: Leaving.)
  84. # [02:32] * Quits: ehsan (ehsan@F2D29657.F60B0462.67AC9B1.IP) (Input/output error)
  85. # [02:40] * Quits: @aaronlev (aaronlev@moz-CDA191A6.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com) (Quit: aaronlev)
  86. # [02:44] * Joins: mike5w3c (MikeS@moz-C6ADF93D.pool.e-mobile.ne.jp)
  87. # [02:58] * Quits: geo (geo@moz-E31CD2CB.mozilla.org) (Ping timeout)
  88. # [02:59] * Quits: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com) (Quit: nhirata)
  89. # [03:03] * Quits: mike5w3c (MikeS@moz-C6ADF93D.pool.e-mobile.ne.jp) (Quit: mike5w3c)
  90. # [03:06] * Joins: mike5w3c (MikeS@moz-C6ADF93D.pool.e-mobile.ne.jp)
  91. # [03:06] <@davidb|afk> mdcurran: ping
  92. # [03:07] * davidb|afk is now known as davidb|mtg
  93. # [03:07] * Joins: jprmc (jprmc@767CBA65.5BCEC6DB.DA78B690.IP)
  94. # [03:07] * ChanServ sets mode: +o jprmc
  95. # [03:20] * Quits: mike5w3c (MikeS@moz-C6ADF93D.pool.e-mobile.ne.jp) (Ping timeout)
  96. # [03:21] * Joins: mike5w3c (MikeS@moz-8CBCDB87.pool.e-mobile.ne.jp)
  97. # [03:27] * Quits: @hub (hub@21B7B9F2.B87E9213.6E712CE2.IP) (Input/output error)
  98. # [03:28] * Joins: geo (geo@moz-E31CD2CB.mozilla.org)
  99. # [03:39] * Quits: @jprmc (jprmc@767CBA65.5BCEC6DB.DA78B690.IP) (Quit: Leaving)
  100. # [03:52] * Quits: mike5w3c (MikeS@moz-8CBCDB87.pool.e-mobile.ne.jp) (Quit: mike5w3c)
  101. # [03:53] * Joins: mike5w3c (MikeS@moz-8CBCDB87.pool.e-mobile.ne.jp)
  102. # [03:58] * Quits: @davidb|mtg (davidb@moz-6F9F653A.dsl.bell.ca) (Quit: davidb|mtg)
  103. # [03:59] * Quits: mike5w3c (MikeS@moz-8CBCDB87.pool.e-mobile.ne.jp) (Quit: mike5w3c)
  104. # [04:03] * Joins: mike5w3c (MikeS@moz-8CBCDB87.pool.e-mobile.ne.jp)
  105. # [04:16] * Quits: mike5w3c (MikeS@moz-8CBCDB87.pool.e-mobile.ne.jp) (Quit: mike5w3c)
  106. # [04:28] * Quits: geo (geo@moz-E31CD2CB.mozilla.org) (Ping timeout)
  107. # [04:29] * Joins: geo (geo@moz-E31CD2CB.mozilla.org)
  108. # [04:42] * Joins: mike5w3c (MikeS@moz-8CBCDB87.pool.e-mobile.ne.jp)
  109. # [04:49] * Quits: mike5w3c (MikeS@moz-8CBCDB87.pool.e-mobile.ne.jp) (Quit: mike5w3c)
  110. # [05:04] * Joins: mike5w3c (MikeS@moz-8CBCDB87.pool.e-mobile.ne.jp)
  111. # [05:05] * Joins: davidb (davidb@moz-6F9F653A.dsl.bell.ca)
  112. # [05:05] * ChanServ sets mode: +qo davidb davidb
  113. # [05:05] * Quits: @davidb (davidb@moz-6F9F653A.dsl.bell.ca) (Input/output error)
  114. # [05:09] * Quits: mike5w3c (MikeS@moz-8CBCDB87.pool.e-mobile.ne.jp) (Ping timeout)
  115. # [05:12] * Joins: mike5w3c (MikeS@moz-C83DBBEA.pool.e-mobile.ne.jp)
  116. # [05:20] * Joins: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com)
  117. # [05:26] * Joins: nhirata (nhirata.bu@moz-2A9C9106.hsd1.ca.comcast.net)
  118. # [05:58] * Quits: geo (geo@moz-E31CD2CB.mozilla.org) (Ping timeout)
  119. # [05:59] * Joins: geo (geo@moz-E31CD2CB.mozilla.org)
  120. # [06:09] * Quits: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com) (Ping timeout)
  121. # [06:25] * Joins: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com)
  122. # [06:41] * Quits: mike5w3c (MikeS@moz-C83DBBEA.pool.e-mobile.ne.jp) (Quit: mike5w3c)
  123. # [06:45] * Joins: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP)
  124. # [07:01] * Joins: silvia (Adium@moz-7033BBBB.dyn.iinet.net.au)
  125. # [07:17] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
  126. # [07:28] * Quits: geo (geo@moz-E31CD2CB.mozilla.org) (Ping timeout)
  127. # [07:29] * Joins: geo (geo@moz-E31CD2CB.mozilla.org)
  128. # [07:41] * Joins: mike5w3c (MikeS@CFBC9B55.FF60F7E5.7238942C.IP)
  129. # [07:57] * Quits: drexler (chatzilla@moz-2C2B7D1F.hsd1.vt.comcast.net) (Quit: ChatZilla 0.9.88 [Firefox 9.0.1/20111220165912])
  130. # [07:57] * Joins: victorporof (victorporo@BCAA178E.F4308271.4873E54D.IP)
  131. # [08:33] * Quits: victorporof (victorporo@BCAA178E.F4308271.4873E54D.IP) (Quit: Linkinus - http://linkinus.com)
  132. # [08:50] * Quits: Jamie (jamie@moz-CA26021.jantrid.net) (Quit: leaving)
  133. # [08:58] * Quits: geo (geo@moz-E31CD2CB.mozilla.org) (Ping timeout)
  134. # [09:00] * Joins: geo (geo@moz-E31CD2CB.mozilla.org)
  135. # [09:03] * khuey|away is now known as khuey
  136. # [09:07] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
  137. # [09:22] * Joins: sgimeno (santiago.g@A922400D.48362F18.BCC03455.IP)
  138. # [09:23] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
  139. # [10:15] * Quits: mike5w3c (MikeS@CFBC9B55.FF60F7E5.7238942C.IP) (Quit: mike5w3c)
  140. # [10:15] * Quits: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Input/output error)
  141. # [10:16] * Quits: sgimeno (santiago.g@A922400D.48362F18.BCC03455.IP) (Quit: KVIrc 4.0.2 Insomnia http://www.kvirc.net/)
  142. # [10:28] * Quits: geo (geo@moz-E31CD2CB.mozilla.org) (Ping timeout)
  143. # [10:29] * Joins: geo (geo@moz-E31CD2CB.mozilla.org)
  144. # [10:46] * Joins: MarcoZ (marco.zehe@moz-600A3C41.dip.t-dialin.net)
  145. # [10:46] * ChanServ sets mode: +o MarcoZ
  146. # [10:47] <@MarcoZ> Hi all!
  147. # [10:47] <@MarcoZ> Hi tbsaunde! Did you watch how the patch you landed fares on the Accessibility branch?
  148. # [10:56] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Ping timeout)
  149. # [11:20] * Quits: mdcurran (mick@moz-C48DC1F2.static.tpgi.com.au) (Quit: leaving)
  150. # [11:20] * Joins: mdcurran (mick@moz-C48DC1F2.static.tpgi.com.au)
  151. # [11:28] * Joins: Stevef (chatzilla@moz-FBEAB712.croy.cable.virginmedia.com)
  152. # [11:28] <Stevef> morning all
  153. # [11:31] * Quits: Stevef (chatzilla@moz-FBEAB712.croy.cable.virginmedia.com) (Connection reset by peer)
  154. # [11:34] * Quits: nhirata (nhirata.bu@moz-2A9C9106.hsd1.ca.comcast.net) (Quit: nhirata)
  155. # [11:57] * Joins: askalski (akuda@moz-6A36EC49.ip.abpl.pl)
  156. # [11:58] * Quits: geo (geo@moz-E31CD2CB.mozilla.org) (Ping timeout)
  157. # [11:59] * Joins: geo (geo@moz-E31CD2CB.mozilla.org)
  158. # [12:01] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
  159. # [12:11] * Joins: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp)
  160. # [12:14] * Quits: askalski (akuda@moz-6A36EC49.ip.abpl.pl) (Ping timeout)
  161. # [12:19] * Joins: askalski (akuda@moz-6A36EC49.ip.abpl.pl)
  162. # [12:49] * Joins: Stevef (chatzilla@moz-FBEAB712.croy.cable.virginmedia.com)
  163. # [13:09] * Quits: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp) (Quit: mike5w3c)
  164. # [13:27] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
  165. # [13:28] * Quits: geo (geo@moz-E31CD2CB.mozilla.org) (Ping timeout)
  166. # [13:29] * Joins: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp)
  167. # [13:29] * Joins: geo (geo@moz-E31CD2CB.mozilla.org)
  168. # [13:35] * Quits: silvia (Adium@moz-7033BBBB.dyn.iinet.net.au) (Quit: Leaving.)
  169. # [13:53] <askalski> tbsaunde, : you want this macro in the same file
  170. # [13:53] <askalski> or should I create a new one?
  171. # [13:55] <@MarcoZ> khuey: Hi! Do you have any objections against me merging the projects/accessibility branch back to m-c? The two bugs that would be pushed are bug 714976 and bug 673689.
  172. # [13:58] <khuey> I do not
  173. # [14:00] <@MarcoZ> khuey: Thanks, pushed.
  174. # [14:10] * Quits: Stevef (chatzilla@moz-FBEAB712.croy.cable.virginmedia.com) (Ping timeout)
  175. # [14:35] <askalski> btw, thank you guys for bug suggestions
  176. # [14:35] <@tbsaunde> askalski: yw
  177. # [14:47] <@tbsaunde> askalski: a number of the bugs blocking cleana11y (bug 389800) are probably reasonable for you
  178. # [14:51] <askalski> ok, any clues why compilation fails to find a new header file?
  179. # [14:51] <askalski> should I add it somewhere or what?
  180. # [14:52] <askalski> I did add
  181. # [14:52] <askalski> #define STATE(name_, number_) const PRUint64 name_ = ((PRUint64) 0x1) << number_;
  182. # [14:52] <askalski> #include "StateList.h"
  183. # [14:52] <askalski> #undef STATE
  184. # [14:52] <askalski> and I got compile warnings "cannot find StateList.h" while it's in the same directory etc
  185. # [14:55] <@tbsaunde> askalski: the header was in the same directory, but was the file it was included from in that directory too?
  186. # [14:55] <@tbsaunde> I mean which file failed to build?
  187. # [14:56] <askalski> In file included from ../../dist/include/nsAccessible.h:43:0,
  188. # [14:56] <askalski> from /home/akuda/Moz/mozilla-central/widget/gtk2/nsWindow.h:66,
  189. # [14:56] <askalski> from /home/akuda/Moz/mozilla-central/widget/gtk2/nsAppShell.cpp:45:
  190. # [14:56] <askalski> ../../dist/include/mozilla/a11y/States.h:50:23: fatal error: StateList.h: Nie ma takiego pliku ani katalogu
  191. # [14:56] <askalski> compilation terminated.
  192. # [14:56] <askalski> make[6]: *** [nsAppShell.o] Błąd 1
  193. # [14:56] <askalski> make[6]: *** Oczekiwanie na niezakończone zadania....
  194. # [14:56] <askalski> In file included from ../../dist/include/nsAccessible.h:43:0,
  195. # [14:56] <askalski> from /home/akuda/Moz/mozilla-central/widget/gtk2/nsWindow.h:66,
  196. # [14:56] <askalski> from /home/akuda/Moz/mozilla-central/widget/gtk2/nsWidgetFactory.cpp:45:
  197. # [14:56] <askalski> ../../dist/include/mozilla/a11y/States.h:50:23: fatal error: StateList.h: Nie ma takiego pliku ani katalogu
  198. # [14:56] <askalski> compilation terminated.
  199. # [14:56] <askalski> make[6]: *** [nsWidgetFactory.o] Błąd 1
  200. # [14:56] <askalski> In file included from ../../dist/include/nsAccessible.h:43:0,
  201. # [14:56] <askalski> from /home/akuda/Moz/mozilla-central/widget/gtk2/nsWindow.h:66,
  202. # [14:56] <askalski> from /home/akuda/Moz/mozilla-central/widget/gtk2/nsGtkIMModule.cpp:51:
  203. # [14:56] <askalski> ../../dist/include/mozilla/a11y/States.h:50:23: fatal error: StateList.h: Nie ma takiego pliku ani katalogu
  204. # [14:56] <askalski> compilation terminated.
  205. # [14:56] <askalski> make[6]: *** [nsGtkIMModule.o] Błąd 1
  206. # [14:56] <askalski> In file included from ../../dist/include/nsAccessible.h:43:0,
  207. # [14:56] <askalski> from /home/akuda/Moz/mozilla-central/widget/gtk2/nsWindow.h:66,
  208. # [14:56] <askalski> from /home/akuda/Moz/mozilla-central/widget/gtk2/nsWindow.cpp:51:
  209. # [14:56] <askalski> ../../dist/include/mozilla/a11y/States.h:50:23: fatal error: StateList.h: Nie ma takiego pliku ani katalogu
  210. # [14:56] <askalski> compilation terminated.
  211. # [14:56] <askalski> m
  212. # [14:56] <askalski> "nie ma takiego pliku ani katalogu" means "no such file or dir"
  213. # [14:57] <@tbsaunde> askalski: pastebin please next time :)
  214. # [14:58] <askalski> I don't know what pastebin is!
  215. # [14:58] <askalski> ok, googled
  216. # [14:58] <@tbsaunde> askalski: add the file you created to either EXPORTS or EXPORTS_mozilla/a11y in the Makefile.in
  217. # [14:58] * Quits: geo (geo@moz-E31CD2CB.mozilla.org) (Ping timeout)
  218. # [14:58] <@tbsaunde> askalski: sorry, website to paste things for people to read
  219. # [14:59] * Joins: geo (geo@moz-E31CD2CB.mozilla.org)
  220. # [15:01] <askalski> done, compiling
  221. # [15:07] <@MarcoZ> tbsaunde: All landed OK it looks like.
  222. # [15:07] <@MarcoZ> tbsaunde: Now we only have to deal with a crasher caused by bug 591363.
  223. # [15:07] <@MarcoZ> tbsaunde: Bug 717505.
  224. # [15:09] * Joins: sgimeno (santiago.g@A922400D.48362F18.BCC03455.IP)
  225. # [15:09] * Joins: jprmc (jprmc@moz-7F2FF3EB.cpe.net.cable.rogers.com)
  226. # [15:09] * ChanServ sets mode: +o jprmc
  227. # [15:10] <@tbsaunde> MarcoZ: I saw the bug mail
  228. # [15:11] <@tbsaunde> only? I can think of a zillion other things I could work on
  229. # [15:13] <askalski> tbsaunde, : ok, it compiles. should I run all the tests, or assume that's a tiny thing and send you a diff
  230. # [15:13] <askalski> tbsaunde, : and plz review the licence block, I don't know if I haven't messed it up
  231. # [15:15] <@tbsaunde> up to you
  232. # [15:15] * Joins: davidb (davidb@F2D29657.F60B0462.67AC9B1.IP)
  233. # [15:15] * ChanServ sets mode: +qo davidb davidb
  234. # [15:15] <@tbsaunde> you probably didn't break anything, but it can't hurt
  235. # [15:15] <askalski> I'll run it
  236. # [15:15] * @davidb looks at a crash
  237. # [15:16] <askalski> o, hi David
  238. # [15:16] <@tbsaunde> davidb: so, somehow either the frame or the pres shel is null
  239. # [15:16] <@davidb> hmm
  240. # [15:17] <askalski> davidb, : later I will have some questions about the first bug I took, ok?
  241. # [15:17] <@davidb> sure
  242. # [15:17] <askalski> davidb, : let me know when you have some spare time
  243. # [15:17] <@davidb> ok
  244. # [15:17] <@tbsaunde> davidb: and I'm going to say that it's being called on a property pain or pain
  245. # [15:22] <@davidb> askalski: if you are blocked, feel fee to ask anytime
  246. # [15:23] <askalski> davidb,: I actually reverted a tiny change I made yesterday
  247. # [15:23] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
  248. # [15:23] <askalski> davidb, : and started to do other stuff
  249. # [15:23] <askalski> davidb, : the modification of removal two lines make it fail tests
  250. # [15:23] <askalski> davidb, : and honestly I am not sure if it's not the problem with the tests
  251. # [15:24] <@tbsaunde> did you ever find out if they run fine to start with?
  252. # [15:24] <@davidb> askalski: the tests are probably incorrect now
  253. # [15:24] <@davidb> askalski: as per specification
  254. # [15:24] <askalski> davidb, : because it seems that some of them rely on listitem being selectable
  255. # [15:24] <askalski> davidb, : so if I remove this property, they fail
  256. # [15:24] <@davidb> askalski: so it involves removing the lines and changing the tests (probably)
  257. # [15:24] <@davidb> askalski: which tests?
  258. # [15:24] <@davidb> also, what tbsaunde said above ^ would be good to confirm
  259. # [15:25] <askalski> these were the most interesting
  260. # [15:25] <askalski> chrome://mochitests/content/a11y/accessible/test_childAtPoint.xul
  261. # [15:25] <askalski> chrome://mochitests/content/a11y/accessible/test_aria_token_attrs.html
  262. # [15:25] <askalski> chrome://mochitests/content/a11y/accessible/events/test_focus_listcontrols.xul
  263. # [15:25] <askalski> chrome://mochitests/content/a11y/accessible/selectable/test_aria.html
  264. # [15:25] <askalski> the first four that fail
  265. # [15:25] <@davidb> askalski: do they all use aria listitems?
  266. # [15:25] <askalski> later some non-deterministic stuff happens, seems to be flaky
  267. # [15:25] <askalski> havent checked yet
  268. # [15:25] <@davidb> askalski: have you ever had a clean test run, on an unmodified source base?
  269. # [15:25] <askalski> the output suggests that at least the last does
  270. # [15:26] <askalski> did a fresh checkout and compile yesterday night
  271. # [15:26] <askalski> right now testing some other patch
  272. # [15:26] <@davidb> did you run the test suite against the fresh checkout?
  273. # [15:26] <askalski> I'll do a full test on clean build immediately when it stops
  274. # [15:26] <@davidb> ok
  275. # [15:26] <@davidb> that is step 1.
  276. # [15:27] <askalski> yes, I figured it out too late
  277. # [15:27] <@davidb> heh
  278. # [15:29] <askalski> ok, so the tests after this tiny patch fails, and it's just moving some code somewhere else, so no semantic difference should be made
  279. # [15:29] <askalski> *should do a semantic different
  280. # [15:29] <askalski> now I started the tests on fresh checkout and compilation
  281. # [15:29] <askalski> but I guess the results will be the same
  282. # [15:30] <askalski> since very beginning tests were kinda non deterministic on my hardware
  283. # [15:30] <@davidb> tbsaunde: does the crash stack look correct to you?
  284. # [15:30] <@tbsaunde> davidb: nothing particularly suspect in it
  285. # [15:31] <@tbsaunde> but I haven't tried to reproduce yet
  286. # [15:32] <@davidb> tbsaunde: these crashes are on linux so far I think
  287. # [15:32] <@tbsaunde> davidb: it looks like that's where jesse found it atleast
  288. # [15:32] <@davidb> and the linked reports
  289. # [15:32] <@tbsaunde> ok, didn't look at those yet
  290. # [15:34] * @tbsaunde wouldn't really expect to get much out of the crash reports
  291. # [15:35] <@davidb> tbsaunde: the claim is a SIGSEGV here: http://hg.mozilla.org/mozilla-central/annotate/e79ef0ffcb09/layout/generic/nsIFrame.h#l825
  292. # [15:38] <@davidb> BTW w3c is using mercurial.
  293. # [15:39] <@davidb> I committed a spec change yesterday.
  294. # [15:39] * @davidb hangs head in shame
  295. # [15:39] <@tbsaunde> davidb: ok, so the nsIFrame* is null
  296. # [15:39] <@davidb> tbsaunde: how did you read that?
  297. # [15:40] * @davidb admits to multitasking
  298. # [15:40] <@tbsaunde> the question is why does the accessible not have a related frame
  299. # [15:40] <@davidb> tbsaunde: it could have gone bad
  300. # [15:40] <@tbsaunde> define "gone bad"
  301. # [15:40] <@davidb> we'll probably need to recreate and see what the node is
  302. # [15:41] <askalski> same
  303. # [15:41] <@davidb> my dev machine is windows now… i'll see if i can recreate
  304. # [15:41] <askalski> the tests on fresh build fails at my machine
  305. # [15:41] <@tbsaunde> I looked for the one place we get the size, and saw it was the first thing after we get the frame
  306. # [15:41] <@davidb> askalski: is that without touching your keyboard and mouse?
  307. # [15:41] <@davidb> tbsaunde: do we check the frame?
  308. # [15:42] <@tbsaunde> davidb: no, but should we have to? shouldn't alive accessibles always have a frame?
  309. # [15:42] <@davidb> true
  310. # [15:43] <@davidb> tbsaunde: is the frame address 0x0?
  311. # [15:43] <@tbsaunde> no idea, but the crash is at 0x10 so probably close too it
  312. # [15:43] <@davidb> 0xc
  313. # [15:44] <@tbsaunde> but I haven't tried to layout nsIFrame to be sure those things could reasonably be at 0x10 in it
  314. # [15:44] <@tbsaunde> oh, I thought I saw 0x10 close enough anyway
  315. # [15:44] <@davidb> this is during event firing
  316. # [15:45] <@davidb> which is async to frames going bad
  317. # [15:46] <@tbsaunde> I thought events were fired after the frame tree had been invalidated and relayed out?
  318. # [15:46] <@davidb> tbsaunde: could an event hold onto an accessible who's frame has gone bye bey?
  319. # [15:47] <@davidb> tbsaunde: correct.
  320. # [15:47] <@tbsaunde> right now yes, but then it should probably be defunct no?
  321. # [15:47] <@davidb> we queue them up during mutations, and fire on the refresh driver pump.
  322. # [15:48] <@davidb> i think WillRefresh is the call into us when things are safe.
  323. # [15:48] <@tbsaunde> yeah
  324. # [15:49] <@davidb> but I'm wondering if it is possible we have events in the queue for accessibles that should be dead.
  325. # [15:49] <@davidb> i've not thought about this before.
  326. # [15:49] <@tbsaunde> so, we can certainly have events whose target is defunct
  327. # [15:49] <@davidb> right
  328. # [15:49] <@davidb> and in some cases the target is a frame
  329. # [15:50] <@tbsaunde> but I believe we know that the accessible in question is not defunct because otherwise we would have bailed out of State()
  330. # [15:50] <@davidb> ah
  331. # [15:50] * Joins: aaronlev (aaronlev@moz-CDA191A6.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com)
  332. # [15:50] * ChanServ sets mode: +o aaronlev
  333. # [15:50] <@davidb> ok, this might be us uncovering a naughtiness in layout.
  334. # [15:50] <@davidb> need to recreate.
  335. # [15:50] <@tbsaunde> davidb: what do you mean by the target of an event being a frame?
  336. # [15:50] <@aaronlev> morning
  337. # [15:51] <@davidb> hi aaronlev
  338. # [15:52] <@davidb> tbsaunde: i was thinking about how there can be multiple frames per node, e.g. bullets.
  339. # [15:52] <@davidb> aaronlev: how goes it?
  340. # [15:53] <@aaronlev> i managed to mess up my build environment
  341. # [15:53] <@aaronlev> can take a long time to debug something like that
  342. # [15:53] <@aaronlev> !
  343. # [15:53] <@aaronlev> yeech
  344. # [15:53] <@davidb> ouch
  345. # [15:53] <@aaronlev> esp on windows
  346. # [15:53] <@aaronlev> but, it's all about having a productive environment
  347. # [15:54] <@tbsaunde> davidb: yes, but events store accessibles and nsIContent* not frames
  348. # [15:54] <@davidb> yes.
  349. # [15:55] <@davidb> ok, let me recreate.
  350. # [15:58] <@tbsaunde> mgorse: you should probably ask for approval on that patch today, there might be a meeting to decide on approvals this evening but I'm not sure
  351. # [15:59] * @tbsaunde -> food
  352. # [16:01] <askalski> davidb, : what should I do if my machine permanenlty fails tests?
  353. # [16:02] <askalski> davidb, : someone asked me to use xvfb-run make mochitest-a11yx
  354. # [16:02] <askalski> xvfb-run anyway
  355. # [16:02] <@davidb> i don't know much about that
  356. # [16:02] <askalski> so I guess that keyboard and mouse is not an issue
  357. # [16:02] <@davidb> hmm
  358. # [16:02] <askalski> OK, I can re-run them normally without doing anyting else during lunch
  359. # [16:03] <askalski> which arrives in 20 minutes :D
  360. # [16:03] <@davidb> askalski: for now I would ignore tests that fail intermittently (or always) on a clean build
  361. # [16:03] <@davidb> sounds good
  362. # [16:04] <askalski> davidb, : ok, and what next, do tests in virtualbox with windows or something?
  363. # [16:04] <askalski> because I need to have a working toolset
  364. # [16:04] <askalski> at some point
  365. # [16:05] <@davidb> askalski: I don't run them locally that often, but when I do it is pretty fast. 5 mins?
  366. # [16:05] <@davidb> but I don't mess around with hardware.
  367. # [16:05] <@davidb> and i want you guys to have the best we can get you.
  368. # [16:06] <askalski> ok so I should probably re-consider hardware
  369. # [16:06] <@davidb> probably
  370. # [16:07] <askalski> xvfb-run is not neutral
  371. # [16:08] <askalski> I just have confirmed that it messes some initial tests
  372. # [16:08] <askalski> and ends prematurely
  373. # [16:08] <askalski> after 4 seconds
  374. # [16:08] <askalski> ok, I will fire all tests right now, and be unable to write
  375. # [16:08] <askalski> brb
  376. # [16:09] <@davidb> np
  377. # [16:09] <@davidb> have an nice lunch :)
  378. # [16:09] <@davidb> tbsaunde: when you're back… I don't seem to be able to recreate in Windows.
  379. # [16:09] <askalski> it's not here yet, but until I fix the working pipeline I don't know what to do
  380. # [16:10] <askalski> because I even have something to commit, but I think I should run some tests before submitting to review
  381. # [16:10] <askalski> ok, Im firing it
  382. # [16:10] <@davidb> ok
  383. # [16:10] <@davidb> (vmware is pretty neutral)
  384. # [16:14] * khuey is now known as khuey|away
  385. # [16:16] * khuey|away is now known as khuey
  386. # [16:17] <@tbsaunde> davidb: interesting
  387. # [16:18] <@davidb> tbsaunde: my bug comment?
  388. # [16:18] <@tbsaunde> askalski: note it might also be your cocmpiler version, or probably any number of other things
  389. # [16:18] <@davidb> note askalski might not respond
  390. # [16:18] <@tbsaunde> davidb: true, but presumably he'll get back eventually
  391. # [16:18] <@davidb> yes sir
  392. # [16:18] <@tbsaunde> davidb: haven't read that yet just responding to your can't reproduce
  393. # [16:19] <@MarcoZ> davidb: tbsaunde: I also didn't see the crash on Windows, and I've been using the browser heavily with multiple windows and/or tabs these days.
  394. # [16:19] <@davidb> tbsaunde: ah yes, forgot already that I noted this in channel.
  395. # [16:19] <@tbsaunde> :-P
  396. # [16:19] <@davidb> MarcoZ: ok, I seem to confirm this is sane observation.
  397. # [16:19] <@davidb> i should get around to setting up dual boot on this xeon beast
  398. # [16:20] <@tbsaunde> askalski: the xvfb effect thing is weird, but I have no idea :\
  399. # [16:21] <@davidb> tbsaunde: can you try to recreate the crash?
  400. # [16:22] <@tbsaunde> davidb: I can see what I can do for time
  401. # [16:23] <@davidb> that's all I can ask
  402. # [16:24] <@tbsaunde> its interesting that it shows up in win64 but not win32
  403. # [16:24] * @MarcoZ runs Win32, that's probably why.
  404. # [16:26] * @davidb installs ubuntu
  405. # [16:27] * Joins: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com)
  406. # [16:28] * Quits: geo (geo@moz-E31CD2CB.mozilla.org) (Ping timeout)
  407. # [16:29] * Joins: geo (geo@moz-E31CD2CB.mozilla.org)
  408. # [16:30] * @davidb squints at a stalled copying files progress bar
  409. # [16:33] <@tbsaunde> davidb: couldn't reproduce in a build with debug and trace malloc on
  410. # [16:34] <@tbsaunde> I'm building without trace malloc to see if that helps
  411. # [16:34] <@davidb> splendid
  412. # [16:35] <@davidb> i had to hard reboot my box
  413. # [16:38] * Quits: webben (benjamin@moz-BA505DDD.static.cloud-ips.com) (Ping timeout)
  414. # [16:42] * @davidb installs ubuntu, applies 289 updates...
  415. # [16:44] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
  416. # [16:45] <@tbsaunde> ok, disabling trace malloc wasn't enough now trying enable optimize though I thought that was the default and disabling debug
  417. # [16:45] * Joins: hhillen (hhillen@moz-DD786BF9.cm-12-4d.dynamic.ziggo.nl)
  418. # [16:45] <@davidb> i'm trying to recall that other crasher we had that seemed to only hit amd64
  419. # [16:46] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
  420. # [16:48] <askalski> ok, these are my results on clean build
  421. # [16:48] <askalski> 23244 INFO TEST-START | Shutdown
  422. # [16:48] <askalski> 23245 INFO Passed: 21479
  423. # [16:48] <askalski> 23246 INFO Failed: 1
  424. # [16:48] <askalski> 23247 INFO Todo: 1168
  425. # [16:48] <askalski> 23248 INFO SimpleTest FINISHED
  426. # [16:49] <@davidb> not too bad, which test failed?
  427. # [16:49] <askalski> 15373 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/test_childAtPoint.xul | Wrong deepest child accessible [['treecol@id="col2" node', address: 0x2b3bb5a71620, role: columnheader, name: 'column 2', address: 0x2b3bb5a5baf0]] at the point (162, 1) of accessible [[ 'tree@id="tree" node', address: 0x2b3bb5a71470 ]] - got [xpconnect wrapped (nsISupports, nsIAccessible, nsIAccessNode) @ 0x2b3bc8294550 (native @ 0x2b3bb5
  428. # [16:49] <askalski> a5b9d0)], expected [xpconnect wrapped (nsISupports, nsIAccessible, nsIAccessNode) @ 0x2b3bc82945c0 (native @ 0x2b3bb5a5baf0)]
  429. # [16:50] <askalski> tbsaunde, : I'm still not sure if it's xvfb. all tests seems to be non deterministic to me
  430. # [16:50] <askalski> it happens that at some point they start to fail all
  431. # [16:51] <@davidb> I'm wondering if you are seeing bug 481721
  432. # [16:51] <@davidb> firebot: bug 481721
  433. # [16:51] <@firebot> davidb: Sorry, I've no idea what 'bug 481721' might be.
  434. # [16:51] * Joins: hub (hub@83874EA1.EB7C1AF9.6F478678.IP)
  435. # [16:51] * ChanServ sets mode: +o hub
  436. # [16:55] <@tbsaunde> davidb: any chance you saw any interesting warnings / asserts on windows?
  437. # [16:55] <@davidb> i didn't notice asserts
  438. # [16:55] <@davidb> i didn't look for console output
  439. # [16:56] <@davidb> i'm setting up my ubuntu build environment at the moment
  440. # [16:56] <@tbsaunde> ok
  441. # [16:58] <@tbsaunde> hm, I think it might be that orca isn't able to click the button for some reason, right clicking doesn't make anything happen
  442. # [17:00] <@davidb> tbsaunde: for me, it opens a new tab, but focus stays in the test page. then 1 sec later the new tab closes.
  443. # [17:01] <@tbsaunde> davidb: yeah, I read the test case
  444. # [17:01] <@tbsaunde> but right click not working is a little odd
  445. # [17:02] <@davidb> hmm
  446. # [17:03] * @tbsaunde considers looking into some of the asserts he's tripping (including NS_ENSURE_* we trip a lot)
  447. # [17:06] <@davidb> tbsaunde: I feel like we can do things like that now, that we are a larger team, at least on the side of other priority work.
  448. # [17:09] * Joins: webben (benjamin@moz-BA505DDD.static.cloud-ips.com)
  449. # [17:19] <@davidb> MarcoZ: how's things?
  450. # [17:19] <@MarcoZ> davidb: Good!
  451. # [17:25] * Joins: ehsan (ehsan@F2D29657.F60B0462.67AC9B1.IP)
  452. # [17:27] <@davidb> I think the slowest part of setting up my build environment is hg clone. Even slower than the Ubuntu install.
  453. # [17:27] <@davidb> I blame ehsan.
  454. # [17:27] <@tbsaunde> nkkheh
  455. # [17:27] <ehsan> davidb: use git
  456. # [17:28] <@davidb> ehsan: stop modifying the source tree… it makes hg clone slower
  457. # [17:28] <ehsan> davidb: use git!
  458. # [17:28] <@davidb> I don't want indirection.
  459. # [17:29] <@davidb> use git, ready patch for hg, commit to inbound, merge to central
  460. # [17:29] <@tbsaunde> moveing patches isn't that hard but it is kind of anoying
  461. # [17:30] <@davidb> tbsaunde: do you use git?
  462. # [17:30] <@davidb> for moz work?
  463. # [17:30] <@tbsaunde> davidb: mostly
  464. # [17:31] <@davidb> this is becoming more common
  465. # [17:31] <@davidb> I'm still waiting on hg clone.
  466. # [17:32] * Quits: askalski (akuda@moz-6A36EC49.ip.abpl.pl) (Quit: Wychodzi)
  467. # [17:32] <@tbsaunde> I love when pull / push / update finish and then just hang
  468. # [17:33] <@tbsaunde> like they print the last line they would print and just sit there
  469. # [17:33] <@davidb> They are probably unionized government workers.
  470. # [17:51] <@hub> this is patch rebasing day
  471. # [17:53] <@tbsaunde> hub: your patch for bug 673405cv doesn't include the fix to bug 672504 right?
  472. # [17:54] <@hub> nope
  473. # [17:54] <@hub> it doesn't
  474. # [17:54] <@hub> and I need to update it again
  475. # [17:54] <@hub> I had to rebase it this morning
  476. # [17:54] <@tbsaunde> ok
  477. # [17:54] <@hub> the update is just because it didn't apply
  478. # [17:54] <@hub> or build
  479. # [17:55] <@hub> and I have it locally is I get crashes in DOM Inspector otherwise
  480. # [17:56] <@tbsaunde> I think I probably want to fix the pres shell thing before reviewing that bug
  481. # [17:57] <@MarcoZ> hub: Yeah I landed two things earlier today by merging them from accessibility to m-c. Among others Firefox can now "HTML Content". ;-)
  482. # [17:58] * Quits: geo (geo@moz-E31CD2CB.mozilla.org) (Ping timeout)
  483. # [17:59] <@hub> MarcoZ: thanks !
  484. # [17:59] <@tbsaunde> the pres shell thing shouldn't be hard, but regressions that are security bugs wouldn't suprise me
  485. # [17:59] * Joins: geo (geo@moz-E31CD2CB.mozilla.org)
  486. # [18:10] * khuey is now known as khuey|away
  487. # [18:24] <@tbsaunde> hub: are you going to work on the pres shell thing bug 672504 or can I deassign you and make it a mentored bug?
  488. # [18:24] <@hub> tbsaunde: if you want to take it, please feel free.
  489. # [18:35] * Joins: victorporof (victorporo@BCAA178E.F4308271.4873E54D.IP)
  490. # [18:41] <@davidb> tbsaunde: pres shell thing?
  491. # [18:42] <@davidb> hi hub
  492. # [18:42] <@hub> davidb: yeah it is bug WA557210
  493. # [18:42] <@hub> oops
  494. # [18:42] <@hub> bug 672504
  495. # [18:42] <@hub> stupid cut and paste
  496. # [18:42] <@davidb> aha
  497. # [18:45] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
  498. # [18:47] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
  499. # [18:58] * Quits: victorporof (victorporo@BCAA178E.F4308271.4873E54D.IP) (Connection reset by peer)
  500. # [18:59] * Joins: victorporof (victorporo@BCAA178E.F4308271.4873E54D.IP)
  501. # [19:07] * Quits: victorporof (victorporo@BCAA178E.F4308271.4873E54D.IP) (Quit: Linkinus - http://linkinus.com)
  502. # [19:18] <@davidb> ehsan: i have 2.9 (clang) - heading to llvm
  503. # [19:18] <ehsan> davidb: yeah you want 3.0
  504. # [19:19] <@tbsaunde> davidb: really? ;)
  505. # [19:27] <@davidb> yeah it was the default package for ubuntu 11.10
  506. # [19:28] * Quits: geo (geo@moz-E31CD2CB.mozilla.org) (Ping timeout)
  507. # [19:29] * Joins: geo (geo@moz-E31CD2CB.mozilla.org)
  508. # [19:30] <@tbsaunde> davidb: ubuntu switched away from gcc?
  509. # [19:31] <@davidb> tbsaunde: no, I mean it was the default but I still had to ask for it
  510. # [19:31] <@davidb> apt-get
  511. # [19:31] <@tbsaunde> oh, you mean the default version of clang
  512. # [19:32] <@tbsaunde> you could just like install build escential and have a fiarly reasonable gcc and go on with your life
  513. # [19:34] <@hub> you want clang 3.0
  514. # [19:34] <@hub> even F16 does not have it yet
  515. # [19:34] <@hub> which disappoints me
  516. # [19:36] * Quits: sgimeno (santiago.g@A922400D.48362F18.BCC03455.IP) (Quit: KVIrc 4.0.2 Insomnia http://www.kvirc.net/)
  517. # [19:37] * @tbsaunde shrugs
  518. # [19:39] <@hub> maybe we should just port Gecko to rust ;-)
  519. # [19:39] <@davidb> i now have clang 3.0
  520. # [19:39] <@davidb> seems to be chugging along nicely
  521. # [19:40] <@davidb> hub: there have been some suggestions like that… but I'm not sure.
  522. # [19:40] <@hub> davidb: I was just making a joke.
  523. # [19:40] <@davidb> i figured
  524. # [19:40] <@hub> graydon, rust main developer, works at the vancouver office
  525. # [19:40] <@davidb> :)
  526. # [19:40] <@davidb> I know graydon
  527. # [19:42] <@davidb> ok hit another bug.
  528. # [19:42] <@davidb> resorting to gcc
  529. # [19:43] <@davidb> oh this is a pymake problem.
  530. # [19:43] <@tbsaunde> gcc really isn't that bad
  531. # [19:43] <@davidb> resorting to make
  532. # [19:43] <@tbsaunde> I don't think there's any real reason to use pymake on !windows is there?
  533. # [19:43] <@tbsaunde> other than an anoyingly long command
  534. # [19:43] <@davidb> heheh
  535. # [19:44] <@davidb> well it is what i'm used to know but yeah make is just fine here
  536. # [19:44] <@davidb> trying make + clang
  537. # [19:45] <@davidb> s/know/now
  538. # [19:45] <@tbsaunde> I haven't bothered to try it on windows even
  539. # [19:45] <@davidb> it is nice
  540. # [19:45] <@davidb> god i miss linux… this is like finding an old friend
  541. # [19:46] <@davidb> except the have gotten younger
  542. # [19:46] <@davidb> the/they
  543. # [19:46] <@davidb> ok beautiful, clang is chugging along nicely
  544. # [19:47] <@MarcoZ> OK, off for the evening!
  545. # [19:47] <@davidb> for anyone taking notes I just extracted the 3.0 binary into /usr/local and set my CC and CXX vars in my mozconfig
  546. # [19:47] <@davidb> MarcoZ: g'night
  547. # [19:47] * Quits: @MarcoZ (marco.zehe@moz-600A3C41.dip.t-dialin.net) (Quit: night!)
  548. # [19:57] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
  549. # [19:57] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
  550. # [20:09] <@davidb> clang finds a lot of warnings
  551. # [20:09] <@tbsaunde> are they useful warnings?
  552. # [20:13] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Ping timeout)
  553. # [20:16] <@davidb> they scroll by too fast
  554. # [20:16] <@davidb> also, i realized my -j8 flag didn't take so i am rebuilding
  555. # [20:16] <@davidb> and now it is blazing
  556. # [20:17] <@tbsaunde> true
  557. # [20:19] <@tbsaunde> davidb: enjoy your reviewws :)
  558. # [20:19] <@tbsaunde> reviews even
  559. # [20:19] <@davidb> oh boy
  560. # [20:19] <@davidb> well at least you broke it up
  561. # [20:20] <@tbsaunde> non of them should be very hard
  562. # [20:21] <@davidb> interesting that we didn't extern "C" before
  563. # [20:23] <@tbsaunde> the G_BEGIN_DECL thing is secretly that
  564. # [20:23] <@tbsaunde> well, #ifdef CXX extern "C" { #endif
  565. # [20:24] <@tbsaunde> and then I suspect what happens is that the compiler has a prototype so it matches the function and uses the prototypes calling convention
  566. # [20:28] <@tbsaunde> davidb: looks like some last minute touch up broke the first patch slightly, I'll upload a new version in a minute
  567. # [20:28] <@davidb> ok
  568. # [20:31] <@davidb> ok full clobber build, in real time was: 2m59.220s
  569. # [20:31] <@davidb> wait
  570. # [20:31] <@tbsaunde> sorry about that :(
  571. # [20:31] <@davidb> i must have ccache
  572. # [20:31] <@davidb> 3 mins is too fast
  573. # [20:31] <@davidb> tbsaunde: s'ok
  574. # [20:31] <@tbsaunde> yeah, was about to say :)
  575. # [20:42] <@davidb> does ccache --clear actually work? because my full build just now was a little over a minute
  576. # [20:45] <@tbsaunde> not sure, you could just rm ~/.ccache
  577. # [20:51] <@hub> ok, going to the office now
  578. # [20:56] <@davidb> heh
  579. # [20:58] * Quits: geo (geo@moz-E31CD2CB.mozilla.org) (Ping timeout)
  580. # [20:59] * Joins: geo (geo@moz-E31CD2CB.mozilla.org)
  581. # [21:03] <@davidb> 11 minutes 37 seconds
  582. # [21:03] <@tbsaunde> davidb: okk new version uploaded fix is pretty trivial
  583. # [21:03] <@davidb> ok
  584. # [21:16] * Quits: @hub (hub@83874EA1.EB7C1AF9.6F478678.IP) (Input/output error)
  585. # [21:35] * Quits: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp) (Ping timeout)
  586. # [21:36] * Joins: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp)
  587. # [21:39] * Joins: hub (hub@21B7B9F2.B87E9213.6E712CE2.IP)
  588. # [21:39] * ChanServ sets mode: +o hub
  589. # [22:04] <@davidb> ok finally, getting to reviews
  590. # [22:13] <@davidb> actually, I could do this better from home… gonna commute early
  591. # [22:13] <@davidb> ttfn
  592. # [22:14] * Quits: @davidb (davidb@F2D29657.F60B0462.67AC9B1.IP) (Quit: davidb)
  593. # [22:15] * Joins: victorporof (victorporo@7245835D.A00C134E.79933D60.IP)
  594. # [22:28] * Quits: geo (geo@moz-E31CD2CB.mozilla.org) (Ping timeout)
  595. # [22:30] * Joins: geo (geo@moz-E31CD2CB.mozilla.org)
  596. # [22:32] * khuey|away is now known as khuey
  597. # [22:38] * Quits: victorporof (victorporo@7245835D.A00C134E.79933D60.IP) (Ping timeout)
  598. # [22:52] * khuey is now known as khuey|away
  599. # [22:53] * Quits: geo (geo@moz-E31CD2CB.mozilla.org) (Ping timeout)
  600. # [22:54] * Joins: geo (geo@moz-E31CD2CB.mozilla.org)
  601. # [23:02] * Quits: hhillen (hhillen@moz-DD786BF9.cm-12-4d.dynamic.ziggo.nl) (Quit: hhillen)
  602. # [23:16] * Joins: silvia (Adium@moz-7033BBBB.dyn.iinet.net.au)
  603. # [23:35] * Joins: askalski (akuda@moz-A9852767.neoplus.adsl.tpnet.pl)
  604. # [23:35] * ChanServ sets mode: +o askalski
  605. # [23:49] * Joins: davidb (davidb@moz-6F9F653A.dsl.bell.ca)
  606. # [23:49] * ChanServ sets mode: +qo davidb davidb
  607. # [23:54] * Quits: @askalski (akuda@moz-A9852767.neoplus.adsl.tpnet.pl) (Ping timeout)
  608. # [23:54] * Quits: geo (geo@moz-E31CD2CB.mozilla.org) (Ping timeout)
  609. # [23:57] * Joins: geo (geo@moz-BBE3ABD.mv.mozilla.com)
  610. # [23:58] * Quits: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com) (Quit: nhirata)
  611. # Session Close: Fri Jan 13 00:00:00 2012

The end :)