/irc-logs / mozilla / #accessibility / 2012-01-13 / end

Options:

  1. # Session Start: Fri Jan 13 00:00:00 2012
  2. # Session Ident: #accessibility
  3. # [00:16] * Joins: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com)
  4. # [00:18] * Joins: askalski (akuda@moz-A9852767.neoplus.adsl.tpnet.pl)
  5. # [00:18] * ChanServ sets mode: +o askalski
  6. # [00:18] <@askalski> tbsaunde, : can you give me your e-mail?
  7. # [00:19] <@askalski> hi
  8. # [00:19] <@askalski> can anyone help me with a detail?
  9. # [00:19] <@hub> what is it?
  10. # [00:21] <@askalski> I got some modifications
  11. # [00:21] <@askalski> I want to turn them into a file and send to tbsaunde
  12. # [00:22] <@askalski> because it's not a patch to a specific bug, only something he asked me if I could do
  13. # [00:22] <@hub> ok
  14. # [00:22] <@hub> hg diff to get a diff of the local changes
  15. # [00:22] <@hub> or better, you can use mercurial Queues https://developer.mozilla.org/en/Mercurial_Queues
  16. # [00:23] <@askalski> yes, I use queues
  17. # [00:23] <@askalski> I even did hg qnew -f StateListPatch
  18. # [00:23] * Quits: @davidb (davidb@moz-6F9F653A.dsl.bell.ca) (Quit: davidb)
  19. # [00:23] <@hub> did you also do https://developer.mozilla.org/en/Installing_Mercurial#Configuration
  20. # [00:23] <@hub> to generate proper diffs?
  21. # [00:24] <@hub> the patch is in .hg/patches/StateListPatch
  22. # [00:25] <@askalski> yep, thanks
  23. # [00:25] <@askalski> do you have tbsaunde's e-mail?
  24. # [00:26] <@tbsaunde> askalski hi
  25. # [00:26] <@askalski> hi
  26. # [00:27] <@askalski> tbsaunde, can you give me your e-mail?
  27. # [00:27] <@askalski> I would send you this modification with macro
  28. # [00:27] <@tbsaunde> askalski: trev.saunders@gmail.com
  29. # [00:27] <@hub> trev.saunders [AT] gmail.com
  30. # [00:27] <@hub> :-)
  31. # [00:28] <@hub> I had to gid in the bugzilla email
  32. # [00:28] <@hub> dig
  33. # [00:28] <@tbsaunde> askalski: I filed a bug for that this morning or last night, I don't remember the number though
  34. # [00:28] <@tbsaunde> usually use {hg,git} log to find emails
  35. # [00:29] <@askalski> ok, it's just very late
  36. # [00:29] <@tbsaunde> askalski: you know how to use qrefresh right?
  37. # [00:29] <@askalski> and I said I will do it tomorrow
  38. # [00:29] <@askalski> *today
  39. # [00:29] <@tbsaunde> no hurry :)
  40. # [00:29] <@askalski> before going asleep, so I didn't want to learn new stuff
  41. # [00:29] <@askalski> yeah, but I wanted to have something done before going to sleep :)
  42. # [00:30] <@askalski> even a tiny thing
  43. # [00:30] <@tbsaunde> askalski: sure, that was suposed I usually do not you should :)
  44. # [00:30] <@askalski> tbsaunde, I might be tired, but I don't understand last message
  45. # [00:30] <@askalski> tbsaunde: check your email
  46. # [00:31] <@tbsaunde> then don't worry about it
  47. # [00:32] <@askalski> tbsaunde: is the patch format etc ok?
  48. # [00:32] <@tbsaunde> ok, got it, thanks
  49. # [00:32] <@askalski> great. so I go to sleep and pick up something more tomorrow
  50. # [00:33] <@askalski> thanks everyone for some guidance and easy assignments
  51. # [00:33] <@askalski> bye
  52. # [00:33] <@tbsaunde> askalski: you should add -U8 -p to something other in your hgrc as diff options
  53. # [00:33] <@askalski> ok
  54. # [00:33] <@askalski> should I redo it?
  55. # [00:34] <@askalski> [diff]
  56. # [00:34] <@askalski> git = 1
  57. # [00:34] <@askalski> showfunc = 1
  58. # [00:34] <@askalski> unified = 8
  59. # [00:34] <@askalski> it's in my ~/.hgrc
  60. # [00:35] <@tbsaunde> askalski: no, for this its fine, but when you ask for reviews a lot of people require the right format
  61. # [00:36] <@askalski> tbsaunde, : and what should I add to get the right format?
  62. # [00:36] <@askalski> a
  63. # [00:36] <@askalski> right
  64. # [00:36] <@askalski> I added these lines *after* generating the patch
  65. # [00:36] <@askalski> how to re-generate?
  66. # [00:37] <@tbsaunde> askalski: do you have qdiff=?
  67. # [00:37] <@askalski> no
  68. # [00:37] <@tbsaunde> askalski: hg qrefresh should be enough
  69. # [00:37] <@tbsaunde> askalski: my .hgrc is http://paste.debian.net/152080/
  70. # [00:38] <@askalski> tbsaunde, check again e-mail
  71. # [00:40] <@tbsaunde> askalski: looks correct thanks
  72. # [00:40] <@askalski> ok, so I go to sleep
  73. # [00:40] <@askalski> bye
  74. # [00:40] * Quits: @askalski (akuda@moz-A9852767.neoplus.adsl.tpnet.pl) (Quit: Wychodzi)
  75. # [00:46] * Joins: Jamie (jamie@moz-CA26021.jantrid.net)
  76. # [00:52] * Quits: @aaronlev (aaronlev@moz-CDA191A6.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com) (Ping timeout)
  77. # [01:02] <@firebot> sgautherie.bz@free.fr set status-firefox11 to affected on bug 717753.
  78. # [01:02] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=717753 maj, --, ---, nobody, NEW, [SeaMonkey] mochitest-a11y: lots(!) of tests fail
  79. # [01:44] * Quits: silvia (Adium@moz-7033BBBB.dyn.iinet.net.au) (Quit: Leaving.)
  80. # [01:45] <@firebot> sgautherie.bz@free.fr changed the Status on bug 717753 from NEW to ASSIGNED.
  81. # [01:45] <@firebot> sgautherie.bz@free.fr changed the Target Milestone on bug 717753 from --- to mozilla12.
  82. # [01:45] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=717753 maj, --, mozilla12, sgautherie.bz, ASSI, [SeaMonkey] mochitest-a11y: lots(!) of tests fail
  83. # [02:15] * Quits: ehsan (ehsan@F2D29657.F60B0462.67AC9B1.IP) (Input/output error)
  84. # [02:18] <@firebot> hub@mozilla.com requested review from trev.saunders@gmail .com for attachment 588246 on bug 712923.
  85. # [02:19] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=712923 nor, --, ---, hub, NEW, [Mac] Heading elements h1 through h6 are not recognizable by VoiceOver
  86. # [02:29] * Joins: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP)
  87. # [02:40] <@firebot> sgautherie.bz@free.fr requested review from marco.zehe@googlema il.com for attachment 588258 on bug 717753.
  88. # [02:40] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=717753 maj, --, mozilla12, sgautherie.bz, ASSI, [SeaMonkey] mochitest-a11y: lots(!) of tests fail
  89. # [02:40] * Quits: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com) (Quit: nhirata)
  90. # [02:41] * Quits: @jprmc (jprmc@moz-7F2FF3EB.cpe.net.cable.rogers.com) (Ping timeout)
  91. # [02:48] <@firebot> New Core - Disability Access APIs bug 717820 filed by hub@mozilla.com.
  92. # [02:48] <@firebot> Bug 717820 was not found.
  93. # [02:56] * Joins: jprmc (jprmc@moz-7F2FF3EB.cpe.net.cable.rogers.com)
  94. # [02:56] * ChanServ sets mode: +o jprmc
  95. # [03:00] * Quits: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Input/output error)
  96. # [03:04] * Joins: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP)
  97. # [03:09] * Joins: Rguy84 (Ryan@moz-16BAE794.nc.res.rr.com)
  98. # [03:24] * Quits: Rguy84 (Ryan@moz-16BAE794.nc.res.rr.com) (Quit: )
  99. # [04:00] * Quits: @firebot (firebot@moz-67BF9FE6.carolina.res.rr.com) (Ping timeout)
  100. # [04:01] * Joins: firebot (firebot@moz-67BF9FE6.carolina.res.rr.com)
  101. # [04:01] * ChanServ sets mode: +o firebot
  102. # [04:02] * Quits: @hub (hub@21B7B9F2.B87E9213.6E712CE2.IP) (Input/output error)
  103. # [04:34] * Joins: hub (hub@moz-E2FCA694.figuiere.net)
  104. # [04:34] * ChanServ sets mode: +o hub
  105. # [05:20] * Joins: nhirata (nhirata.bu@moz-2A9C9106.hsd1.ca.comcast.net)
  106. # [05:58] * Quits: @firebot (firebot@moz-67BF9FE6.carolina.res.rr.com) (Connection reset by peer)
  107. # [06:04] * Quits: @hub (hub@moz-E2FCA694.figuiere.net) (Input/output error)
  108. # [06:33] * Joins: firebot (firebot@moz-67BF9FE6.carolina.res.rr.com)
  109. # [06:33] * ChanServ sets mode: +o firebot
  110. # [06:35] * khuey|away is now known as khuey
  111. # [06:41] * Quits: @firebot (firebot@moz-67BF9FE6.carolina.res.rr.com) (Quit: I was told to shutdown by Wolf. :-( )
  112. # [06:42] * Joins: firebot (firebot@moz-67BF9FE6.carolina.res.rr.com)
  113. # [06:42] * ChanServ sets mode: +o firebot
  114. # [06:45] * Quits: @firebot (firebot@moz-67BF9FE6.carolina.res.rr.com) (Quit: I was told to shutdown by Wolf. :-( )
  115. # [07:13] * Joins: firebot (firebot@moz-67BF9FE6.carolina.res.rr.com)
  116. # [07:13] * ChanServ sets mode: +o firebot
  117. # [07:16] * Quits: @firebot (firebot@moz-67BF9FE6.carolina.res.rr.com) (Quit: I was told to shutdown by Wolf. :-( )
  118. # [07:19] * Joins: firebot (firebot@moz-67BF9FE6.carolina.res.rr.com)
  119. # [07:19] * ChanServ sets mode: +o firebot
  120. # [07:20] * Quits: @firebot (firebot@moz-67BF9FE6.carolina.res.rr.com) (Client exited)
  121. # [07:22] * Joins: firebot (firebot@moz-67BF9FE6.carolina.res.rr.com)
  122. # [07:22] * ChanServ sets mode: +o firebot
  123. # [07:23] * Quits: @firebot (firebot@moz-67BF9FE6.carolina.res.rr.com) (Client exited)
  124. # [07:28] * Joins: firebot (firebot@moz-67BF9FE6.carolina.res.rr.com)
  125. # [07:28] * ChanServ sets mode: +o firebot
  126. # [07:29] * Quits: @firebot (firebot@moz-67BF9FE6.carolina.res.rr.com) (Client exited)
  127. # [07:30] * Joins: firebot (firebot@moz-67BF9FE6.carolina.res.rr.com)
  128. # [07:30] * ChanServ sets mode: +o firebot
  129. # [07:31] * Quits: @firebot (firebot@moz-67BF9FE6.carolina.res.rr.com) (Client exited)
  130. # [07:32] * Joins: firebot (firebot@moz-67BF9FE6.carolina.res.rr.com)
  131. # [07:32] * ChanServ sets mode: +o firebot
  132. # [07:33] * Quits: @firebot (firebot@moz-67BF9FE6.carolina.res.rr.com) (Client exited)
  133. # [07:34] * Joins: firebot (firebot@moz-67BF9FE6.carolina.res.rr.com)
  134. # [07:34] * ChanServ sets mode: +o firebot
  135. # [07:40] * Joins: Flyingmana (Mana@moz-3B83F238.adsl.alicedsl.de)
  136. # [07:43] * khuey is now known as khuey|away
  137. # [07:52] <@firebot> New Core - Disability Access APIs bug 717862 filed by ginn.chen@oracle.com.
  138. # [07:52] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=717862 nor, --, ---, nobody, NEW, Error: Goto dbus_done bypasses a variable (or an exception) initialization.
  139. # [07:53] <@firebot> ginn.chen@oracle.com requested review from trev.saunders@gmail .com for attachment 588320 on bug 717862.
  140. # [07:53] <@firebot> ginn.chen@oracle.com changed the Status on bug 717862 from NEW to ASSIGNED.
  141. # [08:11] <@firebot> marco.zehe@googlemail.com granted review for attachment 588258 on bug 717753.
  142. # [08:11] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=717753 maj, --, mozilla12, sgautherie.bz, ASSI, [SeaMonkey] mochitest-a11y: lots(!) of tests fail
  143. # [08:15] * Joins: MarcoZ (marco.zehe@moz-D0E8DEE5.dip.t-dialin.net)
  144. # [08:15] * ChanServ sets mode: +o MarcoZ
  145. # [08:15] <@MarcoZ> Good morning all!
  146. # [08:46] * Quits: Jamie (jamie@moz-CA26021.jantrid.net) (Quit: leaving)
  147. # [08:50] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
  148. # [08:58] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Ping timeout)
  149. # [09:00] * khuey|away is now known as khuey
  150. # [09:01] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
  151. # [09:32] * Quits: nhirata (nhirata.bu@moz-2A9C9106.hsd1.ca.comcast.net) (Quit: nhirata)
  152. # [09:53] * khuey is now known as khuey|away
  153. # [10:21] * Quits: @MarcoZ (marco.zehe@moz-D0E8DEE5.dip.t-dialin.net) (Ping timeout)
  154. # [10:23] * khuey|away is now known as khuey
  155. # [10:23] * Joins: MarcoZ (marco.zehe@moz-C2CEF848.dip.t-dialin.net)
  156. # [10:23] * ChanServ sets mode: +o MarcoZ
  157. # [10:36] * khuey is now known as khuey|away
  158. # [10:44] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
  159. # [10:44] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
  160. # [10:58] * Joins: sgimeno (santiago.g@A922400D.48362F18.BCC03455.IP)
  161. # [11:07] <@firebot> ioana.budnar@softvision.ro changed the Status on bug 706026 from RESOLVED to VERIFIED.
  162. # [11:07] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=706026 cri, --, mozilla11, surkov.alexander, VERI FIXED, Crash in nsXULTextFieldAccessible::FrameSelection
  163. # [11:46] * khuey|away is now known as khuey
  164. # [11:57] <@firebot> ioana.budnar@softvision.ro changed the Status on bug 706834 from RESOLVED to VERIFIED.
  165. # [11:57] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=706834 cri, --, mozilla11, surkov.alexander, VERI FIXED, Crash in nsXULTreeAccessible::TreeViewChanged
  166. # [12:31] <@firebot> trev.saunders@gmail.com granted review for attachment 588320 on bug 717862.
  167. # [12:31] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=717862 nor, --, ---, ginn.chen, ASSI, Error: Goto dbus_done bypasses a variable (or an exception) initialization.
  168. # [12:44] * Quits: @tbsaunde (tbsaunde@moz-9DECD0.pc.cs.cmu.edu) (Ping timeout)
  169. # [12:44] * Joins: tbsaunde (tbsaunde@moz-9DECD0.pc.cs.cmu.edu)
  170. # [12:45] <@firebot> jigneshhk1992@gmail.com requested review from trev.saunders@gmail .com for attachment 588369 on bug 686433.
  171. # [12:45] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=686433 nor, --, ---, jigneshhk1992, NEW, move out nsXULSelectableAccessible class from nsXULMenuAccessible.h file
  172. # [12:45] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
  173. # [12:48] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
  174. # [12:51] * Joins: victorporof (victorporo@896FAB.880C8D58.79933D60.IP)
  175. # [12:54] * ChanServ sets mode: +o tbsaunde
  176. # [13:11] * khuey is now known as khuey|away
  177. # [13:34] * Quits: @jprmc (jprmc@moz-7F2FF3EB.cpe.net.cable.rogers.com) (Ping timeout)
  178. # [13:37] * khuey|away is now known as khuey
  179. # [13:40] * Quits: sgimeno (santiago.g@A922400D.48362F18.BCC03455.IP) (Client exited)
  180. # [13:45] * Joins: sgimeno (santiago.g@A922400D.48362F18.BCC03455.IP)
  181. # [13:47] * Joins: askalski (akuda@moz-BE7A9C8B.neoplus.adsl.tpnet.pl)
  182. # [13:47] * ChanServ sets mode: +o askalski
  183. # [13:47] <@askalski> hi everyone
  184. # [13:49] <@askalski> tbsaunde, : I picked 716644
  185. # [13:50] <@askalski> tbsaunde, : i found nsRoleMap.h
  186. # [13:50] <@askalski> but I guess there are several other maps I should find ,right?
  187. # [13:52] <@tbsaunde> askalski: see {mac,msaa,atk}/nsRoleMap.h
  188. # [13:53] <@askalski> thx
  189. # [13:54] <@tbsaunde> yw
  190. # [13:55] <@askalski> ok, I have conflicts
  191. # [13:55] <@askalski> makefile has accessible/src/base/Makefile.in has changed
  192. # [13:56] <@askalski> and merge... ah, right I don't have merge setted up
  193. # [14:00] <@askalski> how to apply a patch?
  194. # [14:00] <@tbsaunde> askalski: hg qpush
  195. # [14:01] <@askalski> no, not land a patch
  196. # [14:01] <@askalski> I messed up while merging
  197. # [14:01] <@askalski> I wanted to checkout and apply my own patch to continue working on it
  198. # [14:04] <@tbsaunde> askalski: so, you have a patch in your queue but not applied right?
  199. # [14:04] <@askalski> tbsaunde, : yes
  200. # [14:04] <@tbsaunde> (its a stack, but they want to confuse you)
  201. # [14:05] <@askalski> tbsaunde, : regarding the e-mail, by "expanding" the macro I ment adding the two other arguments etc
  202. # [14:05] <@tbsaunde> qpush is what you want then, it applies the patch on top of the stack of already applied patches
  203. # [14:06] <@tbsaunde> askalski: yeah, please, and then make a macro to generate the atk state map
  204. # [14:14] * khuey is now known as khuey|away
  205. # [14:22] <@askalski> ok, I have dozens of files marked as R and as M
  206. # [14:22] <@askalski> after doing hg pull (without -u)
  207. # [14:22] <@askalski> how to get rid of it?
  208. # [14:24] <@tbsaunde> what do you marked?
  209. # [14:24] <@tbsaunde> what do you mean marked I mean
  210. # [14:24] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
  211. # [14:24] <@tbsaunde> askalski: what you usually do is hg qpop -a && hg pull -u && hg qpush
  212. # [14:24] <@askalski> hg status
  213. # [14:25] <@askalski> is there a nice turorial?
  214. # [14:25] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
  215. # [14:25] <@askalski> tbsaunde, : local changes found, refresh first
  216. # [14:25] <@tbsaunde> askalski: there's a book somewhere fo general hg and the wiki page
  217. # [14:26] <@tbsaunde> askalski: I think you want to do hg update
  218. # [14:26] <@askalski> tbsaunde, : I think that the easiest way would be to update with discarding local changes and then just apply the single patch file I sent you yesterday
  219. # [14:26] <@askalski> but I don't know how to do it
  220. # [14:26] * Joins: jprmc (jprmc@DB3A2AE9.5BCEC6DB.DA78B690.IP)
  221. # [14:26] * ChanServ sets mode: +o jprmc
  222. # [14:26] <@tbsaunde> askalski: well, if you haven't changed since then I gues you could
  223. # [14:26] <@askalski> akuda@nouri:~/Moz/mozilla-central$ hg update
  224. # [14:27] <@askalski> abort: outstanding uncommitted merges
  225. # [14:27] <@askalski> awww, svn was so simple!
  226. # [14:27] <@tbsaunde> try hg revert --all?
  227. # [14:27] <@tbsaunde> and so horrible and useless
  228. # [14:27] <@askalski> abort: uncommitted merge - please provide a specific revision
  229. # [14:27] <@askalski> yes, you're probaly right
  230. # [14:28] <@tbsaunde> oh, how did you get into a mege weird
  231. # [14:28] <@tbsaunde> try hg update --clean
  232. # [14:28] <@askalski> yes, I had merge unset
  233. # [14:28] <@tbsaunde> I've only used svn once, but I've had to use cvs a couple times
  234. # [14:29] <@askalski> ok, and how to re-download missing fille?
  235. # [14:29] <@askalski> I assumed that if i remove something, it'll download the most recent version as svn
  236. # [14:29] <@tbsaunde> grab it from your email?
  237. # [14:30] <@tbsaunde> what do you mean missing?
  238. # [14:30] <@askalski> I deleted a Makefile
  239. # [14:30] <@askalski> one of it at least
  240. # [14:30] <@askalski> oh, revert -all did the trick
  241. # [14:31] <@tbsaunde> yeah, revert -all or update --clean should get you to the state at the last commit or something similar
  242. # [14:31] <@askalski> it's different than svn. if you remove in hg it assumes it's a modification. svn assumes that a removal means "ok, give me last version until i say otherwise"
  243. # [14:32] <@tbsaunde> I know enough about hg to get what I need done, not enough ato explain coherently how it works
  244. # [14:33] <@askalski> ok, how to re-apply the patch I sent you the other day?
  245. # [14:34] * Quits: @jprmc (jprmc@DB3A2AE9.5BCEC6DB.DA78B690.IP) (Quit: Leaving)
  246. # [14:34] <@tbsaunde> first make sure nothing in your queue is applied with hg qpop -a
  247. # [14:34] <@tbsaunde> then update to the most recent version with hg update
  248. # [14:34] <@tbsaunde> then if you still have the patch in your queue hg qpush
  249. # [14:35] <@tbsaunde> otherwise qimport patch && hg qpush
  250. # [14:40] <@askalski> ok, thx, that worked. now the patch fails to apply, because of collision in Makefile
  251. # [14:40] <@askalski> patch failed, rejects left in working dir
  252. # [14:40] <@askalski> errors during apply, please fix and refresh StateListPatch
  253. # [14:40] <@tbsaunde> so, it leaves rejected hunks of the diff in .rej files
  254. # [14:41] <@tbsaunde> so if there were errors applying to foo.cpp you now have foo.cpp.rej that you get to apply by hand
  255. # [14:41] <@tbsaunde> (have fun love mercurial)
  256. # [14:42] <@askalski> ok, and then I need to do some stuff to get StatePatch updated, right?
  257. # [14:43] <@tbsaunde> well, applying by hand will "update" it so it works with trunk
  258. # [14:43] <@tbsaunde> then you can work on my comments :)
  259. # [14:44] <@askalski> that's the plan
  260. # [14:44] <@askalski> thanks a lot
  261. # [14:47] <@tbsaunde> yw
  262. # [14:48] * khuey|away is now known as khuey
  263. # [14:58] * Quits: victorporof (victorporo@896FAB.880C8D58.79933D60.IP) (Ping timeout)
  264. # [14:59] * khuey is now known as khuey|away
  265. # [15:13] * Joins: richardschwerdtfeger (richardsch@moz-130F1494.lightspeed.austtx.sbcglobal.net)
  266. # [15:17] <@firebot> trev.saunders@gmail.com granted review for attachment 588369 on bug 686433.
  267. # [15:18] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=686433 nor, --, ---, jigneshhk1992, NEW, move out nsXULSelectableAccessible class from nsXULMenuAccessible.h file
  268. # [15:35] * Joins: clown (clown@67828CC7.C1A51174.9D42CF23.IP)
  269. # [15:37] <@askalski> btw, is David here today?
  270. # [15:41] <@tbsaunde> I do't know why he wouldn't be, but I haven't read moco email in a couple days
  271. # [15:43] <@askalski> tbsaunde, : I am attaching nsStateMap.h to State macro now
  272. # [15:43] <@askalski> how should I name the arguments? I propose "AtkStateMap key" and "AtkStateMap value"
  273. # [15:44] <@askalski> though it's confusing considering the fact
  274. # [15:44] <@askalski> that several of the "keys" are "kNone"
  275. # [15:44] * Quits: sgimeno (santiago.g@A922400D.48362F18.BCC03455.IP) (Quit: KVIrc 4.0.2 Insomnia http://www.kvirc.net/)
  276. # [15:45] <@askalski> also, the second one ("value") could probably be more informative (it's always kMapDirectly, kMapOpposite or kNoSuchState)
  277. # [15:45] <@askalski> tbsaunde, : what to do with it?
  278. # [15:45] * Joins: jprmc (jprmc@DB3A2AE9.5BCEC6DB.DA78B690.IP)
  279. # [15:45] * ChanServ sets mode: +o jprmc
  280. # [15:45] <@askalski> tbsaunde, : and one last thing, I should probably create a 47th state NOSUCHSTATE or NOSTATE or something like this
  281. # [15:46] <@askalski> it's in Atk map, so I have to create a dummy on the list
  282. # [15:48] <@tbsaunde> askalski: I think call them atkState and AtkMappingType
  283. # [15:48] <@tbsaunde> seem reasonable?
  284. # [15:48] <@tbsaunde> askalski: I'm not sure what you need that state for
  285. # [15:52] <@askalski> { kNone, kNoSuchState }, // = 1 << 47
  286. # [15:52] <@askalski> it's in the gkAtkStateMap.h
  287. # [15:53] <@askalski> nope, it's in nsStateMap.h
  288. # [15:53] <@tbsaunde> yeah, I see now, figuring this out again
  289. # [15:53] <@askalski> anyway, it's there. I can try to remove it and find out if the tests go throug
  290. # [15:53] <@askalski> and if they not, I'll create an artificial state to cover that
  291. # [15:53] <@askalski> I'll be back in 20 mins, my gf made me a lunch
  292. # [16:14] <@tbsaunde> askalski: ok, so I think I understand what's going on now
  293. # [16:14] <@tbsaunde> askalski: I don't think you need to add a new state
  294. # [16:14] <@tbsaunde> just when you'd pass ATK_STATE_FOO to the macro pass kNone
  295. # [16:17] * Quits: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Input/output error)
  296. # [16:18] <@askalski> tbsaunde, : all I am saying is that in "StateList.h" it is necessary to create a STATE(arg1, arg2, arg3, arg4...)
  297. # [16:18] <@askalski> that matches 47th line of nsStateMap.h
  298. # [16:18] <@askalski> to achieve semantically equal code
  299. # [16:19] <@askalski> and this line will be included in States.h as well
  300. # [16:19] <@askalski> so I can either create a preprocesor if
  301. # [16:19] <@askalski> or generate a unnecessary state
  302. # [16:19] <@askalski> OR try to remove the 47th no-state from nsStateMap and hope it'll not break something
  303. # [16:21] <@tbsaunde> askalski: or after the #undef you could just add { kNone, kNoSuchState}
  304. # [16:22] <@tbsaunde> askalski: you'll break stuff ofr now unless you want to rewrite TranslateStates() in this bug
  305. # [16:22] <@tbsaunde> and while I think we should rewrite it, I think you can probably make it more effecient I think its better done in its own bug
  306. # [16:23] <@askalski> ok, i'll pick the option with undef for now
  307. # [16:23] <@askalski> ok?
  308. # [16:23] <@MarcoZ> CSUN stuff booked. Yay!
  309. # [16:24] <@tbsaunde> askalski: I suggested of course I think its fine
  310. # [16:24] <@tbsaunde> :)
  311. # [16:24] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
  312. # [16:29] * Quits: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp) (Quit: mike5w3c)
  313. # [16:32] * Joins: davidb (davidb@F2D29657.F60B0462.67AC9B1.IP)
  314. # [16:32] * ChanServ sets mode: +qo davidb davidb
  315. # [16:37] <@davidb> MarcoZ: those were good hotel rates.
  316. # [16:37] * Quits: @jprmc (jprmc@DB3A2AE9.5BCEC6DB.DA78B690.IP) (Ping timeout)
  317. # [16:38] <@askalski> ok, something that is on the States.h is named OPAQUE1, and in ATK it's named OPAQUE (in comment). is this "1" important, or can I remove it
  318. # [16:39] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
  319. # [16:40] <@askalski> there were also two other name differences between States.h and comments from nsStateMap.h, but I guess that having comments non-synchronized is something often an non harmful
  320. # [16:40] <@askalski> its state number (1 << 39)
  321. # [16:41] <@askalski> actually it's only a de-synchronized comment, so I guess nothing important
  322. # [16:41] <@askalski> tbsaunde, : can you read my last 3 messages?
  323. # [16:42] <@tbsaunde> askalski: yeah, was looking
  324. # [16:42] <@askalski> tbsaunde, : it's like in States.h OPAQUE1 is declared (as c++ name) and in nsStateMap it's called ATK_STATE_OPAQUE, and commented as OPAQUE which confused a python script I created to automatize merge
  325. # [16:43] <@askalski> I think we should keep the OPAQUE1 name, as this way only thing I change is a comment
  326. # [16:43] <@askalski> and not some code
  327. # [16:43] <@tbsaunde> askalski: yes, I agree
  328. # [16:43] <@askalski> ok
  329. # [16:43] <@tbsaunde> I think that's sillyness brought about by Windows.h poluting the global namespace with macros :\
  330. # [16:44] * Joins: victorporof (victorporo@2F385B41.6D2FB7A4.79933D60.IP)
  331. # [16:45] <@tbsaunde> so we named it OPAQUE1 called it states::OPAQUE in comments because that what it is, it built on windows and we were all happy
  332. # [16:48] <@askalski> ok
  333. # [16:48] <@askalski> should I also generate nsIAccessibleStates.idl the same way?
  334. # [16:48] <@askalski> I mean macro, include, undef ?
  335. # [16:50] * Joins: ehsan (ehsan@F2D29657.F60B0462.67AC9B1.IP)
  336. # [16:50] <@tbsaunde> askalski: as I understand it saddly you can't :(
  337. # [16:50] <@davidb> tbsaunde: on bug 672507 there are two patches, "part1" and "patch", is "part1" obsolete?
  338. # [16:50] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=672507 nor, --, ---, trev.saunders, NEW, merge nsIAccessNode and nsIAccessible
  339. # [16:50] <@tbsaunde> askalski: but what you can do is have a file that asserts that they are equivilent
  340. # [16:51] <@tbsaunde> davidb: looking
  341. # [16:51] <@askalski> I just write script that checks if it's binary compatible
  342. # [16:51] <@askalski> if yes, I can generate it
  343. # [16:51] <@askalski> if not, I can add two arguments to macro instead of one
  344. # [16:51] <@askalski> and generate it as well. you'll have a single list to all 3 files
  345. # [16:51] <@askalski> OR I can leave it as it is
  346. # [16:51] <@tbsaunde> askalski: I'm not sure I understand
  347. # [16:52] <@askalski> why it's impossible to generate the .idl file at end
  348. # [16:52] <@tbsaunde> askalski: what I'm suggesting is have a file that does #define STATE(state, xpcomstate) moz_static_assert(state == xpcomstate)
  349. # [16:53] <@tbsaunde> askalski: because it isn't run through cpp
  350. # [16:53] <@askalski> tbsaunde, : OK
  351. # [16:53] <@askalski> where to put it?
  352. # [16:53] <@tbsaunde> askalski: we use our own idl compiler on it
  353. # [16:53] <@tbsaunde> StateAsserts.cpp seem reasonable?
  354. # [16:53] <@tbsaunde> davidb: ^
  355. # [16:53] <@davidb> hmm
  356. # [16:53] <@davidb> yes
  357. # [16:54] <@tbsaunde> davidb: part 1 is obsolete
  358. # [16:54] <@davidb> ok ty
  359. # [16:54] <@tbsaunde> np
  360. # [16:54] <@davidb> regarding StateAsserts, the name sounds fine, I'm not sure of the machinery syntax, but you guys seems on top of that
  361. # [16:54] <@askalski> tbsaunde, ok
  362. # [16:55] <@davidb> (hi all!)
  363. # [16:56] <@tbsaunde> askalski: note xpcom uses two 32 bit uints instead of a 64 bit one, so you'll have to do somethign a little more complicated that ==
  364. # [16:58] <@tbsaunde> askalski: I'd probably be willing to take something that we can currently only compile on some platforms because of C++0x features being used
  365. # [16:58] * Joins: jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP)
  366. # [16:58] * ChanServ sets mode: +o jprmc
  367. # [16:58] <@tbsaunde> for that little bit because burning one platform is about as good as burning them all, and currently we don't burn any
  368. # [17:00] <@askalski> tbsaunde, : thanks for the info on two 32 bit units. about c++0x, do I really need to use it?
  369. # [17:01] <@tbsaunde> askalski: I'm not sure
  370. # [17:01] <@tbsaunde> I haven't thought about how to do it really
  371. # [17:02] <jhk> hi devidb
  372. # [17:02] <@askalski> tbsaunde, : in my experience it's pain. we're removing all c++0x dependencies from Habanero right now, as we cannot get any decent support on mobile platforms
  373. # [17:02] <@askalski> actually, we cannot get any decent support anywhere except visual studio :D
  374. # [17:03] <@askalski> ok
  375. # [17:03] <@tbsaunde> askalski: I wasn't saying you ahve to I was saying you could ;)
  376. # [17:04] <@tbsaunde> askalski: I believe we really like getting some support in gcc even for android for stuff like u"" since we have to deal with a lot of utf16 :/
  377. # [17:05] <@tbsaunde> but I suspose we'll probably have to keep supporting non c++0x compilers for a while for sun and stuff :p
  378. # [17:05] <@davidb> hi jhk
  379. # [17:05] <@davidb> jhk: what are you working on these days?
  380. # [17:07] <@tbsaunde> (the sun compiler is a little silly btw)
  381. # [17:08] <jhk> picking up a11y patches and working on it in my free school time :)
  382. # [17:08] <@davidb> jhk: perfect.
  383. # [17:13] * Joins: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com)
  384. # [17:14] <@tbsaunde> davidb: yeah, I'd expect that cid can go
  385. # [17:14] <@tbsaunde> (re bug 672507
  386. # [17:15] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=672507 nor, --, ---, trev.saunders, NEW, merge nsIAccessNode and nsIAccessible
  387. # [17:15] <@davidb> ok
  388. # [17:15] <@davidb> tbsaunde: i read over the comments, we'll want Alexander to look at this as well, agreed?
  389. # [17:17] <@davidb> i've stayed away from our ISimpleDOM stuff
  390. # [17:19] <@tbsaunde> ok
  391. # [17:19] <@tbsaunde> I don't think any of it should effect ISimpleDOMNode
  392. # [17:19] <@tbsaunde> but I might have missed it calling something in what I moved
  393. # [17:20] <@tbsaunde> I haven't tried to build it on windows yet, so
  394. # [17:21] <@askalski> tbsaunde, : I understood how nsIAccessibleStates.idl sets the vaues
  395. # [17:21] <@askalski> *vaues
  396. # [17:21] <@askalski> *values
  397. # [17:22] <@tbsaunde> askalski: ?
  398. # [17:22] <@askalski> should I create a 3 new arguments for the macro
  399. # [17:22] <@askalski> one for name, and two other for values
  400. # [17:22] <@askalski> or should I try to mix the two for values into one somehow
  401. # [17:22] <@askalski> which would be rather trickt
  402. # [17:22] <@askalski> *tricky
  403. # [17:23] <@askalski> because, from what I understand, it's just that EXT_ means a higher register, right?
  404. # [17:24] <@tbsaunde> well, EX_ meanss it goes in the second bit field
  405. # [17:24] <@tbsaunde> I'm not sure what the three arguments you want are
  406. # [17:24] <@askalski> name, bit_field_one, bit_field_two
  407. # [17:24] <@askalski> one of them set to none
  408. # [17:25] <@tbsaunde> askalski: the value of the xpcom state will be set in the idl
  409. # [17:25] <@tbsaunde> but a .h is generated from that idl
  410. # [17:25] <@MarcoZ> davidb: Yes indeed! You should get eeejay and hub to book ASAP if they definitely attend, so they can benefit from these, too.
  411. # [17:26] <@davidb> yep
  412. # [17:26] <@askalski> tbsaunde : which h?
  413. # [17:26] <@tbsaunde> askalski: nsIAccessibleStates.h
  414. # [17:26] <@davidb> askalski: usually the same filename minus the I
  415. # [17:26] <@tbsaunde> it should be in objdir/dist/include/
  416. # [17:26] * @davidb boots into windows
  417. # [17:27] <@askalski> tbsaunde, : ok, I can make both States.h and nsAccessibleStates.h to be dependant on StateList.h
  418. # [17:27] <@askalski> I understood that's what we want
  419. # [17:27] <@askalski> or what we want is just generating States.h from StateList.h, and asserting that nsAccessibleStates.h is fine with it?
  420. # [17:28] <@tbsaunde> so, what I think you want to do is moz_static_assert(state >> 32 ? state >> 32 == nsIAccessibleStates::EXT_STATE_##xpcomstatename : state == nsIAccessibleStates::STATE_##xpcomstatename
  421. # [17:29] <@tbsaunde> askalski: the second just asserting States.h and nsIAccessibleStates are lined up with it
  422. # [17:33] <@askalski> tbsaunde: ok, so which one should be macro-generated? so far it was just States.h, I am also prepared to generate nsStateMap
  423. # [17:34] <@askalski> or should I just leave nsStateMap alone
  424. # [17:34] <@askalski> because it's generated
  425. # [17:34] <@askalski> and make sure that lines up with states.h
  426. # [17:37] <@askalski> tbsaunde, : can you review it?
  427. # [17:37] <@askalski> tbsaunde, the last 3 messages I mean
  428. # [17:38] <@tbsaunde> askalski: you should generate nsStateMap.h
  429. # [17:38] <@askalski> OK
  430. # [17:55] <@tbsaunde> davidb: why do you bother run tests when reviewing? isn't that what we have build slaves for?
  431. # [17:56] <@davidb> i wanted to know faster
  432. # [17:56] <@davidb> it would take me the same time to construct the try syntax
  433. # [17:56] * Quits: Flyingmana (Mana@moz-3B83F238.adsl.alicedsl.de) (Quit: Verlassend)
  434. # [17:57] <@davidb> also, I'm more worried about some things than in this change, than usual.
  435. # [17:57] <@davidb> -than
  436. # [17:59] <@davidb> so far my worries (regarding jaws) are not warranted
  437. # [17:59] <@askalski> can you tell me what licence block I should use with newly-created files?
  438. # [18:00] <@tbsaunde> davidb: I'd be really suprised if it built and then something broke for jaws
  439. # [18:00] <@davidb> askalski: http://www.mozilla.org/MPL/boilerplate-1.1/mpl-tri-license-c
  440. # [18:00] <@davidb> tbsaunde: yeah i was on a wild goose chase
  441. # [18:00] <@tbsaunde> davidb: I don't usually push patches I'm reviewing to try either
  442. # [18:01] <@davidb> me neither
  443. # [18:01] <@tbsaunde> I figure either they not broken and can land, or my review is not relavent because they can't land anyway
  444. # [18:01] <@davidb> I often don't even build them.
  445. # [18:01] * Joins: hub (hub@83874EA1.EB7C1AF9.6F478678.IP)
  446. # [18:01] * ChanServ sets mode: +o hub
  447. # [18:01] <@askalski> what should I put into "the original code is"
  448. # [18:02] <@davidb> askalski: here's a fairly new example http://mxr.mozilla.org/mozilla-central/source/accessible/src/html/nsHTMLCanvasAccessible.h
  449. # [18:02] <@tbsaunde> mozilla.org code
  450. # [18:02] <@tbsaunde> I think we can use mpl 2.0 if you want to but it might be worth checking
  451. # [18:02] <@davidb> I have a silly habit of not adding my name, but it is common practise to add your name at least under Contributors
  452. # [18:03] <@davidb> tbsaunde: yes!
  453. # [18:03] <@davidb> askalski, tbsaunde http://www.mozilla.org/MPL/headers/
  454. # [18:03] <@davidb> ignore that 1.1 link
  455. # [18:03] <@tbsaunde> davidb: I suspect in that case its the tests being broken not the patch, but I'll look later
  456. # [18:04] <@MarcoZ> davidb: I was worried for a bit that that nsIAccessNode breakage might impact ISimpleDOM, too, which would have broken JAWS. But good that it isn't! :)
  457. # [18:05] <@davidb> MarcoZ: yeah, did you get a chance to play with it?
  458. # [18:05] <@davidb> I'm not a power user by any means
  459. # [18:05] <@MarcoZ> davidb: Nope I wasn't actually following that bug closely.
  460. # [18:05] <@MarcoZ> davidb: I just saw your test results in bugmail after I saw you and tbsaunde chat about it here.
  461. # [18:05] <@davidb> Jaws 13 is pretty good I have to say.
  462. # [18:06] <@MarcoZ> davidb: As long as you get a virtual cursor things are usually OK.
  463. # [18:06] <@MarcoZ> (oh yeah and content within it).
  464. # [18:06] <@davidb> heh
  465. # [18:07] * @MarcoZ just updated his Hyatt Gold Passport profile. With that, I have free WiFi at the Hyatt.
  466. # [18:08] <@askalski> ok, I am finishing for today. I have nsStateMap.h and States.h generated, it compiles, no tests yet
  467. # [18:09] <@askalski> I can either do some tests and send it to review
  468. # [18:09] <@askalski> OR add assertions and send you entire package during weekend
  469. # [18:09] <@askalski> tbsaunde, which one you prefer?
  470. # [18:15] <@tbsaunde> askalski: add assertions and post the whole thing on the bug when your done
  471. # [18:15] <@askalski> ok
  472. # [18:15] <@tbsaunde> (no hurry)
  473. # [18:15] <@askalski> so have a nice weekend all
  474. # [18:16] <@askalski> I'm checking e-mail and phone regularly
  475. # [18:16] <@askalski> bye
  476. # [18:17] <@askalski> btw, where should I add new c++ file to get it compiled
  477. # [18:17] <@askalski> ?
  478. # [18:19] * Quits: @askalski (akuda@moz-BE7A9C8B.neoplus.adsl.tpnet.pl) (Quit: Wychodzi)
  479. # [18:28] * @MarcoZ is also off for the weekend.
  480. # [18:28] * Quits: @MarcoZ (marco.zehe@moz-C2CEF848.dip.t-dialin.net) (Quit: Weekend!)
  481. # [18:36] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
  482. # [18:56] <@firebot> trev.saunders@gmail.com denied review for attachment 588246 on bug 712923.
  483. # [18:56] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=712923 nor, --, ---, hub, NEW, [Mac] Heading elements h1 through h6 are not recognizable by VoiceOver
  484. # [18:58] * Joins: Liviu (chatzilla@677D9D6B.81049FCA.AE2C764A.IP)
  485. # [18:58] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
  486. # [19:01] * Quits: Liviu (chatzilla@677D9D6B.81049FCA.AE2C764A.IP) (Quit: ChatZilla 0.9.88 [Firefox 9.0.1/20111220165912])
  487. # [19:07] * davidb is now known as david|mtg
  488. # [19:46] * Quits: clown (clown@67828CC7.C1A51174.9D42CF23.IP) (Quit: Leaving.)
  489. # [19:46] * Quits: @hub (hub@83874EA1.EB7C1AF9.6F478678.IP) (Input/output error)
  490. # [19:59] * Quits: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com) (Ping timeout)
  491. # [20:00] * Joins: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com)
  492. # [20:02] * Quits: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com) (Ping timeout)
  493. # [20:02] * Joins: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com)
  494. # [20:04] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Ping timeout)
  495. # [20:05] * Quits: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com) (Ping timeout)
  496. # [20:09] * Joins: hub (hub@21B7B9F2.B87E9213.6E712CE2.IP)
  497. # [20:09] * ChanServ sets mode: +o hub
  498. # [20:12] * Joins: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com)
  499. # [20:16] * Joins: hub_ (hub@21B7B9F2.B87E9213.6E712CE2.IP)
  500. # [20:17] * Quits: @hub (hub@21B7B9F2.B87E9213.6E712CE2.IP) (Ping timeout)
  501. # [20:18] * hub_ is now known as hub
  502. # [20:18] * david|mtg is now known as davidb
  503. # [20:21] <@eeejay> how do the three platform names mean that house the accessible.properties?
  504. # [20:21] <@eeejay> unix/mac/win
  505. # [20:21] <@eeejay> i don't see where it is decided which one is used
  506. # [20:24] <hub> I think it is at build time
  507. # [20:25] <@eeejay> hub, they all seem to go into the jar
  508. # [20:25] <hub> weird
  509. # [20:25] <@eeejay> hub, so when are they actually selected? need to know because i want to create a fourth android one
  510. # [20:26] <@eeejay> plus, when are the current action strings in the bundle used? i don't see that either
  511. # [20:27] <@tbsaunde> hm, want me to go digging eeejay
  512. # [20:28] <@eeejay> tbsaunde, don't worry about it, i could dig as well. thought maybe someone here already knows
  513. # [20:31] * Quits: Hixie (ianh@moz-E9FB2A6A.no) (Quit: reloading configuration)
  514. # [20:31] * Joins: Hixie (ianh@moz-E9FB2A6A.no)
  515. # [20:34] <@tbsaunde> eeejay: for how the jar stuff works ask pike, or maybe khuey when he isn't away
  516. # [20:35] <@tbsaunde> where the action strings get used GetActionName() returns one then GetTranslatedstring() converts
  517. # [20:35] <@eeejay> tbsaunde, cool
  518. # [20:46] * Joins: clown (clown@67828CC7.C1A51174.9D42CF23.IP)
  519. # [20:53] * Joins: clown1 (clown@6EDD3027.A6295926.9D42CF23.IP)
  520. # [20:54] * Quits: clown (clown@67828CC7.C1A51174.9D42CF23.IP) (Ping timeout)
  521. # [21:05] * clown1 is now known as clown
  522. # [21:22] <@firebot> bolterbugz@gmail.com granted review for attachment 587334 on bug 672507.
  523. # [21:23] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=672507 nor, --, ---, trev.saunders, NEW, merge nsIAccessNode and nsIAccessible
  524. # [21:23] <@davidb> oh, firebot woke up
  525. # [21:23] * @davidb pats firebot
  526. # [21:23] <@firebot> :)
  527. # [21:25] <@firebot> bolterbugz@gmail.com granted review for attachment 588113 on bug 717689.
  528. # [21:25] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=717689 nor, --, ---, trev.saunders, NEW, unneeded nsCOMPtrs to nsAccessibles
  529. # [21:25] <@tbsaunde> davidb: ok, I've been taking a break mostly the last hour or so, I'll get the stuff finished this weekend, but I think I'm going to try and deal with eeejay's stuff today instead
  530. # [21:25] <@davidb> sounds great.
  531. # [21:49] * Quits: richardschwerdtfeger (richardsch@moz-130F1494.lightspeed.austtx.sbcglobal.net) (Quit: richardschwerdtfeger)
  532. # [21:54] <@firebot> bolterbugz@gmail.com granted review for attachment 588138 on bug 717683.
  533. # [21:54] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=717683 nor, --, ---, trev.saunders, NEW, get rid of nsIAccessibleDocument uses
  534. # [21:55] <@firebot> bolterbugz@gmail.com granted review for attachment 588101 on bug 717683.
  535. # [21:56] <@firebot> bolterbugz@gmail.com granted review for attachment 588104 on bug 717683.
  536. # [21:58] <@firebot> bolterbugz@gmail.com granted review for attachment 588109 on bug 717683.
  537. # [22:02] <@tbsaunde> davidb: usually when I touch stuff in atk/ Alex wants things rewritten using 2 space tabs
  538. # [22:02] <@davidb> fine with me
  539. # [22:04] <@tbsaunde> yeah, just figured you should know :)
  540. # [22:06] <@davidb> it is good to know
  541. # [22:07] <@tbsaunde> how did you find out about stuff going on with nsIView?
  542. # [22:09] <@davidb> tbsaunde: https://wiki.mozilla.org/Platform/2012-Q1-Goals
  543. # [22:09] <@davidb> gotta keep an eye on these layout dudes :)
  544. # [22:09] <@davidb> tn actually shattered us in the past, but it wasn't on purpose
  545. # [22:43] * Joins: aaronlev (aaronlev@moz-CDA191A6.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com)
  546. # [22:43] * ChanServ sets mode: +o aaronlev
  547. # [22:47] * Quits: geo (geo@moz-BBE3ABD.mv.mozilla.com) (NickServ (GHOST command used by geo-))
  548. # [22:48] * Joins: geo- (geo@moz-E31CD2CB.mozilla.org)
  549. # [22:51] * Parts: clown (clown@6EDD3027.A6295926.9D42CF23.IP)
  550. # [22:52] * Quits: geo- (geo@moz-E31CD2CB.mozilla.org) (Ping timeout)
  551. # [22:54] * Joins: geo- (geo@moz-E31CD2CB.mozilla.org)
  552. # [22:54] * Quits: @davidb (davidb@F2D29657.F60B0462.67AC9B1.IP) (Quit: davidb)
  553. # [22:54] * Quits: @aaronlev (aaronlev@moz-CDA191A6.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com) (Quit: aaronlev)
  554. # [23:26] * Quits: victorporof (victorporo@2F385B41.6D2FB7A4.79933D60.IP) (Ping timeout)
  555. # [23:26] * Joins: victorporo (victorporo@68C3E041.6465CCD9.79933D60.IP)
  556. # [23:26] * victorporo is now known as victorporof
  557. # [23:31] <@firebot> hub@mozilla.com requested review from trev.saunders@gmail .com for attachment 588526 on bug 712923.
  558. # [23:31] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=712923 nor, --, ---, hub, NEW, [Mac] Heading elements h1 through h6 are not recognizable by VoiceOver
  559. # [23:35] * Quits: @firebot (firebot@moz-67BF9FE6.carolina.res.rr.com) (Quit: I was told to shutdown by Wolf. :-( )
  560. # [23:36] * Joins: firebot (firebot@moz-67BF9FE6.carolina.res.rr.com)
  561. # [23:36] * ChanServ sets mode: +o firebot
  562. # [23:37] * Quits: @firebot (firebot@moz-67BF9FE6.carolina.res.rr.com) (Client exited)
  563. # [23:38] * Quits: @jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP) (Quit: Leaving)
  564. # [23:39] * Joins: firebot (firebot@moz-67BF9FE6.carolina.res.rr.com)
  565. # [23:39] * ChanServ sets mode: +o firebot
  566. # [23:44] * Quits: @firebot (firebot@moz-67BF9FE6.carolina.res.rr.com) (Quit: someone seems to have changed my source code. brb, unless I get a compile error!)
  567. # [23:44] * Joins: firebot (firebot@moz-67BF9FE6.carolina.res.rr.com)
  568. # [23:44] * ChanServ sets mode: +o firebot
  569. # [23:58] * Quits: geo- (geo@moz-E31CD2CB.mozilla.org) (Ping timeout)
  570. # Session Close: Sat Jan 14 00:00:00 2012

The end :)