/irc-logs / mozilla / #accessibility / 2012-01-16 / end
Options:
- # Session Start: Mon Jan 16 00:00:00 2012
- # Session Ident: #accessibility
- # [00:34] * Joins: mdcurran (mick@moz-C48DC1F2.static.tpgi.com.au)
- # [00:51] * Quits: victorporof (victorporo@F39541EA.9F23B8E6.79933D60.IP) (Ping timeout)
- # [00:54] * Joins: victorporof (victorporo@E25ABA60.880C8D58.79933D60.IP)
- # [01:05] * Quits: victorporof (victorporo@E25ABA60.880C8D58.79933D60.IP) (Ping timeout)
- # [02:16] * Quits: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp) (Quit: mike5w3c)
- # [02:37] * Joins: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp)
- # [02:44] * Quits: mdcurran (mick@moz-C48DC1F2.static.tpgi.com.au) (Connection reset by peer)
- # [03:28] * Quits: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp) (Quit: mike5w3c)
- # [03:35] * Joins: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp)
- # [03:49] * Quits: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp) (Quit: mike5w3c)
- # [03:55] * Joins: mike5w3c (MikeS@moz-AD60DCA.keio.w3.org)
- # [05:27] * Quits: reuben (reuben@seta00.com) (Ping timeout)
- # [05:28] * Joins: reuben (reuben@seta00.com)
- # [06:11] * Quits: firebot (firebot@moz-67BF9FE6.carolina.res.rr.com) (Ping timeout)
- # [06:13] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [06:48] * Quits: mike5w3c (MikeS@moz-AD60DCA.keio.w3.org) (Quit: mike5w3c)
- # [07:23] * Joins: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp)
- # [07:34] * khuey|away is now known as khuey
- # [08:00] * Joins: victorporof (victorporo@169A7BEF.6465CCD9.79933D60.IP)
- # [08:07] * Quits: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp) (Quit: mike5w3c)
- # [08:12] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [08:21] * Joins: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp)
- # [08:30] * Joins: firebot (firebot@moz-67BF9FE6.carolina.res.rr.com)
- # [08:30] * ChanServ sets mode: +o firebot
- # [08:40] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [08:53] * Joins: sgimeno (santiago.g@A922400D.48362F18.BCC03455.IP)
- # [09:02] * Quits: Jamie (jamie@moz-CA26021.jantrid.net) (Quit: leaving)
- # [09:08] * Joins: MarcoZ (marco.zehe@moz-900A5E73.dip.t-dialin.net)
- # [09:08] * ChanServ sets mode: +o MarcoZ
- # [09:09] <@MarcoZ> Good day all!
- # [09:09] <@tbsaunde> morning MarcoZ
- # [09:12] <@MarcoZ> tbsaunde: Hi Trevor!
- # [09:17] * Joins: mdcurran (mick@moz-C48DC1F2.static.tpgi.com.au)
- # [09:54] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Ping timeout)
- # [09:56] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [10:54] * Joins: surkov (surkov@F6C60776.8F955B94.FE58E87C.IP)
- # [10:54] * ChanServ sets mode: +o surkov
- # [10:55] * Quits: victorporof (victorporo@169A7BEF.6465CCD9.79933D60.IP) (Ping timeout)
- # [10:58] <@tbsaunde> surkov: surkov !
- # [10:58] <@surkov> hi, tbsaunde!
- # [11:01] <@MarcoZ> surkov! Welcome back!
- # [11:01] <@surkov> hey, MarcoZ! how is it going?
- # [11:04] <@tbsaunde> surkov: I'm sort of, you?
- # [11:05] <@surkov> yep
- # [11:06] <@tbsaunde> err, where did that ok go to
- # [11:09] * Joins: firewolfbot (firebot@moz-67BF9FE6.carolina.res.rr.com)
- # [11:10] * Quits: @firebot (firebot@moz-67BF9FE6.carolina.res.rr.com) (Ping timeout)
- # [11:11] <@surkov> tbsaunde: sorry failed to translate last phrase
- # [11:11] * Quits: firewolfbot (firebot@moz-67BF9FE6.carolina.res.rr.com) (Ping timeout)
- # [11:13] <@tbsaunde> surkov: ignore it :)
- # [11:13] <@tbsaunde> it wasn't important
- # [11:13] <@surkov> might be nice for english skills :)
- # [11:14] <@MarcoZ> surkov: I'm fine, thanks! And we're making progress on Mac and Android. :)
- # [11:15] <@surkov> excellent!
- # [11:15] <@MarcoZ> surkov: tbsaunde was just asking himself where the word "OK" went in his reply to you. It somehow wasn't written out.
- # [11:15] <@tbsaunde> I was correcting my "I'm sort of," to "I'm sort of ok"
- # [11:15] <@surkov> got it :)
- # [11:16] <@surkov> thanks
- # [11:16] * Joins: firewolfbot (firebot@moz-67BF9FE6.carolina.res.rr.com)
- # [11:16] <@tbsaunde> np
- # [11:16] <@tbsaunde> man, that traversal stuff is really complicated
- # [11:18] <@MarcoZ> tbsaunde: Re your question about the spec in bug 712923, Apple doesn't provide a complete spec about how headings and such are to be coded in non-cocoa-applications. So what we have to do here is copy Safari's behavior. And that we can only do by inspection, without asking too many questions. ;-)
- # [11:18] <firewolfbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=712923 nor, --, ---, hub, NEW, [Mac] Heading elements h1 through h6 are not recognizable by VoiceOver
- # [11:19] <@MarcoZ> tbsaunde: So if the answer to a question is 2Safari does it this way", we have to take it face value and just do the same thing.
- # [11:22] * @tbsaunde doesn't remember asking about a spec in that question
- # [11:22] * Quits: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp) (Quit: mike5w3c)
- # [11:22] <@tbsaunde> err, s/question/bug/
- # [11:23] <@surkov> tbsaunde: what's the status of traversal stuffs?
- # [11:24] <@tbsaunde> surkov: trying to review patches when I can
- # [11:24] <@surkov> ok, so API is finished?
- # [11:24] <@tbsaunde> its all tricky, and eeejay is new to xpcom sort it takes time
- # [11:24] <@tbsaunde> I think so
- # [11:25] <@surkov> ok, sounds good
- # [11:26] <@tbsaunde> which is to say I think the proposed api's are fairly reasonable for a concept I don't think is really a good one
- # [11:26] <@tbsaunde> the events and observer is a little weird, but shrug
- # [11:27] <@tbsaunde> MarcoZ: oh, so I did ask about a spec in that bug, but I was refering to the C++ spec or maybe the objective C++ one
- # [11:27] * Joins: Flyingmana (Mana@moz-908C9B1C.adsl.alicedsl.de)
- # [11:27] <@surkov> ok, I'll take a look, is there updated wiki?
- # [11:28] <@tbsaunde> I'm not sure if the wiki is up to date
- # [11:28] <@tbsaunde> you could just read the idl in the patches, it should be the first thing in each
- # [11:29] <@MarcoZ> tbsaunde: Ah you were asking about Objective-C++! I thought you were asking about the Universal Access spec. (and I believe so was Hub). ;-)
- # [11:30] <@tbsaunde> ok
- # [11:32] <@tbsaunde> also, ugh, I wish voice over didn't require us to setup that bizar setup :\
- # [11:43] * Quits: firewolfbot (firebot@moz-67BF9FE6.carolina.res.rr.com) (Ping timeout)
- # [11:43] <@MarcoZ> tbsaunde: Believe me, if you look at some of the stuff we need to do for Windows, you also want to puke. :)
- # [11:47] * Joins: firewolfbot (firebot@moz-67BF9FE6.carolina.res.rr.com)
- # [11:51] * Quits: @surkov (surkov@F6C60776.8F955B94.FE58E87C.IP) (Quit: surkov)
- # [11:57] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [12:01] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [12:13] * Joins: Stevef (chatzilla@moz-FBEAB712.croy.cable.virginmedia.com)
- # [12:14] <Stevef> morning all!
- # [12:14] <Stevef> is any work being done on firefox on mac accessibility?
- # [12:21] <@tbsaunde> Stevef: some, talk to hub when he shows up in say 6 hrs
- # [12:22] <Stevef> tbsaunde: thanks, so nothing implemented as yet? have tested and found nothing in latest nightly so I presume not
- # [12:23] <@tbsaunde> Stevef: well, there's plenty of stuff implemented, but we don't build it in release builds
- # [12:23] <Stevef> right thanks again
- # [12:23] <@tbsaunde> np
- # [12:23] <Stevef> look forward to tesing it when available
- # [12:28] * Quits: Stevef (chatzilla@moz-FBEAB712.croy.cable.virginmedia.com) (Quit: ChatZilla 0.9.87 [Firefox 9.0.1/20111220165912])
- # [12:30] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Ping timeout)
- # [12:49] * Joins: askalski (akuda@moz-95875962.neoplus.adsl.tpnet.pl)
- # [12:49] * ChanServ sets mode: +o askalski
- # [12:49] <@askalski> morning everyone
- # [12:50] <@tbsaunde> askalski: morning
- # [12:50] <@askalski> tbsaunde, : can you tell me where xpcom states are located?
- # [12:51] <@askalski> I should just assert their number, or also 1:1 reference?
- # [12:51] <@askalski> tbsaunde, : ok, i remeber
- # [12:51] <@tbsaunde> askalski: so, actually no questions then?
- # [12:52] <@askalski> you can correct me if I am wrong. the xpcom_States are in nsIAcceessibleStates.idl
- # [12:52] <@askalski> and I should expand a macro to do mapping 1:1 xpcom to our states, and then assert in stateassert.cpp that everything is right (static assert)
- # [12:52] <@askalski> right?
- # [12:53] <@tbsaunde> askalski: I think so
- # [12:54] <@askalski> tbsaunde, :ok, I'm on it and will ask for your review soon.
- # [12:54] <@tbsaunde> ok, cool
- # [13:16] <@askalski> tbsaunde, : Ok, there is a small issue
- # [13:16] <@askalski> I can either append xpcom name in macro OR I can use preprocessor definitions to build it from statename adding a proper prefix
- # [13:17] <@tbsaunde> I'd prefer you build it from the state name if you can
- # [13:17] <@askalski> OK. btw, is it possible to expand a macro like STATE into a static pre-processor definitions
- # [13:18] * Quits: mdcurran (mick@moz-C48DC1F2.static.tpgi.com.au) (Connection reset by peer)
- # [13:18] <@askalski> I understand, that static assert is a preprocessor definition, right?
- # [13:18] <@tbsaunde> or if that won't work because some names don't exactly line up passing in FOO wand then using the macro to make that nsIAccessibleStates::STATE_FOO would be better than passing in nsIAccessibleStates::STATE_FOO
- # [13:19] <@tbsaunde> askalski: I'm not sure what you mean
- # [13:19] <@askalski> ok 1), I dont understand your last message
- # [13:19] <@askalski> 2)
- # [13:19] <@tbsaunde> askalski: static_assert is a macro that uses static_assert if the compiler supports it or other tricks if not
- # [13:19] <@askalski> static assert is a preprocessor, compile-time check
- # [13:19] <@askalski> right?
- # [13:19] <@askalski> ok
- # [13:19] <@tbsaunde> askalski: yes static_assert is compile time
- # [13:20] <@askalski> so, if I have file of lines like STATE(REQUIRED, 26, ATK_STATE_REQUIRED, kMapDirectly)
- # [13:20] <@askalski> (and possibly XPCOMname)
- # [13:20] <@askalski> is it possible to expand these lines using #define into pre-processor definitions?
- # [13:20] <@askalski> or should I use some kind of templates or something
- # [13:21] <@tbsaunde> askalski: you can define the macro StATE() to expand them as you like
- # [13:22] <@askalski> ah right
- # [13:22] <@tbsaunde> but I'm not sure what you mean by "pre-processor definitions?'
- # [13:23] <@askalski> I just thought that if i expand macro state into another macro (static assert) the second one might not get propely expanded
- # [13:23] <@askalski> but I guess that's not a problem
- # [13:24] <@tbsaunde> no, having one macro use another is fine
- # [13:34] <@askalski> I noticed that XPCOM does not use highest one bit
- # [13:34] <@askalski> so I need to do a shift of 31 not 32
- # [13:34] <@askalski> does that sound reasonable?
- # [13:35] <@askalski> the #31 state (SUPPORTS_AUTOCOMPLETION) is the first one with EXT, and if I do 31 shift and use (> 31) instead of (> 32) test names matches (I'm testing in python)
- # [13:39] <@tbsaunde> I could believe that
- # [13:41] <@askalski> ok, not compatible names :"STATE_CHECKABLE" and "STATE_MARQUEED".
- # [13:41] <@askalski> not compatible names :"STATE_REQUIRED" and "STATE_ALERT_LOW".
- # [13:41] <@askalski> not compatible names :"STATE_ALERT" and "STATE_ALERT_MEDIUM".
- # [13:41] <@askalski> not compatible names :"STATE_INVALID" and "STATE_ALERT_HIGH".
- # [13:41] <@askalski> not compatible names :"EXT_STATE_OPAQUE1" and "EXT_STATE_OPAQUE".
- # [13:41] <@askalski> I can't rely on generation, these 5 would be wrong
- # [13:42] <@askalski> I need to add the fifth argument to a macro, and I can expand it only to check numerical compatibility if desired
- # [13:43] <@askalski> to be more precise:
- # [13:43] <@askalski> not compatible names : (13) "STATE_CHECKABLE" and "STATE_MARQUEED".
- # [13:43] <@askalski> not compatible names : (26) "STATE_REQUIRED" and "STATE_ALERT_LOW".
- # [13:43] <@askalski> not compatible names : (27) "STATE_ALERT" and "STATE_ALERT_MEDIUM".
- # [13:43] <@askalski> not compatible names : (28) "STATE_INVALID" and "STATE_ALERT_HIGH".
- # [13:43] <@askalski> not compatible names : (39) "EXT_STATE_OPAQUE1" and "EXT_STATE_OPAQUE".
- # [13:44] <@askalski> 26 and 28 makes no sense to me
- # [13:44] <@askalski> oh, false alarm
- # [13:44] <@askalski> there are alternative names for these
- # [13:44] <@askalski> aliases I mean
- # [13:45] <@askalski> for REQUIRED and INVALID
- # [13:45] <@askalski> ALERT and OPAQUE will still cause errors
- # [13:46] <@askalski> tbsaunde, : so I am expanding macro and testing for numeric compatiblity, OK?
- # [13:46] <@askalski> I can leave these finding in comment
- # [13:46] <@askalski> tbsaunde, (by expanding I mean "adding new argument")
- # [13:53] <@tbsaunde> askalski: yeah, add a new argument
- # [13:54] <@tbsaunde> the OPAQUE one makes a lot of sense, the ALERT one I'm not sure why that doesn't match
- # [13:54] <@tbsaunde> the aliasing is because those states are technically something else in msaa, but we use them for our own purposes
- # [13:55] <@tbsaunde> I'm not sure why there in the xpcom idl, but I'm sure that happened long ago and probably isn't worth thinking about
- # [14:14] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [14:17] <firewolfbot> dao@mozilla.com requested review from marco.zehe@googlema il.com for attachment 588848 on bug 715857.
- # [14:17] <firewolfbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=715857 nor, --, ---, dao, ASSI, Disable a11y tests that put <tabbrowser> in random XUL documents and expect it to work
- # [14:20] <@askalski> tbsaunde, : how to add StateAsserts.cpp to build?
- # [14:20] <@askalski> I do:
- # [14:20] <@askalski> #define STATE(name_, number_, atkState_, atkMappingType_, xpcomStateName_) \
- # [14:20] <@askalski> moz_static_assert(number_ < 31 \
- # [14:20] <@askalski> ? 1 << number_ == nsIAccessibleStates::xpcomStateName_ \
- # [14:20] <@askalski> : 1 << (number_ - 31) == nsIAccessibleStates::xpcomStateName_ )
- # [14:20] <@askalski> #include "States.h"
- # [14:20] <@askalski> #undef STATE
- # [14:22] <@askalski> tbsaunde, : found it in Makefile
- # [14:23] * Quits: @askalski (akuda@moz-95875962.neoplus.adsl.tpnet.pl) (Quit: Wychodzi)
- # [14:23] <firewolfbot> marco.zehe@googlemail.com granted review for attachment 588848 on bug 715857.
- # [14:25] * Joins: askalski (akuda@moz-95875962.neoplus.adsl.tpnet.pl)
- # [14:25] * ChanServ sets mode: +o askalski
- # [14:25] <@askalski> where moz_static_assert is defined?
- # [14:26] <@tbsaunde> askalski: mfbt/Asserts.h iirc
- # [14:27] <@tbsaunde> you want to include mozilla/Assertions.h then I'd think
- # [14:27] <@askalski> so second or both?
- # [14:28] <@tbsaunde> askalski: that seems right, but usually we do x ?\n y : z; not x
- # [14:29] <@tbsaunde> n ? y : z;
- # [14:29] <@askalski> tbsaunde, : I found mbft/Assertions.h with MOZ_STATIC_ASSERT
- # [14:29] <@tbsaunde> askalski: second
- # [14:30] <@tbsaunde> but the first is where it actually lives till the build copies it into objdir/dist/include/mozilla/
- # [14:31] <@askalski> tbsaunde, : can you explain me what " but usually we do x ?\n y : z; not x" means?
- # [14:32] <@askalski> tbsaunde, : I always thought about ? : as "if then else"
- # [14:33] <@tbsaunde> askalski: I mean '?' goes on the first line not the second
- # [14:33] <@tbsaunde> at the end
- # [14:33] <@askalski> ah ,formatting
- # [14:33] <@askalski> got it
- # [14:35] <@askalski> tbsaunde, : ok, I include mozilla/Assertion.h
- # [14:36] <@askalski> it does not find moz_static_assert, and MOZ_STATIC_ASSERT required two arguments
- # [14:36] <@askalski> and I can't find this file in source tree
- # [14:38] <@askalski> tbsaunde, : ah, "reason", I guess it's error message, right?
- # [14:39] <@tbsaunde> askalski: I assume
- # [14:39] <@tbsaunde> askalski: and mfbt/ is where to look
- # [14:39] <@askalski> tbsaunde, : my proposal is "xpcom State Name does not line up with a11y state name"
- # [14:40] <@askalski> *state number
- # [14:40] <@askalski> twice
- # [14:41] <@tbsaunde> askalski: that seems sort of ok
- # [14:42] <@tbsaunde> askalski: how would you feel about "xpcom and internals states don't match"
- # [14:42] * Joins: surkov (surkov@F6C60776.8F955B94.FE58E87C.IP)
- # [14:42] * ChanServ sets mode: +o surkov
- # [14:42] <@askalski> tbsaunde, : ok
- # [14:43] <@askalski> tbsaunde, : now I have a tiny problem, it doesn't seem to be a "c-string" argument
- # [14:43] <@askalski> I mean passing "error message" gives
- # [14:43] <@askalski> error: expected unqualified-id before string constant
- # [14:45] <@askalski> oh, I guess I was missing semicolon or something
- # [14:46] <firewolfbot> dao@mozilla.com changed the Target Milestone on bug 715857 from --- to mozilla12.
- # [14:46] <firewolfbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=715857 nor, --, mozilla12, dao, ASSI, Disable a11y tests that put <tabbrowser> in random XUL documents and expect it to work
- # [14:46] <@tbsaunde> what did you have before it in the macro?
- # [14:49] <@tbsaunde> askalski: ?
- # [14:49] <@askalski> it just compiled
- # [14:49] <@askalski> I was missing semicolons and made newline in a wrong place
- # [14:49] <@askalski> I will mess it for a moment to chceck if it ever fails
- # [14:50] <@tbsaunde> ok, sounds good
- # [14:50] <@askalski> and if I confirm it does the job, I'll run the tests
- # [14:50] <@askalski> and post it to bugzilla
- # [14:50] <@tbsaunde> ok, I'm about to head for a while, good luck
- # [14:50] * tbsaunde is now known as tbsaunde|afk
- # [14:51] * Quits: @askalski (akuda@moz-95875962.neoplus.adsl.tpnet.pl) (Quit: Wychodzi)
- # [15:18] <@MarcoZ> surkov: Hi! You might want to have a read of bug 415857. I took a look at the browser-chrome tests, and am not sure this is really what we can use for those tests that are now disabled.
- # [15:18] <firewolfbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=415857 nor, --, ---, nobody, RESO INCOMPLETE, Secure indicators remain even when plain HTTP redirects occurred
- # [15:18] * Joins: davidb (davidb@F2D29657.F60B0462.67AC9B1.IP)
- # [15:18] * ChanServ sets mode: +qo davidb davidb
- # [15:18] <@MarcoZ> surkov: err, bug 715857.
- # [15:18] <@surkov> MarcoZ: sure
- # [15:18] <@davidb> hi all!
- # [15:18] <@davidb> hi surkov!
- # [15:18] <@surkov> hi, davidb!
- # [15:18] <firewolfbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=715857 nor, --, mozilla12, dao, ASSI, Disable a11y tests that put <tabbrowser> in random XUL documents and expect it to work
- # [15:19] <@davidb> (surkov: how's Moscow?)
- # [15:19] <@MarcoZ> Hi davidb!
- # [15:19] <@davidb> heyo!
- # [15:19] <@surkov> pretty big
- # [15:19] <@davidb> heheh
- # [15:19] <@davidb> understatement
- # [15:20] <@surkov> :)
- # [15:24] * Joins: clown (clown@67828CC7.C1A51174.9D42CF23.IP)
- # [15:36] * @MarcoZ reads up on browser-chrome tests and thinks....This is not exactly what we need. Hmm...
- # [15:39] <@davidb> MarcoZ: why not?
- # [15:40] <@MarcoZ> I am not sure we can also test website content from within these browser chrome tests.
- # [15:41] <@MarcoZ> s/web site/web page/
- # [15:41] <@MarcoZ> davidb: ^
- # [15:41] <@davidb> MarcoZ: well, we wouldn't move all our tests there, just the browsery ones
- # [15:41] * davidb is now known as davidb|phone
- # [15:50] <@MarcoZ> davidb|phone: Yes but even these need website content IIRC.
- # [15:51] * Joins: askalski (akuda@moz-95875962.neoplus.adsl.tpnet.pl)
- # [15:51] * ChanServ sets mode: +o askalski
- # [16:05] <@davidb|phone> ok
- # [16:05] * davidb|phone is now known as davidb
- # [16:06] * clown is now known as clown_mtg
- # [16:12] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [16:12] * Quits: @surkov (surkov@F6C60776.8F955B94.FE58E87C.IP) (Quit: surkov)
- # [16:13] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [16:26] <@askalski> tbsaunde|afk, : submited, I'm going to lunch
- # [16:27] <@askalski> davidb, : hi david, just submitted first patch, I'll start with another any moment
- # [16:28] <@davidb> askalski: great!
- # [16:28] <@davidb> askalski: do you know how to request review?
- # [16:29] <@davidb> https://developer.mozilla.org/En/Developer_Guide/How_to_Submit_a_Patch#Getting_Reviews
- # [16:39] * tbsaunde|afk is now known as tbsaunde
- # [16:40] * Quits: @askalski (akuda@moz-95875962.neoplus.adsl.tpnet.pl) (Ping timeout)
- # [16:40] * Joins: askalski (akuda@moz-73488749.neoplus.adsl.tpnet.pl)
- # [16:40] * ChanServ sets mode: +o askalski
- # [16:51] <@tbsaunde> askalski: I have some nits, but that patch generally looks good :)
- # [17:07] * Joins: victorporof (victorporo@42388712.7E2AA079.79933D60.IP)
- # [17:19] <@davidb> firewolfbot: hi
- # [17:19] <firewolfbot> davidb: hello
- # [17:22] * Joins: hub (hub@83874EA1.EB7C1AF9.6F478678.IP)
- # [17:22] * ChanServ sets mode: +o hub
- # [17:24] * clown_mtg is now known as clown
- # [17:29] <@MarcoZ> Hi hub!
- # [17:29] <@davidb> heyo
- # [17:29] <@hub> hi
- # [17:29] * Quits: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com) (Ping timeout)
- # [17:38] * khuey is now known as khuey|away
- # [17:40] <@askalski> I need to pick someone from airport, I will be back at work in two hours
- # [17:41] * Quits: @askalski (akuda@moz-73488749.neoplus.adsl.tpnet.pl) (Quit: Wychodzi)
- # [17:50] * Joins: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP)
- # [17:51] * Quits: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Input/output error)
- # [17:51] * Joins: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP)
- # [18:02] * Joins: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com)
- # [18:14] <firewolfbot> hub@mozilla.com requested review from trev.saunders@gmail .com for attachment 588909 on bug 712927.
- # [18:14] <firewolfbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=712927 nor, --, ---, hub, NEW, [Mac] VoiceOver often repeats the document title as if it were a groupbox/fieldset heading/legend
- # [18:14] <@hub> making a try build of this too
- # [18:16] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [18:17] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [18:35] <@MarcoZ> hub: Nice!
- # [18:41] * Quits: @hub (hub@83874EA1.EB7C1AF9.6F478678.IP) (Input/output error)
- # [18:42] <@tbsaunde> so, am I dumb or missing something, or does the addons manager not have a ay to disable addons?
- # [18:50] * Quits: sgimeno (santiago.g@A922400D.48362F18.BCC03455.IP) (Quit: KVIrc 4.0.2 Insomnia http://www.kvirc.net/)
- # [19:04] * Joins: hub (hub@21B7B9F2.B87E9213.6E712CE2.IP)
- # [19:04] * ChanServ sets mode: +o hub
- # [19:06] * Joins: jongunderson (chatzilla@274A68DB.B1819C7E.DC3E9228.IP)
- # [19:08] * Joins: jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP)
- # [19:08] * ChanServ sets mode: +o jprmc
- # [19:18] * Joins: askalski (akuda@moz-6A36EC49.ip.abpl.pl)
- # [19:18] * ChanServ sets mode: +o askalski
- # [19:23] * Joins: davidb_ (davidb@moz-7B22FBCF.eng.wind.ca)
- # [19:35] <davidb_> hub: give me 5 mins?
- # [19:35] <@hub> sure
- # [19:35] <@hub> which room?
- # [19:37] <davidb_> mine
- # [19:37] <@hub> ok
- # [19:37] <@hub> I'll be wating for you
- # [19:38] * Quits: @askalski (akuda@moz-6A36EC49.ip.abpl.pl) (Quit: Wychodzi)
- # [19:41] <@davidb> http://www.csun.edu/cod/conference/sessions/index.php
- # [19:50] * firewolfbot is now known as firebot
- # [19:55] * Joins: askalski (akuda@moz-6A36EC49.ip.abpl.pl)
- # [19:55] * ChanServ sets mode: +o askalski
- # [19:56] <@davidb> MarcoZ: hub's going to CSUN. How did you end up booking the rooms?
- # [19:56] <@askalski> tbsaunde, : how to request a review?
- # [19:56] <@askalski> and what are these hints?
- # [19:56] <@MarcoZ> davidbI called the hotel.
- # [19:56] <@MarcoZ> davidb: ^
- # [19:57] <@MarcoZ> davidb: And while booking, specified that I was attending CSUN (or Center on disabilities Northridge).
- # [19:57] <@davidb> ok
- # [19:57] <@davidb> hub: that's probably your best bet as well ^
- # [19:57] <@davidb> and flights through egencia.
- # [19:57] <@MarcoZ> hub: Yes I'd do that, these are not bookable otherwise, not through Egencia at least.
- # [19:57] <@MarcoZ> hub: Look forward to seeing you there!
- # [19:58] <@hub> ok
- # [19:58] <@davidb> MarcoZ: you can introduce him to the usual suspects :)
- # [19:58] <@MarcoZ> davidb: Will do that!
- # [19:59] <@hub> maybe I need to find a way to emboss my business cards
- # [19:59] <@MarcoZ> hub: Don't bother. I went by at 4 CSUNs without any business cards at all. *g*
- # [20:00] <@hub> ok
- # [20:04] <@davidb> well, hub's not an accessibility celebrity. yet.
- # [20:05] * @davidb cackles maniacally
- # [20:07] <@davidb> askalski: if you click on "Details" next to the patch (on the bug report), you'll see a page that has a Flags section. under review you want to switch it to '?' and type a bug mail in for the target reviewer
- # [20:08] <@askalski> davidb, : the reviewer will be probably tbsaunde, he already read it
- # [20:08] <@davidb> askalski: ok good, so you can put his bug mail address there.
- # [20:09] * @tbsaunde believes :tbsaunde works to
- # [20:09] <@askalski> done
- # [20:09] <firebot> askalski@mozilla.com requested review from trev.saunders@gmail .com for attachment 588866 on bug 717507.
- # [20:09] <firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=717507 nor, --, ---, askalski, NEW, expandoify states
- # [20:09] <@tbsaunde> but I wouldn't object if davidb or surkov were asked instead of me ;)
- # [20:09] <@davidb> woot, firebot is back
- # [20:10] <@MarcoZ> askalski: Looks good!
- # [20:10] <@askalski> tbsaunde, davidb : I will propose David as reviewer for the 716644 which is similar, and I am on it right now
- # [20:10] <@askalski> MarcoZ, : thanks!
- # [20:11] <@askalski> will I be able to land it myself?
- # [20:11] <@tbsaunde> askalski: not unless you have commit access :)
- # [20:11] <@tbsaunde> askalski: I don't mind doing them, I was mostly kidding :)
- # [20:11] <@MarcoZ> Hub: Interesting that you're making the internal_frame a scroll area and the document the axwebarea in bug 712927. I will be curious to see what happens to iframes.
- # [20:12] <firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=712927 nor, --, ---, hub, NEW, [Mac] VoiceOver often repeats the document title as if it were a groupbox/fieldset heading/legend
- # [20:12] <@askalski> yes, I know. it's just once I gave bugzilla an e-mail ending with @mozilla.com it automatically gave me all privileges
- # [20:12] <@askalski> so I was pretty much asking if the same tricks works for repository
- # [20:12] * Quits: @askalski (akuda@moz-6A36EC49.ip.abpl.pl) (Quit: Wychodzi)
- # [20:13] <@hub> MarcoZ: oh, I didn't think of that case. I should try
- # [20:14] * Joins: askalski (akuda@moz-6A36EC49.ip.abpl.pl)
- # [20:14] * ChanServ sets mode: +o askalski
- # [20:14] <@tbsaunde> askalski: no, commit access is seperate from bugzilla
- # [20:17] <@davidb> askalski: first step is to file for level 1 access
- # [20:17] <@davidb> http://www.mozilla.org/hacking/committer/
- # [20:17] <@hub> so I register myself and expense it?
- # [20:18] <@davidb> hub: yeah
- # [20:18] <@davidb> if that's ok
- # [20:18] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [20:18] <@hub> yeah
- # [20:18] <@hub> I can do it
- # [20:18] <@davidb> ok
- # [20:19] <@davidb> askalski: e.g. bug 699221
- # [20:19] <firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=699221 nor, --, ---, ashish, RESO FIXED, Commit Access (Level 1) for Hub Figuiere
- # [20:22] <@MarcoZ> davidb: Do we need to file a bug to get accessibility turned on on the Accessibility branch for Mac nightlies?
- # [20:22] <@tbsaunde> askalski: me or MarcoZ can vouch to save davidb the time :)
- # [20:22] <@davidb> MarcoZ: yes.
- # [20:23] <@davidb> MarcoZ: at least, I don't know the status of whether we can do it ourselves somehow.
- # [20:24] <@MarcoZ> davidb: I am not aware of any way, other than to kick off accessibility-enabled builds on try with a specialized MOZCONFIG, as hub is already doing.
- # [20:24] <@tbsaunde> MarcoZ: you could use the timeing out bug I filed a couple days ago
- # [20:24] <@MarcoZ> hub: If you create a try-server build, can you post the link to it to one of the bugs you're working on?
- # [20:24] <@hub> MarcoZ: there is one in progress
- # [20:25] <@MarcoZ> hub: Cool
- # [20:25] <@MarcoZ> tbsaunde: Got a bug number?
- # [20:25] <@tbsaunde> MarcoZ: not off hand
- # [20:26] <@tbsaunde> davidb: I think the best answer is probably to add some new mozconfigs to the tree, and then get the releng people to fidle build bot so they get used on our branch
- # [20:26] <@davidb> MarcoZ: this might help us bug 558180
- # [20:26] <firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=558180 maj, P3, ---, catlee, NEW, Move mozconfigs into source tree
- # [20:26] <@davidb> tbsaunde: ^
- # [20:26] <@hub> MarcoZ: It should appear in http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/hfiguiere@mozilla.com-b2c705a32cf8/
- # [20:27] <@tbsaunde> davidb: yeah, I know about that bug but haven't payed much attention to the details
- # [20:27] <@davidb> ditto
- # [20:28] <@MarcoZ> davidb: tbsaunde: It's still in the process of patch creation/reviews.
- # [20:28] * @davidb asks in #build
- # [20:29] <@MarcoZ> hub: Thanks, will watch this directory and give you feedback on the bugs! Does this one contain the heading stuff, too?
- # [20:29] <@hub> yeah
- # [20:29] <@hub> it contains both heading the the tab / group name
- # [20:30] <@hub> bug 712923
- # [20:30] <firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=712923 nor, --, ---, hub, NEW, [Mac] Heading elements h1 through h6 are not recognizable by VoiceOver
- # [20:30] <@hub> bug 712927
- # [20:30] <firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=712927 nor, --, ---, hub, NEW, [Mac] VoiceOver often repeats the document title as if it were a groupbox/fieldset heading/legend
- # [20:30] <@davidb> MarcoZ: cat lee thinks we can already tweak our build config in browser/config/mozconfigs
- # [20:30] <@MarcoZ> Hub: Very nice! BTW do you mind if I told on my blog that we've made progress on Mac accessibility, and that in the next couple of weeks, we might have something to hand out to an audience larger than myself?
- # [20:30] <@hub> note, the try build is very red on Windows
- # [20:30] <@davidb> MarcoZ: but we need to be careful with trunk merges
- # [20:30] <@hub> MarcoZ: feel free to let people know
- # [20:31] <@hub> I'd like in the short term, to get more regular builds with a11y enabled on Mac
- # [20:31] <@hub> so that people can try it out
- # [20:31] <@tbsaunde> davidb: that would sort of suck
- # [20:31] <@MarcoZ> davidbYeah that would suck indeed.
- # [20:31] <@MarcoZ> hub: Very nice! I'll prepare a post, then.
- # [20:32] <@tbsaunde> davidb: but catlee doesn't have a way for us to use mozconfigs different from the normal ones?
- # [20:32] <@davidb> tbsaunde: i tried asking for that and it became a perilous and confusing journey nowhere
- # [20:33] <@tbsaunde> davidb: when know? or a while back?
- # [20:33] <@davidb> while back
- # [20:33] <@tbsaunde> things might have changed :)
- # [20:33] <@tbsaunde> but I suppose I won't have much need to use that branch in future so I'm not sure I care that much
- # [20:34] * @davidb asks on #build
- # [20:35] <@tbsaunde> davidb: is projects/accessibility actually level 2? (that's sort of anoying)
- # [20:35] <@davidb> tbsaunde: i don't know
- # [20:36] * Quits: jongunderson (chatzilla@274A68DB.B1819C7E.DC3E9228.IP) (Quit: ChatZilla 0.9.88 [Firefox 9.0.1/20111220165912])
- # [20:38] <@hub> we don't have discount code for the registration?
- # [20:39] <@MarcoZ> hub: For CSUN itself? I do not think so.
- # [20:39] <@hub> yeah
- # [20:39] <@hub> ok
- # [20:40] <@MarcoZ> OK, will write that blog post tomorrow, will now head off for the evening. Look forward to the build tomorrow! :)
- # [20:40] <@MarcoZ> See you all!
- # [20:40] * Quits: @MarcoZ (marco.zehe@moz-900A5E73.dip.t-dialin.net) (Quit: Night!)
- # [20:42] <@davidb> tbsaunde: yeah, so the answer is to merge carefully (sigh)
- # [20:42] * Quits: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com) (Ping timeout)
- # [20:42] <@tbsaunde> davidb: ok
- # [20:42] * @tbsaunde is curious why this is hard
- # [20:46] * Joins: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com)
- # [20:56] * Quits: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com) (Ping timeout)
- # [21:03] <firebot> trev.saunders@gmail.com cancelled review?(trev.saunders@gmail .com) for attachment 588866 on bug 717507.
- # [21:03] <firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=717507 nor, --, ---, askalski, NEW, expandoify states
- # [21:04] * Joins: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com)
- # [21:11] <@askalski> tbsaunde, : why you cancelled a review? and what does that mean?
- # [21:12] <@askalski> oh, and can I simultaneously use two queues for two different patches? I would like to start another one, but I prefer to keep changes separated from first one, and I think I'll be back to first one to apply review notes
- # [21:13] <@davidb> askalski: i usually end up hg qpop -a before starting a new patch
- # [21:14] <@davidb> and, shamefully, I sometimes edit .hg/patches/series
- # [21:15] * khuey|away is now known as khuey
- # [21:19] <@tbsaunde> askalski: you can have more than one patch in a queue
- # [21:20] <@tbsaunde> askalski: canceling is something like "I don't want to r- this, but I'd like to see another version"
- # [21:20] <@tbsaunde> davidb: ^ seem about right to you?
- # [21:20] <@davidb> yes
- # [21:20] <@davidb> it is a friendlier r-
- # [21:20] <@askalski> hmm, and if I already started qnew ?
- # [21:21] <@davidb> askalski: that's fine.
- # [21:21] <@tbsaunde> davidb: well, not exactly since someone could theoretically r+ it and the patch could land right?
- # [21:21] <@davidb> tbsaunde: true
- # [21:22] <@davidb> but your adding the comment to see the next patch is a good protection
- # [21:22] <@tbsaunde> askalski: qnew puts a nother patch in the series
- # [21:22] <@davidb> try: hg qser
- # [21:22] <@davidb> to see status of applied or unapplied patches
- # [21:23] <@askalski> ok, you know, it seems like I'm not editing an old one but I am editing new one, so I will worry about it when I'll have to switch back to previous :)
- # [21:27] <@askalski> I got akuda@nouri:~/Moz/mozilla-central$ hg qser
- # [21:27] <@askalski> 0 A StateListPatch
- # [21:27] <@askalski> 1 A bug-716644-expandoify-accessible-roles
- # [21:27] <@askalski> akuda@nouri:~/Moz/mozilla-central$ cd
- # [21:27] <@askalski> so 0 with the one I submitted and 1 with the new on
- # [21:28] <@askalski> I checked, the old one *is* applied
- # [21:28] <@askalski> so I guess it's just number
- # [21:28] * Quits: @askalski (akuda@moz-6A36EC49.ip.abpl.pl) (Quit: Wychodzi)
- # [21:33] * Joins: richardschwerdtfeger (richardsch@moz-130F1494.lightspeed.austtx.sbcglobal.net)
- # [21:35] * Quits: @hub (hub@21B7B9F2.B87E9213.6E712CE2.IP) (Ping timeout)
- # [21:37] * Joins: askalski (akuda@moz-6A36EC49.ip.abpl.pl)
- # [21:37] * ChanServ sets mode: +o askalski
- # [21:39] * Quits: davidb_ (davidb@moz-7B22FBCF.eng.wind.ca) (Quit: bye)
- # [21:47] <@tbsaunde> askalski: I'm not sure what you mean "just number"
- # [22:03] <@askalski> tbsaunde, : index of patch, I thought it's a binary flag "applied/not applied"
- # [22:04] <@askalski> I should probably leave some of my thoughts to myself instead of posting all of them on IRC, it seems like I am wasting attention some of the times
- # [22:07] <@tbsaunde> well, if it clears up confussion I don't mind
- # [22:08] <@tbsaunde> I believe its index flag of applied / not applied patch name
- # [22:10] * Joins: elbasha (elbasha@25CBB365.151AADDA.C546977A.IP)
- # [22:14] * Quits: elbasha (elbasha@25CBB365.151AADDA.C546977A.IP) (Quit: Leaving)
- # [22:15] <firebot> eitan@monotonous.org requested review from trev.saunders@gmail .com for attachment 588980 on bug 698823.
- # [22:15] <firebot> eitan@monotonous.org requested superreview from neil@httl.net for attachment 588980 on bug 698823.
- # [22:15] <firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=698823 nor, --, mozilla10, eitan, NEW, Introduce virtual cursor/soft focus functionality to a11y API
- # [22:15] * Joins: hub (hub@21B7B9F2.B87E9213.6E712CE2.IP)
- # [22:15] * ChanServ sets mode: +o hub
- # [22:15] * Quits: @hub (hub@21B7B9F2.B87E9213.6E712CE2.IP) (Input/output error)
- # [22:15] * Joins: hub (hub@21B7B9F2.B87E9213.6E712CE2.IP)
- # [22:15] * ChanServ sets mode: +o hub
- # [22:17] <@hub> since the conference end on Saturday at noon, I wonder if I should return Saturday evening or sunday morning
- # [22:24] <@tbsaunde> davidb: what do you mean by "modes that are not progressive"?
- # [22:31] * khuey is now known as khuey|away
- # [22:33] * Quits: @davidb (davidb@F2D29657.F60B0462.67AC9B1.IP) (Quit: davidb)
- # [22:35] * Joins: davidb (davidb@moz-7B22FBCF.eng.wind.ca)
- # [22:35] * ChanServ sets mode: +qo davidb davidb
- # [22:56] <firebot> hub@mozilla.com cancelled review?(trev.saunders@gmail .com) for attachment 588526 on bug 712923.
- # [22:56] <firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=712923 nor, --, ---, hub, NEW, [Mac] Heading elements h1 through h6 are not recognizable by VoiceOver
- # [22:56] <firebot> hub@mozilla.com requested review from trev.saunders@gmail .com for attachment 588991 on bug 712923.
- # [23:02] * Parts: clown (clown@67828CC7.C1A51174.9D42CF23.IP)
- # [23:11] * Quits: @askalski (akuda@moz-6A36EC49.ip.abpl.pl) (Quit: Wychodzi)
- # [23:11] * Joins: askalski (akuda@moz-6A36EC49.ip.abpl.pl)
- # [23:11] * ChanServ sets mode: +o askalski
- # [23:11] <@askalski> hi, it's close to midnight
- # [23:11] <@askalski> I am going asleep
- # [23:11] <@askalski> by everyone
- # [23:11] * Quits: richardschwerdtfeger (richardsch@moz-130F1494.lightspeed.austtx.sbcglobal.net) (Quit: richardschwerdtfeger)
- # [23:12] * Quits: @askalski (akuda@moz-6A36EC49.ip.abpl.pl) (Quit: Wychodzi)
- # [23:34] * Joins: Jamie (jamie@moz-CA26021.jantrid.net)
- # [23:35] * Quits: @jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP) (Ping timeout)
- # [23:36] * Joins: jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP)
- # [23:36] * ChanServ sets mode: +o jprmc
- # [23:41] * Joins: surkov (surkov@F6C60776.8F955B94.FE58E87C.IP)
- # [23:41] * ChanServ sets mode: +o surkov
- # [23:41] * Quits: @surkov (surkov@F6C60776.8F955B94.FE58E87C.IP) (Quit: surkov)
- # Session Close: Tue Jan 17 00:00:00 2012
The end :)