/irc-logs / mozilla / #accessibility / 2012-04-10 / end
Options:
- # Session Start: Tue Apr 10 00:00:00 2012
- # Session Ident: #accessibility
- # [00:14] <@firebot> markcapella@twcny.rr.com requested feedback from hub@mozilla.com for attachment 613410 on bug 741707.
- # [00:14] <@firebot> markcapella@twcny.rr.com changed the Status on bug 741707 from NEW to ASSIGNED.
- # [00:14] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=741707 nor, --, ---, markcapella, ASSI, rm unused a11y CIDs
- # [00:22] * Quits: shorlander (shorlander@moz-853043D6.dhcp.insightbb.com) (Ping timeout)
- # [00:22] * Joins: shorlander_ (shorlander@moz-853043D6.dhcp.insightbb.com)
- # [00:27] <@firebot> hub@mozilla.com denied review for attachment 613245 on bug 741683.
- # [00:27] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=741683 nor, --, ---, markcapella, ASSI, move nsAccessNode::ScrollTo to nsCoreUtils
- # [00:34] * Quits: victorporof (victorporo@BD5B5B26.602BD6C.79933D60.IP) (Connection reset by peer)
- # [00:49] <Mark_Capella> hub: im working on the rebase and will post it in once it clean builds here locally
- # [00:52] <@hub> Mark_Capella: to be honest I might have misunderstood what surkov said. Otherwise it would be r+
- # [00:52] <Mark_Capella> cool B) yah there was a lot going on in that patch, and you kinda got dragged in late ... ill post the rebase asap and ask for review again
- # [00:59] * Joins: jkiss (jkiss@5248D1C6.C5B5659C.8732AABF.IP)
- # [01:04] <jkiss> The W3C A11y API task force is looking for help with the HTML to Platform APIs Implentation Guide at http://dvcs.w3.org/hg/html-api-map/raw-file/tip/Overview.html
- # [01:04] <jkiss> If you've got some time, please let us know what you think should be addded or changed
- # [01:05] <jkiss> You can also the bug adding feature built into the page if you have a W3C bugzilla account
- # [01:05] <jkiss> All feedback appreciated
- # [01:30] <@hub> maybe I'm missing something, but do we have an event like "page loaded"
- # [01:41] * Quits: ehsan (ehsan@F2D29657.F60B0462.67AC9B1.IP) (Input/output error)
- # [01:53] * Quits: nhirata (nhirata.bu@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net) (Quit: nhirata)
- # [01:58] * Joins: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP)
- # [01:58] <Mark_Capella> hub: rebase of bug741683 is building ... any ideas on the bug741701 ?
- # [01:58] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=741683 nor, --, ---, markcapella, ASSI, move nsAccessNode::ScrollTo to nsCoreUtils
- # [01:58] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=741701 nor, --, mozilla14, markcapella, ASSI, CAccessibleHyperlink::get_anchor shouldn't use nsIWinAccessNode
- # [02:00] <Mark_Capella> er --- im mean bug741707 ??
- # [02:00] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=741707 nor, --, ---, markcapella, ASSI, rm unused a11y CIDs
- # [02:00] <Mark_Capella> (typed it wrong)
- # [02:06] <@hub> I didn't really look yet
- # [02:07] <@hub> as for the Windows build error, I have no idea
- # [02:07] <@hub> let me check on Linux
- # [02:07] <Mark_Capella> k :)
- # [02:07] <Mark_Capella> not familiar with these concepts yet so debugging is going slow ...
- # [02:09] * Quits: jimm (jmathies@moz-7F164CA1.pn.at.cox.net) (Quit: )
- # [02:09] * Quits: @jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP) (Ping timeout)
- # [02:27] * Joins: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp)
- # [02:28] * Joins: surkov (surkov@B9538DF7.B7015738.33A1AC3C.IP)
- # [02:28] * ChanServ sets mode: +o surkov
- # [02:29] * Quits: @surkov (surkov@B9538DF7.B7015738.33A1AC3C.IP) (Quit: surkov)
- # [02:35] <@hub> Mark_Capella: it fails to build on Linux too
- # [02:35] <@hub> let me finish rebuilding without the patch so that I can get my browser back
- # [02:35] <@hub> (same errors)
- # [02:35] <Mark_Capella> yah ... odd ... those macros are new to me and there must be an interdependancy that Im unaware of ...
- # [02:36] <@hub> yeah it is XPCOM
- # [02:36] <@hub> it is full of pain
- # [02:36] <Mark_Capella> >ouchies<
- # [02:37] <Mark_Capella> part of the patch caused a secondary problem that I was able to track down / correct ... this one has me stuck
- # [02:37] <Mark_Capella> im trying to fix it without asking for too much help :P
- # [02:46] <@firebot> markcapella@twcny.rr.com requested review from hub@mozilla.com for attachment 613450 on bug 741683.
- # [02:47] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=741683 nor, --, ---, markcapella, ASSI, move nsAccessNode::ScrollTo to nsCoreUtils
- # [02:47] <@firebot> hub@mozilla.com denied feedback for attachment 613410 on bug 741707.
- # [02:47] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=741707 nor, --, ---, markcapella, ASSI, rm unused a11y CIDs
- # [02:54] <Mark_Capella> hub: ok forgotten : but I still have >issues< :D
- # [02:55] <Mark_Capella> polite way to say im confused !
- # [03:09] <Mark_Capella> hub: ill have to wait then ... alex has a buncha my stuff and othes coming through inbound yet maybe by tomorrow
- # [03:15] <@hub> ok, gotta go nw
- # [03:15] <@hub> now
- # [03:16] * Quits: @hub (hub@21B7B9F2.B87E9213.6E712CE2.IP) (Ping timeout)
- # [03:17] * ctalbert is now known as ctalbert|afk
- # [03:38] <@firebot> markcapella@twcny.rr.com changed the Status on bug 741709 from NEW to ASSIGNED.
- # [03:38] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=741709 nor, --, ---, markcapella, ASSI, nsAccessibleWrap::get_accParent() shouldn't use do_QueryObject to get a nsDocAccessible
- # [03:59] * Joins: nickc (Mibbit@moz-91D453DB.network.nus.edu.sg)
- # [04:17] * Joins: surkov (surkov@B9538DF7.B7015738.33A1AC3C.IP)
- # [04:17] * ChanServ sets mode: +o surkov
- # [04:25] <@firebot> markcapella@twcny.rr.com requested feedback from trev.saunders@gma il.com for attachment 613470 on bug 741709.
- # [04:25] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=741709 nor, --, ---, markcapella, ASSI, nsAccessibleWrap::get_accParent() shouldn't use do_QueryObject to get a nsDocAccessible
- # [04:38] <@tbsaunde> Mark_Capella: what were these build errors? (just came back from being away and haven't read mail yet)
- # [04:39] <Mark_Capella> i found one of the problems
- # [04:39] <Mark_Capella> there was a dependency on another bug that I hadnt done yet
- # [04:40] <@tbsaunde> Mark_Capella: yeah, but that wouldn't have effected linux
- # [04:41] <Mark_Capella> well bug 741709 has to be done before bug741707 can be done ....
- # [04:41] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=741709 nor, --, ---, markcapella, ASSI, nsAccessibleWrap::get_accParent() shouldn't use do_QueryObject to get a nsDocAccessible
- # [04:41] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=741707 nor, --, ---, markcapella, ASSI, rm unused a11y CIDs
- # [04:41] <Mark_Capella> I didnt see the dependency in the bugzilla / blocking / depends on thing
- # [04:46] <@tbsaunde> Mark_Capella: yes, bug the dependancy should only effect windows
- # [04:47] <nickc> Hi mark
- # [04:48] <Mark_Capella> well i coded / tested and posted patch for bug741709 ... to get it out of the way
- # [04:48] <Mark_Capella> now I can go back and look at bug740717
- # [04:48] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=740717 nor, P3, ---, nobody, NEW, Add language switcher dropdown to Marketplace
- # [04:48] <Mark_Capella> nickc: hi
- # [04:48] <Mark_Capella> 741707 that is
- # [04:48] <Mark_Capella> too many numbers and its late :)
- # [04:48] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [04:56] <@tbsaunde> heh
- # [04:58] <@firebot> orangedaylily@gmail.com requested review from hub@mozilla.com for attachment 613477 on bug 741681.
- # [04:58] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=741681 nor, --, ---, orangedaylily, NEW, replace nsAccessNode::GetPresContext by nsDocAccessible::PresContext
- # [05:04] <@tbsaunde> Mark_Capella: you could just ask for review if you think the patch is good like bug 741709
- # [05:04] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=741709 nor, --, ---, markcapella, ASSI, nsAccessibleWrap::get_accParent() shouldn't use do_QueryObject to get a nsDocAccessible
- # [05:04] <Mark_Capella> oh! did I do a feedback?
- # [05:05] <@firebot> trev.saunders@gmail.com granted review for attachment 613470 on bug 741709.
- # [05:05] <@firebot> trev.saunders@gmail.com cancelled feedback?(trev.saunders@gma il.com) for attachment 613470 on bug 741709.
- # [05:08] * Quits: @surkov (surkov@B9538DF7.B7015738.33A1AC3C.IP) (Quit: surkov)
- # [06:02] * khuey is now known as khuey|away
- # [06:07] * Joins: victorporof (victorporo@BD5B5B26.602BD6C.79933D60.IP)
- # [06:36] * Quits: brambles_ (brambles@4CBAB088.F3076E90.1822ACA6.IP) (Client exited)
- # [06:37] * Joins: brambles (brambles@4CBAB088.F3076E90.1822ACA6.IP)
- # [06:43] * Quits: jkiss (jkiss@5248D1C6.C5B5659C.8732AABF.IP) (Ping timeout)
- # [06:58] * Joins: hub (hub@moz-E2FCA694.figuiere.net)
- # [06:58] * ChanServ sets mode: +o hub
- # [06:58] <@firebot> markcapella@twcny.rr.com requested feedback from hub@mozilla.com for attachment 613492 on bug 741707.
- # [06:58] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=741707 nor, --, ---, markcapella, ASSI, rm unused a11y CIDs
- # [07:15] <@firebot> hub@mozilla.com granted feedback for attachment 613492 on bug 741707.
- # [07:15] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=741707 nor, --, ---, markcapella, ASSI, rm unused a11y CIDs
- # [07:18] * Quits: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com) (Client exited)
- # [07:29] <@firebot> hub@mozilla.com granted review for attachment 613477 on bug 741681.
- # [07:29] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=741681 nor, --, ---, orangedaylily, NEW, replace nsAccessNode::GetPresContext by nsDocAccessible::PresContext
- # [07:37] <Mark_Capella> yee haa ... i love it when a plan comes together :)
- # [07:38] * Quits: Mark_Capella (chatzilla@moz-DD0C7E4F.twcny.res.rr.com) (Connection reset by peer)
- # [07:38] * Joins: Mark_Capella (chatzilla@moz-DD0C7E4F.twcny.res.rr.com)
- # [07:43] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [07:55] * Joins: surkov (surkov@B9538DF7.B7015738.33A1AC3C.IP)
- # [07:55] * ChanServ sets mode: +o surkov
- # [08:03] <@firebot> surkov.alexander@gmail.com changed the Target Milestone on bug 741709 from --- to mozilla14.
- # [08:03] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=741709 nor, --, mozilla14, markcapella, ASSI, nsAccessibleWrap::get_accParent() shouldn't use do_QueryObject to get a nsDocAccessible
- # [08:12] * Joins: MarcoZ (Daily@moz-C84B5E86.dip.t-dialin.net)
- # [08:12] * ChanServ sets mode: +o MarcoZ
- # [08:17] * Quits: victorporof (victorporo@BD5B5B26.602BD6C.79933D60.IP) (Quit: Leaving...)
- # [08:17] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [08:18] * Quits: @hub (hub@moz-E2FCA694.figuiere.net) (Ping timeout)
- # [08:37] <@firebot> nickyekaiqi@gmail.com requested feedback from the wind for attachment 613504 on bug 740764.
- # [08:37] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=740764 nor, --, ---, nickyekaiqi, NEW, merge GetAttributes and GetAttributesInternal
- # [08:52] * Mark_Capella is now known as Mark_Capella|around
- # [09:04] <@firebot> surkov.alexander@gmail.com cancelled feedback? for attachment 613504 on bug 740764.
- # [09:05] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=740764 nor, --, ---, nickyekaiqi, NEW, merge GetAttributes and GetAttributesInternal
- # [09:58] <jhk> this is how we can get rid of xpcom GetParent? http://pastebin.mozilla.org/1561853
- # [09:59] <@surkov> jhk: what is acc?
- # [09:59] <jhk> nsAccessibleWrap* acc = static_cast<nsAccessibleWrap>(this);
- # [10:01] <jhk> surkov: ^
- # [10:01] <@surkov> jhk: acc->Parent()
- # [10:01] <@surkov> so you code looks correct
- # [10:02] <jhk> surkov: thanks!
- # [10:02] <@surkov> yw
- # [10:07] * Parts: icaaq1 (Adium@moz-7D09279.cust.bredbandsbolaget.se)
- # [10:46] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [10:51] * Joins: victorporof (victorporo@moz-FDB8B824.info.uaic.ro)
- # [10:52] * Mark_Capella|around is now known as Mark_Capella
- # [11:10] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [11:18] * Quits: victorporof (victorporo@moz-FDB8B824.info.uaic.ro) (Quit: Leaving...)
- # [11:20] * Joins: rdt (Adium@moz-3D54E27E.nycmny.fios.verizon.net)
- # [11:22] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Ping timeout)
- # [11:33] * Parts: rdt (Adium@moz-3D54E27E.nycmny.fios.verizon.net)
- # [11:59] * Joins: jhk (jigneshhk1@8E6C34C1.A3F9767A.1C37C358.IP)
- # [12:17] * Quits: @MarcoZ (Daily@moz-C84B5E86.dip.t-dialin.net) (Input/output error)
- # [12:17] * Joins: MarcoZ (Daily@moz-C84B5E86.dip.t-dialin.net)
- # [12:17] * ChanServ sets mode: +o MarcoZ
- # [12:18] <@MarcoZ> Hi all!
- # [12:19] <@MarcoZ> Mark_Capella: Hi, am getting to your review now, was on public Easter holidays.
- # [12:19] <Mark_Capella> marcoz: thanks! Welcome back :)
- # [12:20] <Mark_Capella> lots of people have been out .... real quiet around here
- # [12:23] <@surkov> yeah, try server builds are fast as never
- # [12:24] <@surkov> usually I'm waiting about 15 minutes before it does a push
- # [12:24] <@surkov> these days it's about half of minute ;)
- # [12:25] * Quits: jhk (jigneshhk1@8E6C34C1.A3F9767A.1C37C358.IP) (Ping timeout)
- # [12:28] * Joins: jhk (jigneshhk1@8E6C34C1.A3F9767A.1C37C358.IP)
- # [12:29] * Quits: jhk (jigneshhk1@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [12:29] * Joins: jhk (jigneshhk1@8E6C34C1.A3F9767A.1C37C358.IP)
- # [12:30] <Mark_Capella> its fast now that they got it running ... it was down from Friday night to Sunday morning
- # [12:30] <Mark_Capella> or maybe that was just the autloand portion
- # [12:36] <@firebot> marco.zehe@googlemail.com granted review for attachment 612984 on bug 739612.
- # [12:36] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=739612 nor, --, ---, markcapella, ASSI, Cleanup A11y tests and test-suite organization
- # [12:38] <@MarcoZ> Mark_Capella: To be absolutely certain, you should throw the updated patch for bug 739612 against try and watch the results to make sure the tests still pass on all platforms.
- # [12:39] <Mark_Capella> yah - ok - ill do that here this morning - thankx !
- # [12:41] * Joins: victorporof (victorporo@4B0D9BBA.6D2FB7A4.79933D60.IP)
- # [13:29] <@firebot> surkov.alexander@gmail.com granted review for attachment 613541 on bug 741707.
- # [13:29] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=741707 nor, --, ---, markcapella, ASSI, rm unused a11y CIDs
- # [13:31] <Mark_Capella> Woo Hoo :)
- # [13:33] <Mark_Capella> finally figured out why the out of place getRole() test worked (instead of failing as expected)
- # [13:36] * Quits: @surkov (surkov@B9538DF7.B7015738.33A1AC3C.IP) (Quit: surkov)
- # [13:49] * Quits: victorporof (victorporo@4B0D9BBA.6D2FB7A4.79933D60.IP) (Connection reset by peer)
- # [13:49] * Joins: victorporo (victorporo@4B0D9BBA.6D2FB7A4.79933D60.IP)
- # [13:53] * Quits: victorporo (victorporo@4B0D9BBA.6D2FB7A4.79933D60.IP) (Connection reset by peer)
- # [13:53] * Joins: victorporof (victorporo@4B0D9BBA.6D2FB7A4.79933D60.IP)
- # [13:54] * Mark_Capella is now known as Mark_Capella|away
- # [13:57] * Quits: victorporof (victorporo@4B0D9BBA.6D2FB7A4.79933D60.IP) (Connection reset by peer)
- # [13:57] * Joins: victorporo (victorporo@4B0D9BBA.6D2FB7A4.79933D60.IP)
- # [14:01] * Quits: victorporo (victorporo@4B0D9BBA.6D2FB7A4.79933D60.IP) (Ping timeout)
- # [14:03] * Joins: victorporof (victorporo@4B0D9BBA.6D2FB7A4.79933D60.IP)
- # [14:08] <nickc> Anyone to help?
- # [14:08] * Quits: victorporof (victorporo@4B0D9BBA.6D2FB7A4.79933D60.IP) (Connection reset by peer)
- # [14:08] * Joins: victorporo (victorporo@4B0D9BBA.6D2FB7A4.79933D60.IP)
- # [14:09] <nickc> Need some clarification of a bug
- # [14:09] <@tbsaunde> nickc: yeah?
- # [14:11] <@tbsaunde> nickc: what is your issue?
- # [14:12] * Quits: victorporo (victorporo@4B0D9BBA.6D2FB7A4.79933D60.IP) (Connection reset by peer)
- # [14:12] * Joins: victorporof (victorporo@4B0D9BBA.6D2FB7A4.79933D60.IP)
- # [14:13] * Quits: victorporof (victorporo@4B0D9BBA.6D2FB7A4.79933D60.IP) (Connection reset by peer)
- # [14:13] <nickc> I sent it to you through personal talking
- # [14:13] <nickc> You did not receive the messages?
- # [14:13] * Joins: victorporo (victorporo@4B0D9BBA.6D2FB7A4.79933D60.IP)
- # [14:15] * Joins: jprmc (jprmc@C3A2FAF3.5BCEC6DB.DA78B690.IP)
- # [14:15] * ChanServ sets mode: +o jprmc
- # [14:15] * victorporo is now known as victorporof
- # [14:16] * Quits: victorporof (victorporo@4B0D9BBA.6D2FB7A4.79933D60.IP) (Connection reset by peer)
- # [14:18] <@MarcoZ> nick: Perhaps if you post your question to the channel, any of the team members wo are currently here can try to answer.
- # [14:19] <@MarcoZ> nickc: ^
- # [14:19] <nickc> Yup
- # [14:19] <nickc> I tried to copy
- # [14:19] * Quits: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Input/output error)
- # [14:19] <nickc> Now I am working on this bug 740764
- # [14:19] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=740764 nor, --, ---, nickyekaiqi, NEW, merge GetAttributes and GetAttributesInternal
- # [14:19] <nickc> surkov is not here
- # [14:20] <nickc> I need some more explanation about the review part on nsAccessible.cpp
- # [14:20] * Joins: victorporof (victorporo@830D7731.AB163232.79933D60.IP)
- # [14:21] <nickc> There exists a function with the prototype NS_IMETHODIMP nsAccessible::GetAttributes(nsIPersistentProperties** aAttributes) in nsAccessibility
- # [14:22] <nickc> In the review, I am told to create another NS_IMETHODIMP nsAccessible::GetAttributes(nsIPersistentProperties** aAttributes) function. What does it mean?
- # [14:22] <nickc> I talked with surkov before he left.
- # [14:22] <@tbsaunde> nickc: I don't think you should be creating a second one
- # [14:22] <nickc> It seems that they are the same one.
- # [14:22] <@tbsaunde> but the existing one should be NS_IMETHODIMP not virtual nsresult
- # [14:23] <nickc> NS_IMETHODIMP and virtual nsresult are types?
- # [14:23] <@tbsaunde> but other than that I don't really see what Alex wants
- # [14:24] <@tbsaunde> he might be around in a bit, or you can work on something else
- # [14:24] <nickc> Is there any other recommended bug about accessibility
- # [14:25] <nickc> I want to do one more
- # [14:25] <nickc> Some bug which is not that hard, since I am still trying to be more familiar with it
- # [14:26] * Quits: logbot (logbot@moz-622AFC27.glob.com.au) (Client exited)
- # [14:26] * Joins: logbot (logbot@moz-622AFC27.glob.com.au)
- # [14:31] * Quits: @jprmc (jprmc@C3A2FAF3.5BCEC6DB.DA78B690.IP) (Ping timeout)
- # [14:33] * Joins: icaaq (Adium@714E29CB.13DB46CE.3B93FF6D.IP)
- # [14:36] * Joins: surkov (surkov@B9538DF7.B7015738.33A1AC3C.IP)
- # [14:36] * ChanServ sets mode: +o surkov
- # [14:41] * Joins: shorlander (shorlander@moz-853043D6.dhcp.insightbb.com)
- # [14:41] * Quits: shorlander_ (shorlander@moz-853043D6.dhcp.insightbb.com) (Ping timeout)
- # [14:44] <@tbsaunde> nickc: there are a bunch of other good first bugs, you could ask about the difficulty of one of those in here and we can tell you, or surkov seems to be around
- # [14:44] * tbsaunde is now known as tbsaunde|shower
- # [14:45] <@surkov> getAccessible is not trivial one but iirc nickc has good results on it
- # [14:46] <nickc> Hi surkov
- # [14:46] <@surkov> hi, nickc
- # [14:46] <nickc> Still a little blur
- # [14:46] <nickc> Sorry for that
- # [14:46] <@surkov> it's ok
- # [14:47] <nickc> Where should I put that part of code in?
- # [14:49] <nickc> For NS_IMETHODIMP nsAccessible::GetAttributes(nsIPersistentProperties** aAttributes)
- # [14:49] <nickc> In this function, I should call it again.
- # [14:49] <nickc> Then it runs into an infinite loop...:(
- # [14:49] <nickc> To me...
- # [14:50] <nickc> I must misunderstand your meaning
- # [14:50] <@surkov> nickc: you should put it somewhere in nsAccessible (you can put it near to existing getAttributes implementation)
- # [14:52] <nickc> I will put my understanding into pasterbin and let you check it. Is it OK?
- # [14:52] <@surkov> it's not infinite loop, it's two different methods, one of them takes nsIPersistentProperties** (nsIAccessible interface implementation) and another one takes nsIPersistentProperties*
- # [14:52] <@surkov> sure
- # [14:53] <nickc> Two methods!
- # [14:53] <nickc> One para is pointer and the other one is pointer to pointer
- # [14:53] <@surkov> nickc: it's called overloading functions http://publib.boulder.ibm.com/infocenter/comphelp/v8v101/index.jsp?topic=%2Fcom.ibm.xlcpp8a.doc%2Flanguage%2Fref%2Fcplr312.htm
- # [14:54] <@surkov> right
- # [14:54] <nickc> Oh! That's why I got confused. I thought the same function is called by itself. :)
- # [14:55] <nickc> Then I just define 2 functions
- # [14:55] <nickc> One is called in the other one
- # [14:56] <@surkov> right
- # [14:56] <nickc> OK! I thought they had the same para. :(
- # [14:56] <nickc> Clear now!
- # [14:56] <nickc> Thx
- # [15:00] <@MarcoZ> Hi surkov!
- # [15:00] <@MarcoZ> surkov: Am I correct in assuming that bug 729831 is in Mozilla13?
- # [15:00] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=729831 cri, --, mozilla13, surkov.alexander, RESO FIXED, Crash @ mozilla::a11y::StyleInfo::Margin
- # [15:03] * Joins: davidb (davidb@F2D29657.F60B0462.67AC9B1.IP)
- # [15:03] * ChanServ sets mode: +qo davidb davidb
- # [15:04] <@MarcoZ> Hey davidb!
- # [15:04] <@davidb> hi MarcoZ! Nice holiday?
- # [15:08] <@davidb> tbsaunde|shower: I see results are in on the talos try.
- # [15:09] <@surkov> MarcoZ: hi, sounds so
- # [15:09] <@MarcoZ> davidb: Yes, we went to Petra's Mom's place and spent the rest of Easter Sunday and yesterday at home, clearing up more stuff. Almost all boxes unpacked now. \-O-/
- # [15:10] <@davidb> nice
- # [15:10] <@MarcoZ> surkov: Thanks, then I don't think any more action is needed on the bug, as i said in my e-mail.
- # [15:10] <@davidb> BTW I've not checked twitter in a few days
- # [15:10] <@davidb> which bug?
- # [15:11] <@MarcoZ> davidb: bug 729831. The one you pinged me in e-mail about yesterday.
- # [15:11] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=729831 cri, --, mozilla13, surkov.alexander, RESO FIXED, Crash @ mozilla::a11y::StyleInfo::Margin
- # [15:11] <@MarcoZ> davidb: Nothing to uplift, just to verify.
- # [15:11] * khuey|away is now known as khuey
- # [15:11] <@davidb> ah ok
- # [15:12] <@davidb> MarcoZ: I haven't caught up on the inspect label bug… did that get resolved?
- # [15:12] <@MarcoZ> davidb: Oh then you didn't see my comment about me agreeing with a big German ecomonomy newspaper that stated that Silicon Valley is really going insane? ;)
- # [15:12] <@surkov> MarcoZ: but you might want to double check that
- # [15:12] <@davidb> MarcoZ: haha
- # [15:12] <@surkov> because target13 was set for first patch
- # [15:12] <@MarcoZ> I mean this 1 billion dollar Instagram deal just screams "Bubble!!!" to me.
- # [15:13] <@eeejay> yep, bubble
- # [15:13] <@MarcoZ> surkov: I believe second patch was landed *before* the merge on March 13.
- # [15:13] <@eeejay> and that new silicon valley reality show...
- # [15:13] <@surkov> ok
- # [15:13] <@MarcoZ> davidb: No activity at all on that bug in the last six days.
- # [15:15] <@MarcoZ> surkov: Commented.
- # [15:15] * Joins: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com)
- # [15:15] <@davidb> MarcoZ: one of us should help drive it.
- # [15:22] <@MarcoZ> davidb: TBH, I'm not sure where that bug should go. I'm unsure of the feature/how it works, and also what the exact interaction model is.
- # [15:22] <@MarcoZ> The one thing I *do* know is that hiding it from accessibility APIs is the worst of ideas.
- # [15:22] <@MarcoZ> But if you'd ask me what its label should be.....I have *no* idea. ;)
- # [15:23] <@davidb> MarcoZ: I think we just need a good label. The button in question sets the Inspect mode to mouse interaction sub-mode.
- # [15:23] <@davidb> So something like "rollover mode"
- # [15:24] <@davidb> MarcoZ: what does the button name say in nightly?
- # [15:24] * tbsaunde|shower is now known as tbsaunde
- # [15:26] <@MarcoZ> Nothin.
- # [15:26] <@MarcoZ> Labelless.
- # [15:27] <@davidb> MarcoZ: not even the tooltip?
- # [15:29] <@tbsaunde> davidb: yeah, haven't looked at them yet though
- # [15:30] * Joins: jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP)
- # [15:30] * ChanServ sets mode: +o jprmc
- # [15:31] * Quits: jhk (jigneshhk1@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [15:34] <icaaq> Hi, I asked yesterday about keyboard and video, and why I need javascript for it to be keyboard accessible. have a look at http://icaaq.com/sandbox/a11y/video.htm it's the simplest of all videos but it is not focusable with the keyboard when javascript is disabled.
- # [15:35] <@davidb> icaaq: http://mindforks.blogspot.ca/2009/09/keyboard-control-of-html5-video.html
- # [15:37] <@davidb> icaaq: it might be time to make the controls themselves keyboard navigable, we just need someone to work on it
- # [15:39] <@MarcoZ> davidb: No.
- # [15:39] <@MarcoZ> Not even the tooltip.
- # [15:39] <icaaq> davidb: yes, other browsers already have it implemented
- # [15:39] <@MarcoZ> davidb: At least I didn't find it.
- # [15:39] <icaaq> davidb: opera for example
- # [15:41] <@tbsaunde> davidb: did you have a chance to look yet?
- # [15:45] <@davidb> MarcoZ: that seems odd. so you encounter a nameless "button"?
- # [15:46] <@davidb> tbsaunde: I looked briefly… all the T's are green, but I'm not sure if that means we're ok or not since usually the talos regression algorithm needs multiple data points
- # [15:46] <@MarcoZ> davidb: I see some unlabelled buttons here and there, I am not even sure *where* the right one is.
- # [15:47] <@davidb> ok
- # [15:47] <@davidb> i need to fix my windows build
- # [15:47] <@tbsaunde> davidb: ok, so, do we have a way to compare that run against the m-c changeset it is on top of?
- # [15:47] <@tbsaunde> or do we need to rerun tests first?
- # [15:48] * @tbsaunde not really sure how to use talos
- # [15:49] <@davidb> tbsaunde: we probably need to look at the actual numerical values and compare manually
- # [15:50] <@davidb> tbsaunde: it might be easier to create tests like we did for previous perf work
- # [15:50] <@davidb> actually, almost certainly easier
- # [15:50] <@tbsaunde> davidb: not sure I follow
- # [15:51] <@tbsaunde> it seems crazy that we don't have a way to test perf of a patch without landing it on a rel branch, I'm not sure I believe that
- # [15:51] <@davidb> tbsaunde: I'll back up. Why are you doing this talos try push?
- # [15:52] <@tbsaunde> davidb: so, mostly what want to look at is how much worse turning on a11y
- # [15:52] <@tbsaunde> err, sorry
- # [15:53] <@davidb> it is an interesting thing to try out, I just want to be clear I understand your goal.
- # [15:53] <@tbsaunde> mostly I want to have some real idea how much worse we are with a11y on, and where in particular we are bad
- # [15:53] <@davidb> ok
- # [15:53] <@tbsaunde> davidb: were you thinking of a different goal?
- # [15:53] <@davidb> There is also the desire to have a test for our speech rec goal, which might be a manual test like we created for previous perf work.
- # [15:53] <@davidb> Yes I was conflating the two.
- # [15:54] <@davidb> tbsaunde: I would hope green T's mean we are really performant for the regular Talos tests we have but it is worth confirming with Talos people.
- # [15:54] <@davidb> anode is one of them but on temporary leave i think
- # [15:55] <@davidb> !seen anode
- # [15:55] <@firebot> anode was last seen 27 weeks, 3 days, 16 hours, 47 minutes and 47 seconds ago, changing nick to anode|away.
- # [15:55] <@davidb> catlee is probably a good person to poke
- # [15:56] <@tbsaunde> davidb: ok, I'll try
- # [15:56] <@davidb> awesome
- # [15:56] <@tbsaunde> davidb: its pretty suprising we don't regress dom tests at all
- # [15:56] <@davidb> right. I'm skeptical.
- # [15:57] <@davidb> tbsaunde: although, the Talos tests for DOM probably don't time our 'subsequent' churn.
- # [15:57] <@davidb> when I wrote our Talos tests I had to be tricky
- # [15:58] <@davidb> force reflow to complete, then set a content timer.
- # [15:58] <@davidb> blah blah
- # [15:58] <@tbsaunde> davidb: sure, but it would still imply that having a11y on when you don't need it wouldn't hurt responsiveness, only mean some background cpu time would be used
- # [15:58] <@davidb> tbsaunde: not necessarily
- # [15:58] <@tbsaunde> davidb: why?
- # [15:59] <@davidb> we can produce a lot of churn when the refresh driver says 'go ahead'
- # [15:59] <@davidb> probably mostly around events
- # [16:01] <@davidb> i.e. WillRefresh is called
- # [16:01] <nickc> Hi surkov! Before I start to fix it, could you have a look at my potential method? http://pastebin.mozilla.org/1562265
- # [16:01] <@tbsaunde> davidb: sure, but presambly somebody else tests that if they change content what is actually gets painted in a set amount of time
- # [16:01] <@davidb> tbsaunde: i wouldn't make any assumptions about precisely what they are timing.
- # [16:02] <@tbsaunde> davidb: I guess, but it seems like somebody real should test that
- # [16:02] <@davidb> yes
- # [16:02] <@tbsaunde> any way class
- # [16:02] * tbsaunde is now known as tbsaunde|afk
- # [16:02] <@davidb> saved by the bell :)
- # [16:08] <@surkov> nickc: for nsAccessible::GetAttributes(nsIPersistentProperties **aAttributes) don't forget to create attributes
- # [16:08] <@surkov> nickc: see attributes = do_CreateInstance(NS_PERSISTENTPROPERTIES_CONTRACTID); part
- # [16:09] <nickc> Yes. So it is what you want?
- # [16:09] <@surkov> yep
- # [16:27] * Joins: hub (hub@moz-E2FCA694.figuiere.net)
- # [16:27] * ChanServ sets mode: +o hub
- # [16:38] * Joins: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP)
- # [16:42] <@firebot> nickyekaiqi@gmail.com requested feedback from the wind for attachment 613599 on bug 740764.
- # [16:42] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=740764 nor, --, ---, nickyekaiqi, NEW, merge GetAttributes and GetAttributesInternal
- # [16:42] <nickc> Just submit a patch. Hope it improves. Come back later.
- # [16:42] <nickc> Leave for a while
- # [16:42] * Quits: nickc (Mibbit@moz-91D453DB.network.nus.edu.sg) (Quit: http://www.mibbit.com ajax IRC Client)
- # [16:42] * Quits: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Input/output error)
- # [16:51] <@davidb> icaaq: feel free to comment on bug 494175
- # [16:51] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=494175 nor, --, ---, surkov.alexander, ASSI, Make <video> and <audio> controls keyboard navigable
- # [16:51] <@davidb> icaaq: I recommend reading the whole discussion first.
- # [16:52] * Joins: nhirata (nhirata.bu@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net)
- # [17:00] * Quits: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp) (Quit: mike5w3c)
- # [17:05] * Joins: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp)
- # [17:09] * Joins: ehsan (ehsan@F2D29657.F60B0462.67AC9B1.IP)
- # [17:10] <@firebot> surkov.alexander@gmail.com granted review for attachment 613332 on bug 739498.
- # [17:10] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=739498 nor, --, ---, eitan, NEW, Add Javascript layer for mobile accessibility
- # [17:11] <@MarcoZ> Yay!
- # [17:15] <@davidb> Yes epic. I'm going to review it next.
- # [17:15] <@davidb> (I began yesterday)
- # [17:16] <@MarcoZ> Have fun! :D
- # [17:16] <@davidb> heheh
- # [17:16] <@davidb> I'll try not to ask for dojo-isms
- # [17:18] <@firebot> surkov.alexander@gmail.com requested review from trev.saunders@gmail .com for attachment 613599 on bug 740764.
- # [17:18] <@firebot> surkov.alexander@gmail.com granted feedback for attachment 613599 on bug 740764.
- # [17:18] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=740764 nor, --, ---, nickyekaiqi, NEW, merge GetAttributes and GetAttributesInternal
- # [17:22] * Joins: askalski (akuda@moz-6A36EC49.ip.abpl.pl)
- # [17:22] * ChanServ sets mode: +o askalski
- # [17:33] <@firebot> ehsan@mozilla.com changed the Status on bug 740758 from ASSIGNED to RESOLVED.
- # [17:33] <@firebot> ehsan@mozilla.com set the Resolution field on bug 740758 to FIXED.
- # [17:34] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=740758 nor, --, mozilla14, markcapella, RESO FIXED, dexpcom nsAccessible::GetValue
- # [17:34] <@firebot> ehsan@mozilla.com changed the Status on bug 742695 from ASSIGNED to RESOLVED.
- # [17:34] <@firebot> ehsan@mozilla.com set the Resolution field on bug 742695 to FIXED.
- # [17:34] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=742695 nor, --, mozilla14, markcapella, RESO FIXED, densify nsARIAGridAccessible
- # [17:34] <@firebot> ehsan@mozilla.com changed the Status on bug 741701 from ASSIGNED to RESOLVED.
- # [17:34] <@firebot> ehsan@mozilla.com set the Resolution field on bug 741701 to FIXED.
- # [17:34] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=741701 nor, --, mozilla14, markcapella, RESO FIXED, CAccessibleHyperlink::get_anchor shouldn't use nsIWinAccessNode
- # [17:35] <@firebot> ehsan@mozilla.com changed the Status on bug 539683 from ASSIGNED to RESOLVED.
- # [17:35] <@firebot> ehsan@mozilla.com set the Resolution field on bug 539683 to FIXED.
- # [17:35] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=539683 nor, --, mozilla14, surkov.alexander, RESO FIXED, defunct object methods should return CO_E_OBJECTNOTCONNECTED
- # [17:42] <@firebot> surkov.alexander@gmail.com changed the Target Milestone on bug 707488 from --- to mozilla14.
- # [17:42] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=707488 cri, --, mozilla14, nobody, NEW, Crash in nsHTMLTextFieldAccessible::NativeRole or nsXULTextFieldAccessible::NativeRole
- # [17:43] * Quits: @askalski (akuda@moz-6A36EC49.ip.abpl.pl) (Quit: Wychodzi)
- # [17:54] <@firebot> ehsan@mozilla.com changed the Status on bug 741709 from ASSIGNED to RESOLVED.
- # [17:54] <@firebot> ehsan@mozilla.com set the Resolution field on bug 741709 to FIXED.
- # [17:54] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=741709 nor, --, mozilla14, markcapella, RESO FIXED, nsAccessibleWrap::get_accParent() shouldn't use do_QueryObject to get a nsDocAccessible
- # [18:01] * Quits: @surkov (surkov@B9538DF7.B7015738.33A1AC3C.IP) (Quit: surkov)
- # [18:04] * Joins: nickc (Mibbit@8A748F18.D0521ABA.428E23B0.IP)
- # [18:05] <@firebot> nickyekaiqi@gmail.com cancelled review?(trev.saunders@gmail .com) for attachment 613599 on bug 740764.
- # [18:05] <@firebot> nickyekaiqi@gmail.com requested review from trev.saunders@gmail .com for attachment 613625 on bug 740764.
- # [18:05] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=740764 nor, --, ---, nickyekaiqi, NEW, merge GetAttributes and GetAttributesInternal
- # [18:16] * Joins: jhk (jigneshhk1@8E6C34C1.A3F9767A.1C37C358.IP)
- # [18:18] * khuey is now known as khuey|away
- # [18:22] * Quits: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp) (Quit: mike5w3c)
- # [18:26] * Joins: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp)
- # [18:31] <icaaq> davidb: thanks, *eveningread*!
- # [18:31] <@davidb> :)
- # [18:33] * Quits: @hub (hub@moz-E2FCA694.figuiere.net) (Ping timeout)
- # [18:37] * Joins: fxa90id (fxa90id@moz-C6D6DA75.neoplus.adsl.tpnet.pl)
- # [18:51] * @MarcoZ is off. See you tomorrow!
- # [18:51] * Quits: @MarcoZ (Daily@moz-C84B5E86.dip.t-dialin.net) (Quit: l8er)
- # [18:54] * @eeejay heads to the airport
- # [18:54] <@eeejay> davidb, i'll have a new patch ready en route
- # [18:54] * Quits: fxa90id (fxa90id@moz-C6D6DA75.neoplus.adsl.tpnet.pl) (Connection reset by peer)
- # [18:54] <@davidb> sweet
- # [18:55] * khuey|away is now known as khuey
- # [18:56] * Joins: icaaq1 (Adium@moz-7D09279.cust.bredbandsbolaget.se)
- # [18:57] * Quits: icaaq (Adium@714E29CB.13DB46CE.3B93FF6D.IP) (Ping timeout)
- # [19:15] * Joins: hub (hub@21B7B9F2.B87E9213.6E712CE2.IP)
- # [19:15] * ChanServ sets mode: +o hub
- # [19:17] <@firebot> hub@mozilla.com granted review for attachment 613450 on bug 741683.
- # [19:17] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=741683 nor, --, ---, markcapella, ASSI, move nsAccessNode::ScrollTo to nsCoreUtils
- # [19:19] <@firebot> hub@mozilla.com granted review for attachment 613499 on bug 741681.
- # [19:19] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=741681 nor, --, ---, orangedaylily, NEW, replace nsAccessNode::GetPresContext by nsDocAccessible::PresContext
- # [19:19] <@hub> Mark_Capella|away: I'll rebase and checkin
- # [19:21] * ctalbert|afk is now known as ctalbert
- # [19:21] <Mark_Capella|away> hub: thanks :)
- # [19:23] <@davidb> khuey: i build on windows using regular make because pymake was failing after many trials and permutations. how do i convert my objdir back to using pymake? (MSYS-style srcdir being users with Pymake error)
- # [19:28] * Mark_Capella|away is now known as Mark_Capella
- # [19:28] <khuey> davidb: rm -rf objdir
- # [19:29] <khuey> and then build with pymake
- # [19:29] <Mark_Capella> python -OO build/pymake/make.py -f client.mk
- # [19:31] <jhk> and what if I only want to compile accessibility part?
- # [19:31] <@davidb> khuey: umm… that sort of defeats the purpose
- # [19:32] <@davidb> i've done my experiments… pymake just wouldn't take for me
- # [19:32] <@davidb> Mark_Capella: tried that
- # [19:32] <Mark_Capella> whats it do?
- # [19:32] <@davidb> one thing i haven't tried is changing my mozconfig… but regular make worked :(
- # [19:33] <@davidb> Mark_Capella: i'd tell you but a number of different fails are twirling in my head
- # [19:33] <Mark_Capella> for mozconfig ... mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj
- # [19:33] <@davidb> i have that
- # [19:34] <@davidb> i've pounded through issues with pymake before but never took this long
- # [19:34] <Mark_Capella> where is the mozconfig located? in the repo?
- # [19:34] <@davidb> .mozconfig
- # [19:34] <Mark_Capella> @topsrcdir@? yah .mozconfig
- # [19:35] <@davidb> when was the last time you guys did a clean build?
- # [19:35] <@davidb> using pymake
- # [19:35] <Mark_Capella> couple days ago had issues
- # [19:35] <Mark_Capella> seems theres a build problem known issue
- # [19:35] <@davidb> i think khuey fixed that yesterday
- # [19:36] <@davidb> and regarding pyc files… i fixed them
- # [19:37] <Mark_Capella> :) didnt nwo they were broken whats your situation do when you try?
- # [19:37] <@davidb> i'm trying a full clobber again
- # [19:37] <Mark_Capella> yah .... 2hours for me
- # [19:38] <@davidb> i was using pymake from my objdir… so let's see if from root works better
- # [19:38] <@davidb> (always used to use it from objdir)
- # [19:38] <Mark_Capella> from root !!!!
- # [19:38] <@davidb> Mark_Capella: that's too long
- # [19:38] <@davidb> from topsrc
- # [19:38] <Mark_Capella> right
- # [19:38] <Mark_Capella> repo
- # [19:39] <Mark_Capella> has need started from objdir ... my custom batch file switches me into topsrc
- # [19:39] <@davidb> fail
- # [19:39] <@davidb> Mark_Capella: do you use parallel build switch?
- # [19:39] <Mark_Capella> how does it fail? that fast has seveal easy reasons
- # [19:41] <@davidb> khuey, Mark_Capella: pastebin.mozilla.org/1562565
- # [19:41] <@davidb> http://pastebin.mozilla.org/1562565
- # [19:42] <Mark_Capella> thats the known issue i mentioned - restart the run and pray
- # [19:42] <@davidb> known? i tried a bug search...
- # [19:43] <@davidb> Mark_Capella: 2 hours is too long
- # [19:43] <khuey> davidb: pull
- # [19:44] <@davidb> khuey: now? i have a trunk for 2 hrs ago
- # [19:44] <@davidb> for/from
- # [19:44] <khuey> from m-c?
- # [19:44] <@davidb> inbound
- # [19:44] <khuey> ah
- # [19:44] <khuey> the fix may not have made it to inbound ...
- # [19:44] <@davidb> crap!
- # [19:44] <@davidb> although… my build seems to have gotten further
- # [19:45] <khuey> oh, it did
- # [19:45] <khuey> at 8:12:35 AM PDT
- # [19:45] <khuey> so clearly your pull is more than 2 hours old
- # [19:45] <@firebot> nickyekaiqi@gmail.com requested feedback from the wind for attachment 613663 on bug 743654.
- # [19:45] <@davidb> yeah i don't hit that particular bug anymore - the one you landed a fix for
- # [19:45] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=743654 nor, --, ---, nobody, NEW, replace nsIWinAccessNode on static_cast<nsAccessibleWrap*>
- # [19:45] <@davidb> crap
- # [19:46] <@davidb> fail
- # [19:46] <@davidb> ok pulling
- # [19:46] <Mark_Capella> https://bugzilla.mozilla.org/show_bug.cgi?id=741248
- # [19:46] <@davidb> yeah i know the bug :)
- # [19:46] <@firebot> Bug 741248 cri, --, mozilla14, khuey, RESO FIXED, pymake builds fail in nsIDOMBatteryManager.h or nsIDOMNavigatorBattery.h since the Paris bindings la
- # [19:46] <Mark_Capella> same thing?
- # [19:46] <@davidb> this time i hit mozIStorageVacuumParticipant.xpt failed
- # [19:46] <@davidb> i don't get the dom battery error anymore
- # [19:47] * @davidb tries again
- # [19:47] <Mark_Capella> what are you mozconfig options? i forgot the parallel builds keywords, i tired and stopped using soething
- # [19:47] <@davidb> -j8
- # [19:47] <@davidb> -j[n]
- # [19:48] <khuey> mk_add_options MOZ_MAKE_FLAGS=-jalot
- # [19:48] <@davidb> heh
- # [19:48] <Mark_Capella> yep - i dont go like that
- # [19:48] <@davidb> although with pymake we need to specify on command line no?
- # [19:48] <Mark_Capella> tried using the -j parm
- # [19:48] <Mark_Capella> stopped
- # [19:48] <khuey> no, you want to stick it in the makefile
- # [19:48] <Mark_Capella> in the .mozconfig
- # [19:48] <@davidb> khuey: i have it in the makefile for good measure
- # [19:48] <khuey> er, yes
- # [19:48] <khuey> in the mozconfig
- # [19:48] <@davidb> err yes mozconfig
- # [19:49] <@davidb> maybe the command line req is gone now
- # [19:49] * Joins: drexler (chatzilla@moz-BD26ECCD.hsd1.vt.comcast.net)
- # [19:49] * Quits: drexler (chatzilla@moz-BD26ECCD.hsd1.vt.comcast.net) (Quit: ChatZilla 0.9.88-rdmsoft [XULRunner 1.9.0.17/2009122204])
- # [19:49] <nickc> Sorry no need for the feedback, it has some error for that bug
- # [19:50] <nickc> I forgot to do something
- # [19:50] <@davidb> Mark_Capella: it is worth it if you can get parallel builds going
- # [19:50] <Mark_Capella> yah - i wanted to get something done so i stopped playing with it
- # [19:50] * @davidb nods
- # [19:51] <Mark_Capella> but it looks worth it - i tryied -j4 maybe something larger
- # [19:51] <@davidb> Mark_Capella: i'll just say that once you've done a full build in less than 12 minutes, you'll never go back
- # [19:51] <Mark_Capella> 12 minutes !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
- # [19:51] <Mark_Capella> no
- # [19:51] <Mark_Capella> friggin
- # [19:51] <Mark_Capella> way
- # [19:51] <@davidb> well, certainly less than 20
- # [19:52] <@davidb> khuey: what's your full clobber build time?
- # [19:52] <Mark_Capella> less than 20 on a small change is best i ever get :(
- # [19:52] <khuey> davidb: 25-30 minutes on my laptop
- # [19:52] <@davidb> khuey: that's not an MBP then
- # [19:53] <khuey> no, its not
- # [19:53] <@davidb> ok
- # [19:53] <@davidb> I'm building on a box these day
- # [19:53] <@davidb> s
- # [19:53] <khuey> my laptop is good enough usually
- # [19:54] <@davidb> yeah
- # [19:54] <khuey> except when doing android work
- # [19:54] <@davidb> oof yeah
- # [19:54] <@davidb> do you have 8 or 16?
- # [19:54] <@davidb> probably 8
- # [19:57] <@davidb> Mark_Capella: around the time of my first patch… i used to start a compile before bed, then wake up and it would still be going.
- # [19:57] <Mark_Capella> :O
- # [19:57] <@davidb> Things have improved.
- # [19:57] <@hub> just out: http://android-developers.blogspot.ca/2012/04/accessibility-are-you-serving-all-your.html <- eeejay not sure you saw that
- # [19:57] <@hub> it is a bit thin
- # [19:57] <Mark_Capella> ive got time now - maybe ill try a -j8 and se what happens
- # [19:57] <@davidb> go for it
- # [19:58] <@davidb> Mark_Capella: how many CPUs do you have?
- # [19:58] <Mark_Capella> needs to do a pull anyhow 2 cores
- # [19:58] <@davidb> what does Windows Resource Monitor show you?
- # [19:58] <@davidb> (Accessories->System Tools)
- # [19:59] <Mark_Capella> yah - two of them cpu0 and cpu1
- # [19:59] <@davidb> ok
- # [19:59] <@davidb> -j2 is enough i think
- # [19:59] <@davidb> if that's how it works
- # [20:00] <@davidb> it doesn't hurt to specify too many though
- # [20:00] <@firebot> nickyekaiqi@gmail.com cancelled feedback? for attachment 613663 on bug 743654.
- # [20:00] <@firebot> nickyekaiqi@gmail.com requested feedback from the wind for attachment 613665 on bug 743654.
- # [20:00] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=743654 nor, --, ---, nobody, NEW, replace nsIWinAccessNode on static_cast<nsAccessibleWrap*>
- # [20:00] <@davidb> hub: i think eeejay is on a plane
- # [20:00] <Mark_Capella> actually i thought i read somewhere that you should try to limit it not do -j9999
- # [20:01] <@davidb> well that probably causes some upfront churn
- # [20:01] <@hub> davidb: good point
- # [20:01] <@davidb> my build built!
- # [20:01] <@davidb> hub: but still… his phantom is here so nick'ing him makes sense
- # [20:01] <Mark_Capella> yah!!
- # [20:01] <@davidb> \o/ i can do some real work!
- # [20:01] <Mark_Capella> re-run the build when fail .. see that bug above
- # [20:01] <@davidb> oh meeting in 7 minutes
- # [20:02] <Mark_Capella> was my problem
- # [20:02] <@davidb> Mark_Capella: yeah that is my bad
- # [20:02] <@davidb> although… could have sworn i tried that
- # [20:02] <Mark_Capella> does a little danve - got 5 patchs moved in today
- # [20:02] * @davidb claps
- # [20:03] <nickc> claps too
- # [20:03] <@davidb> those aren't golf claps ;)
- # [20:03] <Mark_Capella> personal best - goes to disney world
- # [20:03] <@davidb> Mark_Capella: clearly we need to challenge you
- # [20:03] <Mark_Capella> thanks his mom .... surkov ... the academy
- # [20:04] <Mark_Capella> yah cahllenge ... talk to me after the meeting :)
- # [20:05] <@davidb> :)
- # [20:08] <Mark_Capella> hub: cool! thanks! That was the weirdest patch ive worked on
- # [20:09] <Mark_Capella> i still dont know how half of it works
- # [20:09] <Mark_Capella> :O
- # [20:12] * Joins: drexler (chatzilla@moz-BD26ECCD.hsd1.vt.comcast.net)
- # [20:19] <@firebot> hub@mozilla.com changed the Target Milestone on bug 741707 from --- to mozilla14.
- # [20:19] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=741707 nor, --, mozilla14, markcapella, ASSI, rm unused a11y CIDs
- # [20:19] <@firebot> hub@mozilla.com changed the Target Milestone on bug 741681 from --- to mozilla14.
- # [20:19] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=741681 nor, --, mozilla14, orangedaylily, NEW, replace nsAccessNode::GetPresContext by nsDocAccessible::PresContext
- # [20:20] <@firebot> hub@mozilla.com changed the Target Milestone on bug 741683 from --- to mozilla14.
- # [20:20] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=741683 nor, --, mozilla14, markcapella, ASSI, move nsAccessNode::ScrollTo to nsCoreUtils
- # [20:22] <@hub> Mark_Capella: my pleasure
- # [20:27] * Quits: nickc (Mibbit@8A748F18.D0521ABA.428E23B0.IP) (Quit: http://www.mibbit.com ajax IRC Client)
- # [20:28] * Quits: jhk (jigneshhk1@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [20:41] * Joins: jhk (jigneshhk1@8E6C34C1.A3F9767A.1C37C358.IP)
- # [20:59] * Quits: drexler (chatzilla@moz-BD26ECCD.hsd1.vt.comcast.net) (Ping timeout)
- # [20:59] <@eeejay> yo yo
- # [21:01] <@hub> hey eeejay
- # [21:03] <@davidb> eeejay: what country are you in?
- # [21:03] <@eeejay> davidb, at the gate in israel
- # [21:03] <@davidb> ok
- # [21:05] * Quits: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp) (Quit: mike5w3c)
- # [21:05] * Joins: jkiss (jkiss@5248D1C6.C5B5659C.8732AABF.IP)
- # [21:07] * Quits: jhk (jigneshhk1@8E6C34C1.A3F9767A.1C37C358.IP) (Ping timeout)
- # [21:18] * Joins: askalski (akuda@moz-6A36EC49.ip.abpl.pl)
- # [21:18] * ChanServ sets mode: +o askalski
- # [21:25] * Quits: @jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP) (Ping timeout)
- # [21:26] * Joins: jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP)
- # [21:26] * ChanServ sets mode: +o jprmc
- # [21:26] * Joins: drexler (chatzilla@moz-BD26ECCD.hsd1.vt.comcast.net)
- # [21:30] <@firebot> eitan@monotonous.org requested review from dbolter@mozilla.com for attachment 613709 on bug 739498.
- # [21:30] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=739498 nor, --, ---, eitan, NEW, Add Javascript layer for mobile accessibility
- # [21:32] * Joins: jhk (jigneshhk1@8E6C34C1.A3F9767A.1C37C358.IP)
- # [21:33] * Quits: jhk (jigneshhk1@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [21:33] <@davidb> hub: I guess Lavina didn't push to try
- # [21:33] * Joins: jhk (jigneshhk1@8E6C34C1.A3F9767A.1C37C358.IP)
- # [21:33] <@davidb> (happens)
- # [21:34] <@hub> davidb: and I didn'
- # [21:34] <@hub> and I didn't wait long enough
- # [21:34] <@hub> :-(
- # [21:34] <@hub> davidb: I have 3 patches
- # [21:34] <@davidb> happens to the best of us
- # [21:34] <@hub> actually I believe it is worse than that
- # [21:34] <@hub> it is changes colliding
- # [21:35] <@davidb> oh
- # [21:35] * Quits: nhirata (nhirata.bu@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net) (Quit: nhirata)
- # [21:36] <Mark_Capella> build -j2 elapsed time 1:18 still running
- # [21:36] <@hub> davidb: I'll push Mark_Capella's patched first
- # [21:37] <@firebot> jigneshhk1992@gmail.com requested review from trev.saunders@gmail .com for attachment 613717 on bug 741697.
- # [21:37] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=741697 nor, --, ---, jigneshhk1992, ASSI, dexpcomify CAccessibleComponent
- # [21:37] <@davidb> ok
- # [21:37] * Quits: @jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP) (Ping timeout)
- # [21:38] * Quits: jhk (jigneshhk1@8E6C34C1.A3F9767A.1C37C358.IP) (Ping timeout)
- # [21:38] * Joins: jhk (jigneshhk1@8E6C34C1.A3F9767A.1C37C358.IP)
- # [21:39] * Joins: jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP)
- # [21:39] * ChanServ sets mode: +o jprmc
- # [21:40] * Quits: jhk (jigneshhk1@8E6C34C1.A3F9767A.1C37C358.IP) (Ping timeout)
- # [21:40] * Joins: nhirata (nhirata.bu@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net)
- # [21:40] * Joins: jhk (jigneshhk1@8E6C34C1.A3F9767A.1C37C358.IP)
- # [21:53] <@hub> davidb: so shall I in that case remove the r+ flag and request the person to fix it?
- # [21:53] <Mark_Capella> build -j2 total runtime 1:36 :( >whah<
- # [21:54] <@davidb> hub: your call
- # [21:59] * Joins: fxa90id (fxa90id@moz-C6D6DA75.neoplus.adsl.tpnet.pl)
- # [22:01] * Quits: fxa90id (fxa90id@moz-C6D6DA75.neoplus.adsl.tpnet.pl) (Quit: Leaving)
- # [22:08] * Quits: victorporof (victorporo@830D7731.AB163232.79933D60.IP) (Ping timeout)
- # [22:09] * Joins: andym (andym@3A0929D2.B9EE6B50.1ECA502.IP)
- # [22:09] <drexler> Mark_Capella: i was pushing 5 hrs + with my core solo + 1GB RAM...the dark days...:(
- # [22:10] <andym> looking at web site design and worried a little bit about the font / colour choice, that could be a problem for some users
- # [22:10] <andym> is that something i should worry about and who would be the best to ask about?
- # [22:21] <@firebot> New Core - Disability Access APIs bug 744144 filed by markcapella@twcny.rr.com.
- # [22:21] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=744144 nor, --, ---, nobody, NEW, Create / Use a heuristic for @longdesc where no valid UIR exists
- # [22:22] * Quits: jkiss (jkiss@5248D1C6.C5B5659C.8732AABF.IP) (Client exited)
- # [22:23] <@davidb> andym: yeah we need to track that
- # [22:23] <@davidb> andym: you could file bugs, I think satdav is the one to ping
- # [22:23] <andym> davidb: it feels rather subjective so it's hard for me to say
- # [22:23] <@davidb> andym: there are some analyzers out there
- # [22:25] <@davidb> andym: you could also ask for community help here https://lists.mozilla.org/listinfo/accessibility
- # [22:25] <@davidb> lots of industry experts would probably jump in
- # [22:25] <@davidb> failing that i can help you
- # [22:25] <@davidb> but i need to juggle priorities
- # [22:26] <andym> ok, i'lll see how it goes with the designs
- # [22:26] <andym> thanks
- # [22:26] <@davidb> anytime
- # [22:27] <@davidb> andym: there is a contrast analyzer addon
- # [22:27] <andym> https://addons.mozilla.org/en-US/firefox/addon/juicy-studio-accessibility-too/ ?
- # [22:28] <@davidb> maybe - i can't recall for sure
- # [22:28] <andym> that gives the site pretty bad ratings :)
- # [22:28] <andym> cool
- # [22:28] <@davidb> andym: are you in webdev?
- # [22:29] <andym> yes
- # [22:29] <@davidb> we need to be upfront about a11y as part of Ux
- # [22:29] * Joins: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp)
- # [22:29] <andym> we do, i've filed bugs on this the past and they haven't gone far
- # [22:29] <@hub> andym: bug #?
- # [22:29] <andym> i'd like to push it in the marketplace, which i'm working on
- # [22:29] <@davidb> ok you have my support
- # [22:30] <andym> cool, it's more getting people to do it
- # [22:30] <@davidb> my/our
- # [22:30] <@davidb> yes
- # [22:30] <@davidb> i can help with that
- # [22:30] <andym> https://bugzilla.mozilla.org/show_bug.cgi?id=686499
- # [22:30] <@firebot> Bug 686499 nor, --, ---, nobody, NEW, Let's be accessible
- # [22:30] <andym> gosh thats old
- # [22:31] * @davidb comments
- # [22:32] * Quits: @askalski (akuda@moz-6A36EC49.ip.abpl.pl) (Quit: Wychodzi)
- # [22:33] <@hub> davidb: maybe we should make sure that sort of bug gets CC to us
- # [22:33] <@hub> or something
- # [22:34] <@davidb> hub: I just added the access keyword
- # [22:34] <@davidb> I'd like to see a Mozilla community group gather around this.
- # [22:35] <andym> i'd like to see webdev be part of that
- # [22:36] <@davidb> andym: I like that you said that :)
- # [22:36] <@davidb> andym: maybe talk to your team, and if you like you can help us do it via the mailing list
- # [22:36] <@davidb> you can drive it
- # [22:36] * Joins: askalski (akuda@moz-6A36EC49.ip.abpl.pl)
- # [22:36] * ChanServ sets mode: +o askalski
- # [22:36] <andym> there's a webdev off site at the end of the month
- # [22:37] <@davidb> but definitely connect with satdav
- # [22:37] <@davidb> andym: where?
- # [22:37] <andym> santa clara,
- # [22:37] <andym> maybe we can get someone to come over talk and start to kick things off
- # [22:38] <@davidb> yeah
- # [22:38] <@davidb> andym: can you email me the dates
- # [22:38] <@davidb> or a link
- # [22:38] <@davidb> or ping me here with that if you can before i pack up :)
- # [22:39] <andym> https://intranet.mozilla.org/Webdev:Offsite
- # [22:39] <@davidb> andym: you might ask around on your team if anyone cows WCAG
- # [22:39] <@davidb> cows/knows
- # [22:39] <andym> Santa Cruz even
- # [22:39] <@davidb> yeah tempting :)
- # [22:40] <@davidb> ok i gotta run
- # [22:40] <@davidb> should be back on line tonight (in ~4 hours) or tomorrow
- # [22:41] * Quits: @davidb (davidb@F2D29657.F60B0462.67AC9B1.IP) (Quit: davidb)
- # [22:43] * Quits: @jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP) (Ping timeout)
- # [23:03] * Quits: drexler (chatzilla@moz-BD26ECCD.hsd1.vt.comcast.net) (Quit: ChatZilla 0.9.88-rdmsoft [XULRunner 1.9.0.17/2009122204])
- # [23:11] * Joins: jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP)
- # [23:11] * ChanServ sets mode: +o jprmc
- # [23:31] * tbsaunde|afk is now known as tbsaunde
- # Session Close: Wed Apr 11 00:00:01 2012
The end :)