/irc-logs / mozilla / #accessibility / 2012-04-26 / end
Options:
- # Session Start: Thu Apr 26 00:00:00 2012
- # Session Ident: #accessibility
- # [00:04] <@hub> infra issues it seems
- # [00:04] <@hub> you can land on central if you want :-)
- # [00:04] <@hub> oh no closed too
- # [00:04] <@hub> my bad
- # [00:17] * Quits: shorlander-mobile (shorlander@F2D29657.F60B0462.67AC9B1.IP) (Quit: Leaving...)
- # [00:19] * Joins: brambles (brambles@4CBAB088.F3076E90.1822ACA6.IP)
- # [00:19] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [00:20] * Joins: shorlander-mobile (shorlander@F2D29657.F60B0462.67AC9B1.IP)
- # [00:30] * Quits: nhirata (nhirata.bu@F2D29657.F60B0462.67AC9B1.IP) (Quit: nhirata)
- # [00:31] * Joins: nhirata (nhirata.bu@F2D29657.F60B0462.67AC9B1.IP)
- # [00:32] * Quits: nhirata (nhirata.bu@F2D29657.F60B0462.67AC9B1.IP) (Quit: nhirata)
- # [00:37] * Quits: victorporof (victorporo@F2D29657.F60B0462.67AC9B1.IP) (Quit: Leaving...)
- # [00:41] * Quits: shorlander-mobile (shorlander@F2D29657.F60B0462.67AC9B1.IP) (Quit: Leaving...)
- # [01:05] * Joins: Jamie (jamie@moz-CA26021.jantrid.net)
- # [01:09] <@firebot> sphink@gmail.com changed the Component on bug 741041 from JavaScript Engine to Keyboard: Navigation.
- # [01:09] <@firebot> sphink@gmail.com changed the Target Milestone on bug 741041 from --- to mozilla14.
- # [01:09] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=741041 nor, --, mozilla14, nobody, NEW, Wrapper hygiene for typed arrays and friends
- # [01:11] <@firebot> sphink@gmail.com changed the Status on bug 741041 from NEW to ASSIGNED.
- # [01:24] <@firebot> sphink@gmail.com changed the Component on bug 741041 from Keyboard: Navigation to JavaScript Engine.
- # [01:24] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=741041 nor, --, mozilla14, sphink, ASSI, Wrapper hygiene for typed arrays and friends
- # [01:27] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [01:27] * Quits: aaronlev (aaronlev@moz-654DF715.bstnma.fios.verizon.net) (Quit: aaronlev)
- # [01:30] * Quits: khuey (khuey@moz-B77DEAEB.mozilla.org) (Ping timeout)
- # [01:37] <@firebot> hub@mozilla.com requested review from ted.mielczarek@gmai l.com for attachment 618473 on bug 733513.
- # [01:38] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=733513 nor, --, ---, hub, NEW, Enable accessibility on Mac
- # [01:43] * Joins: surkov (surkov@A4C60ACB.84614B10.33A1AC3C.IP)
- # [01:43] * ChanServ sets mode: +o surkov
- # [01:44] * Joins: nhirata (nhirata.bu@8F761026.B5EF4AF6.E96CA9D8.IP)
- # [01:48] * Quits: nhirata (nhirata.bu@8F761026.B5EF4AF6.E96CA9D8.IP) (Ping timeout)
- # [01:54] * Joins: aaronlev (aaronlev@moz-654DF715.bstnma.fios.verizon.net)
- # [02:11] * Quits: aaronlev (aaronlev@moz-654DF715.bstnma.fios.verizon.net) (Quit: aaronlev)
- # [02:12] * Quits: brambles (brambles@4CBAB088.F3076E90.1822ACA6.IP) (Ping timeout)
- # [02:21] * Quits: ehsan (ehsan@F2D29657.F60B0462.67AC9B1.IP) (Input/output error)
- # [02:29] * Joins: khuey (khuey@moz-B77DEAEB.mozilla.org)
- # [02:37] * Joins: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP)
- # [02:39] * Quits: @surkov (surkov@A4C60ACB.84614B10.33A1AC3C.IP) (Quit: surkov)
- # [02:57] * ctalbert is now known as ctalbert|afk
- # [02:57] * Joins: aaronlev (aaronlev@moz-654DF715.bstnma.fios.verizon.net)
- # [03:03] <@firebot> maxli@maxli.ca requested review from trev.saunders@gmail .com for attachment 618494 on bug 739884.
- # [03:03] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=739884 nor, --, ---, maxli, NEW, decomtaminate impl of UnselectRow() and UnselectCol() on accessible tables
- # [03:15] * @eeejay goes home
- # [03:18] * Joins: Daniel_Goodrich (chatzilla@moz-6CDAFAD9.allocated.csupomona.edu)
- # [03:24] <Mark_Capella> bye eeejay!
- # [03:24] <@eeejay> Mark_Capella, bye! i am actually still here for a bit. i just tried to scare you
- # [03:24] <Mark_Capella> laughs ... i see bugzilla is back
- # [03:38] <Daniel_Goodrich> I have been looking through nsDocAccessible.cpp and FocusManager.cpp for bug #731091. I personally don't know where to start with trying to go about it. Can anyone point me in the right direction?
- # [03:38] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=731091 nor, --, mozilla13, Jennyherrera.19, NEW, menuStart accessible event fired on sub-menu after focus event for focused item
- # [03:43] <Mark_Capella> tbsaunde: are you here / busy?
- # [03:44] * Quits: @hub (hub@21B7B9F2.B87E9213.6E712CE2.IP) (Ping timeout)
- # [03:44] <Mark_Capella> daniel_goodrich: tbsaunde is probably the best bet if hes around...
- # [03:44] <Daniel_Goodrich> ok
- # [03:45] <Mark_Capella> or surkov of course but he comes in later
- # [03:45] <Daniel_Goodrich> about what time does he come in?
- # [03:46] <Mark_Capella> somewhere around and after midnight US EST usually
- # [03:46] <Mark_Capella> sometimes earlier
- # [03:47] <Daniel_Goodrich> ok, thanks... hopefully tbsaude comes back sooner than that
- # [03:48] <Mark_Capella> yah hes on EST time but keeps late hours also
- # [03:48] <Mark_Capella> night owl
- # [03:49] <@firebot> trev.saunders@gmail.com requested review from surkov.alexander@gm ail.com for attachment 618494 on bug 739884.
- # [03:49] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=739884 nor, --, ---, maxli, NEW, decomtaminate impl of UnselectRow() and UnselectCol() on accessible tables
- # [03:49] <@tbsaunde> Daniel_Goodrich: hi?
- # [03:51] <@tbsaunde> Daniel_Goodrich: so, I think a good idea would be that you add menu popup open / close methods to the mozilla::a11y::FocusManager
- # [03:51] <@tbsaunde> and you call them from nsFocusManager in dom/base/nsFocusManager.h/cpp
- # [03:53] <Daniel_Goodrich> so it would be adding those methods to a11yGeneric.h file and nsFocusManager file?
- # [03:53] <Daniel_Goodrich> or do i leave a11ygeneric alone?
- # [03:54] <@tbsaunde> no, FocusManger.h/cpp not A11yGeneric.h
- # [03:55] <Daniel_Goodrich> ok.. that gives me more of somewhere to start. I might have more questions later
- # [03:57] <@tbsaunde> ok, you should probably talk to surkov, he's thought about it more than me I think, and probably will show up beore 00-00
- # [03:57] <@tbsaunde> if you won't be around that long though feel free to ask in the bug :)
- # [03:58] <Daniel_Goodrich> ok, thank you
- # [03:58] <@tbsaunde> yw
- # [03:59] <@tbsaunde> sorry I can't think about it more, kind of busy and pretty tired
- # [03:59] <Daniel_Goodrich> thats fine.. It is just hard because I still haven't figured out what everything does
- # [04:02] <@tbsaunde> sure, there's a lot of stuff
- # [04:12] * Quits: drexler (chatzilla@moz-BD26ECCD.hsd1.vt.comcast.net) (Quit: ChatZilla 0.9.88-rdmsoft [XULRunner 1.9.0.17/2009122204])
- # [04:28] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [04:28] <@firebot> trev.saunders@gmail.com requested feedback from surkov.alexander@ gmail.com for attachment 618167 on bug 445516.
- # [04:29] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=445516 nor, --, ---, andrew.quartey, ASSI, Support auto-generated=true text attribute on list bullets
- # [04:30] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [04:46] * Joins: surkov (surkov@A4C60ACB.84614B10.33A1AC3C.IP)
- # [04:46] * ChanServ sets mode: +o surkov
- # [04:59] <@firebot> surkov.alexander@gmail.com cancelled review?(surkov.alexander@gm ail.com) for attachment 618311 on bug 746974.
- # [04:59] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=746974 nor, --, ---, nobody, NEW, hittest/ tests expect direct accessible, not text leaves or the like as deepest child on Mac
- # [05:10] <@firebot> surkov.alexander@gmail.com cancelled review?(surkov.alexander@gm ail.com) for attachment 618384 on bug 575976.
- # [05:10] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=575976 nor, --, ---, dbolter, NEW, ARIA conformance, relation trumps role=presentation
- # [05:10] * Quits: @surkov (surkov@A4C60ACB.84614B10.33A1AC3C.IP) (Quit: surkov)
- # [05:16] * khuey is now known as khuey|away
- # [05:16] * khuey|away is now known as khuey
- # [05:41] <@firebot> khuey@kylehuey.com changed the Status on bug 746868 from ASSIGNED to RESOLVED.
- # [05:41] <@firebot> khuey@kylehuey.com set the Resolution field on bug 746868 to FIXED.
- # [05:41] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=746868 nor, --, mozilla15, surkov.alexander, RESO FIXED, Some subtests in test_doc.html fail with Bug 695480
- # [05:49] <@firebot> khuey@kylehuey.com changed the Status on bug 745740 from ASSIGNED to RESOLVED.
- # [05:49] <@firebot> khuey@kylehuey.com set the Resolution field on bug 745740 to FIXED.
- # [05:49] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=745740 nor, --, mozilla15, markcapella, RESO FIXED, De-ns-ify nsApplicationAccessible
- # [05:56] * Quits: aaronlev (aaronlev@moz-654DF715.bstnma.fios.verizon.net) (Quit: aaronlev)
- # [06:01] * Daniel_Goodrich is now known as Shnish
- # [06:08] * Joins: nhirata (nhirata.bu@8F761026.B5EF4AF6.E96CA9D8.IP)
- # [06:11] * Joins: aaronlev (aaronlev@moz-654DF715.bstnma.fios.verizon.net)
- # [06:28] * Joins: ehsan_ (ehsan@F0B20A8D.8458880F.57F33CED.IP)
- # [06:28] * Quits: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Ping timeout)
- # [06:30] * Joins: jesfre (jesfre@moz-25B25285.war.clearwire-wmx.net)
- # [06:30] * Quits: jesfre (jesfre@moz-25B25285.war.clearwire-wmx.net) (Quit: jesfre)
- # [06:34] <Shnish> tbsaunde: What you want us to do for this bug is to make 2 methods.
- # [06:34] <Shnish> menu popup open() that takes in the submenu and focuses it
- # [06:34] <Shnish> and close() that takes in the heirarchy and focuses the next one up?
- # [06:35] <Shnish> trying to get a better grasp of what you would like to have done instead of throwing something down without thinking hard about it
- # [06:37] * Mark_Capella is now known as Mark_Capella|away
- # [06:37] <Shnish> fyi this is Daniel_Goodrich from before
- # [06:42] * Joins: hub (hub@moz-E2FCA694.figuiere.net)
- # [06:42] * ChanServ sets mode: +o hub
- # [06:49] <@tbsaunde> Shnish: I think so
- # [06:49] <Shnish> ok, that at least makes it a little bit more clear of what we are aiming for
- # [06:51] <Shnish> tbsaunde: would you be able to tell us where we can find some code that might call this so we have an idea of what would be passed in as parameters?
- # [06:53] <@tbsaunde> trying to figure that out now
- # [06:56] * Joins: mike5w3c (MikeS@moz-260332AA.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com)
- # [07:05] <@tbsaunde> Shnish: I think you want to look at where popupshown and popuphiding are fired in layout/xul/base
- # [07:08] <@tbsaunde> in particular nsMenuPopupFrame.cpp and nsXULPopupManager.cpp
- # [07:09] * Quits: aaronlev (aaronlev@moz-654DF715.bstnma.fios.verizon.net) (Quit: aaronlev)
- # [07:09] <@tbsaunde> using the nsXULPopup{Hiding,Shown}Event classes
- # [07:09] * Joins: jenniferherrera (chatzilla@moz-DF390D.lsanca.fios.verizon.net)
- # [07:23] <Shnish> ok, I will look into that
- # [07:28] * Quits: Jamie (jamie@moz-CA26021.jantrid.net) (Ping timeout)
- # [07:31] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [07:35] * Joins: surkov (surkov@A4C60ACB.84614B10.33A1AC3C.IP)
- # [07:35] * ChanServ sets mode: +o surkov
- # [07:39] <Shnish> tbsaunde: is there a reason why there is no .h file for nsXULPopupManager.cpp ?
- # [07:40] <Shnish> nevermind, found it further into the folders, but not in the same one
- # [07:42] <@firebot> surkov.alexander@gmail.com requested review from marco.zehe@googlema il.com for attachment 618404 on bug 559747.
- # [07:42] <@firebot> surkov.alexander@gmail.com granted feedback for attachment 618404 on bug 559747.
- # [07:42] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=559747 nor, --, ---, markcapella, ASSI, make <input type="search"> accessible
- # [07:46] * Quits: fxa90id (fxa90id@moz-26877F43.neoplus.adsl.tpnet.pl) (Ping timeout)
- # [07:53] <Shnish> surkov: I was told you could help me with this bug: #731091. with help I have gotten as far as looking into adding 2 new methods into nsFocusManager.cpp called menu popup open and close. right now I am having trouble figuring out what I should take in as the parameters.
- # [07:53] <@surkov> let me look
- # [07:54] <@surkov> Shnish: it's hard to say because I don't have any idea of approach you take. Could you describe it in the bug please?
- # [07:58] <Shnish> will do
- # [08:02] <Shnish> trying to word it / describe what i am thinking right now
- # [08:10] <Shnish> surkov: Bug 731091 I have posted my approach to it, but I am not 100% sure if it would be the right one
- # [08:10] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=731091 nor, --, mozilla13, Jennyherrera.19, NEW, menuStart accessible event fired on sub-menu after focus event for focused item
- # [08:26] * Quits: mike5w3c (MikeS@moz-260332AA.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com) (Ping timeout)
- # [08:26] * Joins: mike5w3c (MikeS@moz-260332AA.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com)
- # [08:31] * Joins: MarcoZ (Daily@moz-72247ABE.dip.t-dialin.net)
- # [08:31] * ChanServ sets mode: +o MarcoZ
- # [08:39] <@surkov> Shnish: ok
- # [08:44] <@surkov> Shnish: asnwered
- # [08:44] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [08:46] <@firebot> marco.zehe@googlemail.com granted review for attachment 618404 on bug 559747.
- # [08:46] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=559747 nor, --, ---, markcapella, ASSI, make <input type="search"> accessible
- # [08:47] <Shnish> surkov: I will research it and get back to you as soon as I can.
- # [08:48] <@surkov> Shnish: ok, cool, btw, this bug is not assigned to you, is it on purpose?
- # [08:48] <Shnish> it is assigned to Jenny, shes my friend and we are working on this together
- # [08:49] <Shnish> surkov: I dont know if we should be both be assigned to it, or just one of us, but either way works for me.
- # [08:49] <@surkov> Shnish: the bug can have only one assignee, so as long both of you are fine with that then I don't care
- # [08:50] * Quits: @hub (hub@moz-E2FCA694.figuiere.net) (Ping timeout)
- # [08:51] * khuey is now known as khuey|away
- # [08:56] <Shnish> surkov: Ok, I will probably be responding in the morning sometime as I am tired after a grueling midterm at school and long day.
- # [08:57] <@surkov> Shnish: ok
- # [08:58] * Quits: jenniferherrera (chatzilla@moz-DF390D.lsanca.fios.verizon.net) (Client exited)
- # [09:15] <Shnish> surkov: what times are you online?
- # [09:17] <@surkov> Shnish: I think I'll stay about 5-6 hours more
- # [09:19] <Shnish> surkov: probably wont be able to get back to you before you leave =/, but i will wait for a response when you get back online tomorrow then
- # [09:25] <@surkov> Shnish: ok, if I'm on online then ask in the bug
- # [09:25] <Shnish> surkov: will do
- # [09:41] <@firebot> surkov.alexander@gmail.com cancelled review?(surkov.alexander@gm ail.com) for attachment 618346 on bug 716644.
- # [09:41] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=716644 nor, --, ---, askalski, NEW, expandoify accessible roles
- # [09:49] <@firebot> surkov.alexander@gmail.com granted review for attachment 618494 on bug 739884.
- # [09:49] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=739884 nor, --, ---, maxli, NEW, decomtaminate impl of UnselectRow() and UnselectCol() on accessible tables
- # [09:50] <@firebot> surkov.alexander@gmail.com cancelled feedback?(surkov.alexander@ gmail.com) for attachment 618167 on bug 445516.
- # [09:50] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=445516 nor, --, ---, andrew.quartey, ASSI, Support auto-generated=true text attribute on list bullets
- # [10:21] * Quits: logbot (logbot@moz-622AFC27.glob.com.au) (Ping timeout)
- # [10:21] * Joins: margle (margle@1E87181D.52CE079D.3F07090C.IP)
- # [10:26] * Joins: logbot (logbot@moz-622AFC27.glob.com.au)
- # [10:31] * Quits: icaaq (Adium@moz-718D9655.cust.bredbandsbolaget.se) (Quit: Leaving.)
- # [10:50] * Quits: mike5w3c (MikeS@moz-260332AA.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com) (Ping timeout)
- # [10:50] * Joins: icaaq (Adium@moz-718D9655.cust.bredbandsbolaget.se)
- # [11:34] <@firebot> marco.zehe@googlemail.com changed the Target Milestone on bug 746164 from mozilla14 to mozilla15.
- # [11:36] <@MarcoZ> OK, in theory, all tests should pass or give a documented todo now when a11y gets enabled on OS X for inbound and central. Fingers crossed!
- # [11:37] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [11:37] <@MarcoZ> surkov: Looks like bug 745788 isn't fixed yet, I just sarred one failure on inbound myself. :(
- # [11:37] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=745788 nor, --, ---, nobody, NEW, Intermittent a11y/accessible/treeupdate/test_imagemap.html | Test timed out
- # [11:38] <@surkov> MarcoZ: did anybody fix it?
- # [11:38] <@MarcoZ> Oh wait, that was a logging patch that got pushed, right?
- # [11:38] <@MarcoZ> Sorry, my bad.
- # [11:38] <@surkov> trevor pushed some logging paths recently
- # [11:39] <@surkov> except the one you did iirc
- # [11:39] * @MarcoZ nods.
- # [11:50] * Joins: mike5w3c (MikeS@moz-260332AA.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com)
- # [11:52] * Quits: mike5w3c (MikeS@moz-260332AA.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com) (Ping timeout)
- # [11:53] * Joins: mike5w3c (MikeS@moz-260332AA.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com)
- # [11:55] * Quits: mike5w3c (MikeS@moz-260332AA.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com) (Ping timeout)
- # [11:57] * Quits: margle (margle@1E87181D.52CE079D.3F07090C.IP) (Ping timeout)
- # [11:58] * Joins: margle (margle@1E87181D.52CE079D.3F07090C.IP)
- # [12:00] * Quits: margle (margle@1E87181D.52CE079D.3F07090C.IP) (Ping timeout)
- # [12:01] * Joins: margle (margle@1E87181D.52CE079D.3F07090C.IP)
- # [12:01] * Joins: mike5w3c (MikeS@moz-260332AA.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com)
- # [12:03] * Quits: mike5w3c (MikeS@moz-260332AA.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com) (Ping timeout)
- # [12:05] * Joins: mike5w3c (MikeS@moz-260332AA.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com)
- # [12:06] * Quits: mike5w3c (MikeS@moz-260332AA.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com) (Quit: Make the road by walking. (B-side: Tired of Fighting))
- # [12:09] * Quits: margle (margle@1E87181D.52CE079D.3F07090C.IP) (Ping timeout)
- # [12:09] * Joins: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP)
- # [12:10] * Quits: ehsan_ (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Ping timeout)
- # [12:12] * Joins: margle (margle@1E87181D.52CE079D.3F07090C.IP)
- # [12:14] * Quits: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Input/output error)
- # [12:17] * Joins: brambles (brambles@4CBAB088.F3076E90.1822ACA6.IP)
- # [12:31] * Quits: margle (margle@1E87181D.52CE079D.3F07090C.IP) (Quit: Computer has gone to sleep.)
- # [12:52] * Joins: margle (margle@moz-15EB76B9.dsl.mweb.co.za)
- # [13:00] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [13:19] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Ping timeout)
- # [13:20] <@firebot> maxli@maxli.ca requested review from surkov.alexander@gm ail.com for attachment 618616 on bug 739884.
- # [13:20] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=739884 nor, --, ---, maxli, NEW, decomtaminate impl of UnselectRow() and UnselectCol() on accessible tables
- # [13:21] <@firebot> bmo@edmorley.co.uk changed the Target Milestone on bug 746164 from mozilla15 to ---.
- # [13:21] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=746164 nor, --, ---, marco.zehe, REOP, Failure for the shortcut keys in actions/test_keys.html b/accessible/tests/mochitest/actions/test_ke
- # [13:28] <@firebot> maxli@maxli.ca cancelled review?(surkov.alexander@gm ail.com) for attachment 618616 on bug 739884.
- # [13:28] <@firebot> maxli@maxli.ca requested review from surkov.alexander@gm ail.com for attachment 618617 on bug 739884.
- # [13:30] <@firebot> surkov.alexander@gmail.com changed the Target Milestone on bug 559747 from --- to mozilla15.
- # [13:30] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=559747 nor, --, mozilla15, markcapella, ASSI, make <input type="search"> accessible
- # [13:36] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [13:38] <@firebot> surkov.alexander@gmail.com granted review for attachment 618617 on bug 739884.
- # [13:38] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=739884 nor, --, ---, maxli, NEW, decomtaminate impl of UnselectRow() and UnselectCol() on accessible tables
- # [14:09] * Joins: mike5w3c (MikeS@moz-E9ABBA62.wireless.csail.mit.edu)
- # [14:19] * Joins: davidb (davidb@moz-68BF56A6.dsl.bell.ca)
- # [14:19] * ChanServ sets mode: +qo davidb davidb
- # [14:21] <@davidb> hi all!
- # [14:22] <@davidb> surkov: the hasRelatedContent || Has… was to avoid calling twice but maybe this can't happen (I'll need to check control flow)? Also I guess HasRelatedContent is cheap now right?
- # [14:30] <@firebot> dbolter@mozilla.com changed the Status on bug 575976 from NEW to RESOLVED.
- # [14:30] <@davidb> surkov: never mind - the bug is invalid.
- # [14:30] <@firebot> dbolter@mozilla.com set the Resolution field on bug 575976 to INVALID.
- # [14:30] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=575976 nor, --, ---, dbolter, RESO INVALID, ARIA conformance, relation trumps role=presentation
- # [14:33] <@davidb> heh
- # [14:33] <@davidb> I probably 'fixed' that bug in W3C space and promptly forgot.
- # [14:37] <@MarcoZ> Hi davidb!
- # [14:37] <@davidb> Hi MarcoZ!
- # [14:40] * Joins: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP)
- # [14:40] * Joins: askalski (akuda@moz-4C8A107E.pool85-48-91.dynamic.orange.es)
- # [14:40] * ChanServ sets mode: +o askalski
- # [14:42] * Joins: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com)
- # [14:58] <@firebot> ted.mielczarek@gmail.com granted review for attachment 618473 on bug 733513.
- # [14:58] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=733513 nor, --, ---, hub, NEW, Enable accessibility on Mac
- # [14:58] <@askalski> tbsaunde, where AtkObject declaration comes from? I need to add include
- # [15:00] <@askalski> surkov, ^
- # [15:03] <@MarcoZ> Yay!
- # [15:03] * Quits: mike5w3c (MikeS@moz-E9ABBA62.wireless.csail.mit.edu) (Quit: mike5w3c)
- # [15:04] <@askalski> MarcoZ, hi
- # [15:04] <@askalski> MarcoZ, do you possibly know where AtkRole is defined?
- # [15:04] <@askalski> MarcoZ, I am dying from compiler errors
- # [15:05] <@davidb> askalski: maybe atkobject.h?
- # [15:05] * @davidb is guessing
- # [15:05] <@askalski> davidb, found it via eclipse, not found
- # [15:05] <@askalski> davidb, compiler says
- # [15:05] <@MarcoZ> askalski: I would have to grep, too, in the atk/ dir.
- # [15:06] * @MarcoZ would very very very much like to push bug 733513, but it's Hub's bug.
- # [15:06] <@davidb> askalski: you might want to hang out on #a11y on irc.gimp.net
- # [15:06] <@davidb> they'd know
- # [15:06] <@davidb> MarcoZ: hehe
- # [15:07] * Joins: mike5w3c (MikeS@moz-E9ABBA62.wireless.csail.mit.edu)
- # [15:07] * @MarcoZ hopes all the test disablings stick this time. Darn typo!
- # [15:08] * Quits: nhirata (nhirata.bu@8F761026.B5EF4AF6.E96CA9D8.IP) (Quit: nhirata)
- # [15:08] <@askalski> davidb, not working, finding only files that use it
- # [15:09] * Joins: aaronlev (aaronlev@moz-654DF715.bstnma.fios.verizon.net)
- # [15:09] <@davidb> askalski: if you've been fighting compiler errors for a while you might want to go get a sandwich then come back fresh.
- # [15:10] <@askalski> davidb, did that. I just want to push this bug and go back to MATS, this one takes hours more than expected
- # [15:10] <@askalski> davidb, it's getting all kind "oh, btw, refactor that"
- # [15:10] <@davidb> askalski: want to pastebin?
- # [15:10] <@davidb> askalski: if you want to negotiate the 'btw' stuff you can :) people are reasonable
- # [15:11] <@askalski> davidb, no need. I either get "atkobject.h" not found while I try to include it
- # [15:11] <@davidb> and if they aren't then bribe them
- # [15:11] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Ping timeout)
- # [15:11] <@askalski> or "AtkRole" not defined (in nsAccessibleWrap.h, cpp miracoulsy have it, and I don't know where from)
- # [15:12] <@davidb> askalski: is it built via some pre-processor magic?
- # [15:12] <@askalski> davidb, no, it's a standard enum defined in atkobject.h, but included some magic way via some other file
- # [15:12] <@davidb> yes indeed
- # [15:12] <@askalski> davidb, I tried to bisect includes from cpp to find it
- # [15:12] <@askalski> but each of them gets me a error
- # [15:12] <@davidb> askalski: does atk.h include it
- # [15:13] <@askalski> davidb, no such file "atk.h"
- # [15:13] <@askalski> :(
- # [15:13] <@davidb> #include <atk.h> ?
- # [15:13] <@askalski> davidb, do I have to work with Makefile.in to get these includes?
- # [15:14] <@askalski> davidb, yes. #include <atk.h?
- # [15:14] <@davidb> oh
- # [15:14] <@davidb> #include <atk/atk.h>
- # [15:14] <@askalski> #include <atk/atkobject.h>
- # [15:15] <@askalski> the force is with us
- # [15:15] <@davidb> good
- # [15:15] <@davidb> note you might want to just have:
- # [15:15] <@davidb> #include "nsMai.h"
- # [15:15] <@davidb> then you get macros and stuff
- # [15:15] * @davidb shrugs
- # [15:16] <@askalski> davidb, no, still doesnt work
- # [15:16] <@askalski> it just took longer to rebuild...
- # [15:16] <@davidb> try all three
- # [15:16] <@davidb> separately
- # [15:16] <@davidb> build each time
- # [15:16] <@askalski> davidb, btw, I wondered what this Mai is
- # [15:16] * Joins: clown (clown@67828CC7.C1A51174.9D42CF23.IP)
- # [15:17] <@davidb> i forget
- # [15:17] * Joins: victorporof (victorporo@F2D29657.F60B0462.67AC9B1.IP)
- # [15:18] <@davidb> something like Mozilla Atk/Accessibility Implementation/Interface
- # [15:19] <@davidb> looks like tbsaunde and surkov worked a long day yesterday
- # [15:20] <@davidb> as far as "yesterday" makes sense in a global team
- # [15:22] <@askalski> davidb, yeah. I am dying by this compiler
- # [15:22] <@askalski> davidb, now this is weird: ../../../dist/system_wrappers/atk/atk.h:3:26: fatal error: atk/atk.h: no such file or directory
- # [15:23] * @MarcoZ knows why he tries to stay away from C++ coding as far as possible, except for very simple stuff. xD
- # [15:23] <@davidb> askalski: you may need to do a clobber
- # [15:24] <@davidb> MarcoZ: yeah this is worse… build pain.
- # [15:24] <@askalski> davidb, clobber?
- # [15:27] <@MarcoZ> make -f client.mk clean
- # [15:27] <@MarcoZ> and then rebuild.
- # [15:28] <@askalski> MarcoZ, doing that :D
- # [15:35] <@davidb> i actually rm -rf objdir for good measure
- # [15:36] <@MarcoZ> davidb: Yeah that's the catch-all solution. :D
- # [15:37] <@askalski> davidb, MarcoZ, I never make clean, I always rm -rf. someone at this channel adviced me to do so
- # [15:40] * Joins: nhirata (nhirata.bu@F2D29657.F60B0462.67AC9B1.IP)
- # [15:41] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [15:44] <@askalski> davidb, ok, I am doing one last try and if it doesn't work I ingore some patch comments
- # [15:44] <@MarcoZ> askalski: Probably wise.
- # [15:45] <@askalski> let us all hope that Rust and Servo do not suck the same way
- # [15:45] <@MarcoZ> If they happen.
- # [15:45] <@MarcoZ> davidb: Any indications that Mozilla is switching away from Mercurial to git?
- # [15:46] <@davidb> I haven't heard anything recent
- # [15:46] <@MarcoZ> davidb: OK!
- # [15:54] * Mark_Capella|away is now known as Mark_Capella
- # [15:56] <@firebot> surkov.alexander@gmail.com changed the Target Milestone on bug 739884 from --- to mozilla15.
- # [15:56] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=739884 nor, --, mozilla15, maxli, NEW, decomtaminate impl of UnselectRow() and UnselectCol() on accessible tables
- # [15:59] <@askalski> tbsaunde, sorry, there will be no PRUint32 -> AtkRole change in method definition. it's a no-go now.
- # [16:05] * clown is now known as clown_mtg
- # [16:06] * Joins: shorlander-mobile (shorlander@F2D29657.F60B0462.67AC9B1.IP)
- # [16:10] * Quits: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Input/output error)
- # [16:12] * Joins: jeremy (Adium@F2D29657.F60B0462.67AC9B1.IP)
- # [16:16] <@tbsaunde> askalski: you want to include atk/atk.h
- # [16:17] <@tbsaunde> davidb: nsMai.h should maybe get killed eventually I'm not quiet sure yet
- # [16:18] <@davidb> ok
- # [16:18] <@tbsaunde> I'm not really sure about the atk headers we keep in other-lienses either, I sort of want to get rid of them, on the other hand it would be nice to be able to include only one atk header sometimes
- # [16:18] <@davidb> i thought askalski tried atk/atk.h no?
- # [16:19] <@tbsaunde> I'm not sure, but it s the correct answer for AtkRole not being defined
- # [16:19] <@tbsaunde> f course with that fixed you might get other errors
- # [16:19] <@tbsaunde> anyway got to run, bbiab
- # [16:19] * tbsaunde is now known as tbsaunde|afk
- # [16:38] * Quits: mike5w3c (MikeS@moz-E9ABBA62.wireless.csail.mit.edu) (Quit: mike5w3c)
- # [16:42] <@MarcoZ> Phew, the Linux tboxes turned green on my bustage fix. Looks like the test changes now stick.
- # [16:44] <@davidb> good good
- # [16:45] <@davidb> i wish this water meter guy would show up
- # [16:45] * @davidb is at home
- # [16:45] <@davidb> also that was sexist
- # [16:45] <@davidb> guy/gal
- # [16:45] <@davidb> askalski: have you exploded?
- # [16:45] * Joins: ehsan (ehsan@F2D29657.F60B0462.67AC9B1.IP)
- # [16:46] <@davidb> because build errors can do that
- # [16:46] <@askalski> davidb, I did rm -rf mozilla-central and checkout and went for a walk
- # [16:47] <@askalski> davidb, I should install quake or something on my working machine, so I can kill something after each compiler nightmare
- # [16:48] <@askalski> quake licenses should be given to c++ developers as stress reduces by desktop :D
- # [16:48] <@askalski> or included to mozilla-build :D
- # [16:49] * Joins: hub (hub@moz-E2FCA694.figuiere.net)
- # [16:49] * ChanServ sets mode: +o hub
- # [16:51] <Mark_Capella> prepares to re-base a 30 file bitrotted patch :(
- # [16:51] <@davidb> askalski: :)
- # [16:52] <@askalski> davidb, yeah. I wanted to finish this patch monday...
- # [16:52] <@davidb> Mark_Capella: ouch
- # [16:52] <Mark_Capella> my fault - i ran another large patch in front
- # [16:52] <@askalski> next life I become woodcutter.
- # [16:52] <@askalski> I will not have to go to gym. Saves time.
- # [16:58] * Joins: mike5w3c (MikeS@moz-E9ABBA62.wireless.csail.mit.edu)
- # [17:01] * Quits: logbot (logbot@moz-622AFC27.glob.com.au) (Ping timeout)
- # [17:03] <@hub> askalski: come like in Quebec. When you have to shovel your driveway in the winter, it is good :-D
- # [17:03] <@hub> s/like/live/
- # [17:04] <@askalski> hub :)
- # [17:04] <Mark_Capella> here in syracuse we got 4inches tother day ... yay for snowblowers
- # [17:05] <@davidb> i've had snow piles taller than me on either side of my driveway… but not for years
- # [17:05] <@askalski> hub, can you tell me how to fight .rej files in hg?
- # [17:06] <@davidb> rm
- # [17:06] <@askalski> davidb, right, so what to do if patch does not apply?
- # [17:06] <@MarcoZ> askalski: .rej files are never supposed to be added in hg. They simply show a chunk of a rejected patch or merge attempt.
- # [17:06] * Joins: logbot (logbot@moz-622AFC27.glob.com.au)
- # [17:07] <Mark_Capella> manual fix one by one
- # [17:07] <@MarcoZ> askalski: Merge manually.
- # [17:07] <@davidb> what they said ^
- # [17:07] <@MarcoZ> hub: The test disablings/fixes are in. You can push to inbound anytime, bug 733513. :)
- # [17:07] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=733513 nor, --, ---, hub, NEW, Enable accessibility on Mac
- # [17:08] <@MarcoZ> (and then bug 749160 can be fixed, too).
- # [17:08] <@davidb> hub: by anytime, MarcoZ means NOW!!! He's pacing I bet.
- # [17:08] <@MarcoZ> No I'm not! :P
- # [17:08] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=749160 nor, --, ---, nobody, NEW, Turn on a11y Mochitests for OS X once bug 733513 lands
- # [17:08] <@davidb> heheh
- # [17:08] * Quits: logbot (logbot@moz-622AFC27.glob.com.au) (Ping timeout)
- # [17:11] * Joins: logbot (logbot@moz-622AFC27.glob.com.au)
- # [17:25] <@askalski> davidb, I am getting delays because of these changes. I am rebasing this patch for the second time, and it's over 10 files large already
- # [17:25] <@davidb> I don't have a clear idea of what changes you'll need to make.
- # [17:26] <@davidb> Is it getting ugly?
- # [17:28] <@askalski> davidb, no it's just that I am modifying a lot of files now, because I got several drop-ins in reviews
- # [17:29] <@askalski> davidb, and probability that these files remain unchanged for several days is very low
- # [17:29] <@davidb> godspeed
- # [17:29] <@askalski> davidb, like now Hub have added 3 new roles. Nice, some new features. But it made my patch unapplyable again
- # [17:29] <@davidb> ah yes
- # [17:29] <@askalski> davidb, so I am wasting time
- # [17:29] <@askalski> davidb, we just need to get this landed soon
- # [17:29] <@davidb> right
- # [17:30] <@davidb> askalski: you should be having this chat with your reviewers really.
- # [17:31] <@askalski> davidb, true. I will add it as a comment in todays submission
- # [17:31] <@askalski> davidb, because I can apply the follow up changes later, once it's landed, so I don't have to rebase everything daily
- # [17:32] <@davidb> sounds like a good bug comment
- # [17:33] <@askalski> surkov, I am removing comments from RolesMap.h as you requested. They are in Roles.h anyway
- # [17:33] <@surkov> ok
- # [17:35] <@MarcoZ> askalski: The problem is for landing, you need to do the rebasing anyway, since you can only land patches that apply cleanly against current trunk.
- # [17:35] <@askalski> MarcoZ, I know, and I have no problem with that. It's just I am doing it not for the first time
- # [17:36] * clown_mtg is now known as clown
- # [17:36] <@davidb> you should read Zen and the art of patch rebasing
- # [17:36] <@askalski> MarcoZ, actually, I would die trying if not the fact I am regenerating some stuff with python scripts, but even these requires updating
- # [17:37] <@askalski> davidb, I got wonderful game. it calls "mount and blade". I will conquer some castle and burn some villages. that relaxes :D
- # [17:38] <@askalski> after work of course
- # [17:44] <@davidb> we've all got a little angry god in us
- # [17:45] <@MarcoZ> Right, sometimes you need to take your mind off things and do something utterly different and maybe even stupidly simple to unwind.
- # [17:46] <@MarcoZ> davidb: Does the Toronto office now also have a Wii with Rock Band set up somewhere, like the office in MV does?
- # [17:46] <@davidb> not yet
- # [17:46] <@davidb> we never did that stuff in the old office for some reason
- # [17:46] <@MarcoZ> The old office was probably too small to set up something like a Wii there.
- # [17:47] * @MarcoZ remembers it being very busy and the space very well used by working people.
- # [17:48] <@askalski> where I can find MOZ_NOTREACHED or MOZ_MARK_UNREACHABLE usage? google returns None
- # [17:51] <@davidb> askalski: NS_NOTREACHED
- # [17:51] <@askalski> davidb, examples?
- # [17:51] <@davidb> askalski: http://mxr.mozilla.org/mozilla-central/search?string=NOTREACHED
- # [17:52] <@askalski> davidb, NS_NOTREACHED("Unknown role."); sounds good?
- # [17:53] <@davidb> no idea - haven't looked/thought
- # [17:53] <@askalski> davidb, ok
- # [17:53] <@davidb> sorry juggling ATM
- # [17:56] <@askalski> davidb, no problem
- # [17:59] * Joins: Infinity (nak123@8F6FDEE4.2DF8667E.D61FB583.IP)
- # [18:01] <Infinity> Hi! I am working on Bug 740750. Could someone help me out with it!
- # [18:01] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=740750 nor, --, ---, junky.argonaut, ASSI, Use nsITreeView* instead of nsCOMPtr<nsITreeView> as followup to bug#739524
- # [18:01] <Mark_Capella> >whew< only 4 reject files ... little misses
- # [18:01] <Infinity> The present version of my patch is on http://pastebin.mozilla.org/1599073
- # [18:02] <Infinity> It doesn't build and shows an error which is on http://pastebin.mozilla.org/1599076
- # [18:06] * khuey|away is now known as khuey
- # [18:13] * ctalbert|afk is now known as ctalbert
- # [18:21] <@firebot> junky.argonaut@gmail.com requested feedback from surkov.alexander@ gmail.com for attachment 618682 on bug 740750.
- # [18:21] <@hub> askalski: hg is very bad at rebasing / diff
- # [18:21] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=740750 nor, --, ---, junky.argonaut, ASSI, Use nsITreeView* instead of nsCOMPtr<nsITreeView> as followup to bug#739524
- # [18:21] <@hub> if a line in the context changed, it reject
- # [18:22] <@hub> askalski: my take? using git :-)
- # [18:22] <@askalski> hub, yes, I know, I will learn GIT ASAP, which is next work week
- # [18:22] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [18:22] <@hub> note: I still use hg directly.
- # [18:22] <@davidb> Infinity: hi!
- # [18:22] * @davidb looks at pastebin
- # [18:23] <Infinity> davidb: Hi!
- # [18:23] <@hub> MarcoZ: I'll check the patch in a couple of hours max
- # [18:23] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [18:23] <@davidb> Infinity: first thing i would try is a full rebuild
- # [18:23] <@hub> MarcoZ: but I'll have to run mochitest first as yesterday it still failed with all these patches applied
- # [18:23] * @davidb looks at patch
- # [18:23] <Infinity> davidb: I was doing a build from scratch....I just pasted the erroneous part!
- # [18:23] <@hub> (I might have missed some)
- # [18:24] <@tbsaunde|afk> askalski: davidb you really want MOZ_NOTREACHED from mfbt/Assertions.h since it includes __builtin_unreachable() / __assume__(0)) or whatever the msvc thing is
- # [18:24] * tbsaunde|afk is now known as tbsaunde
- # [18:24] <Infinity> tbsaunde: Could you also checkout and help me out with Bug 740750
- # [18:25] <Infinity> I have posted my failed patch for feedback on bugzilla with you as a reference !
- # [18:25] <@tbsaunde> Infinity: the smae as the pastebin?
- # [18:26] <Mark_Capella> infinity: that bug may have been addressed by the original change # 739524 after all and not needed anymore ... see comment #2
- # [18:26] <@MarcoZ> hub: The patch for bug 746531 had an error in it, which is why they were backed out and I had to reland later again. It may have been that failure that you were seeing.
- # [18:26] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=746531 nor, --, ---, nobody, NEW, Unexpected focus event on testing down key on ml_marmalade in tests_focus_listcontrols.xul
- # [18:26] <Infinity> tbsaunde: Yes :)
- # [18:27] * Quits: margle (margle@moz-15EB76B9.dsl.mweb.co.za) (Quit: Computer has gone to sleep.)
- # [18:28] <@davidb> tbsaunde,askalski aha it has an extra underscore… MOZ_NOT_REACHED
- # [18:28] <Infinity> Mark_Capella: But you said those macros were not needed!
- # [18:28] <@davidb> explains grep fail
- # [18:28] <Mark_Capella> hmmm .. there was some discussion with tbsaunde: maybe two different bugs....
- # [18:28] <@hub> MarcoZ: I'll check again.
- # [18:28] <@hub> brb need to walk the dog first
- # [18:28] <Infinity> Mark_Capella: So what do you suggest I should do about it?
- # [18:30] * Quits: khuey (khuey@moz-B77DEAEB.mozilla.org) (Ping timeout)
- # [18:30] <Mark_Capella> because for the final change we did pass the nsITreeView * .... comment #2 also mentions doing another bug for downcasting thats not this one though
- # [18:31] * Joins: khuey (khuey@moz-B77DEAEB.mozilla.org)
- # [18:32] <Infinity> Mark_Capella: Is there no need to change nsComptr to nsITreeView * then?
- # [18:33] <Mark_Capella> wonders .... reviewing the history
- # [18:33] <Infinity> Only remove those macros which result in extra computation time?
- # [18:35] <Mark_Capella> infinity: id say to double check with tbsaunde or surkov and see if they knwo why we wanted this ... i dont recall
- # [18:35] <@surkov> what's the question?
- # [18:36] <Mark_Capella> surkov: infinity has questions re:bug740750 why? and etc.
- # [18:36] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=740750 nor, --, ---, junky.argonaut, ASSI, Use nsITreeView* instead of nsCOMPtr<nsITreeView> as followup to bug#739524
- # [18:37] <@firebot> surkov.alexander@gmail.com requested review from surkov.alexander@gm ail.com for attachment 618682 on bug 740750.
- # [18:37] <@firebot> surkov.alexander@gmail.com cancelled feedback?(surkov.alexander@ gmail.com) for attachment 618682 on bug 740750.
- # [18:38] <Infinity> surkov: Firstly Hi! :) Could you check out my patch for Bug 740750 and tell me what I have got wrong?
- # [18:38] <@tbsaunde> askalski: btw I understand why inlcuding atk/atk.h in nsAccessibleWrap.h was faling now, returning PRUint32 is dumb, but I think the correct solution esp since that function will go away soon
- # [18:38] <@surkov> Infinity: hi, did you do anything wrong?
- # [18:38] <Infinity> I have posted it for feedback from you and tbsaunde
- # [18:39] <@askalski> tbsaunde, right
- # [18:39] <@surkov> ah build fails
- # [18:39] <Infinity> Yeah. My build fails after I have made those changes
- # [18:39] <@surkov> Infinity: you should provide failure list, in the bug pls
- # [18:39] <@askalski> tbsaunde, surkov, I addressed all comments you made, except this with return type and some with "expand macro here". I will do code cleanup later, just want the macro landed, since rebasing 12 files kills me
- # [18:40] <@askalski> tbsaunde, surkov, OK?
- # [18:40] <Infinity> surkov: I have changed all nsComptr mTreeview to nsITreeView* mTreeView....and removed some macros suggested my Mark_Capella
- # [18:40] <@tbsaunde> ok, rebasing shouldn't be too bad, but I'd expect the patch is probably fine at this point
- # [18:41] <Infinity> surkov: Sorry, I am new to fixing bugs, so what is a failure list and how do I provide it?
- # [18:41] <@surkov> askalski: margin is awful if that's what you get but those expand macro here shouldn't take much time, right?
- # [18:41] <@tbsaunde> askalski: I'm not sure what you mean by expand macro
- # [18:41] <@surkov> Infinity: you said your build fails, so do you see compilation/linker errors? then put them into bug
- # [18:41] <@askalski> surkov, tbsaunde, Alex wants me to remove inlined method and expand the macro in code
- # [18:42] <@surkov> askalski: that was tbsaunde idea :) but those methods are not inlined iirc
- # [18:42] <Infinity> surkov: I have pastebin them on http://pastebin.mozilla.org/1599073
- # [18:42] <@askalski> surkov, tbsaunde, I say that these functions are to be removed anyway, to be replaced by non-argument ones or something, but this is non-doable in ATK I think, and for clarity let's leave them analogous for now
- # [18:42] <@surkov> Infinity: that's the patch? no?
- # [18:42] <@askalski> surkov, tbsaunde, they're static, inlined. there will be no harm
- # [18:43] <@surkov> askalski: it isn't about atk, it's about mac and widnows
- # [18:43] <@surkov> askalski: did you inlined them in new patch?
- # [18:43] <@askalski> surkov, yes
- # [18:43] <Infinity> sorry surkov...its http://pastebin.mozilla.org/1599076
- # [18:44] <@surkov> askalski: so you add role map include into headers?
- # [18:44] <@surkov> and then export RoleMap.h?
- # [18:44] <@askalski> surkov, no?
- # [18:44] <@askalski> surkov, I am fighting compiler brb
- # [18:45] <@surkov> mm, any way, why do you prefer to keep these method and file bugs to remove them?
- # [18:45] <@surkov> you're going to make extra work
- # [18:45] <@askalski> surkov, yes! I am rewriting this patch for the 3rd time
- # [18:45] <@askalski> surkov, that's what I call extra time
- # [18:45] <@askalski> surkov, and I have generated "RoleMap.h" 6 times at least
- # [18:45] <@askalski> surkov, updating script and input files
- # [18:46] <@surkov> askalski: sometimes that happens, but doing later something means only you should do that later, if that requires to rewrite the paths then it requires
- # [18:47] <@surkov> what's the point?
- # [18:47] <@tbsaunde> I guess I'm fine with leaving them and filing follow ups so long as they get done
- # [18:47] <@tbsaunde> but I don't really understand why, I'd think you could fix in the length of time you've been talking about it
- # [18:49] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [18:51] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [18:53] <@surkov> I have the same feeling
- # [18:54] <@davidb> i'm confused
- # [18:54] <@davidb> what is the tl;dr here?
- # [18:54] <@davidb> we want some last changes that are causing build headaches?
- # [18:56] * Quits: @hub (hub@moz-E2FCA694.figuiere.net) (Ping timeout)
- # [18:56] <@askalski> no, it's just that I want to get it landed ASAP and am a bit tired of cosmetic adjustments. I still fight the windows compiler on some basic stuff
- # [18:57] <@davidb> ok so the changes talked about recently are not causing the build pain (?)
- # [18:58] <@askalski> you know, I paused yesterday night, woke up and did rebase
- # [18:58] <@askalski> I am not sure I am even in the yesterday's ending point
- # [18:59] * @davidb hands askalski a coke
- # [19:00] <@davidb> discussions are probably best had when things compile :)
- # [19:00] <Mark_Capella> sympathises ... is rebasing GetName() ... gonn afinish that one yet :P
- # [19:00] <Infinity> surkov: Thanks. Will be waiting for your review. Can't wait to get it fixed :)
- # [19:00] <@surkov> Infinity: please fix that issue and file another patch
- # [19:01] <@surkov> Mark_Capella: cool!
- # [19:01] <Mark_Capella> yah - i let nsApplicationAccessible go in front
- # [19:01] <Mark_Capella> falling back now
- # [19:01] <Infinity> surkov: what issue?
- # [19:01] <@surkov> Infinity: build error
- # [19:02] <Infinity> surkov: The build error is due to the patch
- # [19:02] <@surkov> yes
- # [19:02] <Infinity> surkov: That's where I need your help...do you know what is resulting in it?
- # [19:02] <@askalski> oh, btw, windows really needs mozilla::a11y::
- # [19:02] <@surkov> Infinity: I commented into bug
- # [19:02] <@askalski> so do not ask me to remove it next time
- # [19:02] <@askalski> at least in c++ it needs it
- # [19:03] <Infinity> Oh! sorry...i'll check...wait...hmm..I did check just a minute ago!
- # [19:03] <@surkov> askalski: only headers need mozilla::a11y, in cpp you should add using namespace if it's missed
- # [19:03] <@davidb> surkov: not sure your comment made it
- # [19:03] <@surkov> davidb: you're right mid-air collision
- # [19:04] <@askalski> surkov, so add "using" instead of mozilla::a11y:: ?
- # [19:04] <@surkov> Infinity: done, sorry for confusion
- # [19:04] <@davidb> surkov: http://mozillamemes.tumblr.com/post/20191295877/touch-all-the-bugs-dont-you-like-mid-air
- # [19:04] <@surkov> askalski: if you're in cpp file
- # [19:04] <@askalski> surkov, well, it's already there
- # [19:05] <@askalski> I guess it's switch case that really needs it or something
- # [19:05] <@surkov> davidb: :)
- # [19:05] <Infinity> surkov: No problemo :) ..... looking now !
- # [19:05] <@askalski> no idea. compiles just takes me so much time I change multiple things at once
- # [19:05] <@surkov> hm, interesting
- # [19:06] <@MarcoZ> askalski: My experience with C++ is: Fix the first, and only the first, compile error and rebuild. All the others are usually just the result of that very first one and are not to be taken seriously.
- # [19:06] <@askalski> MarcoZ, true. but I had this file working yesterday
- # [19:07] <@askalski> MarcoZ, and I recall these were only changes I made since rebasing
- # [19:07] <@askalski> anyway, I go for a second lunch, since I rebuild on windows which is 20 mins :D
- # [19:07] <@askalski> cause now I get linker troubles
- # [19:08] <Infinity> surkov: Is that method to downcast it?
- # [19:09] <Infinity> surkov: Should I use it in every file where I have made a change or only in the concerned file in the build
- # [19:09] <@surkov> nope, GetView works for nsCOMPtr stuff, you switched to raw pointer
- # [19:10] <@surkov> use this snippet when you get build error
- # [19:10] <Infinity> Ah!....so that's a problem...
- # [19:10] <Infinity> ok....cool
- # [19:10] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [19:13] <Infinity> surkov: One more thing....should I add the snippet in the very begining ?
- # [19:13] <@surkov> Infinity: you should replace old code on new one
- # [19:14] <Infinity> Okay...will see what to do and ask you if I have further queries :)
- # [19:24] * Quits: aaronlev (aaronlev@moz-654DF715.bstnma.fios.verizon.net) (Connection reset by peer)
- # [19:24] * Joins: aaronlev_ (aaronlev@moz-654DF715.bstnma.fios.verizon.net)
- # [19:24] <@MarcoZ> OK, calling it a night. See you tomorrow!
- # [19:24] <@davidb> ciao!
- # [19:25] <@askalski> surkov, about generating switches in .mm files : can someone else do it? I have no way to test even semantical correctness of these
- # [19:25] * Quits: @MarcoZ (Daily@moz-72247ABE.dip.t-dialin.net) (Quit: A11y on Mac is approaching! YAY!)
- # [19:25] <@surkov> let's ping hub, otherwise I can try to do that tomorrow (please update your patch in bugzilla)
- # [19:26] <@askalski> surkov, sure
- # [19:29] <@tbsaunde> askalski: valid c++ should be valid objective-c++
- # [19:31] * Quits: shorlander-mobile (shorlander@F2D29657.F60B0462.67AC9B1.IP) (Quit: Linkinus - http://linkinus.com)
- # [19:33] * tbsaunde is now known as tbsaunde|afk
- # [19:35] <@askalski> tbsaunde|afk, yes. but c++ compiler will not compile objective-c++ to tell me if it's ok. I do what I can patching, but I cannot test. That's what I am saying.
- # [19:35] * Joins: shorlander-mobile (shorlander@F2D29657.F60B0462.67AC9B1.IP)
- # [19:35] * Joins: hub (hub@21B7B9F2.B87E9213.6E712CE2.IP)
- # [19:35] * ChanServ sets mode: +o hub
- # [19:38] * Quits: @hub (hub@21B7B9F2.B87E9213.6E712CE2.IP) (Ping timeout)
- # [19:41] * Joins: hub (hub@21B7B9F2.B87E9213.6E712CE2.IP)
- # [19:41] * ChanServ sets mode: +o hub
- # [19:42] * Joins: fxa90id (fxa90id@moz-9D9A4D03.neoplus.adsl.tpnet.pl)
- # [19:49] * Quits: @hub (hub@21B7B9F2.B87E9213.6E712CE2.IP) (Ping timeout)
- # [19:51] <@davidb> I'm reminded of Donald Knuth
- # [19:51] <@davidb> "Beware of bugs in the above code; I have only proved it correct, not tried it."
- # [19:52] * Joins: hub (hub@21B7B9F2.B87E9213.6E712CE2.IP)
- # [19:52] * ChanServ sets mode: +o hub
- # [19:52] * Joins: margle (margle@moz-15EB76B9.dsl.mweb.co.za)
- # [19:53] * Joins: hub2 (yaaic@moz-5CAAF405.eng.wind.ca)
- # [19:53] <Mark_Capella> Knuth? Hmmm ... I remember Yourdin ... thats probably before your time
- # [19:54] <@davidb> dunno
- # [19:54] <Mark_Capella> Bible of Structured programming and analysis - circa 1980
- # [19:54] <Mark_Capella> cold war era i think :P
- # [19:55] <@davidb> i might have that
- # [19:55] <Mark_Capella> It was a green hardcover ... shaped my little mind
- # [19:55] <@davidb> hmm don't recall green
- # [19:56] <Mark_Capella> thinks green ...
- # [19:56] <@davidb> Alan Kay… "I invented the term 'Object-Oriented', and I can tell you I did not have C++ in mind."
- # [19:57] <@davidb> http://www.junauza.com/2010/12/top-50-programming-quotes-of-all-time.html
- # [19:57] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [19:58] <Mark_Capella> E.W. Dijkstra !!
- # [19:59] * Quits: @hub (hub@21B7B9F2.B87E9213.6E712CE2.IP) (Ping timeout)
- # [19:59] <Mark_Capella> Thanks god we finally killed GOTO
- # [20:00] <@davidb> the kids don't even know what that is
- # [20:00] <Mark_Capella> heehee
- # [20:03] * Joins: hub (hub@21B7B9F2.B87E9213.6E712CE2.IP)
- # [20:03] * ChanServ sets mode: +o hub
- # [20:04] <hub2> internet is down
- # [20:04] <hub2> thanks to the monopoly
- # [20:04] * Quits: @surkov (surkov@A4C60ACB.84614B10.33A1AC3C.IP) (Quit: surkov)
- # [20:04] <@davidb> hmm?
- # [20:04] <@davidb> oh your local line?
- # [20:04] <hub2> shaw
- # [20:05] <@davidb> :|
- # [20:05] * Quits: @hub (hub@21B7B9F2.B87E9213.6E712CE2.IP) (Ping timeout)
- # [20:06] <hub2> the whole city
- # [20:08] * Quits: margle (margle@moz-15EB76B9.dsl.mweb.co.za) (Quit: Textual IRC Client: http://www.textualapp.com/)
- # [20:10] * Joins: hub (hub@21B7B9F2.B87E9213.6E712CE2.IP)
- # [20:10] * ChanServ sets mode: +o hub
- # [20:12] * Quits: @hub (hub@21B7B9F2.B87E9213.6E712CE2.IP) (Ping timeout)
- # [20:13] * Quits: @jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP) (Ping timeout)
- # [20:18] <@firebot> junky.argonaut@gmail.com cancelled review?(surkov.alexander@gm ail.com) for attachment 618682 on bug 740750.
- # [20:18] <@firebot> junky.argonaut@gmail.com requested review from surkov.alexander@gm ail.com for attachment 618724 on bug 740750.
- # [20:18] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=740750 nor, --, ---, junky.argonaut, ASSI, Use nsITreeView* instead of nsCOMPtr<nsITreeView> as followup to bug#739524
- # [20:19] * Parts: Infinity (nak123@8F6FDEE4.2DF8667E.D61FB583.IP) (Leaving)
- # [20:21] * Joins: hub (hub@21B7B9F2.B87E9213.6E712CE2.IP)
- # [20:21] * ChanServ sets mode: +o hub
- # [20:24] * Quits: hub2 (yaaic@moz-5CAAF405.eng.wind.ca) (Quit: Yaaic - Yet another Android IRC client - http://www.yaaic.org)
- # [20:25] <@firebot> askalski@mozilla.com requested review from surkov.alexander@gm ail.com for attachment 618728 on bug 716644.
- # [20:25] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=716644 nor, --, ---, askalski, NEW, expandoify accessible roles
- # [20:25] <@askalski> davidb, hi, I think I will be finishing for today
- # [20:26] <@askalski> I am very tired of this bug, too much refactoring got in
- # [20:27] <@askalski> bye everyone
- # [20:27] <Mark_Capella> bye askalski
- # [20:27] <@hub> seems to be back
- # [20:34] <@firebot> askalski@mozilla.com cancelled review?(surkov.alexander@gm ail.com) for attachment 618728 on bug 716644.
- # [20:34] <@firebot> askalski@mozilla.com requested review from surkov.alexander@gm ail.com for attachment 618734 on bug 716644.
- # [20:34] * Quits: @askalski (akuda@moz-4C8A107E.pool85-48-91.dynamic.orange.es) (Quit: Wychodzi)
- # [20:34] <fxa90id> :D
- # [20:34] * Quits: shorlander-mobile (shorlander@F2D29657.F60B0462.67AC9B1.IP) (Quit: Linkinus - http://linkinus.com)
- # [20:43] * Quits: fxa90id (fxa90id@moz-9D9A4D03.neoplus.adsl.tpnet.pl) (Quit: Leaving)
- # [20:50] * Joins: shorlander-mobile (shorlander@F2D29657.F60B0462.67AC9B1.IP)
- # [20:59] * Joins: aaronlev (aaronlev@moz-654DF715.bstnma.fios.verizon.net)
- # [20:59] * Quits: aaronlev_ (aaronlev@moz-654DF715.bstnma.fios.verizon.net) (Connection reset by peer)
- # [21:14] <@hub> btw I have to hold on committing the build fix. mochitests-a11y still fail on Mac
- # [21:14] <@davidb> np
- # [21:15] <@hub> also I have to rebase it again...
- # [21:35] <@hub> I never noticed the Beatles references in our mochitests
- # [21:35] <@hub> tangerine trees and marmelade skies
- # [21:37] <Mark_Capella> beep beep beep beep beep yah !!!
- # [21:38] <@davidb> that could be me or surkov
- # [21:38] <@davidb> surkov is a big fan
- # [21:39] <@davidb> explains his Liverpool accent
- # [21:39] <@davidb> j/k
- # [21:39] <Mark_Capella> hee
- # [21:40] <Mark_Capella> i sneak in references to classic pc games
- # [21:40] <Mark_Capella> xyzzy ....
- # [21:42] <@hub> I wouldn't get these
- # [21:42] <@davidb> maze of twisty passages all alike
- # [21:42] <Mark_Capella> Colossal Caves adventure! You're in a twisty maze ...
- # [21:42] <Mark_Capella> B)
- # [21:42] <@hub> BFG
- # [21:43] <@davidb> lol
- # [21:44] * Joins: jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP)
- # [21:44] * ChanServ sets mode: +o jprmc
- # [21:46] <Mark_Capella> hub: watch out for grues and mugwumps
- # [21:50] * Quits: @jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP) (Ping timeout)
- # [21:50] * Joins: jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP)
- # [21:50] * ChanServ sets mode: +o jprmc
- # [22:15] <Mark_Capella> confluence? mana?
- # [22:24] * Joins: drexler (chatzilla@moz-BD26ECCD.hsd1.vt.comcast.net)
- # [22:33] * Joins: jeremy1 (Adium@F2D29657.F60B0462.67AC9B1.IP)
- # [22:33] * Quits: ehsan (ehsan@F2D29657.F60B0462.67AC9B1.IP) (Connection reset by peer)
- # [22:33] * Quits: shorlander-mobile (shorlander@F2D29657.F60B0462.67AC9B1.IP) (Connection reset by peer)
- # [22:33] * Quits: jeremy (Adium@F2D29657.F60B0462.67AC9B1.IP) (Connection reset by peer)
- # [22:33] * Quits: nhirata (nhirata.bu@F2D29657.F60B0462.67AC9B1.IP) (Connection reset by peer)
- # [22:34] * Quits: victorporof (victorporo@F2D29657.F60B0462.67AC9B1.IP) (Ping timeout)
- # [22:34] * Quits: @jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP) (Ping timeout)
- # [22:36] * Joins: ehsan (ehsan@F2D29657.F60B0462.67AC9B1.IP)
- # [22:40] * Quits: jeremy1 (Adium@F2D29657.F60B0462.67AC9B1.IP) (Quit: Leaving.)
- # [22:40] * Joins: nhirata (nhirata.bu@F2D29657.F60B0462.67AC9B1.IP)
- # [22:41] * Joins: jeremy (Adium@F2D29657.F60B0462.67AC9B1.IP)
- # [22:41] * Quits: jeremy (Adium@F2D29657.F60B0462.67AC9B1.IP) (Client exited)
- # [22:45] * Joins: shorlander-mobile (shorlander@F2D29657.F60B0462.67AC9B1.IP)
- # [22:52] * Quits: drexler (chatzilla@moz-BD26ECCD.hsd1.vt.comcast.net) (Ping timeout)
- # [22:56] * Quits: clown (clown@67828CC7.C1A51174.9D42CF23.IP) (Quit: Leaving.)
- # [22:56] * Joins: victorporof (victorporo@F2D29657.F60B0462.67AC9B1.IP)
- # [22:59] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Ping timeout)
- # [23:04] * Quits: nhirata (nhirata.bu@F2D29657.F60B0462.67AC9B1.IP) (Quit: nhirata)
- # [23:07] <@davidb> Mark_Capella: did you get that too?
- # [23:07] <@davidb> ignore it i think
- # [23:08] <Mark_Capella> yah is what i hear
- # [23:08] <@davidb> (i think i auto-deleted it without really reading)
- # [23:08] <Mark_Capella> over in #introduction .... they say IT is lookint @ it
- # [23:10] <@davidb> ok that's a wrap for me
- # [23:10] <@davidb> ttyl
- # [23:10] * Quits: @davidb (davidb@moz-68BF56A6.dsl.bell.ca) (Quit: davidb)
- # [23:13] * Quits: icaaq (Adium@moz-718D9655.cust.bredbandsbolaget.se) (Quit: Leaving.)
- # [23:16] * Joins: satdav (satdav@moz-1ECB932B.cable.virginmedia.com)
- # [23:23] * Joins: jpr_ (jprmc@F2D29657.F60B0462.67AC9B1.IP)
- # [23:23] * Joins: jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP)
- # [23:23] * Quits: jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP) (Quit: Leaving)
- # [23:24] * Quits: mike5w3c (MikeS@moz-E9ABBA62.wireless.csail.mit.edu) (Quit: mike5w3c)
- # [23:25] * Joins: mike5w3c (MikeS@moz-E9ABBA62.wireless.csail.mit.edu)
- # [23:25] * Quits: jpr_ (jprmc@F2D29657.F60B0462.67AC9B1.IP) (Ping timeout)
- # [23:26] * Quits: mike5w3c (MikeS@moz-E9ABBA62.wireless.csail.mit.edu) (Quit: mike5w3c)
- # [23:26] * Joins: jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP)
- # [23:26] * ChanServ sets mode: +o jprmc
- # [23:38] * tbsaunde|afk is now known as tbsaunde
- # [23:39] * Quits: shorlander-mobile (shorlander@F2D29657.F60B0462.67AC9B1.IP) (Quit: Leaving...)
- # [23:40] * Joins: shorlander-mobile (shorlander@F2D29657.F60B0462.67AC9B1.IP)
- # [23:45] * Quits: brambles (brambles@4CBAB088.F3076E90.1822ACA6.IP) (Quit: leaving)
- # [23:46] * Joins: brambles (brambles@4CBAB088.F3076E90.1822ACA6.IP)
- # Session Close: Fri Apr 27 00:00:00 2012
The end :)