/irc-logs / mozilla / #accessibility / 2012-05-01 / end

Options:

  1. # Session Start: Tue May 01 00:00:00 2012
  2. # Session Ident: #accessibility
  3. # [00:05] * Joins: drexler (chatzilla@moz-6F22CAC7.e7jvsoe-gw.cust.sover.net)
  4. # [00:13] * Quits: @jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP) (Ping timeout)
  5. # [00:14] * Quits: drexler (chatzilla@moz-6F22CAC7.e7jvsoe-gw.cust.sover.net) (Ping timeout)
  6. # [00:14] * Joins: drexler (chatzilla@moz-6F22CAC7.e7jvsoe-gw.cust.sover.net)
  7. # [00:15] * Quits: drexler (chatzilla@moz-6F22CAC7.e7jvsoe-gw.cust.sover.net) (Quit: ChatZilla 0.9.88-rdmsoft [XULRunner 1.9.0.17/2009122204])
  8. # [00:23] <@firebot> New Core - Disability Access APIs bug 750528 filed by eitan@monotonous.org.
  9. # [00:23] <@firebot> Bug 750528 was not found.
  10. # [00:24] <@firebot> eitan@monotonous.org changed the Target Milestone on bug 750528 from --- to mozilla15.
  11. # [00:29] * Quits: fxa90id (fxa90id@moz-A9D753D2.neoplus.adsl.tpnet.pl) (Ping timeout)
  12. # [00:43] * Joins: jprmc (jprmc@A21EB03E.3CBDB8AB.DA78B690.IP)
  13. # [00:43] * ChanServ sets mode: +o jprmc
  14. # [00:49] * Joins: satdav (satdav@moz-1ECB932B.cable.virginmedia.com)
  15. # [00:54] * Quits: aaronlev_ (aaronlev@moz-654DF715.bstnma.fios.verizon.net) (Quit: aaronlev_)
  16. # [01:06] * Joins: aaronlev_ (aaronlev@moz-654DF715.bstnma.fios.verizon.net)
  17. # [01:20] * Quits: satdav (satdav@moz-1ECB932B.cable.virginmedia.com) (Connection reset by peer)
  18. # [01:27] * Quits: margle (margle@moz-15EB76B9.dsl.mweb.co.za) (Ping timeout)
  19. # [01:27] * Joins: margle (margle@moz-15EB76B9.dsl.mweb.co.za)
  20. # [01:37] * Quits: aaronlev_ (aaronlev@moz-654DF715.bstnma.fios.verizon.net) (Quit: aaronlev_)
  21. # [01:46] * Quits: @jprmc (jprmc@A21EB03E.3CBDB8AB.DA78B690.IP) (Ping timeout)
  22. # [01:47] * Quits: aaronlev (chatzilla@moz-654DF715.bstnma.fios.verizon.net) (Ping timeout)
  23. # [01:47] * Joins: davidb (davidb@moz-68BF56A6.dsl.bell.ca)
  24. # [01:47] * ChanServ sets mode: +qo davidb davidb
  25. # [01:48] * Quits: @davidb (davidb@moz-68BF56A6.dsl.bell.ca) (Input/output error)
  26. # [01:50] * Quits: nhirata (nhirata.bu@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net) (Quit: nhirata)
  27. # [01:52] * Joins: jprmc (jprmc@346FA63F.3CBDB8AB.DA78B690.IP)
  28. # [01:52] * ChanServ sets mode: +o jprmc
  29. # [01:55] * Quits: @jprmc (jprmc@346FA63F.3CBDB8AB.DA78B690.IP) (Ping timeout)
  30. # [02:00] <@firebot> maxli@maxli.ca requested review from eitan@monotonous.or g for attachment 619765 on bug 750193.
  31. # [02:00] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=750193 nor, --, ---, maxli, NEW, get rid useless DEBUG_A11Y code
  32. # [02:14] * Quits: victorporo (victorporo@5F6B43D3.1C233438.79933D60.IP) (Quit: Linkinus - http://linkinus.com)
  33. # [02:16] * Quits: ehsan (ehsan@F2D29657.F60B0462.67AC9B1.IP) (Input/output error)
  34. # [02:22] * Joins: jprmc (jprmc@moz-7F2FF3EB.cpe.net.cable.rogers.com)
  35. # [02:22] * ChanServ sets mode: +o jprmc
  36. # [02:23] * Quits: @jprmc (jprmc@moz-7F2FF3EB.cpe.net.cable.rogers.com) (Input/output error)
  37. # [02:23] * Joins: jprmc (jprmc@moz-7F2FF3EB.cpe.net.cable.rogers.com)
  38. # [02:23] * ChanServ sets mode: +o jprmc
  39. # [02:28] * Joins: victorporof (victorporo@5F6B43D3.1C233438.79933D60.IP)
  40. # [02:29] * Quits: victorporof (victorporo@5F6B43D3.1C233438.79933D60.IP) (Client exited)
  41. # [02:30] * Joins: victorporof (victorporo@5F6B43D3.1C233438.79933D60.IP)
  42. # [02:39] * Joins: ehsan (ehsan@BEDFFF26.EE049E25.8B035CD7.IP)
  43. # [02:42] * Quits: ehsan (ehsan@BEDFFF26.EE049E25.8B035CD7.IP) (Ping timeout)
  44. # [02:43] * Joins: ehsan (ehsan@BEDFFF26.EE049E25.8B035CD7.IP)
  45. # [02:44] * Joins: ehsan_ (ehsan@BEDFFF26.EE049E25.8B035CD7.IP)
  46. # [02:45] * Quits: ehsan (ehsan@BEDFFF26.EE049E25.8B035CD7.IP) (Ping timeout)
  47. # [02:47] * Quits: ehsan_ (ehsan@BEDFFF26.EE049E25.8B035CD7.IP) (Input/output error)
  48. # [03:04] * Joins: ehsan (ehsan@BEDFFF26.EE049E25.8B035CD7.IP)
  49. # [03:13] * Quits: ehsan (ehsan@BEDFFF26.EE049E25.8B035CD7.IP) (Input/output error)
  50. # [03:29] * ctalbert is now known as ctalbert|afk
  51. # [03:42] <@firebot> maxli@maxli.ca requested review from eitan@monotonous.or g for attachment 619806 on bug 750196.
  52. # [03:42] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=750196 nor, --, ---, maxli, NEW, remove ROLE_SYSTEM_ definitions
  53. # [03:52] * Joins: drexler (chatzilla@moz-BD26ECCD.hsd1.vt.comcast.net)
  54. # [04:16] * Joins: nhirata (nhirata.bu@moz-585D5EFC.hsd1.ca.comcast.net)
  55. # [04:18] * Quits: hub (hub@D459F0F4.D9251953.6E712CE2.IP) (Ping timeout)
  56. # [04:26] * khuey|away is now known as khuey
  57. # [04:31] * Quits: victorporof (victorporo@5F6B43D3.1C233438.79933D60.IP) (Connection reset by peer)
  58. # [04:39] * Quits: @jprmc (jprmc@moz-7F2FF3EB.cpe.net.cable.rogers.com) (Ping timeout)
  59. # [04:49] * Joins: surkov (surkov@C1A6A50A.88321457.33A1AC3C.IP)
  60. # [04:49] * ChanServ sets mode: +o surkov
  61. # [04:58] * Joins: jprmc (jprmc@moz-7F2FF3EB.cpe.net.cable.rogers.com)
  62. # [04:58] * ChanServ sets mode: +o jprmc
  63. # [05:17] <@firebot> surkov.alexander@gmail.com changed the Target Milestone on bug 740747 from --- to mozilla15.
  64. # [05:17] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=740747 nor, --, mozilla15, nobody, ASSI, dexpcom nsAccessible::GetName
  65. # [05:19] <Mark_Capella> surkov: thanks for finishing GetName() !!
  66. # [05:19] <Mark_Capella> i've been wrestling with de-ns-ify nsRootAccessible and can't do two things at once :p
  67. # [05:21] <@surkov> Mark_Capella: yw! thanks to you actually, that was one of most complicated dexpcoming work. yeah, dealing with big patches the same time is tricky, usually I'm trying to avoid this
  68. # [05:22] <Mark_Capella> i guess i need to budget more time for the review process... my bugs arent one-liners anymore and i cant crank them out as fast
  69. # [05:25] <@surkov> Mark_Capella: yeah, sometimes reviews take your time, sometimes they take more time then you spent for initial patch version. Usually I'm trying to choose bugs that don't intersect much. If I'm not working on the set of bugs but in this case I'm in danger of merging
  70. # [05:28] <Mark_Capella> i going to do a status post on the de-ns-ify rootaccessible patch ... its failing during widget/windows modules and the build system has me stuck
  71. # [05:28] <Mark_Capella> not sure how this change caused this ... we just moved base/nsrootaccessible to generic/rootaccessible ... its the fourth one ive done so im confused
  72. # [05:38] <@firebot> markcapella@twcny.rr.com requested feedback from trev.saunders@gma il.com for attachment 619823 on bug 748724.
  73. # [05:39] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=748724 nor, --, ---, markcapella, ASSI, de-ns-ify nsRootAccessible
  74. # [05:49] * Joins: mike5w3c (MikeS@moz-2E518994.hfc.comcastbusiness.net)
  75. # [05:50] <@surkov> Mark_Capella: answered
  76. # [05:51] * khuey is now known as khuey|away
  77. # [05:59] <Mark_Capella> surkov: by inline you mean the "RootAccessible* AsRoot()" declaration in nsaccessible.h? and you think maybe move it to the rootaccessible.h area instead?
  78. # [06:02] <Mark_Capella> nah ... that cant be right
  79. # [06:03] <Mark_Capella> the class can return a pointer to a class of its own type ?
  80. # [06:09] * Joins: ehsan (ehsan@BEDFFF26.EE049E25.8B035CD7.IP)
  81. # [06:11] * Quits: ehsan (ehsan@BEDFFF26.EE049E25.8B035CD7.IP) (Connection reset by peer)
  82. # [06:12] * Joins: ehsan (ehsan@BEDFFF26.EE049E25.8B035CD7.IP)
  83. # [06:12] <@surkov> Mark_Capella: I think you should do namespace mozilla { ns a11y { class RootAccessible; } } in nsAccessNode.h and move out nsRootAccessible nsAccessible::AsRoot() from mozilla::a11y namespace in RootAccessible.h
  84. # [06:13] <@surkov> and in nsAccessibe.h you should do mozilla::a11y::RootAccessible AsRoot() prototype
  85. # [06:19] <Mark_Capella> (got a build running ... trying something) if that fails ill try yours .... nsaccessnode.h change i see what you mean, change to the nsaccessible.h prototype I see
  86. # [06:19] <Mark_Capella> what you mean, change to the RootAccessible.h not sure ... "move out" ? the downcast function ? oh ... after the close of the mozilla namespace bracket / before final .h file #endif
  87. # [06:20] <@surkov> Mark_Capella: yep, downcast function, it's prototyped on nsAccessible which is not in a11y namespace, right? So you shouldn't define it under a11y namespace
  88. # [06:20] <Mark_Capella> yah .... light starts to seep in !
  89. # [06:28] * Quits: ehsan (ehsan@BEDFFF26.EE049E25.8B035CD7.IP) (Input/output error)
  90. # [06:38] * Joins: ehsan_ (ehsan@BEDFFF26.EE049E25.8B035CD7.IP)
  91. # [06:45] <Mark_Capella> drats ... fails ... now nsaccessnode.h doesn't recognize the "type"
  92. # [06:45] <Mark_Capella> wonders ... if i take out all the namespace specific changes i made for this ... would that build?
  93. # [06:45] <Mark_Capella> or is namespacing required?
  94. # [06:47] <@firebot> surkov.alexander@gmail.com granted feedback for attachment 619684 on bug 748601.
  95. # [06:47] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=748601 nor, --, ---, maxli, NEW, nsMaiInterfaceText.cpp should check internal role not atk role
  96. # [07:02] * Joins: hub (hub@moz-E2FCA694.figuiere.net)
  97. # [07:02] * ChanServ sets mode: +o hub
  98. # [07:03] <@tbsaunde> Mark_Capella: it's really hard to say what's wrong from really vauge descriptions like that
  99. # [07:04] * ctalbert|afk is now known as ctalbert
  100. # [07:04] <@firebot> surkov.alexander@gmail.com cancelled review?(surkov.alexander@gm ail.com) for attachment 619692 on bug 747272.
  101. # [07:04] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=747272 nor, --, ---, nobody, NEW, [AccessFu] Filter out whitespace text leaves in navigation
  102. # [07:04] <Mark_Capella> yah .... i know .... been messing with this for like 9 hours now ...
  103. # [07:04] <@surkov> Mark_Capella: can you upload the patch please?
  104. # [07:06] <Mark_Capella> surkov: the original is there already, do you want the latest one with the changes you suggested?
  105. # [07:06] <@surkov> Mark_Capella: yeah if you have build problems (and please point errors)
  106. # [07:09] <Mark_Capella> k - gimme a few minutes ... hate to go through all this .... especially if i find out i did something stupid
  107. # [07:17] <@firebot> markcapella@twcny.rr.com cancelled feedback?(trev.saunders@gma il.com) for attachment 619823 on bug 748724.
  108. # [07:17] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=748724 nor, --, ---, markcapella, ASSI, de-ns-ify nsRootAccessible
  109. # [07:22] * Quits: ehsan_ (ehsan@BEDFFF26.EE049E25.8B035CD7.IP) (Input/output error)
  110. # [07:23] <Mark_Capella> FocusManager.cpp has a pre-existing function RootAccessible() that matches our de-ns-ify class ...
  111. # [07:23] <Mark_Capella> wonders if that would matter overall
  112. # [07:23] <@surkov> Mark_Capella: commented
  113. # [07:25] <Mark_Capella> thank you .... repairing and rebuilding ....
  114. # [07:25] <@surkov> Mark_Capella: you shouldn't have name collisions but if you have then pointing namespace explicitly should help
  115. # [07:26] <Mark_Capella> k .... then i got truly desperate ... tried to remember when order of includes makes a difference ...
  116. # [07:27] <Mark_Capella> since I alphabetized them for ya'll
  117. # [07:31] <Mark_Capella> one day someone will explain to me why namespaces are a good thing ... probably just that my 'C++' hasn't
  118. # [07:31] <Mark_Capella> caught up to my 'C' yet
  119. # [07:53] * Quits: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com) (Client exited)
  120. # [08:09] <@firebot> New Core - Disability Access APIs bug 750612 filed by marco.zehe@googlemail.com.
  121. # [08:09] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=750612 maj, --, ---, nobody, NEW, [Mac] Too much is exposed to VoiceOver that is actually not currently visible/interactable
  122. # [08:16] * Quits: drexler (chatzilla@moz-BD26ECCD.hsd1.vt.comcast.net) (Quit: ChatZilla 0.9.88-rdmsoft [XULRunner 1.9.0.17/2009122204])
  123. # [08:33] * Quits: @hub (hub@moz-E2FCA694.figuiere.net) (Ping timeout)
  124. # [08:37] * Joins: aaronlev (aaronlev@moz-654DF715.bstnma.fios.verizon.net)
  125. # [08:49] * Quits: brambles (brambles@4CBAB088.F3076E90.1822ACA6.IP) (Ping timeout)
  126. # [08:49] * Joins: brambles (brambles@4CBAB088.F3076E90.1822ACA6.IP)
  127. # [08:54] * Quits: aaronlev (aaronlev@moz-654DF715.bstnma.fios.verizon.net) (Quit: aaronlev)
  128. # [08:55] <@firebot> trev.saunders@gmail.com granted review for attachment 619680 on bug 749812.
  129. # [08:55] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=749812 nor, --, ---, nobody, NEW, [AccessFu] Display text editing changes
  130. # [09:02] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
  131. # [09:08] * Quits: mike5w3c (MikeS@moz-2E518994.hfc.comcastbusiness.net) (Quit: mike5w3c)
  132. # [09:15] <@tbsaunde> surkov: hi
  133. # [09:16] <@surkov> hi, tbsaunde
  134. # [09:19] <@tbsaunde> surkov: anything interesting up?
  135. # [09:19] <@surkov> it doesn't seem so
  136. # [09:57] * Joins: victorporof (victorporo@5F6B43D3.1C233438.79933D60.IP)
  137. # [09:58] * Quits: victorporof (victorporo@5F6B43D3.1C233438.79933D60.IP) (Quit: Linkinus - http://linkinus.com)
  138. # [11:11] <@tbsaunde> surkov: thoughts on moving all the wrapper methods for nsIAccessible stuff from nsAccessible.cpp to a new xpcAccessible.cpp?
  139. # [11:12] <@tbsaunde> and maybe the same for nsIAccessibleHyperlink since all of its methods are wrappers now
  140. # [11:13] <@tbsaunde> we'd still have to sort out class org stuff, but it would get xpcom stuff out of nsAccessible.cpp so easier to see what is left to dexpcom and less boiler plate to skip past
  141. # [11:13] <@surkov> tbsaunde: that's what we should do if you think to inherit xpcAccessible from nsAccessible
  142. # [11:14] <@surkov> what about memory?
  143. # [11:17] <@tbsaunde> surkov: I wasn't planning to change what class anything is in, so I don't see how it could effect memory
  144. # [11:18] <@tbsaunde> although we might want to do that in the future
  145. # [11:20] <@surkov> ok
  146. # [11:23] <@tbsaunde> surkov: btw thoughts on what you want to rename nsMaiInterfaceFoo to?
  147. # [11:24] <@surkov> tbsaunde: perhaps maiFooAccessible?
  148. # [11:25] <@surkov> though accessible is not right term here
  149. # [11:26] <@surkov> or perhaps atk prefix instead mai
  150. # [11:26] <@surkov> what do you think?
  151. # [11:26] <@firebot> markcapella@twcny.rr.com requested feedback from trev.saunders@gma il.com for attachment 619870 on bug 748724.
  152. # [11:27] <@tbsaunde> surkov: how about just TextInterface.cpp or AtkTextInterface.cp
  153. # [11:28] <@surkov> tbsaunde: maybe prefixed 'atk' (lowercase)? like we do for ia2?
  154. # [11:29] <@surkov> like atkTextInterface
  155. # [11:30] <@tbsaunde> surkov: ok, sounds good
  156. # [11:38] <@tbsaunde> surkov: for bug 750025 are you ok with maintaining the current state where we won't create a ISimpleDOMNode for a non accessible document or text node?
  157. # [11:38] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=750025 nor, --, ---, trev.saunders, NEW, clean up nsAccessNodeWrap::MakeAccessNode()
  158. # [11:38] <@tbsaunde> and return null instead
  159. # [11:39] <@surkov> tbsaunde: we create for text node right now
  160. # [11:39] <@surkov> I'm up to preserve the state
  161. # [11:41] <@tbsaunde> surkov: what about getting rid of the call to Init() on the new access node since we know that has no effect, so that we can move Init() to only be on accessibles
  162. # [11:42] <@surkov> maybe that should be a part of moving Init() to nsAccessible?
  163. # [11:43] <@tbsaunde> it doesn't matter much to me either way
  164. # [11:43] <@tbsaunde> just figured I was there and I'm sure it has no effect
  165. # [11:45] <@firebot> trev.saunders@gmail.com requested review from surkov.alexander@gm ail.com for attachment 619877 on bug 750025.
  166. # [12:02] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
  167. # [12:14] * Quits: a-865 (fmcz@moz-A5D13CA.cable.mindspring.com) (Quit: ChatZilla 0.9.88.2 [SeaMonkey 2.9/20120422224137])
  168. # [12:23] <@firebot> surkov.alexander@gmail.com requested review from trev.saunders@gmail .com for attachment 619884 on bug 746084.
  169. # [12:23] <@firebot> surkov.alexander@gmail.com changed the Status on bug 746084 from NEW to ASSIGNED.
  170. # [12:23] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=746084 nor, --, ---, surkov.alexander, ASSI, provide extended logging for a11y module
  171. # [12:30] * Joins: icaaq (Adium@moz-718D9655.cust.bredbandsbolaget.se)
  172. # [12:31] <@tbsaunde> surkov: so, by text nodes you meant things that are nsIContents but not dom::Elements?
  173. # [12:31] <@surkov> tbsaunde: yes
  174. # [12:32] <@surkov> but actually that's consequence
  175. # [12:32] <@surkov> :)
  176. # [12:37] <@tbsaunde> surkov: consequence of what?
  177. # [12:40] * Quits: margle (margle@moz-15EB76B9.dsl.mweb.co.za) (Quit: Computer has gone to sleep.)
  178. # [12:40] <@tbsaunde> surkov: also, while I'm curious what lexem etc mean, haven't you heard of strtok / strcmp?
  179. # [12:43] * Joins: a-865 (fmcz@moz-A5D13CA.cable.mindspring.com)
  180. # [12:55] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
  181. # [12:55] * Joins: margle (margle@moz-15EB76B9.dsl.mweb.co.za)
  182. # [12:57] * Quits: a-865 (fmcz@moz-A5D13CA.cable.mindspring.com) (Quit: ChatZilla 0.9.88.2 [SeaMonkey 2.9/20120422224137])
  183. # [13:01] <@tbsaunde> surkov: ?
  184. # [13:07] * Joins: a-865 (fmcz@moz-A5D13CA.cable.mindspring.com)
  185. # [13:14] * khuey|away is now known as khuey
  186. # [13:34] * khuey is now known as khuey|away
  187. # [13:34] * khuey|away is now known as khuey
  188. # [13:36] <@surkov> tbsaunde: I used lexem for value in "value;value;value" string
  189. # [13:36] <@surkov> tbsaunde: I don't recall when I used them :)
  190. # [13:37] <@surkov> tbsaunde: ok, I'll change it to strtok
  191. # [13:38] * Quits: @jprmc (jprmc@moz-7F2FF3EB.cpe.net.cable.rogers.com) (Ping timeout)
  192. # [13:40] <@surkov> tbsaunde: so you know who strtok is implemented, where it holds last index?
  193. # [13:40] <@tbsaunde> surkov: so, do we have a way to convert a nsINode to a nsIContent such that it works for text nodes?
  194. # [13:41] <@surkov> perhaps simile static_cast<> if NodeOfType is correct
  195. # [13:41] <@tbsaunde> surkov: ok
  196. # [13:42] <@tbsaunde> surkov: static variable I'd assume
  197. # [13:42] <@tbsaunde> note if someone else can call strtok between your calls to it on the same string you should use something else like strtok_r, but that isn't the case for us
  198. # [13:49] <@surkov> tbsaunde: strtok takes not const pointer, ideas?
  199. # [13:50] <@surkov> is it supposed to change the string?
  200. # [13:52] <@tbsaunde> surkov: yes, it replaces the char you search for by '\0'
  201. # [13:52] <@surkov> oh
  202. # [13:52] <@surkov> tbsaunde: are there alternatives?
  203. # [13:52] <@surkov> basically I need a function I will feed a pointer and that returns a pointer to needed character
  204. # [13:53] <@tbsaunde> surkov: there's a couple sort of similar functions, you could look at string.h
  205. # [13:53] <@surkov> ok
  206. # [13:55] <@tbsaunde> but I think strtok is actually what you want here so you can do while (token = strtok(aModes, ",")) { if (strcmp(token, "mymode")) sModes |= myMode; if (!strcmp(token, "otherMode")) sModes |= otherMode; }
  207. # [13:57] <@surkov> it's nice but I can't change strings
  208. # [13:57] <@surkov> and don't want to copy them
  209. # [14:00] <@tbsaunde> surkov: why? isn't it an in argument only?
  210. # [14:00] <@surkov> basically yes because get_env returns char* but I'm not sure whether I'm allowed to change it
  211. # [14:01] <@tbsaunde> surkov: oh, yeah, forgot bout getting the env variable
  212. # [14:01] <@tbsaunde> hm
  213. # [14:02] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
  214. # [14:04] <@tbsaunde> maybe use strchr and strncmp?
  215. # [14:04] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
  216. # [14:04] <@tbsaunde> I might just copy the string though, I'm not really sure
  217. # [14:07] * Joins: mike5w3c (MikeS@moz-2E518994.hfc.comcastbusiness.net)
  218. # [14:09] <@tbsaunde> surkov: does if (!node->IsNodeOfType(nsINode::eDOCUMENT)) static_cast<nsIContent*>(node) work?
  219. # [14:09] <@surkov> tbsaunde: I think no, because there's different types
  220. # [14:10] <@surkov> but I'm not sure
  221. # [14:10] <@surkov> so maybe yes :)
  222. # [14:12] <@tbsaunde> yeah, actually I think we want if (node->IsNodeOfType(nsINode::eCONTENT)) static_cast<>(node)
  223. # [14:19] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Ping timeout)
  224. # [14:24] * Quits: icaaq (Adium@moz-718D9655.cust.bredbandsbolaget.se) (Quit: Leaving.)
  225. # [14:30] * Joins: jprmc (jprmc@78763BD4.3CBDB8AB.DA78B690.IP)
  226. # [14:30] * ChanServ sets mode: +o jprmc
  227. # [14:33] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
  228. # [14:38] <@firebot> surkov.alexander@gmail.com cancelled review?(trev.saunders@gmail .com) for attachment 619884 on bug 746084.
  229. # [14:38] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=746084 nor, --, ---, surkov.alexander, ASSI, provide extended logging for a11y module
  230. # [14:48] * Quits: @jprmc (jprmc@78763BD4.3CBDB8AB.DA78B690.IP) (Ping timeout)
  231. # [15:05] * Joins: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com)
  232. # [15:05] * khuey is now known as khuey|away
  233. # [15:10] * Joins: davidb (davidb@F2D29657.F60B0462.67AC9B1.IP)
  234. # [15:10] * ChanServ sets mode: +qo davidb davidb
  235. # [15:11] * Quits: margle (margle@moz-15EB76B9.dsl.mweb.co.za) (Quit: Computer has gone to sleep.)
  236. # [15:14] <@davidb> hi hi hi
  237. # [15:19] * Quits: nhirata (nhirata.bu@moz-585D5EFC.hsd1.ca.comcast.net) (Quit: nhirata)
  238. # [15:39] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Ping timeout)
  239. # [15:40] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
  240. # [15:48] * Joins: ehsan (ehsan@F2D29657.F60B0462.67AC9B1.IP)
  241. # [16:08] * Joins: jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP)
  242. # [16:08] * ChanServ sets mode: +o jprmc
  243. # [16:29] * Quits: @surkov (surkov@C1A6A50A.88321457.33A1AC3C.IP) (Quit: surkov)
  244. # [16:33] * Joins: margle (margle@moz-15EB76B9.dsl.mweb.co.za)
  245. # [16:34] * Quits: margle (margle@moz-15EB76B9.dsl.mweb.co.za) (Quit: Textual IRC Client: http://www.textualapp.com/)
  246. # [16:57] * Quits: mike5w3c (MikeS@moz-2E518994.hfc.comcastbusiness.net) (Quit: mike5w3c)
  247. # [17:14] * Joins: hub (hub@moz-E2FCA694.figuiere.net)
  248. # [17:14] * ChanServ sets mode: +o hub
  249. # [17:27] * Joins: nhirata (nhirata.bu@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net)
  250. # [17:30] * khuey|away is now known as khuey
  251. # [17:31] <@davidb> hmm my backtrace in gdb on mac looks like lies
  252. # [17:31] <@davidb> ph
  253. # [17:31] <@davidb> oh
  254. # [17:32] <@davidb> nevermind
  255. # [17:53] <@davidb> heyo Mark_Capella
  256. # [17:58] <Mark_Capella> yah- just woke ... spent 14 hours hacking a new patch yesterday .... just went for it
  257. # [17:59] <Mark_Capella> firstr eview not too bad ... good ideas
  258. # [17:59] <@davidb> cool
  259. # [17:59] <Mark_Capella> looks like the rooms sleeping too today ?
  260. # [18:02] * Mark_Capella is now known as Mark_Capella|inninout
  261. # [18:02] <@davidb> europe has a holiday
  262. # [18:02] <Mark_Capella|inninout> oh ... though i caught some of that discussion yesterday
  263. # [18:03] * Mark_Capella|inninout is now known as Mark_Capella
  264. # [18:04] <Mark_Capella> ah i guess im up now
  265. # [18:09] <@hub> Happy May day
  266. # [18:09] <@davidb> ditto
  267. # [18:11] <Mark_Capella> May day kind of a forgotten holiday in the us
  268. # [18:13] <@hub> and in Canada
  269. # [18:13] * Joins: drexler (chatzilla@moz-6F22CAC7.e7jvsoe-gw.cust.sover.net)
  270. # [18:14] * davidb is now known as davidb|w3
  271. # [18:15] <Mark_Capella> oh the occupyers are getting goofy today ... sighs .... maybe just go back to bed
  272. # [18:17] * drexler wonders if Mark_Capella ever sleeps...
  273. # [18:18] <@davidb|w3> sleep is a pretty important thing
  274. # [18:18] <Mark_Capella> heh yah - but on a very weird cycle
  275. # [18:19] <@hub> sleep: command not found
  276. # [18:19] <Mark_Capella> looks for a sleep button ... just finds reboot
  277. # [18:25] * Joins: mike5w3c (MikeS@454A1A4F.FF5089F.1771B9DE.IP)
  278. # [18:34] * Joins: aaronlev (aaronlev@moz-654DF715.bstnma.fios.verizon.net)
  279. # [18:35] * Quits: brambles (brambles@4CBAB088.F3076E90.1822ACA6.IP) (Quit: leaving)
  280. # [18:35] * davidb|w3 is now known as davidb
  281. # [18:35] * Joins: brambles (brambles@4CBAB088.F3076E90.1822ACA6.IP)
  282. # [18:41] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
  283. # [18:45] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
  284. # [18:58] * Quits: drexler (chatzilla@moz-6F22CAC7.e7jvsoe-gw.cust.sover.net) (Connection reset by peer)
  285. # [18:59] * Joins: drexler (chatzilla@moz-6F22CAC7.e7jvsoe-gw.cust.sover.net)
  286. # [19:02] * Joins: icaaq (Adium@moz-718D9655.cust.bredbandsbolaget.se)
  287. # [19:21] * Quits: @hub (hub@moz-E2FCA694.figuiere.net) (Ping timeout)
  288. # [19:42] * Joins: hub (hub@1063758.68078EAA.B97E6502.IP)
  289. # [19:42] * ChanServ sets mode: +o hub
  290. # [20:00] <@firebot> eitan@monotonous.org cancelled review?(surkov.alexander@gm ail.com) for attachment 619620 on bug 745986.
  291. # [20:00] <@firebot> eitan@monotonous.org requested review from surkov.alexander@gm ail.com for attachment 619982 on bug 745986.
  292. # [20:00] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=745986 nor, --, ---, nobody, NEW, [AccessFu] Display page loading states
  293. # [20:05] * Quits: nhirata (nhirata.bu@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net) (Quit: nhirata)
  294. # [20:06] * Parts: aaronlev (aaronlev@moz-654DF715.bstnma.fios.verizon.net)
  295. # [20:06] * Joins: nhirata (nhirata.bu@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net)
  296. # [20:09] <@davidb> hub: look right? https://wiki.mozilla.org/Platform/2012-05-01#Accessibility
  297. # [20:10] * Joins: aaronlev (aaronlev@moz-654DF715.bstnma.fios.verizon.net)
  298. # [20:17] <@hub> davidb: it does
  299. # [20:18] <@davidb> ok thanks
  300. # [20:18] <@hub> davidb: except that I'd use the word "may"
  301. # [20:18] <@hub> instead of likely
  302. # [20:18] <@davidb> done
  303. # [20:23] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Ping timeout)
  304. # [20:26] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
  305. # [20:35] <@firebot> pppx@i.com.ua changed the Status on bug 398188 from UNCONFIRMED to RESOLVED.
  306. # [20:35] <@firebot> pppx@i.com.ua set the Resolution field on bug 398188 to INCOMPLETE.
  307. # [20:35] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=398188 min, --, ---, nobody, RESO INCOMPLETE, Can't edit field after switching tabs with Ctrl+Tab (focus issue)
  308. # [21:00] * Quits: drexler (chatzilla@moz-6F22CAC7.e7jvsoe-gw.cust.sover.net) (Ping timeout)
  309. # [21:14] <@firebot> eitan@monotonous.org granted review for attachment 619765 on bug 750193.
  310. # [21:14] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=750193 nor, --, ---, maxli, NEW, get rid useless DEBUG_A11Y code
  311. # [21:15] * khuey is now known as khuey|away
  312. # [21:16] <@firebot> eitan@monotonous.org granted review for attachment 619806 on bug 750196.
  313. # [21:16] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=750196 nor, --, ---, maxli, NEW, remove ROLE_SYSTEM_ definitions
  314. # [21:20] * Joins: nickray (nickray@A06A984.BC260B81.37B1640F.IP)
  315. # [21:20] * Parts: nickray (nickray@A06A984.BC260B81.37B1640F.IP)
  316. # [21:23] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
  317. # [21:25] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
  318. # [21:30] * Quits: aaronlev (aaronlev@moz-654DF715.bstnma.fios.verizon.net) (Quit: aaronlev)
  319. # [21:32] * Quits: mike5w3c (MikeS@454A1A4F.FF5089F.1771B9DE.IP) (Ping timeout)
  320. # [21:38] <@firebot> eitan@monotonous.org requested review from surkov.alexander@gm ail.com for attachment 620022 on bug 747272.
  321. # [21:38] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=747272 nor, --, ---, nobody, NEW, [AccessFu] Filter out whitespace text leaves in navigation
  322. # [21:49] * Joins: drexler (chatzilla@moz-BD26ECCD.hsd1.vt.comcast.net)
  323. # [22:08] <@firebot> New Core - Disability Access APIs bug 750853 filed by landry@openbsd.org.
  324. # [22:08] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=750853 nor, --, ---, nobody, NEW, mozilla/a11y/Role.h:817: error: comma at end of enumerator list
  325. # [22:13] <@firebot> landry@openbsd.org requested review from hub@mozilla.com for attachment 620036 on bug 750853.
  326. # [22:40] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Ping timeout)
  327. # [22:42] * Quits: @davidb (davidb@F2D29657.F60B0462.67AC9B1.IP) (Quit: davidb)
  328. # [22:44] * Joins: mike5w3c (MikeS@454A1A4F.FF5089F.1771B9DE.IP)
  329. # [22:45] * Quits: drexler (chatzilla@moz-BD26ECCD.hsd1.vt.comcast.net) (Quit: ChatZilla 0.9.88-rdmsoft [XULRunner 1.9.0.17/2009122204])
  330. # [22:50] * Quits: icaaq (Adium@moz-718D9655.cust.bredbandsbolaget.se) (Quit: Leaving.)
  331. # [23:01] * Quits: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com) (Ping timeout)
  332. # [23:06] * khuey|away is now known as khuey
  333. # [23:09] <@firebot> hub@mozilla.com granted review for attachment 620036 on bug 750853.
  334. # [23:09] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=750853 nor, --, ---, hub, NEW, mozilla/a11y/Role.h:817: error: comma at end of enumerator list
  335. # [23:19] * khuey is now known as khuey|away
  336. # [23:23] * Joins: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com)
  337. # [23:27] <@firebot> markcapella@twcny.rr.com cancelled feedback?(trev.saunders@gma il.com) for attachment 619870 on bug 748724.
  338. # [23:27] <@firebot> markcapella@twcny.rr.com requested review from surkov.alexander@gm ail.com for attachment 620059 on bug 748724.
  339. # [23:27] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=748724 nor, --, ---, markcapella, ASSI, de-ns-ify nsRootAccessible
  340. # [23:28] * Quits: ehsan (ehsan@F2D29657.F60B0462.67AC9B1.IP) (Input/output error)
  341. # Session Close: Wed May 02 00:00:20 2012

The end :)