/irc-logs / mozilla / #accessibility / 2012-05-11 / end
Options:
- # Session Start: Fri May 11 00:00:00 2012
- # Session Ident: #accessibility
- # [00:05] * catlee is now known as catlee-away
- # [00:07] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [00:12] * Quits: ehsan (ehsan@F2D29657.F60B0462.67AC9B1.IP) (Input/output error)
- # [00:32] * khuey is now known as khuey|away
- # [01:02] * Joins: drexler (chatzilla@moz-BD26ECCD.hsd1.vt.comcast.net)
- # [01:17] <capella|away> hub: still here?
- # [01:17] * capella|away is now known as capella
- # [01:22] * khuey|away is now known as khuey
- # [01:23] <@hub> capella: still
- # [01:23] <capella> oh ... i added a note to the bug you reviewed
- # [01:24] <capella> hub: I notice inline function GetCombobox() in the header file which is pretty much the exact same logic. I'll null check both of them then.
- # [01:24] <@hub> I read the comment
- # [01:26] <capella> ok ... i was going to just check with you on irc ... then decided to document it in the bug
- # [01:44] * khuey is now known as khuey|away
- # [01:44] * khuey|away is now known as khuey
- # [01:50] * Quits: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com) (Client exited)
- # [01:51] <@eeejay> capella, is this your new nick? :)
- # [01:54] <capella> yah: old one was too long ... this matches my bugzilla :capella name
- # [01:56] * Quits: nhirata (nhirata.bu@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net) (Quit: nhirata)
- # [02:02] <@firebot> markcapella@twcny.rr.com requested review from surkov.alexander@gm ail.com for attachment 622974 on bug 751497.
- # [02:02] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=751497 nor, --, ---, markcapella, ASSI, replace nsHTMLSelectOptionAccessible::GetSelectState by nice inline
- # [02:51] * khuey is now known as khuey|away
- # [02:55] * khuey|away is now known as khuey
- # [03:07] * Quits: @hub (hub@moz-6D2CDEFB.panavision.com) (Ping timeout)
- # [03:12] * Joins: davidb (davidb@moz-68BF56A6.dsl.bell.ca)
- # [03:12] * ChanServ sets mode: +qo davidb davidb
- # [03:25] * Quits: @davidb (davidb@moz-68BF56A6.dsl.bell.ca) (Quit: blast off!)
- # [03:30] * Joins: surkov (surkov@C1A6A50A.88321457.33A1AC3C.IP)
- # [03:30] * ChanServ sets mode: +o surkov
- # [03:36] <@firebot> surkov.alexander@gmail.com changed the Target Milestone on bug 750301 from --- to mozilla15.
- # [03:36] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=750301 nor, --, mozilla15, maxli, NEW, add static asserts internal and xpcom accessible roles are the same
- # [03:41] <@firebot> surkov.alexander@gmail.com changed the Target Milestone on bug 750216 from --- to mozilla15.
- # [03:41] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=750216 nor, --, mozilla15, markcapella, ASSI, don't export headers that aren't used outside
- # [03:43] <@firebot> joe@drew.ca changed the Status on bug 712924 from ASSIGNED to RESOLVED.
- # [03:43] <@firebot> joe@drew.ca set the Resolution field on bug 712924 to FIXED.
- # [03:43] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=712924 nor, P2, mozilla14, hub, RESO FIXED, [Mac] li elements inside an ul element are announced as "list box"
- # [03:44] * Joins: hub (hub@moz-E2FCA694.figuiere.net)
- # [03:44] * ChanServ sets mode: +o hub
- # [03:49] <@firebot> joe@drew.ca changed the Status on bug 747227 from NEW to RESOLVED.
- # [03:49] <@firebot> joe@drew.ca set the Resolution field on bug 747227 to FIXED.
- # [03:49] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=747227 nor, --, mozilla15, maxli, RESO FIXED, decomtaminate GetCellIndexAt() on accessible tables
- # [03:49] <@firebot> joe@drew.ca changed the Status on bug 614585 from ASSIGNED to RESOLVED.
- # [03:49] <@firebot> joe@drew.ca set the Resolution field on bug 614585 to FIXED.
- # [03:49] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=614585 nor, --, mozilla15, markcapella, RESO FIXED, mochitest test selection functions for nsIAccessibleText
- # [03:50] <@firebot> joe@drew.ca changed the Status on bug 750295 from ASSIGNED to RESOLVED.
- # [03:50] <@firebot> joe@drew.ca set the Resolution field on bug 750295 to FIXED.
- # [03:50] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=750295 nor, --, mozilla15, markcapella, RESO FIXED, don't cache gStringBundle in nsAccessNode
- # [04:12] <@firebot> surkov.alexander@gmail.com cancelled review?(surkov.alexander@gm ail.com) for attachment 622974 on bug 751497.
- # [04:12] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=751497 nor, --, ---, markcapella, ASSI, replace nsHTMLSelectOptionAccessible::GetSelectState by nice inline
- # [04:29] * Joins: nhirata (nhirata.bu@moz-585D5EFC.hsd1.ca.comcast.net)
- # [04:46] * Joins: mike5w3c_ (MikeS@moz-E827CF07.xgsspn.imtp.tachikawa.spmode.ne.jp)
- # [04:46] * Quits: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp) (Ping timeout)
- # [04:46] * mike5w3c_ is now known as mike5w3c
- # [05:01] * Joins: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com)
- # [05:33] <@firebot> surkov.alexander@gmail.com requested review from trev.saunders@gmail .com for attachment 622756 on bug 745429.
- # [05:33] <@firebot> surkov.alexander@gmail.com granted feedback for attachment 622756 on bug 745429.
- # [05:34] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=745429 nor, --, ---, markcapella, ASSI, don't use QueryInterface() in CAccessibleImage
- # [05:36] <@firebot> surkov.alexander@gmail.com granted review for attachment 623025 on bug 751497.
- # [05:36] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=751497 nor, --, ---, markcapella, ASSI, replace nsHTMLSelectOptionAccessible::GetSelectState by nice inline
- # [05:39] <capella> surkov: ill try to land the bug 751497 after adding a blank line
- # [05:39] <capella> (inbound)
- # [05:40] <@surkov> capella: cool
- # [05:40] <@surkov> if you have any questions please ask
- # [05:46] * Joins: ehsan (ehsan@BEDFFF26.EE049E25.8B035CD7.IP)
- # [05:49] <capella> surkov: question ....
- # [05:49] <capella> remote: added 1 changesets with 2 changes to 2 files (+1 heads)
- # [05:49] <capella> remote: Two heads detected on branch 'default'
- # [05:49] <capella> remote: Only one head per branch is allowed!
- # [05:49] <@surkov> you did pull -u?
- # [05:49] <@surkov> capella: ^
- # [05:50] <capella> yes .... then applied just the one patch
- # [05:50] <@surkov> when you did that you had some patches applied, right?
- # [05:50] <@surkov> are you using mq?
- # [05:50] * Joins: MarcoZ (Daily@moz-B4F01E80.dip.t-dialin.net)
- # [05:50] * ChanServ sets mode: +o MarcoZ
- # [05:50] <@surkov> if yes then qpop -a
- # [05:51] <@surkov> and then hg update
- # [05:51] <capella> then qpush the one patch?
- # [05:52] <capella> followed by hg push -f .....
- # [05:54] <@firebot> surkov.alexander@gmail.com cancelled feedback?(surkov.alexander@ gmail.com) for attachment 622168 on bug 739885.
- # [05:54] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=739885 nor, --, ---, xph9753, ASSI, decomtaminate impl of IsRowSelected() and IsColumnSelected() on accessible tables
- # [05:55] <@surkov> capella: yes then hg qpush
- # [05:55] <@surkov> after that you do hg qrem -r patchname
- # [05:55] <@surkov> e
- # [05:55] <@surkov> then they recommend to do hg out to make sure you are landing correct things
- # [05:55] <@surkov> and then 'hg push'
- # [05:56] <@surkov> don't use hg push -f
- # [05:56] <@surkov> it's not recommended, pushing should be gentle :)
- # [05:57] <@surkov> you can land few patches at once if you are sure they can't have any problems
- # [05:59] <capella> ok, so i did
- # [05:59] <capella> hg qpop -a
- # [05:59] <capella> hg update
- # [05:59] <capella> hg qpush
- # [05:59] <capella> hg push L3in <--- my shortcut to inbound
- # [05:59] <capella> now i get abort: source has mq patches applied
- # [06:06] <@firebot> surkov.alexander@gmail.com denied feedback for attachment 621899 on bug 751493.
- # [06:06] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=751493 nor, --, ---, nobody, NEW, move out the nsHTMLComboboxListAccessible logic from nsHTMLSelectListAccessible::NativeRole
- # [06:07] <@surkov> capella: after you did 'hg qpush' you should do 'hg qrem -r patchanme', then 'hg out' to make sure you land correct things and then 'hg push'
- # [06:09] <capella> little closer... now
- # [06:09] <capella> abort: push creates new remote head 1bd1096b8dea!
- # [06:09] <capella> it wants me to use hg push -f
- # [06:09] <@firebot> surkov.alexander@gmail.com cancelled review?(surkov.alexander@gm ail.com) for attachment 619877 on bug 750025.
- # [06:09] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=750025 nor, --, ---, trev.saunders, NEW, clean up nsAccessNodeWrap::MakeAccessNode()
- # [06:10] <@surkov> capella: it seems somebody pushed before you, so in this case you should do 'hg log -l 1'
- # [06:10] <@surkov> you have something like changeset: 93769:1a00d690aa69
- # [06:10] <@surkov> then you do hg qimp -r 93769 (replace on number you get)
- # [06:10] <@surkov> then hg qpop
- # [06:11] <@surkov> and hg pull -u
- # [06:11] <@surkov> and then usual procedure
- # [06:12] <@surkov> and you never should use hg push -f for repos other than try server builds
- # [06:15] <capella> hang on .... my pulls arent coming from inbound though ... isnt that the problem?
- # [06:18] * Joins: victorporof (victorporo@6FF5A155.DA9DCE7D.79933D60.IP)
- # [06:23] <@firebot> New Core - Disability Access APIs bug 754165 filed by surkov.alexander@gmail.com.
- # [06:23] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=754165 nor, --, ---, nobody, NEW, fire document load events on iframes too
- # [06:23] <capella> my repo is a clone of mozilla-central ...
- # [06:23] <@surkov> capella: sure
- # [06:23] <@surkov> I have two trees
- # [06:24] <@surkov> tbsaunde knows how to land from mc tree to inbound
- # [06:24] <capella> wow ... this is turning into work !
- # [06:57] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [06:59] * Quits: drexler (chatzilla@moz-BD26ECCD.hsd1.vt.comcast.net) (Quit: ChatZilla 0.9.88-rdmsoft [XULRunner 1.9.0.17/2009122204])
- # [07:01] * Quits: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com) (Client exited)
- # [07:07] <@hub> I just run inbound :-)
- # [07:16] <capella> hub: so all your hg push / pulls go to / from inbound?
- # [07:17] <@surkov> capella: I don't see your landing in inbound
- # [07:17] <@surkov> you didn't land yet?
- # [07:17] <capella> i havent yet surkov: wrestling with the rules ...
- # [07:17] <@surkov> ok
- # [07:19] <capella> so maybe i need to do like hub and use one repo ... inbound clone
- # [07:21] <@hub> capella: to me that's the easiest
- # [07:21] <capella> surkov: cause at this point ive got a central repo with patches that I'm trying to push to an inbound tree
- # [07:21] <@hub> it is sometimes risky
- # [07:21] <@hub> as inbound sometime breaks
- # [07:21] <capella> hub: yah - i was wondering about that part next also
- # [07:21] <@surkov> capella: I use have two trees, one for mc (I'm working on) and another one for inbound
- # [07:22] <capella> surkov: how do you migraate from your central to yuor inbound so you can push?
- # [07:23] <@surkov> capella: you can do hg qimp path-to-patch-in-mc-repo
- # [07:23] <@surkov> personally I copy the patch from mc tree in UI file manager to nice place where I can import it from
- # [07:24] <capella> so you juggle two patch queues .... import from central to inbound locally ... then push from there
- # [07:24] <@surkov> yes
- # [07:25] <@surkov> it takes dozen seconds so not big deal I think
- # [07:26] <capella> doing hg qpop -a on both queues ... hg pull -u on both repos ... import mypatch from central queue to inbound queue ...
- # [07:26] <capella> hg qpush the patch ... then so on up to hg push to http://mozilla..... inbound/
- # [07:27] <capella> and to start setting that up i now have to clone inbound as a first step
- # [07:32] <capella> surkov: sound correct? ----^
- # [07:33] <@surkov> sounds complicated
- # [07:33] <@surkov> you should do 'hg pull -u' on inbound repo
- # [07:33] <@surkov> then 'hg qimp patch_path' on inbound repo
- # [07:33] <@surkov> and then land that patch on inbound repo
- # [07:34] <capella> but i do have two repos / clones right?
- # [07:34] <@surkov> technically you should be able just on inbound repo
- # [07:34] <@surkov> if you want to work on mc then yes
- # [07:35] <@surkov> I do that, I'm working on mc and when patch is ready then I import it to inbound and land it there
- # [07:35] <capella> maybe hub: way is better .... just work on inbound
- # [07:35] <@surkov> yeah, you can do that
- # [07:35] * khuey is now known as khuey|away
- # [07:35] <capella> but i still need to clone inbound at this point either way i go
- # [07:35] <@surkov> sure
- # [07:36] <@surkov> it's easy :)
- # [07:36] <@surkov> until you care of internet traffic
- # [07:38] * Quits: nhirata (nhirata.bu@moz-585D5EFC.hsd1.ca.comcast.net) (Quit: nhirata)
- # [07:38] <capella> nah ... i next worry about things like .... will the mozilla-inbound repo go side by side with my mozilla-central repo under my c:\users\master folder ...
- # [07:38] <capella> can i build either one depending where im currently CD'ed into? will MQ's work based on where I'm CD'ed into etc.
- # [07:39] * Quits: @surkov (surkov@C1A6A50A.88321457.33A1AC3C.IP) (Quit: surkov)
- # [07:40] * Quits: victorporof (victorporo@6FF5A155.DA9DCE7D.79933D60.IP) (Ping timeout)
- # [07:44] <capella> surkov: FYI im going to try and set this all up ... will put everything else on hold
- # [07:44] <capella> may take awhile before i push that patch or any others
- # [07:45] <capella> ooops he went away
- # [07:54] * Joins: surkov (surkov@C1A6A50A.88321457.33A1AC3C.IP)
- # [07:54] * ChanServ sets mode: +o surkov
- # [08:18] <capella> >cloning inbound< zzzzzzzzzzzzz............
- # [08:20] * Joins: nhirata (nhirata.bu@moz-585D5EFC.hsd1.ca.comcast.net)
- # [08:37] * Quits: ehsan (ehsan@BEDFFF26.EE049E25.8B035CD7.IP) (Ping timeout)
- # [08:38] * Joins: ehsan (ehsan@BEDFFF26.EE049E25.8B035CD7.IP)
- # [08:46] * Joins: margle (margle@moz-22C89123.dsl.mweb.co.za)
- # [08:47] * Quits: ehsan (ehsan@BEDFFF26.EE049E25.8B035CD7.IP) (Ping timeout)
- # [08:55] * Quits: icaaq (Adium@moz-2401F758.cust.telenor.se) (Connection reset by peer)
- # [08:57] * Joins: icaaq (Adium@moz-2401F758.cust.telenor.se)
- # [09:09] * Quits: reuben (reuben@seta00.com) (Quit: ZNC - http://znc.in)
- # [09:09] * Quits: icaaq (Adium@moz-2401F758.cust.telenor.se) (Connection reset by peer)
- # [09:09] * Quits: @hub (hub@moz-E2FCA694.figuiere.net) (Ping timeout)
- # [09:24] * Joins: icaaq (Adium@714E29CB.13DB46CE.3B93FF6D.IP)
- # [09:29] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Ping timeout)
- # [09:50] * Quits: margle (margle@moz-22C89123.dsl.mweb.co.za) (Quit: Computer has gone to sleep.)
- # [10:02] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [10:08] <capella> surkov: i think i just did my first push to inbound :)
- # [10:08] <@surkov> cool
- # [10:08] <@surkov> capella: you should add a comment into bug and set target milestone
- # [10:10] <capella> hmmmm ... where do i find the link to paste into the comment like you do?
- # [10:16] <@firebot> markcapella@twcny.rr.com changed the Target Milestone on bug 751497 from --- to mozilla15.
- # [10:16] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=751497 nor, --, mozilla15, markcapella, ASSI, replace nsHTMLSelectOptionAccessible::GetSelectState by nice inline
- # [10:17] <@MarcoZ> capella: http://ht.mozilla.org/integration/mozilla-inbound
- # [10:17] <@MarcoZ> capella: In the table, the "diff" link next to your patch is the one you want to paste into the bug.
- # [10:18] <capella> marcoz: Yah ! Just posted it !
- # [10:18] <capella> :)
- # [10:19] <@MarcoZ> Yep this looks good! Congrats on your first push!
- # [10:19] <capella> woo hoo !
- # [10:19] * @MarcoZ feels reminded how he juggled around in the same way 4 years ago when HG was first introduced to Mozilla's infrastructure.
- # [10:20] <capella> wow .... lotsa work .... no wonder surkov was eager to have me do it for myself from now on
- # [10:20] <@surkov> :)
- # [10:20] <@MarcoZ> Yeah, you're a *very* active contributor, and having you manage your patches yourself and land them seems only right!
- # [10:21] <capella> markoz: fair enough :) share the pain
- # [10:21] * @MarcoZ is very impressed with the responsiveness of Fennec. Yes, our APIs are quite fast!
- # [10:22] <@MarcoZ> I just wish we had the same responsiveness on mac, too.
- # [10:25] <@surkov> MarcoZ: unbelievable :)
- # [10:31] <@tbsaunde> fwiw all I do is pull from m-i or whereever into an m-c tree, and then push with push -r tip
- # [10:32] <@tbsaunde> and then curse whoever thought unnamed branches was a good idea
- # [10:39] <@MarcoZ> surkov: You don't have an Android phone yet, correct?
- # [10:40] <@surkov> I have my one, so I can try I think
- # [10:40] <@MarcoZ> surkov: If you're curious... I am really happy with the good start we hit with this!
- # [10:40] <@surkov> MarcoZ: should I download nightly and enable some preferences?
- # [10:42] <@MarcoZ> surkov: All documented here: http://www.marcozehe.de/2012/05/08/first-round-of-accessibility-support-for-android-in-mobile-firefox/
- # [10:42] <@surkov> ok, thx
- # [10:43] * Joins: victorporof (victorporo@88D8B88B.70F4578F.79933D60.IP)
- # [10:44] <@firebot> bmo@edmorley.co.uk changed the Target Milestone on bug 751497 from mozilla15 to ---.
- # [10:44] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=751497 nor, --, ---, markcapella, ASSI, replace nsHTMLSelectOptionAccessible::GetSelectState by nice inline
- # [10:47] <@surkov> capella: usually I practice try server build before pushing into inbound to be on safe side
- # [10:49] <@surkov> capella: I think you should do mParent.get() or Parent();
- # [10:49] <capella> surkov: hmmm ... thought i had tried the TRY, but maybe not on this one
- # [10:50] <capella> why did it work on my local .... wonders
- # [10:50] <@surkov> capella: because you're on Windows I guess
- # [10:50] <@surkov> vc compilers eats that
- # [10:51] <capella> oh .... ok let me regroup ... update the patch ... import to my inbound .... push to try from there
- # [10:58] <capella> surkov: i dont understand your fix suggestion ... isnt GetSelect method ok since its just
- # [10:58] <capella> like the GetCombobox method thats been working all along?
- # [10:59] <@surkov> capella: iirc the problem is you use different types in ?: statement
- # [10:59] <@surkov> one of them is nsRefPtr<nsAccessible> (mParent presumably), other one is nsAccessible* (combobox variable I think)(
- # [10:59] <capella> oh THAT mParent .... for the false condition
- # [11:00] <@surkov> so you should make sure nsAccessible* is used in left and in right parts of : operator
- # [11:00] <@surkov> yep, I think so
- # [11:00] <capella> and thats where the two methods are different .... i see
- # [11:02] <capella> so maybe
- # [11:02] <capella> return combobox && combobox->IsCombobox() ? combobox : Parent();
- # [11:02] * Joins: margle (margle@moz-22C89123.dsl.mweb.co.za)
- # [11:06] <capella> or return combobox && combobox->IsCombobox() ? combobox : mParent.get();
- # [11:07] * Quits: victorporof (victorporo@88D8B88B.70F4578F.79933D60.IP) (Connection reset by peer)
- # [11:28] <@MarcoZ> capella: Happens to all of us. :)
- # [11:29] <capella> i blame windows
- # [11:43] * Joins: victorporof (victorporo@45524559.602BD6C.79933D60.IP)
- # [11:59] <margle> do you guys know how to reset your password on irc.mozilla.org?
- # [12:25] <capella> margle: did you try /msg NickServ help
- # [12:26] <capella> margo: do "/msg nickserv help" or "/msg nickserv sendpass" i think
- # [12:27] <capella> margle: do / msg nickserv help or / msg nickserv sendpass
- # [12:27] <capella> yah thats it
- # [12:29] * Joins: askalski (akuda@moz-4C8A107E.pool85-48-91.dynamic.orange.es)
- # [12:29] * ChanServ sets mode: +o askalski
- # [12:36] <margle> capella: it says permission denied.
- # [12:38] * Joins: icaaq1 (Adium@714E29CB.13DB46CE.3B93FF6D.IP)
- # [12:38] <capella> have you registered your nick already?
- # [12:38] <capella> https://wiki.mozilla.org/IRC#Register_your_nickname
- # [12:39] * Quits: icaaq (Adium@714E29CB.13DB46CE.3B93FF6D.IP) (Ping timeout)
- # [12:39] <@askalski> hi everyone
- # [12:39] <capella> askalski: <- waves at
- # [12:40] <@askalski> hi Mark
- # [12:41] <@tbsaunde> hi
- # [12:41] <margle> capella: yup
- # [12:42] <capella> not sure .... just learned it myself
- # [12:43] <capella> info says to do /msg nickserv sendpass yournick
- # [12:48] * Joins: sgimeno (santiago.g@A922400D.48362F18.BCC03455.IP)
- # [13:04] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [13:05] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [13:07] <@firebot> New Core - Disability Access APIs bug 754230 filed by surkov.alexander@gmail.com.
- # [13:07] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=754230 nor, --, ---, nobody, NEW, IA2::get_states should expose STATE_DEFUNCT if accessible is defunct
- # [13:13] <margle> capella: thanks, I'll try and find an admin
- # [13:13] <capella> ok ... good luck
- # [13:14] <@surkov> capella: don't forget to cancel try server builds when you don't need them :)
- # [13:14] <capella> surkov: "cancel" the one that just succeeded? like delete in now that I know the results?
- # [13:15] <@surkov> capella: no if it's not finished all builds
- # [13:15] <@surkov> if it's still building something
- # [13:16] <capella> surkov: oh.... isnt that TRY finished then? i only asked for linux
- # [13:16] <@surkov> capella: I didn't look, it's just a hint in case if you don't know
- # [13:17] <capella> surkov: oh ! yah! "if the TRY fails .... cancel the rest of it and review the results"
- # [13:17] <@surkov> ok :)
- # [13:18] <capella> i only did one try ... linux only .... it worked .... now i pushed to inbound again
- # [13:19] <@firebot> markcapella@twcny.rr.com changed the Target Milestone on bug 751497 from --- to mozilla15.
- # [13:19] * Quits: icaaq1 (Adium@714E29CB.13DB46CE.3B93FF6D.IP) (Quit: Leaving.)
- # [13:19] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=751497 nor, --, mozilla15, markcapella, ASSI, replace nsHTMLSelectOptionAccessible::GetSelectState by nice inline
- # [13:19] <capella> though i dont have verification email yet from inbound
- # [13:21] <capella> surkov: so does edmorley or others like him monitor inbound ? is that "sherriff"?
- # [13:22] <@surkov> it should be
- # [13:22] <capella> o i c
- # [13:37] * Quits: @jprmc (jprmc@moz-7F2FF3EB.cpe.net.cable.rogers.com) (Ping timeout)
- # [13:38] <@askalski> eeejay, u there?
- # [13:44] * Joins: icaaq (Adium@moz-FA7F85B8.cust.telenor.se)
- # [13:44] * Quits: icaaq (Adium@moz-FA7F85B8.cust.telenor.se) (Connection reset by peer)
- # [13:44] * Joins: icaaq (Adium@moz-FA7F85B8.cust.telenor.se)
- # [14:11] * Joins: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com)
- # [14:15] * Joins: surkov_ (surkov@C1A6A50A.88321457.33A1AC3C.IP)
- # [14:15] * Quits: @surkov (surkov@C1A6A50A.88321457.33A1AC3C.IP) (Connection reset by peer)
- # [14:15] * surkov_ is now known as surkov
- # [14:43] * Quits: icaaq (Adium@moz-FA7F85B8.cust.telenor.se) (Ping timeout)
- # [14:43] * Joins: icaaq (Adium@moz-FA7F85B8.cust.telenor.se)
- # [14:47] * Quits: icaaq (Adium@moz-FA7F85B8.cust.telenor.se) (Ping timeout)
- # [14:47] * catlee-away is now known as catlee
- # [14:47] <@tbsaunde> surkov: so, do you think State() should be checking if the accessible is defunct, or should its caller?
- # [14:47] * Joins: icaaq (Adium@moz-FA7F85B8.cust.telenor.se)
- # [14:48] * Quits: surkov (surkov@C1A6A50A.88321457.33A1AC3C.IP) (Ping timeout)
- # [15:04] * Joins: icaaq1 (Adium@moz-98AF81F2.cust.telenor.se)
- # [15:04] * Quits: icaaq (Adium@moz-FA7F85B8.cust.telenor.se) (Ping timeout)
- # [15:19] * Quits: icaaq1 (Adium@moz-98AF81F2.cust.telenor.se) (Ping timeout)
- # [15:20] * Quits: victorporof (victorporo@45524559.602BD6C.79933D60.IP) (Quit: Linkinus - http://linkinus.com)
- # [15:21] * Joins: davidb (davidb@F2D29657.F60B0462.67AC9B1.IP)
- # [15:21] * ChanServ sets mode: +qo davidb davidb
- # [15:21] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [15:21] <@davidb> hi!
- # [15:22] * Joins: icaaq (Adium@moz-98AF81F2.cust.telenor.se)
- # [15:23] * Joins: clown (clown@67828CC7.C1A51174.9D42CF23.IP)
- # [15:24] <capella> waves
- # [15:30] * Joins: surkov (surkov@C1A6A50A.88321457.33A1AC3C.IP)
- # [15:30] * ChanServ sets mode: +o surkov
- # [15:31] <@surkov> tbsaunde: if accessible is defunct then State() should return defunct state
- # [15:37] * khuey|away is now known as khuey
- # [15:39] <@tbsaunde> surkov: I guess that makes sense
- # [15:39] <@surkov> tbsaunde: we did that before
- # [15:39] <@tbsaunde> on other hand people shouldn't hve a defunct accessible, so in ideal world you could never call State() on a defunct one
- # [15:40] <@tbsaunde> surkov: yeah, and every now and again I've wondered if that was teh right way
- # [15:40] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [15:41] <@surkov> that's ideally but it happens always
- # [15:41] * Quits: sgimeno (santiago.g@A922400D.48362F18.BCC03455.IP) (Quit: KVIrc 4.0.2 Insomnia http://www.kvirc.net/)
- # [15:42] * Joins: ehsan (ehsan@moz-ED3249A4.dmz.releng.scl3.mozilla.com)
- # [15:43] <@tbsaunde> surkov: true
- # [15:43] <@davidb> define defunct
- # [15:43] <@tbsaunde> I guess leaveing as is, and when we start using seperate objects on windows and weak refs or something we can come back to it
- # [15:44] <@tbsaunde> davidb: hwe've decided we don't want it anymore and shut it down
- # [15:44] <@davidb> and why wouldn't people still have a defunct accessible?
- # [15:44] <@davidb> are you saying we shouldn't shut it down?
- # [15:45] <@tbsaunde> davidb: because we killed there ref to it?
- # [15:46] <@tbsaunde> no, it should be shut down, as well as refs to it going away so it doesn't stay around longer than we need
- # [16:00] * Joins: mike5w3c_ (MikeS@moz-E827CF07.xgsspn.imtp.tachikawa.spmode.ne.jp)
- # [16:00] * Quits: mike5w3c (MikeS@moz-E827CF07.xgsspn.imtp.tachikawa.spmode.ne.jp) (Connection reset by peer)
- # [16:00] * mike5w3c_ is now known as mike5w3c
- # [16:08] * Joins: jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP)
- # [16:08] * ChanServ sets mode: +o jprmc
- # [16:08] * Quits: icaaq (Adium@moz-98AF81F2.cust.telenor.se) (Connection reset by peer)
- # [16:25] * Joins: icaaq (Adium@moz-98AF81F2.cust.telenor.se)
- # [16:30] * Quits: ehsan (ehsan@moz-ED3249A4.dmz.releng.scl3.mozilla.com) (Input/output error)
- # [16:35] * @MarcoZ waves.
- # [16:38] <@MarcoZ> Oh noes, JAWS wants an update. Will be rebooting in a few seconds.
- # [16:39] * Quits: @MarcoZ (Daily@moz-B4F01E80.dip.t-dialin.net) (Quit: Quitting for a Windows reboot.)
- # [16:40] * Quits: mike5w3c (MikeS@moz-E827CF07.xgsspn.imtp.tachikawa.spmode.ne.jp) (Quit: mike5w3c)
- # [16:48] * Joins: mike5w3c (MikeS@moz-7A86FF97.xgsspn.imtp.tachikawa.spmode.ne.jp)
- # [16:53] * Quits: icaaq (Adium@moz-98AF81F2.cust.telenor.se) (Ping timeout)
- # [17:00] * Joins: MarcoZ (Daily@moz-B4F01E80.dip.t-dialin.net)
- # [17:00] * ChanServ sets mode: +o MarcoZ
- # [17:03] * Joins: ehsan (ehsan@F2D29657.F60B0462.67AC9B1.IP)
- # [17:07] * Joins: victorporof (victorporo@45524559.602BD6C.79933D60.IP)
- # [17:09] * Joins: icaaq (Adium@moz-FEE5C3A4.cust.telenor.se)
- # [17:12] * Joins: hub (hub@moz-E2FCA694.figuiere.net)
- # [17:12] * ChanServ sets mode: +o hub
- # [17:15] * Quits: ehsan (ehsan@F2D29657.F60B0462.67AC9B1.IP) (Input/output error)
- # [17:17] <@MarcoZ> Gosh I almost forgot how slow the JAWS installs and updates are! This is just soooo painfully slow!
- # [17:18] <@MarcoZ> davidb: Hey, would you mind looking at statistics for me briefly? I'd just like to know what our screen reader usage numbers currently are. Haven't looked for a while I think.
- # [17:26] * Joins: ehsan (ehsan@F2D29657.F60B0462.67AC9B1.IP)
- # [17:36] * Quits: icaaq (Adium@moz-FEE5C3A4.cust.telenor.se) (Connection reset by peer)
- # [17:38] <@davidb> MarcoZ: sure!
- # [17:39] <@davidb> i suspect things might be mucked up
- # [17:39] * @davidb looks
- # [17:39] <@davidb> we have this weird period of multiple different implementations of telemetry
- # [17:40] <@davidb> hmmm it appears i need to login
- # [17:49] * Joins: jorendorff (jorendorff@moz-91590D94.hsd1.tn.comcast.net)
- # [17:50] <jorendorff> hi. i'm writing a screencast about something totally unrelated to accessibility, but in it I'll have occasion to say about 3 sentences about ARIA to a technical audience (mostly Firefox hackers I imagine). What should I say?
- # [17:51] <@askalski> surkov, hi, got a minute?
- # [17:52] <@davidb> jorendorff: hi!
- # [17:52] <@davidb> jorendorff: hmmm, what is the context?
- # [17:52] <jorendorff> The screencast is about the Debugger object
- # [17:52] <jorendorff> I'll use the Debugger object to inspect the JS code running in various web pages selected at random-- but
- # [17:52] <@davidb> cool this is a good opp
- # [17:53] <jorendorff> coincidentally, one of those is mozilla.org which happens to be doing some aria-related JS stuff
- # [17:53] <@davidb> yep :)
- # [17:53] <@davidb> MarcoZ: ^
- # [17:54] <@davidb> I'd say something like "and here are some ARIA attributes, describing what is seen visually"
- # [17:54] <@davidb> depending on context you can say it is good for people who are blind, as well as search engines blah blah
- # [17:54] <@davidb> but really depends on the flow
- # [17:55] <@davidb> BTW jorendorff I saw you recent screen cast :) good stuff
- # [17:55] <@davidb> your
- # [17:55] <jorendorff> oh thanks!
- # [17:57] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [17:57] <@davidb> jorendorff: BTW Mozilla helped pioneer ARIA (standards and implementation)
- # [17:58] <@davidb> but we aren't to blame for the final MESS
- # [17:58] <jorendorff> :)
- # [17:58] <@davidb> heheh
- # [17:58] * catlee is now known as catlee-lunch
- # [17:58] <@davidb> catlee-lunch: oh it is ready?
- # [17:58] <jorendorff> thank you
- # [17:59] <@davidb> np
- # [18:00] * Joins: icaaq (Adium@moz-7AD0B9CB.cust.bredbandsbolaget.se)
- # [18:01] * khuey is now known as khuey|away
- # [18:03] <@surkov> askalski: yep
- # [18:04] <@askalski> surkov, is Nightly registered to OLE database, and if so, what is it's GUID?
- # [18:04] <@askalski> surkov, hacking with comtypes now
- # [18:04] <@davidb> askalski: might be a better question for eeejay
- # [18:04] <@surkov> GUID of nightly? dunno
- # [18:05] <@davidb> (oh sorry you question is not about comtypes really)
- # [18:05] <@askalski> davidb, yeah, I am just hacking around
- # [18:09] * Quits: jorendorff (jorendorff@moz-91590D94.hsd1.tn.comcast.net) (Quit: Eaten by grue.)
- # [18:11] * Joins: drexler (chatzilla@moz-6F22CAC7.e7jvsoe-gw.cust.sover.net)
- # [18:11] <@tbsaunde> askalski: why not just go diving in nvda?
- # [18:11] <@askalski> tbsaunde, because I don't know what's nvda
- # [18:11] <@askalski> tbsaunde, tell me :)
- # [18:12] <@tbsaunde> askalski: screen reader
- # [18:13] * Quits: clown (clown@67828CC7.C1A51174.9D42CF23.IP) (Ping timeout)
- # [18:13] * Joins: clown (clown@5C0F34C7.A6295926.9D42CF23.IP)
- # [18:13] * Quits: margle (margle@moz-22C89123.dsl.mweb.co.za) (Quit: Computer has gone to sleep.)
- # [18:17] * clown is now known as clown_mtg
- # [18:22] <@tbsaunde> askalski: nvda-project.org
- # [18:23] <@askalski> tbsaunde, I need to capture a windows 32 instance of firefox via comtypes
- # [18:26] <@MarcoZ> askalski: Isn't that to find in msaa/nsAccessNodeWrap.cpp or .h somewhere?
- # [18:26] <@MarcoZ> davidb: Sorry was on the phone when you pinged me regarding jorendorf's screen cast. But what you said was perfect. :)
- # [18:26] <@askalski> MarcoZ, I did grep -lr and got something, but I don't know where to put "-"
- # [18:26] <@tbsaunde> askalski: sure, and presumably a screen reader would have cod e to do this that you could read
- # [18:26] <@MarcoZ> davidb: Nevermind the Screen Reader statistics, then. I was just being curious.
- # [18:26] <@askalski> tbsaunde, right
- # [18:27] <@MarcoZ> askalski: Yes, the NVDA vbuf gecko backend should have all the relevant stuff in there, but I think *we* need to have it too somewhere. I just don't know where currently.
- # [18:30] <@tbsaunde> MarcoZ: sure, and I really suspect nvda has less code to look through than all of gecko
- # [18:30] * @MarcoZ nods.
- # [18:30] <@MarcoZ> OK, but I'm off for the weekend now. See you all on Monday!
- # [18:30] <@tbsaunde> askalski: I sort of suspect what you want to do is get a hwnd for firefox somehow
- # [18:31] <@tbsaunde> and send it wm_getobject
- # [18:31] <@askalski> tbsaunde, I can get hwnd of firefox from mozprocess I run
- # [18:31] <@askalski> no problem with that
- # [18:31] <@askalski> I guess
- # [18:31] * Quits: @MarcoZ (Daily@moz-B4F01E80.dip.t-dialin.net) (Quit: Weekend!)
- # [18:32] <@askalski> tbsaunde, so it's possible to get Accessible from HWND?
- # [18:33] <@tbsaunde> askalski: yes, look at msdn ofr wm_getobject
- # [18:36] * khuey|away is now known as khuey
- # [18:43] * Joins: tbsaunde_ (tbsaunde@moz-EF151DA0.ghc.andrew.cmu.edu)
- # [18:47] * Parts: @tbsaunde (tsaunders@moz-B77DEAEB.mozilla.org)
- # [18:48] * tbsaunde_ is now known as tbsaunde
- # [18:51] * ChanServ sets mode: +o tbsaunde
- # [18:51] * Quits: icaaq (Adium@moz-7AD0B9CB.cust.bredbandsbolaget.se) (Quit: Leaving.)
- # [18:51] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [18:52] * Quits: @askalski (akuda@moz-4C8A107E.pool85-48-91.dynamic.orange.es) (Ping timeout)
- # [18:55] * Joins: askalski (akuda@moz-4C8A107E.pool85-48-91.dynamic.orange.es)
- # [18:55] * ChanServ sets mode: +o askalski
- # [19:03] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Quit: Leaving.)
- # [19:03] * Joins: icaaq (Adium@moz-7AD0B9CB.cust.bredbandsbolaget.se)
- # [19:04] * Quits: @askalski (akuda@moz-4C8A107E.pool85-48-91.dynamic.orange.es) (Ping timeout)
- # [19:06] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [19:07] * Quits: drexler (chatzilla@moz-6F22CAC7.e7jvsoe-gw.cust.sover.net) (Connection reset by peer)
- # [19:08] * Quits: @hub (hub@moz-E2FCA694.figuiere.net) (Ping timeout)
- # [19:08] * Joins: drexler (chatzilla@moz-6F22CAC7.e7jvsoe-gw.cust.sover.net)
- # [19:08] * Quits: drexler (chatzilla@moz-6F22CAC7.e7jvsoe-gw.cust.sover.net) (Connection reset by peer)
- # [19:09] * Joins: drexler (chatzilla@moz-6F22CAC7.e7jvsoe-gw.cust.sover.net)
- # [19:09] * Quits: clown_mtg (clown@5C0F34C7.A6295926.9D42CF23.IP) (Quit: Leaving.)
- # [19:11] * Joins: clown (clown@5C0F34C7.A6295926.9D42CF23.IP)
- # [19:23] * Joins: hub (hub@moz-6D2CDEFB.panavision.com)
- # [19:23] * ChanServ sets mode: +o hub
- # [19:24] <@eeejay> surkov, hey
- # [19:30] * Joins: askalski (akuda@moz-4C8A107E.pool85-48-91.dynamic.orange.es)
- # [19:30] * ChanServ sets mode: +o askalski
- # [19:40] * catlee-lunch is now known as catlee
- # [19:46] * Quits: @askalski (akuda@moz-4C8A107E.pool85-48-91.dynamic.orange.es) (Ping timeout)
- # [19:49] * Joins: askalski (akuda@moz-4C8A107E.pool85-48-91.dynamic.orange.es)
- # [19:49] * ChanServ sets mode: +o askalski
- # [19:52] * Quits: icaaq (Adium@moz-7AD0B9CB.cust.bredbandsbolaget.se) (Ping timeout)
- # [20:00] * Quits: @askalski (akuda@moz-4C8A107E.pool85-48-91.dynamic.orange.es) (Ping timeout)
- # [20:01] * Joins: askalski (akuda@moz-4C8A107E.pool85-48-91.dynamic.orange.es)
- # [20:01] * ChanServ sets mode: +o askalski
- # [20:02] <@tbsaunde> eeejay: what's up?
- # [20:03] <@eeejay> tbsaunde, could there be a case where a parent is defunct, but the child is not?
- # [20:06] <@davidb> i hope to not outlive my children
- # [20:07] * @davidb <-- helpful
- # [20:07] <@davidb> eeejay: my answer would be possibly… during re-parenting
- # [20:07] <@davidb> but unsure
- # [20:08] <@eeejay> hum
- # [20:08] <@davidb> you have this case?
- # [20:08] <@eeejay> davidb, when we do movenext in the pivot, i am just wondering if it is enough to test if the position is defunct, or do i need to check the root too
- # [20:09] <@davidb> eeejay: what is your motivation for caring about the root?
- # [20:09] * Quits: mike5w3c (MikeS@moz-7A86FF97.xgsspn.imtp.tachikawa.spmode.ne.jp) (Quit: mike5w3c)
- # [20:10] * Quits: clown (clown@5C0F34C7.A6295926.9D42CF23.IP) (Quit: Leaving.)
- # [20:10] <@tbsaunde> eeejay: well, if an accessible is defunct it has no parent
- # [20:11] * Quits: shorlander (shorlander@moz-853043D6.dhcp.insightbb.com) (Ping timeout)
- # [20:11] <@tbsaunde> davidb: we don't currently reparent, thought I know we've talked about doing it
- # [20:11] * Joins: margle (margle@moz-22C89123.dsl.mweb.co.za)
- # [20:11] <@davidb> ok
- # [20:12] * Joins: shorlander_ (shorlander@moz-853043D6.dhcp.insightbb.com)
- # [20:13] * Joins: clown (clown@67828CC7.C1A51174.9D42CF23.IP)
- # [20:16] * Joins: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp)
- # [20:17] * Joins: mike5w3c_ (MikeS@moz-7A86FF97.xgsspn.imtp.tachikawa.spmode.ne.jp)
- # [20:18] * Quits: mike5w3c (MikeS@moz-DAFE1A45.tokyo.ocn.ne.jp) (Ping timeout)
- # [20:18] * mike5w3c_ is now known as mike5w3c
- # [20:23] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Ping timeout)
- # [20:23] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [20:23] <@firebot> New Core - Disability Access APIs bug 754377 filed by scoobidiver@netcourrier.com.
- # [20:23] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=754377 cri, --, ---, nobody, NEW, crash in nsDocAccessible::AttributeChangedImpl
- # [20:30] * Quits: margle (margle@moz-22C89123.dsl.mweb.co.za) (Quit: Textual IRC Client: http://www.textualapp.com/)
- # [20:40] <@eeejay> crasher!
- # [20:46] * Quits: drexler (chatzilla@moz-6F22CAC7.e7jvsoe-gw.cust.sover.net) (Connection reset by peer)
- # [20:46] * Joins: drexler (chatzilla@moz-6F22CAC7.e7jvsoe-gw.cust.sover.net)
- # [20:49] <@davidb> eeejay: i have the fix
- # [20:49] <@eeejay> davidb, that was quick
- # [20:49] <@firebot> mbrubeck@mozilla.com changed the Status on bug 750301 from NEW to RESOLVED.
- # [20:49] <@davidb> trivial
- # [20:49] <@firebot> mbrubeck@mozilla.com set the Resolution field on bug 750301 to FIXED.
- # [20:49] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=750301 nor, --, mozilla15, maxli, RESO FIXED, add static asserts internal and xpcom accessible roles are the same
- # [20:50] <@firebot> mbrubeck@mozilla.com changed the Status on bug 750216 from ASSIGNED to RESOLVED.
- # [20:50] <@firebot> mbrubeck@mozilla.com set the Resolution field on bug 750216 to FIXED.
- # [20:50] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=750216 nor, --, mozilla15, markcapella, RESO FIXED, don't export headers that aren't used outside
- # [20:51] <@firebot> mbrubeck@mozilla.com changed the Status on bug 751497 from ASSIGNED to RESOLVED.
- # [20:51] <@firebot> mbrubeck@mozilla.com set the Resolution field on bug 751497 to FIXED.
- # [20:52] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=751497 nor, --, mozilla15, markcapella, RESO FIXED, replace nsHTMLSelectOptionAccessible::GetSelectState by nice inline
- # [20:52] * khuey is now known as khuey|away
- # [20:52] * khuey|away is now known as khuey
- # [20:53] <@firebot> dbolter@mozilla.com requested review from trev.saunders@gmail .com for attachment 623237 on bug 754377.
- # [20:53] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=754377 cri, --, ---, dbolter, NEW, crash in nsDocAccessible::AttributeChangedImpl
- # [20:53] * Quits: brambles (brambles@4CBAB088.F3076E90.1822ACA6.IP) (Client exited)
- # [20:55] <@davidb> oh surkov is still here
- # [20:55] * Joins: brambles (brambles@4CBAB088.F3076E90.1822ACA6.IP)
- # [20:55] <@davidb> anyone feel free to drive by review ^
- # [20:55] <@davidb> there might be a deeper problem
- # [20:56] <@eeejay> davidb, exactly! which is why i will not touch it
- # [20:56] <@davidb> hahaha
- # [20:56] <@eeejay> it will be interesting to see what kind of generic crashers android will bring with it
- # [20:58] <@davidb> yes
- # [20:58] <@davidb> a11y is usually a stress test
- # [21:04] <@davidb> that is probably an understatement
- # [21:04] <@davidb> a11y is the unholy beast of stress tests
- # [21:04] <@eeejay> heh
- # [21:04] * Joins: jorendorff (jorendorff@moz-91590D94.hsd1.tn.comcast.net)
- # [21:05] * Quits: drexler (chatzilla@moz-6F22CAC7.e7jvsoe-gw.cust.sover.net) (Connection reset by peer)
- # [21:05] * @eeejay wishes surkov was around for a late-night review
- # [21:05] <jorendorff> davidb: i had to cut the ARIA cameo in my screencast. it turned out to be way too long, i had to trim a lot of stuff
- # [21:05] <@davidb> np - thanks for thinking of it
- # [21:05] <jorendorff> thanks though
- # [21:05] <@davidb> anytime
- # [21:06] <@firebot> eitan@monotonous.org cancelled review?(surkov.alexander@gm ail.com) for attachment 622849 on bug 753093.
- # [21:06] <@firebot> eitan@monotonous.org requested review from surkov.alexander@gm ail.com for attachment 623242 on bug 753093.
- # [21:06] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=753093 cri, --, ---, eitan, ASSI, crash in nsAccUtils::HasDefinedARIAToken
- # [21:11] <@tbsaunde> davidb: that seems sort of fine, although we may want to rethink some stuff
- # [21:11] <@davidb> tbsaunde: details?
- # [21:11] <@tbsaunde> like getting the accessible for the content at the beginning of the method would probably make sense
- # [21:11] <@davidb> yes!
- # [21:11] <@davidb> if it is used in each block
- # [21:11] <@davidb> why not
- # [21:12] * @davidb looks
- # [21:12] <@tbsaunde> and checking if its null before the method and in nsAccUtils::GetSelectableContainer() sort of sucks though I'll be shocked if the branch predictor gets it wrong the second time
- # [21:12] <@tbsaunde> well, it isn't yet, but we fire events based on content a lot there atm, and eventually that should go away
- # [21:13] <@tbsaunde> so r=me just noting there is room for improvement
- # [21:14] <@davidb> tbsaunde: yeah makes sense to clean up later
- # [21:14] <@davidb> tbsaunde: can you r+ in the bug or is that tedious?
- # [21:14] <@tbsaunde> I guess
- # [21:15] <@firebot> trev.saunders@gmail.com granted review for attachment 623237 on bug 754377.
- # [21:15] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=754377 cri, --, ---, dbolter, NEW, crash in nsDocAccessible::AttributeChangedImpl
- # [21:16] <@davidb> ta
- # [21:18] * catlee is now known as catlee-away
- # [21:19] <@davidb> eeejay: how much xul does fennec native have?
- # [21:20] <@eeejay> davidb, <window>, <deck> and <browser>s
- # [21:20] <@eeejay> http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.xul
- # [21:20] <@eeejay> if you don't count the binding stuff
- # [21:20] <@davidb> ok thanks
- # [21:22] <@eeejay> davidb, why?
- # [21:22] <@davidb> my bug fix
- # [21:22] <@davidb> trevor had a good
- # [21:22] <@davidb> q
- # [21:23] <@firebot> dbolter@mozilla.com changed the Status on bug 754377 from NEW to RESOLVED.
- # [21:23] <@firebot> dbolter@mozilla.com set the Resolution field on bug 754377 to FIXED.
- # [21:23] <@firebot> dbolter@mozilla.com changed the Target Milestone on bug 754377 from --- to mozilla15.
- # [21:27] * shorlander_ is now known as shorlander
- # [21:29] <@tbsaunde> davidb: what's up with not waiting for it to be merged to mark fixed?
- # [21:29] <@davidb> good pt
- # [21:30] <@davidb> went back to old habits
- # [21:30] <@tbsaunde> and that check seems reasonable even if we don't understand this case since I'd think there are reasonable cases where we have a non accessible node getting selected
- # [21:30] <@davidb> agreed that's why i pulled the trigger
- # [21:31] <@firebot> dbolter@mozilla.com changed the Status on bug 754377 from RESOLVED to REOPENED.
- # [21:31] <@firebot> dbolter@mozilla.com cleared the Resolution 'FIXED' from bug 754377.
- # [21:31] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=754377 cri, --, mozilla15, dbolter, REOP, crash in nsDocAccessible::AttributeChangedImpl
- # [21:31] <@davidb> tbsaunde: an example is role="presentation"
- # [21:31] <@davidb> we can't really guard against that
- # [21:32] <@tbsaunde> davidb: yeah, or svg or mathml as I said
- # [21:33] <@tbsaunde> or I think we sometimes don't create a accessible for <img>
- # [21:33] <@tbsaunde> but I am sort of curious what's happening in this case, although I'm not sure if its worth investigating
- # [21:35] <@davidb> yeah fair
- # [21:36] <@firebot> eitan@monotonous.org cancelled review?(dbolter@mozilla.com ) for attachment 622917 on bug 752127.
- # [21:36] <@firebot> eitan@monotonous.org requested review from dbolter@mozilla.com for attachment 623253 on bug 752127.
- # [21:36] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=752127 nor, --, ---, eitan, ASSI, [AccessFu] Abolish anonymous functions
- # [21:36] <@davidb> eeejay: was it simply renaming for this iteration?
- # [21:37] <@eeejay> davidb, yeah
- # [21:37] <@davidb> ok should be quick then
- # [21:38] * @eeejay is getting ready to head out for a bit.
- # [21:38] <@eeejay> davidb, no rush
- # [21:38] <@davidb> ok
- # [21:41] <@firebot> dbolter@mozilla.com granted review for attachment 623253 on bug 752127.
- # [21:46] * Quits: @jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP) (Ping timeout)
- # [21:47] * Joins: jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP)
- # [21:47] * ChanServ sets mode: +o jprmc
- # [21:52] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [22:07] * Quits: @askalski (akuda@moz-4C8A107E.pool85-48-91.dynamic.orange.es) (Quit: Wychodzi)
- # [22:13] * Quits: mike5w3c (MikeS@moz-7A86FF97.xgsspn.imtp.tachikawa.spmode.ne.jp) (Ping timeout)
- # [22:13] * Joins: mike5w3c (MikeS@moz-CA6195DB.xgsspn.imtp.tachikawa.spmode.ne.jp)
- # [22:16] * Joins: mike5w3c_ (MikeS@moz-6B57789E.xgsspn.imtp.tachikawa.spmode.ne.jp)
- # [22:16] * Quits: mike5w3c (MikeS@moz-CA6195DB.xgsspn.imtp.tachikawa.spmode.ne.jp) (Ping timeout)
- # [22:16] * mike5w3c_ is now known as mike5w3c
- # [22:25] * catlee-away is now known as catlee
- # [22:42] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [22:56] * Quits: clown (clown@67828CC7.C1A51174.9D42CF23.IP) (Quit: Leaving.)
- # [23:00] * Quits: @davidb (davidb@F2D29657.F60B0462.67AC9B1.IP) (Quit: davidb)
- # [23:07] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Ping timeout)
- # [23:08] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [23:08] * Quits: @jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP) (Ping timeout)
- # [23:11] * catlee is now known as catlee-away
- # [23:32] * Quits: @surkov (surkov@C1A6A50A.88321457.33A1AC3C.IP) (Quit: surkov)
- # Session Close: Sat May 12 00:00:00 2012
The end :)