/irc-logs / mozilla / #accessibility / 2012-09-24 / end
Options:
- # Session Start: Mon Sep 24 00:00:00 2012
- # Session Ident: #accessibility
- # [00:12] * Quits: @firebot (firebot@moz-F8C1AF63.carolina.res.rr.com) (Quit: BRB. Reloading my configuration. (Koala))
- # [00:12] * Joins: firebot (firebot@moz-F8C1AF63.carolina.res.rr.com)
- # [00:12] * ChanServ sets mode: +o firebot
- # [03:05] * Joins: hub (hub@moz-E2FCA694.figuiere.net)
- # [03:05] * ChanServ sets mode: +o hub
- # [03:46] * Joins: surkov (surkov@6476E1B7.95871A73.E17943EE.IP)
- # [03:46] * ChanServ sets mode: +o surkov
- # [05:19] <@surkov> tbsaunde: hi
- # [05:29] <@tbsaunde> surkov: yo
- # [05:29] <@surkov> tbsaunde: plans for reviews? :)
- # [05:31] <@tbsaunde> surkov: yeah, probably tonight / tomorrow morning
- # [05:36] <@surkov> tbsaunde: ok, cool
- # [05:39] <@tbsaunde> surkov: sorry about delay, didn't feel really great last couple of days
- # [05:39] <@surkov> oh, I see, take your time, I'm not in hurry :)
- # [06:10] * Quits: @hub (hub@moz-E2FCA694.figuiere.net) (Ping timeout)
- # [06:11] * Joins: hub (hub@moz-E2FCA694.figuiere.net)
- # [06:11] * ChanServ sets mode: +o hub
- # [06:19] * khuey is now known as khuey|away
- # [07:36] * Joins: icaaq (Adium@moz-80D0ACBE.cust.bredbandsbolaget.se)
- # [07:49] * Quits: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com) (Ping timeout)
- # [08:03] * Quits: icaaq (Adium@moz-80D0ACBE.cust.bredbandsbolaget.se) (Quit: Leaving.)
- # [08:24] <@firebot> New Core - Disability Access APIs bug 793587 filed by surkov.alexander@gmail.com.
- # [08:25] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=793587 nor, --, ---, surkov.alexander, NEW, ASSERTION: "No frame for list item" in HTMLListBulletAccessible::Name
- # [08:30] * Joins: icaaq (Adium@moz-80D0ACBE.cust.bredbandsbolaget.se)
- # [08:43] * Quits: @surkov (surkov@6476E1B7.95871A73.E17943EE.IP) (Quit: surkov)
- # [08:46] * Quits: @hub (hub@moz-E2FCA694.figuiere.net) (Ping timeout)
- # [11:11] * Joins: surkov (surkov@91C2D83E.CE67D555.26B1D6E2.IP)
- # [11:11] * ChanServ sets mode: +o surkov
- # [11:34] * Quits: @surkov (surkov@91C2D83E.CE67D555.26B1D6E2.IP) (Ping timeout)
- # [12:19] * Quits: @firebot (firebot@moz-F8C1AF63.carolina.res.rr.com) (Ping timeout)
- # [12:47] * Joins: firebot (firebot@moz-F8C1AF63.carolina.res.rr.com)
- # [12:47] * ChanServ sets mode: +o firebot
- # [13:02] * Joins: surkov (surkov@1DE574E4.CE67D555.26B1D6E2.IP)
- # [13:02] * ChanServ sets mode: +o surkov
- # [13:21] * Quits: @surkov (surkov@1DE574E4.CE67D555.26B1D6E2.IP) (Quit: surkov)
- # [13:39] * Joins: Mic (Mic@moz-B74E0D7A.superkabel.de)
- # [13:48] * Quits: Mic (Mic@moz-B74E0D7A.superkabel.de) (Connection reset by peer)
- # [14:05] * Joins: Mic (Mic@moz-B74E0D7A.superkabel.de)
- # [14:07] * Joins: surkov (surkov@1929664.CE67D555.26B1D6E2.IP)
- # [14:07] * ChanServ sets mode: +o surkov
- # [14:20] * khuey|away is now known as khuey
- # [14:27] * Joins: Justin_o (Justin_o@67828CC7.C1A51174.9D42CF23.IP)
- # [14:41] * Quits: Justin_o (Justin_o@67828CC7.C1A51174.9D42CF23.IP) (Quit: Justin_o)
- # [14:43] * Quits: Mic (Mic@moz-B74E0D7A.superkabel.de) (Input/output error)
- # [14:46] * Joins: Justin_o (Justin_o@67828CC7.C1A51174.9D42CF23.IP)
- # [15:00] * Joins: habber (habber@moz-D385198D.nyc.res.rr.com)
- # [15:00] * Joins: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com)
- # [15:19] * Joins: davidb (davidb@F2D29657.F60B0462.67AC9B1.IP)
- # [15:19] * ChanServ sets mode: +qo davidb davidb
- # [15:29] * Quits: @surkov (surkov@1929664.CE67D555.26B1D6E2.IP) (Ping timeout)
- # [15:29] * Joins: Mic (Mic@moz-B74E0D7A.superkabel.de)
- # [15:29] <@davidb> heyo
- # [15:30] * Quits: nhirata (nhirata.bu@moz-6D599AA6.hsd1.ca.comcast.net) (Quit: nhirata)
- # [15:33] * Joins: clown (clown@5C0F34C7.A6295926.9D42CF23.IP)
- # [16:00] * Quits: Mic (Mic@moz-B74E0D7A.superkabel.de) (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
- # [16:10] * clown is now known as clown_mtg
- # [16:11] * Joins: jongund (chatzilla@moz-97EEA285.rehab.uiuc.edu)
- # [16:14] * Joins: nhirata (nhirata.bu@moz-6D599AA6.hsd1.ca.comcast.net)
- # [16:33] * Quits: Justin_o (Justin_o@67828CC7.C1A51174.9D42CF23.IP) (Quit: Justin_o)
- # [16:34] * timeless_ is now known as timeless
- # [16:35] * Joins: Justin_o (Justin_o@67828CC7.C1A51174.9D42CF23.IP)
- # [16:42] * Joins: shorlander (shorlander@moz-853043D6.dhcp.insightbb.com)
- # [16:57] * Quits: Justin_o (Justin_o@67828CC7.C1A51174.9D42CF23.IP) (Quit: Justin_o)
- # [16:58] * Joins: Justin_o (Justin_o@67828CC7.C1A51174.9D42CF23.IP)
- # [16:58] * Quits: Justin_o (Justin_o@67828CC7.C1A51174.9D42CF23.IP) (Input/output error)
- # [16:58] * Joins: Justin_o (Justin_o@67828CC7.C1A51174.9D42CF23.IP)
- # [17:05] * Joins: ehsan (ehsan@F2D29657.F60B0462.67AC9B1.IP)
- # [17:11] * khuey is now known as khuey|away
- # [17:11] * Quits: Justin_o (Justin_o@67828CC7.C1A51174.9D42CF23.IP) (Quit: Justin_o)
- # [17:25] * Joins: Justin_o (Justin_o@67828CC7.C1A51174.9D42CF23.IP)
- # [17:48] <@davidb> tbsaunde: hi
- # [17:58] * khuey|away is now known as khuey
- # [18:48] * Joins: hub (hub@A5087023.2354C43D.D8E68FF6.IP)
- # [18:48] * ChanServ sets mode: +o hub
- # [18:50] * Quits: Justin_o (Justin_o@67828CC7.C1A51174.9D42CF23.IP) (Input/output error)
- # [18:50] * Joins: Justin_o (Justin_o@67828CC7.C1A51174.9D42CF23.IP)
- # [19:10] <@firebot> bugzilla@mversen.de changed the Resolution on bug 793521 from --- to INCOMPLETE.
- # [19:10] <@firebot> bugzilla@mversen.de changed the Status on bug 793521 from UNCONFIRMED to RESOLVED.
- # [19:10] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=793521 min, --, ---, nobody, RESO INCOMPLETE, keyboard layout changed to english
- # [19:18] * Quits: clown_mtg (clown@5C0F34C7.A6295926.9D42CF23.IP) (Quit: Leaving.)
- # [19:20] * Joins: clown (clown@67828CC7.C1A51174.9D42CF23.IP)
- # [20:12] <@davidb> hub: peekaboo
- # [20:12] <@hub> davidb: hey
- # [20:12] <@hub> I'm in the front row too
- # [20:13] <@davidb> very nice
- # [20:13] <@davidb> a11y front
- # [20:19] * Joins: ttaubert (u2620@moz-160C58C6.com)
- # [20:21] <ttaubert> hey, anyone here familiar with a11y mochitests?
- # [20:21] <@davidb> ttaubert: yeah
- # [20:21] <@davidb> ttaubert: what's up?
- # [20:21] <ttaubert> davidb: awesome. I have a little problem with bug 791670.
- # [20:21] * @davidb looks
- # [20:21] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=791670 nor, --, ---, ttaubert, ASSI, [New Tab Page] enable new tab page preloading by default
- # [20:22] <@davidb> ttaubert: what's happening - fails?
- # [20:22] <ttaubert> this basically puts an iframe into the hidden window which somehow seems to make a11y tests fail:L
- # [20:22] <ttaubert> https://tbpl.mozilla.org/?tree=Try&rev=afc14b08d37a
- # [20:23] <ttaubert> the document containing the iframe (the hidden window) is one of the nsIAccessibility children
- # [20:23] <@davidb> ttaubert: this is probably a case of us needed to change the test
- # [20:24] <ttaubert> davidb: maybe. it should ideally work with or without the hidden ifram
- # [20:24] <ttaubert> e
- # [20:24] <@davidb> ttaubert: can you try putting role="presentation" on the iframe?
- # [20:24] <ttaubert> I did
- # [20:24] <ttaubert> doesn't work
- # [20:24] <@davidb> hmm
- # [20:24] <ttaubert> same thing for aria-hidden
- # [20:24] <@davidb> aria-hidden won't work
- # [20:25] <ttaubert> so the nsIAccessibility child's name is the title of the hiddenWindow
- # [20:25] <ttaubert> as soon as the hiddenWindow contains the iframe
- # [20:25] <ttaubert> it makes the test fail
- # [20:26] <ttaubert> I wonder how I can make it ignore the whole hidden window. it's not a xul element or anything
- # [20:27] * @davidb thinking
- # [20:27] <@davidb> ttaubert: is it display:none or visibility:hidden?
- # [20:27] <ttaubert> if you want to try it, just flip browser.newtab.preload to 'true' in browser/app/profile/firefox.js
- # [20:27] <@davidb> ok
- # [20:27] <ttaubert> davidb: well it's none of those (although I tried that too)
- # [20:28] <ttaubert> it's the nsIAppShellServices.hiddenWindow
- # [20:30] <@davidb> ttaubert: what does the preload do?
- # [20:31] <ttaubert> it preloads 'about:newtab'. when you open a new tab we just swap in the preloaded docShell and the new tab page loads instantly
- # [20:31] <@davidb> ok
- # [20:37] * Quits: icaaq (Adium@moz-80D0ACBE.cust.bredbandsbolaget.se) (Quit: Leaving.)
- # [20:37] <@davidb> ttaubert: not sure if you've looked into the tests… is it openDialogWnd that is failing?
- # [20:39] * Joins: icaaq (Adium@moz-80D0ACBE.cust.bredbandsbolaget.se)
- # [20:44] <ttaubert> davidb: I think the openWndShutdownDoc() was one of them
- # [20:45] <ttaubert> davidb: if you comment out L186 the test passes
- # [20:45] <ttaubert> it's about the rootAcc
- # [20:47] <@davidb> ttaubert: ok so sometimes that accTree has 3 children and sometimes not?
- # [20:49] <ttaubert> davidb: it always has three children with preloading enabled
- # [20:49] <@davidb> ok
- # [20:50] <ttaubert> one of them is the hiddenWindow for some reason
- # [20:51] <ttaubert> the other two are the test harness window and probably the current test
- # [20:51] <ttaubert> I wonder if the hiddenWindow should already be excluded at a lower level
- # [20:52] <ttaubert> I think there should never be any stuff in there that matters for a11y
- # [20:53] <@davidb> of the other two, one is the test harness window and the other should be a dialog window AFAIK
- # [20:54] <@davidb> ttaubert: display:none should keep it out of the a11y tree
- # [20:54] <@davidb> but that's probably not an option?
- # [20:54] <@davidb> (you mentioned trying it)
- # [20:56] <@davidb> (sorry doing 1 other thing at same time here)
- # [20:56] <ttaubert> davidb: np, thanks for trying to help me :)
- # [20:57] <ttaubert> the problem is that this is one magically initialized hidden window
- # [20:57] <@davidb> anytime
- # [20:57] <ttaubert> not sure how I could set that to display: none
- # [20:57] <@davidb> darn magic
- # [20:57] <ttaubert> it probably wouldn't even render/load the iframe in it
- # [20:58] <@davidb> well i can think of 3 options: change the test to somehow not use the hidden window case, have a check (from js) for the case where a hidden window is expected, modify hidden window to help a11y ignore it.
- # [20:59] <@davidb> if you do the first one, please ask :surkov for review
- # [21:04] <ttaubert> davidb: ok, thx. I'll play with it a little more :)
- # [21:04] <@davidb> ttaubert: which browser.js do i modify when using the test harness to recreate?
- # [21:04] <ttaubert> browser/app/profile/firefox.js
- # [21:05] <@davidb> ty
- # [21:05] <ttaubert> that's where we set our default values for the prefs
- # [21:05] <@davidb> yeah my brain was stuck on browser.js for some reason
- # [21:07] <@davidb> ttaubert: BTW if you want to select specific a11y tests to run… go to objdir/_tests_testing/mochitest and python run tests.py --a11y
- # [21:09] <@davidb> oh man - time for a full build for me
- # [21:18] <ttaubert> davidb: cool thx
- # [21:23] <@davidb> ttaubert: the test is passing for me on mac (with preload true)
- # [21:24] <ttaubert> davidb: yes, that failure is linux/win-only
- # [21:24] <@davidb> oh duh
- # [21:24] <ttaubert> the hiddenWindow behaves slightly different on mac
- # [21:24] <ttaubert> we don't need to inject an iframe there
- # [21:24] <@davidb> ok
- # [21:24] <@davidb> i'll need to wait until i can test then
- # [21:45] * Quits: Justin_o (Justin_o@67828CC7.C1A51174.9D42CF23.IP) (Quit: Justin_o)
- # [22:12] <@davidb> ttaubert: can't recreate it on windows… do I need a patch or something?
- # [22:12] <ttaubert> not if you're running the latest m-c
- # [22:22] <@davidb> ttaubert: latest mozilla-inbound is what i have
- # [22:22] * @davidb has to pack up
- # [22:23] * Quits: @davidb (davidb@F2D29657.F60B0462.67AC9B1.IP) (Quit: davidb)
- # [22:43] * Quits: habber (habber@moz-D385198D.nyc.res.rr.com) (Quit: habber)
- # [22:51] * Joins: satdav (satdav@moz-B6463CBE.cable.virginmedia.com)
- # [22:52] <satdav> hub, we been getting many spam on the mozilla list for accessibility
- # [22:54] <@hub> not my fault
- # [22:54] <satdav> yes i know
- # [22:54] <satdav> we should promote it more
- # [22:55] <satdav> do you know Kevin Scannell hub trying to find out what he does at mozilla
- # [22:56] <@hub> don't know
- # [22:58] <satdav> OK
- # [22:58] <satdav> is accessibility on mozillians
- # [23:00] * Parts: clown (clown@67828CC7.C1A51174.9D42CF23.IP)
- # [23:04] <satdav> hub is your email hub@mozilla.com
- # [23:06] * Parts: ttaubert (u2620@moz-160C58C6.com)
- # [23:08] * Joins: fxa90id (fxa90id@moz-D7A67C63.neoplus.adsl.tpnet.pl)
- # [23:18] * Quits: a-865 (fmcz@moz-A5D13CA.cable.mindspring.com) (Quit: ChatZilla 0.9.89 [SeaMonkey 2.13/20120912212615])
- # [23:22] * Joins: a-865 (fmcz@moz-A5D13CA.cable.mindspring.com)
- # [23:25] <fxa90id> sup ?
- # [23:25] <satdav> fxa90id, can we help you
- # [23:26] <fxa90id> just saying hello
- # [23:27] <satdav> Hello how are you
- # [23:27] <fxa90id> very well thank you
- # [23:29] <fxa90id> do you know when applying for interns ends ?
- # [23:29] <satdav> hub, can you help
- # [23:29] <fxa90id> ;p
- # [23:29] <fxa90id> probably he do
- # [23:29] <fxa90id> how are you ?
- # [23:30] <satdav> I am good
- # [23:30] <satdav> I am doing support.mozilla accessibility
- # [23:30] <fxa90id> great
- # [23:31] <fxa90id> I go take shower and try to fix #722417
- # [23:31] <fxa90id> ;p
- # [23:57] * Quits: jongund (chatzilla@moz-97EEA285.rehab.uiuc.edu) (Quit: ChatZilla 0.9.88.2 [Firefox 15.0.1/20120905151427])
- # Session Close: Tue Sep 25 00:00:02 2012
The end :)