/irc-logs / mozilla / #accessibility / 2012-10-28 / end
Options:
- # Session Start: Sun Oct 28 00:00:00 2012
- # Session Ident: #accessibility
- # [00:31] * Quits: icaaq (Adium@moz-80D0ACBE.cust.bredbandsbolaget.se) (Quit: Leaving.)
- # [01:29] * khuey is now known as khuey|away
- # [02:15] * Joins: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com)
- # [02:42] * Joins: surkov (surkov@D08E2EFF.E35E3D12.E17943EE.IP)
- # [02:42] * ChanServ sets mode: +o surkov
- # [03:46] <@tbsaunde> surkov: hey
- # [03:46] <@surkov> hello, tbsaunde
- # [03:57] <@tbsaunde> how goes?
- # [05:19] * Quits: peteb-away (ptbrunet@moz-E9B02845.austin.res.rr.com) (Client exited)
- # [05:29] <@firebot> ryanvm@gmail.com changed the Resolution on bug 782547 from FIXED to ---.
- # [05:29] <@firebot> ryanvm@gmail.com changed the Status on bug 782547 from RESOLVED to REOPENED.
- # [05:29] <@firebot> ryanvm@gmail.com changed the Target Milestone on bug 782547 from mozilla19 to ---.
- # [05:29] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=782547 nor, --, ---, enndeakin, REOP, Accessible focus not fired after dismissing modal OS dialogs (e.g. file chooser and print dialogs)
- # [06:52] * Quits: @surkov (surkov@D08E2EFF.E35E3D12.E17943EE.IP) (Quit: surkov)
- # [07:09] * Joins: ehsan (ehsan@moz-C48D29C4.cable.teksavvy.com)
- # [08:25] * Joins: victorporof (victorporo@E84D8C5F.5E620EAC.6A4F8DA2.IP)
- # [08:34] * Quits: victorporof (victorporo@E84D8C5F.5E620EAC.6A4F8DA2.IP) (Ping timeout)
- # [08:34] * Joins: victorporof (victorporo@E84D8C5F.5E620EAC.6A4F8DA2.IP)
- # [08:58] * Quits: victorporof (victorporo@E84D8C5F.5E620EAC.6A4F8DA2.IP) (Ping timeout)
- # [09:05] * Joins: icaaq (Adium@moz-80D0ACBE.cust.bredbandsbolaget.se)
- # [09:35] * Joins: victorporof (victorporo@E84D8C5F.5E620EAC.6A4F8DA2.IP)
- # [09:41] * Quits: victorporof (victorporo@E84D8C5F.5E620EAC.6A4F8DA2.IP) (Connection reset by peer)
- # [11:11] * Joins: Stevef (chatzilla@moz-CD0F47B5.cable.virginmedia.com)
- # [11:58] * Quits: icaaq (Adium@moz-80D0ACBE.cust.bredbandsbolaget.se) (Quit: Leaving.)
- # [12:54] * Joins: icaaq (Adium@475AF70D.7DCD925.CE255B90.IP)
- # [13:36] * Quits: icaaq (Adium@475AF70D.7DCD925.CE255B90.IP) (Quit: Leaving.)
- # [13:43] * Quits: Stevef (chatzilla@moz-CD0F47B5.cable.virginmedia.com) (Ping timeout)
- # [13:44] * Joins: icaaq (Adium@475AF70D.7DCD925.CE255B90.IP)
- # [13:53] * Joins: Stevef (chatzilla@moz-CD0F47B5.cable.virginmedia.com)
- # [13:55] * Quits: icaaq (Adium@475AF70D.7DCD925.CE255B90.IP) (Quit: Leaving.)
- # [13:58] * Joins: icaaq (Adium@moz-8CEEA340.cust.telenor.se)
- # [14:04] * Quits: icaaq (Adium@moz-8CEEA340.cust.telenor.se) (Connection reset by peer)
- # [14:06] * Quits: ehsan (ehsan@moz-C48D29C4.cable.teksavvy.com) (Input/output error)
- # [14:18] * Joins: surkov (surkov@D08E2EFF.E35E3D12.E17943EE.IP)
- # [14:18] * ChanServ sets mode: +o surkov
- # [14:19] <@firebot> surkov.alexander@gmail.com changed the Assignee on bug 786553 from nobody@mozilla.org to francesco.infante@aol.com.
- # [14:19] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=786553 nor, --, ---, francesco.infante, NEW, aria-relevant should be mapped to object attributes
- # [14:44] <@tbsaunde> surkov: so, what's up with bug 768243? does the patch still seem crazy or something?
- # [14:44] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=768243 is not accessible
- # [14:45] <@surkov> tbsaunde: it seems hacky
- # [14:45] <@surkov> like a workaround
- # [14:46] <@tbsaunde> surkov: hm, why?
- # [14:46] <@tbsaunde> it used to be cacheChildren always built up full children set assuming there were no existing kids
- # [14:46] <@firebot> surkov.alexander@gmail.com requested review from trev.saunders@gmail .com for attachment 675947 on bug 612830.
- # [14:46] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=612830 nor, --, ---, surkov.alexander, ASSI, make HTML document accessible work even when there's no body
- # [14:47] <@tbsaunde> now cacheChildren() can be called to make sure accessible has all the children it should have
- # [14:48] <@tbsaunde> I wouldn't mind a nicer way to figure out what needs to be added to the tree, but I think its better than what we did before
- # [14:48] <@surkov> in general when something wrong happens that I don't understand then I can't say how good the fix is
- # [14:49] <@surkov> so we have something wrong with children caching
- # [14:49] <@surkov> and instead of invalidation you just add to cache missed things
- # [14:49] <@surkov> it doesn't seem safe since I recall we were needed that InvalidateChildren in some cases
- # [14:50] <@tbsaunde> surkov: I'd say the problem is more with InvalidateChildren() than children caching
- # [14:50] <@surkov> for example, how we can guarantee that we don't add one child twice if it's index was chagned
- # [14:51] <@surkov> maybe I should answer in the bug
- # [14:52] <@surkov> to state my concern clearer
- # [14:52] <@tbsaunde> surkov: I'm thinking about how we preventing adding something again, but I feel like it either should work already or we can make it work
- # [14:53] <@tbsaunde> but I need to understand the argument so I can explain it
- # [14:57] <@tbsaunde> surkov: can you explain how you think you could get a child added twice?
- # [14:59] <@tbsaunde> I can see it happening if something has already run off the rails, but I feel like so long as you stay on the rails you keep on them
- # [14:59] <@surkov> tbsaunde: I just don't trust cache missed children approach, I don't have idea what exactly happens there so I assume all scenarios possible
- # [15:00] <@tbsaunde> surkov: I can sort of understand that
- # [15:02] <@tbsaunde> surkov: on the other hand what we do right now doesn't work iether so
- # [15:02] <@surkov> true
- # [15:03] <@surkov> but I would't avoid to trade bad for worse
- # [15:03] <@surkov> wouldn't -> would
- # [15:03] <@surkov> tbsaunde: is there a chance to debug and understand where exactly we get broken?
- # [15:03] <@tbsaunde> surkov: sure, but I'd trade bad for less bad
- # [15:04] <@surkov> true
- # [15:04] <@tbsaunde> surkov: I guess
- # [15:05] <@tbsaunde> surkov: but really I don't see what there is too understand lets say you have <div id=foo> <div> <div> </div> </div> </div> and you cause InvaidateChildren() to be called on foo how could that not detach a subtree?
- # [15:06] <@surkov> InvalidateChildren is always paired by CacheChildren, no?
- # [15:07] <@tbsaunde> sure, but for some time the subtree was detached right
- # [15:07] <@surkov> it happens sync
- # [15:07] <@tbsaunde> true
- # [15:08] <@surkov> we shouldn't do anything bad between InvalidateChildren and CacheChildren
- # [15:08] <@surkov> but it seems we do
- # [15:08] <@surkov> and what we do is a question
- # [15:08] <@surkov> if I understand right
- # [15:09] <@tbsaunde> surkov: well, suppose the dom changes something like this <div id=foo> <div> <div id=bar> </div> </div> </div> then you change it to <div id=foo> <div id=bar> </div> </div>
- # [15:10] <@tbsaunde> I think removal notifications should probably make that a two step thing, but
- # [15:10] <@tbsaunde> it seems kind of dangerious to assume that
- # [15:11] <@surkov> how do you change DOM to get that?
- # [15:11] <@tbsaunde> surkov: so I actually sort of like just ensuring all children are cached and not calling InvalidateChildren() because it seems it should make bugs where we don't get notified more apparent
- # [15:12] <@surkov> tbsaunde: do you have failed mochitest?
- # [15:12] <@tbsaunde> surkov: with my patch? only that reorder event
- # [15:12] <@surkov> tbsaunde: did you debugged it?
- # [15:13] <@surkov> did you checked accessible tree?
- # [15:13] <@tbsaunde> as a test case for bug no only the fuzzer thing which seems basically unreadable
- # [15:13] <@tbsaunde> not yet because you seemed to want to
- # [15:13] <@tbsaunde> but I can look into it soon
- # [15:14] <@surkov> that'd be good
- # [15:15] <@tbsaunde> yeah, ok
- # [15:36] * Quits: @surkov (surkov@D08E2EFF.E35E3D12.E17943EE.IP) (Quit: surkov)
- # [15:52] * Quits: Stevef (chatzilla@moz-CD0F47B5.cable.virginmedia.com) (Ping timeout)
- # [16:17] * Joins: Stevef (chatzilla@moz-CD0F47B5.cable.virginmedia.com)
- # [17:17] * Joins: ehsan (ehsan@moz-C48D29C4.cable.teksavvy.com)
- # [17:23] * Quits: Stevef (chatzilla@moz-CD0F47B5.cable.virginmedia.com) (Ping timeout)
- # [17:45] * Joins: victorporof (victorporo@E84D8C5F.5E620EAC.6A4F8DA2.IP)
- # [17:48] * Joins: icaaq (Adium@moz-80D0ACBE.cust.bredbandsbolaget.se)
- # [18:37] * Quits: icaaq (Adium@moz-80D0ACBE.cust.bredbandsbolaget.se) (Quit: Leaving.)
- # [18:39] * Quits: victorporof (victorporo@E84D8C5F.5E620EAC.6A4F8DA2.IP) (Connection reset by peer)
- # [18:48] * Joins: victorporof (victorporo@E84D8C5F.5E620EAC.6A4F8DA2.IP)
- # [18:50] * Quits: victorporof (victorporo@E84D8C5F.5E620EAC.6A4F8DA2.IP) (Connection reset by peer)
- # [18:50] * Joins: victor (victorporo@E84D8C5F.5E620EAC.6A4F8DA2.IP)
- # [19:07] * Joins: margle (margle@moz-FA382099.dsl.mweb.co.za)
- # [19:31] * Joins: Stevef (chatzilla@moz-CD0F47B5.cable.virginmedia.com)
- # [19:44] * Joins: icaaq (Adium@moz-80D0ACBE.cust.bredbandsbolaget.se)
- # [19:55] * Quits: margle (margle@moz-FA382099.dsl.mweb.co.za) (Quit: Computer has gone to sleep.)
- # [19:58] * Joins: margle (margle@moz-FA382099.dsl.mweb.co.za)
- # [20:24] * Joins: habber (habber@moz-4CC5106C.nyc.res.rr.com)
- # [20:30] * Quits: ehsan (ehsan@moz-C48D29C4.cable.teksavvy.com) (Connection reset by peer)
- # [20:40] * Quits: icaaq (Adium@moz-80D0ACBE.cust.bredbandsbolaget.se) (Quit: Leaving.)
- # [20:46] * Quits: Stevef (chatzilla@moz-CD0F47B5.cable.virginmedia.com) (Ping timeout)
- # [21:26] * Joins: ehsan (ehsan@moz-C48D29C4.cable.teksavvy.com)
- # [21:33] * Quits: habber (habber@moz-4CC5106C.nyc.res.rr.com) (Quit: habber)
- # [21:49] * Joins: icaaq (Adium@moz-80D0ACBE.cust.bredbandsbolaget.se)
- # [21:49] * Quits: margle (margle@moz-FA382099.dsl.mweb.co.za) (Quit: Computer has gone to sleep.)
- # [21:52] * Joins: margle (margle@moz-FA382099.dsl.mweb.co.za)
- # [22:17] * Quits: margle (margle@moz-FA382099.dsl.mweb.co.za) (Quit: Computer has gone to sleep.)
- # [22:20] * Joins: margle (margle@moz-FA382099.dsl.mweb.co.za)
- # [22:22] * Quits: icaaq (Adium@moz-80D0ACBE.cust.bredbandsbolaget.se) (Quit: Leaving.)
- # [22:24] * Quits: victor (victorporo@E84D8C5F.5E620EAC.6A4F8DA2.IP) (Quit: victor)
- # [22:32] * Quits: margle (margle@moz-FA382099.dsl.mweb.co.za) (Quit: Computer has gone to sleep.)
- # [22:55] * Joins: victorporof (victorporo@E84D8C5F.5E620EAC.6A4F8DA2.IP)
- # [23:03] * Quits: victorporof (victorporo@E84D8C5F.5E620EAC.6A4F8DA2.IP) (Ping timeout)
- # [23:29] * Quits: ehsan (ehsan@moz-C48D29C4.cable.teksavvy.com) (Input/output error)
- # [23:31] * Joins: victorporof (victorporo@E84D8C5F.5E620EAC.6A4F8DA2.IP)
- # [23:40] * Quits: victorporof (victorporo@E84D8C5F.5E620EAC.6A4F8DA2.IP) (Ping timeout)
- # Session Close: Mon Oct 29 00:00:00 2012
The end :)