/irc-logs / mozilla / #accessibility / 2013-03-22 / end
Options:
- # Session Start: Fri Mar 22 00:00:00 2013
- # Session Ident: #accessibility
- # [00:09] * Quits: lizzard (ehenry@moz-BE33DA21.fw1.sfo1.mozilla.net) (Quit: lizzard)
- # [00:09] <@firebot> bugmail.mozilla@staktrace.com denied review for attachment 727704 on bug 852955.
- # [00:09] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=852955 maj, --, ---, nobody, NEW, [AccessFu] Trying to activate items at top of pages brings up awesome bar or menu instead
- # [00:11] * khuey is now known as khuey|away
- # [00:14] * Joins: lizzard (ehenry@moz-BE33DA21.fw1.sfo1.mozilla.net)
- # [00:36] * Quits: nhirata (anonymous@moz-1A50F7F8.hsd1.ca.comcast.net) (Quit: nhirata)
- # [01:18] * Quits: lizzard (ehenry@moz-BE33DA21.fw1.sfo1.mozilla.net) (Quit: lizzard)
- # [01:23] * khuey|away is now known as khuey
- # [01:43] * Joins: lizzard (ehenry@moz-5530C43D.tmodns.net)
- # [01:53] * Quits: lizzard (ehenry@moz-5530C43D.tmodns.net) (Quit: lizzard)
- # [01:57] * Joins: hub (hub@moz-ACA38520.dsl.teksavvy.com)
- # [01:57] * ChanServ sets mode: +o hub
- # [02:16] * Joins: lizzard (ehenry@moz-5443DFD2.public.monkeybrains.net)
- # [02:46] * Quits: lizzard (ehenry@moz-5443DFD2.public.monkeybrains.net) (Ping timeout)
- # [02:46] * Joins: lizzard (ehenry@DC06FEB8.986AD0D1.E9CDD81.IP)
- # [02:48] * Joins: surkov (surkov@511E724B.E00BF004.E17943EE.IP)
- # [02:48] * ChanServ sets mode: +o surkov
- # [03:00] * Quits: lizzard (ehenry@DC06FEB8.986AD0D1.E9CDD81.IP) (Quit: lizzard)
- # [03:00] * Joins: lizzard (ehenry@moz-5443DFD2.public.monkeybrains.net)
- # [03:02] * Quits: lizzard (ehenry@moz-5443DFD2.public.monkeybrains.net) (Ping timeout)
- # [03:03] * Joins: lizzard (ehenry@59AFB49E.97E0E411.F02D0170.IP)
- # [03:07] * Quits: lizzard (ehenry@59AFB49E.97E0E411.F02D0170.IP) (Quit: lizzard)
- # [03:30] * Quits: @hub (hub@moz-ACA38520.dsl.teksavvy.com) (Ping timeout)
- # [03:32] * Joins: lizzard (ehenry@moz-5443DFD2.public.monkeybrains.net)
- # [03:34] * Quits: lizzard (ehenry@moz-5443DFD2.public.monkeybrains.net) (Ping timeout)
- # [03:34] * Joins: lizzard (ehenry@59AFB49E.97E0E411.F02D0170.IP)
- # [03:53] * Quits: lizzard (ehenry@59AFB49E.97E0E411.F02D0170.IP) (Quit: lizzard)
- # [04:13] <@firebot> jamie@nvaccess.org cancelled needinfo?(jamie@nvaccess.or g) on bug 852044.
- # [04:13] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=852044 nor, --, ---, trev.saunders, ASSI, don't fire events from DocAccessible::ProcessLoad() sync
- # [04:14] * Joins: lizzard (ehenry@moz-5443DFD2.public.monkeybrains.net)
- # [04:16] * Quits: lizzard (ehenry@moz-5443DFD2.public.monkeybrains.net) (Ping timeout)
- # [04:47] * Quits: @surkov (surkov@511E724B.E00BF004.E17943EE.IP) (Quit: surkov)
- # [04:50] * Joins: surkov (surkov@511E724B.E00BF004.E17943EE.IP)
- # [04:50] * ChanServ sets mode: +o surkov
- # [06:11] * khuey is now known as khuey|away
- # [06:59] * Quits: peteb-away (ptbrunet@moz-B51E1692.austin.res.rr.com) (Input/output error)
- # [07:17] <@tbsaunde> surkov: so, what is the forwardBack thing about?
- # [07:37] * Joins: icaaq (Adium@moz-D8A76420.cust.bredbandsbolaget.se)
- # [08:07] <@tbsaunde> surkov: ping
- # [08:28] <@surkov> tbsaunde: it's about when we should move forward and then backward or we move backward and then to forward
- # [08:29] <@tbsaunde> surkov: oh, hm, I wonder if it would be clearer to just check aBoundaryType == ?
- # [08:30] <@tbsaunde> surkov: the other thing that comes to mind is that maybe it would be nice to just create an iterator like thing that iterates over words?
- # [08:31] <@surkov> tbsaunde: perhaps it's not very evident to deal with boundary type for this, if forwardBack is not good name then we can rename it to something nicer?
- # [08:32] <@surkov> tbsaunde: yeah, I thought about word iterator, probably that's the way I will go next round
- # [08:32] <@tbsaunde> surkov: renaming sgtm
- # [08:32] <@tbsaunde> moveDirection maybe?
- # [08:32] <@surkov> tbsaunde: name alternatives?
- # [08:33] <@tbsaunde> surkov: ^ ;)
- # [08:33] <@surkov> enum { forwardBack, backForward } ?
- # [08:33] <@tbsaunde> surkov: forward and back in the same thing is still confusing
- # [08:34] <@surkov> moveDirection is usually a one direction
- # [08:34] <@surkov> forwardThenBack?
- # [08:34] <@tbsaunde> how about enum { prevText, nextChunk }
- # [08:34] <@tbsaunde> well, prevChunk / nextChunk of course
- # [08:35] <@tbsaunde> err, that's still bad
- # [08:35] <@tbsaunde> surkov: maybe just leave it and hope iterator stuff makes it somewhat go away?
- # [08:36] <@surkov> tbsaunde: sounds good, for now maybe bool moveForwardThenBack?
- # [08:36] <@tbsaunde> surkov: ok
- # [08:36] <@surkov> of course it doesn't mean that false is vise versa
- # [08:36] <@surkov> mean -> point
- # [08:37] <@tbsaunde> surkov: or enum { moveForwardThenBack, MoveBackThenForward } ?
- # [08:37] <@surkov> tbsaunde: it's larger but should be ok
- # [08:38] <@tbsaunde> surkov: yeah, but bools aren't always to read when there meaning is unclear
- # [08:38] <@tbsaunde> surkov: are you planning to provide non xpcom API at some point so we can just assert more stuff?
- # [08:38] <@surkov> tbsaunde: like what?
- # [08:39] <@surkov> I don't get connection between API and assertions
- # [08:39] <@tbsaunde> surkov: surkov mostly I just want to make stuff infalible when possible
- # [08:39] <@surkov> tbsaunde: I see, one day we will need it anyway
- # [08:40] <@surkov> not sure about nearest plans
- # [08:40] <@tbsaunde> surkov: not sure what you mean
- # [08:40] <@surkov> tbsaunde: we need non xpcom api for text stuffs because xpcom will be moved out from internal classes
- # [08:41] <@tbsaunde> surkov: true
- # [08:41] <@tbsaunde> surkov: unless we decide we want to convert it to webidl at some point
- # [08:42] <@surkov> tbsaunde: right
- # [08:44] <@tbsaunde> surkov: any opion on that btw
- # [08:45] <@tbsaunde> surkov: so, I don't understand the null checking stuff of startFrame after GetPosAndText()
- # [08:47] <@surkov> tbsaunde: which method do you refer?
- # [08:48] <@tbsaunde> surkov: the new stuff for word boundaries
- # [08:48] <@surkov> tbsaunde: iirc when we at the text len offset then startFrame is null
- # [08:49] <@tbsaunde> surkov: so its just accounting for GetPosAndText() being crazy and will go away?
- # [08:49] <@surkov> tbsaunde: true
- # [08:50] <@tbsaunde> surkov: one more thing, the regressions in singleLine.html are from what?
- # [08:51] <@surkov> tbsaunde: in getTextAtOffset?
- # [08:51] <@surkov> if getTextAfter/BeforeOffset then from getPosAndText
- # [08:51] <@surkov> getTextAtOffset is layout gives us wrong word
- # [08:52] <@tbsaunde> surkov: ok, is there a bug for layout giving us the wrong word?
- # [08:52] <@surkov> tbsaunde: I filed yesterday
- # [08:52] <@surkov> tbsaunde: actually I want to try implement own word iterator
- # [08:53] <@tbsaunde> surkov: ok, based on what?
- # [08:54] <@surkov> tbsaunde: layout use a thing to guess word boundaries, we just reuse it and will traverse accessible tree instead frame tree
- # [08:54] <@surkov> and that must be fast
- # [08:55] <@tbsaunde> surkov: ok, so that would mean we'd use frames a lot less in the text stuff and rely on cached text?
- # [08:55] <@surkov> tbsaunde: yes
- # [08:56] <@tbsaunde> surkov: ok :)
- # [08:57] <@tbsaunde> surkov: then r=me (be abit before I can use bugzilla because of debugging stuff thoguh)
- # [08:57] <@surkov> :) ok
- # [08:57] * Quits: Jamie (Instantbir@moz-CA26021.jantrid.net) (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
- # [09:21] * Joins: ghooo (ghooo@AC245DAC.C93B4D20.8A456C8F.IP)
- # [09:23] <@firebot> trev.saunders@gmail.com granted review for attachment 727551 on bug 853340.
- # [09:23] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=853340 nor, --, ---, surkov.alexander, ASSI, getTextAtOffset for word boundaries: beginning of a new life
- # [09:26] * Joins: marcoz (marco.zehe@moz-9E48456C.dip.t-dialin.net)
- # [09:26] * ChanServ sets mode: +o marcoz
- # [09:45] <@firebot> marco.zehe@googlemail.com changed the Assignee on bug 848775 from nobody@mozilla.org to marco.zehe@googlemail.com.
- # [09:45] <@firebot> marco.zehe@googlemail.com changed the Status on bug 848775 from NEW to ASSIGNED.
- # [09:46] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=848775 nor, --, ---, marco.zehe, ASSI, NVDA only gets text from status bar live region in disjointed chunks
- # [10:25] * Quits: ghooo (ghooo@AC245DAC.C93B4D20.8A456C8F.IP) (Ping timeout)
- # [10:26] * Joins: ghooo (ghooo@AC245DAC.C93B4D20.8A456C8F.IP)
- # [11:17] * Quits: logbot (logbot@moz-58CB32ED.glob.com.au) (Ping timeout)
- # [11:18] * Quits: ghooo (ghooo@AC245DAC.C93B4D20.8A456C8F.IP) (Ping timeout)
- # [11:20] <@tbsaunde> surkov: see my comment in bug 852150?
- # [11:20] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=852150 nor, --, ---, nobody, NEW, "ASSERTION: No accessible parent?!" with table
- # [11:20] <@surkov> tbsaunde: the last one?
- # [11:22] * Joins: logbot (logbot@moz-58CB32ED.glob.com.au)
- # [11:23] <@tbsaunde> surkov: yes
- # [11:24] <@surkov> yeah, that was surprising :)
- # [11:24] <@tbsaunde> surkov: yeah, any interesting ideas?
- # [11:25] <@surkov> I don't think so
- # [11:26] * Joins: victorporof (victorporo@2982C4BE.162B26E2.79933D60.IP)
- # [11:34] * Quits: @surkov (surkov@511E724B.E00BF004.E17943EE.IP) (Quit: surkov)
- # [11:56] * Joins: victorporof_ (victorporo@2982C4BE.162B26E2.79933D60.IP)
- # [11:57] * Quits: victorporof (victorporo@2982C4BE.162B26E2.79933D60.IP) (Ping timeout)
- # [12:13] * victorporof_ is now known as victorporof
- # [13:12] * Joins: Justin_o (Justin_o@67828CC7.C1A51174.9D42CF23.IP)
- # [13:31] * Quits: victorporof (victorporo@2982C4BE.162B26E2.79933D60.IP) (Quit: victorporof)
- # [13:34] * Joins: davidb|mobile (yaaic@moz-CC2687B8.eng.wind.ca)
- # [13:35] <davidb|mobile> fwiw in later today (dental followup)
- # [13:35] * Quits: davidb|mobile (yaaic@moz-CC2687B8.eng.wind.ca) (Quit: Yaaic - Yet another Android IRC client - http://www.yaaic.org)
- # [13:54] * Joins: yzen (Adium@AA2C085E.10C8AEF8.9A8C35B4.IP)
- # [14:04] <@tbsaunde> vd: ping
- # [14:14] * Joins: peteb-away (ptbrunet@moz-B51E1692.austin.res.rr.com)
- # [14:24] <vd> tbsaunde: pong (back from lunch)
- # [14:29] * Joins: scott_gonzalez (scott_gonz@moz-91C81A39.hrbgpa.fios.verizon.net)
- # [14:29] <@tbsaunde> vd: sure, so I talked with surkov yesterday, keep firing events from GetNameCB() but put comment saying // XXX this is crazy or similar
- # [14:29] <vd> :)
- # [14:30] <@tbsaunde> vd: be more descriptive than just "this is crazy" of course ;)
- # [14:30] <vd> tbsaunde: Should I mention any dragons? :)
- # [14:34] * Joins: victorporof (victorporo@DC82DE00.39508509.6A4F8DA2.IP)
- # [14:35] <@tbsaunde> vd: nah, not scary just odd and crazy
- # [14:37] <vd> tbsaunde: so the patch I submitted last is about ok? https://bug733712.bugzilla.mozilla.org/attachment.cgi?id=726580
- # [14:37] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=733712 cri, --, ---, vd, ASSI, Don't call atk_object_set_name
- # [14:39] <@tbsaunde> vd: the one I f+'d? yeah, just clean it up
- # [14:40] <vd> yes
- # [14:41] <vd> tbsaunde: btw is this multithreaded code (getDescriptionCB() and getNameCB()) ?
- # [14:44] <@tbsaunde> vd: no
- # [14:44] <@tbsaunde> atk never says that explicitly, but in practice it has to be
- # [14:45] <vd> hmm, then probably the copying of the new string into the old one if the new one is smaller is indeed a noop
- # [14:45] <vd> or even a loss
- # [14:45] <vd> Should I remove it?
- # [14:46] <@tbsaunde> vd: I think so
- # [14:46] <vd> ok
- # [14:47] <@tbsaunde> that's I why I suggested it ;)
- # [14:53] * Quits: Justin_o (Justin_o@67828CC7.C1A51174.9D42CF23.IP) (Quit: Justin_o)
- # [14:57] * Joins: davidb (davidb@F2D29657.F60B0462.67AC9B1.IP)
- # [14:57] * ChanServ sets mode: +qo davidb davidb
- # [14:58] <@davidb> heyo
- # [14:59] <@davidb> i am so tired of dentistry
- # [15:00] <@tbsaunde> davidb: hi
- # [15:00] <@marcoz> davidb: Oh I can imagine!
- # [15:01] <@davidb> back on baby food for a week
- # [15:01] <@firebot> emorley@mozilla.com changed the Resolution on bug 852044 from --- to FIXED.
- # [15:01] <@davidb> what am i gonna do when i run out of babies?
- # [15:01] <@firebot> emorley@mozilla.com changed the Status on bug 852044 from ASSIGNED to RESOLVED.
- # [15:01] <@firebot> emorley@mozilla.com changed the Target Milestone on bug 852044 from --- to mozilla22.
- # [15:01] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=852044 nor, --, mozilla22, trev.saunders, RESO FIXED, don't fire events from DocAccessible::ProcessLoad() sync
- # [15:02] <@marcoz> davidb: Baby food will always be available in the store round the corner. ;)
- # [15:02] <@davidb> oh! that's what she mean't?
- # [15:03] <@davidb> what a relief
- # [15:03] <@firebot> emorley@mozilla.com changed the Resolution on bug 852021 from --- to FIXED.
- # [15:03] * Joins: clown (clown@67828CC7.C1A51174.9D42CF23.IP)
- # [15:03] * Quits: brambles (xymox@moz-969AAE9B.barwen.ch) (Ping timeout)
- # [15:03] <@firebot> emorley@mozilla.com changed the Status on bug 852021 from NEW to RESOLVED.
- # [15:03] <@firebot> emorley@mozilla.com changed the Target Milestone on bug 852021 from --- to mozilla22.
- # [15:03] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=852021 nor, --, ---, surkov.alexander, NEW, add getText* at caret offset mochitest
- # [15:04] <@marcoz> davidb: Dunno actually. ;)
- # [15:05] * Joins: brambles (xymox@moz-969AAE9B.barwen.ch)
- # [15:06] <@marcoz> davidb: On something completely unrelated: Looks like the number of devices that blind Android users can use is increasing. The HTC One Petra got today actually works quite well with TalkBack. It comes with Jelly Bean 4.1.2, so quite close to current Google version, and the Sense skin doesn't give it too much trouble it appears.
- # [15:06] * Joins: Justin_o (Justin_o@67828CC7.C1A51174.9D42CF23.IP)
- # [15:08] <@davidb> it makes sense
- # [15:12] * Joins: Bryen (Bryen@moz-97CDA41D.lightspeed.cicril.sbcglobal.net)
- # [15:17] * Joins: hub (hub@F2D29657.F60B0462.67AC9B1.IP)
- # [15:17] * ChanServ sets mode: +o hub
- # [15:25] * Quits: Justin_o (Justin_o@67828CC7.C1A51174.9D42CF23.IP) (Quit: Justin_o)
- # [15:27] <@marcoz> hub: The HTC One works with TalkBack! :)
- # [15:30] <@hub> marcoz: I read that.
- # [15:30] <@hub> is it Android 4.x?
- # [15:31] * Joins: habber (habber@moz-8654C0B7.nyc.res.rr.com)
- # [15:33] <@marcoz> hub: 4.1.2, so *almost* current! :)
- # [15:35] <@marcoz> hub: The HTC One is their shiny new flagship model that they released just this month.
- # [15:36] <@hub> more current than my samsung crap, that's for sure
- # [15:36] <@hub> marcoz: it is good they fixed that
- # [15:44] * Joins: Justin_o (Justin_o@67828CC7.C1A51174.9D42CF23.IP)
- # [15:57] <@marcoz> hub: I
- # [15:57] <@marcoz> Hub: I'm still trying to find out whether this was intentional or by accident. :)
- # [16:01] <@hub> it could hardly been an accident
- # [16:08] <@marcoz> hub: Why do you think that? :)
- # [16:09] <@davidb> a good goal is to make a11y accidentally possible :)
- # [16:10] <@hub> marcoz: it is Android. Things don't miraculously start to work
- # [16:10] <@hub> you have to put a lot of effort to do so
- # [16:13] <@marcoz> hub: Yeah but Samsung can still fuck this up. The Galaxy S III, also running Jelly Bean now, is barely accessible.
- # [16:14] <@hub> marcoz: as soon as samsung touch software it becomes a turd. Samsung manage to turn Android into worse than it is
- # [16:14] <@hub> I know I have one
- # [16:14] <@hub> their "note" app require to explicitly save
- # [16:15] <@marcoz> hub: Noooooooo! ROFL!
- # [16:16] <@marcoz> hub: Yeah what I saw so far felt pretty much like Standard Android with some additions on the HTC side. Even their Blink Feed, the aggregator on the home screen, works at least on the surface. haven't dug deeper yet.
- # [16:32] <@firebot> mak77@bonardo.net requested review from paolo.mozmail@amadz one.org for attachment 727098 on bug 394144.
- # [16:32] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=394144 tri, --, ---, nobody, NEW, Missing keyboard accelerator on "Do not ask next time" in the new quit dialog
- # [16:39] * Quits: Justin_o (Justin_o@67828CC7.C1A51174.9D42CF23.IP) (Quit: Justin_o)
- # [16:50] * Quits: victorporof (victorporo@DC82DE00.39508509.6A4F8DA2.IP) (Quit: victorporof)
- # [16:57] <vd> tbsaunde: what is the recommended max line length in AccessibleWrap.cpp ?
- # [16:58] * Joins: Justin_o (Justin_o@67828CC7.C1A51174.9D42CF23.IP)
- # [17:05] <@tbsaunde> vd: we still use 80 :/
- # [17:07] <vd> tbsaunde: so I have to break this line: "static void MaybeFireNameChange(AtkObject *aAtkObj, const nsAutoString& aNewNameUTF16);" if I split before the "const" keyword, how many spaces on the second line?
- # [17:09] <vd> I little below there are lines like (inside a comment):
- # [17:09] <vd> static guint ConnectPropertyChangeHandlerCB(
- # [17:09] <vd> AtkObject *aObj,
- # [17:09] <vd> AtkPropertyChangeHandler *handler);
- # [17:09] <vd> do I start the second line with 0 extra spaces?
- # [17:14] <yzen> eeejay: ping
- # [17:21] * Joins: victorporof (victorporo@DC82DE00.39508509.6A4F8DA2.IP)
- # [17:23] <@marcoz> yzen: eeejay is usually around in an hour from now. he's on the west coast.
- # [17:23] <yzen> marcoz: thanks, ill ping him then
- # [17:23] * khuey|away is now known as khuey
- # [17:24] * khuey is now known as khuey|sick
- # [17:24] <@firebot> vd@FreeBSD.org requested review from trev.saunders@gmail .com for attachment 728261 on bug 733712.
- # [17:25] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=733712 cri, --, ---, vd, ASSI, Don't call atk_object_set_name
- # [17:27] * Quits: victorporof (victorporo@DC82DE00.39508509.6A4F8DA2.IP) (Ping timeout)
- # [17:30] <@marcoz> OK, weekend! :) See you on Monday!
- # [17:30] * Quits: @marcoz (marco.zehe@moz-9E48456C.dip.t-dialin.net) (Quit: Leaving.)
- # [17:36] <@davidb> jlreboot
- # [17:36] <@davidb> reboot
- # [17:38] * Quits: @davidb (davidb@F2D29657.F60B0462.67AC9B1.IP) (Quit: davidb)
- # [17:38] <@firebot> yura.zenevich@gmail.com cancelled feedback?(eitan@monotonous. org) for attachment 727535 on bug 753984.
- # [17:38] <@firebot> yura.zenevich@gmail.com requested feedback from eitan@monotonous. org for attachment 728276 on bug 753984.
- # [17:38] <@firebot> yura.zenevich@gmail.com requested needinfo from eitan@monotonous. org on bug 753984.
- # [17:38] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=753984 nor, --, ---, yura.zenevich, NEW, [AccessFu] Make utterance order configurable
- # [17:41] * Joins: davidb (davidb@F2D29657.F60B0462.67AC9B1.IP)
- # [17:41] * ChanServ sets mode: +qo davidb davidb
- # [17:48] * habber is now known as habber-away
- # [17:55] <@eeejay> hey yzen
- # [17:55] <@eeejay> i'll look at your test today
- # [17:58] <yzen> eeejay: thanks!
- # [18:08] * Quits: Justin_o (Justin_o@67828CC7.C1A51174.9D42CF23.IP) (Quit: Justin_o)
- # [18:10] <@tbsaunde> vd: start of args should line up, so indent second line as much as ( on line above
- # [18:11] <@tbsaunde> (just got back from lunch)
- # [18:13] * Joins: Justin_o (Justin_o@67828CC7.C1A51174.9D42CF23.IP)
- # [18:16] <@firebot> eitan@monotonous.org cancelled needinfo?(eitan@monotonous. org) on bug 753984.
- # [18:16] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=753984 nor, --, ---, yura.zenevich, NEW, [AccessFu] Make utterance order configurable
- # [18:19] <yzen> eeejay: so does it mean _addName should be called within the list item utterance generator function at all ?
- # [18:19] <yzen> should not*
- # [18:20] <@eeejay> yzen. it is making me re-think your patch, it only does half the job
- # [18:20] <@eeejay> now that i think of it. it slipped my mind when i gave initial feedback
- # [18:22] <@eeejay> yzen the full utterances are constructed in the presenters
- # [18:22] <@eeejay> which, btw might not be great
- # [18:22] <@eeejay> yzen, so you need to feed the utterance generator in post-order as opposed to pre-order
- # [18:22] <@eeejay> does that make sense?
- # [18:26] * Joins: victorporof (victorporo@DC82DE00.39508509.6A4F8DA2.IP)
- # [18:28] * Quits: victorporof (victorporo@DC82DE00.39508509.6A4F8DA2.IP) (Ping timeout)
- # [18:29] <@firebot> mounir@lamouri.fr requested needinfo from surkov.alexander@ gmail.com on bug 847233.
- # [18:29] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=847233 nor, --, ---, mounir, ASSI, Fix a11y with <input type='file'> changes
- # [18:31] <yzen> eeejay: i just beed a little bit more context. so you are saying that full utterance might include outputs from multiple utterance generators? in that case the ordering should also happen before the output is announced?
- # [18:31] <@eeejay> yzen, yes
- # [18:32] * habber-away is now known as habber
- # [18:32] <@eeejay> yzen, originally i thought it would mean a different tree traversal order, and now i am wondering if simply reversing the array in the presenter is enough..
- # [18:33] * Joins: drexler (chatzilla@moz-1896B9D3.hsd1.vt.comcast.net)
- # [18:38] <@firebot> dbolter@mozilla.com cancelled needinfo?(dbolter@mozilla.c om) on bug 847233.
- # [18:38] <@eeejay> yzen, yeah, i think maybe reversing the array on the Presentation side might be the more correct thing to do
- # [18:39] <yzen> eeejay: so do you think it should be like this : reversed subtree , accessible, reversed ancestry ?
- # [18:40] <@eeejay> yzen, isn't that the same as reversing the whole thing after the are all appended?
- # [18:40] <yzen> eeejay: duh , you are right :)
- # [18:40] <@eeejay> yzen, i am not 100% sure if that will produce the right effect. i think so
- # [18:41] <@eeejay> but i might need to think about it. you could too!
- # [18:41] <@eeejay> if you have an iphone or nvda, you could see how they do it
- # [18:41] <yzen> eeejay: nvda
- # [18:41] <yzen> eeejay: ok so ill try reverting output and see what i get
- # [18:41] <@eeejay> yzen, yeah, worth seeing how they announce things in the page
- # [18:42] <@tbsaunde> davidb: have time for a quick test review?
- # [18:42] <@davidb> tbsaunde: you bet
- # [18:42] <@eeejay> yzen, also, i think the utterance list construction should be move to UtteranceGenerator out of Presenters
- # [18:42] <yzen> eeejay: should i make a separate bug for that ?
- # [18:42] <vd> tbsaunde: I wrote it as:
- # [18:42] <vd> static void
- # [18:42] <vd> MaybeFireNameChange(AtkObject *aAtkObj, const nsAutoString& aNewNameUTF16);
- # [18:43] <@eeejay> yzen, i am fine with you submitting a patch for this bug with a refactor
- # [18:43] <vd> and uploaded the patch to the bug report, see if there is anything else I chould change
- # [18:43] <vd> s/chould/should/
- # [18:43] <@tbsaunde> vd: ok, sure
- # [18:44] <yzen> eeejay: sounds good, also regarding that earlier question about list item and name, does it need to happen since you mentioned that the name for list item is not being included ?
- # [18:45] <@eeejay> yzen, it is not a bug. it shouldn't be included because the child's name is
- # [18:45] <@davidb> names for list items is a strange case
- # [18:45] <@eeejay> yeah
- # [18:45] <@davidb> probably a non case
- # [18:46] <@eeejay> there are two children, we ignore the first
- # [18:46] <@eeejay> because it is the bullet
- # [18:46] <@davidb> usually the middle child is ignored ;)
- # [18:46] <yzen> haha
- # [18:48] <@eeejay> :)
- # [18:49] <@eeejay> but it is not strange in the sense that container names not spoken if their names are anyway constructed by the subtree
- # [18:50] <@firebot> New Core - Disability Access APIs bug 853927 filed by trev.saunders@gmail.com.
- # [18:50] <@davidb> right
- # [18:50] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=853927 nor, --, ---, trev.saunders, NEW, test_scroll.xul can fail locally because of the weird shenanigans it does to open scroll.html
- # [18:50] <@davidb> name from subtree
- # [18:50] <@davidb> tbsaunde: love that title
- # [18:51] <@davidb> we run an httpd?
- # [18:51] * @davidb learns something new every day
- # [18:51] <@tbsaunde> davidb: yup, httpd.js in pxcshell iirc
- # [18:51] <@tbsaunde> *xpcshell
- # [18:52] <@davidb> i know nothing
- # [18:52] <@davidb> .
- # [18:52] <@firebot> trev.saunders@gmail.com requested review from dbolter@mozilla.com for attachment 728311 on bug 853927.
- # [18:52] <@tbsaunde> 1 file changed 1 insertion 14 deletions :)
- # [18:54] * @davidb salivates
- # [18:55] <@davidb> tbsaunde: this works?
- # [18:55] <@davidb> when are tests in a jar?
- # [18:56] <@tbsaunde> davidb: locally yes, I intend to push it to try, but figured you'd head off for the weekend soon
- # [18:56] <@davidb> tbsaunde: can you explain this to me enough that i can review?
- # [18:56] <@davidb> i have a couple hours i can still get in here.
- # [18:56] <@tbsaunde> davidb: its vudu to me too
- # [18:56] <@davidb> tbsaunde: mind if i f+ and r? jmaher?
- # [18:57] <@davidb> or i could r+ conditional on try
- # [18:57] <@tbsaunde> I guess that's fine
- # [18:58] <@davidb> tbsaunde: this might not work on android
- # [18:59] <@tbsaunde> davidb: according to ehsan its pretty common in mochitest-plain
- # [18:59] <@davidb> what is?
- # [18:59] <@tbsaunde> so I assume it does
- # [18:59] <@tbsaunde> just using http:// urls to load other files external to the test
- # [19:00] <@davidb> conditional r=me
- # [19:00] <@firebot> dbolter@mozilla.com granted review for attachment 728311 on bug 853927.
- # [19:00] <@firebot> dbolter@mozilla.com requested feedback from jmaher@mozilla.com for attachment 728311 on bug 853927.
- # [19:00] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=853927 nor, --, ---, trev.saunders, NEW, test_scroll.xul can fail locally because of the weird shenanigans it does to open scroll.html
- # [19:08] <@tbsaunde> davidb: you worry to much ;)
- # [19:09] <@tbsaunde> what you you r+ or not that burns the tree is completely irrelivant ;)
- # [19:09] <@davidb> r+ shame :)
- # [19:10] <@tbsaunde> meh, we have tests and machines to run them so I don't have to do it in my head
- # [19:17] <@davidb> yeah
- # [19:18] <@davidb> when i started here it was a bigger deal to burn
- # [19:18] <@davidb> i need to wash that off
- # [19:19] <@tbsaunde> really? I've seen plenty of backed out for red etc from before 2010
- # [19:21] <@tbsaunde> so I'm careful with what I push to m-c but a good bit less so about m-i and completely not about stuff I review because that's just a waste of my time
- # [19:21] <@davidb> there used to be more complaining
- # [19:22] <@davidb> m-i has been a great great thing
- # [19:22] <@davidb> that was mconnor's baby
- # [19:22] <@davidb> which i fully endoresed
- # [19:22] <@davidb> -e
- # [19:23] <@tbsaunde> so I think we could be in largely the same position if we'd just changed the rules for m-c but whatever
- # [19:23] <@davidb> yes my default reviewing mode is 'i assume you will land with professional apprehension'
- # [19:23] <@davidb> m-c should stay unbroken
- # [19:23] <@davidb> think of it as mozilla-we-promise
- # [19:23] <@firebot> jmaher@mozilla.com granted feedback for attachment 728311 on bug 853927.
- # [19:24] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=853927 nor, --, ---, trev.saunders, NEW, test_scroll.xul can fail locally because of the weird shenanigans it does to open scroll.html
- # [19:24] <@davidb> tada!
- # [19:24] <@tbsaunde> davidb: so I'm not convinced I agree with breaking inbound is better than breaking m-c
- # [19:25] <@tbsaunde> either way you end up with bad commits in your history
- # [19:25] <@davidb> to bad that's not fixable
- # [19:25] <@davidb> to/too
- # [19:26] <@tbsaunde> yeah, in the same sense its too bad I can't get payed to live on a beach and get high all the time
- # [19:27] <@davidb> lol
- # [19:27] * Joins: victorporof (victorporo@DC82DE00.39508509.6A4F8DA2.IP)
- # [19:28] <@davidb> i could service-now some sand
- # [19:28] <@davidb> i'll file it under mercurial nits
- # [19:28] <@tbsaunde> meh
- # [19:28] <@davidb> speaking of getting beach
- # [19:28] * Quits: victorporof (victorporo@DC82DE00.39508509.6A4F8DA2.IP) (Ping timeout)
- # [19:28] <@davidb> gonna take any vacay?
- # [19:30] <@tbsaunde> maybe? need to think of something to do first
- # [19:31] <@davidb> that's a fun thought spae
- # [19:31] <@davidb> space
- # [19:34] * Quits: Justin_o (Justin_o@67828CC7.C1A51174.9D42CF23.IP) (Quit: Justin_o)
- # [19:51] <icaaq> davidb: i just tweeted you :)
- # [19:57] * Quits: Jesse (jruderman@moz-537BCF9.hsd1.ca.comcast.net) (Quit: Jesse)
- # [19:58] * Joins: Justin_o (Justin_o@67828CC7.C1A51174.9D42CF23.IP)
- # [19:59] <@davidb> icaaq: i have an email thread going with the x-components dev
- # [20:00] <@davidb> icaaq: answered
- # [20:01] <@davidb> err web components
- # [20:01] <icaaq> davidb: great :) but is it mature enough to implement today?
- # [20:01] <@davidb> icaaq: https://bugzilla.mozilla.org/show_bug.cgi?id=webcomponents
- # [20:01] <@davidb> i'd say no
- # [20:03] <icaaq> I talked to the guys in the #webmaker room and they are looking at it. or my feeling… they are implementing it ;)
- # [20:05] <@hub> tbsaunde: this test_scroll mochitest bug is bug 835338. I'll use that older bug to reenable the test once you check bug 853927 in
- # [20:05] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=835338 nor, --, ---, hub, NEW, events/test_scroll.xul time out on desktop (Mac and Linux) but not on the buildservers.
- # [20:05] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=853927 nor, --, ---, trev.saunders, NEW, test_scroll.xul can fail locally because of the weird shenanigans it does to open scroll.html
- # [20:22] <icaaq> davidb: if you have the time. could you explain the benefits of using webcomponents
- # [20:22] <@davidb> icaaq: i need to learn more about them first :)
- # [20:23] <@davidb> actually if you beat me too it we can reverse roles here :)
- # [20:23] <icaaq> davidb: heh
- # [20:23] <icaaq> yes, I'll have a look
- # [20:27] * Joins: victorporof (victorporo@DC82DE00.39508509.6A4F8DA2.IP)
- # [20:30] * Quits: victorporof (victorporo@DC82DE00.39508509.6A4F8DA2.IP) (Ping timeout)
- # [20:46] <@tbsaunde> icaaq: afaik tehy're intended to be "xbl done right"
- # [20:47] * icaaq reads http://html5-demos.appspot.com/static/webcomponents/index.html
- # [20:48] * vd is now known as vd|afk
- # [20:50] <@tbsaunde> hub: yeah, but its sometimes easier to just file another bug than go hunting
- # [20:54] <@hub> tbsaunde: no worries. btw it does not fix it on Mac
- # [20:56] * Quits: drexler (chatzilla@moz-1896B9D3.hsd1.vt.comcast.net) (Quit: ChatZilla 0.9.90-rdmsoft [XULRunner 1.9.0.17/2009122204])
- # [20:58] * Quits: yzen (Adium@AA2C085E.10C8AEF8.9A8C35B4.IP) (Quit: Leaving.)
- # [21:01] <@tbsaunde> hub: oh, that's interesting
- # [21:01] <@tbsaunde> I wonder what the failure mode is there?
- # [21:02] <@hub> tbsaunde: it does time out as it never gets the scroll event
- # [21:02] <@hub> works find on the try servers
- # [21:02] <@hub> works fine I meant
- # [21:05] <@tbsaunde> hub: but no scroll start event after the patch?
- # [21:06] <@hub> tbsaunde: before or after, no change
- # [21:08] * @tbsaunde is an idiot
- # [21:08] <@davidb> tbsaunde: i like when you say that because it is usually followed by usefulness
- # [21:08] <@tbsaunde> it should be url = "http://mochi.test:8888/a11y/accessible/..."
- # [21:09] <@tbsaunde> hah
- # [21:09] <@tbsaunde> but that usefulness has been preceeded by uselessness :(
- # [21:11] <@davidb> boy do i know how that feels
- # [21:13] <@tbsaunde> ok, the patch I meant to right is http://paste.debian.net/243777/
- # [21:13] <@tbsaunde> hub: davidb ^
- # [21:13] <@hub> tbsaunde: trying now
- # [21:14] <@tbsaunde> davidb: I bet that one will be less scary :)
- # [21:14] <@davidb> yeah
- # [21:14] <@davidb> looks like what you want
- # [21:15] * Joins: yzen (Adium@AA2C085E.10C8AEF8.9A8C35B4.IP)
- # [21:15] * Quits: yzen (Adium@AA2C085E.10C8AEF8.9A8C35B4.IP) (Quit: Leaving.)
- # [21:15] <@hub> tbsaunde: yep, this works
- # [21:19] <@davidb> ok peace out!
- # [21:19] * Quits: @davidb (davidb@F2D29657.F60B0462.67AC9B1.IP) (Quit: davidb)
- # [21:20] * Joins: yzen (Adium@AA2C085E.10C8AEF8.9A8C35B4.IP)
- # [21:28] * Joins: victorporof (victorporo@DC82DE00.39508509.6A4F8DA2.IP)
- # [21:30] * Quits: victorporof (victorporo@DC82DE00.39508509.6A4F8DA2.IP) (Ping timeout)
- # [21:32] * Quits: Justin_o (Justin_o@67828CC7.C1A51174.9D42CF23.IP) (Quit: Justin_o)
- # [21:39] * Joins: victorporof (victorporo@DC82DE00.39508509.6A4F8DA2.IP)
- # [21:42] <@firebot> hub@mozilla.com requested review from trev.saunders@gmail .com for attachment 728386 on bug 835338.
- # [21:42] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=835338 nor, --, ---, hub, NEW, events/test_scroll.xul time out on desktop (Mac and Linux) but not on the buildservers.
- # [21:50] * Quits: scott_gonzalez (scott_gonz@moz-91C81A39.hrbgpa.fios.verizon.net) (Quit: scott_gonzalez)
- # [21:56] <@firebot> trev.saunders@gmail.com granted review for attachment 728386 on bug 835338.
- # [21:56] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=835338 nor, --, ---, hub, NEW, events/test_scroll.xul time out on desktop (Mac and Linux) but not on the buildservers.
- # [22:12] * Parts: clown (clown@67828CC7.C1A51174.9D42CF23.IP)
- # [22:44] <@firebot> New Core - Disability Access APIs bug 854006 filed by eitan@monotonous.org.
- # [22:50] * Joins: scott_gonzalez (scott_gonz@moz-91C81A39.hrbgpa.fios.verizon.net)
- # [22:52] * Quits: scott_gonzalez (scott_gonz@moz-91C81A39.hrbgpa.fios.verizon.net) (Quit: scott_gonzalez)
- # [23:17] * Joins: lizzard (ehenry@moz-5A4BE8E8.dsl.static.sonic.net)
- # [23:21] * Quits: lizzard (ehenry@moz-5A4BE8E8.dsl.static.sonic.net) (Quit: lizzard)
- # [23:21] * Joins: lizzard (ehenry@moz-5A4BE8E8.dsl.static.sonic.net)
- # [23:23] * Quits: @hub (hub@F2D29657.F60B0462.67AC9B1.IP) (Ping timeout)
- # [23:31] * Quits: victorporof (victorporo@DC82DE00.39508509.6A4F8DA2.IP) (Quit: victorporof)
- # [23:46] * Quits: habber (habber@moz-8654C0B7.nyc.res.rr.com) (Quit: habber)
- # [23:47] * Joins: scott_gonzalez (scott_gonz@moz-91C81A39.hrbgpa.fios.verizon.net)
- # [23:49] * Quits: scott_gonzalez (scott_gonz@moz-91C81A39.hrbgpa.fios.verizon.net) (Quit: scott_gonzalez)
- # Session Close: Sat Mar 23 00:00:01 2013
The end :)