/irc-logs / mozilla / #accessibility / 2013-05-27 / end

Options:

  1. # Session Start: Mon May 27 00:00:00 2013
  2. # Session Ident: #accessibility
  3. # [00:30] * Quits: scott_gonzalez (scott_gonz@moz-91C81A39.hrbgpa.fios.verizon.net) (Quit: scott_gonzalez)
  4. # [00:30] * Joins: scott_gonzalez (scott_gonz@moz-91C81A39.hrbgpa.fios.verizon.net)
  5. # [00:31] * Quits: scott_gonzalez (scott_gonz@moz-91C81A39.hrbgpa.fios.verizon.net) (No route to host)
  6. # [00:32] * Joins: scott_gonzalez (scott_gonz@moz-91C81A39.hrbgpa.fios.verizon.net)
  7. # [00:35] * Joins: maxli (maxli@C03F2759.C70D537E.2FA4EA88.IP)
  8. # [00:52] * Quits: scott_gonzalez (scott_gonz@moz-91C81A39.hrbgpa.fios.verizon.net) (Quit: scott_gonzalez)
  9. # [01:54] * Joins: surkov (surkov@4F778CCB.95871A73.E17943EE.IP)
  10. # [01:54] * ChanServ sets mode: +o surkov
  11. # [02:02] * Quits: webatou (Instantbir@455F2973.12C6E01D.BF9F5BB8.IP) (Client exited)
  12. # [02:25] <@firebot> surkov.alexander@gmail.com cancelled review?(surkov.alexander@gm ail.com) for attachment 749877 on bug 448235.
  13. # [02:25] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=448235 nor, --, ---, trev.saunders, NEW, Thunderbird replied and forwarded states not exposed via AT-SPI
  14. # [02:26] * Quits: maxli (maxli@C03F2759.C70D537E.2FA4EA88.IP) (Connection reset by peer)
  15. # [02:26] * Joins: maxli (maxli@C03F2759.C70D537E.2FA4EA88.IP)
  16. # [02:38] * Quits: maxli (maxli@C03F2759.C70D537E.2FA4EA88.IP) (Quit: Leaving.)
  17. # [03:19] <@firebot> surkov.alexander@gmail.com granted review for attachment 753917 on bug 869806.
  18. # [03:19] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=869806 nor, --, ---, trev.saunders, NEW, fix asserts in actions/test_link.html
  19. # [03:49] * khuey|away is now known as khuey|tw
  20. # [04:59] * Quits: @surkov (surkov@4F778CCB.95871A73.E17943EE.IP) (Quit: surkov)
  21. # [05:26] * Joins: darkowlzz (sunny@6C736F0.C79D8377.27560D6E.IP)
  22. # [05:52] * Joins: surkov (surkov@4F778CCB.95871A73.E17943EE.IP)
  23. # [05:52] * ChanServ sets mode: +o surkov
  24. # [05:57] * Joins: scott_gonzalez (scott_gonz@moz-91C81A39.hrbgpa.fios.verizon.net)
  25. # [06:43] * Quits: scott_gonzalez (scott_gonz@moz-91C81A39.hrbgpa.fios.verizon.net) (Quit: scott_gonzalez)
  26. # [06:54] * Quits: fxa90id (fxa90id@moz-A3D5C6C0.dsl.dynamic.t-mobile.pl) (Ping timeout)
  27. # [07:20] * Quits: peteb-away (ptbrunet@moz-B51E1692.austin.res.rr.com) (Client exited)
  28. # [07:23] * Joins: icaaq (Adium@moz-C35543CE.cust.bredbandsbolaget.se)
  29. # [08:07] * Quits: @surkov (surkov@4F778CCB.95871A73.E17943EE.IP) (Connection reset by peer)
  30. # [08:08] * Joins: surkov (surkov@4F778CCB.95871A73.E17943EE.IP)
  31. # [08:08] * ChanServ sets mode: +o surkov
  32. # [08:11] * Quits: @surkov (surkov@4F778CCB.95871A73.E17943EE.IP) (Connection reset by peer)
  33. # [08:11] * Joins: surkov (surkov@4F778CCB.95871A73.E17943EE.IP)
  34. # [08:11] * ChanServ sets mode: +o surkov
  35. # [08:28] * Quits: @surkov (surkov@4F778CCB.95871A73.E17943EE.IP) (Quit: surkov)
  36. # [09:01] * Joins: SteveF (chatzilla@moz-3F778890.cable.virginmedia.com)
  37. # [09:34] * Quits: darkowlzz (sunny@6C736F0.C79D8377.27560D6E.IP) (Ping timeout)
  38. # [10:38] * Joins: surkov (surkov@4F778CCB.95871A73.E17943EE.IP)
  39. # [10:38] * ChanServ sets mode: +o surkov
  40. # [11:15] * Quits: SteveF (chatzilla@moz-3F778890.cable.virginmedia.com) (Ping timeout)
  41. # [11:39] * Joins: darkowlzz (sunny@46637F10.78C09A82.27560D6E.IP)
  42. # [11:43] * Joins: SteveF (chatzilla@moz-3F778890.cable.virginmedia.com)
  43. # [12:01] * Quits: darkowlzz (sunny@46637F10.78C09A82.27560D6E.IP) (Quit: Leaving)
  44. # [12:23] * khuey|tw is now known as khuey|away
  45. # [13:00] * Quits: brambles (xymox@moz-969AAE9B.barwen.ch) (Ping timeout)
  46. # [13:01] * Joins: brambles (xymox@moz-969AAE9B.barwen.ch)
  47. # [13:19] * Joins: darkowlzz (sunny@4505BF9D.375996AE.27560D6E.IP)
  48. # [13:24] * khuey|away is now known as khuey|tw
  49. # [13:37] * Quits: darkowlzz (sunny@4505BF9D.375996AE.27560D6E.IP) (Ping timeout)
  50. # [13:38] * Quits: @surkov (surkov@4F778CCB.95871A73.E17943EE.IP) (Quit: surkov)
  51. # [13:41] * Joins: darkowlzz (sunny@3D485BB8.AA38B91B.25B273F5.IP)
  52. # [13:43] * Joins: rednaks (rednaks@3A7FD89C.AEAA42A2.55FFA9B4.IP)
  53. # [13:51] <darkowlzz> could anyone help me with this bug https://bugzilla.mozilla.org/show_bug.cgi?id=846185 ?
  54. # [13:51] <@firebot> Bug 846185 nor, --, ---, nobody, NEW, get rid of nsIAccessibleProvider
  55. # [13:52] <@tbsaunde> darkowlzz: what do you want to know?
  56. # [13:53] <darkowlzz> from comment 2, how do I make |nsAccessibilityService::CreateAccessibleByType| check @role attribute
  57. # [13:55] <darkowlzz> pointer to example code or some docs?
  58. # [14:00] <darkowlzz> tbsaunde, any clue?
  59. # [14:06] * Joins: scott_gonzalez (scott_gonz@moz-91C81A39.hrbgpa.fios.verizon.net)
  60. # [14:12] <@tbsaunde> darkowlzz: content->GetAttribute()
  61. # [14:14] <@tbsaunde> darkowlzz: look at accessible/src/base/ARIAMap.cpp:729 for an example
  62. # [14:15] <darkowlzz> tbsaunde, lemme see, thanks :)
  63. # [14:18] <darkowlzz> tbsaunde, okay, that makes some sense. Will read what's happening and come back
  64. # [14:22] * darkowlzz is now known as darkowlzz|afk
  65. # [14:34] * khuey|tw is now known as khuey|away
  66. # [14:39] * Joins: maxli (maxli@F2D29657.F60B0462.67AC9B1.IP)
  67. # [15:21] * khuey|away is now known as khuey|tw
  68. # [15:30] * Joins: yzen (Adium@AA2C085E.10C8AEF8.9A8C35B4.IP)
  69. # [15:48] * Joins: peteb-away (ptbrunet@moz-B51E1692.austin.res.rr.com)
  70. # [15:49] * Joins: davidb (davidb@F2D29657.F60B0462.67AC9B1.IP)
  71. # [15:49] * ChanServ sets mode: +qo davidb davidb
  72. # [15:50] <@davidb> heyo
  73. # [15:56] * Joins: timeless (uid4015@moz-C944F5EC.irccloud.com)
  74. # [16:34] * khuey|tw is now known as khuey|away
  75. # [16:54] * Joins: victorporof (victorporo@DE2B5DEF.67CDC207.79933D60.IP)
  76. # [17:09] <@davidb> tbsaunde: 1:1?
  77. # [17:14] * Quits: brambles (xymox@moz-969AAE9B.barwen.ch) (Ping timeout)
  78. # [17:14] * Joins: brambles (xymox@moz-969AAE9B.barwen.ch)
  79. # [17:14] <@tbsaunde> davidb: sure, now?
  80. # [17:18] <@davidb> tbsaunde: oh sorry i went for a stretch yeah now. coming over
  81. # [17:32] * darkowlzz|afk is now known as darkowlzz
  82. # [17:52] * Joins: darkowlzzzz (sunny@1F79C15F.C1BCE42C.F44414AF.IP)
  83. # [17:53] * Quits: darkowlzz (sunny@3D485BB8.AA38B91B.25B273F5.IP) (Ping timeout)
  84. # [17:54] * darkowlzzzz is now known as darkowlzz
  85. # [17:55] * Joins: yzen1 (Adium@AA2C085E.10C8AEF8.9A8C35B4.IP)
  86. # [17:55] * Quits: yzen (Adium@AA2C085E.10C8AEF8.9A8C35B4.IP) (Ping timeout)
  87. # [18:16] <@firebot> ttaubert@mozilla.com requested review from jaws@mozilla.com for attachment 754492 on bug 794041.
  88. # [18:16] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=794041 nor, --, ---, ttaubert, ASSI, nsAccDocManager shouldn't create a RootAccessible for the hiddenWindow
  89. # [18:17] <icaaq> davidb SteveF I've forgotten where I read something about how to markup a search form, and not to make it to verbose. does it ring a bell?
  90. # [18:18] <icaaq> i thought it was on tink but I cant find it :(
  91. # [18:31] * Quits: darkowlzz (sunny@1F79C15F.C1BCE42C.F44414AF.IP) (Ping timeout)
  92. # [18:45] * Joins: darkowlzz (sunny@2A889560.4BBF4313.27560D6E.IP)
  93. # [18:59] <@davidb> icaaq: i'd have to go looking sorry
  94. # [19:10] <@firebot> New Core - Disability Access APIs bug 876475 filed by maxli@maxli.ca.
  95. # [19:10] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=876475 nor, --, ---, maxli, NEW, [AccessFu] Make braille output less verbose
  96. # [19:21] * Joins: darkowlzzzz (sunny@7F9480CA.F373EC37.F44414AF.IP)
  97. # [19:22] * Quits: darkowlzz (sunny@2A889560.4BBF4313.27560D6E.IP) (Ping timeout)
  98. # [19:22] * darkowlzzzz is now known as darkowlzz
  99. # [19:35] <darkowlzz> tbsaunde, ping!
  100. # [19:40] <@tbsaunde> darkowlzz: pong
  101. # [19:42] <darkowlzz> tbsaunde, hi
  102. # [19:42] <darkowlzz> bug 846185
  103. # [19:42] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=846185 nor, --, ---, nobody, NEW, get rid of nsIAccessibleProvider
  104. # [19:42] <darkowlzz> after reading the code, I have some ideas now
  105. # [19:42] <darkowlzz> change mxr.mozilla.org/mozilla-central/source/accessible/src/base/nsAccessibilityService.cpp#1025
  106. # [19:43] <darkowlzz> with nsAutoString roles;
  107. # [19:43] <darkowlzz> 1138 aContent->GetAttr(kNameSpaceID_None, nsGkAtoms::role, roles);
  108. # [19:43] <darkowlzz> ^ ignore the number
  109. # [19:44] <darkowlzz> now, I am not sure what I should be doing with mxr.mozilla.org/mozilla-central/source/accessible/src/base/nsAccessibilityService.cpp#1025
  110. # [19:44] <darkowlzz> should I use |GetAccessibleType| on role?
  111. # [19:44] <darkowlzz> *roles
  112. # [19:46] <@tbsaunde> darkowlzz: no, you shouldn't be changing that at all
  113. # [19:46] <darkowlzz> oh!
  114. # [19:46] <darkowlzz> is the 1st change correct?
  115. # [19:46] <@tbsaunde> darkowlzz: just change CreateAccessibleByType()
  116. # [19:46] <@tbsaunde> I'm not sure what the first is
  117. # [19:47] <darkowlzz> oh! I have been giving you wrong links
  118. # [19:48] <darkowlzz> 1st change I made is here http://mxr.mozilla.org/mozilla-central/source/accessible/src/base/nsAccessibilityService.cpp#1137
  119. # [19:48] <darkowlzz> which is CreateAccessibleByType
  120. # [19:48] <darkowlzz> I declared, nsAutoString roles
  121. # [19:48] <darkowlzz> and then replaced line 1137 by
  122. # [19:48] <darkowlzz> aContent->GetAttr(kNameSpaceID_None, nsGkAtoms::role, roles);
  123. # [19:50] <darkowlzz> tbsaunde, and I am not sure if I should change line 1142 accordingly
  124. # [19:50] <darkowlzz> like doing |GetAccessibleType| on |roles|
  125. # [19:55] <darkowlzz> tbsaunde, now it looks like if we get rid of |nsIAccessibleProvider|, even this file should be changed
  126. # [19:56] * Quits: yzen1 (Adium@AA2C085E.10C8AEF8.9A8C35B4.IP) (Quit: Leaving.)
  127. # [19:56] * Joins: yzen (Adium@AA2C085E.10C8AEF8.9A8C35B4.IP)
  128. # [19:57] <darkowlzz> http://mxr.mozilla.org/mozilla-central/source/accessible/public/nsIAccessibleProvider.idl
  129. # [19:57] <@tbsaunde> darkowlzz: that file should go away
  130. # [19:57] <@tbsaunde> darkowlzz: you absolutely have to change line 1142
  131. # [19:58] <@tbsaunde> darkowlzz: you need to compare role to strings for each of the constants in that idl
  132. # [19:58] <darkowlzz> tbsaunde, roles->GetAccessibleType(&type) would work?
  133. # [19:58] <darkowlzz> oh!
  134. # [19:59] <@tbsaunde> darkowlzz: how could that possibly work strings have no such method
  135. # [19:59] <darkowlzz> so the roles, received from |GetAttr| should be compared with each of the constants in that idl
  136. # [20:00] <@tbsaunde> no, with strings that have equivelent meaning
  137. # [20:01] <darkowlzz> equivalent meaning in the sense?
  138. # [20:01] <@tbsaunde> huh?
  139. # [20:01] <darkowlzz> and where should the constants be transferred? should I hard code the constants in the current file?
  140. # [20:02] <@tbsaunde> I guess, the only other place they'll be used is the xbl xml stuff and there's no easy way to share between those afaik
  141. # [20:08] <darkowlzz> tbsaunde, could anything be done right now, other than commenting and waiting for surkov ?
  142. # [20:08] <darkowlzz> anyone who would know what to do?
  143. # [20:09] <@firebot> yura.zenevich@gmail.com requested review from eitan@monotonous.or g for attachment 754530 on bug 845870.
  144. # [20:09] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=845870 nor, --, ---, yura.zenevich, NEW, [AccessFu] Trust explicitly associated names when speaking certain elements
  145. # [20:13] <@tbsaunde> darkowlzz: do about what?
  146. # [20:14] <darkowlzz> I mean, what should be done with the .idl file
  147. # [20:14] <darkowlzz> where should the contents be moved
  148. # [20:15] <@tbsaunde> darkowlzz: there'll be literal strings in place of the stuff in the idl
  149. # [20:16] <darkowlzz> yes, there are
  150. # [20:17] <@tbsaunde> darkowlzz: not sure what you mean
  151. # [20:18] <darkowlzz> no, see, we have to remove nsIAccessibleProvider.idl, right?
  152. # [20:18] <darkowlzz> tbsaunde, ^
  153. # [20:18] <@tbsaunde> darkowlzz: yes, that is what I said
  154. # [20:18] <darkowlzz> nsIAccessibleProvider.idl has some constants
  155. # [20:18] <darkowlzz> if we remove it, won't we need those constants?
  156. # [20:19] <@tbsaunde> darkowlzz: no, you need to replace there usage with literal stings in the source like I said a few lines up
  157. # [20:20] <darkowlzz> oh!
  158. # [20:23] <darkowlzz> so in the switch cases, each of the cases could get rid of nsIAccessibleProvider and be just the original literals?
  159. # [20:23] <darkowlzz> tbsaunde, ^
  160. # [20:29] * Quits: victorporof (victorporo@DE2B5DEF.67CDC207.79933D60.IP) (Quit: victorporof)
  161. # [20:32] <@tbsaunde> darkowlzz: I'm not sure what you mean by that
  162. # [20:33] <darkowlzz> tbsaunde, okay, could you guide me how to get rid of nsIAccessibleProvider?
  163. # [20:35] <@tbsaunde> darkowlzz: have you read comment 2 in the bug?
  164. # [20:35] <darkowlzz> yes
  165. # [20:35] <@tbsaunde> darkowlzz: then what's unclear?
  166. # [20:35] <darkowlzz> it says to make it check role attribute
  167. # [20:36] <darkowlzz> so I get the roles using |aContent->GetAttr|
  168. # [20:36] <@tbsaunde> yes
  169. # [20:37] <darkowlzz> now roles should be checked in the switch case
  170. # [20:37] <darkowlzz> switch-case has nsIAccessibleProvider cases, and we have to get rid of them
  171. # [20:38] <darkowlzz> currently, the cases are like, nsIAccessibleProvider::XULAlert, what should I replace them with?
  172. # [20:39] <@tbsaunde> darkowlzz: role.EqualsLiteral("xulalert")
  173. # [20:40] <@tbsaunde> well I guess "XULAlert" would be better
  174. # [20:40] <darkowlzz> ah! okay
  175. # [20:41] <darkowlzz> role is a string, how do I replace this line http://mxr.mozilla.org/mozilla-central/source/accessible/src/base/nsAccessibilityService.cpp#1142 ?
  176. # [20:42] <darkowlzz> GetAccessibleType would work on nsIAccessibleProviders but we have a string now
  177. # [20:46] <@tbsaunde> you just compare the string against the possible values it can have you don't need that line
  178. # [20:47] <darkowlzz> ah! okay :)
  179. # [20:56] * Joins: fxa90id (fxa90id@moz-1B295DB2.dsl.dynamic.t-mobile.pl)
  180. # [20:57] <yzen> eeejay: ping
  181. # [20:57] <@firebot> ttaubert@mozilla.com cancelled review?(jaws@mozilla.com) for attachment 754492 on bug 794041.
  182. # [20:57] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=794041 nor, --, ---, ttaubert, ASSI, nsAccDocManager shouldn't create a RootAccessible for the hiddenWindow
  183. # [21:20] * Quits: rednaks (rednaks@3A7FD89C.AEAA42A2.55FFA9B4.IP) (Quit: Téléportation !)
  184. # [21:21] <@davidb> hg qdiff |less
  185. # [21:21] <@davidb> sigh
  186. # [21:21] <@davidb> sorry
  187. # [21:23] * Joins: rednaks (rednaks@3A7FD89C.AEAA42A2.55FFA9B4.IP)
  188. # [21:47] <darkowlzz> tbsaunde, thanks, will be back soon :)
  189. # [21:48] * darkowlzz is now known as darkowlzz|zZz
  190. # [21:55] * Quits: SteveF (chatzilla@moz-3F778890.cable.virginmedia.com) (Ping timeout)
  191. # [22:22] <@tbsaunde> man, it would be really nice if a running build didn't make facebook go from seriously annoying to completely unusable
  192. # [22:23] * @tbsaunde shake fist
  193. # [22:23] <@davidb> lots of dom churn
  194. # [22:30] <@tbsaunde> davidb: sure, but I restarted firefox and it was still bad and then wait and it got much better (while the build is still going)
  195. # [22:30] * @tbsaunde shakes fist more at things he doesn't understand
  196. # [22:31] <@davidb> yeah
  197. # [22:31] <@tbsaunde> like always slow would be fine atleast I can profile that easily
  198. # [22:32] <@davidb> tbsaunde: single tab?
  199. # [22:32] <@davidb> i can look into it this week
  200. # [22:32] <@tbsaunde> davidb: not nearly
  201. # [22:32] <@davidb> heh
  202. # [22:32] <@davidb> ok i gotta relocate
  203. # [22:33] <@tbsaunde> davidb: if I thought it would be useful I'd just do it :)
  204. # [22:33] <@davidb> yeah
  205. # [22:33] <@davidb> ok
  206. # [22:33] <@davidb> ok catch y'all later
  207. # [22:35] * Quits: @davidb (davidb@F2D29657.F60B0462.67AC9B1.IP) (Ping timeout)
  208. # [22:37] * Joins: luffa (chatzilla@404323AA.E908E8BE.91FC25CA.IP)
  209. # [22:38] * Quits: luffa (chatzilla@404323AA.E908E8BE.91FC25CA.IP) (Quit: Moving to the other parallel universe!)
  210. # [22:39] * Joins: luffa (chatzilla@404323AA.E908E8BE.91FC25CA.IP)
  211. # [23:01] * Quits: rednaks (rednaks@3A7FD89C.AEAA42A2.55FFA9B4.IP) (Quit: Téléportation !)
  212. # [23:13] * Quits: luffa (chatzilla@404323AA.E908E8BE.91FC25CA.IP) (Client exited)
  213. # [23:14] * Joins: luffa (chatzilla@404323AA.E908E8BE.91FC25CA.IP)
  214. # [23:20] * Quits: icaaq (Adium@moz-C35543CE.cust.bredbandsbolaget.se) (Quit: Leaving.)
  215. # [23:52] * Quits: luffa (chatzilla@404323AA.E908E8BE.91FC25CA.IP) (Ping timeout)
  216. # Session Close: Tue May 28 00:00:00 2013

The end :)