/irc-logs / mozilla / #accessibility / 2013-09-16 / end
Options:
- # Session Start: Mon Sep 16 00:00:00 2013
- # Session Ident: #accessibility
- # [00:27] * Quits: rednaks (rednaks@C9E4B479.9AEB82FE.55FFA9B4.IP) (Quit: Téléportation !)
- # [00:41] * Quits: victorporof (victorporo@6C2683EC.42B20A5F.6A4F8DA2.IP) (Quit: victorporof)
- # [00:43] * Joins: davidb-bot (uid12418@moz-31ABA2C0.irccloud.com)
- # [01:26] * Quits: @surkov (surkov@74F7CB6C.E80E6317.6BEEAEBD.IP) (Ping timeout)
- # [01:52] * khuey|away is now known as khuey
- # [02:30] * Joins: yzen (yzen@D5EB79BB.FCC4B66A.A6DC652B.IP)
- # [02:30] * Quits: yzen (yzen@D5EB79BB.FCC4B66A.A6DC652B.IP) (Quit: yzen)
- # [02:44] * Quits: erkan^ (Erkan@EF5F69DA.47EF3760.6894ADF4.IP) (Ping timeout)
- # [02:55] * khuey is now known as khuey|away
- # [02:57] * Quits: maxli (maxli@moz-A607CA26.student.cs.uwaterloo.ca) (Quit: Leaving.)
- # [02:57] * Joins: maxli (maxli@moz-A607CA26.student.cs.uwaterloo.ca)
- # [03:29] * Quits: maxli (maxli@moz-A607CA26.student.cs.uwaterloo.ca) (Quit: Leaving.)
- # [03:29] * Joins: maxli (maxli@moz-A607CA26.student.cs.uwaterloo.ca)
- # [03:34] <@firebot> roc@ocallahan.org changed the Assignee on bug 905909 from nobody@mozilla.org to roc@ocallahan.org.
- # [03:34] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=905909 nor, --, ---, roc, NEW, test_tree.xul causes infinite recursion
- # [03:47] * khuey|away is now known as khuey
- # [04:00] * Quits: maxli (maxli@moz-A607CA26.student.cs.uwaterloo.ca) (Quit: Leaving.)
- # [04:00] * Joins: maxli (maxli@moz-A607CA26.student.cs.uwaterloo.ca)
- # [04:06] * Quits: maxli (maxli@moz-A607CA26.student.cs.uwaterloo.ca) (Quit: Leaving.)
- # [04:12] * Joins: surkov (surkov@74F7CB6C.E80E6317.6BEEAEBD.IP)
- # [04:12] * ChanServ sets mode: +o surkov
- # [04:12] * Quits: @surkov (surkov@74F7CB6C.E80E6317.6BEEAEBD.IP) (Quit: surkov)
- # [04:28] * Joins: surkov (surkov@74F7CB6C.E80E6317.6BEEAEBD.IP)
- # [04:28] * ChanServ sets mode: +o surkov
- # [04:28] * Quits: @surkov (surkov@74F7CB6C.E80E6317.6BEEAEBD.IP) (Quit: surkov)
- # [04:38] * Joins: maxli (maxli@moz-A607CA26.student.cs.uwaterloo.ca)
- # [04:42] * Quits: maxli (maxli@moz-A607CA26.student.cs.uwaterloo.ca) (Ping timeout)
- # [05:19] * Joins: surkov (surkov@74F7CB6C.E80E6317.6BEEAEBD.IP)
- # [05:19] * ChanServ sets mode: +o surkov
- # [05:19] * Quits: @surkov (surkov@74F7CB6C.E80E6317.6BEEAEBD.IP) (Quit: surkov)
- # [06:34] * Quits: peteb-away (ptbrunet@moz-B51E1692.austin.res.rr.com) (Client exited)
- # [06:36] * Quits: a-865 (fmcz@moz-8F21088B.cable.mindspring.com) (Quit: ChatZilla 0.9.90.1 [SeaMonkey 2.21/20130908220903])
- # [06:41] * Quits: MrMazda (fmcz@moz-8F21088B.cable.mindspring.com) (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.18/2009082712])
- # [06:45] * khuey is now known as khuey|away
- # [06:58] * Joins: a-865 (fmcz@moz-8F21088B.cable.mindspring.com)
- # [07:29] * Joins: Jesse (jruderman@moz-537BCF9.hsd1.ca.comcast.net)
- # [07:31] * khuey|away is now known as khuey
- # [07:53] * Tomcat|afk is now known as Tomcat|sheriffduty
- # [08:55] * Joins: icaaq (Adium@moz-2EB07EA7.cust.bredbandsbolaget.se)
- # [09:17] * Joins: Gijs (gijs@moz-C11B0461.dsl.alice.nl)
- # [09:19] * Joins: marcoz (marco.zehe@moz-939293F4.dip0.t-ipconnect.de)
- # [09:20] * ChanServ sets mode: +o marcoz
- # [10:06] * Joins: victorporof (victorporo@6C2683EC.42B20A5F.6A4F8DA2.IP)
- # [10:07] * khuey is now known as khuey|away
- # [10:19] * khuey|away is now known as khuey
- # [10:34] * Joins: SteveF (chatzilla@moz-3F778890.cable.virginmedia.com)
- # [11:19] <@firebot> mozilla@baum.de cancelled needinfo?(mozilla@baum.de) on bug 894819.
- # [11:19] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=894819 nor, --, ---, nobody, UNCO, After switching page direction in the view menu, no more IAccessible2 Caret Events are fired, when y
- # [11:42] * Quits: @marcoz (marco.zehe@moz-939293F4.dip0.t-ipconnect.de) (Quit: Leaving.)
- # [11:46] * Joins: marcoz (marco.zehe@moz-939293F4.dip0.t-ipconnect.de)
- # [11:46] * ChanServ sets mode: +o marcoz
- # [12:29] * Joins: yzen (yzen@moz-E06714DD.cpe.netcabo.pt)
- # [12:39] <@firebot> roc@ocallahan.org requested review from dholbert@mozilla.co m for attachment 805230 on bug 905909.
- # [12:39] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=905909 nor, --, ---, roc, NEW, test_tree.xul causes infinite recursion
- # [14:09] * Joins: surkov (surkov@74F7CB6C.E80E6317.6BEEAEBD.IP)
- # [14:09] * ChanServ sets mode: +o surkov
- # [14:12] * khuey is now known as khuey|away
- # [14:18] * Joins: Justin_o (Justin_o@67828CC7.C1A51174.9D42CF23.IP)
- # [14:26] <@marcoz> surkov: Good morning!
- # [14:26] <@surkov> hey, marcoz
- # [14:27] <@marcoz> surkov: Regarding bug 915558, I can confirm what Jamie found, that it tends to break and un-break without a real discernable pattern. The same build that worked on Thursday and Friday was broken this morning, without having been updated or any other changes.
- # [14:27] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=915558 cri, P1, ---, nobody, REOP, XUL UI completely broken in Windows: Tabs, menus, etc.
- # [14:28] <@marcoz> surkov: That also makes finding the regression range impossible.
- # [14:28] <@surkov> die hard
- # [15:00] * Quits: yzen (yzen@moz-E06714DD.cpe.netcabo.pt) (Quit: yzen)
- # [15:25] * Joins: peteb-away (ptbrunet@moz-B51E1692.austin.res.rr.com)
- # [15:45] * Joins: davidb (davidb@13F2CEC5.7672369.D8E68FF6.IP)
- # [15:45] * ChanServ sets mode: +qo davidb davidb
- # [15:48] <@marcoz> Good morning davidb! :)
- # [15:50] * Joins: maxli (maxli@moz-A607CA26.student.cs.uwaterloo.ca)
- # [15:50] <@marcoz> Hi maxli! :)
- # [15:50] <maxli> Hi marcoz!
- # [15:52] <@davidb> heyo!
- # [16:02] * Tomcat|sheriffduty is now known as Tomcat|afk
- # [16:03] <@marcoz> davidb: Ready when you are!
- # [16:03] <@davidb> marcoz: 2 mins
- # [16:04] <@davidb> marcoz: maybe longer because i need to disconnect on the way
- # [16:04] * Quits: victorporof (victorporo@6C2683EC.42B20A5F.6A4F8DA2.IP) (Quit: victorporof)
- # [16:05] <@marcoz> davidb: Heh OK! I'm online in Skype, just ping me when you're ready, or just call yourself.
- # [16:06] * Quits: @davidb (davidb@13F2CEC5.7672369.D8E68FF6.IP) (Ping timeout)
- # [16:07] * Joins: clown (clown@67828CC7.C1A51174.9D42CF23.IP)
- # [16:07] * clown is now known as clown_mtg
- # [16:09] * Joins: davidb (davidb@FCCEA34F.7672369.D8E68FF6.IP)
- # [16:09] * ChanServ sets mode: +qo davidb davidb
- # [16:16] * Joins: jongunderson (chatzilla@moz-406FB4A4.dres.uiuc.edu)
- # [16:39] * Joins: victorporof (victorporo@CFB98BB1.77B8163B.2B3D3D4.IP)
- # [16:39] * Quits: icaaq (Adium@moz-2EB07EA7.cust.bredbandsbolaget.se) (Ping timeout)
- # [16:43] * Joins: icaaq (Adium@moz-2EB07EA7.cust.bredbandsbolaget.se)
- # [16:50] <@marcoz> Bah I hate it when missing a train so closely. Hopefully we can get bug 904687 into Gecko26 anyway. Otherwise it would throw us back to 1.3.
- # [16:50] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=904687 nor, --, ---, nobody, NEW, Introduce Pico speech synthesis service
- # [16:52] * Joins: yzen (yzen@moz-E06714DD.cpe.netcabo.pt)
- # [17:03] <@davidb> tbsaunde: hello sir. are you around?
- # [17:07] * Quits: maxli (maxli@moz-A607CA26.student.cs.uwaterloo.ca) (Quit: Leaving.)
- # [17:17] <@davidb> marcoz: there is a delay in uplift so maybe still time
- # [17:21] * Quits: davidb-bot (uid12418@moz-31ABA2C0.irccloud.com) (Quit: )
- # [17:22] <@marcoz> davidb: Heh, yeah just saw that. A bit of a race there. ;)
- # [17:23] * Joins: erkan^ (Erkan@37E2BECA.CD215376.6894ADF4.IP)
- # [17:25] <@marcoz> davidb: Wonder if I should send a note to release-drivers (separate thread) about bug 904687 in case we don't make the cut.
- # [17:25] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=904687 nor, --, ---, nobody, NEW, Introduce Pico speech synthesis service
- # [17:26] * Quits: yzen (yzen@moz-E06714DD.cpe.netcabo.pt) (Quit: yzen)
- # [17:28] * Quits: jongunderson (chatzilla@moz-406FB4A4.dres.uiuc.edu) (Client exited)
- # [17:28] * Joins: jongunderson (chatzilla@moz-406FB4A4.dres.uiuc.edu)
- # [17:30] * Quits: erkan^ (Erkan@37E2BECA.CD215376.6894ADF4.IP) (Quit: Textual IRC Client: www.textualapp.com)
- # [17:33] <@davidb> surkov: meeting time
- # [17:33] <@davidb> eeejay: meeting time
- # [17:33] <@davidb> tbsaunde: meeting time
- # [17:33] <@davidb> !seen yen
- # [17:33] <@firebot> yen was last seen 252 weeks, 2 days, 19 hours, 5 minutes and 30 seconds ago,
- # [17:33] <@davidb> !seen yzen
- # [17:33] <@firebot> yzen was last seen 4 days, 2 hours, 33 minutes and 50 seconds ago, saying 'Yoric: sounds good sure' in #developers.
- # [17:34] * Joins: rednaks (rednaks@2BFFE0C9.74C6FD40.360EF119.IP)
- # [17:35] * Quits: rednaks (rednaks@2BFFE0C9.74C6FD40.360EF119.IP) (Max SendQ exceeded)
- # [17:35] * Joins: yzen (yzen@moz-E06714DD.cpe.netcabo.pt)
- # [17:36] * Joins: rednaks (rednaks@2BFFE0C9.74C6FD40.360EF119.IP)
- # [17:36] * Quits: icaaq (Adium@moz-2EB07EA7.cust.bredbandsbolaget.se) (Ping timeout)
- # [17:37] * Joins: icaaq (Adium@moz-2EB07EA7.cust.bredbandsbolaget.se)
- # [17:38] * Joins: erkan^ (Erkan@37E2BECA.CD215376.6894ADF4.IP)
- # [17:40] * khuey|away is now known as khuey
- # [17:45] * Quits: clown_mtg (clown@67828CC7.C1A51174.9D42CF23.IP) (Quit: Leaving.)
- # [18:01] * Quits: rednaks (rednaks@2BFFE0C9.74C6FD40.360EF119.IP) (Quit: Téléportation !)
- # [18:06] * Quits: icaaq (Adium@moz-2EB07EA7.cust.bredbandsbolaget.se) (Quit: Leaving.)
- # [18:19] * Quits: @marcoz (marco.zehe@moz-939293F4.dip0.t-ipconnect.de) (Quit: Leaving.)
- # [18:21] * Joins: clown (clown@67828CC7.C1A51174.9D42CF23.IP)
- # [18:21] * Quits: clown (clown@67828CC7.C1A51174.9D42CF23.IP) (Quit: Leaving.)
- # [18:21] * Joins: clown (clown@67828CC7.C1A51174.9D42CF23.IP)
- # [18:42] <erkan^> is here special from people with disable?
- # [18:44] * Quits: MattN (MattN@A8588C62.B1B6FA80.709ED47B.IP) (Ping timeout)
- # [18:48] * Joins: MattN (MattN@A8588C62.B1B6FA80.709ED47B.IP)
- # [19:02] * Joins: james (jnurthen@moz-15DF0CD.oracle.com)
- # [19:23] <@davidb> erkan^: Sorry I'm not sure I understand your question. Could you rephrase it?
- # [19:24] <@davidb> This is the right channel to discuss features for people with disabilities.
- # [19:25] <@davidb> bah
- # [19:26] <@davidb> "Despite the tree closure on mozilla-central, we're moving forward with the Aurora to Beta merge. Central to Aurora will come later, possibly not even today. Thanks to Bhavana for modifying our merge day scripts to remove the dependency on a Central to Aurora merge."
- # [19:26] <@davidb> ohhhh not bah
- # [19:26] <@davidb> central to aurora comes later
- # [19:28] * Quits: Gijs (gijs@moz-C11B0461.dsl.alice.nl) (Quit: dinner)
- # [19:30] <erkan^> ah
- # [19:30] <erkan^> i am deaf and impaired visual, davidb
- # [19:30] <@davidb> nice to meet you
- # [19:30] <erkan^> you too, davidb
- # [19:31] <erkan^> I see addons "Noquist" that is great, but little problem
- # [19:31] <@davidb> I'm not familiar with Noquist
- # [19:31] <erkan^> I don't get still answer of dev from my email )-:
- # [19:31] * @davidb looks it up
- # [19:32] <@davidb> hmmm I can't find it
- # [19:34] * Joins: icaaq (Adium@moz-2EB07EA7.cust.bredbandsbolaget.se)
- # [19:34] <erkan^> i am searching
- # [19:34] <erkan^> i forget good spell
- # [19:35] * khuey is now known as khuey|away
- # [19:36] <erkan^> davidb: https://addons.mozilla.org/nl/firefox/addon/nosquint/
- # [19:37] <@davidb> erkan^: looks like bugs are to be reported here https://github.com/jtackaberry/nosquint/issues
- # [19:37] <@firebot> dholbert@mozilla.com granted review for attachment 805230 on bug 905909.
- # [19:38] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=905909 nor, --, ---, roc, NEW, test_tree.xul causes infinite recursion
- # [19:39] <erkan^> I want another bug, i am searching to mail
- # [19:39] <erkan^> *to my mailbox
- # [19:40] <erkan^> Dear Jason,
- # [19:40] <erkan^> NoSquint works great! But I have a problem.
- # [19:40] <erkan^> I did change: Backgrounds is black and Text is white. If I type a post on Facebook, than cannot I see what I am typing.
- # [19:40] <erkan^> Can you fix a bugs?
- # [19:40] <erkan^> Thank you and your sincerely,
- # [19:40] <erkan^> Ekrem Koç
- # [19:45] <erkan^> do you understand that, davidb ?
- # [19:46] <@davidb> erkan^: your email looks good
- # [19:46] <erkan^> yes and he doesn't answer my question :/
- # [19:46] <erkan^> i think that he has very busy
- # [19:46] <erkan^> I have never spoken with him
- # [19:47] <@davidb> probably busy yeah
- # [19:47] * Joins: victorporof_ (victorporo@CFB98BB1.77B8163B.2B3D3D4.IP)
- # [19:48] <@davidb> erkan^: the best thing would be to enter a bug at that link i sent you
- # [19:48] <@davidb> but i don't know when it would get ficed
- # [19:48] <@davidb> fixed
- # [19:48] * Quits: victorporof (victorporo@CFB98BB1.77B8163B.2B3D3D4.IP) (Ping timeout)
- # [19:48] <erkan^> that is good
- # [19:52] <erkan^> I will install this later, davidb
- # [19:53] <@davidb> good luck!
- # [19:55] * Joins: scott_gonzalez (scott_gonz@moz-8E5C24A9.hsd1.pa.comcast.net)
- # [20:11] * Joins: nhirata (anonymous@moz-BE33DA21.fw1.sfo1.mozilla.net)
- # [20:39] <@eeejay> did merge happen yet?
- # [20:36] <@davidb> eeejay: central to aurora is not yet FAIK
- # [20:36] <@eeejay> okie dokes
- # [20:37] <@davidb> possibly late today or tomorrow
- # [20:37] <@eeejay> okay, good
- # [20:37] <@eeejay> wanted to do one last try run
- # [20:40] * Quits: icaaq (Adium@moz-2EB07EA7.cust.bredbandsbolaget.se) (Quit: Leaving.)
- # [20:40] * Quits: victorporof_ (victorporo@CFB98BB1.77B8163B.2B3D3D4.IP) (Ping timeout)
- # [20:41] <@davidb> surkov: PMed ya
- # [20:53] * Joins: victorporof (victorporo@CFB98BB1.77B8163B.2B3D3D4.IP)
- # [20:53] * Joins: victorporof_ (victorporo@CFB98BB1.77B8163B.2B3D3D4.IP)
- # [20:54] * Quits: victorporof (victorporo@CFB98BB1.77B8163B.2B3D3D4.IP) (Ping timeout)
- # [21:02] * khuey|away is now known as khuey
- # [21:10] * Quits: jongunderson (chatzilla@moz-406FB4A4.dres.uiuc.edu) (Client exited)
- # [21:18] * victorporof_ is now known as victorporof
- # [21:34] * Quits: scott_gonzalez (scott_gonz@moz-8E5C24A9.hsd1.pa.comcast.net) (Quit: scott_gonzalez)
- # [21:35] * Quits: james (jnurthen@moz-15DF0CD.oracle.com) (Client exited)
- # [21:36] * Joins: rednaks (rednaks@291C9C0A.6CAC82C1.55FFA9B4.IP)
- # [21:49] * Quits: Justin_o (Justin_o@67828CC7.C1A51174.9D42CF23.IP) (Quit: Justin_o)
- # [21:53] * Quits: @davidb (davidb@FCCEA34F.7672369.D8E68FF6.IP) (Ping timeout)
- # [22:00] * khuey is now known as khuey|away
- # [22:00] * Joins: scott_gonzalez (scott_gonz@moz-91C81A39.hrbgpa.fios.verizon.net)
- # [22:02] * Joins: davidb (davidb@13F2CEC5.7672369.D8E68FF6.IP)
- # [22:02] * ChanServ sets mode: +qo davidb davidb
- # [22:08] * Quits: rednaks (rednaks@291C9C0A.6CAC82C1.55FFA9B4.IP) (Quit: Téléportation !)
- # [22:19] * Joins: sfoster (sfoster@moz-37AA60E3.hsd1.wa.comcast.net)
- # [22:27] * Quits: @davidb (davidb@13F2CEC5.7672369.D8E68FF6.IP) (Ping timeout)
- # [22:31] * Quits: yzen (yzen@moz-E06714DD.cpe.netcabo.pt) (Quit: yzen)
- # [22:34] * Quits: SteveF (chatzilla@moz-3F778890.cable.virginmedia.com) (Ping timeout)
- # [22:35] * Joins: davidb-bot (uid12418@moz-31ABA2C0.irccloud.com)
- # [22:38] <erkan^> Time Machine
- # [22:50] <@firebot> lsblakk@mozilla.com denied approval-mozilla-aurora for attachment 801722 on bug 899433.
- # [22:50] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=899433 maj, --, mozilla26, surkov.alexander, RESO FIXED, Accessibility returns empty line for last line in certain cases
- # [22:52] <@eeejay> burn!
- # [22:52] * eeejay sets mode: +o tbsaunde
- # [22:54] * Joins: james (jnurthen@moz-7DAF1A3B.oracle.com)
- # [22:54] * Quits: erkan^ (Erkan@37E2BECA.CD215376.6894ADF4.IP) (Quit: Textual IRC Client: www.textualapp.com)
- # [22:57] * Joins: erkan^ (Erkan@37E2BECA.CD215376.6894ADF4.IP)
- # [22:58] * Quits: clown (clown@67828CC7.C1A51174.9D42CF23.IP) (Quit: Leaving.)
- # [22:58] * Joins: victorporof_ (victorporo@CFB98BB1.77B8163B.2B3D3D4.IP)
- # [22:59] * Quits: victorporof (victorporo@CFB98BB1.77B8163B.2B3D3D4.IP) (Ping timeout)
- # [23:01] * Quits: victorporof_ (victorporo@CFB98BB1.77B8163B.2B3D3D4.IP) (Quit: victorporof_)
- # [23:05] * khuey|away is now known as khuey
- # [23:08] * Joins: yzen (yzen@moz-E06714DD.cpe.netcabo.pt)
- # [23:18] * Quits: erkan^ (Erkan@37E2BECA.CD215376.6894ADF4.IP) (Quit: Textual IRC Client: www.textualapp.com)
- # [23:19] * Joins: erkan^ (Erkan@37E2BECA.CD215376.6894ADF4.IP)
- # [23:26] * Joins: satdav (David@moz-2B0F19ED.cable.virginmedia.com)
- # [23:27] <satdav> is anyone able to help do a ally test
- # [23:28] * Joins: espressive (espressive@moz-B2313420.access.mtnbusiness.co.za)
- # [23:28] <satdav> eeejay, or surkov or tbsaunde you about
- # [23:28] <satdav> espressive, tbsaunde would also be good to test it as he uses a screen reader also
- # [23:29] <espressive> good stuff
- # [23:29] <satdav> fxa90id, do you fancy helping test the breakpad site for ally
- # [23:29] <espressive> I will ping in here once I feel I made anough headway
- # [23:30] <sfoster> surkov, I put a patch on bug 903866 that re-maps Metro's urlbar input to use the plain vanilla textbox binding.
- # [23:30] <@firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=903866 nor, --, ---, surkov.alexander, NEW, [MP] Defect - Soft keyboard does not display when the user taps the nav bar edit / text input(?)
- # [23:31] <sfoster> surkov, this bug is my top priority, so let me know how I can help (I am the front-end help you asked for)
- # [23:47] * Quits: james (jnurthen@moz-7DAF1A3B.oracle.com) (Client exited)
- # [23:48] * Joins: james (jnurthen@moz-7DAF1A3B.oracle.com)
- # [23:50] * Quits: a-865 (fmcz@moz-8F21088B.cable.mindspring.com) (Quit: ChatZilla 0.9.90.1 [SeaMonkey 2.21/20130908220903])
- # [23:52] * Joins: a-865 (fmcz@moz-8F21088B.cable.mindspring.com)
- # [23:54] * Joins: MrMazda (fmcz@moz-8F21088B.cable.mindspring.com)
- # [23:54] <james> Does FF expose aria-hidden in any way? I've seen some bugs which seem to imply that it will be exposed as STATE_INVISIBLE but in my testing I don't see that.
- # Session Close: Tue Sep 17 00:00:00 2013
The end :)