/irc-logs / mozilla / #accessibility / 2014-09-10 / end
Options:
- # Session Start: Wed Sep 10 00:00:01 2014
- # Session Ident: #accessibility
- # [00:02] * Quits: icaaq (icaaq@moz-396D494F.ias.bredband.telia.com) (Quit: 10-79 Notify coroner, over and out)
- # [00:15] * Joins: Jamie (Instantbir@moz-CA26021.jantrid.net)
- # [00:19] <@firebot> ktucker@qanalydocs.com changed the Component on bug 1063843 from Gaia::Browser to Disability Access APIs.
- # [00:19] <@firebot> ktucker@qanalydocs.com changed the Product on bug 1063843 from Firefox OS to Core.
- # [00:19] <@firebot> https://bugzil.la/1063843 — NEW — [Browser] When Color filter is on and contrast is set browser is cut in half in landscape
- # [00:19] * khuey is now known as khuey|away
- # [00:23] <@firebot> ktucker@qanalydocs.com set blocking-b2g to 2.1? on bug 1063843.
- # [00:27] * wlach is now known as wlach|afk
- # [00:42] * Quits: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net) (Ping timeout)
- # [00:42] * Joins: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net)
- # [00:51] <@firebot> eitan@monotonous.org changed the Assignee on bug 1062016 from nobody@mozilla.org to eitan@monotonous.org.
- # [00:51] <@firebot> https://bugzil.la/1062016 — NEW, eitan — [AccessFu] Editing state does not remain consistent with focused state of entry
- # [01:10] * Quits: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net) (Client exited)
- # [01:10] * Joins: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net)
- # [01:12] * Joins: newtron_ (newtron@moz-8A56CC3B.ip.mcleodusa.net)
- # [01:12] * Quits: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net) (Ping timeout)
- # [01:17] * Quits: jamesn (jnurthen@moz-F1E6EF59.oracle.com) (Ping timeout)
- # [01:31] * Quits: newtron_ (newtron@moz-8A56CC3B.ip.mcleodusa.net) (Client exited)
- # [01:31] * Joins: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net)
- # [01:33] * Quits: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net) (Ping timeout)
- # [02:22] * Quits: Justin_o (uid14648@moz-E77DEB21.irccloud.com) (Quit: Connection closed for inactivity)
- # [02:26] * khuey|away is now known as khuey
- # [02:41] * Joins: jamesn (jnurthen@moz-9D5C2F29.oracle.com)
- # [02:45] * Joins: surkov (surkov@moz-DF24A6EA.cpe.pppoe.ca)
- # [02:45] * ChanServ sets mode: +o surkov
- # [02:55] * Quits: jamesn (jnurthen@moz-9D5C2F29.oracle.com) (Client exited)
- # [03:00] * Quits: @surkov (surkov@moz-DF24A6EA.cpe.pppoe.ca) (Quit: surkov)
- # [03:03] * Joins: surkov (surkov@moz-DF24A6EA.cpe.pppoe.ca)
- # [03:03] * ChanServ sets mode: +o surkov
- # [03:24] * Joins: yzen (yzen@moz-F62769B5.cpe.pppoe.ca)
- # [03:24] * ChanServ sets mode: +o yzen
- # [03:27] * Joins: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net)
- # [03:28] * Quits: @yzen (yzen@moz-F62769B5.cpe.pppoe.ca) (Connection reset by peer)
- # [03:28] * Joins: yzen (yzen@moz-F62769B5.cpe.pppoe.ca)
- # [03:28] * ChanServ sets mode: +o yzen
- # [03:32] * Joins: yliao (yliao@moz-99690620.hinet-ip.hinet.net)
- # [03:33] * Quits: @yzen (yzen@moz-F62769B5.cpe.pppoe.ca) (Ping timeout)
- # [03:44] * Quits: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net) (Ping timeout)
- # [03:45] * Joins: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net)
- # [04:08] * Joins: yzen (yzen@moz-F62769B5.cpe.pppoe.ca)
- # [04:08] * ChanServ sets mode: +o yzen
- # [04:14] * Quits: @yzen (yzen@moz-F62769B5.cpe.pppoe.ca) (Ping timeout)
- # [04:40] * Quits: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net) (Ping timeout)
- # [04:41] * Joins: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net)
- # [04:45] * Quits: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net) (Ping timeout)
- # [04:46] * Joins: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net)
- # [04:49] * Quits: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net) (Ping timeout)
- # [04:51] * Joins: yzen (yzen@moz-F62769B5.cpe.pppoe.ca)
- # [04:51] * ChanServ sets mode: +o yzen
- # [04:56] * Joins: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net)
- # [04:57] * Quits: yliao (yliao@moz-99690620.hinet-ip.hinet.net) (Client exited)
- # [04:58] * Quits: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net) (Ping timeout)
- # [04:58] * Joins: yliao (yliao@moz-99690620.hinet-ip.hinet.net)
- # [05:04] * Quits: @yzen (yzen@moz-F62769B5.cpe.pppoe.ca) (Ping timeout)
- # [05:05] * Quits: yliao (yliao@moz-99690620.hinet-ip.hinet.net) (Client exited)
- # [05:06] * Joins: yliao (yliao@moz-99690620.hinet-ip.hinet.net)
- # [05:08] * Joins: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net)
- # [05:12] * Quits: @surkov (surkov@moz-DF24A6EA.cpe.pppoe.ca) (Quit: surkov)
- # [05:12] * khuey is now known as khuey|away
- # [05:17] * Joins: yzen (yzen@moz-F62769B5.cpe.pppoe.ca)
- # [05:17] * ChanServ sets mode: +o yzen
- # [05:21] * Quits: @yzen (yzen@moz-F62769B5.cpe.pppoe.ca) (Ping timeout)
- # [05:38] * Quits: yliao (yliao@moz-99690620.hinet-ip.hinet.net) (Client exited)
- # [05:38] * Joins: yliao (yliao@moz-E37F359D.hinet-ip.hinet.net)
- # [05:41] * Quits: yliao (yliao@moz-E37F359D.hinet-ip.hinet.net) (Client exited)
- # [05:42] * Joins: maxli (maxli@moz-F47DD19B.student.cs.uwaterloo.ca)
- # [05:42] * Joins: yliao (yliao@moz-E37F359D.hinet-ip.hinet.net)
- # [05:47] * Quits: yliao (yliao@moz-E37F359D.hinet-ip.hinet.net) (Client exited)
- # [05:49] * Quits: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net) (Ping timeout)
- # [05:56] * Joins: yliao (yliao@moz-E37F359D.hinet-ip.hinet.net)
- # [06:01] * Joins: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net)
- # [06:35] * Quits: Jamie (Instantbir@moz-CA26021.jantrid.net) (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
- # [06:38] * Quits: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net) (Connection reset by peer)
- # [07:32] * Joins: dij (Mibbit@9B9315E1.A6025CA.1C37C358.IP)
- # [07:42] * Quits: MattN (MattN@A8588C62.B1B6FA80.709ED47B.IP) (Ping timeout)
- # [07:43] * Joins: MattN (MattN@A8588C62.B1B6FA80.709ED47B.IP)
- # [08:03] * Joins: icaaq (icaaq@moz-3F40A4C4.cust.telenor.se)
- # [08:33] * Quits: maxli (maxli@moz-F47DD19B.student.cs.uwaterloo.ca) (Quit: Leaving.)
- # [08:59] * Quits: icaaq (icaaq@moz-3F40A4C4.cust.telenor.se) (Ping timeout)
- # [09:23] * Joins: icaaq (icaaq@moz-4595FE6F.creuna.se)
- # [10:02] * Joins: ioanachiorean (ioanachior@6DC7A5F5.AA1FA0D2.6A4F8DA2.IP)
- # [10:07] * Joins: slee (chatzilla@moz-F3E9DB28.gotadsl.co.uk)
- # [10:21] * Joins: agibson (agibson@moz-2C643250.gate.cable.virginm.net)
- # [10:25] * Quits: dij (Mibbit@9B9315E1.A6025CA.1C37C358.IP) (Quit: http://www.mibbit.com ajax IRC Client)
- # [10:51] * Quits: icaaq (icaaq@moz-4595FE6F.creuna.se) (Connection reset by peer)
- # [10:51] * Joins: icaaq (icaaq@moz-4595FE6F.creuna.se)
- # [10:56] * Joins: dij (Mibbit@9B9315E1.A6025CA.1C37C358.IP)
- # [11:15] * Quits: slee (chatzilla@moz-F3E9DB28.gotadsl.co.uk) (Quit: ChatZilla 0.9.90.1 [Firefox 33.0/20140902214533])
- # [11:16] * Joins: slee (chatzilla@moz-F3E9DB28.gotadsl.co.uk)
- # [11:52] * Joins: Gijs (gijs@moz-D2B81DF.range86-173.btcentralplus.com)
- # [12:10] * Joins: API (api@moz-75739B3B.igalia.com)
- # [12:31] * Quits: yliao (yliao@moz-E37F359D.hinet-ip.hinet.net) (Client exited)
- # [12:51] * Quits: API (api@moz-75739B3B.igalia.com) (Ping timeout)
- # [12:55] * agibson is now known as agibson|afk
- # [13:09] * Joins: API (api@moz-75739B3B.igalia.com)
- # [13:21] * Joins: surkov (surkov@moz-DF24A6EA.cpe.pppoe.ca)
- # [13:21] * ChanServ sets mode: +o surkov
- # [13:27] * Joins: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net)
- # [13:45] * Joins: yzen (yzen@moz-F62769B5.cpe.pppoe.ca)
- # [13:45] * ChanServ sets mode: +o yzen
- # [13:46] * Joins: MarcoZ (marco.zehe@moz-ABCBD7A6.dip0.t-ipconnect.de)
- # [13:46] * ChanServ sets mode: +ao MarcoZ MarcoZ
- # [13:53] <@firebot> mzehe@mozilla.com requested needinfo from mzehe@mozilla.com on bug 1064883.
- # [13:53] <@firebot> https://bugzil.la/1064883 — NEW — Quick navigation letters sometimes don't work when entered on a braille display
- # [13:56] * Quits: @yzen (yzen@moz-F62769B5.cpe.pppoe.ca) (Ping timeout)
- # [13:57] * Quits: agibson|afk (agibson@moz-2C643250.gate.cable.virginm.net) (Client exited)
- # [14:03] * Quits: icaaq (icaaq@moz-4595FE6F.creuna.se) (Quit: 10-79 Notify coroner, over and out)
- # [14:03] * Joins: agibson (agibson@moz-2C643250.gate.cable.virginm.net)
- # [14:12] * khuey|away is now known as khuey
- # [14:19] * Joins: yliao (yliao@moz-D5CB3E1F.dynamic.hinet.net)
- # [14:24] * Joins: icaaq (icaaq@D2069856.FE797095.222B27F0.IP)
- # [14:24] * Quits: icaaq (icaaq@D2069856.FE797095.222B27F0.IP) (Client exited)
- # [14:27] * Quits: yliao (yliao@moz-D5CB3E1F.dynamic.hinet.net) (Client exited)
- # [14:28] * Joins: icaaq (icaaq@D2069856.FE797095.222B27F0.IP)
- # [14:32] * Quits: icaaq (icaaq@D2069856.FE797095.222B27F0.IP) (Quit: 10-79 Notify coroner, over and out)
- # [14:33] * Joins: yliao (yliao@moz-D5CB3E1F.dynamic.hinet.net)
- # [14:38] * Quits: khuey (khuey@moz-DB4A9C19.scl3.mozilla.com) (Ping timeout)
- # [14:39] * Joins: khuey (khuey@moz-DB4A9C19.scl3.mozilla.com)
- # [14:39] * Joins: yzen (yzen@13F2CEC5.7672369.D8E68FF6.IP)
- # [14:39] * ChanServ sets mode: +o yzen
- # [14:40] * Quits: yliao (yliao@moz-D5CB3E1F.dynamic.hinet.net) (Ping timeout)
- # [14:41] * Joins: Justin_o (uid14648@moz-E77DEB21.irccloud.com)
- # [14:42] * Joins: icaaq (icaaq@D2069856.FE797095.222B27F0.IP)
- # [14:43] * Joins: anvk (anovak@C141829F.3923648E.6468E038.IP)
- # [14:44] <@yzen> morning MarcoZ
- # [14:57] * Joins: slee_ (chatzilla@moz-CF8D1B29.range81-154.btcentralplus.com)
- # [14:57] * Quits: slee (chatzilla@moz-F3E9DB28.gotadsl.co.uk) (Ping timeout)
- # [14:57] * slee_ is now known as slee
- # [14:59] <@firebot> cbook@mozilla.com changed the Resolution on bug 1062016 from --- to FIXED.
- # [14:59] <@firebot> cbook@mozilla.com changed the Status on bug 1062016 from NEW to RESOLVED.
- # [14:59] <@firebot> cbook@mozilla.com changed the Target Milestone on bug 1062016 from --- to mozilla35.
- # [14:59] <@MarcoZ> Morning yzen!
- # [14:59] <@firebot> https://bugzil.la/1062016 — FIXED, eitan — [AccessFu] Editing state does not remain consistent with focused state of entry
- # [15:05] * Quits: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net) (Quit: Leaving...)
- # [15:13] <@MarcoZ> yzen: Veeeery nice change to the status bar re the audio channel! This one works much much smoother now in the latest Aurora nightly (2.1)
- # [15:14] <@yzen> MarcoZ awesome, also just landed contacts app a11y imrovements
- # [15:14] <@MarcoZ> yzen: Also, the keyboard now interacts very much better with the PIN entry. Even when eeejay's editing mode patch hasn't landed yet.
- # [15:14] <@yzen> s/imrovements/improvements
- # [15:14] <@MarcoZ> yzen: Yeah I saw that!
- # [15:15] <@MarcoZ> We seem to getting good approvals for these patches for 2.1 too, no fights.
- # [15:15] <@MarcoZ> +be
- # [15:15] * Quits: slee (chatzilla@moz-CF8D1B29.range81-154.btcentralplus.com) (Ping timeout)
- # [15:15] <@yzen> MarcoZ yep, 1 b2g 2.1 bug left, hopefully it will get reviewed soon and approved
- # [15:16] <@yzen> MarcoZ plus the status bar
- # [15:16] <@yzen> i will land it shortly i think
- # [15:16] <@yzen> well today at least :)
- # [15:17] * Joins: slee (chatzilla@moz-CF8D1B29.range81-154.btcentralplus.com)
- # [15:19] * Quits: slee (chatzilla@moz-CF8D1B29.range81-154.btcentralplus.com) (Ping timeout)
- # [15:34] <tbsaunde> surkov: seems bug 1020039 is happening a lot, please look at it ;)
- # [15:34] <@firebot> https://bugzil.la/1020039 — NEW — Intermittent relations/test_embeds.xul | Can't get accessible for [object XULElement]
- # [15:42] <@MarcoZ> yzen: Which is the one that's still left besides the status bar?
- # [15:42] <@MarcoZ> yzen: And awesome work on that status bar, btw! Great you could pick up Vivien's patch so easily and finish it!
- # [15:42] <@yzen> MarcoZ the order of icons is reversed , bug 1014052
- # [15:42] <@firebot> https://bugzil.la/1014052 — ASSIGNED, yzenevich — [Status bar Accessibility] The swiping order of items is reversed
- # [15:43] * Joins: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net)
- # [15:46] <@MarcoZ> yzen: Awesome!
- # [15:47] <@yzen> MarcoZ :)
- # [15:47] <@MarcoZ> Phew, that didn't take as long as I feared it would with all those bugs. Suddenly it all came together.
- # [15:47] * Quits: logbot (logbot@moz-58CB32ED.glob.com.au) (Ping timeout)
- # [15:48] <@MarcoZ> We may still want/have to port some AccessFu stuff to Aurora, like bug 1062016.
- # [15:48] <@firebot> https://bugzil.la/1062016 — FIXED, eitan — [AccessFu] Editing state does not remain consistent with focused state of entry
- # [15:48] * Joins: logbot (logbot@moz-58CB32ED.glob.com.au)
- # [15:55] * Quits: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net) (Quit: Leaving...)
- # [15:55] * Joins: slee (chatzilla@moz-CF8D1B29.range81-154.btcentralplus.com)
- # [16:01] * Quits: slee (chatzilla@moz-CF8D1B29.range81-154.btcentralplus.com) (Ping timeout)
- # [16:02] * Joins: slee (chatzilla@moz-3B64AAF8.range81-154.btcentralplus.com)
- # [16:03] * Quits: slee (chatzilla@moz-3B64AAF8.range81-154.btcentralplus.com) (Connection reset by peer)
- # [16:04] * Joins: slee (chatzilla@moz-3B64AAF8.range81-154.btcentralplus.com)
- # [16:07] <tbsaunde> surkov: any idea why a document would fire a hide event before any show events?
- # [16:10] * Quits: slee (chatzilla@moz-3B64AAF8.range81-154.btcentralplus.com) (Ping timeout)
- # [16:21] * Joins: slee (chatzilla@moz-532EA3B0.range81-132.btcentralplus.com)
- # [16:26] * Quits: slee (chatzilla@moz-532EA3B0.range81-132.btcentralplus.com) (Ping timeout)
- # [16:26] * Joins: slee (chatzilla@moz-532EA3B0.range81-132.btcentralplus.com)
- # [16:31] * Quits: slee (chatzilla@moz-532EA3B0.range81-132.btcentralplus.com) (Ping timeout)
- # [16:36] * Joins: slee (chatzilla@moz-532EA3B0.range81-132.btcentralplus.com)
- # [16:39] <@surkov> tbsaunde: iirc show and hide events are sort of special on document
- # [16:39] * Joins: slee_ (chatzilla@moz-532EA3B0.range81-132.btcentralplus.com)
- # [16:39] <@surkov> but what you say sounds like a bug
- # [16:39] * Quits: slee (chatzilla@moz-532EA3B0.range81-132.btcentralplus.com) (Ping timeout)
- # [16:39] <tbsaunde> surkov: hm, how are they special?
- # [16:39] * slee_ is now known as slee
- # [16:40] <@surkov> tbsaunde: iirc they are artifical, i.e they aren’t result of usual tree update process
- # [16:40] <@surkov> but that was a while ago, I don’t remember details
- # [16:43] <tbsaunde> surkov: btw fell like finishing bug 1041070 for me so I can debug this event thing to unbreak e10s tree update?
- # [16:43] <@firebot> https://bugzil.la/1041070 — ASSIGNED, trev.saunders — Update `CacheChildren` and `ShutdownChildrenInSubtree` to avoid locking up main thread
- # [16:44] * Joins: maxli (maxli@moz-B19F68ED.student.cs.uwaterloo.ca)
- # [16:45] * icaaq is now known as icaaq|afk
- # [16:46] <@surkov> tbsaunde: do you have good ideas how to make it faster?
- # [16:47] <tbsaunde> surkov: what?
- # [16:47] <@surkov> assertion part
- # [16:48] * Joins: clown (clown@67828CC7.C1A51174.9D42CF23.IP)
- # [16:48] <@surkov> anyway I think I can pick it up if you want
- # [16:48] <tbsaunde> surkov: just ifdef DEBUG it?
- # [16:49] <@surkov> it’ll be running on all debug builds that’s not also good
- # [16:49] * Joins: yliao (yliao@moz-D5CB3E1F.dynamic.hinet.net)
- # [16:49] * Quits: slee (chatzilla@moz-532EA3B0.range81-132.btcentralplus.com) (Ping timeout)
- # [16:50] <tbsaunde> surkov: I bet it'll generally be fast since mutating subtree isn't that big
- # [16:50] * Joins: slee (chatzilla@moz-532EA3B0.range81-132.btcentralplus.com)
- # [16:51] <@surkov> tbsaunde: large portions of document may be inserted and the check will be running for each inserted node, that may be big
- # [16:52] * Quits: slee (chatzilla@moz-532EA3B0.range81-132.btcentralplus.com) (Ping timeout)
- # [16:53] <tbsaunde> surkov: sure, you don't really have any better choice
- # [16:53] <tbsaunde> they may be, but probably not all that common
- # [16:56] * Quits: yliao (yliao@moz-D5CB3E1F.dynamic.hinet.net) (Ping timeout)
- # [16:57] * Joins: yliao (yliao@moz-D5CB3E1F.dynamic.hinet.net)
- # [16:59] * Quits: yliao (yliao@moz-D5CB3E1F.dynamic.hinet.net) (Ping timeout)
- # [17:18] <tbsaunde> surkov: so?
- # [17:26] * Joins: slee (chatzilla@moz-C5BCDAE3.range86-146.btcentralplus.com)
- # [17:27] <@surkov> tbsaunde: maybe we can go wihout assertions
- # [17:28] <tbsaunde> surkov: so the reason no show event before hide event is that DoInitialUpdate just calls CacheChildrenInSubtree instead of using UpdateTree
- # [17:29] <tbsaunde> surkov: I'd rather not, why do you care about debug speed so much?
- # [17:30] <@surkov> tbsaunde: it should be still usable and ideally not too much different from release build
- # [17:30] <tbsaunde> its only different in that it asserts more stuff, which is the only reason to bother in the first plae
- # [17:33] * wlach|afk is now known as wlach
- # [17:35] * Joins: slee_ (chatzilla@moz-C5BCDAE3.range86-146.btcentralplus.com)
- # [17:35] * Quits: slee (chatzilla@moz-C5BCDAE3.range86-146.btcentralplus.com) (Ping timeout)
- # [17:35] * slee_ is now known as slee
- # [17:37] * Joins: slee_ (chatzilla@moz-C5BCDAE3.range86-146.btcentralplus.com)
- # [17:37] * Quits: slee (chatzilla@moz-C5BCDAE3.range86-146.btcentralplus.com) (Ping timeout)
- # [17:37] * slee_ is now known as slee
- # [17:43] * Quits: slee (chatzilla@moz-C5BCDAE3.range86-146.btcentralplus.com) (Ping timeout)
- # [17:44] * Joins: slee (chatzilla@moz-87D8FC32.range86-155.btcentralplus.com)
- # [17:47] * Quits: @MarcoZ (marco.zehe@moz-ABCBD7A6.dip0.t-ipconnect.de) (Input/output error)
- # [17:49] <@surkov> tbsaunde: review plans?
- # [17:50] <tbsaunde> surkov: ongoing as other work is spinning
- # [17:50] <@surkov> ok
- # [17:51] * Joins: askalski (akuda@2BA4E5A7.CC7751E8.6712E96B.IP)
- # [17:52] <tbsaunde> surkov: so, ideas what to do about CacheChildrenInSubtree creating subtrees but not firing events
- # [17:53] <@surkov> tbsaunde: nothing if it doesn’t hurt anybody
- # [17:53] <tbsaunde> surkov: well, it breaks e10s stuff
- # [17:53] <tbsaunde> and it seems just broken
- # [17:53] <@surkov> tbsaunde: you rely on show/hide events on document?
- # [17:53] * icaaq|afk is now known as icaaq
- # [17:54] * clown is now known as clown_mtg
- # [17:54] <tbsaunde> surkov: I don't think the ondocument part is really relavent here
- # [17:54] <@surkov> I have impression that show/hide evnets on document are sort of optional
- # [17:54] <@surkov> what is ondocument part?
- # [17:54] <tbsaunde> I would say I rely on show / hide events period
- # [17:55] <tbsaunde> and I don't see anything treating show / hide where document is parent specially
- # [17:55] <@surkov> why do you rely at events at all?
- # [17:55] <tbsaunde> surkov: how else would you do it?
- # [17:55] <@surkov> internally you can always know the document was created or destroyed
- # [17:56] <tbsaunde> surkov: what does documents have to do with this?
- # [17:56] <@surkov> I don’t get you
- # [17:56] <@surkov> can you describe what are you trying to solve
- # [17:57] <tbsaunde> surkov: if you have a copy of the tree, how do you update it on changes other than use events
- # [17:57] <@surkov> well you could hook directly into shutdown
- # [17:58] <tbsaunde> surkov: shutdown meaning?
- # [17:58] <@surkov> I meant method
- # [17:58] <@surkov> or inside UpdateTree()
- # [17:59] <tbsaunde> surkov: UpdateTree has the exact same problem as events
- # [17:59] <@surkov> we could depend on events and that would make us closer to AT
- # [17:59] <@surkov> you can have several hooks of course
- # [17:59] <tbsaunde> and if you try to use AppendChild / RemoveChild you probably get flood of useless notifications because of stupid invalidateChildren
- # [17:59] <@surkov> anyway if document is subject of show/hide events then you can fix that
- # [18:00] <@surkov> right, AppendChild/RemoveChild perhpas it not a best place
- # [18:00] <tbsaunde> surkov: sure, but its not clear to me how to fix it
- # [18:01] <@surkov> tbsaunde: after all you can just force the event
- # [18:01] <tbsaunde> surkov: meaning what?
- # [18:01] <@surkov> tbsaunde: just create event object and fire it
- # [18:01] <tbsaunde> surkov: sure assuming you know something changed
- # [18:02] <tbsaunde> which afaik you can't really
- # [18:02] <@surkov> I don’t get you, did you said you don’t have show event on document creation or something else?
- # [18:03] <@surkov> tbsaunde: ^
- # [18:03] * Quits: slee (chatzilla@moz-87D8FC32.range86-155.btcentralplus.com) (Ping timeout)
- # [18:03] <tbsaunde> surkov: you don't get show event for whatever accessibles are created by CacheChildrenInSubtree
- # [18:03] * Joins: slee (chatzilla@moz-87D8FC32.range86-155.btcentralplus.com)
- # [18:04] <@surkov> tbsaunde: in DoInitialUpdate we fire reorder event, if we fired show event there then would it solve the problem?
- # [18:06] <tbsaunde> surkov: partially
- # [18:06] <@surkov> what is other part?
- # [18:06] * Quits: askalski (akuda@2BA4E5A7.CC7751E8.6712E96B.IP) (Quit: Wychodzi)
- # [18:06] <@surkov> btw, it’s worth to check with jamie if show event on document is something is expected
- # [18:06] * Quits: slee (chatzilla@moz-87D8FC32.range86-155.btcentralplus.com) (Ping timeout)
- # [18:06] <tbsaunde> surkov: things like ProcessContentInserted and ProcessInvalidationList that also call CacheChildrenInSubtree are probably a -roblem
- # [18:07] <@surkov> tbsaunde: all those stuff cannot result in document creation. you miss some show events other than on document?
- # [18:08] <tbsaunde> surkov: not document creation, but they can create new subtrees I think
- # [18:08] * Joins: yliao (yliao@moz-D5CB3E1F.dynamic.hinet.net)
- # [18:09] <@surkov> tbsaunde: I believe those methods should be correctly covered by show events
- # [18:09] <@surkov> I mean you always should have show event on top
- # [18:10] <tbsaunde> surkov: I don't believe you at least for ProcessInvalidationList
- # [18:10] * Quits: yliao (yliao@moz-D5CB3E1F.dynamic.hinet.net) (Ping timeout)
- # [18:11] * Joins: jamesn (jnurthen@moz-F1E6EF59.oracle.com)
- # [18:11] <tbsaunde> now, I guess I could "fix" each of those cases in a really stupid way but uhg
- # [18:11] <@surkov> tbsaunde: ProcessInvalidationList is always part of some tree update and that tree update is suject of show event
- # [18:11] * Joins: slee (chatzilla@moz-44F81FFB.range86-152.btcentralplus.com)
- # [18:11] <@surkov> either way I’m not aware of any missed show events
- # [18:12] <@surkov> in case of document it’d be good to check with AT
- # [18:13] <tbsaunde> surkov: I don't see ProcessInvalidationList being called as part of tree update
- # [18:13] <tbsaunde> but I guess we can hack around the DoInitialUpdate thing and Indiana Jones our way along
- # [18:17] <@surkov> tbsaunde: that’s sort of surprising for me, can you think of prooving example?
- # [18:18] <@surkov> would it be like insertion <span id=“span”><span><input aria-labelledby=“span”>
- # [18:19] * Quits: wlach (wlach@13F2CEC5.7672369.D8E68FF6.IP) (Quit: Ex-Chat)
- # [18:21] * Quits: slee (chatzilla@moz-44F81FFB.range86-152.btcentralplus.com) (Ping timeout)
- # [18:21] * Joins: slee_ (chatzilla@moz-44F81FFB.range86-152.btcentralplus.com)
- # [18:22] * slee_ is now known as slee
- # [18:27] * khuey is now known as khuey|away
- # [18:28] <@surkov> tbsaunde: you’re right, insert span, insert input doesn’t fire show event for span
- # [18:37] * Quits: slee (chatzilla@moz-44F81FFB.range86-152.btcentralplus.com) (Ping timeout)
- # [18:38] * Joins: slee (chatzilla@moz-44F81FFB.range86-152.btcentralplus.com)
- # [18:40] * Quits: icaaq (icaaq@D2069856.FE797095.222B27F0.IP) (Quit: 10-79 Notify coroner, over and out)
- # [18:41] * Quits: slee (chatzilla@moz-44F81FFB.range86-152.btcentralplus.com) (Ping timeout)
- # [18:43] * Joins: slee (chatzilla@moz-44F81FFB.range86-152.btcentralplus.com)
- # [18:45] <tbsaunde> surkov: so, ideas how to fix it?
- # [18:45] * Quits: jamesn (jnurthen@moz-F1E6EF59.oracle.com) (Quit: Leaving)
- # [18:51] * Quits: @yzen (yzen@13F2CEC5.7672369.D8E68FF6.IP) (Quit: leaving... bye!)
- # [18:51] * Joins: yzen (yzen@13F2CEC5.7672369.D8E68FF6.IP)
- # [18:51] * ChanServ sets mode: +o yzen
- # [18:54] * Quits: API (api@moz-75739B3B.igalia.com) (Client exited)
- # [18:58] * Quits: maxli (maxli@moz-B19F68ED.student.cs.uwaterloo.ca) (Quit: Leaving.)
- # [19:01] * Quits: @yzen (yzen@13F2CEC5.7672369.D8E68FF6.IP) (Ping timeout)
- # [19:08] <@surkov> tbsaunde: in case of invalidationList we could switch to UpdateTree
- # [19:10] <tbsaunde> surkov: and the others?
- # [19:11] <@surkov> tbsaunde: document or something else?
- # [19:11] <tbsaunde> surkov: ProcessContentInsertions and DoInitialUpdate atleast
- # [19:12] <tbsaunde> I guess its just those
- # [19:13] * Joins: slee_ (chatzilla@moz-44F81FFB.range86-152.btcentralplus.com)
- # [19:13] <@surkov> tbsaunde: do you mean ProcessContentInserted?
- # [19:13] <tbsaunde> surkov: yes
- # [19:13] * Quits: slee (chatzilla@moz-44F81FFB.range86-152.btcentralplus.com) (Ping timeout)
- # [19:13] * slee_ is now known as slee
- # [19:13] <@surkov> tbsaunde: it uses UpdateTree
- # [19:15] <tbsaunde> surkov: I'm not entirely convinced that's enough, but maybe
- # [19:18] <tbsaunde> surkov: so in ProcessInvalidationList I see how you can get rid of the UpdateChildren call with UpdateTree, but not the CacheChildrenInSubtree one
- # [19:19] <@surkov> tbsaunde: I don’t follow, CacheChildrenInSubtree is just a helper
- # [19:20] <tbsaunde> surkov: so what are you saying ProcessInvalidationList should do?
- # [19:21] * Quits: @surkov (surkov@moz-DF24A6EA.cpe.pppoe.ca) (Ping timeout)
- # [19:21] * Joins: surkov (surkov@moz-DF24A6EA.cpe.pppoe.ca)
- # [19:21] * ChanServ sets mode: +o surkov
- # [19:21] * Quits: slee (chatzilla@moz-44F81FFB.range86-152.btcentralplus.com) (Ping timeout)
- # [19:32] * Joins: slee (chatzilla@moz-44F81FFB.range86-152.btcentralplus.com)
- # [19:35] * khuey|away is now known as khuey
- # [19:36] <tbsaunde> surkov: I guessed you missed question, what are you saying ProcessInvalidationList should do?
- # [19:36] <@surkov> tbsaunde: can it be switched to UpdateTree?
- # [19:36] * clown_mtg is now known as clown
- # [19:37] * Quits: slee (chatzilla@moz-44F81FFB.range86-152.btcentralplus.com) (Ping timeout)
- # [19:37] <tbsaunde> surkov: its not obvious to me how
- # [19:37] * Joins: slee_ (chatzilla@moz-44F81FFB.range86-152.btcentralplus.com)
- # [19:38] * slee_ is now known as slee
- # [19:38] <tbsaunde> though if you see a way that'd be nice
- # [19:39] <@surkov> tbsaunde: what if run UpdateTree for each content from mInvalidationList?
- # [19:39] * Joins: slee__ (chatzilla@moz-44F81FFB.range86-152.btcentralplus.com)
- # [19:40] * agibson is now known as agibson|afk
- # [19:40] * Quits: slee (chatzilla@moz-44F81FFB.range86-152.btcentralplus.com) (Ping timeout)
- # [19:40] * slee__ is now known as slee
- # [19:41] <tbsaunde> surkov: maybe, though not sure what exactly
- # [19:41] <tbsaunde> // Make sure the subtree is created.
- # [19:41] <tbsaunde> if (accessible)
- # [19:41] <tbsaunde> CacheChildrenInSubtree(accessible);
- # [19:41] <tbsaunde> surkov: is trying to do so not sure if that's enough or not
- # [19:41] * Joins: slee_ (chatzilla@moz-44F81FFB.range86-152.btcentralplus.com)
- # [19:41] <@firebot> lhenry@mozilla.com changed the Status on bug 1041817 from UNCONFIRMED to NEW.
- # [19:41] <@surkov> I see, update logic is tricky
- # [19:41] <@firebot> https://bugzil.la/1041817 — NEW — Custom keyboards and shortcuts
- # [19:42] * Quits: slee (chatzilla@moz-44F81FFB.range86-152.btcentralplus.com) (Ping timeout)
- # [19:42] * slee_ is now known as slee
- # [19:42] <@surkov> at the fisrt glance it should be working
- # [19:43] <@surkov> however probably not
- # [19:43] <tbsaunde> surkov: yeah, but it seems like it would have done that if it covered all edge cases
- # [19:43] <@surkov> what if fire show events in case of (!accessible) { }
- # [19:44] <@surkov> what happens if that inaccessible thing contained accessilbe children
- # [19:45] <@surkov> it should result in kids adoption
- # [19:45] <tbsaunde> surkov: maybe, atm I don't want to know, I just want to make e10s not die
- # [19:46] <@surkov> it shouldn’t die, it will have not complete accessible tree
- # [19:46] <tbsaunde> surkov: well, it asserts
- # [19:46] * Quits: slee (chatzilla@moz-44F81FFB.range86-152.btcentralplus.com) (Ping timeout)
- # [19:46] * Joins: slee (chatzilla@moz-44F81FFB.range86-152.btcentralplus.com)
- # [19:46] <@surkov> it’s not so bad, anyway bug should be fixed
- # [20:00] * Quits: slee (chatzilla@moz-44F81FFB.range86-152.btcentralplus.com) (Ping timeout)
- # [20:01] * agibson|afk is now known as agibson
- # [20:15] * agibson is now known as agibson|afk
- # [20:18] * Joins: slee (chatzilla@moz-44F81FFB.range86-152.btcentralplus.com)
- # [20:27] * Quits: slee (chatzilla@moz-44F81FFB.range86-152.btcentralplus.com) (Quit: ChatZilla 0.9.90.1 [Firefox 33.0/20140908190852])
- # [20:43] * Quits: agibson|afk (agibson@moz-2C643250.gate.cable.virginm.net) (Quit: )
- # [20:45] * Joins: yzen (yzen@moz-F62769B5.cpe.pppoe.ca)
- # [20:45] * ChanServ sets mode: +o yzen
- # [20:45] <@yzen> eeejay any time
- # [20:46] <eeejay> sure, let me set up
- # [20:47] <eeejay> yzen, i'm in the page
- # [20:48] <@yzen> ok
- # [20:49] * Quits: @surkov (surkov@moz-DF24A6EA.cpe.pppoe.ca) (Quit: surkov)
- # [20:53] * Joins: surkov (surkov@moz-DF24A6EA.cpe.pppoe.ca)
- # [20:53] * ChanServ sets mode: +o surkov
- # [20:57] * Joins: icaaq (icaaq@CDF70C60.7DCD925.CE255B90.IP)
- # [21:22] * Quits: icaaq (icaaq@CDF70C60.7DCD925.CE255B90.IP) (Ping timeout)
- # [21:25] * Joins: icaaq (icaaq@CDF70C60.7DCD925.CE255B90.IP)
- # [21:46] * Quits: icaaq (icaaq@CDF70C60.7DCD925.CE255B90.IP) (Ping timeout)
- # [22:04] * Quits: anvk (anovak@C141829F.3923648E.6468E038.IP) (Quit: Leaving.)
- # [22:13] * Joins: icaaq (icaaq@moz-396D494F.ias.bredband.telia.com)
- # [22:59] * Parts: clown (clown@67828CC7.C1A51174.9D42CF23.IP)
- # [23:19] * Quits: Gijs (gijs@moz-D2B81DF.range86-173.btcentralplus.com) (Quit: sleep)
- # [23:33] * khuey is now known as khuey|away
- # [23:41] * Joins: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net)
- # [23:43] * khuey|away is now known as khuey
- # [23:44] * Quits: @yzen (yzen@moz-F62769B5.cpe.pppoe.ca) (Ping timeout)
- # [23:44] * Quits: icaaq (icaaq@moz-396D494F.ias.bredband.telia.com) (Quit: 10-79 Notify coroner, over and out)
- # [23:48] * Joins: Jamie (Instantbir@moz-CA26021.jantrid.net)
- # [23:53] * Joins: yzen (yzen@moz-F62769B5.cpe.pppoe.ca)
- # [23:53] * ChanServ sets mode: +o yzen
- # [23:57] * Quits: @yzen (yzen@moz-F62769B5.cpe.pppoe.ca) (Ping timeout)
- # Session Close: Thu Sep 11 00:00:00 2014
The end :)