/irc-logs / mozilla / #accessibility / 2014-09-11 / end
Options:
- # Session Start: Thu Sep 11 00:00:00 2014
- # Session Ident: #accessibility
- # [00:13] * Quits: Bryen (Bryen@moz-97CDA41D.lightspeed.cicril.sbcglobal.net) (Ping timeout)
- # [00:22] * Quits: Justin_o (uid14648@moz-E77DEB21.irccloud.com) (Quit: Connection closed for inactivity)
- # [00:25] * khuey is now known as khuey|away
- # [00:54] * Quits: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net) (Ping timeout)
- # [01:01] * Joins: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net)
- # [02:08] * Joins: yzen (yzen@moz-F62769B5.cpe.pppoe.ca)
- # [02:08] * ChanServ sets mode: +o yzen
- # [02:09] * Parts: @yzen (yzen@moz-F62769B5.cpe.pppoe.ca) (leaving... bye!)
- # [02:49] * Joins: yzen (yzen@moz-F62769B5.cpe.pppoe.ca)
- # [02:49] * ChanServ sets mode: +o yzen
- # [03:16] * Quits: @yzen (yzen@moz-F62769B5.cpe.pppoe.ca) (Ping timeout)
- # [03:30] * Joins: yliao (yliao@moz-99690620.hinet-ip.hinet.net)
- # [03:32] * Quits: yliao (yliao@moz-99690620.hinet-ip.hinet.net) (Client exited)
- # [03:33] * Joins: yliao (yliao@moz-E37F359D.hinet-ip.hinet.net)
- # [03:53] <@firebot> vseerror@lehigh.edu requested needinfo from trev.saunders@gmail.com on bug 857319.
- # [03:53] <@firebot> https://bugzil.la/857319 — NEW — crash in mozilla::a11y::sdnAccessible::Release
- # [04:03] * Joins: yzen (yzen@moz-F62769B5.cpe.pppoe.ca)
- # [04:03] * ChanServ sets mode: +o yzen
- # [04:11] * Quits: @yzen (yzen@moz-F62769B5.cpe.pppoe.ca) (Ping timeout)
- # [04:18] * Joins: yzen (yzen@moz-F62769B5.cpe.pppoe.ca)
- # [04:18] * ChanServ sets mode: +o yzen
- # [04:20] * Quits: @yzen (yzen@moz-F62769B5.cpe.pppoe.ca) (Ping timeout)
- # [04:22] * khuey|away is now known as khuey
- # [04:58] * khuey is now known as khuey|away
- # [05:16] * Quits: @surkov (surkov@moz-DF24A6EA.cpe.pppoe.ca) (Quit: surkov)
- # [05:18] * Joins: yzen (yzen@moz-F62769B5.cpe.pppoe.ca)
- # [05:18] * ChanServ sets mode: +o yzen
- # [06:40] * Quits: dij (Mibbit@9B9315E1.A6025CA.1C37C358.IP) (Quit: http://www.mibbit.com ajax IRC Client)
- # [06:40] * Joins: dij (Mibbit@9B9315E1.A6025CA.1C37C358.IP)
- # [07:09] * Joins: icaaq (icaaq@moz-396D494F.ias.bredband.telia.com)
- # [07:38] * Quits: @yzen (yzen@moz-F62769B5.cpe.pppoe.ca) (Ping timeout)
- # [07:44] * Quits: icaaq (icaaq@moz-396D494F.ias.bredband.telia.com) (Quit: 10-79 Notify coroner, over and out)
- # [07:59] * Joins: maxli (maxli@moz-F47DD19B.student.cs.uwaterloo.ca)
- # [08:03] * Quits: maxli (maxli@moz-F47DD19B.student.cs.uwaterloo.ca) (Ping timeout)
- # [08:11] * Joins: icaaq (icaaq@moz-222501AC.cust.telenor.se)
- # [08:14] * Joins: maxli (maxli@moz-EE42E0E.student.cs.uwaterloo.ca)
- # [08:26] * Quits: dij (Mibbit@9B9315E1.A6025CA.1C37C358.IP) (Quit: http://www.mibbit.com ajax IRC Client)
- # [08:41] * Quits: Jamie (Instantbir@moz-CA26021.jantrid.net) (Ping timeout)
- # [08:43] * Joins: Jamie (Instantbir@moz-CA26021.jantrid.net)
- # [08:46] * Quits: yliao (yliao@moz-E37F359D.hinet-ip.hinet.net) (Client exited)
- # [08:51] * Joins: yliao (yliao@moz-99690620.hinet-ip.hinet.net)
- # [08:53] * Quits: icaaq (icaaq@moz-222501AC.cust.telenor.se) (Ping timeout)
- # [09:01] * Joins: dij (Mibbit@9B9315E1.A6025CA.1C37C358.IP)
- # [09:07] * Quits: yliao (yliao@moz-99690620.hinet-ip.hinet.net) (Client exited)
- # [09:21] * Joins: icaaq (icaaq@D2069856.FE797095.222B27F0.IP)
- # [09:28] * Joins: Gijs (gijs@moz-D2B81DF.range86-173.btcentralplus.com)
- # [09:30] * Joins: yliao (yliao@moz-E37F359D.hinet-ip.hinet.net)
- # [09:35] * Quits: MrMazda (fmcz@moz-CB202EEF.cable.mindspring.com) (Quit: ChatZilla 0.9.86.1 [SeaMonkey 1.1.18/2009082712])
- # [09:37] * Quits: yliao (yliao@moz-E37F359D.hinet-ip.hinet.net) (Client exited)
- # [09:49] * Joins: yliao (yliao@moz-E37F359D.hinet-ip.hinet.net)
- # [09:49] * Quits: yliao (yliao@moz-E37F359D.hinet-ip.hinet.net) (Client exited)
- # [09:56] * Joins: MarcoZ (marco.zehe@moz-ABCBD7A6.dip0.t-ipconnect.de)
- # [09:56] * ChanServ sets mode: +ao MarcoZ MarcoZ
- # [10:01] * Joins: yliao (yliao@moz-E37F359D.hinet-ip.hinet.net)
- # [10:02] * Quits: @MarcoZ (marco.zehe@moz-ABCBD7A6.dip0.t-ipconnect.de) (Input/output error)
- # [10:02] * Quits: yliao (yliao@moz-E37F359D.hinet-ip.hinet.net) (Client exited)
- # [10:02] * Joins: yliao (yliao@moz-E37F359D.hinet-ip.hinet.net)
- # [10:03] * Quits: Jamie (Instantbir@moz-CA26021.jantrid.net) (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
- # [10:04] * Joins: MarcoZ (marco.zehe@moz-ABCBD7A6.dip0.t-ipconnect.de)
- # [10:04] * ChanServ sets mode: +ao MarcoZ MarcoZ
- # [10:13] * Quits: maxli (maxli@moz-EE42E0E.student.cs.uwaterloo.ca) (Quit: Leaving.)
- # [10:18] * Joins: MrMazda (fmcz@moz-CB202EEF.cable.mindspring.com)
- # [10:18] * Joins: SteveF (chatzilla@moz-6F24D0BD.cable.virginm.net)
- # [10:19] * Joins: agibson (agibson@moz-2C643250.gate.cable.virginm.net)
- # [11:23] * Quits: SteveF (chatzilla@moz-6F24D0BD.cable.virginm.net) (Connection reset by peer)
- # [11:24] * Joins: SteveF (chatzilla@moz-6F24D0BD.cable.virginm.net)
- # [12:13] * Joins: API (api@moz-75739B3B.igalia.com)
- # [12:27] * Quits: Gijs (gijs@moz-D2B81DF.range86-173.btcentralplus.com) (Quit: bbiab)
- # [12:31] * Quits: yliao (yliao@moz-E37F359D.hinet-ip.hinet.net) (Client exited)
- # [12:59] * icaaq is now known as icaaq|afk
- # [13:01] * agibson is now known as agibson|afk
- # [13:08] * icaaq|afk is now known as icaaq
- # [13:42] * Joins: yliao (yliao@CA7875FA.15D5E57B.E89465F7.IP)
- # [13:44] * Quits: yliao (yliao@CA7875FA.15D5E57B.E89465F7.IP) (Ping timeout)
- # [14:02] * Quits: SteveF (chatzilla@moz-6F24D0BD.cable.virginm.net) (Ping timeout)
- # [14:02] * Quits: agibson|afk (agibson@moz-2C643250.gate.cable.virginm.net) (Client exited)
- # [14:10] * Joins: surkov (surkov@moz-DF24A6EA.cpe.pppoe.ca)
- # [14:10] * ChanServ sets mode: +o surkov
- # [14:13] * Joins: agibson|afk (agibson@moz-2C643250.gate.cable.virginm.net)
- # [14:18] * Joins: yzen (yzen@moz-F62769B5.cpe.pppoe.ca)
- # [14:18] * ChanServ sets mode: +o yzen
- # [14:22] * Joins: SteveF (chatzilla@moz-6F24D0BD.cable.virginm.net)
- # [14:23] * Joins: yliao (yliao@moz-D5CB3E1F.dynamic.hinet.net)
- # [14:25] * Quits: yliao (yliao@moz-D5CB3E1F.dynamic.hinet.net) (Client exited)
- # [14:25] <@MarcoZ> yzen: Yay for status bar landings! Will report back when these arrived in my Aurora updates!
- # [14:25] <@yzen> MarcoZ looking forward to it :)
- # [14:26] <@MarcoZ> yzen: Now for those regressions re the contacts/dialer app. Or? :)
- # [14:27] <@yzen> well it's already fixed, both bugs (mine and the one that includes the fix for a styling regression) will be requested for 2.1 approval today
- # [14:27] <@MarcoZ> yzen: Ah cool!
- # [14:27] <@yzen> same goes for the statusbar bugs, ill request those today :)
- # [14:28] <@yzen> but our 2.1 p1 list is empty \o/
- # [14:29] * Quits: @firebot (firebot@moz-D6137482.glob.com.au) (Ping timeout)
- # [14:32] * Joins: firebot (firebot@moz-D6137482.glob.com.au)
- # [14:32] * ChanServ sets mode: +o firebot
- # [14:50] * khuey|away is now known as khuey
- # [14:52] * Joins: anvk (anovak@C141829F.3923648E.6468E038.IP)
- # [14:52] * Quits: @yzen (yzen@moz-F62769B5.cpe.pppoe.ca) (Ping timeout)
- # [14:52] * Joins: yliao (yliao@moz-D5CB3E1F.dynamic.hinet.net)
- # [14:56] * Quits: yliao (yliao@moz-D5CB3E1F.dynamic.hinet.net) (Ping timeout)
- # [14:57] * Joins: Justin_o (uid14648@moz-E77DEB21.irccloud.com)
- # [15:01] * icaaq is now known as icaaq|afk
- # [15:12] * Joins: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net)
- # [15:16] * Quits: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net) (Client exited)
- # [15:16] * Joins: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net)
- # [15:16] * Joins: yzen (yzen@13F2CEC5.7672369.D8E68FF6.IP)
- # [15:16] * ChanServ sets mode: +o yzen
- # [15:17] * Joins: yliao_ (yliao@moz-D5CB3E1F.dynamic.hinet.net)
- # [15:18] * Quits: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net) (Ping timeout)
- # [15:21] * Quits: yliao_ (yliao@moz-D5CB3E1F.dynamic.hinet.net) (Client exited)
- # [15:24] * icaaq|afk is now known as icaaq
- # [15:25] * Joins: yliao (yliao@moz-D5CB3E1F.dynamic.hinet.net)
- # [15:27] * Quits: yliao (yliao@moz-D5CB3E1F.dynamic.hinet.net) (No route to host)
- # [15:27] * Joins: yliao (yliao@moz-D5CB3E1F.dynamic.hinet.net)
- # [15:29] * Quits: yliao (yliao@moz-D5CB3E1F.dynamic.hinet.net) (Ping timeout)
- # [15:32] * Joins: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net)
- # [15:32] * Joins: yliao_ (yliao@moz-A6EFB7B1.hinet-ip.hinet.net)
- # [15:34] * Quits: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net) (Ping timeout)
- # [15:37] * Quits: yliao_ (yliao@moz-A6EFB7B1.hinet-ip.hinet.net) (Ping timeout)
- # [15:37] * Joins: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net)
- # [15:38] * Quits: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net) (Client exited)
- # [15:38] * Joins: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net)
- # [15:39] * Quits: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net) (Ping timeout)
- # [15:40] * Quits: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net) (Ping timeout)
- # [15:40] <@MarcoZ> yzen: Hi! Feel like looking at https://bugzilla.mozilla.org/show_bug.cgi?id=969512 real quick? I would love to test the try build myself, but it refuses to install on my Androids for some reason. (Regular nightlies work.)
- # [15:41] <@firebot> Bug 969512 — NEW, bugmail.mozilla — Don't use NS_MOUSEENTER/LEAVE in widget level code
- # [15:41] <@MarcoZ> yzen: I know kats asked eeejay for info, but perhaps you have a quick idea so this can be sped up.
- # [15:41] <@yzen> MarcoZ taking a look
- # [15:45] * Joins: clown (clown@67828CC7.C1A51174.9D42CF23.IP)
- # [15:45] * clown is now known as clown_mtg
- # [15:45] * Joins: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net)
- # [15:47] * Joins: yliao_ (yliao@moz-A6EFB7B1.hinet-ip.hinet.net)
- # [15:47] <@firebot> trev.saunders@gmail.com cancelled needinfo?(trev.saunders@gmail.com) on bug 857319.
- # [15:47] <@firebot> https://bugzil.la/857319 — NEW — crash in mozilla::a11y::sdnAccessible::Release
- # [15:47] * Quits: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net) (Ping timeout)
- # [15:48] * Joins: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net)
- # [15:49] * Quits: yliao_ (yliao@moz-A6EFB7B1.hinet-ip.hinet.net) (Ping timeout)
- # [15:50] * Quits: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net) (Ping timeout)
- # [15:56] * Joins: davidb (davidb@13F2CEC5.7672369.D8E68FF6.IP)
- # [15:56] * ChanServ sets mode: +qo davidb davidb
- # [15:56] * Joins: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net)
- # [15:57] <@davidb> heyo
- # [15:57] <@yzen> MarcoZ so i nightly from try build just crashes on me
- # [15:58] <@yzen> MarcoZ both with vo and without it
- # [15:58] * Quits: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net) (Ping timeout)
- # [16:01] * agibson|afk is now known as agibson
- # [16:02] * Joins: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net)
- # [16:02] * Joins: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net)
- # [16:04] * Quits: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net) (Ping timeout)
- # [16:07] * Joins: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net)
- # [16:09] * Quits: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net) (Ping timeout)
- # [16:10] * Joins: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net)
- # [16:11] * Joins: yliao_ (yliao@moz-A6EFB7B1.hinet-ip.hinet.net)
- # [16:12] * Quits: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net) (Ping timeout)
- # [16:13] * Quits: yliao_ (yliao@moz-A6EFB7B1.hinet-ip.hinet.net) (Ping timeout)
- # [16:17] * Quits: SteveF (chatzilla@moz-6F24D0BD.cable.virginm.net) (Ping timeout)
- # [16:17] * Joins: SteveF (chatzilla@moz-6F24D0BD.cable.virginm.net)
- # [16:18] * Joins: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net)
- # [16:20] * Joins: yliao_ (yliao@moz-A6EFB7B1.hinet-ip.hinet.net)
- # [16:20] * Quits: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net) (Ping timeout)
- # [16:21] * Quits: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net) (Ping timeout)
- # [16:31] * Quits: yliao_ (yliao@moz-A6EFB7B1.hinet-ip.hinet.net) (Ping timeout)
- # [16:36] * Joins: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net)
- # [16:38] * Quits: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net) (Ping timeout)
- # [16:38] * Joins: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net)
- # [16:39] * Joins: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net)
- # [16:42] * Quits: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net) (Ping timeout)
- # [16:43] <@firebot> ryanvm@gmail.com requested needinfo from surkov.alexander@gmail.com on bug 1020039.
- # [16:43] <@firebot> https://bugzil.la/1020039 — NEW — Intermittent relations/test_embeds.xul | Can't get accessible for [object XULElement]
- # [16:46] <@MarcoZ> yzen: Then you get further than I, it just doesn't install on my Nexus 5 at all.
- # [16:46] <@yzen> hmm
- # [16:46] <@firebot> surkov.alexander@gmail.com cancelled needinfo?(surkov.alexander@gmail.com) on bug 1020039.
- # [16:46] * Joins: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net)
- # [16:47] <@firebot> ryanvm@gmail.com requested needinfo from ryanvm@gmail.com on bug 1020039.
- # [16:55] * Quits: icaaq (icaaq@D2069856.FE797095.222B27F0.IP) (Quit: 10-79 Notify coroner, over and out)
- # [16:55] * Quits: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net) (Connection reset by peer)
- # [16:55] * Joins: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net)
- # [17:05] * clown_mtg is now known as clown
- # [17:08] * davidb is now known as davidb|afk
- # [17:11] * Quits: ioanachiorean (ioanachior@6DC7A5F5.AA1FA0D2.6A4F8DA2.IP) (Ping timeout)
- # [17:16] * Quits: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net) (Client exited)
- # [17:23] * Joins: Bryen (Bryen@moz-97CDA41D.lightspeed.cicril.sbcglobal.net)
- # [17:31] * Joins: yliao_ (yliao@moz-A6EFB7B1.hinet-ip.hinet.net)
- # [17:31] * Quits: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net) (Connection reset by peer)
- # [17:33] <@surkov> tbsaunde: can I ask you to take a quick look at bug 1065100 to check if you’re fine with the approach
- # [17:33] <@firebot> https://bugzil.la/1065100 — NEW — hide bulky static_cast stuff in xpc classes
- # [17:33] * Joins: maxli (maxli@moz-F47DD19B.student.cs.uwaterloo.ca)
- # [17:33] <tbsaunde> surkov: ok
- # [17:33] <@surkov> thx
- # [17:37] * davidb|afk is now known as davidb
- # [17:37] * Quits: yliao_ (yliao@moz-A6EFB7B1.hinet-ip.hinet.net) (Ping timeout)
- # [17:38] * Joins: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net)
- # [17:40] <tbsaunde> surkov: what's wrong with static inline Accessible* Acc(XPCAccessibles* aAcc) { return static_cast<Accessible*>(aAcc); } in cpp file if you really dislike raw static casts?
- # [17:41] <@surkov> tbsaunde: I outlined 3 reason in the bug, you don’t buy them?
- # [17:43] <@surkov> I guess 2nd is still applied
- # [17:43] <eeejay> MarcoZ, I'm giving it a try now.
- # [17:43] <tbsaunde> surkov: yeah, 1 is invalid because function is defined in cpp file 2 I don't care about compilers are so stupid they don't inline that
- # [17:43] <eeejay> if it installs..
- # [17:43] <tbsaunde> surkov: 3 == 1
- # [17:44] <@surkov> tbsaunde: after we switch to aggreagation then this inline have to be a fried of the XPCAccessible
- # [17:44] <@surkov> it cannot be done for cpp inline, right?
- # [17:45] <tbsaunde> surkov: well, then you don't need this thing at all afaik
- # [17:45] <@surkov> why?
- # [17:45] <tbsaunde> because you just have a member Accessible* mAcc;
- # [17:45] <tbsaunde> so you can do mAcc->Parent()
- # [17:46] <@surkov> tbsaunde: I think mAcc will be a memeber of xpcAccessibleGeneric and I should make something like static_cast<xpcAccessibleGeneric*>->mAcc from xpcAccessibleHyperLink class
- # [17:47] <@surkov> from HyperText class I have to make something like mAcc->AsHyperText()
- # [17:47] <@surkov> so macroses are soft of nice way to hide these details and not care about them
- # [17:48] <tbsaunde> surkov: well, I'm not sure how your going to do the inheritance
- # [17:48] <tbsaunde> and the final solution depends on that
- # [17:49] <tbsaunde> so why not worry about casts later
- # [17:50] * Joins: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net)
- # [17:54] <@davidb> tbsaunde, i'm skipping lunch today
- # [17:54] <@davidb> or may grab cereal or something
- # [18:04] <@davidb> eeejay, is the gfx filtering stuff making it into 2.1 (along with UI for it)?
- # [18:04] <eeejay> davidb, it is in, yeah
- # [18:04] <@davidb> fantastic
- # [18:09] * Quits: @MarcoZ (marco.zehe@moz-ABCBD7A6.dip0.t-ipconnect.de) (Quit: l8er)
- # [18:10] * Quits: yliao (yliao@moz-A6EFB7B1.hinet-ip.hinet.net) (Client exited)
- # [18:19] * Quits: API (api@moz-75739B3B.igalia.com) (Quit: Leaving)
- # [18:20] * Quits: SteveF (chatzilla@moz-6F24D0BD.cable.virginm.net) (Ping timeout)
- # [18:22] <@surkov> tbsaunde: the proposed hierarchy in the patch
- # [18:22] * davidb is now known as davidb|afk
- # [18:23] <@surkov> tbsaunde: except keeping it nice another reason of the change I want to keep ongoing changes smaller (when we switch to aggregation)
- # [18:34] * Joins: SteveF (chatzilla@moz-6F24D0BD.cable.virginm.net)
- # [18:37] * davidb|afk is now known as davidb
- # [18:50] <tbsaunde> surkov: yeah, but you don't show there how things like hypertext / tables will work
- # [18:51] <@surkov> tbsaunde: I think they will be inherited from xpcAccessibleGeneric
- # [18:52] <@surkov> tbsaunde: anyway you dislike macros?
- # [18:52] <@surkov> for me they are look harmless in this case
- # [18:56] * Joins: icaaq (icaaq@moz-B598B10E.cust.telenor.se)
- # [19:00] <tbsaunde> surkov: yeah, I think we can use functions well enough, and I'm just fine with casts as is
- # [19:02] <@surkov> tbsaunde: ok how to make inline cpp function a friend for the class? and what’s benefits of function over macroses?
- # [19:02] * Joins: Gijs (chatzilla@moz-D2B81DF.range86-173.btcentralplus.com)
- # [19:03] <@surkov> I think I’m fine with casts but they are large and have to be changed all together as long as we touch the hiehrarchy etc
- # [19:03] <Gijs> davidb: yo! You CC'd me on this a11y review bug, and now I'm scared. What are you planning? :)
- # [19:03] <Gijs> (for tiles)
- # [19:04] <@davidb> Gijs, be very afaid. Kidding. I want to make sure you are aware of all front-endish a11y bugs. Someone needs to do a keyboard a11y assessment, Marco can do the reader part...
- # [19:04] <tbsaunde> surkov: change them with sed ;)
- # [19:05] <@surkov> tbsaunde: can you use sed for review? ;)
- # [19:05] <@davidb> Gijs, is it okay that I consider you an a11y go-to?
- # [19:05] <tbsaunde> surkov: no, but reviewing mechanical patches isn't hard
- # [19:05] <Gijs> davidb: I guess!
- # [19:06] <@surkov> you still has to do that
- # [19:06] <@davidb> :)
- # [19:06] <Gijs> davidb: it is going to be interesting to combine with the prioritization we do inside firefox desktop
- # [19:06] <Gijs> I will juggle where necessary
- # [19:06] <@davidb> understood
- # [19:06] <@surkov> anyway, I’m fine with long static_cast, I just wanted to find a way how to improve that
- # [19:06] <Gijs> anyway, I just marked all the high contrast bugs as deps for the tiles stuff...
- # [19:06] <Gijs> that was a 30-second process and at least now they have something ;)
- # [19:06] <@surkov> macroses look nice, I didn’t see nice way with functions
- # [19:07] <@davidb> Gijs, oh there are tiles specific high contrast bugs?
- # [19:07] <Gijs> but a full review would take longer obviously
- # [19:07] * @davidb nods
- # [19:07] * Quits: icaaq (icaaq@moz-B598B10E.cust.telenor.se) (Ping timeout)
- # [19:07] <Gijs> davidb: I think most of these are longer-standing new tab page issues
- # [19:07] <@davidb> sighted keyboard user + screen reader review covers a lot.
- # [19:07] <Gijs> I don't know that/if the tiles stuff changed much in terms of the page's layout... although I've vaguely heard something about interactive tiles
- # [19:07] <Gijs> and I don't know how those work because I've never seen any
- # [19:08] <@surkov> tbsaunde: so?
- # [19:09] <Gijs> davidb: the tab order seems non-terrible, and the (pin) and (tab) buttons work, and enter navigates to tiles, so it's at least not terribly broken for the "regular" tiles
- # [19:09] <Gijs> davidb: I would be surprised if there was a keyboard equivalent for the dnd stuff (you can reorder tiles with the mouse)
- # [19:09] <Gijs> ttaubert would know.
- # [19:10] * Joins: icaaq (icaaq@moz-B598B10E.cust.telenor.se)
- # [19:11] <tbsaunde> surkov: basically I don't think I have time to think about something nicer atm
- # [19:11] * Quits: maxli (maxli@moz-F47DD19B.student.cs.uwaterloo.ca) (Quit: Leaving.)
- # [19:11] <@surkov> tbsaunde: ok, do you think marcoses is no way to go?
- # [19:13] <@davidb> Gijs, yeah dnd via keyboard is a hard problem.
- # [19:13] <@davidb> in this case there are possible nice solutions but it takes work.
- # [19:13] <@davidb> yzen, remember the fluid reorderer?
- # [19:14] <@yzen> yeah
- # [19:14] <@davidb> (for keyboard drag and drop)
- # [19:14] <@davidb> is that hard to do?
- # [19:14] <tbsaunde> surkov: I suspect you can come up with something ebtter
- # [19:14] <@yzen> davidb i never actually worked with the component, but i think it's reasonable
- # [19:15] <@davidb> ack
- # [19:15] <@yzen> davidb you mean the keyboard ?
- # [19:16] <@davidb> yzen, keyboard control of drag and drop for grids
- # [19:16] <@surkov> tbsaunde: maybe, but I’m fine with macroses to dig deeper. If you are not then we always can stay with >80chars line with existing static_cast
- # [19:17] * Quits: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net) (Client exited)
- # [19:22] <@surkov> tbsaunde: so what is your back word :)
- # [19:28] * Quits: icaaq (icaaq@moz-B598B10E.cust.telenor.se) (Ping timeout)
- # [19:29] <tbsaunde> surkov: I'd say leave it esp since I don't have spare time to review extra patches
- # [19:30] <@surkov> tbsaunde: ok, I should notice though you won’t save time on patches reviewing, depending on how the work is splitted you may do even more work
- # [19:31] <tbsaunde> hopefully you'll put renaming in seperate patch that I can just skim
- # [19:32] <tbsaunde> or I can just grumble and skim worse
- # [19:32] <@davidb> gotta shuffle
- # [19:32] * Quits: @davidb (davidb@13F2CEC5.7672369.D8E68FF6.IP) (Quit: Blah blah blah)
- # [19:33] <@firebot> surkov.alexander@gmail.com changed the Resolution on bug 1065100 from --- to WONTFIX.
- # [19:33] <@firebot> surkov.alexander@gmail.com changed the Status on bug 1065100 from NEW to RESOLVED.
- # [19:33] <@firebot> https://bugzil.la/1065100 — WONTFIX — hide bulky static_cast stuff in xpc classes
- # [19:34] <@surkov> tbsaunde: maybe separate patch is not really needed for skimming becuase those files will have this sort of chagnes
- # [19:34] <@surkov> and nothing else
- # [19:36] <tbsaunde> the accessible/src/ -> accessible/ move breaking history without git log -M -C --find-coppies-harder --follow is supper annoying :(
- # [19:37] <@surkov> perhaps you need to create command shortcut
- # [19:39] <tbsaunde> or perhaps hg or hg -git should suck less
- # [19:42] * Quits: SteveF (chatzilla@moz-6F24D0BD.cable.virginm.net) (Ping timeout)
- # [19:43] * Joins: SteveF (chatzilla@moz-6F24D0BD.cable.virginm.net)
- # [19:46] * Joins: SteveF_ (chatzilla@moz-6F24D0BD.cable.virginm.net)
- # [19:46] * Quits: SteveF (chatzilla@moz-6F24D0BD.cable.virginm.net) (Ping timeout)
- # [19:47] * SteveF_ is now known as SteveF
- # [19:48] * Joins: icaaq (icaaq@moz-396D494F.ias.bredband.telia.com)
- # [19:51] * Quits: SteveF (chatzilla@moz-6F24D0BD.cable.virginm.net) (Ping timeout)
- # [19:51] * Joins: SteveF (chatzilla@moz-6F24D0BD.cable.virginm.net)
- # [19:56] * Joins: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net)
- # [19:59] * Quits: SteveF (chatzilla@moz-6F24D0BD.cable.virginm.net) (Connection reset by peer)
- # [19:59] * Joins: SteveF (chatzilla@moz-6F24D0BD.cable.virginm.net)
- # [20:18] * Quits: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net) (Client exited)
- # [20:18] * agibson is now known as agibson|afk
- # [20:18] * Joins: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net)
- # [20:19] * icaaq is now known as icaaq|afk
- # [20:19] * Quits: icaaq|afk (icaaq@moz-396D494F.ias.bredband.telia.com) (Quit: 10-79 Notify coroner, over and out)
- # [20:20] * Quits: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net) (Ping timeout)
- # [20:23] * Joins: davidb (davidb@moz-B2092CB.dsl.bell.ca)
- # [20:23] * ChanServ sets mode: +qo davidb davidb
- # [20:24] * agibson|afk is now known as agibson
- # [20:28] * Quits: SteveF (chatzilla@moz-6F24D0BD.cable.virginm.net) (Ping timeout)
- # [20:28] * Joins: SteveF (chatzilla@moz-6F24D0BD.cable.virginm.net)
- # [20:34] * agibson is now known as agibson|noms
- # [20:38] * Joins: SteveF_ (chatzilla@moz-6F24D0BD.cable.virginm.net)
- # [20:38] * Quits: SteveF (chatzilla@moz-6F24D0BD.cable.virginm.net) (Ping timeout)
- # [20:38] * SteveF_ is now known as SteveF
- # [20:40] * Quits: SteveF (chatzilla@moz-6F24D0BD.cable.virginm.net) (Ping timeout)
- # [20:41] * Joins: SteveF (chatzilla@moz-6F24D0BD.cable.virginm.net)
- # [20:45] * Joins: SteveF_ (chatzilla@moz-6F24D0BD.cable.virginm.net)
- # [20:45] * Quits: SteveF (chatzilla@moz-6F24D0BD.cable.virginm.net) (Ping timeout)
- # [20:45] * SteveF_ is now known as SteveF
- # [20:57] * agibson|noms is now known as agibson
- # [20:59] * davidb is now known as davidb|afk
- # [21:15] * Quits: SteveF (chatzilla@moz-6F24D0BD.cable.virginm.net) (Ping timeout)
- # [21:21] * khuey is now known as khuey|away
- # [21:23] * Joins: icaaq (icaaq@moz-396D494F.ias.bredband.telia.com)
- # [21:26] * icaaq is now known as icaaq|afk
- # [21:26] * Quits: icaaq|afk (icaaq@moz-396D494F.ias.bredband.telia.com) (Quit: 10-79 Notify coroner, over and out)
- # [21:28] * Joins: icaaq (icaaq@moz-396D494F.ias.bredband.telia.com)
- # [21:29] * khuey|away is now known as khuey
- # [21:33] * Quits: agibson (agibson@moz-2C643250.gate.cable.virginm.net) (Quit: )
- # [21:39] * Joins: SteveF (chatzilla@moz-6F24D0BD.cable.virginm.net)
- # [21:52] * davidb|afk is now known as davidb
- # [21:54] <tbsaunde> surkov: so, I'm pretty sure I'm seeing content inserted by the CacheChildrenInSubtree in ProcessContentInserted istr fixing a bug something like that too
- # [21:54] <tbsaunde> so, any idea how to make events work there?
- # [21:55] * Joins: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net)
- # [21:55] <@surkov> tbsaunde: no good suggestions until I understand roots of the problem, I assume you have a test case?
- # [21:56] <tbsaunde> surkov: loading google.com with my e10s patch
- # [21:56] <@surkov> nothing simpler?
- # [21:56] <@surkov> that’d be hard
- # [21:56] <tbsaunde> surkov: noap
- # [21:57] <@surkov> logging might help
- # [21:57] <tbsaunde> I suppose I could hack and fire "internal only" show / hide for full subtree :/
- # [21:57] <@surkov> I’m curious why AT don’t run into this problem
- # [21:59] <tbsaunde> surkov: not sure
- # [21:59] <@surkov> so you have missed subtree?
- # [21:59] <@surkov> and there’s no event for missed subtree
- # [22:00] <tbsaunde> surkov: yeah, I'm seeing insertion into subtree I don't think exists
- # [22:00] * Quits: SteveF (chatzilla@moz-6F24D0BD.cable.virginm.net) (Ping timeout)
- # [22:01] <tbsaunde> I'm asserting the thing show event is child of is already in parent, but in this case its not
- # [22:10] * Quits: dij (Mibbit@9B9315E1.A6025CA.1C37C358.IP) (Connection reset by peer)
- # [22:16] * Quits: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net) (Client exited)
- # [22:17] * Joins: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net)
- # [22:18] * Quits: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net) (Ping timeout)
- # [22:22] * Joins: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net)
- # [22:25] * Quits: Gijs (chatzilla@moz-D2B81DF.range86-173.btcentralplus.com) (Ping timeout)
- # [22:30] * Parts: clown (clown@67828CC7.C1A51174.9D42CF23.IP)
- # [22:39] * Quits: anvk (anovak@C141829F.3923648E.6468E038.IP) (Quit: Leaving.)
- # [22:44] * Quits: icaaq (icaaq@moz-396D494F.ias.bredband.telia.com) (Quit: 10-79 Notify coroner, over and out)
- # [22:48] * Joins: Gijs (chatzilla@moz-D2B81DF.range86-173.btcentralplus.com)
- # [23:02] * Quits: @yzen (yzen@13F2CEC5.7672369.D8E68FF6.IP) (Ping timeout)
- # [23:09] * Quits: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net) (Client exited)
- # [23:10] * Joins: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net)
- # [23:12] * Quits: newtron (newtron@moz-8A56CC3B.ip.mcleodusa.net) (Ping timeout)
- # [23:21] * Joins: SteveF (chatzilla@moz-6F24D0BD.cable.virginm.net)
- # [23:23] * Joins: newtron (newtron@16CD1393.1DC31EC0.921B270C.IP)
- # [23:27] * Quits: @davidb (davidb@moz-B2092CB.dsl.bell.ca) (Quit: Blah blah blah)
- # [23:32] * Quits: SteveF (chatzilla@moz-6F24D0BD.cable.virginm.net) (Ping timeout)
- # [23:32] * Quits: Justin_o (uid14648@moz-E77DEB21.irccloud.com) (Quit: Connection closed for inactivity)
- # Session Close: Fri Sep 12 00:00:00 2014
The end :)