/irc-logs / mozilla / #developers / 2011-12-20 / end
Options:
- # Session Start: Tue Dec 20 00:00:00 2011
- # Session Ident: #developers
- # [00:00] * Quits: kaze (kaze@moz-79F78BFC.w90-46.abo.wanadoo.fr) (Quit: WeeChat 0.3.5)
- # [00:01] * Joins: lsumar (lsumar@538BABFE.A073F3E.97BBD552.IP)
- # [00:02] * Quits: michal (michal@moz-5C5A58A8.broadband14.iol.cz) (Input/output error)
- # [00:02] * Quits: jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP) (Ping timeout)
- # [00:04] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [00:05] * philor is now known as philor|away
- # [00:07] * Quits: nattokirai (nattokirai@moz-C97EE7C8.dynamic.ppp.asahi-net.or.jp) (Quit: nattokirai)
- # [00:07] * Joins: stfl|away (stfl@moz-22F37930.hsi7.kabel-badenwuerttemberg.de)
- # [00:08] * philor|away is now known as philor
- # [00:08] * Quits: jduell (jduell@moz-2D9EDA98.lightspeed.sntcca.sbcglobal.net) (Ping timeout)
- # [00:09] * Quits: bmoss (bmoss@moz-BBE3ABD.mv.mozilla.com) (Ping timeout)
- # [00:09] * Quits: espindola (espindola@F2D29657.F60B0462.67AC9B1.IP) (Client exited)
- # [00:09] * rick is now known as rwaldron
- # [00:10] * joduinn-mtg is now known as joduinn
- # [00:11] * Joins: bbondy (bbondy@moz-28CF6D1C.home.cgocable.net)
- # [00:11] * Quits: bbondy (bbondy@moz-28CF6D1C.home.cgocable.net) (Client exited)
- # [00:11] * Joins: bbondy (bbondy@moz-28CF6D1C.home.cgocable.net)
- # [00:11] * Quits: clee (clee@moz-BBE3ABD.mv.mozilla.com) (Quit: clee)
- # [00:11] * Joins: bmoss (bmoss@moz-BBE3ABD.mv.mozilla.com)
- # [00:12] * Quits: bjacob (bjacob@F2D29657.F60B0462.67AC9B1.IP) (Quit: Konversation terminated!)
- # [00:12] * Joins: bjacob (bjacob@F2D29657.F60B0462.67AC9B1.IP)
- # [00:12] * catlee is now known as catlee-away
- # [00:12] * Joins: clee (clee@moz-BBE3ABD.mv.mozilla.com)
- # [00:13] * Quits: smaug (chatzilla@moz-1D1B327E.elisa-mobile.fi) (Ping timeout)
- # [00:14] * Quits: bjacob (bjacob@F2D29657.F60B0462.67AC9B1.IP) (Quit: Konversation terminated!)
- # [00:14] * Joins: bjacob (bjacob@F2D29657.F60B0462.67AC9B1.IP)
- # [00:14] * Joins: smaug (chatzilla@moz-1D1B327E.elisa-mobile.fi)
- # [00:14] * Joins: merinui (merinui@moz-61C7235E.osk2.eonet.ne.jp)
- # [00:14] * Quits: bmoss (bmoss@moz-BBE3ABD.mv.mozilla.com) (Ping timeout)
- # [00:14] <mounir> khuey: ping
- # [00:14] <khuey> mounir: pong
- # [00:14] <mounir> khuey: I've a build system question for you :)
- # [00:15] <mounir> I got a link error I can't understand
- # [00:15] * Quits: ajuma (ajuma@F2D29657.F60B0462.67AC9B1.IP) (Quit: ajuma)
- # [00:15] <khuey> heh
- # [00:15] * Quits: Honza (chatzilla@E07BF19C.5BB5597D.D0083327.IP) (Ping timeout)
- # [00:15] <mounir> I have A.cpp that is using a method declared with extern in B.h and defined in B.cpp
- # [00:15] <mounir> both cpp files a used in the same static lib (libhal)
- # [00:16] <mounir> but when linking libxul, I get a link error becouse the method is undefined
- # [00:16] * Quits: MMx (mmx@moz-1AFE3502.afthd.hg.tu-darmstadt.de) (Ping timeout)
- # [00:16] * Joins: jwatt (roslea@jwatt.irc.users.mozilla.org)
- # [00:16] * Joins: Honza (chatzilla@E07BF19C.5BB5597D.D0083327.IP)
- # [00:17] <mounir> it seems that the lib isn't created but there is libfoo_s.a.desc file created instead with the list ob obj files inside
- # [00:17] <Pike> glandium: re your patch in bug 708437, strings.xml depends on the files in branding, moved to the right place by a jar.mn, which, AFAICT, only picks up on libs and realchrome, and thus fails on export::. At least that's what my bustage for xul android with that fix ported suggests, http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/axel@mozilla.com-4f2868c689aa/try-android-xul/try-android-
- # [00:17] <Pike> xul-build426.txt.gz
- # [00:17] <Pike> glandium: did you test a clobber build?
- # [00:17] <mounir> khuey: do you have any idea of what is happening?
- # [00:18] * Quits: bjacob (bjacob@F2D29657.F60B0462.67AC9B1.IP) (Connection reset by peer)
- # [00:18] * Joins: bjacob (bjacob@F2D29657.F60B0462.67AC9B1.IP)
- # [00:18] <khuey> mounir: why are you declaring a function with extern?
- # [00:19] <mounir> khuey: it's an auto-generated file
- # [00:19] * Joins: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP)
- # [00:19] <khuey> ok
- # [00:19] * Quits: ahal (ahal@F2D29657.F60B0462.67AC9B1.IP) (Client exited)
- # [00:19] <khuey> why is whatever generates this file declaring a function with extern?
- # [00:20] * Quits: josh (josh@moz-2EE66546.nyc.res.rr.com) (Quit: josh)
- # [00:20] <mounir> khuey: why is that bad?
- # [00:21] * Joins: jfkthame (jfkthame@CE8EB10E.90783722.9542EC20.IP)
- # [00:21] <bholley> mounir: how are you getting to FOSDEM? TGV?
- # [00:22] <mounir> bholley: TGV, yes
- # [00:22] <mounir> bholley: Thalys actually
- # [00:22] <bholley> mounir: are you going friday evening?
- # [00:22] * Quits: ddahl (ddahl@moz-6971CF66.hsd1.il.comcast.net) (Ping timeout)
- # [00:22] <khuey> mounir: well, it's completely pointless
- # [00:22] <mounir> bholley: man, that's the best moment of FOSDEM :)
- # [00:22] <khuey> anyways
- # [00:23] * Quits: mak (chatzilla@moz-6699258.retail.telecomitalia.it) (Quit: ChatZilla 0.9.86.1-rdmsoft [XULRunner 2.0/20110318052756])
- # [00:23] <khuey> mounir: is B really a .cpp file?
- # [00:23] <khuey> and not a .c?
- # [00:23] <karl> mounir: check visibility of the symbols
- # [00:23] <bholley> mounir: ok, when should I plan on leaving paris then?
- # [00:23] <mounir> khuey: for the moment, I did copy-paste the generated code so it's a .cpp file
- # [00:23] <mounir> karl: what do you mean?
- # [00:23] * Quits: jfkthame (jfkthame@CE8EB10E.90783722.9542EC20.IP) (Ping timeout)
- # [00:24] <jlebar> <mounir> I have A.cpp that is using a method declared with extern in B.h and defined in B.cpp
- # [00:24] <khuey> mounir: my guess is that name mangling is your problem
- # [00:24] <jlebar> mounir, are you sure the function definitions are the same?
- # [00:24] <mounir> jlebar: yes
- # [00:24] <jlebar> mounir, I've gotten that error when I'm just calling the wrong function.
- # [00:24] <jlebar> like, maybe without const or something.
- # [00:24] * Quits: pnemsak_ (Miranda@moz-7409BD53.orange.sk) (Quit: pnemsak_)
- # [00:24] <khuey> are you really, really sure?
- # [00:24] <khuey> like one of your types isn't something different in A.cpp and B.cpp?
- # [00:25] <smaug> ah, Fosdem. I was thinking to go there this time
- # [00:25] <mounir> bholley: better to be there around 6pm so you can enjoy your evening
- # [00:25] <mounir> smaug: yeah, you should come, there will be bholley, mrbkap and likely peterv
- # [00:25] <smaug> bholley: and really, Fosdem without Friday night is meaninless
- # [00:25] <smaug> meaningless
- # [00:25] <mounir> smaug++
- # [00:25] <bholley> the whole DOM team will be there!
- # [00:25] <khuey> we will?
- # [00:26] * jlebar didn't know he was going.
- # [00:26] <mounir> you guys just left the DOM team...
- # [00:26] <bholley> khuey: you'll be in europe right? You should come
- # [00:26] * adam is now known as adam-afk
- # [00:26] <khuey> bholley: if I stay through FOSDEM I will be in europe for 5 weeks
- # [00:26] <karl> mounir: do a readelf -s on the object files generating and using the function
- # [00:26] <bholley> khuey: that sounds about right :-)
- # [00:27] <smaug> khuey: that sounds like a good thing to me
- # [00:27] <khuey> that's a bit much :-P
- # [00:27] <mcsmurf> lol
- # [00:27] * Joins: sheppy (sheppy@moz-7EAE095F.sip.tys.bellsouth.net)
- # [00:27] <bholley> khuey: so the binding meetup is at the end of your trip?
- # [00:27] <khuey> yes
- # [00:27] <khuey> I'm heading over the 9th or 10th or so
- # [00:27] <mounir> karl: 21: 0000000000000000 220 FUNC GLOBAL HIDDEN 10 _Z36mozilla_marshal_VOID_
- # [00:27] <karl> mounir: and check the "Vis" column matches for the symbols
- # [00:27] <mounir> should I worry with "HIDDEN"?
- # [00:27] <bholley> mounir: is thaly's cheaper? What's the difference?
- # [00:28] <bholley> mounir: I need TGV on my return, because it stops at CDG and I'm flying out sunday morning
- # [00:28] * Joins: mconley (mconley@moz-9C0F4EBF.cable.teksavvy.com)
- # [00:28] <bholley> mounir: If I take the 7AM train from brussels, I'll just make my flight
- # [00:28] <karl> mounir: hidden is good, but the caller object needs to be looking for hidden also
- # [00:28] <karl> s/caller/using/
- # [00:28] <mounir> bholley: Thalys is only the TGV brand doing Paris <-> Bruxelles
- # [00:29] <bholley> mounir: hmm, on the thaly's website I don't see the CDG station
- # [00:29] <bholley> mounir: but I see it on raileurope-world.com
- # [00:29] <bholley> weird
- # [00:30] * Quits: Theo (chatzilla@moz-499C8051.w90-48.abo.wanadoo.fr) (Ping timeout)
- # [00:31] * Joins: Theo (chatzilla@moz-499C8051.w90-48.abo.wanadoo.fr)
- # [00:31] * jcranmer|driving_like_mad is now known as jcranmer
- # [00:31] <mounir> bholley: do you speak a bit of french?
- # [00:31] <bholley> mounir: oui
- # [00:31] <jlebar> What attribute would you say an iframe for which you can get and set properties (e.g. location, title) on its content-window, even if it's cross-origin, has?
- # [00:31] <khuey> I don't have to speak french to come to paris do I?
- # [00:31] * Joins: Theo_ (chatzilla@moz-499C8051.w90-48.abo.wanadoo.fr)
- # [00:32] <bholley> khuey: non
- # [00:32] <hub> mounir: Paris <-> Amsterdam and also to Aachen in Germany
- # [00:32] <jlebar> khuey, no, but everyone will scoff at you.
- # [00:32] <jlebar> khuey, The French are quite good at scoffing.
- # [00:32] <khuey> jlebar: oh, that's fine
- # [00:32] <khuey> I can handle that
- # [00:32] <mounir> bholley: I know a website that should be quite nice to do your reservation (at least, I like it)
- # [00:32] <bholley> jlebar: mais ils vont faire le meme chose si ton accent est trop fort
- # [00:32] * bholley can't spell very well
- # [00:32] * Quits: Theo (chatzilla@moz-499C8051.w90-48.abo.wanadoo.fr) (Ping timeout)
- # [00:33] <bholley> mounir: lequelle?
- # [00:33] <jlebar> bholley, translate.google.com right back at you!
- # [00:33] * Theo_ is now known as Theo
- # [00:33] <mounir> bholley: just sent you an invit (it's in beta for the moment)
- # [00:33] * Quits: lsumar (lsumar@538BABFE.A073F3E.97BBD552.IP) (Quit: This computer has gone to sleep)
- # [00:33] * Quits: wolfiR (wolfiR@moz-145F9C08.dip0.t-ipconnect.de) (Quit: Leaving)
- # [00:33] <mounir> khuey: yes, you have to speak french to eat cheese :)
- # [00:34] <khuey> that'll be a deal breaker
- # [00:34] <mounir> and I narrow down the issue
- # [00:34] <mounir> removing G_BEGIN_DECLS
- # [00:34] <mounir> makes the linke work
- # [00:34] <khuey> mounir: that's unacceptable
- # [00:34] * Quits: clee (clee@moz-BBE3ABD.mv.mozilla.com) (Quit: clee)
- # [00:34] <khuey> the whole point is to eat cheese
- # [00:35] <karl> # define G_BEGIN_DECLS extern "C" {
- # [00:35] <mounir> karl: just saw that
- # [00:35] <khuey> mmm
- # [00:35] <karl> so sounds like khuey was right
- # [00:35] <khuey> symbol mangling
- # [00:35] <bholley> mounir: hey, this is nice
- # [00:36] * khuey remembers saying that
- # [00:36] * Joins: sfink (chatzilla@moz-4EAF93BB.dsl.pltn13.sbcglobal.net)
- # [00:36] * Joins: gandalf (zbraniecki@moz-144E18A2.neoplus.adsl.tpnet.pl)
- # [00:36] <mounir> khuey: how can I compile a C file? :)
- # [00:36] <mcsmurf> no french? then they'll serve you French snails
- # [00:36] <mcsmurf> delicious! ;)
- # [00:37] * Quits: nthomas (chatzilla@moz-75DA4CCD.dsl.telstraclear.net) (Ping timeout)
- # [00:37] * adam-afk is now known as adam
- # [00:38] <khuey> mounir: CSRCS ?
- # [00:38] <khuey> mcsmurf: yeah that's what I'm afraid of
- # [00:38] * Quits: bjacob (bjacob@F2D29657.F60B0462.67AC9B1.IP) (Quit: Konversation terminated!)
- # [00:38] <khuey> mcsmurf: no snails, just cheese
- # [00:38] * Joins: bjacob (bjacob@F2D29657.F60B0462.67AC9B1.IP)
- # [00:38] <khuey> is what I'm going for
- # [00:38] * Joins: nthomas (chatzilla@moz-75DA4CCD.dsl.telstraclear.net)
- # [00:38] <mounir> khuey: I did try CSCRS randomly and it works
- # [00:38] * Joins: jprmc (jprmc@C4C1FE33.5BCEC6DB.DA78B690.IP)
- # [00:38] * Joins: clee (clee@moz-BBE3ABD.mv.mozilla.com)
- # [00:38] <mounir> it's really weird that our build system was predictable on this
- # [00:38] <khuey> ouch
- # [00:39] <mounir> khuey: no snail? will you try trip or foie gras at least?
- # [00:39] * Quits: Waldo (waldo@moz-534B4EF1.hsd1.mi.comcast.net) (Quit: ChatZilla 0.9.87-4.1450hg.fc15 [XULRunner 8.0/20111108090029])
- # [00:40] <khuey> we'll see
- # [00:40] <njn> dbaron: ping
- # [00:42] <njn> khuey: I've started on layout memory reporters, looks like nsLayoutStylesheetCache is the root of it all, does that sound right to you?
- # [00:42] <bholley> mounir: are you staying at a hotel in brussels?
- # [00:42] <njn> dholbert may know about this too
- # [00:42] <khuey> uh
- # [00:42] <khuey> I'm not sure
- # [00:42] <khuey> it's been a while
- # [00:42] <bholley> mounir: I have friends I was going to stay with, but I know some conferences are very hotel-centric
- # [00:43] <mounir> bholley: FOSDEM doesn't attend in a hotel but in a university
- # [00:44] <bholley> mounir: ah, ok
- # [00:44] <mounir> bholley: FOSDEM is run by benevols ;)
- # [00:44] * Quits: AaronMT (AaronMT@moz-DEDA283.cpe.net.cable.rogers.com) (Ping timeout)
- # [00:44] * Joins: priya (priya@moz-BBE3ABD.mv.mozilla.com)
- # [00:45] * Quits: squib (squib-@moz-3F6F2A9C.ep.wisc.edu) (Quit: Leaving)
- # [00:46] * jcranmer is now known as jcranmer|away
- # [00:47] * Quits: alastair (alastair@moz-9E58F371.dynamic.dsl.as9105.com) (Quit: sleep)
- # [00:47] * Quits: bjacob (bjacob@F2D29657.F60B0462.67AC9B1.IP) (Quit: Konversation terminated!)
- # [00:47] <smaug> Enn: ping
- # [00:47] * Quits: Mossop (mossop@moz-BBE3ABD.mv.mozilla.com) (Ping timeout)
- # [00:47] * gregglind is now known as gregglind_away
- # [00:48] * Quits: romeo (romeo@moz-A9325888.k459.webspeed.dk) (Quit: Leaving)
- # [00:49] * Quits: TheLink (TheLink@moz-753C1E34.pools.arcor-ip.net) (Client exited)
- # [00:49] * Quits: darktrojan (geoff@moz-BC95E278.dsl.telstraclear.net) (Ping timeout)
- # [00:49] * Joins: bmoss (bmoss@moz-BBE3ABD.mv.mozilla.com)
- # [00:50] * Joins: jimb (user@moz-F4EC06CC.hsd1.or.comcast.net)
- # [00:51] * Quits: robhawkes (robhawkes@moz-33A339B7.dsl.cnl.uk.net) (Quit: Linkinus - http://linkinus.com)
- # [00:53] * bwinton_away is now known as bwinton
- # [00:53] <@dbaron> njn, pong
- # [00:53] <njn> dbaron: I'm writing a memory reporter for style data
- # [00:53] <@dbaron> njn, and nsLayoutStylesheetCache should not be the root of it all
- # [00:54] <njn> dbaron: oh?
- # [00:54] * Quits: jprmc (jprmc@C4C1FE33.5BCEC6DB.DA78B690.IP) (Quit: Leaving)
- # [00:54] * Joins: jprmc (jprmc@C4C1FE33.5BCEC6DB.DA78B690.IP)
- # [00:54] <njn> dbaron: tracing back from the allocations that DMD told me were uncovered, that's where I ended up
- # [00:54] * Quits: pcwalton (pcwalton@moz-7B0110AD.mv.mozilla.com) (Quit: pcwalton)
- # [00:54] <@dbaron> njn, nsLayoutStylesheetCache is what owns the user-agent style sheets and user style sheets
- # [00:55] <@dbaron> njn, but it doesn't own any of the style sheets from Web content
- # [00:55] <njn> dbaron: so where is the root of it all?
- # [00:55] <@dbaron> njn, of what all?
- # [00:55] * Quits: mconley (mconley@moz-9C0F4EBF.cable.teksavvy.com) (Input/output error)
- # [00:55] * Quits: Standard8 (Standard8@B7F1AE36.48015583.54C3481B.IP) (Quit: ZNC - http://znc.in)
- # [00:55] <@dbaron> njn, (see http://www.w3.org/TR/CSS21/cascade.html#cascade if those terms don't make sense to you)
- # [00:55] <njn> dbaron: how are the web content sheets stored?
- # [00:56] <@dbaron> njn, they're attached to the document
- # [00:56] * Joins: edmorley1 (edmorley@moz-1BABC6CB.range86-166.btcentralplus.com)
- # [00:56] * Quits: edmorley (edmorley@moz-28ED10AB.range86-144.btcentralplus.com) (NickServ (GHOST command used by edmorley1))
- # [00:56] * edmorley1 is now known as edmorley
- # [00:56] <njn> dbaron: can you give me some class/member names?
- # [00:56] <@dbaron> njn, er, hold on
- # [00:56] <njn> I need to understand the internal data structures
- # [00:56] * ctalbert is now known as ctalbert|afk
- # [00:56] <@dbaron> njn, yeah, nsDocument::mStyleSheets
- # [00:56] <njn> and traverse them
- # [00:56] * Quits: Fallen|mac (kewisch@moz-6F64C71A.adsl.alicedsl.de) (Quit: Leaving.)
- # [00:56] <@dbaron> njn, that said, what do you mean by "style data"
- # [00:57] <@dbaron> njn, there are two large pieces
- # [00:57] <@dbaron> njn, which are almost entirely separate, and worth separating conceptually
- # [00:57] <njn> ok
- # [00:57] <@dbaron> njn, (1) the representation of the style sheets (sheets, rules, selectors) and (2) computed style data (a value of each property for each frame)
- # [00:58] <@dbaron> njn, so far we're talking about (1)
- # [00:58] <@dbaron> njn, https://wiki.mozilla.org/Gecko:Overview#Style_System should give an overview of both
- # [00:58] <njn> dbaron: ok
- # [00:58] <njn> dbaron: I'm just trying to implement bug 671299
- # [00:58] * Quits: dRdR (dRdR@moz-F979C50C.cpe.net.cable.rogers.com) (Client exited)
- # [00:58] <njn> dbaron: and cover the memory in https://bugzilla.mozilla.org/attachment.cgi?id=554784
- # [00:59] * @dbaron waits for bugzilla
- # [00:59] * Joins: dRdR (dRdR@moz-F979C50C.cpe.net.cable.rogers.com)
- # [00:59] <njn> dbaron: some of those I traced back to nsLayoutStylesheetCache, but I may have made a mistake
- # [00:59] <@dbaron> njn, ah, right, as bz says in comment 0 of that bug, most of category (2) is in the pres shell arena, so already accounted for
- # [00:59] * Joins: davidb (davidb@moz-6F9F653A.dsl.bell.ca)
- # [00:59] * Quits: smaug (chatzilla@moz-1D1B327E.elisa-mobile.fi) (Quit: Reconnecting…)
- # [00:59] * Quits: mzz (marienz@BD227D12.9EF052E3.A6B97D29.IP) (Ping timeout)
- # [01:00] <@dbaron> njn, if you're looking for the first ones we create at startup, yes, they'll trace back to nsLayoutStylesheetCache
- # [01:00] <njn> nsCompressedBlock is a big missing piece
- # [01:00] * mcote is now known as mcote|afk
- # [01:00] <@dbaron> njn, so, yeah, this should be about (1) above
- # [01:00] <njn> IIRC that hangs off Declaratio
- # [01:00] <njn> n
- # [01:00] * Quits: Theo (chatzilla@moz-499C8051.w90-48.abo.wanadoo.fr) (Quit: ChatZilla 0.9.87 [Firefox 11.0a1/20111219031209])
- # [01:00] <@dbaron> njn, but I'm not too worried about memory reporting for the pieces from nsLayoutStylesheetCache -- that's a few one-off sheets we load at startup
- # [01:00] * Quits: damons (gnubeard@moz-BBE3ABD.mv.mozilla.com) (Quit: damons)
- # [01:01] <@dbaron> njn, I think the more interesting piece is tracing from nsDocument::mStyleSheets
- # [01:01] <@dbaron> njn, some of those sheets will be nsCSSStyleSheet
- # [01:01] * Quits: mcsmurf (mcsmurf@moz-5BDA8BFA.dip.t-dialin.net) (Quit: )
- # [01:01] <@dbaron> njn, those sheets contain rules, some of which will be css::StyleRule
- # [01:01] * Quits: dRdR (dRdR@moz-F979C50C.cpe.net.cable.rogers.com) (Ping timeout)
- # [01:01] <njn> that sounds familiar from what I was looking at
- # [01:01] * Joins: pcwalton (pcwalton@moz-7B0110AD.mv.mozilla.com)
- # [01:01] * Quits: clee (clee@moz-BBE3ABD.mv.mozilla.com) (Quit: clee)
- # [01:01] <njn> dbaron: but you think nsDocument::mStyleSheets will be most of it?
- # [01:01] <@dbaron> njn, css::StyleRule contain a css::Declaration and one or two nsCSSDataBlock
- # [01:02] <@dbaron> njn, yeah, for "once you've loaded more than a trivial Web page", yes
- # [01:02] <@dbaron> njn, maybe a little over trivial
- # [01:02] <njn> dbaron: the DMD results are for non-trivial pages like gmail
- # [01:02] * rail_away is now known as rail
- # [01:02] <@dbaron> njn, maybe it's worth tracking the ones from nsLayoutStylesheetCache too... but there's really nothing we should be adding there past startup, unless something's broken
- # [01:03] * Joins: dRdR (dRdR@moz-F979C50C.cpe.net.cable.rogers.com)
- # [01:03] <mbrubeck> edmorley, mak: Might want to hold off on merging *from* mozilla-central until we see if bug 711263 can be resolved soon.
- # [01:03] <njn> dbaron: that's a good sanity check :)
- # [01:03] * Joins: smaug (chatzilla@moz-1D1B327E.elisa-mobile.fi)
- # [01:03] <njn> dbaron: any suggestions on how to iterate over the nsDocuments?
- # [01:03] <edmorley> mbrubeck: will do :-)
- # [01:03] <njn> dbaron: maybe the DOM reporters already do that?
- # [01:03] <@dbaron> njn, how do we do it when doing memory reporting for the content nodes?
- # [01:03] * Joins: damons (gnubeard@moz-BBE3ABD.mv.mozilla.com)
- # [01:03] * Joins: anant_ (anant@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net)
- # [01:03] <njn> I don't know
- # [01:03] * Quits: davidb (davidb@moz-6F9F653A.dsl.bell.ca) (Quit: davidb)
- # [01:03] <njn> the DOM reporters must do it somehow
- # [01:03] <@dbaron> njn, if we have memory reporters for *anything* in DOM then we're already doing it
- # [01:03] <njn> I'll take a look
- # [01:03] <njn> ok
- # [01:04] * njn is just blundering around in the dark with these data structures ATM
- # [01:04] * Joins: michal (michal@moz-5C5A58A8.broadband14.iol.cz)
- # [01:04] * Quits: redfive (chatzilla@moz-B94E1A81.ipnetworksinc.net) (Ping timeout)
- # [01:04] <sheppy> By the way, it would be super helpful if folks could look over Firefox 9 for developers and make sure stuff they worked on is listed there if appropriate: https://developer.mozilla.org/en/Firefox_9_for_developers
- # [01:04] * Joins: redfive_ (chatzilla@moz-B94E1A81.ipnetworksinc.net)
- # [01:04] * redfive_ is now known as redfive
- # [01:04] <njn> mounir: ping
- # [01:04] * Quits: anant (anant@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net) (Ping timeout)
- # [01:04] * anant_ is now known as anant
- # [01:04] * Joins: clee (clee@moz-BBE3ABD.mv.mozilla.com)
- # [01:04] * Joins: MMx (mmx@moz-1AFE3502.afthd.hg.tu-darmstadt.de)
- # [01:06] * Joins: davidb (davidb@moz-6F9F653A.dsl.bell.ca)
- # [01:06] <njn> dbaron: I'll read that wiki page too, thanks for the help
- # [01:06] * Quits: dRdR (dRdR@moz-F979C50C.cpe.net.cable.rogers.com) (Ping timeout)
- # [01:06] <@dbaron> njn, sure, thanks for adding these memory reporters
- # [01:06] <njn> dbaron: thank me when they're finished :)
- # [01:07] * Joins: WeirdAl (chatzilla@moz-D461843.ask.info)
- # [01:07] * Quits: gkw (gkw@moz-BBE3ABD.mv.mozilla.com) (Quit: Instantbird 1.1)
- # [01:07] * Quits: bmoss (bmoss@moz-BBE3ABD.mv.mozilla.com) (Ping timeout)
- # [01:08] * Quits: dao (dao@moz-2DD4FBFB.superkabel.de) (Quit: Leaving.)
- # [01:08] <njn> dbaron: they're the biggest unreported piece in most cases
- # [01:08] * nthomas is now known as nthomas|away
- # [01:09] * Joins: dao (dao@moz-2DD4FBFB.superkabel.de)
- # [01:09] <@dbaron> njn, if they're big enough, we may want to split stuff into categories (e.g., the data blocks vs. the selectors)
- # [01:09] <@dbaron> (vs the rest)
- # [01:09] * Quits: bsmedberg (bsmedberg@moz-5A317CF.alt.east.verizon.net) (Ping timeout)
- # [01:09] * Quits: KaiRo_away (robert@moz-CA29FA62.adsl.highway.telekom.at) (Ping timeout)
- # [01:09] * Quits: akeybl (akeybl@moz-BBE3ABD.mv.mozilla.com) (Quit: Leaving...)
- # [01:09] * Quits: dao (dao@moz-2DD4FBFB.superkabel.de) (Quit: Leaving.)
- # [01:09] * Joins: KaIRC (robert@moz-DD749FCB.adsl.highway.telekom.at)
- # [01:09] <@dbaron> njn, I suppose that wouldn't be too hard if the rest is done?
- # [01:10] * Joins: mconley (mconley@31ABB91E.F7EBA23.C3C3A9D0.IP)
- # [01:10] * Joins: bmoss (bmoss@moz-BBE3ABD.mv.mozilla.com)
- # [01:11] * Joins: akeybl (akeybl@moz-BBE3ABD.mv.mozilla.com)
- # [01:11] * Joins: bsmedberg (bsmedberg@moz-5A317CF.alt.east.verizon.net)
- # [01:11] <njn> dbaron: that's easy
- # [01:11] <njn> dbaron: and definitely worth doing
- # [01:12] * njn is disappointed that mozilla::ArrayLength can't be used in constant expressions
- # [01:13] * njn learns that he should just use NS_ARRAY_LENGTH
- # [01:14] * Quits: armenzg_away (armenzg@moz-7B7ED579.home1.cgocable.net) (Input/output error)
- # [01:15] * Quits: jimm (jmathies@moz-7F164CA1.pn.at.cox.net) (Quit: )
- # [01:15] * Quits: @dbaron (dbaron@moz-389E0BB7.phlapa.fios.verizon.net) (Quit: 8403864 bytes have been tenured, next gc will be global.)
- # [01:16] * Quits: bmoss (bmoss@moz-BBE3ABD.mv.mozilla.com) (Ping timeout)
- # [01:19] * Quits: tonymec|away (tonymec@561D0D9A.23AE5289.277517C1.IP) (Ping timeout)
- # [01:19] * Joins: bmoss (bmoss@moz-BBE3ABD.mv.mozilla.com)
- # [01:21] * Quits: hipokrit (hipokrit@moz-502C3BF.rackspace.net) (Connection reset by peer)
- # [01:21] * Quits: jprmc (jprmc@C4C1FE33.5BCEC6DB.DA78B690.IP) (Ping timeout)
- # [01:21] * Quits: WeirdAl (chatzilla@moz-D461843.ask.info) (Quit: ChatZilla 0.9.87 [Firefox 8.0/20111104165243])
- # [01:22] * Joins: tonymec__ (tonymec@6174664F.9256CA4D.277517C1.IP)
- # [01:23] * bhearsum is now known as bhearsum|afk
- # [01:23] * tonymec__ is now known as tonymec|away
- # [01:25] * Quits: bmoss (bmoss@moz-BBE3ABD.mv.mozilla.com) (Ping timeout)
- # [01:26] * Joins: dao (dao@moz-2DD4FBFB.superkabel.de)
- # [01:26] * Joins: bmoss (bmoss@moz-BBE3ABD.mv.mozilla.com)
- # [01:29] * rail is now known as rail-food
- # [01:29] * Quits: anant (anant@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net) (Input/output error)
- # [01:30] * Joins: anant (anant@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net)
- # [01:32] * Quits: bmoss (bmoss@moz-BBE3ABD.mv.mozilla.com) (Ping timeout)
- # [01:34] * Quits: stfl|away (stfl@moz-22F37930.hsi7.kabel-badenwuerttemberg.de) (Client exited)
- # [01:34] * Quits: jhammink (textual@moz-BBE3ABD.mv.mozilla.com) (Quit: Computer has gone to sleep.)
- # [01:34] * Joins: mr_trousers (Mibbit@B65C3ADB.770AB491.57460053.IP)
- # [01:35] * Joins: squib (squib@moz-F5CA0CFB.dhcp.mdsn.wi.charter.com)
- # [01:35] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [01:35] * Joins: bmoss (bmoss@moz-BBE3ABD.mv.mozilla.com)
- # [01:35] * Joins: regen (Miller@moz-82F245A.adsl.dynamic.seed.net.tw)
- # [01:36] * Quits: regen (Miller@moz-82F245A.adsl.dynamic.seed.net.tw) (Input/output error)
- # [01:36] * Quits: jrmuizel (jrmuizel@F2D29657.F60B0462.67AC9B1.IP) (Input/output error)
- # [01:37] * Quits: rwaldron (rwaldron@moz-CE27855E.hfc.comcastbusiness.net) (Quit: Leaving...)
- # [01:37] * Joins: jrmuizel (jrmuizel@F2D29657.F60B0462.67AC9B1.IP)
- # [01:38] * Quits: damons (gnubeard@moz-BBE3ABD.mv.mozilla.com) (Quit: damons)
- # [01:38] * Quits: gandalf (zbraniecki@moz-144E18A2.neoplus.adsl.tpnet.pl) (Quit: Textual IRC Client: http://www.textualapp.com/)
- # [01:38] * Quits: davidb (davidb@moz-6F9F653A.dsl.bell.ca) (Quit: davidb)
- # [01:39] * Quits: decoder (quassel@moz-216446B9.own-hero.net) (Quit: No Ping reply in 180 seconds.)
- # [01:39] * Joins: decoder (quassel@moz-216446B9.own-hero.net)
- # [01:40] * Quits: AutomatedTester (AutomatedT@moz-8DECC833.as13285.net) (Quit: AutomatedTester)
- # [01:40] * rshetty is now known as rshetty_away
- # [01:42] * Joins: IanN (chatzilla@moz-3F5A461C.cable.virginmedia.com)
- # [01:42] * Joins: davidb (davidb@moz-6F9F653A.dsl.bell.ca)
- # [01:42] * Quits: jorendorff (jorendorff@moz-91590D94.hsd1.tn.comcast.net) (Quit: jorendorff)
- # [01:43] <IanN> who is the best person on the SSL3.0/TLS1.0 and what happens if TLS is not available and SSL3.0 is not enabled?
- # [01:43] * Quits: mr_trousers (Mibbit@B65C3ADB.770AB491.57460053.IP) (Quit: http://www.mibbit.com ajax IRC Client)
- # [01:44] <khuey> kaie or bsmith
- # [01:45] <khuey> or maybe mayhemer
- # [01:46] <mayhemer> IanN: I would have to take a look and I'm right now quit busy
- # [01:46] * Quits: nitot (nitot@moz-A2A3C9E6.vlan402.asr1.cdg3.gblx.net) (Ping timeout)
- # [01:47] * nthomas|away is now known as nthomas
- # [01:47] <IanN> thanks, i'll refer the person with the query to one of them
- # [01:48] * Quits: ejpbruel (ejpbruel@moz-5EE20326.adsl2.static.versatel.nl) (Quit: ejpbruel)
- # [01:48] * Quits: sheppy (sheppy@moz-7EAE095F.sip.tys.bellsouth.net) (Quit: sheppy)
- # [01:49] <edmorley> does anyone know roughly how much time --disable-tests trims off the build time for a non-SSD build?
- # [01:50] <khuey> is it known that egencia doesn't work in nightlies?
- # [01:50] <mccr8> njn: the DOM memory reporter iterates over the currently visible windows, then traces through their documents, or something like that.
- # [01:50] <njn> mccr8: ok, thanks
- # [01:51] <taras> this is probably the wrong channel, but can multiple people admin an addon on amo?
- # [01:51] <mccr8> njn: jst's patch separately keeps track of orphan DOMs, which I guess maybe could have their own set of documents.
- # [01:51] * Quits: Mardak (Mardak@moz-BBE3ABD.mv.mozilla.com) (Quit: Mardak)
- # [01:51] * Quits: mconley (mconley@31ABB91E.F7EBA23.C3C3A9D0.IP) (Input/output error)
- # [01:51] <lurking_work> khuey: I saw someone mention that earlier today - but I was out of IRC most of the day, and only saw in passing - so don't have any context to issue
- # [01:53] <gavin> taras: yes, an addon can have multiple authors
- # [01:53] * Quits: davidb (davidb@moz-6F9F653A.dsl.bell.ca) (Quit: davidb)
- # [01:53] <taras> gavin: thanks
- # [01:54] * Joins: lsumar (lsumar@538BABFE.A073F3E.97BBD552.IP)
- # [01:55] <khuey> lurking_work: yeah that was probably me
- # [01:55] <lurking_work> heh
- # [01:57] * Quits: jwq (jwq@moz-8238A1D6.irl.cri.nz) (Ping timeout)
- # [01:58] * Joins: mzz (marienz@moz-D1CC9ED2.tomaw.net)
- # [01:58] * Joins: mjschranz (mjschranz@6B54A471.531FD64C.630E4E47.IP)
- # [01:59] * Joins: mconley (mconley@moz-9C0F4EBF.cable.teksavvy.com)
- # [02:02] * Quits: smooney (smooney@moz-BBE3ABD.mv.mozilla.com) (Quit: smooney)
- # [02:02] * Quits: jhammel (jhammel@moz-EBD5D56.hsd1.ca.comcast.net) (Quit: saturnalia shopping)
- # [02:03] * Quits: dao (dao@moz-2DD4FBFB.superkabel.de) (Quit: Leaving.)
- # [02:04] * Joins: jduell (jduell@moz-2D9EDA98.lightspeed.sntcca.sbcglobal.net)
- # [02:07] * Quits: mike5w3c (MikeS@moz-82086631.pool.e-mobile.ne.jp) (Ping timeout)
- # [02:07] * Joins: mike5w3c (MikeS@moz-1CC04BF0.pool.e-mobile.ne.jp)
- # [02:08] * Quits: priya (priya@moz-BBE3ABD.mv.mozilla.com) (Quit: This computer has gone to sleep)
- # [02:09] * Quits: mayhemer (Miranda@B3D46202.F87A741B.F23860FD.IP) (Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org)
- # [02:10] * Quits: myk (myk@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net) (Ping timeout)
- # [02:11] * Quits: kumar (kmcmillan@moz-F2D05B8.c3-0.stk-ubr1.chi-stk.il.cable.rcn.com) (Quit: kumar)
- # [02:11] * Quits: gcp (gpascutto@moz-D0E475EA.access.telenet.be) (Quit: Make a new plan, Stan!)
- # [02:13] <gavin> jrmuizel: you never provide enough info in your bugs
- # [02:13] <gavin> is that youtube bug you just filed specific to their html5 player?
- # [02:13] * Quits: mzz (marienz@moz-D1CC9ED2.tomaw.net) (Ping timeout)
- # [02:13] * Parts: cpeterson (cpeterson@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net)
- # [02:14] * adam is now known as adam-afk
- # [02:14] * Quits: IRCMonkey58367 (Tobbi@16BAC97A.933EA279.AC7F8427.IP) (Ping timeout)
- # [02:14] <jrmuizel> gavin: yes sorry
- # [02:14] <jrmuizel> gavin: sometimes I have a bunch of context in my head that I forget is not shared
- # [02:15] * Quits: sicking (chatzilla@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net) (Ping timeout)
- # [02:16] * Joins: jrmuizel_ (jrmuizel@F2D29657.F60B0462.67AC9B1.IP)
- # [02:16] * Joins: jwq (jwq@moz-8238A1D6.irl.cri.nz)
- # [02:17] * Quits: jrmuizel (jrmuizel@F2D29657.F60B0462.67AC9B1.IP) (Ping timeout)
- # [02:18] * Joins: AaronMT (AaronMT@moz-DB17C53A.cpe.net.cable.rogers.com)
- # [02:18] * Quits: zuzelvp (zuzelvp@2112147D.C3507A2D.9A8C35B4.IP) (Ping timeout)
- # [02:18] * Quits: rs (rs@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net) (Quit: ChatZilla 0.9.86.1-rdmsoft [XULRunner 1.8.0.9/2006120508])
- # [02:19] * Joins: zuzelvp (zuzelvp@2112147D.C3507A2D.9A8C35B4.IP)
- # [02:21] * mcote|afk is now known as mcote
- # [02:21] * Quits: janv (varga@moz-C1261AFF.flarion.as5628.telecom.sk) (Quit: This computer has gone to sleep)
- # [02:21] * Joins: Jesse (jruderman@moz-447E6DA0.oc.oc.cox.net)
- # [02:22] * Quits: redfive (chatzilla@moz-B94E1A81.ipnetworksinc.net) (Ping timeout)
- # [02:22] * Quits: sworkman (sworkman@moz-BBE3ABD.mv.mozilla.com) (Ping timeout)
- # [02:22] <gps> sheriff?
- # [02:23] <Jesse> jwir3: reftest-wait
- # [02:23] * Joins: mib_l21wx9 (Mibbit@B65C3ADB.770AB491.57460053.IP)
- # [02:23] * Quits: ewong|afk (chatzilla@moz-83240463.belfordhk.com) (Quit: Reboot)
- # [02:24] <philikon> today it's jst apparently
- # [02:24] <philikon> (sheriff)
- # [02:24] <philor> hahaha
- # [02:24] <philikon> yeah
- # [02:24] <philor> itym "mbrubeck, you still sheriff?"
- # [02:25] <philikon> mbrubeck, philor: gps has a fix for the essentially perma-orange xpcshell test failures that perist after the backout mbrubeck performed
- # [02:25] <gps> so, I have a fix for the oranges on m-c… I think
- # [02:25] <khuey> jst is on vacation
- # [02:25] <philikon> hah
- # [02:26] <gps> I'm not sure what route I should take to get the change in m-c
- # [02:26] * Joins: rwaldron (rwaldron@moz-71B3012E.c3-0.abr-ubr1.sbo-abr.ma.cable.rcn.com)
- # [02:26] * rail-food is now known as rail
- # [02:27] <gps> I'll need https://tbpl.mozilla.org/?tree=Services-Central&rev=c53e7d91cd50 to finish before I know if it fixes everything
- # [02:28] * joduinn is now known as joduinn-brb
- # [02:28] <edmorley> gps: well the tree is already orange, so I say merge s-c to m-c and if the try run or m-c go orange, then that + the whole s-c merge comes out, until such time s-c is green prior to merging
- # [02:28] <edmorley> mbrubeck: are you around? :-)
- # [02:28] * Quits: smaug (chatzilla@moz-1D1B327E.elisa-mobile.fi) (Ping timeout)
- # [02:30] <jrmuizel_> ehsan: http://code.google.com/p/google-breakpad/wiki/SymbolFiles
- # [02:31] * Joins: raccettura (raccettura@moz-660B8F4B.hsd1.nj.comcast.net)
- # [02:31] <edmorley> gps: does that sound fair?
- # [02:31] <gps> edmorley: except the part about merging out all of s-c. but hopefully it won't come to that ;)
- # [02:32] * rail is now known as rail-around
- # [02:32] <diogogmt> anybody knows why when an element is in fullscreen mode the window.innerHeight becomes bigger than the window.outerHeight?
- # [02:32] * Quits: Goldorak (chatzilla@9CD43D39.E6A99E96.187A1082.IP) (Client exited)
- # [02:32] <diogogmt> it gives me a difference of 6px
- # [02:32] <edmorley> gps: hopefully; but tomorrow is uplift day, so kinda have no choice
- # [02:32] <gps> yeah. what time does that happen?
- # [02:33] * Quits: mconley (mconley@moz-9C0F4EBF.cable.teksavvy.com) (Ping timeout)
- # [02:33] <edmorley> varies, but really we need to sort this now, not wait until tomorrow :-)
- # [02:33] <gps> I know. I have every intention of watching the tree and trying patches to get things green
- # [02:34] <gps> if only things would #buildfaster
- # [02:34] * Joins: ewong|afk (chatzilla@moz-B5A86794.com)
- # [02:35] <gps> OK, I'll merge s-c into m-c and hope for the best
- # [02:35] <gps> if not, then I guess it will be a long night
- # [02:35] * ewong|afk is now known as ewong
- # [02:35] <IanN> hmmm, my title bar's disappeared for one of my browser windows on Gnome3 :(
- # [02:35] * Joins: anant_ (anant@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net)
- # [02:35] * Quits: anant_ (anant@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net) (Quit: anant_)
- # [02:36] <firebot> Check-in: http://hg.mozilla.org/mozilla-central/rev/c53e7d91cd50 - Gregory Szorc - Bug 711263 - Don't register AddonsReconciler unless addons engine is enabled; r=philikon
- # [02:36] <IanN> and now it has reappeared
- # [02:36] <IanN> i'm sure Gnome3 is still flaky
- # [02:36] * Quits: anant (anant@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net) (Ping timeout)
- # [02:36] * bkero has been using it for about a month now with no issues like that O_o
- # [02:36] <edmorley> gps: fingers crossed :-)
- # [02:36] * Quits: mjschranz (mjschranz@6B54A471.531FD64C.630E4E47.IP) (Client exited)
- # [02:37] * Quits: clee (clee@moz-BBE3ABD.mv.mozilla.com) (Quit: clee)
- # [02:38] <mbrubeck> edmorley, gps: I'm back... reading scrollback
- # [02:38] <IanN> i also seem to have cursor click point issues, perhaps it is because i am using it with compiz
- # [02:38] <mbrubeck> okay, good, I see the fix is on m-c
- # [02:38] <gps> hopeful fix
- # [02:38] * Joins: mconley (mconley@moz-9C0F4EBF.cable.teksavvy.com)
- # [02:38] * Quits: timA (tabraldes@moz-535753DA.hsd1.or.comcast.net) (Quit: Instantbird 1.2a1pre)
- # [02:40] * Quits: Joeh (joe@5A3923AA.BC22908.C7CEC4ED.IP) (Connection reset by peer)
- # [02:41] <gps> OK. I'm transitioning to home (so I don't get stuck at the office trying to fix oranges all night)
- # [02:42] <gps> I should be back by the time https://tbpl.mozilla.org/?tree=Services-Central&rev=c53e7d91cd50 or the m-c builds start finishing
- # [02:42] * Joins: lmandel (lmandel@moz-113D7D7C.cable.teksavvy.com)
- # [02:42] * Joins: sworkman (sworkman@moz-BBE3ABD.mv.mozilla.com)
- # [02:42] * Joins: mjschranz (mjschranz@6B54A471.531FD64C.630E4E47.IP)
- # [02:43] <jlebar> diogogmt, If it happens in the nightly builds, that sounds like a bug.
- # [02:43] * Quits: bmoss (bmoss@moz-BBE3ABD.mv.mozilla.com) (Quit: bmoss)
- # [02:43] * Joins: RyanVM (chatzilla@moz-D04D3C77.phlapa.fios.verizon.net)
- # [02:43] <RyanVM> khuey: ping
- # [02:44] <khuey> RyanVM: pong
- # [02:44] <RyanVM> did an experiment tonight with js pgo
- # [02:44] <RyanVM> I added v8 and kraken to the pages that get run during the profiling run
- # [02:44] <jlebar> ooh
- # [02:44] <RyanVM> interestingly enough, ss and v8 scores actually got a bit worse vs the default pgo suite
- # [02:44] <RyanVM> but kraken improved
- # [02:45] <jlebar> RyanVM, by how much?
- # [02:45] <diogogmt> jlebar: yep, I'm running on a nightly
- # [02:45] <jlebar> diogogmt, please file a bug.
- # [02:45] <diogogmt> shouldn't the inner/outterWidthHeight have the same values once the element is in fullscreen?
- # [02:45] <khuey> yeah, that's not surprising
- # [02:45] <diogogmt> jlebar: ok
- # [02:45] <khuey> it tunes less toward sunspider specifically
- # [02:46] <jlebar> diogogmt, yes, I'd expect inner/outter to have the same values. But even if not, the inner shouldn't be bigger than the outer for any reason I know of.
- # [02:47] <RyanVM> no-PGO, default-PGO, ryanvm-PGO
- # [02:47] <RyanVM> ss 224.8ms +/- 0.6%, 194.3ms +/- 1.3%, 197.5ms +/- 0.7%
- # [02:47] <RyanVM> v8 6470, 6781, 6741
- # [02:47] <RyanVM> kr 3405.4ms +/- 0.6%, 3271.8ms +/- 1.0%, 3183.8ms +/- 0.8%
- # [02:47] <khuey> is this with PGOing hte js engine?
- # [02:47] <khuey> cause we don't do that by default
- # [02:47] <RyanVM> yes
- # [02:47] <RyanVM> easy to turn back on for personal builds, though :)
- # [02:47] * Quits: yuan (ywang@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net) (Quit: yuan)
- # [02:47] <jlebar> That's a pretty small kracken change...
- # [02:48] * KaIRC is now known as KaiRo
- # [02:48] <jlebar> If anything, this suggests that there aren't huge wins to be had from changing our PGO scripts, which is nice to know...
- # [02:48] <jrmuizel_> BenWa: http://code.google.com/p/google-breakpad/wiki/SymbolFiles
- # [02:48] * Quits: mconley (mconley@moz-9C0F4EBF.cable.teksavvy.com) (Connection reset by peer)
- # [02:48] * philor is now known as philor|away
- # [02:48] * Joins: anant (Anant@moz-271479F2.hsd1.ca.comcast.net)
- # [02:48] <RyanVM> jlebar: about 2.7% for Kraken
- # [02:48] * Quits: Enn (enn@moz-DB6467E3.cpe.net.cable.rogers.com) (Ping timeout)
- # [02:48] * Joins: mconley (mconley@moz-9C0F4EBF.cable.teksavvy.com)
- # [02:48] <jlebar> yeah.
- # [02:49] <jlebar> I guess that's not "pretty small".
- # [02:49] <jlebar> "small-ish"?
- # [02:49] <jlebar> non-large.
- # [02:49] <RyanVM> jlebar: but yeah, it's been something that's been bugging me for awhile
- # [02:49] * Joins: nattokirai (nattokirai@moz-C97EE7C8.dynamic.ppp.asahi-net.or.jp)
- # [02:49] <RyanVM> i'm going to try kraken-only and v8-only version of the pgo script too
- # [02:49] <jlebar> RyanVM, I'd be curious how a pgo script which loads gmail does.
- # [02:49] <jlebar> (tune for my personal use-case.)
- # [02:49] <RyanVM> hah
- # [02:49] <RyanVM> i can try it
- # [02:50] <khuey> or one that submits patches to bugzilla
- # [02:50] <jlebar> khuey, that seems to be gated on our hamster-powered computers, atm.
- # [02:50] <jlebar> the hamsters can only run through teh tubes so fast!
- # [02:51] * Joins: redfive (chatzilla@moz-B94E1A81.ipnetworksinc.net)
- # [02:51] * Quits: jrmuizel_ (jrmuizel@F2D29657.F60B0462.67AC9B1.IP) (Input/output error)
- # [02:51] <RyanVM> jlebar: I also want to play with adding more to the pgo suite, like media, canvas, etc
- # [02:51] <jlebar> I know our IT is in a sad state right now, but slow bugzilla sucks. And it's slow even when it's not running off the failover machine.
- # [02:52] * jlebar nods
- # [02:52] <RyanVM> jlebar: would be interesting to see what we can get with some of that code actually getting used
- # [02:52] * bkero is going to blame connectivity issues in phx
- # [02:52] <RyanVM> right now, only about 2% of libxul gets optimized for speed on a PGO run
- # [02:52] <ewong> no eta on phx being back up 100%?
- # [02:52] <bkero> I don't believe we've had any hardware issues with anything related to bugzilla
- # [02:53] <RyanVM> (btw, my JS change bumped mozjs from 2.5% to 4.0%)
- # [02:53] <khuey> well, we don't want all the code to be optimized for speed :-P
- # [02:53] <RyanVM> sure, but that doesn't mean there isn't room for improvement
- # [02:54] <RyanVM> we just don't know where that upper limit lives
- # [02:54] <RyanVM> but I do believe we can stand to be smarter about what we try to optimize w/ PGO
- # [02:55] * Quits: Mook_as (mook@moz-1FCC0032.activestate.com) (Quit: ChatZilla 0.9.87-rdmsoft [XULRunner 1.9.2.13/20101203074205])
- # [02:55] * jmaher|afk is now known as jmaher
- # [02:55] * Quits: IanN (chatzilla@moz-3F5A461C.cable.virginmedia.com) (Quit: ChatZilla 0.9.87 [SeaMonkey 2.8a1/20111217163420])
- # [02:58] * Quits: sworkman (sworkman@moz-BBE3ABD.mv.mozilla.com) (Ping timeout)
- # [02:59] * Quits: ehsan (ehsan@F2D29657.F60B0462.67AC9B1.IP) (Input/output error)
- # [03:00] * Joins: ehsan (ehsan@F2D29657.F60B0462.67AC9B1.IP)
- # [03:01] <RyanVM> anyhoo, I'll keep plugging away and let you know if I find anything interesting
- # [03:01] * Quits: ehsan (ehsan@F2D29657.F60B0462.67AC9B1.IP) (Input/output error)
- # [03:02] * Joins: lsumar_ (lsumar@E2F7352.56080C53.97BBD552.IP)
- # [03:02] * Quits: lsumar (lsumar@538BABFE.A073F3E.97BBD552.IP) (Ping timeout)
- # [03:04] * Quits: AaronMT (AaronMT@moz-DB17C53A.cpe.net.cable.rogers.com) (Quit: Textual IRC Client: http://www.textualapp.com/)
- # [03:05] * Ziggy_Maes is now known as Ziggy|AWAY
- # [03:06] * Joins: Enn (enn@moz-DB6467E3.cpe.net.cable.rogers.com)
- # [03:07] * Joins: sworkman (sworkman@moz-BBE3ABD.mv.mozilla.com)
- # [03:09] * Joins: anky (anky@56E2009D.18C7E222.A3D1B221.IP)
- # [03:09] * Joins: Boriss_ (FlyingToas@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net)
- # [03:09] * Quits: Boriss_ (FlyingToas@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net) (Quit: Boriss_)
- # [03:10] * Quits: Boriss (FlyingToas@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net) (Ping timeout)
- # [03:10] * Quits: sworkman (sworkman@moz-BBE3ABD.mv.mozilla.com) (Ping timeout)
- # [03:11] * Joins: m_kato (m_kato@moz-348F61F0.mozilla.or.jp)
- # [03:11] <jdm> taras: NS_ABORT_IF_FALSE is debug only :(
- # [03:13] * Joins: clee (clee@moz-E3C0B5D0.hsd1.ca.comcast.net)
- # [03:13] * Quits: clee (clee@moz-E3C0B5D0.hsd1.ca.comcast.net) (Quit: clee)
- # [03:13] <edmorley> gps: sadly looks like xpcshell is failing still
- # [03:13] * Joins: Tobbi (Tobbi@16BAC97A.933EA279.AC7F8427.IP)
- # [03:14] <gps> edmorley: I just saw that and it has me scratching my head
- # [03:14] <gps> not happening on my local machine
- # [03:14] <edmorley> gps: what do you think the best course of action is now?
- # [03:14] * Tobbi is now known as IRCMonkey57045
- # [03:14] <gps> I want to see if all the builds fail that way
- # [03:14] <gps> the error implies a syntax error
- # [03:15] * Quits: rwaldron (rwaldron@moz-71B3012E.c3-0.abr-ubr1.sbo-abr.ma.cable.rcn.com) (Quit: Leaving...)
- # [03:16] * Quits: mccr8 (mccr8@moz-BBE3ABD.mv.mozilla.com) (Quit: mccr8)
- # [03:16] * Joins: jrmuizel (jrmuizel@moz-20EF8EAA.cpe.net.cable.rogers.com)
- # [03:17] <gps> what the? did I forget to check in a file?
- # [03:17] * Quits: jduell (jduell@moz-2D9EDA98.lightspeed.sntcca.sbcglobal.net) (Ping timeout)
- # [03:19] * lsblakk is now known as lsblakk|afk
- # [03:19] * Joins: sworkman (sworkman@moz-BBE3ABD.mv.mozilla.com)
- # [03:19] * Joins: Mossop (mossop@moz-E325C2EC.dsl.dynamic.sonic.net)
- # [03:22] * Joins: Waldo (waldo@moz-534B4EF1.hsd1.mi.comcast.net)
- # [03:23] * lsumar_ is now known as lsumar
- # [03:23] <bholley> philikon, khuey: maybe let's just talk here
- # [03:23] * joduinn-brb is now known as joduinn
- # [03:23] * bholley keeps getting mid-air collisions on bugzilla
- # [03:23] <ewong> yeah.. been getting that a lot lately
- # [03:24] <philikon> bholley: hi
- # [03:24] <bholley> philikon: hi
- # [03:24] * Quits: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com) (Quit: nhirata)
- # [03:24] <bholley> philikon: so your issue is that you can't QI to the desired interface at all?
- # [03:24] <philikon> it looks like it
- # [03:25] <bholley> philikon: which scriptable helper does it have?
- # [03:25] <khuey> yeah, this is something different than what I thought then
- # [03:25] * Joins: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP)
- # [03:25] * Quits: caillon (caillon@moz-359E39FC.lightspeed.sntcca.sbcglobal.net) (Ping timeout)
- # [03:25] <bholley> philikon: DOM_DEFAULT_SCRIPTABLE_FLAGS includes nsIXPCScriptable::CLASSINFO_INTERFACES_ONLY
- # [03:26] <philikon> bholley: this is the patch: https://hg.mozilla.org/users/pweitershausen_mozilla.com/mq-b2g/file/f8e5675de95d/709568-smsmessage
- # [03:27] <philikon> bholley: basically i wanted to add a js-accessible, but chrome-only way of creating an SmsMessage object with some initial data
- # [03:27] * philor|away is now known as philor
- # [03:27] <philikon> bholley: so i added nsISmsMessage which would have the privileged stuff in it
- # [03:28] <taras> jdm: :(
- # [03:28] <philikon> bholley: i just extended the existing boiler plate and i'm nto very well versed with xpcom c++ stuff, so i have no idea what those things you just mentioned are or mean
- # [03:28] * Joins: caillon (caillon@moz-359E39FC.lightspeed.sntcca.sbcglobal.net)
- # [03:28] <jlebar> bholley, Dumb question, but how do I install git bz?
- # [03:28] <gps> wait. is my file system not case sensitive?
- # [03:29] <philikon> osx is case sensitive but case smashing
- # [03:29] <gps> is the OS X file system not case sensitive?
- # [03:29] <jbuck> if you're on a mac, it's case-aware but case-insensitive, yes
- # [03:29] <hub> gps: not by default
- # [03:29] <jbuck> you can verify this by going to Disk Utility
- # [03:29] <jbuck> it'll tell yo
- # [03:29] <jbuck> u
- # [03:29] <hub> gps: it is just case preserving by default
- # [03:29] <hub> too many software fail to run on case-sensitive
- # [03:29] * Quits: tanvi (tanvi@moz-BBE3ABD.mv.mozilla.com) (Quit: Leaving.)
- # [03:29] * Quits: jet (junglecode@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net) (Quit: jet)
- # [03:30] * Quits: mjschranz (mjschranz@6B54A471.531FD64C.630E4E47.IP) (Ping timeout)
- # [03:30] <bholley> jlebar: pull it somewhere, then put something like this in your gitconfig
- # [03:30] * Joins: birtles (chatzilla@moz-348F61F0.mozilla.or.jp)
- # [03:30] * Quits: @dveditz (dveditz@moz-BBE3ABD.mv.mozilla.com) (Quit: dveditz)
- # [03:31] <khuey> git?
- # [03:31] <khuey> jlebar: Y U TRAITOR?
- # [03:31] <bholley> jlebar: it needs to be in your path
- # [03:31] * Joins: jprmc (jprmc@moz-7F2FF3EB.cpe.net.cable.rogers.com)
- # [03:31] <bholley> philikon: yeah, it looks like MozSmsMessage uses DOM_DEFAULT_SCRIPTABLE_FLAGS
- # [03:31] <jlebar> khuey, B2G uses git, and a hg + git workflow is sufficiently painful to make me try a git-only workflow.
- # [03:32] <jlebar> khuey, I've already footgun'ed once.
- # [03:32] <bholley> jlebar: you should try multiple workdirs if you haven't already ;-)
- # [03:33] <philor> firebot: bug 629595
- # [03:33] <jlebar> bholley, I was reading through your blog post from last year; there's a lot of good stuff in there.
- # [03:33] <firebot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=629595 maj, --, ---, nobody, NEW, [OMG NOT FIREFOX!!!!! SeaMonkey] mochitests-1: permanent "test_webgl_conformance_test_suite.html | C
- # [03:33] <jlebar> bholley, but what's the gitconfig magic?
- # [03:33] * Quits: jprmc (jprmc@moz-7F2FF3EB.cpe.net.cable.rogers.com) (Ping timeout)
- # [03:33] <philor> how many exclamations does that need, to actually persuade people?
- # [03:33] <bholley> jlebar: the stuff I pastebin-ed you?
- # [03:33] * Quits: chrisccoulson (chr1s@moz-692D94C8.cust-3601.ip.static.uno.uk.net) (Ping timeout)
- # [03:33] <jwir3> philor: at least 3
- # [03:33] <jlebar> <bholley> jlebar: pull it somewhere, then put something like this in your gitconfig
- # [03:33] <philikon> bholley: um ok. i have no idea what that means
- # [03:33] <bholley> philikon: sec
- # [03:33] <philikon> bholley: what should i do to fix?
- # [03:33] <jlebar> bholley, I don't see a URL in my client.
- # [03:33] <philor> it has 5, and that's not enough - at least 3 more?
- # [03:33] <khuey> philor: I --d sicking already for that today
- # [03:34] <bholley> jlebar: oh, I never actually pasted it :-(
- # [03:34] <bholley> jlebar: http://pastebin.mozilla.org/1413061
- # [03:34] <jwir3> philor: nah, I meant it needs at least 3 total. ;)
- # [03:35] <jlebar> bholley, thanks.
- # [03:35] <jlebar> bholley, I don't need to point git at the plugin itself?
- # [03:35] <philor> mmm, bz's failing jsreftests, isn't this where I came in this morning?
- # [03:35] <bholley> jlebar: I _think_ the directory just needs to be in your path
- # [03:35] <jlebar> bizarre.
- # [03:35] <bholley> jlebar: I have it in ~/sw/git-bz
- # [03:36] <bholley> jlebar: you're pulling git-bz-moz right
- # [03:36] <bholley> jlebar: the one off my github
- # [03:36] <jlebar> bholley, yeah
- # [03:37] <gps> are the OS X build machines using case sensitive file systems?
- # [03:37] * Quits: Callek (chatzilla@moz-DD17331C.dhcp.oxfr.ma.charter.com) (Ping timeout)
- # [03:37] <bholley> jlebar: git foo is just an alias for git-foo
- # [03:37] <bholley> for most values of foo
- # [03:37] * Quits: chewey (chewey@moz-F80275DC.dip0.t-ipconnect.de) (Ping timeout)
- # [03:37] <jlebar> I see.
- # [03:38] * bholley goes back to looking at philikon's patch
- # [03:38] * Joins: chewey (chewey@moz-E0C199AC.dip0.t-ipconnect.de)
- # [03:39] * irving|away is now known as irving
- # [03:40] <gps> edmorley: I think it was a filename case issue. I've pushed a fix to s-c
- # [03:40] <gps> should I wait for mochitests to come back on the original s-c build or merge s-c to m-c right away?
- # [03:41] * Joins: Callek (chatzilla@moz-DD17331C.dhcp.oxfr.ma.charter.com)
- # [03:41] <gps> hey good news - mochitests on Linux64 opt are green!
- # [03:41] <edmorley> ah the joys of OS case sensitivity variations :-)
- # [03:41] * Quits: mib_l21wx9 (Mibbit@B65C3ADB.770AB491.57460053.IP) (Quit: http://www.mibbit.com ajax IRC Client)
- # [03:41] <edmorley> I say merge :-)
- # [03:42] * heycam is now known as heycam|away
- # [03:42] <lurking_work> there are still some un-starred X shell tests failing but appears to me at least that issue is already known ?
- # [03:42] <gps> and pushed!
- # [03:43] * Joins: bent (chatzilla@moz-DB4C5E15.triad.res.rr.com)
- # [03:43] <firebot> Check-in: http://hg.mozilla.org/mozilla-central/rev/0885bdf12669 - Gregory Szorc - Bug 711263 - Fix filename case in Cu.import(); r=bustage
- # [03:43] <gps> lurking_work: the last round was due to my stupidity which was due to a known issue
- # [03:43] <lurking_work> ok
- # [03:43] <gps> they should hopefully go away on the next build
- # [03:43] <lurking_work> k
- # [03:44] <gps> well, the xpcshell and other mochitests failures were mine
- # [03:44] <philor> anybody cc'ed on bug 624621, who can paste a backout message in there?
- # [03:44] <gps> the android XUL and mochitest 1 on windows shouldn't be me (hopefully)
- # [03:44] <bholley> khuey: how skittish are we about putting non DOM properties and methods on DOM objects?
- # [03:44] <khuey> bholley: what do you mean?
- # [03:45] <edmorley> philor: you doing the backout?
- # [03:45] <philor> edmorley: yeah, finally it's my turn
- # [03:45] <bholley> khuey: like, take the case of FileReader
- # [03:45] <philikon> bholley: you mean just folding the interfaces together?
- # [03:45] <mbrubeck> philor: Yeah, I had a bit of deja vu when I looked at inbound just now
- # [03:45] <bholley> philikon: no
- # [03:45] <bholley> philikon: keeping them separate
- # [03:45] <bholley> philikon: there are 2 issues in your case. The first is exposing the method, the second is making it chrome-only
- # [03:45] <philikon> ok i'll let you finish your thought
- # [03:46] <philikon> right
- # [03:46] <bholley> philikon: the second has to be done with an explicit security check
- # [03:46] * Quits: mgoodwin_ (mgoodwin@moz-4BB9E5E9.cable.virginmedia.com) (Ping timeout)
- # [03:46] <philikon> yeah i have that in there
- # [03:46] <khuey> bholley: there are plenty of dom objects with other interfaces on them
- # [03:46] * Quits: andreasn (andreasn@moz-3CDFCC6A.a336.corp.bahnhof.se) (Ping timeout)
- # [03:46] <bholley> khuey: and we don't care about polluting them with our stuff?
- # [03:46] <bholley> khuey: it seems weird, given that we're -moz-prefix-crazy in other areas
- # [03:46] * Joins: mgoodwin (mgoodwin@moz-4BB9E5E9.cable.virginmedia.com)
- # [03:47] <Waldo> hm, whither bz...
- # [03:47] <khuey> bholley: that really depends on what it is
- # [03:47] <gps> w00t - more mochitests on s-c are going green. I'm optimistic m-c will go green with the latest commit
- # [03:48] <bholley> khuey: explain?
- # [03:48] <khuey> bholley: if you're talking about extra stuff hanging off of dom interfaces, we generally do care
- # [03:49] <khuey> bholley: if we're talking about extra interfaces, we generally don't
- # [03:49] <mbrubeck> hmm, what's with the 5516 failures in mochitest-browser-chrome on s-c?
- # [03:49] * Quits: felipe|tab (AndChat@moz-BBE3ABD.mv.mozilla.com) (Quit: Bye)
- # [03:49] * Waldo sees philor Being Bold
- # [03:49] <bholley> khuey: even though the extra interfaces cause extra properties and methods to appear on objects supposedly implementing the dom interfaces we care about keeping clean?
- # [03:50] * Joins: jorendorff (jorendorff@moz-91590D94.hsd1.tn.comcast.net)
- # [03:51] <philor> Waldo: just too bad he's not on irc, so I could both tell him I backed him out, and explain the JS Way of dealing with such a situation, declare the test stupid and remove it
- # [03:51] <khuey> bholley: well, that depends on whether they're in classinfo or not
- # [03:51] <philor> oh, wait, it's a test he wrote, isn't it?
- # [03:51] <khuey> that doesn't mean it's not stupid
- # [03:51] * Quits: lurking_work (chatzilla@moz-107FCDBA.hfc.comcastbusiness.net) (Quit: ChatZilla 0.9.87 [Firefox 8.0/20111104165243])
- # [03:51] <mbrubeck> and did I already just retrigger this test or not?
- # [03:52] <Waldo> philor: looks like the test is indeed stupid, probably has an easy fix, but yeah, that's beep beep beep territory :-)
- # [03:52] <bholley> khuey: if they're not classinfo, you can't get to them, because you can't QI to them (unless they're elements)
- # [03:52] <Waldo> security stuff like that's too difficult to eyeball a fix for the entire set of all test suites
- # [03:52] <khuey> bholley: elements are a lot of the dom ;-)
- # [03:52] <Waldo> although
- # [03:52] * Waldo gives the Evil Eye to a test checking exact error message syntax
- # [03:52] <bholley> khuey: well, suppose we're not talking about elements
- # [03:53] <bholley> khuey: and we're talking about philikon's MozSmsMessage
- # [03:54] <bholley> khuey: maybe philikon should just expose nsIInterfaceRequestor
- # [03:54] <bholley> khuey: and do the security check there
- # [03:54] <bholley> it looks like we're certainly comfortable exposing getInterface
- # [03:54] * Quits: jwq (jwq@moz-8238A1D6.irl.cri.nz) (Ping timeout)
- # [03:55] <philikon> aren't we exposing that on pretty much anything?
- # [03:55] <philikon> i don't really want ot rethink our DOM bindings :)
- # [03:55] * Quits: Callek (chatzilla@moz-DD17331C.dhcp.oxfr.ma.charter.com) (Ping timeout)
- # [03:55] <bholley> philikon: exposing what? nsIInterfaceRequestor?
- # [03:56] <philikon> getInterface
- # [03:56] <bholley> philikon: I only see it on XHR and FileReader
- # [03:56] <philikon> that's on pretty much anything
- # [03:56] <bholley> philikon: in XPCOM maybe, but not on dom objects
- # [03:56] <philikon> window.getInterface
- # [03:56] <khuey> windows are weird too
- # [03:57] <philikon> hmm, i guess that's perhaps the only thing
- # [03:57] <khuey> bholley: I wouldn't think about it too hard
- # [03:57] <philikon> ic
- # [03:57] <bholley> khuey: ok, thanks. Also, is IsCapabilityEnabled("UniversalXPConnect") still the preferred way of detecting system principal?
- # [03:58] <philikon> bholley: i'm using nsContentUtils::IsCallerChrome()
- # [03:58] * Quits: anky (anky@56E2009D.18C7E222.A3D1B221.IP) (Client exited)
- # [03:58] <philikon> bholley: so i should just look at what XHR does?
- # [03:58] <bholley> philikon: I don't see it in the patch. Maybe it's somewhere else?
- # [03:58] <philikon> and copy their stuff?
- # [03:58] <khuey> IsCapabilityEanbled("UniversalXPConnect") doesn't detect system principal ...
- # [03:58] <philikon> bholley: i just pushed that bit
- # [03:58] <philikon> bholley: i hadn't pushed it yet
- # [03:58] <khuey> it detects whether or not your principal has the UniversalXPConnect capability
- # [03:59] <khuey> as one might exepct
- # [03:59] <khuey> *expect
- # [03:59] * Joins: tonymec (tonymec@6174664F.9256CA4D.277517C1.IP)
- # [03:59] <bholley> khuey: which you have, if you're system principal
- # [03:59] <khuey> sure
- # [03:59] <khuey> but you can have it and not be system principal
- # [03:59] <bent> that whole api is going away some day
- # [03:59] <bholley> khuey: because of enablePrivilege
- # [03:59] <khuey> exhibit a: mochitest
- # [03:59] <khuey> bent: right
- # [03:59] <khuey> but not today
- # [04:00] <bholley> philikon: so, do you want the interface to be chrome only? or just the method
- # [04:00] * Joins: kenny (kenny@moz-7EAF8A2D.hsd1.wa.comcast.net)
- # [04:00] <philikon> the interface, i guess
- # [04:01] * Quits: Pike (Pike@moz-5E07E9D5.dip.t-dialin.net) (Quit: ChatZilla 0.9.87 [Firefox 8.0.1/20111120135848])
- # [04:01] <bent> philikon, i thought we didn't have any "chrome"in b2g?
- # [04:01] <philikon> um
- # [04:01] * Joins: davidb_ (davidb@moz-6F9F653A.dsl.bell.ca)
- # [04:01] <philikon> whatever you call xpcom components then
- # [04:02] <philikon> (and yes, we do have a tiny chrome shell)
- # [04:02] <philikon> (but this isn't about that)
- # [04:02] <philikon> bent: i need to create sms message objecdts in nsTelephonyWorker
- # [04:02] <bent> this is sms stuff right?
- # [04:02] <philikon> which means i need to create them from JS
- # [04:02] <philikon> yes
- # [04:02] <bent> oh in the component
- # [04:02] <philikon> right
- # [04:02] <bent> not in the web page
- # [04:02] <bent> aha
- # [04:02] <philikon> no
- # [04:02] * bent gets with it
- # [04:02] <philikon> :)
- # [04:03] <bholley> philikon: so, my initial idea was to use nsIInterfaceRequestor, and do the security check within getInterface
- # [04:03] <bholley> philikon: but I'm concerned that XPConnect might get confused
- # [04:03] * Joins: rwaldron (rwaldron@moz-71B3012E.c3-0.abr-ubr1.sbo-abr.ma.cable.rcn.com)
- # [04:04] <bholley> philikon: you'd need to have a different class
- # [04:04] <khuey> why would it get confused?
- # [04:04] * Quits: Enn (enn@moz-DB6467E3.cpe.net.cable.rogers.com) (Ping timeout)
- # [04:04] <philikon> bholley: hwo would that work?
- # [04:05] <philor> and there's roc's ticket to ride...
- # [04:05] <bholley> khuey: pointers of different types to the same object, some secure some not
- # [04:06] <bholley> khuey: I'm worried that if chrome got the chrome-only interface, content would get it via XPCWrappedNative::GetNewOrUsed
- # [04:06] <bholley> khuey: if getInterface just returned a QI-ed version of itself
- # [04:06] <roc> hmm?
- # [04:07] <bholley> philikon: I think your best bet is to add your new interface here: http://mxr.mozilla.org/mozilla-central/source/dom/base/nsDOMClassInfo.cpp#1399
- # [04:07] <philor> roc: 10.6 debug, your reftest failed
- # [04:07] <roc> gah!
- # [04:07] <bholley> philikon: and do a security check in each method you add that you want to be chrome-only
- # [04:07] * Quits: juanb (jbecerra@moz-BBE3ABD.mv.mozilla.com) (Quit: juanb)
- # [04:07] <roc> only two pixels off
- # [04:07] * Quits: Mossop (mossop@moz-E325C2EC.dsl.dynamic.sonic.net) (Ping timeout)
- # [04:08] <roc> I'll back out
- # [04:08] <philikon> bholley: i see no mentions of interfaces here
- # [04:08] * Quits: davidb_ (davidb@moz-6F9F653A.dsl.bell.ca) (Quit: davidb_)
- # [04:08] <khuey> bholley: how would that work at all
- # [04:08] <philor> oh, good, an explosion of red, that must signal something nice
- # [04:08] * Joins: Mossop (mossop@moz-E325C2EC.dsl.dynamic.sonic.net)
- # [04:08] <philor> watermelon?
- # [04:08] <khuey> bholley: those interfaces have to be in the QI impl to work
- # [04:08] <bholley> philikon: interfaces where?
- # [04:08] <philikon> the link you just pointed me at!
- # [04:08] <philor> no, dns failure
- # [04:08] <bholley> philikon: sorry, here: http://mxr.mozilla.org/mozilla-central/source/dom/base/nsDOMClassInfo.cpp#3929
- # [04:09] <philikon> bholley: so how is that different from just folding the two interfaces?
- # [04:09] * bholley points philikon to khuey
- # [04:09] <philikon> this is khuey
- # [04:09] <philikon> 's questions
- # [04:10] <khuey> THIS IS KHUEY
- # [04:10] <philikon> from earlier
- # [04:10] <philikon> sorry, hit enter instead of apostrophe ;)
- # [04:10] <dolske> NO, I'M SPARTACUS!
- # [04:10] <khuey> philikon: that particular question was rhetorical
- # [04:10] <philikon> damn yanks and their keyboard layouts ;)
- # [04:10] <khuey> I'm pretty sure there is no difference
- # [04:10] <philikon> right
- # [04:10] <philikon> my point
- # [04:10] <philikon> might as well just fold it in no?
- # [04:11] <philikon> until we fix bug 712199 :)
- # [04:11] <philikon> and by we i mean bholley ;)
- # [04:11] <bholley> philikon: it's not a bug
- # [04:11] <philor> edmorley: second opinion - close for infra?
- # [04:11] <bholley> philikon: what is the bug there?
- # [04:11] <bholley> philikon: I'm just about to resolve it INVALID
- # [04:11] <philikon> is it not?
- # [04:11] <philikon> i really have no clue what's going on
- # [04:11] <philikon> did you guys come to the conclusion it's not a bug?
- # [04:12] <bholley> philikon: your class passes a flag to xpconnect that says "don't let me be QIed to anything that's not in classinfo!"
- # [04:12] <khuey> yeah, it's not a bug
- # [04:12] <philikon> oh
- # [04:12] <philikon> what's the flag?
- # [04:12] <bholley> philikon: CLASSINFO_INTERFACES_ONLY
- # [04:12] <edmorley> philor: agreed
- # [04:13] <bholley> philikon: it's part of DOM_DEFAULT_SCRIPTABLE_FLAGS, used here: http://mxr.mozilla.org/mozilla-central/source/dom/base/nsDOMClassInfo.cpp#1399
- # [04:13] <philikon> aaah
- # [04:13] * philor changes topic to 'm-c: CLOSED m-i: CLOSED (infra) || Next aurora uplift: 20th Dec || If you are new or want to help, see irc://irc.mozilla.org/#introduction || "if you like the way it's working, just you wait five minutes"'
- # [04:13] <bholley> philikon: you could just not pass that flag, but nobody else does that, so I'm afraid
- # [04:13] <philikon> bholley: thanks for explainin!
- # [04:13] * Joins: jwq (jwq@moz-8238A1D6.irl.cri.nz)
- # [04:13] <khuey> what's the worst that could happen?
- # [04:14] <bholley> philikon: :-)
- # [04:14] <bent> security bugs?
- # [04:14] <bent> :)
- # [04:14] <philikon> pah, who expects security with their sms
- # [04:14] * Joins: rniwa_ (rniwa@5CA6DC39.C60FE7DC.4065847B.IP)
- # [04:14] * bholley has to go
- # [04:14] <philikon> bholley: thanks!
- # [04:14] <bent> could you just add your interface to its classinfo list?
- # [04:14] <bholley> bent: this was my eventual suggestion
- # [04:15] <bent> sounds pretty simple, low risk
- # [04:15] <bholley> bent: philikon wants to fold it with the DOM interface, I think that's probably bad form, but don't really know
- # [04:15] <bholley> anyway, /me points philikon to bent
- # [04:15] * bent points to... um... jst!
- # [04:15] <khuey> bent: what's a few sg:crits between friends?
- # [04:15] <bholley> jst is in finland
- # [04:15] <bent> too bad he's in finlane
- # [04:15] <bent> yeah
- # [04:15] * bholley heads out
- # [04:15] * Quits: bholley (bholley@moz-7B0110AD.mv.mozilla.com) (Quit: bholley)
- # [04:16] <bent> khuey, we're friends with... the internet
- # [04:16] <khuey> I'm pretty sure most of us hate the web
- # [04:17] <jdm> I frequently steal its lunch money
- # [04:18] * khuey gives up trying to understand this crazy bug
- # [04:18] * khuey -> out
- # [04:18] * khuey is now known as khuey|away
- # [04:18] <philikon> i really don't care either way
- # [04:19] <philikon> i'm happy to add my iface to the class info
- # [04:19] <dolske> i'm happy to add my oface to the... wait, what?
- # [04:20] * Quits: sworkman (sworkman@moz-BBE3ABD.mv.mozilla.com) (Ping timeout)
- # [04:20] <philikon> i don't want to see your oface kthx
- # [04:20] <dolske> :P
- # [04:20] <Unfocused> ANYWAY
- # [04:21] <bent> philikon, i'd do that, yeah
- # [04:21] <philikon> mfb(ed)t
- # [04:21] <bent> heh
- # [04:21] <gps> OK, now what's wrong with the tree?
- # [04:21] <philikon> bent: cool!
- # [04:21] <philikon> gps: infra
- # [04:21] <philikon> i think philor wants to close it
- # [04:22] * Quits: hub (hub@21B7B9F2.B87E9213.6E712CE2.IP) (Ping timeout)
- # [04:22] <gps> ?
- # [04:22] <bent> according to status he did i think
- # [04:22] <bent> er
- # [04:22] <bent> topic
- # [04:22] <philikon> oh yeah it's closed
- # [04:22] <philor> status, too - maybe just a hiccup in dns, may be over already, not sure
- # [04:23] <gps> did I miss something?
- # [04:23] <gps> what status?
- # [04:26] * Quits: rniwa (rniwa@5CA6DC39.C60FE7DC.4065847B.IP) (Quit: rniwa)
- # [04:26] * rniwa_ is now known as rniwa
- # [04:28] * bwinton is now known as bwinton_away
- # [04:29] * Quits: mconley (mconley@moz-9C0F4EBF.cable.teksavvy.com) (Input/output error)
- # [04:30] * philor changes topic to 'm-c: OPEN m-i: OPEN || Next aurora uplift: 20th Dec || If you are new or want to help, see irc://irc.mozilla.org/#introduction || "if you like the way it's working, just you wait five minutes"'
- # [04:30] <philor> I swear, one of these days I really am going to get a prescription for Xanax and send the bill to MoCo
- # [04:31] * heycam|away is now known as heycam
- # [04:31] * mattwoodrow is now known as mattwoodrow|away
- # [04:32] * Quits: terrence (terrence@moz-BBE3ABD.mv.mozilla.com) (Ping timeout)
- # [04:32] <ewong> philor "u[\0x1e]plift:" ?
- # [04:34] * glob|away is now known as glob
- # [04:35] * Joins: dRdR (dRdR@moz-F979C50C.cpe.net.cable.rogers.com)
- # [04:35] * philor changes topic to 'm-c: OPEN m-i: OPEN || Next aurora uplift: 20th Dec || If you are new or want to help, see irc://irc.mozilla.org/#introduction || "if you like the way it's working, just you wait five minutes"'
- # [04:37] * Quits: Ami_Ty_ (Amie@moz-BBE3ABD.mv.mozilla.com) (Quit: Ami_Ty_)
- # [04:37] <Unfocused> i see the tree status, and all i can think of is monads
- # [04:37] <Unfocused> Maybe open
- # [04:37] * Quits: rniwa (rniwa@5CA6DC39.C60FE7DC.4065847B.IP) (Quit: rniwa)
- # [04:38] * jmaher is now known as jmaher|afk
- # [04:39] * Joins: biesi (cbiesinger@2E747C8D.C1499D0.396E4C6D.IP)
- # [04:39] * Quits: redfive (chatzilla@moz-B94E1A81.ipnetworksinc.net) (Ping timeout)
- # [04:39] * adam-afk is now known as adam
- # [04:42] * Joins: mib_q23660 (Mibbit@B65C3ADB.770AB491.57460053.IP)
- # [04:43] * Joins: kats (kats@moz-DE13FC16.compute-1.amazonaws.com)
- # [04:43] * Joins: jamesr (jamesr@moz-C40B3BE3.hfc.comcastbusiness.net)
- # [04:45] * Quits: KaiRo (robert@moz-DD749FCB.adsl.highway.telekom.at) (Input/output error)
- # [04:45] * Quits: cpearce (chatzilla@538BABFE.A073F3E.97BBD552.IP) (Ping timeout)
- # [04:45] * Joins: cpearce (chatzilla@538BABFE.A073F3E.97BBD552.IP)
- # [04:47] <gps> do I need to do anything to recover from this burnination?
- # [04:47] <gps> I fear the reds are trolling Unfocused to bitrot me :)
- # [04:48] <cpearce> What is the sanctioned way to convert an integer to a string in mozilla c++?
- # [04:49] * Quits: Hendikins (wolfox@moz-9A361C95.static.internode.on.net) (Ping timeout)
- # [04:49] <cpearce> nsPrintfCString ?
- # [04:49] * Joins: Hendikins (wolfox@moz-9A361C95.static.internode.on.net)
- # [04:50] <Unfocused> heh...
- # [04:50] * cpearce discovers AppendInt
- # [04:50] * Joins: hub (hub@moz-E2FCA694.figuiere.net)
- # [04:51] <Unfocused> python: can't open file 'tools/buildfarm/maintenance/count_and_reboot.py': [Errno 2] No such file or directory
- # [04:51] <Unfocused> gps: i don't think that's your fault
- # [04:53] <philor> gps: that orange, though?
- # [04:53] <gps> hmmm. I just had a try build come back with "getaddrinfo failed"
- # [04:54] <philor> yeah, that's the dns failure that was the cause of the red, but on the tip of m-c, you've got an orange xpcshell
- # [04:54] <gps> philor: looking
- # [04:54] <gps> this hasn't been my day
- # [04:55] <Unfocused> hey look, thats the orange your patch was meant to fix
- # [04:55] <gps> I completely ignored the bit about the backout bitrotting my own code
- # [04:55] <gps> so the fix for the orange never got committed back in - just the fix for the oranges that were a result of that patch
- # [04:56] * Joins: darktrojan (geoff@moz-BC95E278.dsl.telstraclear.net)
- # [04:59] * Quits: merinui (merinui@moz-61C7235E.osk2.eonet.ne.jp) (Quit: Leaving...)
- # [04:59] <gps> how many times will I have to land this bug?
- # [04:59] <darktrojan> 5
- # [05:00] <nthomas> meeeeelion
- # [05:01] * Quits: akeybl (akeybl@moz-BBE3ABD.mv.mozilla.com) (Quit: Leaving...)
- # [05:05] * Joins: jet (junglecode@moz-79F891EE.hsd1.ca.comcast.net)
- # [05:05] * Quits: jwq (jwq@moz-8238A1D6.irl.cri.nz) (Quit: ChatZilla 0.9.87 [Firefox 8.0/20111104165243])
- # [05:05] <bent> njn, you around?
- # [05:05] <njn> bent: yes
- # [05:06] <bent> njn, hey, haven't forgotten about your patch
- # [05:06] <bent> just busy
- # [05:06] <njn> good! :)
- # [05:06] <bent> tomorrow ok?
- # [05:06] <njn> bent: I NEED IT ONW
- # [05:06] <bent> or do you need it tonight?
- # [05:06] <njn> NOW
- # [05:06] <njn> oh ok
- # [05:06] <Waldo> heh
- # [05:06] <njn> tomorrow is fine
- # [05:06] <bent> njn, uplift is in the morning...
- # [05:06] <njn> yeah, I'm happy to wait
- # [05:06] <bent> were you trying to land it tonight?
- # [05:07] <bent> ok
- # [05:07] <bent> thanks
- # [05:07] * Parts: kats (kats@moz-DE13FC16.compute-1.amazonaws.com)
- # [05:07] <njn> I would have bugged you earlier if I wanted to land it by uplift :)
- # [05:07] <njn> Waldo: -Wuninitialized is a real trouble-maker
- # [05:07] <bent> k
- # [05:08] <njn> Waldo: it's the biggest obstacle to zero warnings, IMO
- # [05:08] <Waldo> njn: did you see my comment earlier about __builtin_unreachable()?
- # [05:08] * Quits: jamesr (jamesr@moz-C40B3BE3.hfc.comcastbusiness.net) (Quit: jamesr)
- # [05:08] <njn> Waldo: yes
- # [05:08] * Joins: jamesr (jamesr@moz-C40B3BE3.hfc.comcastbusiness.net)
- # [05:08] <njn> Waldo: that helps in certain cases, like switches
- # [05:08] <njn> but there are lots of others
- # [05:09] * Quits: jrmuizel (jrmuizel@moz-20EF8EAA.cpe.net.cable.rogers.com) (Input/output error)
- # [05:09] <njn> e.g. the old repeated condition case
- # [05:09] <Waldo> well, it's more a general tool to use
- # [05:09] * Quits: kenny (kenny@moz-7EAF8A2D.hsd1.wa.comcast.net) (Ping timeout)
- # [05:09] * joduinn is now known as joduinn-commute
- # [05:09] <njn> ?
- # [05:09] <Waldo> eh, I'm just kind of mumbling :-)
- # [05:09] <Waldo> I'd kind of like to add it to MOZ_NOT_REACHED, maybe
- # [05:10] * Joins: kenny (kenny@moz-7EAF8A2D.hsd1.wa.comcast.net)
- # [05:10] <Waldo> but we need to audit some to make sure there's no backstop code that using any of those hints might elide
- # [05:10] <njn> Waldo: now I'm not sure if I'm following you
- # [05:11] * Quits: RyanVM (chatzilla@moz-D04D3C77.phlapa.fios.verizon.net) (Quit: ChatZilla 0.9.87-2011052417 [Firefox 11.0a1/20111219170600])
- # [05:11] <gps> OK. I need to reland the originally backed-out patch to bug 711263
- # [05:12] <Waldo> well, we add MOZ_NOT_REACHED("this shouldn't have been hit") to mfbt, then we make that expand to a call to __builtin_unreachable(), and the compiler won't worry its poor self about uninitialized variables "used" after that, because some guarding condition couldn't hold, and such
- # [05:12] <gps> do I commit with the original message or should I r=bustage?
- # [05:13] * Waldo has the patch for that ready, but it rejiggers headers and macros enough he's not interested in having made some sort of mistake in transcription, and finding out after it's merged to aurora
- # [05:13] * Joins: jrmuizel (jrmuizel@moz-20EF8EAA.cpe.net.cable.rogers.com)
- # [05:13] <Waldo> patch to add M_N_R, that is, not to call the builtin in it
- # [05:14] <njn> Waldo: sure, but we'd only add MOZ_NOT_REACHED manually to default case, right?
- # [05:14] <njn> so the auditing would naturally occur then
- # [05:14] <Waldo> sure
- # [05:14] * Quits: irving (irving@moz-92D12271.dsl.bell.ca) (Input/output error)
- # [05:14] <Waldo> I generally assume there's no silver bullet, although one can always stick one's head in the sand
- # [05:15] <njn> Waldo: would MOZ_NOT_REACHED be empty for opt builds?
- # [05:16] <Waldo> njn: it could call __builtin_unreachable() in opt builds
- # [05:16] <Waldo> if control flow reaches it, ever, that's a bug
- # [05:16] <njn> Waldo: sounds good
- # [05:16] * Joins: Mook (mook@moz-B1410066.dsl.teksavvy.com)
- # [05:17] <Waldo> it's not clear to me what the effect would be on execution if it *were* reached; any crash seems fine so long as that place being reached can be determined, I think
- # [05:17] * Joins: Mardak (Mardak@moz-4FA48382.hsd1.ca.comcast.net)
- # [05:17] <Waldo> or at least that no *other* place was reached
- # [05:17] <Waldo> don't want M_N_R crashes to alias other crashes -- or worse, non-crashes
- # [05:18] <Waldo> although that might be a risk worth living with, potentially
- # [05:18] <Waldo> some care is needed here
- # [05:19] <firebot> Check-in: http://hg.mozilla.org/mozilla-central/rev/9eda39f28e5a - Gregory Szorc - Bug 711263 - Prevent race condition when saving reconciler state; r=philikon
- # [05:19] <njn> Waldo: I get a seg fault when I hit it in a test program
- # [05:19] <njn> Waldo: so long as stack traces are accurate, should be ok
- # [05:19] * Joins: jprmc (jprmc@moz-7F2FF3EB.cpe.net.cable.rogers.com)
- # [05:19] <Waldo> yeah, that's about my thought
- # [05:20] <njn> Waldo: I bet someone will argue that it's better to soldier on in an opt build
- # [05:20] <Waldo> njn: we can have some separate thing for that, maybe
- # [05:20] <njn> in some cases I can believe it, but others not
- # [05:21] <Waldo> LOCAL_ASSERT is basically just bowing to reality in the decompiler
- # [05:21] <Waldo> you need something like that for truly awful code
- # [05:21] * njn looks up LOCAL_ASSERT
- # [05:21] <Waldo> it just probably shouldn't be using the assert stuff
- # [05:22] <Waldo> and maybe should be hand-coded locally...maybe
- # [05:22] * Quits: rwaldron (rwaldron@moz-71B3012E.c3-0.abr-ubr1.sbo-abr.ma.cable.rcn.com) (Quit: Leaving...)
- # [05:22] <njn> I'd suggest local
- # [05:22] <njn> in the default case, if there's a sane fallback value...
- # [05:22] * azakai|2_ is now known as azakai|2
- # [05:22] <Waldo> basically the decompiler code is so under-understood that all asserts in it are asserts backstopped by return-failure code
- # [05:22] <njn> default: MOZ_NOT_REACHED("foo"); x = sane_fallback; break;
- # [05:23] <Waldo> x = sane_fallback would be elided by __assume(0), from how I interpret MSVC docs
- # [05:23] <njn> Waldo: if only someone would work on that lazy script compilation bug, the decompiler could be murdered in its bed
- # [05:23] <njn> Waldo: is __assume the MSVC to __builtin_unreachable?
- # [05:23] <njn> well, __assume(0)
- # [05:23] <njn> *MSVC equivalent
- # [05:23] <Waldo> njn: roughly; from the docs, it sounds like any code after it is flat-out removed
- # [05:23] * Quits: raccettura (raccettura@moz-660B8F4B.hsd1.nj.comcast.net) (Quit: raccettura)
- # [05:24] <njn> hmm
- # [05:24] <njn> wot a hassle
- # [05:24] <Waldo> which is why it's important to make sure however we use these, there can be *no possibility* anyone assumes fallback code will work
- # [05:24] * Joins: alex (alex@moz-BD8D0A09.lightspeed.sntcca.sbcglobal.net)
- # [05:24] <njn> I've concluded that uninitialized warnings not caused by switches are indicative of overly complex control flow
- # [05:24] <Waldo> if JS_ASSERT expanded to include __assume(0), LOCAL_ASSERT would be busted
- # [05:24] <njn> yeah
- # [05:25] <njn> I've been fixing layout warnings, there are some horrible large functions with repeated conditions
- # [05:25] <njn> quite non-trivial to convince one's self that the warning is a false positive
- # [05:25] * Waldo isn't willing to conclude such control flow is overly complex, but it does raise a warning flag
- # [05:25] <njn> exactly
- # [05:25] <njn> suggestive
- # [05:26] * Quits: jet (junglecode@moz-79F891EE.hsd1.ca.comcast.net) (Quit: jet)
- # [05:27] * Joins: mzz (marienz@moz-D1CC9ED2.tomaw.net)
- # [05:28] * Quits: caillon (caillon@moz-359E39FC.lightspeed.sntcca.sbcglobal.net) (Ping timeout)
- # [05:29] * Quits: slowpoke (slowpoke@moz-F02DAE63.gigabit.perfect-privacy.com) (Ping timeout)
- # [05:29] * Quits: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP) (Ping timeout)
- # [05:30] * nthomas is now known as nthomas|away
- # [05:32] <philor> edmorley: bz's not entirely crazy, we just star too fast :) - if you look at the popup summary of that failure after it's starred, the Actual value has an unescaped "<file://>" so it doesn't show up, even though it shows up if you look before the failure is starred
- # [05:32] <edmorley> ah
- # [05:33] <philor> yay for tbpl bugs I probably know how to fix
- # [05:33] * glob is now known as glob|away
- # [05:34] <darktrojan> what, you actually fix bugs philor?
- # [05:34] <darktrojan> where do you find time?
- # [05:34] * darktrojan thought philor only starred stuff and grumbled :)
- # [05:34] <philor> sometimes, it gets boring just backing things out and disabling tests
- # [05:35] <darktrojan> someone's gotta do it, philor++
- # [05:35] * Joins: bwinton_away (bwinton@D7D3C4B5.88764A66.72A31D6.IP)
- # [05:35] <philor> bugzilla sez... I've fixed 754, of which some probably weren't just fixed by a backout
- # [05:36] * njn is intrigued by |nsAutoPtr<css::Declaration> declaration(new css::Declaration());|
- # [05:36] <edmorley> :-)
- # [05:36] <jwir3> philor: How did you find out how many bugs you fixed? (This may be a stupid question, but I'm not sure how to set up the query)
- # [05:36] * mcote is now known as mcote|afk
- # [05:36] <philor> jwir3: https://bugzilla.mozilla.org/buglist.cgi?quicksearch=FIXED%20assignee%3Aphilringnalda
- # [05:37] * njn reckons that's a leak
- # [05:37] <jwir3> philor: gotcha
- # [05:37] <jwir3> philor: Thx
- # [05:37] * Mook is curious how that's a leak - nsAutoPtr is owning, isn't it?
- # [05:38] * Quits: mzz (marienz@moz-D1CC9ED2.tomaw.net) (Ping timeout)
- # [05:38] <njn> Mook: actually, I'm totally bamboozled by it
- # [05:38] <Mook> i.e. it's like a std::auto_ptr?
- # [05:39] <njn> Mook: there's a |declaration.forget()| later on that gives an address on the stack
- # [05:40] <Mook> sure, _that_ could leak, but that's pretty normal-looking and hopefully it does something useful...
- # [05:40] <darktrojan> oh what, no "firefox 9 is out" article on slashdot for the comment trolls?
- # [05:40] <njn> Mook: problem is I'm writing a memory reporter and calling moz_malloc_usable_size on that stack address, which is bad
- # [05:41] <Mook> hah, that might not be what you want, yeah
- # [05:41] <njn> Mook: actually, I'm not even sure that's the problem... I'm just confused in general
- # [05:41] * Quits: dRdR (dRdR@moz-F979C50C.cpe.net.cable.rogers.com) (Client exited)
- # [05:42] <Mook> consider adding pictures of cats.
- # [05:42] <njn> declaration.forget() should give me the ptr returned by the |new Declaration()|, right?
- # [05:42] <njn> I have a |Declaration| somewhere allocated on the stack, I thought this might be the place, but maybe not
- # [05:42] <edmorley> jwir3: or alternatively: $ hg log -u philringnalda --template '{desc|firstline}\n' | egrep -vi '^(back|merge)' | wc -l
- # [05:42] <edmorley> 469
- # [05:43] <edmorley> and on that note, less distractions, time for bed...
- # [05:44] <Mook> yes, .forget should give you the original pointer
- # [05:44] <Mook> and stop the nsAutoPtr from |delete|ing it when it goes out of scope
- # [05:44] * rail-around is now known as rail_away
- # [05:45] * Joins: slowpoke (slowpoke@moz-F02DAE63.gigabit.perfect-privacy.com)
- # [05:46] <Waldo> if you're just looking, get() is probably what you want, not forget()
- # [05:47] * Joins: rniwa (rniwa@moz-E171DA5.sfba.hfc.comcastbusiness.net)
- # [05:48] * Quits: rniwa (rniwa@moz-E171DA5.sfba.hfc.comcastbusiness.net) (Quit: rniwa)
- # [05:48] * Quits: edmorley (edmorley@moz-1BABC6CB.range86-166.btcentralplus.com) (Quit: Leaving.)
- # [05:53] * Quits: anant (Anant@moz-271479F2.hsd1.ca.comcast.net) (Quit: Leaving)
- # [05:53] * Quits: cpearce (chatzilla@538BABFE.A073F3E.97BBD552.IP) (Ping timeout)
- # [05:54] * Joins: jet (junglecode@moz-79F891EE.hsd1.ca.comcast.net)
- # [05:55] * Quits: darktrojan (geoff@moz-BC95E278.dsl.telstraclear.net) (Ping timeout)
- # [05:56] * Quits: jamesr (jamesr@moz-C40B3BE3.hfc.comcastbusiness.net) (Quit: jamesr)
- # [05:58] * Quits: jdm (jdm@moz-9AEDE212.cpe.net.cable.rogers.com) (Client exited)
- # [05:59] <njn> Mook: turns out the problem was something completely unrelated
- # [05:59] * Quits: diogogmt (kvirc@moz-4D628198.cpe.net.cable.rogers.com) (Quit: KVIrc 4.1.1 Equilibrium http://www.kvirc.net/)
- # [05:59] <njn> thanks for the help
- # [05:59] <njn> Waldo: the .forget is pre-existing
- # [05:59] <Mook> no problem; things often turn out that way
- # [06:02] * Quits: jet (junglecode@moz-79F891EE.hsd1.ca.comcast.net) (Quit: jet)
- # [06:05] * Joins: rwaldron (rwaldron@moz-71B3012E.c3-0.abr-ubr1.sbo-abr.ma.cable.rcn.com)
- # [06:07] * Quits: Polynomial-C (Poly-C@moz-7F02F440.dip.t-dialin.net) (Ping timeout)
- # [06:07] * Joins: Polynomial-C (Poly-C@moz-99F20074.dip.t-dialin.net)
- # [06:08] * Joins: ejpbruel (ejpbruel@933E3A2E.83A511AD.F413BF4D.IP)
- # [06:09] <JonathanS> is it me that forget() is another word for delete?
- # [06:09] * Joins: rniwa (rniwa@moz-E171DA5.sfba.hfc.comcastbusiness.net)
- # [06:12] <gps> almost out of the woods
- # [06:12] <Mook> it's you.
- # [06:14] * Quits: bbondy (bbondy@moz-28CF6D1C.home.cgocable.net) (Quit: Going offline, see ya! (www.adiirc.com))
- # [06:14] * Quits: biesi (cbiesinger@2E747C8D.C1499D0.396E4C6D.IP) (Ping timeout)
- # [06:15] * Joins: josh (josh@moz-2EE66546.nyc.res.rr.com)
- # [06:15] * Quits: gerv (gerv@moz-8E68CF56.in-addr.arpa) (Ping timeout)
- # [06:15] <bent> forget implies leaks to me
- # [06:15] <gps> for future relevance (and to judge how many beers to drink tonight), on a scale of 1 to 10, how disruptive were the oranges (I made) on m-c today?
- # [06:15] * Quits: rniwa (rniwa@moz-E171DA5.sfba.hfc.comcastbusiness.net) (Quit: rniwa)
- # [06:15] * Joins: graydot (jeba@63F3AA56.9CFBD76D.30E7AE68.IP)
- # [06:17] <philor> potential? 9 or 10. actual? you'd have to ask the people who might have merged from inbound, but didn't, why they didn't
- # [06:17] * Joins: gerv (gerv@moz-8E68CF56.in-addr.arpa)
- # [06:18] * glob|away is now known as glob
- # [06:20] <gps> well then. I suppose I should issues vouchers for beer or something
- # [06:20] * Quits: jorendorff (jorendorff@moz-91590D94.hsd1.tn.comcast.net) (Quit: jorendorff)
- # [06:20] <gps> especially given uplift is tomorrow
- # [06:21] <Unfocused> gps: if it makes you feel better, i'll let you buy me a rum next time i'm in town
- # [06:22] <gps> :)
- # [06:22] <Unfocused> i'm all for making sacrifices to make other people feel better
- # [06:25] <Mossop> So tomorrow we sacrifice Unfocused?
- # [06:26] <Unfocused> i can't help but notice you're suggesting that *after* i finished my project
- # [06:27] * Quits: mib_q23660 (Mibbit@B65C3ADB.770AB491.57460053.IP) (Quit: http://www.mibbit.com ajax IRC Client)
- # [06:27] <Mossop> Well if I did it before I'd have to do some work or something, can't have that
- # [06:27] <Unfocused> of course
- # [06:29] * joduinn-commute is now known as joduinn-home
- # [06:30] * Quits: ewong|sleep (chatzilla@F536648C.E5F17347.51F738FB.IP) (Ping timeout)
- # [06:30] * Joins: cpearce (chatzilla@moz-55A2BC7D.xdsl.xnet.co.nz)
- # [06:30] * Joins: ewong|sleep (chatzilla@F536648C.E5F17347.51F738FB.IP)
- # [06:32] * Quits: Waldo (waldo@moz-534B4EF1.hsd1.mi.comcast.net) (Quit: ChatZilla 0.9.87-4.1450hg.fc15 [XULRunner 8.0/20111108090029])
- # [06:34] * Quits: philipp64|laptop (chatzilla@moz-764C1742.hfc.comcastbusiness.net) (Ping timeout)
- # [06:34] * Quits: Mook (mook@moz-B1410066.dsl.teksavvy.com) (Ping timeout)
- # [06:34] * Quits: roc (chatzilla@538BABFE.A073F3E.97BBD552.IP) (Ping timeout)
- # [06:35] * Joins: philipp64|laptop (chatzilla@moz-764C1742.hfc.comcastbusiness.net)
- # [06:35] * Joins: Mook (mook@68E3C9C2.16C74E88.6F478678.IP)
- # [06:37] * Quits: rwaldron (rwaldron@moz-71B3012E.c3-0.abr-ubr1.sbo-abr.ma.cable.rcn.com) (Quit: Leaving...)
- # [06:37] * Quits: Mook (mook@68E3C9C2.16C74E88.6F478678.IP) (Ping timeout)
- # [06:40] <gps> inconvenienced mergers: file your claim to bug 712218
- # [06:40] * Joins: Mook (mook@moz-B1410066.dsl.teksavvy.com)
- # [06:40] * Quits: ashughes (ashughes@6202C507.852FE72D.DA78B690.IP) (Ping timeout)
- # [06:41] <Mossop> I was in meetings all day but I was experiencing sympathetic pains for those inconvenienced. Honest
- # [06:41] <dolske> gps: bad in that losing a day of the tree is never good. ok in that if people were needing to land on this train, they shouldn't have waited so long. :)
- # [06:42] <dolske> iirc the first upload (FF5) had a small orange trainwreck, so drivers just chose a changeset from the day before. #winning
- # [06:42] * Joins: mzz (marienz@moz-D1CC9ED2.tomaw.net)
- # [06:43] * philor is now known as philor|away
- # [06:43] <gps> Mossop: find me next time you are in SF and I think you'll walk away happy :)
- # [06:43] <Unfocused> i remember that. that was funny
- # [06:44] * Quits: mzz (marienz@moz-D1CC9ED2.tomaw.net) (Ping timeout)
- # [06:45] * Joins: zwol (zack@moz-37CFDBA4.lightspeed.sntcca.sbcglobal.net)
- # [06:45] * Quits: zwol (zack@moz-37CFDBA4.lightspeed.sntcca.sbcglobal.net) (Quit: zwol)
- # [06:45] * Quits: kenny (kenny@moz-7EAF8A2D.hsd1.wa.comcast.net) (Quit: Leaving)
- # [06:50] * Quits: Mook (mook@moz-B1410066.dsl.teksavvy.com) (Quit: ChatZilla 0.9.87-rdmsoft [XULRunner 6.0/20110811165603])
- # [06:52] * philor|away is now known as philor
- # [06:52] <Mossop> gps: I'll be in tomorrow!
- # [06:53] <gps> well, you know where I sit!
- # [06:55] * Quits: chewey (chewey@moz-E0C199AC.dip0.t-ipconnect.de) (Ping timeout)
- # [06:56] * Joins: chewey (chewey@moz-C0A1D71D.dip0.t-ipconnect.de)
- # [06:57] <gps> well, the tree looks green to me. I only tried on multiple pairs of clownshoes today
- # [06:57] <gps> I'm gonna sign off [and drink some beer]
- # [06:58] * Joins: nhirata (nhirata.bu@moz-2A9C9106.hsd1.ca.comcast.net)
- # [06:59] <dolske> see, there's your mistake.
- # [06:59] <philor> way too late in the day, right?
- # [06:59] <dolske> BAD: land -> signoff -> drink beer
- # [06:59] <dolske> GOOD: drink beer -> signoff -> land
- # [06:59] <philor> jwir3: noo, you be stealin' our assertions!
- # [06:59] <philor> also, was the backout because the first version was going to fail that reftest, or is that still hanging over our heads?
- # [07:00] <gps> who says I haven't started drinking yet?
- # [07:00] * Quits: Mossop (mossop@moz-E325C2EC.dsl.dynamic.sonic.net) (Ping timeout)
- # [07:00] * Joins: anky (anky@9F974336.3238CD1B.A3D1B221.IP)
- # [07:03] <jwir3> philor: What?
- # [07:04] <philor> jwir3: a shortage of expected assertions in crashtests up top, and a reftest failure below
- # [07:04] <jwir3> philor: Ok, I'll back out
- # [07:05] * Joins: janv (varga@moz-C1261AFF.flarion.as5628.telecom.sk)
- # [07:08] <jwir3> philor: Ok, backed out
- # [07:10] * philor is now known as philor|away
- # [07:10] * Quits: jrmuizel (jrmuizel@moz-20EF8EAA.cpe.net.cable.rogers.com) (Input/output error)
- # [07:12] * Quits: northWind (northWind@moz-20E58859.cable.teksavvy.com) (Ping timeout)
- # [07:15] * Quits: Mardak (Mardak@moz-4FA48382.hsd1.ca.comcast.net) (Quit: Mardak)
- # [07:18] * Joins: jamesr (jamesr@moz-C40B3BE3.hfc.comcastbusiness.net)
- # [07:19] * Quits: jamesr (jamesr@moz-C40B3BE3.hfc.comcastbusiness.net) (Quit: jamesr)
- # [07:19] * philor|away is now known as philor
- # [07:24] * philor is now known as philor|away
- # [07:25] * Joins: ericb2 (X@moz-9C4C3DED.fbx.proxad.net)
- # [07:27] * Joins: Boriss (FlyingToas@moz-62AAA429.hsd1.ca.comcast.net)
- # [07:27] * Quits: By-Tor (bytor@moz-46974D0B.dyn.optonline.net) (Input/output error)
- # [07:30] * Joins: By-Tor (bytor@moz-46974D0B.dyn.optonline.net)
- # [07:31] * Quits: ericb2 (X@moz-9C4C3DED.fbx.proxad.net) (Quit: Success !!)
- # [07:32] * Joins: cjones (cjones@moz-45913895.socal.res.rr.com)
- # [07:32] * adam is now known as adam-afk
- # [07:34] * Joins: dRdR (dRdR@moz-F979C50C.cpe.net.cable.rogers.com)
- # [07:34] * Quits: lmandel (lmandel@moz-113D7D7C.cable.teksavvy.com) (Quit: lmandel)
- # [07:35] * philor|away is now known as philor
- # [07:36] * Quits: pcwalton (pcwalton@moz-7B0110AD.mv.mozilla.com) (Quit: nbvcx)
- # [07:37] * Quits: Boriss (FlyingToas@moz-62AAA429.hsd1.ca.comcast.net) (Quit: Boriss)
- # [07:39] * Joins: redfive (chatzilla@moz-75DD4703.dsl.pltn13.sbcglobal.net)
- # [07:42] * Joins: Boriss (FlyingToas@moz-62AAA429.hsd1.ca.comcast.net)
- # [07:42] * Joins: mzz (marienz@moz-D1CC9ED2.tomaw.net)
- # [07:42] * Joins: Fallen|mac (kewisch@moz-DCD8F77E.adsl.alicedsl.de)
- # [07:42] * Quits: anky (anky@9F974336.3238CD1B.A3D1B221.IP) (Ping timeout)
- # [07:43] * Quits: eflores (AndChat@538BABFE.A073F3E.97BBD552.IP) (Quit: Bye)
- # [07:44] * Joins: anky (anky@58BA4F9C.9EB919EA.A3D1B221.IP)
- # [07:45] * Joins: victorporof (victorporo@A78C599A.14EB2DE0.79933D60.IP)
- # [07:46] * Parts: lsumar (lsumar@E2F7352.56080C53.97BBD552.IP) (Leaving)
- # [07:48] * Joins: rniwa (rniwa@moz-E171DA5.sfba.hfc.comcastbusiness.net)
- # [07:49] * Joins: Mardak (Mardak@moz-4FA48382.hsd1.ca.comcast.net)
- # [07:50] * Quits: anky (anky@58BA4F9C.9EB919EA.A3D1B221.IP) (Client exited)
- # [07:53] * Quits: bnicholson (bnicholson@moz-CA78B821.rcmdva.fios.verizon.net) (Quit: Leaving)
- # [07:54] * Quits: Honza (chatzilla@E07BF19C.5BB5597D.D0083327.IP) (Ping timeout)
- # [07:55] * Joins: Honza (chatzilla@E07BF19C.5BB5597D.D0083327.IP)
- # [07:56] * jwir3 is now known as jwir3|away
- # [07:56] * Quits: jgilbert_ (jgilbert@moz-BBE3ABD.mv.mozilla.com) (Ping timeout)
- # [07:57] * Joins: darktrojan (geoff@moz-BC95E278.dsl.telstraclear.net)
- # [07:58] <bent> shortage of expected assertions sounds like you should win a prize
- # [07:59] * Quits: darktrojan (geoff@moz-BC95E278.dsl.telstraclear.net) (Quit: darktrojan)
- # [08:00] <philor> sure, but this is Moz: the prize is getting to back out and adjust the annotation before you land again
- # [08:02] * Joins: roc (chatzilla@C0ACF8B.5E1E9EEA.613E47D1.IP)
- # [08:03] * Joins: magsout (magsout@moz-E559D13.fbx.proxad.net)
- # [08:03] * Joins: caillon (caillon@moz-359E39FC.lightspeed.sntcca.sbcglobal.net)
- # [08:05] * Quits: graydot (jeba@63F3AA56.9CFBD76D.30E7AE68.IP) (Ping timeout)
- # [08:06] * Joins: smontagu (chatzilla@moz-95CF342D.red.bezeqint.net)
- # [08:06] * Quits: josh (josh@moz-2EE66546.nyc.res.rr.com) (Quit: josh)
- # [08:07] * Joins: graydot (jeba@63F3AA56.9CFBD76D.30E7AE68.IP)
- # [08:07] * Quits: mike5w3c (MikeS@moz-1CC04BF0.pool.e-mobile.ne.jp) (Ping timeout)
- # [08:07] * Quits: ehsan (ehsan@F0B20A8D.8458880F.57F33CED.IP) (Input/output error)
- # [08:07] * Joins: mike5w3c (MikeS@moz-7C44325D.pool.e-mobile.ne.jp)
- # [08:10] * Joins: darktrojan (geoff@moz-BC95E278.dsl.telstraclear.net)
- # [08:11] * Joins: whimboo (whimboo@moz-216F9AFA.superkabel.de)
- # [08:11] * Joins: wolfiR (wolfiR@moz-9F2DACD5.dip0.t-ipconnect.de)
- # [08:13] * Quits: njn (chatzilla@32788AE8.60066DFE.8660782D.IP) (Quit: ChatZilla 0.9.87 [Firefox 11.0a1/20111212152829])
- # [08:15] * Joins: fer (fherrera@moz-7D8524C1.dynamic.jazztel.es)
- # [08:16] * Quits: dRdR (dRdR@moz-F979C50C.cpe.net.cable.rogers.com) (Connection reset by peer)
- # [08:16] * Joins: dRdR (dRdR@moz-F979C50C.cpe.net.cable.rogers.com)
- # [08:17] * Quits: magsout (magsout@moz-E559D13.fbx.proxad.net) (Client exited)
- # [08:17] * Joins: mib_vh6c98 (Mibbit@B65C3ADB.770AB491.57460053.IP)
- # [08:17] * Joins: sicking (chatzilla@moz-229429EC.dsl.pltn13.sbcglobal.net)
- # [08:18] * Quits: dRdR (dRdR@moz-F979C50C.cpe.net.cable.rogers.com) (Connection reset by peer)
- # [08:19] * Joins: magsout (magsout@moz-E559D13.fbx.proxad.net)
- # [08:20] * Quits: philipp64|laptop (chatzilla@moz-764C1742.hfc.comcastbusiness.net) (Ping timeout)
- # [08:20] * Joins: bholley (bholley@moz-24EDB000.hsd1.ca.comcast.net)
- # [08:21] * Joins: philipp64|laptop (chatzilla@moz-764C1742.hfc.comcastbusiness.net)
- # [08:21] * Quits: michal (michal@moz-5C5A58A8.broadband14.iol.cz) (Ping timeout)
- # [08:21] * glob is now known as glob|away
- # [08:24] * Joins: glazou (glazou@moz-204094DD.disruptive-innovations.fr)
- # [08:25] <glazou> bonjour
- # [08:26] * Quits: mzz (marienz@moz-D1CC9ED2.tomaw.net) (Ping timeout)
- # [08:27] * Quits: roc (chatzilla@C0ACF8B.5E1E9EEA.613E47D1.IP) (Ping timeout)
- # [08:29] * Quits: Fallen|mac (kewisch@moz-DCD8F77E.adsl.alicedsl.de) (Quit: Leaving.)
- # [08:32] * Quits: micahg (micahg@moz-C7CC8D27.c3-0.arm-ubr1.chi-arm.il.cable.rcn.com) (Ping timeout)
- # [08:32] * heycam is now known as heycam|away
- # [08:35] * Quits: darktrojan (geoff@moz-BC95E278.dsl.telstraclear.net) (Quit: darktrojan)
- # [08:37] * Joins: darktrojan (geoff@moz-BC95E278.dsl.telstraclear.net)
- # [08:37] * Joins: jhorak (jhorak@moz-107AD163.redhat.com)
- # [08:38] <tbsaunde> ok, so is there someway to fix abort: index data/mobile/chrome/content/aboutHome.xhtml.i is corrupted! or do I just lose?
- # [08:39] * Joins: micahg (micahg@moz-C7CC8D27.c3-0.arm-ubr1.chi-arm.il.cable.rcn.com)
- # [08:39] * Quits: Hendikins (wolfox@moz-9A361C95.static.internode.on.net) (Ping timeout)
- # [08:40] * Joins: Hendikins (wolfox@moz-9A361C95.static.internode.on.net)
- # [08:43] <Unfocused> tbsaunde: http://mercurial.selenic.com/wiki/RepositoryCorruption might help
- # [08:43] * philor is now known as philor|away
- # [08:43] * Joins: jduell (jduell@moz-2D9EDA98.lightspeed.sntcca.sbcglobal.net)
- # [08:44] <tbsaunde> Unfocused: thx
- # [08:45] <jduell> anybody know if we're doing another inbound->mc merge before the fork?
- # [08:45] * Joins: Ami_Ty (Amie@moz-7D22EB0A.dsl.static.sonic.net)
- # [08:46] * Quits: Ami_Ty (Amie@moz-7D22EB0A.dsl.static.sonic.net) (Connection reset by peer)
- # [08:46] * Joins: Ami_Ty_ (Amie@moz-7D22EB0A.dsl.static.sonic.net)
- # [08:46] * Ami_Ty_ is now known as Ami_Ty
- # [08:47] * Quits: Jesse (jruderman@moz-447E6DA0.oc.oc.cox.net) (Quit: Jesse)
- # [08:47] <jesup> !seen dbaron
- # [08:47] <firebot> dbaron was last seen 7 hours, 38 minutes and 4 seconds ago, saying 'njn, I suppose that wouldn't be too hard if the rest is done?' in #developers.
- # [08:48] <jesup> !seen bz
- # [08:48] <firebot> bz was last seen 3 days, 3 hours, 5 minutes and 39 seconds ago, saying 'is that just behavior I as caller have to handle, or a bug in one of the other of those functions?' in #jsapi.
- # [08:49] <jesup> Feh, the only people willing to r+ (or rs+) jprof patches aren't around.
- # [08:49] * Quits: By-Tor (bytor@moz-46974D0B.dyn.optonline.net) (Connection reset by peer)
- # [08:50] <mounir> glandium: do we still have to ask to land big chunk of C++ code (re the windows linker issue)
- # [08:50] * jesup wishes he could rs=jesup them, since they're not normally built and are tools only :-)
- # [08:50] <glandium> mounir: it's still better, yes
- # [08:51] * zpao|detached is now known as zpao
- # [08:51] * Joins: gabor (gabor@moz-3B57BCD1.catv.pool.telekom.hu)
- # [08:52] * Joins: MarcoZ (marco.zehe@moz-65E5AE7F.dip.t-dialin.net)
- # [08:54] <mounir> glandium: what *big* means?
- # [08:55] * Quits: bent (chatzilla@moz-DB4C5E15.triad.res.rr.com) (Quit: ChatZilla 0.9.87-rdmsoft [XULRunner 1.9.2.19/20110707195905])
- # [08:55] <glandium> mounir: how big is your stuff?
- # [08:56] * Joins: anky (anky@A084DBCA.44921952.A3D1B221.IP)
- # [08:56] <mounir> glandium: the directory is 268K (including Makefiles, interfaces and two test files)
- # [08:56] * Parts: whimboo (whimboo@moz-216F9AFA.superkabel.de)
- # [08:57] * Quits: magsout (magsout@moz-E559D13.fbx.proxad.net) (Ping timeout)
- # [08:57] <glandium> mounir: that's pretty big, what are you adding?
- # [08:57] <mounir> glandium: WebSMS
- # [08:57] <mounir> I could try to find a way to not build it on Windows if that can help
- # [08:57] * Joins: magsout (magsout@moz-E559D13.fbx.proxad.net)
- # [08:57] <mounir> but I would prefer to prevent that kind of tricks
- # [08:59] <glandium> mounir: you can do that, or you can check on try how much more memory it's going to use compared to m-c. (you need to add export MOZ_PGO=1 in your try mozconfig for windows, and check the vsize info in the log)
- # [08:59] <mounir> glandium: where do the mozconfigs live?
- # [09:00] * Quits: anky (anky@A084DBCA.44921952.A3D1B221.IP) (Client exited)
- # [09:01] <glandium> mounir: iirc mozconfig-extra at topsrcdir
- # [09:01] * Joins: juanb (jbecerra@moz-F1012875.hsd1.ca.comcast.net)
- # [09:01] <jduell> glandium: mounir: either of you know if we'll be merging inbound->mc before fork tomorrow?
- # [09:01] <glandium> jduell: you mean, today? ;) no idea
- # [09:01] <mounir> jduell: very likely
- # [09:01] <jduell> ok, thanks.
- # [09:02] <mounir> I mean, anyone can do the merge so you just have to do it if you need it ;)
- # [09:02] <glandium> jduell: note that this doesn't mean much wrt what is going to be in aurora
- # [09:02] <jduell> glandium: how so?
- # [09:02] <glandium> jduell: it's not necessarily the last changeset on m-c that is merged on aurora
- # [09:02] <glandium> it could very well be one from two days ago
- # [09:03] <glandium> unlikely, but possible
- # [09:03] <jduell> glandium: well, right. But landing on m-c increases my chances exponentially!
- # [09:06] * sancus is now known as sancus_
- # [09:06] * sancus_ is now known as sancus
- # [09:07] * Joins: pascalc (chatzilla@moz-15F4ED77.rev.sfr.net)
- # [09:08] * Joins: waschtl (waschtl@moz-A4ECE553.hsi4.kabel-badenwuerttemberg.de)
- # [09:08] * Joins: anky (anky@A084DBCA.44921952.A3D1B221.IP)
- # [09:09] <mounir> glandium: really?
- # [09:09] <glandium> mounir: ?
- # [09:09] <mounir> glandium: why the cs can be two days old?
- # [09:10] <dolske> there's no guaranteed cut-off date. you land near the merge at your own risk.
- # [09:10] <glandium> mounir: because it can
- # [09:11] <mounir> I saw that proposal but I didn't knew that was effective
- # [09:11] <hsivonen> slow bugzilla is slow :-(
- # [09:11] <cjones> down bugzilla is down
- # [09:12] <dolske> grrrrrr
- # [09:12] <ewong> -.- -Zzzz waiting for bugzilla to load..
- # [09:13] <ewong> it wasn't this bad an hour ago
- # [09:14] <mounir> ewong: Europe did woke up ;)
- # [09:14] <ewong> ooh right...
- # [09:14] <mounir> ... and is going to take a breakfast now that bugzilla is down ;)
- # [09:14] <ewong> Europe: go back to sleep..it's still early.. :)
- # [09:15] * Quits: zuzelvp (zuzelvp@2112147D.C3507A2D.9A8C35B4.IP) (Ping timeout)
- # [09:15] * Joins: jauip (x@moz-2E73ACE4.wp.shawcable.net)
- # [09:15] * Quits: jauip (x@moz-2E73ACE4.wp.shawcable.net) (Quit: jauip)
- # [09:16] * Quits: hub (hub@moz-E2FCA694.figuiere.net) (Ping timeout)
- # [09:19] * zpao is now known as zpao|detached
- # [09:22] * Joins: past (past@moz-7A93B333.dsl.dyn.forthnet.gr)
- # [09:22] * Joins: dao (dao@moz-5C3831CE.superkabel.de)
- # [09:22] <glazou> it's 9:17am here
- # [09:23] * Quits: aja (chatzilla@A8F7EE0.72086529.7880DB15.IP) (Client exited)
- # [09:23] <ewong> still early...
- # [09:23] <ewong> ;)
- # [09:23] * Joins: Jesse (jruderman@moz-447E6DA0.oc.oc.cox.net)
- # [09:24] * Joins: mzz (marienz@moz-D1CC9ED2.tomaw.net)
- # [09:24] * Quits: Jesse (jruderman@moz-447E6DA0.oc.oc.cox.net) (Quit: Jesse)
- # [09:25] * Quits: dbradley (dbradley@moz-8FACAA93.fuse.net) (Ping timeout)
- # [09:25] * Joins: Jesse (jruderman@moz-447E6DA0.oc.oc.cox.net)
- # [09:26] * Quits: mib_vh6c98 (Mibbit@B65C3ADB.770AB491.57460053.IP) (Quit: http://www.mibbit.com ajax IRC Client)
- # [09:29] * Quits: mzz (marienz@moz-D1CC9ED2.tomaw.net) (Ping timeout)
- # [09:29] * Quits: nhirata (nhirata.bu@moz-2A9C9106.hsd1.ca.comcast.net) (Quit: nhirata)
- # [09:30] <darktrojan> yeah, that's way too early
- # [09:31] * Joins: gkw (gkw@moz-A7D8CA2A.hsd1.ca.comcast.net)
- # [09:31] * Quits: bholley (bholley@moz-24EDB000.hsd1.ca.comcast.net) (Quit: bholley)
- # [09:32] * Joins: protz (protz@moz-E29D2A15.inria.fr)
- # [09:39] * Quits: birtles (chatzilla@moz-348F61F0.mozilla.or.jp) (Quit: ChatZilla 0.9.87-rdmsoft [XULRunner 1.9.0.17/2009122204])
- # [09:42] <ttaubert> is it ok to merge?
- # [09:43] * joduinn-home is now known as joduinn-zzz
- # [09:45] * ttaubert merges...
- # [09:45] <firebot> Check-in: http://hg.mozilla.org/mozilla-central/rev/90348927d796 - Jason Duell - Bug 666349: update status code usage to latest spec. r=mcmanus
- # [09:46] <firebot> http://hg.mozilla.org/mozilla-central/rev/7f42341adb99 - Jason Duell - Bug 666349 - Update WebSocket API to latest draft. r=mcmanus
- # [09:46] <firebot> http://hg.mozilla.org/mozilla-central/rev/998eecfec4de - Jason Duell - Bug 711205: Increase inbound WebSocket message size from 16MB to whatever malloc can handle. r=mcmanus
- # [09:46] <firebot> http://hg.mozilla.org/mozilla-central/rev/a558bfcac2e6 - Jason Duell - Bug 710964. No longer dispatch incoming WebSocket messages in CLOSING state. r=smaug
- # [09:46] <firebot> http://hg.mozilla.org/mozilla-central/rev/2afd7ae68e8b - Jason Duell - Bug 695635: Unprefix websockets. r=sicking, sr=smaug
- # [09:46] <firebot> http://hg.mozilla.org/mozilla-central/rev/225f854f8ff1 - Jason Duell - Bug 710345: Upgrade pywebsocket to v606 (RFC 6455). r=mcmanus
- # [09:46] <firebot> http://hg.mozilla.org/mozilla-central/rev/384e5cb0ffa6 - Jason Duell - Bug 711205: Limit websocket outbound msg size to PR_INT32_MAX. r=mcmanus
- # [09:46] <Unfocused> wow, finally unprefixed?
- # [09:46] <firebot> http://hg.mozilla.org/mozilla-central/rev/ccb71819f0c2 - Jason Duell - Bug 710345: Mozilla-specific changes to pywebsocket v606. r=mcmanus
- # [09:47] <hsivonen> unprefixing FTW! \o/
- # [09:47] * Quits: alex (alex@moz-BD8D0A09.lightspeed.sntcca.sbcglobal.net) (Client exited)
- # [09:47] <ttaubert> yeah!
- # [09:47] <ttaubert> finally
- # [09:47] <ttaubert> :)
- # [09:47] * Joins: gandalf (zbraniecki@moz-80CE5BCD.home.aster.pl)
- # [09:49] * Quits: squib (squib@moz-F5CA0CFB.dhcp.mdsn.wi.charter.com) (Quit: Leaving)
- # [09:49] * mattwoodrow|away is now known as mattwoodrow
- # [09:52] * Joins: RemusPop (remuspop@601F3B17.33662590.A5830293.IP)
- # [09:52] * Joins: bholley (bholley@moz-24EDB000.hsd1.ca.comcast.net)
- # [09:53] <protz> there's a file that, when downloaded with wget, yields a different md5sum than if downloaded with firefox
- # [09:53] <protz> ideas, anyone?
- # [09:53] * protz is puzzled
- # [09:53] * Quits: cjones (cjones@moz-45913895.socal.res.rr.com) (Quit: Leaving)
- # [09:54] <ewong> protz: just wondering.. how big is this file?
- # [09:54] * heycam|away is now known as heycam
- # [09:54] <nthomas|away> server changes the response based on the user agent ?
- # [09:54] <protz> 520k
- # [09:54] <jesup> Are you sure the GET is exactly identical? In theory the site might send you different data depending on UA, cookies, etc
- # [09:55] * Joins: daim (David_Mart@779E3E00.1773D26C.C0FF2207.IP)
- # [09:55] <firebot> Check-in: http://hg.mozilla.org/mozilla-central/rev/cf81dc222041 - Paul Rouget - Bug 689939 - Infobar disappears when node fills top and bottom of screen during page zoom in highlighter; r=rcampbell
- # [09:55] <firebot> http://hg.mozilla.org/mozilla-central/rev/8a9d9d0d3897 - Paul Rouget - Bug 694954 - [highlighter] [infobar] If a node is not visible anymore, the infobar should point to the direction of the node; r=rcampbell
- # [09:55] <protz> well no I'm not sure the get is identical, but it's downloading a plain targz from a server, so I'm curious as to why the server would send different data depending on the UA
- # [09:55] <hsivonen> protz: how did you download with Firefox?
- # [09:55] <firebot> http://hg.mozilla.org/mozilla-central/rev/37b413b9c87b - Rob Campbell - backout Bug 694954, Bug 689939; a=orange
- # [09:55] <protz> hsivonen: right click, save target as
- # [09:55] <firebot> http://hg.mozilla.org/mozilla-central/rev/127b20bb1530 - Tim Taubert - merge fx-team to m-c
- # [09:55] <firebot> http://hg.mozilla.org/mozilla-central/rev/8269e12d7adb - Paul Rouget - Bug 687702 - Skin the Style Editor according to shorlander's mockups. r=dao
- # [09:55] <protz> s/target/link/
- # [09:55] <firebot> http://hg.mozilla.org/mozilla-central/rev/462e79456fe8 - Paul Rouget - Bug 709006 - Implement a Orion theme that matches the DevTools theme. r=msucan
- # [09:55] <firebot> http://hg.mozilla.org/mozilla-central/rev/582afb96bf5d - Paul Rouget - Bug 711737 - Orion should support all the CSS properties from CSS1, CSS2, CSS2.1 and CSS3. r=msucan
- # [09:55] <hsivonen> protz: is it an HTML or XML file?
- # [09:56] <firebot> http://hg.mozilla.org/mozilla-central/rev/d79c91d63dd8 - Tim Taubert - merge m-c to fx-team
- # [09:56] <protz> hsivonen: application/x-gzip
- # [09:56] <hsivonen> protz: ok. then I don't have an explanation
- # [09:56] <protz> hsivonen: alright, I'll keep investigating, thanks :)
- # [09:56] <hsivonen> protz: oh, did Firefox automatically decompress it?
- # [09:56] <jesup> MITM injecting a trojan :-)
- # [09:56] <protz> hsivonen: not that I know of
- # [09:57] <protz> jesup: it's not going through the intertubes, the server is a local one
- # [09:57] <darktrojan> jesup: hello?
- # [09:57] <darktrojan> :-P
- # [10:00] <darktrojan> hmm, I didn't know the style editor had landed
- # [10:00] * darktrojan has clearly not been paying attention
- # [10:02] <protz> I have two different profiles running on the same version of firefox, and one of them has decided that the firefox button should appear on the right, and the other one on the left
- # [10:02] <protz> I've been unable to figure out what this depends on
- # [10:02] <protz> linux
- # [10:02] * Joins: gcp (gpascutto@moz-D0E475EA.access.telenet.be)
- # [10:02] * Joins: Pike (Pike@moz-E31CD2CB.mozilla.org)
- # [10:03] * Joins: chrisccoulson (chr1s@moz-692D94C8.cust-3601.ip.static.uno.uk.net)
- # [10:03] * Quits: Jesse (jruderman@moz-447E6DA0.oc.oc.cox.net) (Quit: Jesse)
- # [10:05] <protz> huh so the server is sending Content-Encoding: gzip to firefox but not to wget
- # [10:05] * Quits: caillon (caillon@moz-359E39FC.lightspeed.sntcca.sbcglobal.net) (Quit: caillon)
- # [10:06] <protz> hsivonen: you were right it looks like firefox performed the gzip decoding on-the-fly
- # [10:06] * Joins: roc (chatzilla@C0ACF8B.5E1E9EEA.613E47D1.IP)
- # [10:06] * Quits: mwu (mwu@moz-59435430.hsd1.nj.comcast.net) (Quit: This computer has gone to sleep)
- # [10:07] * Quits: dao (dao@moz-5C3831CE.superkabel.de) (Quit: Leaving.)
- # [10:07] * Joins: jfkthame (jfkthame@2A16B178.90783722.9542EC20.IP)
- # [10:07] <Unfocused> protz: reset your toolbar customizations, that was an old bug iirc
- # [10:07] * Joins: pnemsak (Miranda@moz-3D67D819.rainside.sk)
- # [10:08] <protz> Unfocused: oh cool, thanks !
- # [10:10] <firebot> Check-in: http://hg.mozilla.org/mozilla-central/rev/85d5d52ae629 - Dão Gottwald - Bug 707672 - openUILink[In] behavior should not be determined by browser.tabs.loadBookmarksInBackground. r=mak
- # [10:11] * Joins: msucan (msucan-@FA9E8863.56E67207.699550A1.IP)
- # [10:11] * Quits: mgoodwin (mgoodwin@moz-4BB9E5E9.cable.virginmedia.com) (Ping timeout)
- # [10:11] * Joins: mgoodwin (mgoodwin@moz-4BB9E5E9.cable.virginmedia.com)
- # [10:12] * Quits: bholley (bholley@moz-24EDB000.hsd1.ca.comcast.net) (Quit: bholley)
- # [10:12] * glob|away is now known as glob
- # [10:16] * Joins: Goldorak (chatzilla@9CD43D39.E6A99E96.187A1082.IP)
- # [10:28] * Joins: By-Tor (bytor@moz-46974D0B.dyn.optonline.net)
- # [10:28] * Joins: mzz (marienz@moz-D1CC9ED2.tomaw.net)
- # [10:29] * Quits: fzzzy (donovan@moz-2B41AF9B.lightspeed.mtvwca.sbcglobal.net) (Quit: fzzzy)
- # [10:29] * Quits: ejpbruel (ejpbruel@933E3A2E.83A511AD.F413BF4D.IP) (Quit: ejpbruel)
- # [10:29] * jfkthame is now known as jfkthame_afk
- # [10:29] * Quits: gkw (gkw@moz-A7D8CA2A.hsd1.ca.comcast.net) (Quit: Instantbird 1.1)
- # [10:29] * Quits: victorporof (victorporo@A78C599A.14EB2DE0.79933D60.IP) (Ping timeout)
- # [10:30] * Joins: bjarne (bjarne@moz-46A85847.nextgentel.com)
- # [10:37] * Quits: Mardak (Mardak@moz-4FA48382.hsd1.ca.comcast.net) (Quit: Mardak)
- # [10:38] * Quits: redfive (chatzilla@moz-75DD4703.dsl.pltn13.sbcglobal.net) (Ping timeout)
- # [10:38] * Quits: glazou (glazou@moz-204094DD.disruptive-innovations.fr) (Quit: bbl)
- # [10:44] * Quits: imphil (philipp@moz-655EF802.customer.m-online.net) (Ping timeout)
- # [10:45] * Joins: robhawkes (robhawkes@moz-33A339B7.dsl.cnl.uk.net)
- # [10:55] * Joins: AutomatedTester (AutomatedT@moz-8DECC833.as13285.net)
- # [10:57] * Quits: AutomatedTester (AutomatedT@moz-8DECC833.as13285.net) (Ping timeout)
- # [11:00] * Joins: AutomatedTester (AutomatedT@moz-EF4205EF.as13285.net)
- # [11:01] * heycam is now known as heycam|away
- # [11:05] * glob is now known as glob|away
- # [11:05] <darktrojan> is there some winxp test holdup?
- # [11:07] * ewong is now known as ewong|afk
- # [11:07] * darktrojan shrugs and ignores it
- # [11:08] * Quits: Honza (chatzilla@E07BF19C.5BB5597D.D0083327.IP) (Ping timeout)
- # [11:11] * Joins: Honza (chatzilla@E07BF19C.5BB5597D.D0083327.IP)
- # [11:13] * Joins: jacek (jacek@moz-5D707D3B.psi.wroc.pl)
- # [11:14] * Joins: glazou (glazou@moz-204094DD.disruptive-innovations.fr)
- # [11:16] * Quits: jfkthame_afk (jfkthame@2A16B178.90783722.9542EC20.IP) (Quit: jfkthame_afk)
- # [11:17] * Joins: dao (dao@moz-8D471AEE.dip.tu-dresden.de)
- # [11:25] * Quits: karl (karl@82F54078.8998A38C.C8A09C26.IP) (Ping timeout)
- # [11:26] * Joins: nitot (nitot@moz-A2A3C9E6.vlan402.asr1.cdg3.gblx.net)
- # [11:26] * Joins: whimboo (whimboo@moz-216F9AFA.superkabel.de)
- # [11:28] * Quits: gabor (gabor@moz-3B57BCD1.catv.pool.telekom.hu) (Ping timeout)
- # [11:28] * Joins: florian (florian@moz-87C33FDA.kimsufi.com)
- # [11:28] * Quits: chrisccoulson (chr1s@moz-692D94C8.cust-3601.ip.static.uno.uk.net) (Ping timeout)
- # [11:31] * Joins: davehunt (davehunt@moz-E2929564.dsl.in-addr.zen.co.uk)
- # [11:35] * Quits: Hendikins (wolfox@moz-9A361C95.static.internode.on.net) (Ping timeout)
- # [11:35] * Joins: Hendikins (wolfox@moz-9A361C95.static.internode.on.net)
- # [11:41] * Quits: juanb (jbecerra@moz-F1012875.hsd1.ca.comcast.net) (Quit: juanb)
- # [11:43] * Joins: graememcc (chatzilla@moz-DCCF2A04.range86-150.btcentralplus.com)
- # [11:43] * Quits: gandalf (zbraniecki@moz-80CE5BCD.home.aster.pl) (Quit: Computer has gone to sleep.)
- # [11:43] * Quits: mzz (marienz@moz-D1CC9ED2.tomaw.net) (Ping timeout)
- # [11:45] * Joins: prip (prip@moz-C330E3B5.k559.webspeed.dk)
- # [11:45] * Quits: bjarne (bjarne@moz-46A85847.nextgentel.com) (Ping timeout)
- # [11:46] * Joins: bjarne (bjarne@moz-46A85847.nextgentel.com)
- # [11:48] <nthomas|away> rescued a bunch of xp test boxes
- # [11:52] * Joins: edmorley (edmorley@moz-1BABC6CB.range86-166.btcentralplus.com)
- # [11:54] * Joins: mak (chatzilla@moz-6699258.retail.telecomitalia.it)
- # [11:54] * Joins: Standard8 (Standard8@B7F1AE36.48015583.54C3481B.IP)
- # [11:56] * Joins: Ms2ger (Ms2ger@moz-50F1BD94.ugent.be)
- # [11:57] <edmorley> Hi mak, Ms2ger :-)
- # [11:57] <mak> edmorley: hi!
- # [11:58] <Ms2ger> Morning
- # [11:58] * Quits: prip (prip@moz-C330E3B5.k559.webspeed.dk) (Client exited)
- # [11:58] * Quits: anky (anky@A084DBCA.44921952.A3D1B221.IP) (Client exited)
- # [11:59] * Joins: gandalf (zbraniecki@moz-8DB99104.neoplus.adsl.tpnet.pl)
- # [11:59] * khuey|away is now known as khuey
- # [11:59] <mak> edmorley: are you merging?
- # [11:59] <edmorley> mak: yeah, just surveying the damage from last night PT (can't tell it's the night before uplift in the slightest.....)
- # [12:00] <Ms2ger> ted, nspr?
- # [12:00] * Quits: RemusPop (remuspop@601F3B17.33662590.A5830293.IP) (Connection reset by peer)
- # [12:01] * Joins: kaze (kaze@moz-A2A3C9E6.vlan402.asr1.cdg3.gblx.net)
- # [12:02] * Joins: anky (anky@A084DBCA.44921952.A3D1B221.IP)
- # [12:02] * Joins: imphil (philipp@moz-4FAD558C.dfn.mwn.de)
- # [12:03] * Quits: anky (anky@A084DBCA.44921952.A3D1B221.IP) (Client exited)
- # [12:04] * Parts: whimboo (whimboo@moz-216F9AFA.superkabel.de)
- # [12:04] * Joins: anky (anky@A084DBCA.44921952.A3D1B221.IP)
- # [12:05] <firebot> Check-in: http://hg.mozilla.org/mozilla-central/rev/0ad9c268e932 - Jonas Sicking - Bug 694138: Support an array of strings as keyPath on objectStores and indexes. r=janv/bent
- # [12:05] <firebot> http://hg.mozilla.org/mozilla-central/rev/214af12ee22d - Jonas Sicking - Bug 692614: Support all spec'ed key-types, including Arrays. Patch by Jan Varga and me. r=janv/bent/me
- # [12:06] * mattwoodrow is now known as mattwoodrow|away
- # [12:08] <Ms2ger> sicking, oh, even better
- # [12:09] <Ms2ger> But please do file a followup to consolidate these defines :)
- # [12:09] <sicking> Ms2ger: will do
- # [12:11] * Joins: gabor (gabor@moz-3B57BCD1.catv.pool.telekom.hu)
- # [12:12] * Joins: regen (Miller@moz-82F245A.adsl.dynamic.seed.net.tw)
- # [12:14] * Quits: regen (Miller@moz-82F245A.adsl.dynamic.seed.net.tw) (Quit: regen)
- # [12:15] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [12:15] * Quits: ohsix (ohsix@838F6D8B.58D6D1EC.6D4D60F7.IP) (Ping timeout)
- # [12:17] * Joins: jfkthame (jfkthame@2A16B178.90783722.9542EC20.IP)
- # [12:17] * rail_away is now known as rail
- # [12:18] * Quits: jwatt (roslea@jwatt.irc.users.mozilla.org) (Ping timeout)
- # [12:19] * Quits: imphil (philipp@moz-4FAD558C.dfn.mwn.de) (Ping timeout)
- # [12:19] * Quits: sicking (chatzilla@moz-229429EC.dsl.pltn13.sbcglobal.net) (Input/output error)
- # [12:20] <Ms2ger> "Firefox 9 Released"
- # [12:20] <Ms2ger> Oh, did we?
- # [12:21] <glob|away> Ms2ger, same old, same old
- # [12:21] <glazou> to be consistent with the "meaningless version numbers", mozilla should just say "Firefox released, again"
- # [12:21] * glazou hides
- # [12:21] * Joins: mayhemer (Miranda@B3D46202.F87A741B.F23860FD.IP)
- # [12:21] <darktrojan> "Firefox is"
- # [12:21] <Ms2ger> Sure, but I don't think /. would like that as a headline
- # [12:21] <glazou> yep, that too
- # [12:22] <darktrojan> oh /. has finally woken up?
- # [12:22] <glazou> Ms2ger: not a problem; make a release every day and the headline will be permanent anyway :-D
- # [12:22] <Ms2ger> Hmm....
- # [12:22] <darktrojan> they think we do that anyway
- # [12:22] <glob|away> glazou, so, drop all channels except for nightly?
- # [12:22] <Ms2ger> Did they run a "Firefox 9 leaked" headline this time?
- # [12:23] <glazou> glob|away: I'm kidding
- # [12:23] <glob|away> "firefox 9 is now available"
- # [12:23] <glob|away> glazou, i know :)
- # [12:24] <darktrojan> "if you want it to last more than a day, build it yourself"
- # [12:25] * Joins: chrisccoulson (chr1s@moz-692D94C8.cust-3601.ip.static.uno.uk.net)
- # [12:25] * Quits: chrisccoulson (chr1s@moz-692D94C8.cust-3601.ip.static.uno.uk.net) (Client exited)
- # [12:25] * Joins: chrisccoulson (chr1s@moz-692D94C8.cust-3601.ip.static.uno.uk.net)
- # [12:27] <glob|away> hrm, there's something wrong with https://wiki.mozilla.org/RapidRelease/Calendar
- # [12:28] <glob|away> there's no mention of timezone
- # [12:28] * jfkthame is now known as jfkthame_afk
- # [12:28] <Ms2ger> 'Zilla Standard Time, surely
- # [12:30] <firebot> Check-in: http://hg.mozilla.org/mozilla-central/rev/f3c943d2e763 - Jan Varga - Bug 711727 - Followup cleanup for files in IndexedDB. r=sicking/bent
- # [12:32] <gabor> Ms2ger: assuming that IDBFactory create returns a already_addRefed, could you check if I'm doing the right thing here? http://pastebin.mozilla.org/1413558
- # [12:32] <gabor> IDBFactory::create
- # [12:34] <Ms2ger> You're not
- # [12:34] <Ms2ger> http://pastebin.mozilla.org/1413559
- # [12:35] * Quits: decoder (quassel@moz-216446B9.own-hero.net) (Ping timeout)
- # [12:36] * Quits: dao (dao@moz-8D471AEE.dip.tu-dresden.de) (Quit: Leaving.)
- # [12:37] * Joins: decoder (quassel@moz-216446B9.own-hero.net)
- # [12:39] <gabor> Ms2ger: thanks... I was not sure in this... so assigning an already_addRefed to an nsCOMPtr does not addref it again? or assigning the interface pointer with WrapNative to a jsval does not addRef the interface pointer?
- # [12:40] <gabor> anyway... it seems like it's time to read some docs
- # [12:40] <Ms2ger> The point of already_addRefed is that you have a reference in a function, and want to pass it to the caller
- # [12:41] <Ms2ger> If you returned a raw pointer, you'd release in the getter, and immediately addref in the caller
- # [12:41] * Joins: victorporof (victorporo@moz-4137721A.uaic.ro)
- # [12:42] <Ms2ger> And unless a function takes an already_addRefed argument, you shouldn't forget() it
- # [12:42] * Joins: mzz (marienz@moz-D1CC9ED2.tomaw.net)
- # [12:42] <gabor> right... it works diferently then I thought, I'll check the code I think
- # [12:42] * Joins: Callek (chatzilla@moz-DD17331C.dhcp.oxfr.ma.charter.com)
- # [12:43] <Ms2ger> As long as you don't call already_AddRefed::get, you should be safe
- # [12:43] * Quits: darktrojan (geoff@moz-BC95E278.dsl.telstraclear.net) (Quit: darktrojan)
- # [12:45] <gabor> being safe is one thing... but understanding what i'm doing is the prefered way :)
- # [12:46] <Ms2ger> Ah
- # [12:46] <Ms2ger> Good luck, then, and leave breadcrumbs :)
- # [12:47] <Ms2ger> We'll drink on your memory if you don't make it back
- # [12:47] <edmorley> heh
- # [12:48] <Ms2ger> jacek, did you mean to reopen 711381?
- # [12:49] * Quits: chrisccoulson (chr1s@moz-692D94C8.cust-3601.ip.static.uno.uk.net) (Ping timeout)
- # [12:49] * Joins: pranavrc (pranavrc@B7401A63.54549A93.520CDC98.IP)
- # [12:49] <jacek> Ms2ger: no, I don't know why this happened. thanks for catching
- # [12:49] <Ms2ger> Np
- # [12:52] * edmorley changes topic to 'm-c: OPEN m-i: OPEN || Next aurora uplift: Today! \o/ || If you are new or want to help, see irc://irc.mozilla.org/#introduction || "if you like the way it's working, just you wait five minutes"'
- # [12:54] * Quits: Goldorak (chatzilla@9CD43D39.E6A99E96.187A1082.IP) (Quit: ChatZilla 0.9.87 [Firefox 8.0/20111104165243])
- # [12:55] <gabor> haha:)
- # [12:57] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [12:57] * Quits: anky (anky@A084DBCA.44921952.A3D1B221.IP) (Client exited)
- # [12:57] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [12:58] * Quits: Ms2ger (Ms2ger@moz-50F1BD94.ugent.be) (Quit: bbl)
- # [12:59] * Quits: victorporof (victorporo@moz-4137721A.uaic.ro) (Quit: victorporof)
- # [13:02] * Joins: victorporof (victorporo@moz-4137721A.uaic.ro)
- # [13:04] <edmorley> so close! :-( https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=687289854e56
- # [13:07] <mounir> jlebar: you around?
- # [13:08] * Joins: beaufour (beaufour@moz-7BF7903.cpe.xe-6-0-0-1104.boanqu2.customer.tele.dk)
- # [13:10] * Joins: RemusPop (remuspop@601F3B17.33662590.A5830293.IP)
- # [13:10] * Quits: fer (fherrera@moz-7D8524C1.dynamic.jazztel.es) (Quit: Saliendo)
- # [13:12] * ewong|sleep is now known as ewong
- # [13:14] * Joins: maikmerten (merten@moz-E254386D.cs.uni-dortmund.de)
- # [13:17] * Joins: peregrino (peregrino@moz-96A63A2D.telecom.net.ar)
- # [13:18] * Quits: jduell (jduell@moz-2D9EDA98.lightspeed.sntcca.sbcglobal.net) (Ping timeout)
- # [13:20] * rail is now known as rail_away
- # [13:21] * Joins: jrmuizel (jrmuizel@moz-20EF8EAA.cpe.net.cable.rogers.com)
- # [13:24] * Quits: slowpoke (slowpoke@moz-F02DAE63.gigabit.perfect-privacy.com) (Ping timeout)
- # [13:24] * Joins: KaiRo (robert@moz-DD749FCB.adsl.highway.telekom.at)
- # [13:28] * Joins: chrisccoulson (chr1s@moz-692D94C8.cust-3601.ip.static.uno.uk.net)
- # [13:28] * Quits: chrisccoulson (chr1s@moz-692D94C8.cust-3601.ip.static.uno.uk.net) (Client exited)
- # [13:29] * Joins: vingtetun (vingtetun@moz-A2A3C9E6.vlan402.asr1.cdg3.gblx.net)
- # [13:30] * Joins: chrisccoulson (chr1s@moz-692D94C8.cust-3601.ip.static.uno.uk.net)
- # [13:31] <mounir> jlebar: unping
- # [13:32] <mounir> khuey: MSVC doesn't allow SomeType foo[aVar]; ?
- # [13:32] <mounir> I get error C2057: expected constant expression
- # [13:32] <mounir> I feel like using ANSI C :-/
- # [13:33] * Quits: nigelb (nigel@moz-8640053A.me) (Ping timeout)
- # [13:33] * Joins: prip (prip@moz-E702E0C9.c2440.amb314.cust.comxnet.dk)
- # [13:33] * Joins: nigelb (nigel@moz-8640053A.me)
- # [13:33] * Quits: prip (prip@moz-E702E0C9.c2440.amb314.cust.comxnet.dk) (Client exited)
- # [13:36] <Pike> glandium: might address my comment still for bug 708437 ?
- # [13:37] * Quits: jprmc (jprmc@moz-7F2FF3EB.cpe.net.cable.rogers.com) (Ping timeout)
- # [13:37] <glandium> Pike: mmm hadn't seen it. and i forgot to remove the spurious semi colon, too
- # [13:37] <khuey> mounir: there's no variable length arrays, correct
- # [13:37] <glandium> ah i missed it because i wasn't cced on the bug
- # [13:38] * jfkthame_afk is now known as jfkthame
- # [13:38] <glandium> mounir: that's a C99 construct. There's no legal equivalent in C++ yet
- # [13:38] <khuey> and msvc doesn't support c99 :-)
- # [13:38] <glandium> gcc emits a noisy warning
- # [13:39] <jfkthame> edmorley: you're even starring my try builds for me now? awesome! :)
- # [13:40] <edmorley> jfkthame: thought it might make uplift day go a bit smoother :-)
- # [13:40] <edmorley> more smoothly, even
- # [13:40] <mak> jfkthame: wait the end of the month, when you'll receive his invoice :p
- # [13:40] * Joins: slowpoke (slowpoke@moz-F02DAE63.gigabit.perfect-privacy.com)
- # [13:40] <jfkthame> ah - i knew there must be a catch!
- # [13:40] <mak> edmorley: how much is it now for a star?
- # [13:41] * Quits: cpearce (chatzilla@moz-55A2BC7D.xdsl.xnet.co.nz) (Ping timeout)
- # [13:41] <edmorley> half a review or 200 pony points :-)
- # [13:41] <mounir> glandium: that's the point, it feels weird to have ANSI C issues in C++ :-/
- # [13:41] <mak> hmmmm, pony points
- # [13:42] <mounir> but I guess I should blame gcc because it gave me the feeling that was doable in C++
- # [13:42] <glandium> mounir: you should blame yourself for not reading gcc's warnings
- # [13:43] <mounir> glandium: oh, there is warning?
- # [13:43] <mounir> didn't see it :(
- # [13:43] <glandium> mounir: yes there is
- # [13:45] <glandium> Pike: the problem in embedding/android is quite different, which is why porting the same fix doesn't quite work. Is there a specific reason the branding files are taken from dist/bin instead of the source directory?
- # [13:45] <edmorley> ...and if we didn't have a few thousand warnings on every build, things like this would be easier to spot :-)
- # [13:46] <mak> are you volunteering to fix warnings?
- # [13:46] <mounir> glandium: I do not have a worning
- # [13:46] <glandium> edmorley: what bothers me, since i'm currently doing a lot of android builds, is that the android system headers are responsible for a lot of warnings/noise :(
- # [13:47] <glandium> mounir: well, i do
- # [13:47] <mounir> glandium: so whether my version doesn't warn or -s hides it
- # [13:47] <edmorley> -s only hides the paths aiui
- # [13:48] <mounir> edmorley: it should only hide the command I believe
- # [13:48] <Pike> glandium: I figured out why my patch didn't work
- # [13:49] <Pike> glandium: different order of the java files and BRANDING
- # [13:49] <Pike> glandium: still, I don't think that doing it in the export target should work when the branding only comes in with libs
- # [13:50] <Pike> glandium: and that's the case because we don't localize the branding, so we rely on the makefile logic in branding to hard-code en-US
- # [13:50] * Quits: jrmuizel (jrmuizel@moz-20EF8EAA.cpe.net.cable.rogers.com) (Input/output error)
- # [13:52] <gandalf> is NS_NewChannel caching?
- # [13:52] * Quits: chrisccoulson (chr1s@moz-692D94C8.cust-3601.ip.static.uno.uk.net) (Ping timeout)
- # [13:52] <gandalf> if I fire two async loads of the same file will it load it twice?
- # [13:54] <khuey> no, and yes, probably
- # [13:54] <khuey> kind of depends on what you mean
- # [13:55] <khuey> file reads will likely be cached at the OS level, for instance
- # [13:55] * Joins: jorendorff (jorendorff@moz-91590D94.hsd1.tn.comcast.net)
- # [13:59] * rail_away is now known as rail
- # [14:00] <gandalf> khuey: I mean, if I use nsIStreamLoader and nsIChannel to load a file, and there is a chance that the same file will be loaded multiple times via my service, does it bring me any value to cache it or will the network stack do the caching?
- # [14:01] * Joins: smaug (chatzilla@moz-D1F69100.gprs.sl-laajakaista.fi)
- # [14:03] * rail is now known as rail-coffee
- # [14:04] * Quits: slowpoke (slowpoke@moz-F02DAE63.gigabit.perfect-privacy.com) (Ping timeout)
- # [14:07] <smaug> and again
- # [14:07] * Joins: mr_trousers (Mibbit@300E8850.15B7D320.67BABDAE.IP)
- # [14:07] <smaug> the ssl/network hang is really annoying
- # [14:07] * Joins: Ms2ger (Ms2ger@moz-518E357F.access.telenet.be)
- # [14:08] * Quits: mike5w3c (MikeS@moz-7C44325D.pool.e-mobile.ne.jp) (Ping timeout)
- # [14:08] * Joins: mike5w3c (MikeS@moz-33844EC4.pool.e-mobile.ne.jp)
- # [14:10] * Quits: graydot (jeba@63F3AA56.9CFBD76D.30E7AE68.IP) (Quit: graydot)
- # [14:11] <firebot> Check-in: http://hg.mozilla.org/mozilla-central/rev/f7a00571c87f - Reuben Morais - Bug 490225 - Open new tabs in existing browser window if there is one. r=dao
- # [14:13] * davehunt is now known as davehunt|away
- # [14:14] * Joins: jwatt (roslea@jwatt.irc.users.mozilla.org)
- # [14:14] <ted> Ms2ger: i'll ping wtc about it again
- # [14:14] <Ms2ger> Thanks
- # [14:15] * Quits: victorporof (victorporo@moz-4137721A.uaic.ro) (Ping timeout)
- # [14:16] <khuey> gandalf: I would not rely on Necko caching that
- # [14:17] <gandalf> ok
- # [14:17] <gandalf> that's sad
- # [14:17] <Ms2ger> The web? Yes
- # [14:17] <gandalf> cause the way I need it to be caches is perfectly the same as website's PNG's, scripts, stylesheet files etc.
- # [14:18] <gandalf> so I'd like to reuse a common code that does that
- # [14:18] <gandalf> (behaviors like soft reload vs. hard reload etc.)
- # [14:18] <khuey> Ms2ger: we unprefixed websockets?
- # [14:19] <khuey> gandalf: well it seems kind of silly to blow space in the memory cache to cache what's on disk
- # [14:19] <Ms2ger> Yeah, this night
- # [14:19] <khuey> gandalf: and putting stuff on the disk in the disk cache ....
- # [14:20] <Ms2ger> I think it's an awful moment to do that, but people liked it
- # [14:20] <khuey> gandalf: I don't actually know whether or not it caches it, but I wouldn't expect it to
- # [14:20] <khuey> Ms2ger: fun stuff
- # [14:20] <gandalf> khuey: I'm talking about loading files from the web
- # [14:20] <gandalf> the resources may be located on remote servers
- # [14:21] <gandalf> (exactly in the same fashion as stylesheets, javascript files and other resources linked from the document)
- # [14:21] <khuey> oh
- # [14:21] <khuey> don't call them files then :-P
- # [14:21] <gandalf> roger that, sir :)
- # [14:21] <khuey> gandalf: yeah if you fetch random stuff over http I think it gets the same caching behavior as anything else
- # [14:22] <gandalf> ok
- # [14:22] <gandalf> I'm writing a small python server to test that
- # [14:22] <gandalf> we should document that probably ;)
- # [14:23] * Joins: slowpoke (slowpoke@moz-4C99897A.pools.arcor-ip.net)
- # [14:26] * Joins: mconley (mconley@moz-9C0F4EBF.cable.teksavvy.com)
- # [14:27] * Quits: maikmerten (merten@moz-E254386D.cs.uni-dortmund.de) (Client exited)
- # [14:27] * Joins: jprmc (jprmc@678F0879.5BCEC6DB.DA78B690.IP)
- # [14:28] * Ziggy|AWAY is now known as Ziggy_Maes
- # [14:28] * Joins: romeo (romeo@moz-A9325888.k459.webspeed.dk)
- # [14:29] * Joins: evilpie (chatzilla@moz-EE3D45A2.pools.arcor-ip.net)
- # [14:29] * Joins: erione (erione@ADAD118C.7C72B2C.C752B3FA.IP)
- # [14:30] * Joins: Fallen|mac (kewisch@moz-1E4F934D.customers.d1-online.com)
- # [14:33] <protz> is there a meta-bug for the "my firefox takes forever to close and I have to kill it every single time" symptom?
- # [14:33] * Quits: rshetty_away (quassel@F4613178.6B56F8F4.D30E9BEF.IP) (Quit: No Ping reply in 180 seconds.)
- # [14:33] * Joins: rshetty (quassel@F4613178.6B56F8F4.D30E9BEF.IP)
- # [14:34] <Ms2ger> Not that I know of
- # [14:35] <mak> there are many
- # [14:35] * Joins: kats (kats@moz-DE13FC16.compute-1.amazonaws.com)
- # [14:36] <mak> protz: which version?
- # [14:36] <Ms2ger> "Bug 674725 - Part AU"
- # [14:36] <Ms2ger> Yeah, too many patches
- # [14:36] <protz> firefox 9
- # [14:36] <protz> I'm trying to figure out if it's an addon, but I thought I could check the bugs first :)
- # [14:37] * Parts: kats (kats@moz-DE13FC16.compute-1.amazonaws.com)
- # [14:37] <protz> also it's eating 100% cpu and there's nothing meaningful really in the stack trace
- # [14:37] <mak> protz: heh, I think you can easily find tens of bugs about slow shutdown, but they usually lack enough info to reproduce
- # [14:37] <protz> huh, I guess I'm on my own then :)
- # [14:38] <mak> protz: just to figure out my part, do you have autoExportHTML pref set?
- # [14:38] <protz> false
- # [14:38] <protz> it's weird, it only happens after the browser has been open for quite a long time
- # [14:38] <edmorley> Ms2ger: thanks :-)
- # [14:38] <protz> if I restart it like, now, it's blazingly fast!
- # [14:38] * Joins: sgreenlay (sgreenlay@moz-712D0FD1.dsl.bell.ca)
- # [14:39] * Joins: regen (Miller@moz-82F245A.adsl.dynamic.seed.net.tw)
- # [14:39] <Ms2ger> edmorley, hmm?
- # [14:39] <edmorley> Ms2ger: starring my inbound push
- # [14:39] <Ms2ger> Oh, np
- # [14:40] * Quits: mr_trousers (Mibbit@300E8850.15B7D320.67BABDAE.IP) (Quit: http://www.mibbit.com ajax IRC Client)
- # [14:40] * Joins: kanru (user@79E6271C.120775F3.B7D4332.IP)
- # [14:40] <mak> protz: so something is accumulating over time and discarded at shutdown... strange
- # [14:41] <protz> mak: I kill -SIGSEV'd the process, but https://crash-stats.mozilla.com/report/index/bp-6b7cedbc-6824-48ba-8b9c-6399e2111220 is not helpful
- # [14:41] <protz> and because I'm not compiling it myself, I don't think I can gdb into the process and call DumpJSStack, can I?
- # [14:41] <mak> protz: I suppose you don't have "clear history on shutdown" enabled?
- # [14:41] * rail-coffee is now known as rail
- # [14:42] <edmorley> android failure on inbound, the tip cset can't be responsible (imo), but was on free-space clobber, so presuming something earlier
- # [14:42] <mak> that stack tells me something is doing work on xpcom-shutdown notification
- # [14:42] <edmorley> ah fe434c1887f5
- # [14:42] <mak> and it's a js component
- # [14:42] <protz> mak: not that I know of
- # [14:43] <protz> I have a few addons, it may well be one of them
- # [14:43] <edmorley> glandium: ping
- # [14:43] * Joins: slowbro (slowpoke@moz-39E36627.pools.arcor-ip.net)
- # [14:43] <glandium> edmorley: pong
- # [14:43] <Ms2ger> Why a js component?
- # [14:43] <mak> well, after the notification all the stack is js
- # [14:44] <Pike> glandium: seems your patch burned the first clobberish build in incoming
- # [14:44] <edmorley> glandium: seems likely that bug 708437 is causing the android failures on inbound tip (which is the first clobber build)
- # [14:44] * Quits: slowpoke (slowpoke@moz-4C99897A.pools.arcor-ip.net) (Ping timeout)
- # [14:44] <edmorley> backout processing, about to push
- # [14:44] <glandium> Pike: great :( edmorley: yeah, you can backout 708437
- # [14:44] <Pike> also, great, no new emails coming to my zimbra
- # [14:45] * Joins: joey (chatzilla@moz-EFCB4CBF.princetowncable.com)
- # [14:46] * Quits: mconley (mconley@moz-9C0F4EBF.cable.teksavvy.com) (Input/output error)
- # [14:47] * Quits: regen (Miller@moz-82F245A.adsl.dynamic.seed.net.tw) (Quit: regen)
- # [14:48] * Joins: kenny (kenny@moz-7EAF8A2D.hsd1.wa.comcast.net)
- # [14:49] <NeilAway> protz: I thought there was a way of downloading symbols for linux builds too, although it's easier for Windows
- # [14:49] * Quits: kinetik (kinetik@B0506AEA.F200EF31.613E47D1.IP) (Ping timeout)
- # [14:50] * Quits: ewong|afk (chatzilla@moz-B5A86794.com) (Ping timeout)
- # [14:50] * glob|away is now known as glob
- # [14:50] * Joins: ewong|afk (chatzilla@moz-83240463.belfordhk.com)
- # [14:51] <smaug> hsivonen: certain documents, which are known to be alive, are marked to be in CC generation
- # [14:52] * Joins: mib_2mrt0f (Mibbit@300E8850.15B7D320.67BABDAE.IP)
- # [14:52] * Quits: jprmc (jprmc@678F0879.5BCEC6DB.DA78B690.IP) (Ping timeout)
- # [14:53] * Joins: ejpbruel (ejpbruel@moz-5EE20326.adsl2.static.versatel.nl)
- # [14:53] * Joins: kinetik (kinetik@B0506AEA.F200EF31.613E47D1.IP)
- # [14:53] * Joins: bbondy (bbondy@moz-28CF6D1C.home.cgocable.net)
- # [14:54] * rail is now known as rail_away
- # [14:54] <khuey> smaug: so, this dictionary helper tool
- # [14:54] <khuey> did you actually run this? :-)
- # [14:54] * rail_away is now known as rail
- # [14:55] <smaug> yes, it passes on try
- # [14:55] * Quits: jwatt (roslea@jwatt.irc.users.mozilla.org) (Ping timeout)
- # [14:55] <khuey> smaug: well in the patch a bunch of your python ends with ';'
- # [14:55] <Ms2ger> By chance? :)
- # [14:55] <khuey> :-P
- # [14:55] <smaug> khuey: I can imagine my python code hurts your eyes
- # [14:55] * Quits: mib_2mrt0f (Mibbit@300E8850.15B7D320.67BABDAE.IP) (Quit: http://www.mibbit.com ajax IRC Client)
- # [14:55] <smaug> bah, still some ;
- # [14:55] * Joins: regen (Miller@moz-82F245A.adsl.dynamic.seed.net.tw)
- # [14:55] <smaug> I was trying to remove those
- # [14:55] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Ping timeout)
- # [14:55] <smaug> sorry that I want sane syntax
- # [14:56] <jesup> admin needed in #firefox...
- # [14:56] * Joins: jwatt (roslea@jwatt.irc.users.mozilla.org)
- # [14:56] <khuey> smaug: you can do fd.write("""
- # [14:56] <khuey> lots of C++
- # [14:56] <khuey> spread over multiple lines
- # [14:56] <khuey> """)
- # [14:56] <smaug> yes
- # [14:57] <smaug> to my eyes fd.write is better
- # [14:57] <Ms2ger> That's not used a lot in the codegen files
- # [14:57] <smaug> but I can change that
- # [14:57] * Joins: andreasn (andreasn@moz-BB6A8755.bredband.comhem.se)
- # [14:57] * Joins: andreasn_ (andreasn@moz-BB6A8755.bredband.comhem.se)
- # [14:57] <hsivonen> smaug: ok. in that case, it would make sense to add the check you suggest to the HTML parser
- # [14:57] * Parts: andreasn (andreasn@moz-BB6A8755.bredband.comhem.se)
- # [14:57] <smaug> khuey: thank you!
- # [14:58] <smaug> aurora uplift didn't happen yet, right?
- # [14:58] <khuey> nope
- # [14:58] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [14:58] <smaug> I don't want to push that tool to aurora
- # [14:58] * khuey is scared now
- # [14:58] <khuey> ah ,ok
- # [14:58] * khuey relaxes
- # [14:58] <jesup> Time for the last-second-rubber-stamp-roulette - will someone willing to rs jprof changes show up before uplift? Tune in and see!
- # [14:58] <smaug> :)
- # [14:58] <Ms2ger> So you'll push it now so you don't have to push it to aurora yourself?
- # [14:58] <Ms2ger> jesup, rs-
- # [14:59] <khuey> ouch
- # [14:59] <khuey> that was brutal
- # [14:59] <smaug> Ms2ger: bah. I mean I want it to FF12
- # [14:59] * Joins: imphil (philipp@moz-55513EF0.rad.med.uni-muenchen.de)
- # [14:59] <jesup> Seems only dbaron and bz know enough to look at it -- though neither ever actually reads the patches and they just rs+ it since it's NPOTB
- # [15:00] <Ms2ger> Sounds like bsmedberg and OS/2
- # [15:01] <jesup> Yeah. jprof only is build on --enable-jprof, and unless the patches touch mainline code (normally they don't) it's irrelevent to anyone but me, really.
- # [15:01] * Quits: smontagu (chatzilla@moz-95CF342D.red.bezeqint.net) (Ping timeout)
- # [15:01] <Ms2ger> And other people who want to rush code in right now
- # [15:02] <jesup> Still doesn't matter if they aren't touching tools/jprof (and the patch is a DONTBUILD patch)
- # [15:03] * khuey grumbles
- # [15:03] <jesup> not a big deal (adding an output option for benwa's front-end snappy analyzer)
- # [15:03] <khuey> poking around the disassembly of windows apis sucks
- # [15:04] <smaug> hsivonen: so at which point will parser release those nodes?
- # [15:04] * mak is now known as mak|afk
- # [15:04] <smaug> hsivonen: when parsing is done?
- # [15:06] <mounir> edmorley: you are really starring jobs in try?
- # [15:06] * Joins: AaronMT (AaronMT@moz-DB17C53A.cpe.net.cable.rogers.com)
- # [15:06] <Ms2ger> Then you don't have to check them all every time you look at tbpl
- # [15:07] * davehunt|away is now known as davehunt
- # [15:07] * Joins: Enn (enn@F2D29657.F60B0462.67AC9B1.IP)
- # [15:08] <edmorley> mounir: thought it would be quicker for me to do (+ in one go), rather than 10 devs less familiar with known oranges that don't show up via tbpl summary, to each individually do (given it's uplift day)
- # [15:09] * Quits: Fallen|mac (kewisch@moz-1E4F934D.customers.d1-online.com) (Ping timeout)
- # [15:09] * Joins: Suresh (chatzilla@59631007.A67A8385.EB06F97B.IP)
- # [15:10] * Joins: Fallen|mac (kewisch@moz-1E4F934D.customers.d1-online.com)
- # [15:11] * Joins: sheppy (sheppy@moz-F39D62DA.dhcp.kgpt.tn.charter.com)
- # [15:13] <hsivonen> smaug: when the parser itself is destructed, so after parsing is done
- # [15:14] * Joins: dbradley (dbradley@moz-8FACAA93.fuse.net)
- # [15:15] * Joins: mconley (mconley@F2D29657.F60B0462.67AC9B1.IP)
- # [15:16] * Quits: erione (erione@ADAD118C.7C72B2C.C752B3FA.IP) (Ping timeout)
- # [15:17] * Quits: smaug (chatzilla@moz-D1F69100.gprs.sl-laajakaista.fi) (Ping timeout)
- # [15:20] <Ms2ger> <davidb> BTW a bicycle site crashing FF for screen reader users is a safety feature.
- # [15:20] * Ms2ger approves
- # [15:21] <glob> hehe
- # [15:24] * Joins: anky (anky@97945A95.8A8D24F2.A3D1B221.IP)
- # [15:25] * Joins: josh (josh@moz-2EE66546.nyc.res.rr.com)
- # [15:25] * Joins: ajuma (ajuma@F2D29657.F60B0462.67AC9B1.IP)
- # [15:27] * Quits: Suresh (chatzilla@59631007.A67A8385.EB06F97B.IP) (Client exited)
- # [15:27] * Joins: davidb (davidb@F2D29657.F60B0462.67AC9B1.IP)
- # [15:32] * Joins: armenzg (armenzg@moz-A6FE435.build.sjc1.mozilla.com)
- # [15:32] * Quits: rshetty (quassel@F4613178.6B56F8F4.D30E9BEF.IP) (Ping timeout)
- # [15:32] * Joins: Goldorak (chatzilla@9CD43D39.E6A99E96.187A1082.IP)
- # [15:32] <sheppy> lol
- # [15:34] * Quits: Fallen|mac (kewisch@moz-1E4F934D.customers.d1-online.com) (Ping timeout)
- # [15:34] * Joins: whimboo (whimboo@moz-216F9AFA.superkabel.de)
- # [15:34] * Joins: rshetty (quassel@77EBE0C9.CD099EF.C842849F.IP)
- # [15:35] * Joins: regen_ (Miller@moz-82F245A.adsl.dynamic.seed.net.tw)
- # [15:35] <whimboo> is there a way to print the gc/cc log to the command line and not only to the error console?
- # [15:35] * Quits: regen_ (Miller@moz-82F245A.adsl.dynamic.seed.net.tw) (Quit: regen_)
- # [15:35] * Joins: regen_ (Miller@moz-82F245A.adsl.dynamic.seed.net.tw)
- # [15:36] * Quits: regen (Miller@moz-82F245A.adsl.dynamic.seed.net.tw) (Ping timeout)
- # [15:36] * Joins: qheaden (qheaden@moz-67E02157.nrflva.fios.verizon.net)
- # [15:36] <qheaden> Hey everyone!
- # [15:37] <edmorley> hi :-)
- # [15:38] <qheaden> I decided to start doing some FF dev on Linux for a change. It compiles much faster on Linux than windows.
- # [15:38] * Quits: Enn (enn@F2D29657.F60B0462.67AC9B1.IP) (Input/output error)
- # [15:38] * Quits: peregrino (peregrino@moz-96A63A2D.telecom.net.ar) (Ping timeout)
- # [15:38] <qheaden> I guess because the tools are native to the OS.
- # [15:38] * Joins: peregrino (peregrino@moz-96A63A2D.telecom.net.ar)
- # [15:39] * mcote|afk is now known as mcote
- # [15:40] <qheaden> So which FF version will be uplifted to Aurora status? Version 10?
- # [15:40] * Joins: jrmuizel (jrmuizel@F2D29657.F60B0462.67AC9B1.IP)
- # [15:41] <khuey> 11
- # [15:41] <glob> qheaden, see https://wiki.mozilla.org/RapidRelease/Calendar
- # [15:41] <qheaden> khuey: Oh wow, that was fast. :)
- # [15:41] <qheaden> glob: Thanks
- # [15:41] * Quits: kaze (kaze@moz-A2A3C9E6.vlan402.asr1.cdg3.gblx.net) (Ping timeout)
- # [15:43] * qheaden is happy about his first bugfix being in FF 10 beta. :)
- # [15:43] * Joins: caillon (caillon@moz-359E39FC.lightspeed.sntcca.sbcglobal.net)
- # [15:43] * Joins: dbaron (dbaron@moz-389E0BB7.phlapa.fios.verizon.net)
- # [15:43] * ChanServ sets mode: +o dbaron
- # [15:43] <jesup> dbaron!
- # [15:44] <@dbaron> g'morning
- # [15:44] * Joins: zuzelvp (zuzelvp@2112147D.C3507A2D.9A8C35B4.IP)
- # [15:44] <tbsaunde> 0
- # [15:44] <qheaden> Good morning :)
- # [15:44] <jesup> dbaron: interested in rs-ing a jprof-only change (to the analysis tool)? bug 710849
- # [15:45] <firebot> Check-in: http://hg.mozilla.org/mozilla-central/rev/887abec76bca - Mike Gorse - bug 693343 - a11y disabled on gnome 3 when GNOME_ACCESSIBILITY is unset r=tbsaunde, karlt
- # [15:45] <@dbaron> jesup, wrong bug number
- # [15:46] <jesup> How'd I grab that one? Bug 712224
- # [15:46] <jesup> Making jprof produce output benwa's snappy analysis tool can parse
- # [15:46] <@dbaron> jesup, yeah, saw the request... still reading email... I'll have a look in the next few hours
- # [15:46] <jesup> np
- # [15:47] <jesup> It doesn't need to land today; as jprof-only, I can probably get a= for it on aurora later
- # [15:47] <jesup> Consider it low priority
- # [15:47] <edmorley> qheaden: congrats :-)
- # [15:48] <qheaden> edmorley: Thx
- # [15:48] <jesup> qheaden: ditto
- # [15:48] * qheaden accepts the award and bows to the audience.
- # [15:48] <qheaden> :P
- # [15:49] * Joins: Fallen|mac (kewisch@moz-17E072E0.customers.d1-online.com)
- # [15:49] <edmorley> right, time to make a cuppa before the real uplift day bustage onslaught begins
- # [15:49] * Quits: mgoodwin (mgoodwin@moz-4BB9E5E9.cable.virginmedia.com) (Connection reset by peer)
- # [15:49] * Joins: mgoodwin (mgoodwin@moz-4BB9E5E9.cable.virginmedia.com)
- # [15:49] <qheaden> I'm happy to see that FF is getting much faster.
- # [15:50] * Quits: mcote (mcote@moz-7CCC926E.mc.videotron.ca) (Quit: leaving)
- # [15:50] <qheaden> I installed Ubuntu 10.04 LTS on my desktop, and it had FF 3 on it. It ran MUCH slower than 8, and of course the mozilla-central version. Happy to see it.
- # [15:50] * Joins: peregrino_ (peregrino@moz-96A63A2D.telecom.net.ar)
- # [15:51] <firebot> Check-in: http://hg.mozilla.org/mozilla-central/rev/860fdd41cfed - Trevor Saunders - bug 693343 - fix review nit missed when qrefreshing r=me
- # [15:52] <tbsaunde> qrefresh I will kill you some day...
- # [15:52] * Quits: peregrino (peregrino@moz-96A63A2D.telecom.net.ar) (Ping timeout)
- # [15:52] * coop|away is now known as coop
- # [15:52] * peregrino_ is now known as peregrino
- # [15:52] * bwinton_away is now known as bwinton
- # [15:52] * Joins: ohsix (ohsix@4353B567.EB213E1.8EE29C2D.IP)
- # [15:52] * Joins: rwaldron (rwaldron@moz-BDCCF091.hfc.comcastbusiness.net)
- # [15:52] <gabor> can I edit an attachment on firebug? I filed a patch without fixing the patch checkbox, shall I resend the patch or is there a way to fix it somehow?
- # [15:53] <mounir> gabor: details -> edit details -> check 'patch'
- # [15:53] <gabor> s/fixing/checking in
- # [15:54] <gabor> mounir++
- # [15:54] * Quits: ohsix (ohsix@4353B567.EB213E1.8EE29C2D.IP) (Ping timeout)
- # [15:56] * Joins: jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP)
- # [15:56] <khuey> imphil: ping
- # [15:56] <imphil> khuey, pong
- # [15:56] <qheaden> I've really got to start hg pull && hg update'ng my repository more.
- # [15:56] <khuey> imphil: your patch doesn't apply
- # [15:56] <khuey> it looks like it's against an old m-c revision?
- # [15:56] * khuey sees some PRBool in there
- # [15:57] <imphil> khuey, hm ok, it did yesterday
- # [15:57] * Joins: bent (chatzilla@moz-32655341.midsouth.biz.rr.com)
- # [15:57] <edmorley> qheaden: make a cron job
- # [15:57] <imphil> khuey, I'll have a look
- # [15:57] * Joins: lmandel (lmandel@F2D29657.F60B0462.67AC9B1.IP)
- # [15:57] * Quits: tonymec (tonymec@6174664F.9256CA4D.277517C1.IP) (Ping timeout)
- # [15:57] <qheaden> edmorley: I tend to not during while fixing code so as not to have to merge conflicts.
- # [15:57] * Joins: mcote (mcote@moz-7CCC926E.mc.videotron.ca)
- # [15:57] <qheaden> edmorley: Of course that is a bad excuse. :P
- # [15:58] * bent is now known as IRCMonkey18128
- # [15:58] <qheaden> So far, the code I've been working on hasn't conflicted yet, but still, I hate merging.
- # [15:59] <qheaden> Is it recommended to pull and update with a Mq patch applied? Or should I call hg qpop -a first?
- # [15:59] * Joins: kaze (kaze@moz-A2A3C9E6.vlan402.asr1.cdg3.gblx.net)
- # [15:59] <edmorley> qheaden: understandable :-) my trees are pretty much always up to date, just because merging inbound and backing out means they have to be, and my on-the-verge-of-death HD gets stroppy enough about 1 checkout each of m-c and inbound, let alone multiple :-/
- # [16:00] <qheaden> Your poor HD needs a vacation. :P
- # [16:00] * Joins: tonymec (tonymec@6174664F.9256CA4D.277517C1.IP)
- # [16:01] <edmorley> qheaden: preferable to qpop -a first, otherwise the first qpop will take ages, as it has to do funky things to work around the fact that mq makes fake commits in the repo
- # [16:01] * Quits: mayhemer (Miranda@B3D46202.F87A741B.F23860FD.IP) (Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org)
- # [16:01] <qheaden> edmorley: Agreed
- # [16:01] <qheaden> brb
- # [16:01] * qheaden is now known as qheaden_away
- # [16:03] * Joins: Enn (enn@F2D29657.F60B0462.67AC9B1.IP)
- # [16:04] <imphil> khuey, indeed, I'm sorry, I attached the wrong patch to the bug. should be ok now
- # [16:05] * Quits: kenny (kenny@moz-7EAF8A2D.hsd1.wa.comcast.net) (Quit: Leaving)
- # [16:05] * IRCMonkey18128 is now known as bent
- # [16:06] * Quits: anky (anky@97945A95.8A8D24F2.A3D1B221.IP) (Ping timeout)
- # [16:06] <firebot> Check-in: http://hg.mozilla.org/mozilla-central/rev/7d75e0057998 - Philipp Wagner - Bug 693615 - element.lookupNamespaceURI(null) in text/html page cause NS_ERROR_FAILURE error on XrayWrappers; r=bz
- # [16:07] * Joins: anky (anky@3921E49A.68D1775A.A3D1B221.IP)
- # [16:07] * Joins: ashughes (ashughes@6202C507.852FE72D.DA78B690.IP)
- # [16:07] * Joins: ahal (ahal@F2D29657.F60B0462.67AC9B1.IP)
- # [16:07] <imphil> khuey, thanks
- # [16:07] <khuey> imphil: thanks for the patch :-)
- # [16:08] * jhopkins|afk is now known as jhopkins
- # [16:09] * Quits: peregrino (peregrino@moz-96A63A2D.telecom.net.ar) (Ping timeout)
- # [16:10] * Joins: peregrino (peregrino@moz-D0CB2FAA.telecom.net.ar)
- # [16:10] * merike|away is now known as merike
- # [16:12] * bhearsum|afk is now known as bhearsum
- # [16:13] <bent> khuey, seems like we should have a way to make the idl tools available before libs::
- # [16:14] * Joins: jimm (jmathies@moz-7F164CA1.pn.at.cox.net)
- # [16:16] <Callek> can I borrow any mac user to confirm a SeaMonkey bug for me? (should be a real real simple bug to check)
- # [16:16] <Callek> Bug 712298
- # [16:16] <khuey> bent: does it really matter?
- # [16:17] * Joins: redfive (chatzilla@moz-75DD4703.dsl.pltn13.sbcglobal.net)
- # [16:17] * Joins: michal (michal@moz-5C5A58A8.broadband14.iol.cz)
- # [16:17] <bent> having exported headers that aren't generated until libs seems like a headache
- # [16:17] * Quits: michal (michal@moz-5C5A58A8.broadband14.iol.cz) (Input/output error)
- # [16:17] * Joins: michal (michal@moz-5C5A58A8.broadband14.iol.cz)
- # [16:18] * armenzg is now known as armenzg_brb
- # [16:18] <bent> though... i guess i don't understand what needs to wait for libs
- # [16:18] * Quits: mcote (mcote@moz-7CCC926E.mc.videotron.ca) (Ping timeout)
- # [16:18] <bent> idl parsing obviously happens for interface exports
- # [16:19] * Quits: Pike (Pike@moz-E31CD2CB.mozilla.org) (Ping timeout)
- # [16:19] * Joins: mcote (mcote@moz-7CCC926E.mc.videotron.ca)
- # [16:19] <khuey> and that idl parsing happens when we traverse those directories
- # [16:20] <khuey> which for dom stuff is after js/xpconnect
- # [16:20] * Joins: victorporof (victorporo@3A53A763.F695A43D.79933D60.IP)
- # [16:20] <khuey> really what should probably happen is that we should generate the dictionary code when we parse the idl for header generation
- # [16:20] <khuey> but implementing that before we move to webidl seems silly
- # [16:21] <bent> do we have someone assigned to that btw?
- # [16:21] <khuey> what, exactly
- # [16:22] <Ms2ger> Yes, bent
- # [16:22] <bent> webidl
- # [16:22] <khuey> what about webidl
- # [16:23] <bent> do we have someone assigned to "do it"
- # [16:23] <khuey> there are a lot of pieces here, and different people are working on different things
- # [16:24] * Quits: regen_ (Miller@moz-82F245A.adsl.dynamic.seed.net.tw) (Quit: regen_)
- # [16:25] * Joins: dveditz (dveditz@moz-34991AF4.dhcp.cruzio.com)
- # [16:25] * ChanServ sets mode: +o dveditz
- # [16:26] * Joins: mayhemer (Miranda@B3D46202.F87A741B.F23860FD.IP)
- # [16:26] * Quits: andreasn_ (andreasn@moz-BB6A8755.bredband.comhem.se) (Quit: Ex-Chat)
- # [16:27] * Joins: hipokrit (hipokrit@moz-502C3BF.rackspace.net)
- # [16:27] * Joins: mdas (mdas@F2D29657.F60B0462.67AC9B1.IP)
- # [16:27] * Joins: Pike (Pike@moz-E31CD2CB.mozilla.org)
- # [16:27] * Quits: waschtl (waschtl@moz-A4ECE553.hsi4.kabel-badenwuerttemberg.de) (Client exited)
- # [16:28] <tbsaunde> edmorley: did I somehow burn the tree? my browser is shit o day (really long story) but that patch was fine on try an hour ago
- # [16:29] <Ms2ger> Mm, linux debug builds are orange
- # [16:29] * mkelly|gone is now known as mkelly
- # [16:29] <tbsaunde> Ms2ger: see what I just said?
- # [16:30] <tbsaunde> Ms2ger: would you mind giving me a error?
- # [16:30] * tbsaunde rages at the worl
- # [16:30] <Ms2ger> Doesn't seem to be your fault
- # [16:30] <tbsaunde> Ms2ger: thanks!!!
- # [16:31] * davehunt is now known as davehunt|away
- # [16:31] * qheaden_away is now known as qheaden
- # [16:33] <qheaden> Hmm. I'm getting a build error on Linux. Something about TEST_UNEXPECTED_FAIL | xpccheck
- # [16:33] * Quits: beaufour (beaufour@moz-7BF7903.cpe.xe-6-0-0-1104.boanqu2.customer.tele.dk) (Quit: beaufour)
- # [16:34] * Joins: LegNeato (clegnitto@moz-B77DEAEB.mozilla.org)
- # [16:34] * Quits: Pike (Pike@moz-E31CD2CB.mozilla.org) (Ping timeout)
- # [16:34] <LegNeato> REMINDER: Source migration is today. Get your patches in
- # [16:34] <Ms2ger> LegNeato, itym "Stay away from the tree"
- # [16:34] * philor|away is now known as philor
- # [16:34] * Joins: biesi (cbiesinger@2E747C8D.C1499D0.396E4C6D.IP)
- # [16:34] <edmorley> tbsaunde: sorry was afk, still poking at the logs, but wasn't you, happened on the push before
- # [16:34] <LegNeato> Ms2ger: Yes :-P
- # [16:34] * ewong is now known as ewong|sleep
- # [16:35] <edmorley> tbsaunde: so either the push before or infra
- # [16:35] <Ms2ger> edmorley, I blame infra
- # [16:36] * edmorley kicks pokes Nightly in the hope it loads the logs faster
- # [16:36] * Quits: redfive (chatzilla@moz-75DD4703.dsl.pltn13.sbcglobal.net) (Connection reset by peer)
- # [16:36] <edmorley> mid-comment revision fail
- # [16:37] * Joins: redfive (chatzilla@moz-75DD4703.dsl.pltn13.sbcglobal.net)
- # [16:37] * Joins: smontagu (chatzilla@moz-95CF342D.red.bezeqint.net)
- # [16:37] * khuey is now known as khuey|away
- # [16:38] <Ms2ger> Or the pywebsocket update
- # [16:38] * Joins: smaug (chatzilla@moz-E39770AA.gprs.sl-laajakaista.fi)
- # [16:38] * khuey|away is now known as khuey
- # [16:39] * Quits: RemusPop (remuspop@601F3B17.33662590.A5830293.IP) (Client exited)
- # [16:40] <qheaden> Do you guys remove your objdir each time you pull, update, and build?
- # [16:40] * gregglind_away is now known as gregglind
- # [16:40] <khuey> no
- # [16:40] <qheaden> Ok.
- # [16:41] * Joins: Pike (Pike@moz-E31CD2CB.mozilla.org)
- # [16:41] * Joins: bmoss (bmoss@moz-54D507F.hsd1.ca.comcast.net)
- # [16:42] * Joins: Saurabh (abc@BCB4D3DC.2A41BE0.C5C1B1F7.IP)
- # [16:42] * armenzg_brb is now known as armenzg
- # [16:43] <edmorley> !seen jduel
- # [16:43] <firebot> I've never seen a 'jduel', sorry.
- # [16:43] <edmorley> !seen jduell
- # [16:43] * catlee-away is now known as catlee
- # [16:43] <Ms2ger> !seen jduell
- # [16:43] <firebot> jduell was last seen 7 hours, 39 minutes and 26 seconds ago, saying 'glandium: well, right. But landing on m-c increases my chances exponentially!' in #developers.
- # [16:43] <edmorley> jinx :-)
- # [16:43] <firebot> jduell was last seen 7 hours, 39 minutes and 26 seconds ago, saying 'glandium: well, right. But landing on m-c increases my chances exponentially!' in #developers.
- # [16:43] <edmorley> ...of breaking linux builds, yes :-)
- # [16:43] * armenzg is now known as armenzg_bus
- # [16:45] <smaug> glandium: why a mutex is used in that nullstring case?
- # [16:45] * Parts: Saurabh (abc@BCB4D3DC.2A41BE0.C5C1B1F7.IP)
- # [16:46] <glandium> smaug: because c++ requires that the static initialization of the const variable within the function is thread-safe. So in fact, the function will get a mutex, test whether the constant is initialized, initialize it if it's not, release the mutex and return the constant.
- # [16:46] * Quits: armenzg_bus (armenzg@moz-A6FE435.build.sjc1.mozilla.com) (Ping timeout)
- # [16:47] * Joins: graydot (jeba@B6001B9.4E8FB30C.700C6EB0.IP)
- # [16:47] * Joins: Joeh (joe@5A3923AA.BC22908.C7CEC4ED.IP)
- # [16:48] * Joins: espindola (espindola@moz-16A6837B.dsl.teksavvy.com)
- # [16:48] <smaug> glandium: is the situation same with EmptyString() ?
- # [16:48] <smaug> I assume so
- # [16:48] <glandium> smaug: as a matter of fact, yes
- # [16:49] <espindola> jrmuizel, would you be ok with reviewing the new patch in 708051? It is much smaller than the previous one and Joe will be back only Jan 3.
- # [16:49] <glandium> smaug: so yeah, nothing new under the sun
- # [16:49] * smaug couldn't have imagined that C++ does anything with threads by default
- # [16:49] * Quits: peregrino (peregrino@moz-D0CB2FAA.telecom.net.ar) (Ping timeout)
- # [16:50] * Joins: peregrino (peregrino@moz-D0CB2FAA.telecom.net.ar)
- # [16:50] * Joins: akeybl (akeybl@moz-52D39FF6.hsd1.ca.comcast.net)
- # [16:50] * Quits: bmoss (bmoss@moz-54D507F.hsd1.ca.comcast.net) (Quit: bmoss)
- # [16:50] <kennyluck> Are there people here who are against this channel being logged?
- # [16:50] * Quits: bjarne (bjarne@moz-46A85847.nextgentel.com) (Quit: Leaving.)
- # [16:51] <smaug> glandium: any suggestions how to improve that situation?
- # [16:51] <Callek> kennyluck: its already logged
- # [16:51] <Callek> so if you're planning to add a logging system for your own use, go ahead
- # [16:51] <glandium> smaug: mmm actually looking at the code gcc generates, it only acquires the lock if it the constant wasn't already initialized, so it's not as bad as i suggested
- # [16:51] * ctalbert|afk is now known as ctalbert
- # [16:51] <kennyluck> Callek, oh is it? Where?
- # [16:52] <Callek> http://bugzilla.glob.com.au/irc/?c=developers
- # [16:52] <edmorley> roc:ping
- # [16:52] <kennyluck> Callek, ah great. Thanks.
- # [16:52] <philor> edmorley: why are we convinced that tbsaunde is blameless?
- # [16:52] <smaug> glandium: much better
- # [16:52] <smaug> glandium: if that is the case, there isn't anything to optimize, I think
- # [16:52] <philor> I mean, I'd like for him to be, sure...
- # [16:52] * Quits: graydot (jeba@B6001B9.4E8FB30C.700C6EB0.IP) (Quit: graydot)
- # [16:53] <edmorley> philor: push before is orange surely?
- # [16:53] <philor> ?
- # [16:53] * Quits: redfive (chatzilla@moz-75DD4703.dsl.pltn13.sbcglobal.net) (Ping timeout)
- # [16:53] * qheaden is now known as qheaden_away
- # [16:53] <philor> am I on the wrong tree, or looking at the wrong failure?
- # [16:53] <glandium> smaug: well it's possible to optimize, but it's probably much more work
- # [16:54] <edmorley> philor: oh you meant 887abec76bca authored by Mike Gorse but pushed by tbsaunde
- # [16:54] <philor> yeah
- # [16:54] <edmorley> sorry, trying to do too many things at once :-)
- # [16:54] <edmorley> philor: I'm not sure
- # [16:54] * Quits: peregrino (peregrino@moz-D0CB2FAA.telecom.net.ar) (Ping timeout)
- # [16:55] * Joins: Suresh (chatzilla@CE80C3FC.5C86A38E.EB06F97B.IP)
- # [16:55] <edmorley> poking at the log is a bit hit or miss
- # [16:55] <edmorley> have retriggered
- # [16:57] * khuey is now known as khuey|away
- # [16:57] <NeilAway> glandium: I suppose nsA(C)String could have a private base struct which you could then declare static, and then Empty(C)String() could cast it to a const ns(C)String
- # [16:57] <glandium> NeilAway: yeah, something like that
- # [16:58] * Joins: regen (Miller@moz-82F245A.adsl.dynamic.seed.net.tw)
- # [16:59] <edmorley> philor: shall we just backout and see?
- # [16:59] <Ms2ger> philor, fwiw, tbsaunde says he was green on try earlier
- # [17:00] * Quits: jacek (jacek@moz-5D707D3B.psi.wroc.pl) (Client exited)
- # [17:00] * Joins: peregrino (peregrino@moz-D0CB2FAA.telecom.net.ar)
- # [17:00] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [17:01] <tbsaunde> https://tbpl.mozilla.org/?tree=Try&rev=083fd66ad8f2 fwiw
- # [17:01] <edmorley> thanks
- # [17:01] <edmorley> I'll retrigger a known green from the push before, to see if some infra change could have caused it
- # [17:01] * Quits: anky (anky@3921E49A.68D1775A.A3D1B221.IP) (Client exited)
- # [17:01] * philor loads up the try log
- # [17:01] * Joins: dao (dao@moz-283B6C57.pool.mediaways.net)
- # [17:01] * Joins: ehsan (ehsan@F2D29657.F60B0462.67AC9B1.IP)
- # [17:02] <philor> not that I don't trust try to run the same things that m-c runs, but, well, I don't trust to try to run the same things
- # [17:02] <Ms2ger> :)
- # [17:02] * tbsaunde starts local debug build for the fun of it
- # [17:02] * gregglind is now known as gregglind_afk_until_10_pst
- # [17:04] <philor> interesting: try still does a couple of rather foolish and pointless steps, that wind up creating a profile which isn't actually used, and that's apparently enough
- # [17:04] * Joins: armenzg_bus (armenzg@D0E54E4D.5BCEC6DB.DA78B690.IP)
- # [17:04] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [17:04] * armenzg_bus is now known as armenzg
- # [17:04] <Ms2ger> philor, the first word I can think of to describe that is "Mozilla"
- # [17:04] * Quits: tonymec (tonymec@6174664F.9256CA4D.277517C1.IP) (Broken pipe)
- # [17:05] <philor> so my wild guess, having been awake for 20 minutes, is that the patch introduces a shutdown hang or at least a shutdown really-slow, and try survives it by being foolish
- # [17:05] * davehunt|away is now known as davehunt
- # [17:06] <tbsaunde> do we run the browser during build?
- # [17:06] <bhearsum> tbsaunde: on PGO builds we run it briefly, to profile
- # [17:06] <bhearsum> and on debug builds we run it for the leak tests
- # [17:06] <philor> multiple times
- # [17:07] <bhearsum> yeah
- # [17:07] <philor> on try, several of those times what could be charitably called "in a totally insane manner"
- # [17:07] <tbsaunde> ok, I figured for pgo, but didn't know about !pgo
- # [17:07] <edmorley> ok, so no other trees exhibiting the issue + now have three m-c pushes with the failure, so going to backout on the premise that try avoids the failure
- # [17:07] * Joins: nhirata (nhirata.bu@moz-2A9C9106.hsd1.ca.comcast.net)
- # [17:08] <tbsaunde> so, if that theory is true I have no idea ow that patch introduces a shutdown hang
- # [17:08] <tbsaunde> edmorley: ok, fine by me thanks
- # [17:08] <philor> "firefox-bin -no-remote -profile /builds/slave/try-lnx64-dbg/build/obj-firefox/_leaktest/leakprofile/ http://localhost:8888/bloatcycle.html -P default"
- # [17:09] * Joins: hhillen (hhillen@moz-81563C98.ip.telfort.nl)
- # [17:09] <philor> no idea how you could be saved by that bit of foolishness, either
- # [17:09] * Quits: humph (dave@moz-E0B198AD.senecac.on.ca) (Quit: leaving)
- # [17:09] <tbsaunde> philor: what's foolish about that other than 2 -p's
- # [17:10] * Quits: wolfiR (wolfiR@moz-9F2DACD5.dip0.t-ipconnect.de) (Quit: Leaving)
- # [17:10] * Quits: mak|afk (chatzilla@moz-6699258.retail.telecomitalia.it) (Input/output error)
- # [17:11] * Quits: tonymec|away (tonymec@6174664F.9256CA4D.277517C1.IP) (Input/output error)
- # [17:11] * Joins: Mardak (Mardak@moz-4FA48382.hsd1.ca.comcast.net)
- # [17:12] <firebot> Check-in: http://hg.mozilla.org/mozilla-central/rev/6af20fb62fb7 - Ed Morley - Backout 860fdd41cfed & 887abec76bca (bug 693343) for suspected Linux shutdown hangs
- # [17:12] * Joins: chrisccoulson (chr1s@moz-692D94C8.cust-3601.ip.static.uno.uk.net)
- # [17:12] * Quits: chrisccoulson (chr1s@moz-692D94C8.cust-3601.ip.static.uno.uk.net) (Client exited)
- # [17:12] * Quits: smaug (chatzilla@moz-E39770AA.gprs.sl-laajakaista.fi) (Connection reset by peer)
- # [17:13] * Joins: alex_mayorga (u4422@moz-160C58C6.com)
- # [17:13] * Quits: regen (Miller@moz-82F245A.adsl.dynamic.seed.net.tw) (Quit: regen)
- # [17:13] <philor> tbsaunde: that's the foolishness, there's a buildstep that thinks it creates a profile, though it doesn't, then that buildstep which thinks that it will use the profile, though it doesn't
- # [17:14] <tbsaunde> philor: oh, lols
- # [17:15] * Parts: alex_mayorga (u4422@moz-160C58C6.com)
- # [17:15] <LegNeato> REMINDER: 1 hour until source migration. Be kind to the tree!
- # [17:15] <tbsaunde> so, to try and reproduce this locally I assume I need to do more than make -f client.mk with --enable-debug right?
- # [17:15] <philor> probably so, yeah
- # [17:16] * Joins: chrisccoulson (chr1s@moz-692D94C8.cust-3601.ip.static.uno.uk.net)
- # [17:16] * Quits: smontagu (chatzilla@moz-95CF342D.red.bezeqint.net) (Ping timeout)
- # [17:16] <tbsaunde> philor: what are the other steps before tbpl decides its a good build?
- # [17:16] * tbsaunde nub here
- # [17:17] * Joins: mstange (mstange@moz-685E8D65.wohnheim.uni-kl.de)
- # [17:17] * Quits: jhorak (jhorak@moz-107AD163.redhat.com) (Quit: Leaving)
- # [17:18] * Parts: mstange (mstange@moz-685E8D65.wohnheim.uni-kl.de)
- # [17:18] <philor> tbsaunde: in theory, build with ac_add_options --enable-debug and ac_add_options --enable-trace-malloc, cd objdir/_leaktest/, python leaktest.py, then python leaktest.py --trace-malloc malloc.log --shutdown-leaks=sdleak.log should repro
- # [17:19] <gandalf> how do I convert nsACString to feed it to printf() as an argument?
- # [17:20] * Quits: sheppy (sheppy@moz-F39D62DA.dhcp.kgpt.tn.charter.com) (Quit: sheppy)
- # [17:20] <tbsaunde> philor: thanks
- # [17:21] <tbsaunde> gandalf: nsACString::get() works I believe
- # [17:21] * Quits: nhirata (nhirata.bu@moz-2A9C9106.hsd1.ca.comcast.net) (Quit: nhirata)
- # [17:21] * Joins: bmoss (bmoss@moz-BBE3ABD.mv.mozilla.com)
- # [17:21] <gandalf> tbsaunde: "error: ‘const class nsACString_internal’ has no member named ‘get’"
- # [17:22] <gandalf> it may be that my var is "const nsACString& aURL"
- # [17:22] * joduinn-zzz is now known as joduinn-coffee
- # [17:22] <gandalf> but aURL.get(); throws an error
- # [17:23] <biesi> nsACString doesn
- # [17:23] <biesi> 't have get
- # [17:23] <biesi> because it may not be nullterminated
- # [17:23] <biesi> use PromiseFlatCSTring(foo).get()
- # [17:23] <biesi> ST -> St
- # [17:23] <philor> when I finally find the bug where we stopped all that profile creation madness on non-try, I sure hope there isn't going to be a comment from me saying something about how it doesn't really matter, so it doesn't matter whether we stop it on try too
- # [17:24] * bear-afk is now known as bear-buildduty
- # [17:24] <gandalf> biesi: thanks
- # [17:24] <tbsaunde> biesi: ok, not sure what I was remembering seeing then :(
- # [17:25] * Joins: cjones (cjones@moz-46923FE5.tmodns.net)
- # [17:26] <NeilAway> tbsaunde: if it was anything other than PromiseFlatCString then it was wrong ;-)
- # [17:26] <biesi> tbsaunde, so there's two versions of nsACString :/
- # [17:27] <biesi> the other one may have .get()
- # [17:27] * NeilAway hopes not
- # [17:27] * Joins: prip (prip@moz-C330E3B5.k559.webspeed.dk)
- # [17:28] <mounir> edmorley: any news regarding the auto m-i->m-c tool?
- # [17:29] <tbsaunde> philor: is there a reason the log doesn't give me a stack?
- # [17:29] * Quits: gandalf (zbraniecki@moz-8DB99104.neoplus.adsl.tpnet.pl) (Quit: Computer has gone to sleep.)
- # [17:29] * Quits: glazou (glazou@moz-204094DD.disruptive-innovations.fr) (Quit: bbl)
- # [17:29] <Ms2ger> mounir, up there with philorbot
- # [17:30] <edmorley> mounir: I'd put it on hold pending robcee's WIP jetpack extension that was supposed to do something similar, that he had already started
- # [17:30] <edmorley> however, not sure if that's happening, so might just do it anyway :-)
- # [17:30] <tbsaunde> NeilAway: NS_ConvertUTF16toUTF8 maybe?
- # [17:31] * Joins: kdcw (kdc@moz-F7413045.pk.shawcable.net)
- # [17:31] <edmorley> mounir: something to distract from family arguments over Christmas perhaps :-)
- # [17:31] * Quits: pnemsak (Miranda@moz-3D67D819.rainside.sk) (Quit: pnemsak)
- # [17:32] <mounir> edmorley: if you need something for that, I can find you some bugs :)
- # [17:32] * IRCMonkey57045 is now known as Tobbi
- # [17:32] <edmorley> heh :-)
- # [17:32] <Ms2ger> edmorley, ignore mounir
- # [17:32] <Ms2ger> I've got more fun bugs :)
- # [17:33] <qheaden_away> So any patch I submit "after" today will be in FF 12?
- # [17:33] <mounir> edmorley: HTML5 Forms bugs, how can something big more fun? :)
- # [17:33] <qheaden_away> Until the next uplift anyway
- # [17:33] <edmorley> qheaden_away: yup, unless it is granted aurora approval (rare)
- # [17:33] <Ms2ger> qheaden_away, 33 minutes :)
- # [17:33] <edmorley> well, s/rare/needs to really be worth it/
- # [17:33] * qheaden_away is now known as qheaden
- # [17:34] <qheaden> Oh well. I should have sped up my work. College finals the week before last slowed me. :P
- # [17:34] <philor> tbsaunde: no idea who would give you a stack, since I don't even know what's happening - leaktest.py starts up an http server, runs the browser, according to the log the browser closed, according to the exit code leaktest.py closed and closed happy, but when it tries to run again, it's still running from before
- # [17:34] <Ms2ger> More like, well-done
- # [17:35] <bear-buildduty> bbondy - ping?
- # [17:35] <NeilAway> tbsaunde: ah, that would be for ns(A)String, not nsACString
- # [17:35] <bbondy> bear-buildduty: hi
- # [17:35] <tbsaunde> philor: yeah, I gues
- # [17:36] <bear-buildduty> bbondy - hello - talos-r3-xp-009 is out of the pool and all yours. do you need buildvpn access enabled?
- # [17:36] * Quits: logbot (logbot@moz-785868D2.glob.com.au) (Ping timeout)
- # [17:36] <tbsaunde> maybe just attaching gdb to whatever is running and making dump a stack would be a useful thing to do, or maybe this is too one of of a case
- # [17:36] * Joins: logbot (logbot@moz-785868D2.glob.com.au)
- # [17:36] <bbondy> bear-buildduty: great thank you, yes I'm remote. I haven't setup vpn I'll try so now.
- # [17:37] <bear-buildduty> k, let me know when you are done with it
- # [17:37] <bbondy> k thx
- # [17:37] <tbsaunde> philor: thanks, and sorry about the trouble, I'll get back to this later when more rested
- # [17:38] <philor> tbsaunde: no trouble, sorry you got bounced, but there's always six weeks from now :)
- # [17:39] <tbsaunde> its ok
- # [17:40] * armenzg is now known as armenzg_subway
- # [17:41] * Joins: mwu (mwu@moz-59435430.hsd1.nj.comcast.net)
- # [17:42] <firebot> Check-in: http://hg.mozilla.org/mozilla-central/rev/c7101dec8deb - Matt Brubeck - Bug 709921 - (2/2) Rename "Preferences" to "Settings" for Android fennec [r=cpeterson]
- # [17:42] <firebot> http://hg.mozilla.org/mozilla-central/rev/05720c79f740 - Matt Brubeck - Bug 709921 - (1/2) Clean up unused localization files [r=mfinkle]
- # [17:42] * Quits: Ms2ger (Ms2ger@moz-518E357F.access.telenet.be) (Quit: nn)
- # [17:42] * Quits: prip (prip@moz-C330E3B5.k559.webspeed.dk) (Client exited)
- # [17:43] * Joins: damons (gnubeard@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net)
- # [17:43] * Quits: armenzg_subway (armenzg@D0E54E4D.5BCEC6DB.DA78B690.IP) (Input/output error)
- # [17:45] * Quits: biesi (cbiesinger@2E747C8D.C1499D0.396E4C6D.IP) (Ping timeout)
- # [17:48] <qheaden> Where is a good place to test the XUL textbox spellchecking for Firefox?
- # [17:48] <qheaden> I use regular web pages to test the spellchecking for the browser textbox/textarea, but not sure where to go for testing it with the browser chrome.
- # [17:52] * rshetty is now known as rshetty|busy
- # [17:53] * Quits: Ami_Ty (Amie@moz-7D22EB0A.dsl.static.sonic.net) (Quit: Ami_Ty)
- # [17:53] * Joins: nhirata (nhirata.bu@moz-BBE3ABD.mv.mozilla.com)
- # [17:55] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [17:55] * Joins: smontagu (chatzilla@54292542.DC2479E.E9C721AF.IP)
- # [17:56] * Quits: protz (protz@moz-E29D2A15.inria.fr) (Quit: Leaving)
- # [17:57] * Quits: kaze (kaze@moz-A2A3C9E6.vlan402.asr1.cdg3.gblx.net) (Ping timeout)
- # [17:58] * Quits: peregrino (peregrino@moz-D0CB2FAA.telecom.net.ar) (Ping timeout)
- # [17:58] * mkelly is now known as mkelly|wfh
- # [18:00] * Joins: myk (myk@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net)
- # [18:00] <NeilAway> qheaden: there isn't any
- # [18:00] * Joins: Fallen|mac1 (kewisch@moz-17E072E0.customers.d1-online.com)
- # [18:00] * Joins: peregrino (peregrino@moz-D0CB2FAA.telecom.net.ar)
- # [18:00] * Quits: Fallen|mac (kewisch@moz-17E072E0.customers.d1-online.com) (Connection reset by peer)
- # [18:00] * Quits: Fallen|mac1 (kewisch@moz-17E072E0.customers.d1-online.com) (Connection reset by peer)
- # [18:01] <qheaden> NeilAway: Wow really? So how do I test my spellchecking code for XUL textboxes?
- # [18:01] <qheaden> My code words for html textboxes
- # [18:01] <NeilAway> qheaden: mxr only shows one hit, in Thuderbird compose subject field
- # [18:01] <qheaden> *works
- # [18:01] * lsblakk|afk is now known as lsblakk
- # [18:02] <NeilAway> *Thunderbird
- # [18:02] <qheaden> Ahh ok.
- # [18:02] <qheaden> I'll just put the code in there and let the reviewer(s) test it.
- # [18:02] <qheaden> Not in the mood to compile Thunderbird right now.
- # [18:03] <qheaden> ehsan: Ping
- # [18:03] * Quits: wesj (wesj@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net) (Quit: Instantbird 1.2a1pre)
- # [18:03] * Joins: wesj (wesj@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net)
- # [18:04] * Quits: joey (chatzilla@moz-EFCB4CBF.princetowncable.com) (Input/output error)
- # [18:05] * Joins: mjschranz_ (mjschranz@moz-6FE6B833.cpe.net.cable.rogers.com)
- # [18:05] * Joins: joey (chatzilla@moz-EFCB4CBF.princetowncable.com)
- # [18:05] <Standard8> qheaden: could you not write a browser-chrome mochitest?
- # [18:06] * Joins: prip (prip@moz-C330E3B5.k559.webspeed.dk)
- # [18:06] <qheaden> Standard8: Yeah, looks like I have to.
- # [18:06] * Joins: TheLink (TheLink@moz-753C1E34.pools.arcor-ip.net)
- # [18:07] <NeilAway> Standard8: well, a regular chrome mochitest should suffice, no?
- # [18:07] <Standard8> NeilAway: true
- # [18:07] <Standard8> qheaden: ^^^
- # [18:08] <qheaden> NeilAway: Thx
- # [18:08] <LegNeato> inbound merge 5 minutes before a source migration? Ballsy ha
- # [18:08] <qheaden> Its strange that FF doesn't use spellchecking on at least some of its textboxes
- # [18:09] * mjschranz_ is now known as mjschranz
- # [18:09] * joduinn-coffee is now known as joduinn-biab
- # [18:09] * Quits: grubshka (grubshka@moz-5519B649.w86-216.abo.wanadoo.fr) (Connection reset by peer)
- # [18:09] * Joins: kaze (kaze@moz-A2A3C9E6.vlan402.asr1.cdg3.gblx.net)
- # [18:10] * qheaden is now known as qheaden_away
- # [18:10] * Quits: cjones (cjones@moz-46923FE5.tmodns.net) (Ping timeout)
- # [18:10] * Joins: graydot (jeba@B6001B9.4E8FB30C.700C6EB0.IP)
- # [18:10] * Quits: graydot (jeba@B6001B9.4E8FB30C.700C6EB0.IP) (Quit: graydot)
- # [18:11] * Joins: Sander (chatzilla@moz-B871F4D3.direct-adsl.nl)
- # [18:11] * Quits: Suresh (chatzilla@CE80C3FC.5C86A38E.EB06F97B.IP) (Client exited)
- # [18:12] * Joins: anant (Anant@moz-271479F2.hsd1.ca.comcast.net)
- # [18:12] * Joins: smaug (chatzilla@moz-DAAE7598.elisa-mobile.fi)
- # [18:13] * Joins: fzzzy (donovan@moz-2B41AF9B.lightspeed.mtvwca.sbcglobal.net)
- # [18:13] * Joins: bnicholson (bnicholson@moz-CA78B821.rcmdva.fios.verizon.net)
- # [18:14] * Quits: Enn (enn@F2D29657.F60B0462.67AC9B1.IP) (Ping timeout)
- # [18:14] * Quits: hhillen (hhillen@moz-81563C98.ip.telfort.nl) (Connection reset by peer)
- # [18:14] <jprmc> taras: we only started collect GC_MS in FF10 correct?
- # [18:14] <NeilAway> qheaden: btw, bug#?
- # [18:15] <edmorley> LegNeato: this morning inbound's been more green than m-c :-)
- # [18:15] <LegNeato> :-)
- # [18:15] * Joins: hhillen (hhillen@moz-81563C98.ip.telfort.nl)
- # [18:17] * Quits: hhillen (hhillen@moz-81563C98.ip.telfort.nl) (Connection reset by peer)
- # [18:18] * Joins: hhillen (hhillen@moz-81563C98.ip.telfort.nl)
- # [18:19] * Quits: hhillen (hhillen@moz-81563C98.ip.telfort.nl) (Quit: hhillen)
- # [18:20] * joduinn-biab is now known as joduinn-home
- # [18:22] * Joins: armenzg_subway (armenzg@F2D29657.F60B0462.67AC9B1.IP)
- # [18:23] * qheaden_away is now known as qheaden
- # [18:24] <qheaden> NeilAway: I am working on bug# 352037
- # [18:24] * Joins: smooney (smooney@moz-BBE3ABD.mv.mozilla.com)
- # [18:24] * Joins: bjacob (bjacob@F2D29657.F60B0462.67AC9B1.IP)
- # [18:27] <NeilAway> qheaden: ah, right
- # [18:28] * NeilAway wonders whether we've ever had UI for the personal dictionary
- # [18:28] <NeilAway> oh yes, it's in the check spelling dialog (TB/SM)
- # [18:29] * Joins: armenzg__ (armenzg@F2D29657.F60B0462.67AC9B1.IP)
- # [18:29] * Quits: armenzg_subway (armenzg@F2D29657.F60B0462.67AC9B1.IP) (Ping timeout)
- # [18:30] * Joins: andreasn_ (andreasn@moz-BB6A8755.bredband.comhem.se)
- # [18:30] <qheaden> NeilAway: Hmm. That should be ported to FF.
- # [18:30] * Quits: dao (dao@moz-283B6C57.pool.mediaways.net) (Ping timeout)
- # [18:30] <sid0> how can I get a XUL element's ID while in a debugger?
- # [18:30] <qheaden> Editing your personal dictionary is very useful.
- # [18:30] * Quits: daim (David_Mart@779E3E00.1773D26C.C0FF2207.IP) (Client exited)
- # [18:30] <sid0> (MSVC)
- # [18:31] <LegNeato> the bug # hook is annoying!
- # [18:32] <firebot> Check-in: http://hg.mozilla.org/mozilla-central/rev/00dc96a6c12b - Christian Legnitto - Added tag AURORA_BASE_20111220 for changeset a8506ab2c654
- # [18:32] <firebot> http://hg.mozilla.org/mozilla-central/rev/f890732ebaa3 - Christian Legnitto - Bug 700000 - Version bump
- # [18:33] <Callek> oooo the bug # hook is live now?
- # [18:33] * Quits: past (past@moz-7A93B333.dsl.dyn.forthnet.gr) (Input/output error)
- # [18:33] <Callek> LegNeato: "No Bug"
- # [18:33] <edmorley> LegNeato: (no bug) or "IGNORE BAD COMMIT MESSAGES" :-)
- # [18:33] * Quits: kaze (kaze@moz-A2A3C9E6.vlan402.asr1.cdg3.gblx.net) (Ping timeout)
- # [18:34] <edmorley> (beaten to it anyway)
- # [18:34] <lurking> o_O version bump to Beer ?
- # [18:34] <qheaden> Is there any easier way to sync Mq patches between computers without manually copying them over?
- # [18:34] * Quits: sfink (chatzilla@moz-4EAF93BB.dsl.pltn13.sbcglobal.net) (Client exited)
- # [18:34] <Callek> qheaden: mount a network path to your .hg/patches ?
- # [18:35] <LegNeato> it'd be mighty helpful if the hook told you No bug was ok :-)
- # [18:35] * LegNeato goes to patch it
- # [18:35] <Callek> LegNeato: well its not ok in 90% of the time
- # [18:35] <qheaden> Callek: I know that, but I was just wondering if mercurial had some sort of sync command built into it. Guess not.
- # [18:35] <Callek> but for cases liek that is good :-)
- # [18:36] <edmorley> qheaden: you can version control your patch queue using qcommit and push the patch repo to a user repo (https://developer.mozilla.org/en/Creating_Mercurial_User_Repositories)
- # [18:36] <LegNeato> Callek: Yeah, I just need to add it to my checklist :-)
- # [18:36] * jlebar is now known as jlebar|away
- # [18:36] <qheaden> edmorley: Hmm ok. Thanks for that.
- # [18:36] * Quits: magsout (magsout@moz-E559D13.fbx.proxad.net) (Ping timeout)
- # [18:37] <edmorley> qheaden: end of that page gives an example, if that helps
- # [18:37] <qheaden> edmorley: I see now. I was using qnew and qrefresh, but I never commited anything.
- # [18:37] <qheaden> edmorley: With qcommit that is.
- # [18:38] <edmorley> it also means you have backups of your patch queue in case something goes wrong
- # [18:40] * glob is now known as mkanat_
- # [18:40] <tbsaunde> wonderful my shutdown hang issue doesn't seem to show up locally :(
- # [18:40] * mkanat_ is now known as glob
- # [18:40] <mounir> do we have a specific mozconfig for pgo?
- # [18:40] <tbsaunde> philor: I expect your there's a bug for cleaning up the silliness on try?
- # [18:41] * Joins: ohsix (ohsix@moz-E0C24F4A.bendbroadband.com)
- # [18:41] * jmaher|afk is now known as jmaher
- # [18:42] * Joins: Mossop (mossop@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net)
- # [18:42] <philor> tbsaunde: there will be, probably tonight after I get home from work
- # [18:42] * Parts: ejpbruel (ejpbruel@moz-5EE20326.adsl2.static.versatel.nl)
- # [18:42] <tbsaunde> philor: sounds go cc me?
- # [18:42] <tbsaunde> *good
- # [18:42] * Quits: bjacob (bjacob@F2D29657.F60B0462.67AC9B1.IP) (Ping timeout)
- # [18:42] <philor> will do
- # [18:43] <firebot> Check-in: http://hg.mozilla.org/mozilla-central/rev/a0d32d0353e1 - Aki Sasaki - bug 611648 - fix sutAgentAndroid.apk JARSIGNER
- # [18:44] <edmorley> mounir: add |mk_add_options MOZ_PGO=1| to the nightly mozconfigs when pushing to try
- # [18:44] <mounir> edmorley: that I know
- # [18:44] <philor> tbsaunde: might be easier to repro by getting access to a buildslave and running it yourself there, I don't know since they refuse to ever give me access ;)
- # [18:44] <edmorley> mounir: oh sorry, misunderstood :-)
- # [18:45] <mounir> edmorley: I wonder if when we build a PGO on m-c/m-i we ore using another mozconfig
- # [18:45] * Joins: jet (junglecode@moz-79F891EE.hsd1.ca.comcast.net)
- # [18:45] <mounir> I want to put some build config in that mozconfig if that's the case
- # [18:46] * Quits: imphil (philipp@moz-55513EF0.rad.med.uni-muenchen.de) (Ping timeout)
- # [18:48] <taras> jprmc: looks like it, why do you ask?
- # [18:48] <qheaden> Is something wrong with the Mozilla website? I can't seem to access pages on the Mozilla developers guide.
- # [18:49] * Quits: bent (chatzilla@moz-32655341.midsouth.biz.rr.com) (Quit: ChatZilla 0.9.87-rdmsoft [XULRunner 1.9.2.19/20110707195905])
- # [18:49] * Joins: juanb (jbecerra@moz-BBE3ABD.mv.mozilla.com)
- # [18:49] <gps> were you annoyed because you couldn't merge to m-c because it was orange yesterday? file a claim at bug 712218
- # [18:49] * Joins: gkw (gkw@moz-A7D8CA2A.hsd1.ca.comcast.net)
- # [18:49] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [18:49] <rnewman> heh
- # [18:50] <rnewman> anyone have a best-practice for landing dependencies as source in m-c from an SVN repo?
- # [18:50] <rnewman> I'm presuming that a checkout in a subdir is a no-no
- # [18:50] <tbsaunde> philor: yeah, at this rate I might have to didn't think about that
- # [18:51] <NeilAway> sid0: I can get you its tag name, but I don't know an easy way to get its id :-(
- # [18:51] <jprmc> taras: we dug, its not in 9 based on changelog
- # [18:51] * Joins: cpeterson (cpeterson@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net)
- # [18:51] * gregglind_afk_until_10_pst is now known as gregglind
- # [18:51] * Quits: ochameau (ochameau@moz-A33C217B.fbx.proxad.net) (Ping timeout)
- # [18:51] * Quits: Boriss (FlyingToas@moz-62AAA429.hsd1.ca.comcast.net) (Quit: Boriss)
- # [18:51] * Joins: kaze (kaze@moz-A2A3C9E6.vlan402.asr1.cdg3.gblx.net)
- # [18:51] <NeilAway> qheaden: create an hg repo for your mq?
- # [18:52] <sid0> NeilAway: yeah I got hold of the tag name too
- # [18:52] <jprmc> taras: the data would actually be a big help on confirming whether a problem exists in 10 but not 9
- # [18:52] * Joins: mayhemer_ (nobody@B3D46202.F87A741B.F23860FD.IP)
- # [18:52] * Joins: bjacob (bjacob@F2D29657.F60B0462.67AC9B1.IP)
- # [18:52] <taras> jprmc: telemetry ui is usually the way to check that
- # [18:52] <sid0> NeilAway: never mind, figured it out using siblings and children
- # [18:52] <NeilAway> qheaden: oh, sorry, edmorley already mentioned that
- # [18:52] <jprmc> taras: time to get serious about telemetry as part of release criteria, lmandel is going to discuss that with you :-)
- # [18:53] * Joins: jhammel (jhammel@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net)
- # [18:53] * Joins: ochameau (ochameau@moz-A33C217B.fbx.proxad.net)
- # [18:53] <taras> jprmc: sure, it's good enough now
- # [18:53] * philor is now known as philor|away
- # [18:53] <edmorley> mounir: from what I can tell, MOZ_PGO=1 just gets appended, there isn't another mozconfig (https://bugzilla.mozilla.org/attachment.cgi?id=564425&action=diff#a/process/factory.py_sec2)
- # [18:53] * Joins: Mook_as (mook@moz-1FCC0032.activestate.com)
- # [18:53] * Parts: mayhemer_ (nobody@B3D46202.F87A741B.F23860FD.IP)
- # [18:54] * Joins: Jesse (jruderman@moz-447E6DA0.oc.oc.cox.net)
- # [18:54] <edmorley> (obviously relying on the fact that mk_add_options PROFILE_GEN_SCRIPT=... was left in the in-tree mozconfigs)
- # [18:55] * Joins: priya (priya@moz-BBE3ABD.mv.mozilla.com)
- # [18:55] * Joins: mayhemer_ (nobody@B3D46202.F87A741B.F23860FD.IP)
- # [18:56] <mounir> edmorley: that's what I was fearing
- # [18:56] * Joins: jhorak (jhorak@moz-59813FB4.cust.nbox.cz)
- # [18:57] <ted> when you see "updates disabled by administrator", where does that setting come from?
- # [18:57] * Quits: kanru (user@79E6271C.120775F3.B7D4332.IP) (Ping timeout)
- # [18:57] <ted> mounir: what do you want to do differently in a PGO build?
- # [18:58] * Quits: mayhemer_ (nobody@B3D46202.F87A741B.F23860FD.IP) (Ping timeout)
- # [18:59] * Quits: pranavrc (pranavrc@B7401A63.54549A93.520CDC98.IP) (Client exited)
- # [19:00] * Joins: mccr8 (mccr8@moz-BBE3ABD.mv.mozilla.com)
- # [19:01] <qheaden> Hmm. The "Automated Testing" page on the developers guide seems to be inaccessable.
- # [19:02] * Joins: Ami_Ty (Amie@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net)
- # [19:02] * Joins: mayhemer_ (mayhemer@B3D46202.F87A741B.F23860FD.IP)
- # [19:02] * Joins: stevee (Miranda@moz-BEBDF855.cable.virginmedia.com)
- # [19:02] <mounir> ted: I'm working on WARNINGS_AS_FAILURES and currently there is a hack that disable this on PGO for Windows but I think that would be nicer to have this in the mozconfig
- # [19:03] <mounir> ted: so anybody could try to enable it locally (at there own risks)
- # [19:03] * Quits: ewong|sleep (chatzilla@F536648C.E5F17347.51F738FB.IP) (Ping timeout)
- # [19:03] * Quits: Jesse (jruderman@moz-447E6DA0.oc.oc.cox.net) (Quit: Jesse)
- # [19:03] <ted> hm
- # [19:03] <mounir> I wonder if doing |if test "$MOZ_PGO"; then| would work (I guess not)
- # [19:04] <ted> in the mozconfig?
- # [19:04] <ted> no
- # [19:04] * Joins: ewong|sleep (chatzilla@F536648C.E5F17347.51F738FB.IP)
- # [19:04] <ted> mostly because MOZ_PGO is a client.mk var
- # [19:04] * Joins: bmoss|2 (bmoss@moz-BBE3ABD.mv.mozilla.com)
- # [19:04] * Quits: bmoss (bmoss@moz-BBE3ABD.mv.mozilla.com) (Ping timeout)
- # [19:05] <jesup> So is aurora uplift done? "firebot: Channels Blog: Source Migration Notice: FINISHED mozilla-central → mozilla-aurora" in #firefox
- # [19:05] * Quits: By-Tor (bytor@moz-46974D0B.dyn.optonline.net) (Quit: Leaving)
- # [19:05] * Quits: mayhemer (Miranda@B3D46202.F87A741B.F23860FD.IP) (Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org)
- # [19:05] * mayhemer_ is now known as mayhemer
- # [19:05] * Joins: northWind (northWind@2F50C7BC.10A7D831.6816E6B7.IP)
- # [19:06] * Joins: yuan (ywang@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net)
- # [19:06] <mounir> ted: I guess I will survive with the current hack
- # [19:06] * Quits: zandr (zandr@moz-891BD824.milewski.org) (Max SendQ exceeded)
- # [19:06] * Joins: Neil (neil@moz-4AB77362.cable.virginmedia.com)
- # [19:07] * Quits: NeilAway (neil@moz-32AA0D01.in-addr.btopenworld.com) (Ping timeout)
- # [19:07] * Neil is now known as NeilAway
- # [19:07] * Joins: sicking (chatzilla@moz-FB52AFB7.dsl.pltn13.sbcglobal.net)
- # [19:07] * Joins: Neil (neil@moz-32AA0D01.in-addr.btopenworld.com)
- # [19:08] * Joins: zandr (zandr@moz-891BD824.milewski.org)
- # [19:08] * Joins: By-Tor (bytor@moz-46974D0B.dyn.optonline.net)
- # [19:08] * Joins: timA (tabraldes@moz-535753DA.hsd1.or.comcast.net)
- # [19:08] * armenzg__ is now known as armenzg
- # [19:08] * Quits: gabor (gabor@moz-3B57BCD1.catv.pool.telekom.hu) (Connection reset by peer)
- # [19:08] * Quits: NeilAway (neil@moz-4AB77362.cable.virginmedia.com) (Ping timeout)
- # [19:08] * jimm is now known as jimm-lunch
- # [19:08] * Neil is now known as NeilAway
- # [19:09] * Joins: bent (chatzilla@moz-DB4C5E15.triad.res.rr.com)
- # [19:09] * Quits: jhammel (jhammel@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net) (Ping timeout)
- # [19:09] * Quits: kaze (kaze@moz-A2A3C9E6.vlan402.asr1.cdg3.gblx.net) (Ping timeout)
- # [19:10] * khuey|away is now known as khuey
- # [19:10] * Quits: akeybl (akeybl@moz-52D39FF6.hsd1.ca.comcast.net) (Quit: Linkinus - http://linkinus.com)
- # [19:10] * AaronMT is now known as AaronMT|mtg
- # [19:10] * Joins: bsmith (bsmith@moz-364A0C3E.hsd1.ca.comcast.net)
- # [19:11] * joduinn-home is now known as joduinn-commute
- # [19:13] * jwir3|away is now known as jwir3
- # [19:13] * Quits: mayhemer (mayhemer@B3D46202.F87A741B.F23860FD.IP) (Quit: mayhemer)
- # [19:13] * Quits: jrmuizel (jrmuizel@F2D29657.F60B0462.67AC9B1.IP) (Input/output error)
- # [19:13] <qheaden> In a chrome mochitest, is the document the browser window?
- # [19:14] * Joins: jrmuizel (jrmuizel@F2D29657.F60B0462.67AC9B1.IP)
- # [19:14] * Quits: jhorak (jhorak@moz-59813FB4.cust.nbox.cz) (Ping timeout)
- # [19:15] * Quits: bjacob (bjacob@F2D29657.F60B0462.67AC9B1.IP) (Quit: Konversation terminated!)
- # [19:15] * Joins: bjacob (bjacob@F2D29657.F60B0462.67AC9B1.IP)
- # [19:15] * whimboo is now known as whimboo|afk
- # [19:16] * Joins: sheppy (sheppy@moz-F39D62DA.dhcp.kgpt.tn.charter.com)
- # [19:16] * Joins: bholley (bholley@moz-24EDB000.hsd1.ca.comcast.net)
- # [19:17] * philor|away is now known as philor
- # [19:17] * Quits: bjacob (bjacob@F2D29657.F60B0462.67AC9B1.IP) (Quit: Konversation terminated!)
- # [19:17] * Joins: terrence (terrence@moz-BBE3ABD.mv.mozilla.com)
- # [19:17] * Joins: bjacob (bjacob@F2D29657.F60B0462.67AC9B1.IP)
- # [19:17] * Quits: rniwa (rniwa@moz-E171DA5.sfba.hfc.comcastbusiness.net) (Quit: rniwa)
- # [19:17] * Joins: kaze (kaze@moz-A2A3C9E6.vlan402.asr1.cdg3.gblx.net)
- # [19:17] <taras> gcp: ping
- # [19:18] * Joins: sfink (chatzilla@moz-BBE3ABD.mv.mozilla.com)
- # [19:18] <gcp> pong
- # [19:19] * Quits: kaze (kaze@moz-A2A3C9E6.vlan402.asr1.cdg3.gblx.net) (Ping timeout)
- # [19:19] <khuey> http://jasonlefkowitz.net/2011/12/good-news-mozilla-fixed-their-damn-browser/
- # [19:20] * zpao|detached is now known as zpao
- # [19:20] * Joins: sworkman (sworkman@moz-BBE3ABD.mv.mozilla.com)
- # [19:23] * Joins: tanvi (tanvi@moz-BBE3ABD.mv.mozilla.com)
- # [19:23] * Joins: jhorak (jhorak@moz-59813FB4.cust.nbox.cz)
- # [19:24] * Joins: redfive (chatzilla@moz-B94E1A81.ipnetworksinc.net)
- # [19:24] <gcp> taras: pong
- # [19:24] <taras> gcp: how's url classifier.sqlite nuking coming?
- # [19:25] <gcp> its blocking on an issue with nsISafeOutputStream causing test failures on Windows
- # [19:25] <gcp> the code itself is ready to land
- # [19:25] <taras> from our sql reports, it's a pig
- # [19:26] <taras> so please hurry :)
- # [19:26] * Quits: gkw (gkw@moz-A7D8CA2A.hsd1.ca.comcast.net) (Quit: Instantbird 1.1)
- # [19:26] <gcp> the new code is causing an OOM topcrasher
- # [19:26] <gcp> you know, the code that reduced memory usage 40-fold
- # [19:26] * Quits: KLB (Kenneth_Ba@moz-CB90BBF2.maine.res.rr.com) (Quit: ChatZilla 0.9.87 [Firefox 8.0/20111104165243])
- # [19:27] <gcp> I'm *so* enjoying this.
- # [19:27] * Joins: Boriss (FlyingToas@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net)
- # [19:27] <taras> :)
- # [19:27] * adam-afk is now known as adam
- # [19:28] * Quits: sicking (chatzilla@moz-FB52AFB7.dsl.pltn13.sbcglobal.net) (Ping timeout)
- # [19:29] * Joins: Waldo (waldo@moz-104CC309.mv.mozilla.com)
- # [19:29] * Quits: micahg (micahg@moz-C7CC8D27.c3-0.arm-ubr1.chi-arm.il.cable.rcn.com) (Ping timeout)
- # [19:29] <khuey> keeping gcp and gps straight is hard
- # [19:29] * Joins: sicking (chatzilla@moz-22D12CFF.dsl.pltn13.sbcglobal.net)
- # [19:29] <edmorley> +1
- # [19:30] <mwu> we have a wwu in #b2g
- # [19:30] <mwu> gets confusing when we both speak
- # [19:30] <qheaden> I'm a bit confused on how to open and check the context menu of a textbox in a chrome mochitest.
- # [19:30] <gcp> xchat has auto-nick coloring
- # [19:30] <mwu> yeah xchat saves me
- # [19:30] <gcp> easily avoids those kind of issues
- # [19:31] * coop is now known as coop|lunch
- # [19:31] <bent> taras, i wonder if classifier gets really fragmented
- # [19:31] * Quits: Mardak (Mardak@moz-4FA48382.hsd1.ca.comcast.net) (Quit: Mardak)
- # [19:31] <bent> it can get quite large, right?
- # [19:32] * Joins: KLB (Kenneth_Ba@moz-CB90BBF2.maine.res.rr.com)
- # [19:32] <bent> and it gets updated like all the time
- # [19:32] * qheaden is now known as qheaden_away
- # [19:33] * davehunt is now known as davehunt|away
- # [19:33] <taras> bent: it doesn't really
- # [19:33] <taras> we papered over it
- # [19:34] <taras> it's just a big db and sqlite is slow
- # [19:34] <gcp> updates still go all over
- # [19:34] * Joins: karl (karl@A5E853A7.333C855E.C8A09C26.IP)
- # [19:34] <bent> "doesn't really"... get fragmented? update all the time?
- # [19:35] <gcp> it gets an update every 30 mins that might delete and add stuff almost randomly
- # [19:35] * bear-buildduty is now known as bear-buildduty-afk
- # [19:35] <ehsan> qheaden_away: pong
- # [19:36] <jesup> someone in #firefox just had a 29MB urlclassifier (also 70K bookmarks...)
- # [19:36] <gcp> 40M urlclassifier is normal
- # [19:37] <bent> gcp, does it do all its IO on another thread?
- # [19:37] <jesup> sorry, 29MB in about:memory
- # [19:37] <gcp> yes
- # [19:37] <bent> ok
- # [19:37] * Joins: jamesr (jamesr@429717EF.C60FE7DC.4065847B.IP)
- # [19:37] <bent> well, that's better than it could be :)
- # [19:37] <jesup> god knows the size on disk
- # [19:37] <gcp> heh actually
- # [19:37] <gcp> jesup: what version?
- # [19:38] <jesup> ask stevedtrm in #firefox
- # [19:38] <gcp> jesup: since 8.0, urlclassifier should use at most 1M unless it's updating (i.e. maybe 30s every half hour)
- # [19:38] * jesup lunches
- # [19:38] * Quits: jet (junglecode@moz-79F891EE.hsd1.ca.comcast.net) (Quit: jet)
- # [19:39] * Quits: MarcoZ (marco.zehe@moz-65E5AE7F.dip.t-dialin.net) (Quit: l8er)
- # [19:40] <lurking> hmm, latest mc hourly build win32 on win7 x64: ───161,864 B (00.10%) -- urlclassifier3.sqlite
- # [19:40] * Quits: florian (florian@moz-87C33FDA.kimsufi.com) (Quit: Instantbird 1.2a1pre)
- # [19:40] <gcp> 8.0 cuts down the cache to max 1M unless its in an update
- # [19:40] * Joins: dao (dao@moz-F3A7319.superkabel.de)
- # [19:42] * Quits: Goldorak (chatzilla@9CD43D39.E6A99E96.187A1082.IP) (Quit: ChatZilla 0.9.87 [Firefox 9.0/20111216140209])
- # [19:42] <lurking> file size on disk is 40mb -
- # [19:42] * glob is now known as glob|away
- # [19:43] * Joins: pcwalton (pcwalton@moz-7B0110AD.mv.mozilla.com)
- # [19:43] * Quits: smontagu (chatzilla@54292542.DC2479E.E9C721AF.IP) (Ping timeout)
- # [19:43] * Quits: zandr (zandr@moz-891BD824.milewski.org) (Max SendQ exceeded)
- # [19:43] * Joins: zandr (zandr@moz-891BD824.milewski.org)
- # [19:44] * Quits: jhorak (jhorak@moz-59813FB4.cust.nbox.cz) (Ping timeout)
- # [19:45] * Joins: micahg (micahg@moz-C7CC8D27.c3-0.arm-ubr1.chi-arm.il.cable.rcn.com)
- # [19:46] * Joins: jhorak (jhorak@moz-59813FB4.cust.nbox.cz)
- # [19:47] * Quits: ohsix (ohsix@moz-E0C24F4A.bendbroadband.com) (Ping timeout)
- # [19:49] * Joins: kumar (kmcmillan@moz-E31CD2CB.mozilla.org)
- # [19:49] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Ping timeout)
- # [19:49] * Quits: arno (arno@moz-DFB73ABF.fbx.proxad.net) (Ping timeout)
- # [19:49] * Joins: rniwa (rniwa@5CA6DC39.C60FE7DC.4065847B.IP)
- # [19:50] * Joins: jhammink (textual@moz-BBE3ABD.mv.mozilla.com)
- # [19:50] * Quits: redfive (chatzilla@moz-B94E1A81.ipnetworksinc.net) (Ping timeout)
- # [19:50] * Joins: squib (squib-@moz-3F6F2A9C.ep.wisc.edu)
- # [19:51] * Quits: bholley (bholley@moz-24EDB000.hsd1.ca.comcast.net) (Client exited)
- # [19:51] * Joins: smontagu (chatzilla@moz-D5E67D96.red.bezeqint.net)
- # [19:51] * Joins: bholley (bholley@moz-1A79C381.tmodns.net)
- # [19:52] * Quits: bholley (bholley@moz-1A79C381.tmodns.net) (Quit: bholley)
- # [19:52] * Joins: gkw (gkw@moz-BBE3ABD.mv.mozilla.com)
- # [19:53] * Joins: WeirdAl (chatzilla@moz-D461843.ask.info)
- # [19:53] * Quits: vingtetun (vingtetun@moz-A2A3C9E6.vlan402.asr1.cdg3.gblx.net) (Ping timeout)
- # [19:54] * Joins: rniwa_ (rniwa@5CA6DC39.C60FE7DC.4065847B.IP)
- # [19:54] * Quits: Boriss (FlyingToas@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net) (Client exited)
- # [19:54] * Joins: Boriss (FlyingToas@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net)
- # [19:55] * Joins: marcoos (marcoos@moz-2F1E2CBA.cityconnect.pl)
- # [19:56] * Joins: pnemsak (Miranda@moz-7409BD53.orange.sk)
- # [19:56] <WeirdAl> !seen dherman
- # [19:57] <firebot> dherman was last seen 3 days, 18 hours, 47 minutes and 15 seconds ago, saying 'quiet guys, dad can hear you' in #jsapi.
- # [19:57] * Joins: mario (mario@67575F8A.5B6D81B9.490799F7.IP)
- # [19:57] <jorendorff> gulp
- # [19:57] * qheaden_away is now known as qheaden
- # [19:57] <qheaden> ehsan: Ping again
- # [19:57] <jorendorff> dad got dherman
- # [19:57] <ehsan> qheaden: hi! :)
- # [19:58] <qheaden> ehsan: Hey how's it going? I dropped you an email about the undo add to dictionary bug.
- # [19:58] <WeirdAl> jorendorff: hehe, I was just hoping for a progress report on JSReflect.serialize, and to see if there was a bug filed for Harmony's value proxies
- # [19:58] <qheaden> ehsan: I made another version of the patch.
- # [19:58] <WeirdAl> that's all
- # [19:58] <jwir3> jorendoff++
- # [19:58] <ehsan> qheaden: yep, I saw it but didn't look at your patch cause I was walking when reading my email :)
- # [19:58] <ehsan> qheaden: I'll take a look today
- # [19:58] <ehsan> qheaden: (thanks for not assuming that I read my bugmail :)
- # [19:58] <qheaden> ehsan: Oh no problem. I just wanted to make sure you received it. :)
- # [19:58] <ehsan> qheaden: is the new version the final one?
- # [19:59] * mcote is now known as mcote|lunch
- # [19:59] <qheaden> ehsan: No. I'm working on the final one now.
- # [19:59] * Joins: jgilbert_ (jgilbert@moz-BBE3ABD.mv.mozilla.com)
- # [19:59] * Joins: ohsix (ohsix@moz-E0C24F4A.bendbroadband.com)
- # [19:59] <qheaden> ehsan: I'm still trying to work on the XUL textbox element. I'm having trouble writing a test for it.
- # [19:59] <jorendorff> WeirdAl: the patch adds a new file, Reflect_stringify.js, to js/src
- # [20:00] <jorendorff> WeirdAl: you have to run the file
- # [20:00] * Joins: hub (hub@21B7B9F2.B87E9213.6E712CE2.IP)
- # [20:00] <ehsan> qheaden: can I help?
- # [20:00] <jorendorff> WeirdAl: or load the script or whatever it is you kids do these days
- # [20:00] <WeirdAl> huh, I thought he was planning a native impl
- # [20:00] <jorendorff> WeirdAl: why native though
- # [20:00] <qheaden> ehsan: Basically, I'm trying to write a test to check the context menu on a right click and make sure that the Undo Add to Dictionary button is there.
- # [20:00] * rshetty|busy is now known as rshetty
- # [20:00] <WeirdAl> that's how JSReflect.parse is impl'd, I think
- # [20:01] <jorendorff> WeirdAl: it is, but if you can do it in JS why wouldn't you
- # [20:01] <qheaden> ehsan: The same thing as the text_context mochitest, but for the browser element.
- # [20:01] <WeirdAl> good point
- # [20:01] <ehsan> right
- # [20:01] <jorendorff> WeirdAl: he wrote it in C++ because the parser is in C++ and he gets to reuse all that code
- # [20:01] <jorendorff> WeirdAl: but we don't have reusable code for stringify
- # [20:01] * Joins: cjones (cjones@moz-BBE3ABD.mv.mozilla.com)
- # [20:02] * Quits: smontagu (chatzilla@moz-D5E67D96.red.bezeqint.net) (Ping timeout)
- # [20:02] * Joins: lurking_work (chatzilla@moz-107FCDBA.hfc.comcastbusiness.net)
- # [20:02] * Joins: smontagu (chatzilla@moz-D5E67D96.red.bezeqint.net)
- # [20:03] <roc> edmorley: hi
- # [20:03] <qheaden> ehsan: How would you access the context menu of a XUL textbox in javascript?
- # [20:03] <ehsan> qheaden: so you know that xul:textbox context menus are not derived using the nsContextMenu class right?
- # [20:03] <edmorley> roc: Hi :-) my ping was just about bug 710992, but I've added a comment there now, if that's easier?
- # [20:04] <dao> hm, Alex Polvi just took over planet.mozilla.org
- # [20:04] <WeirdAl> jorendorff: how about the value proxies stuff? That's really interesting, but less useful to me at present
- # [20:04] <qheaden> ehsan: I kinda figured that because I had to redefine the element.
- # [20:04] * Quits: jhorak (jhorak@moz-59813FB4.cust.nbox.cz) (Ping timeout)
- # [20:05] <jorendorff> WeirdAl: no word on value proxies. i don't think they are proposed for ES6, and ES6 is in "no more proposals, seriously, please stop proposing things" mode
- # [20:05] * Joins: arno (arno@moz-DFB73ABF.fbx.proxad.net)
- # [20:05] <WeirdAl> hehehe
- # [20:05] * Quits: lurking_work (chatzilla@moz-107FCDBA.hfc.comcastbusiness.net) (Ping timeout)
- # [20:05] * Quits: nitot (nitot@moz-A2A3C9E6.vlan402.asr1.cdg3.gblx.net) (Ping timeout)
- # [20:05] * Quits: ohsix (ohsix@moz-E0C24F4A.bendbroadband.com) (Ping timeout)
- # [20:05] * Joins: cpearce (chatzilla@moz-55A2BC7D.xdsl.xnet.co.nz)
- # [20:06] * Joins: Jake (Jake@moz-CDAFE004.phlapafg.dynamic.covad.net)
- # [20:06] * Joins: lurking_work (chatzilla@moz-107FCDBA.hfc.comcastbusiness.net)
- # [20:06] * Joins: Jesse (jruderman@moz-447E6DA0.oc.oc.cox.net)
- # [20:06] * AaronMT|mtg is now known as AaronMT
- # [20:07] * Joins: jdgilbert (jgilbert@moz-BBE3ABD.mv.mozilla.com)
- # [20:07] * joduinn-commute is now known as joduinn-mtg
- # [20:07] * Joins: fx9 (blah@EEA1950F.43374906.79496794.IP)
- # [20:08] * Quits: jgilbert_ (jgilbert@moz-BBE3ABD.mv.mozilla.com) (Ping timeout)
- # [20:08] <cjones> is bugzilla down again
- # [20:08] <cjones> ?
- # [20:08] <fx9> hey Mozilla, where's Firefox 9.0? http://www.mozilla.org/en-US/firefox/new/ still only offers 8.0.1
- # [20:08] <khuey> it's working for me
- # [20:08] <ehsan> qheaden: this is the binding used for xul:textbox elements that are spell-checked: http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/textbox.xml#505
- # [20:08] * Quits: mike5w3c (MikeS@moz-33844EC4.pool.e-mobile.ne.jp) (Ping timeout)
- # [20:08] <sheppy> fx9: not posted yet
- # [20:08] * Joins: jhammel (jhammel@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net)
- # [20:09] * Joins: mike5w3c (MikeS@moz-42AD9CBD.pool.e-mobile.ne.jp)
- # [20:09] * Joins: clee (clee@moz-BBE3ABD.mv.mozilla.com)
- # [20:10] * bnicholson is now known as bnicholson|afk
- # [20:10] <ehsan> qheaden: what I would do is to simulate the right click, listen for onpopupshown, get the menupopup anonymous node and look for the undo menu item (or do whatever checks you need) and then call .closePopup() on the menupopup object
- # [20:11] <ehsan> qheaden: does that make sense?
- # [20:11] * Quits: cjones (cjones@moz-BBE3ABD.mv.mozilla.com) (Ping timeout)
- # [20:11] <qheaden> ehsan: Sounds good. Do textboxes have spellchecking enabled automatically? Or do you have to enable it?
- # [20:12] <ehsan> qheaden: you need to set the spellcheck="true" attrib on the textbox element
- # [20:12] * Joins: jhorak (jhorak@moz-59813FB4.cust.nbox.cz)
- # [20:12] <qheaden> ehsan: Ok then.
- # [20:12] * Quits: smontagu (chatzilla@moz-D5E67D96.red.bezeqint.net) (Ping timeout)
- # [20:12] * Joins: jduell (jduell@moz-2D9EDA98.lightspeed.sntcca.sbcglobal.net)
- # [20:13] * Joins: jet (junglecode@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net)
- # [20:14] <qheaden> ehsan: So I need to set the onpopupshown attribute on my textbox, or do I need to use addEventLIstener or something like that?
- # [20:14] * Quits: mario (mario@67575F8A.5B6D81B9.490799F7.IP) (Ping timeout)
- # [20:14] <ehsan> qheaden: I think you can both add it on the textbox or any other element in the parent chain
- # [20:14] <ehsan> cause it will bubble up
- # [20:14] <smaug> khuey: using """ ruins indentation and code readability. I'll use just multiline .write so that each line is inside "line of code"
- # [20:14] * rail is now known as rail_away
- # [20:15] <ehsan> but the textbox itself would be the easiest
- # [20:15] <khuey> smaug: ok
- # [20:15] * rail_away is now known as rail
- # [20:15] <khuey> smaug: I don't really care either way, just wasn't sure if you knew that existed
- # [20:15] <qheaden> ehsan: Sounds great. I'm working on it now.
- # [20:15] * Joins: dRdR (dRdR@moz-F979C50C.cpe.net.cable.rogers.com)
- # [20:15] <ehsan> qheaden: awesome, thnks!
- # [20:16] <smaug> khuey: I knew, since I was told to use that """ """ as multiline comments. (which is horrible)
- # [20:16] <khuey> yeah
- # [20:16] <khuey> python has some nasty bits
- # [20:17] * jhammel isn't sure what that is horrible
- # [20:17] * Joins: ohsix (ohsix@E6E9ACEC.B59296AB.15ED1FDC.IP)
- # [20:17] * Joins: marcia (marcia@moz-BBE3ABD.mv.mozilla.com)
- # [20:17] <qheaden> ehsan: You can get elements in chrome test by calling document.getElementId(id_of_element) right?
- # [20:17] * jimm-lunch is now known as jimm
- # [20:18] <ehsan> qheaden: yes
- # [20:18] * Joins: azakai (alon@moz-BBE3ABD.mv.mozilla.com)
- # [20:18] * Joins: Enn (enn@moz-DB6467E3.cpe.net.cable.rogers.com)
- # [20:19] * coop|lunch is now known as coop
- # [20:19] * Quits: ashughes (ashughes@6202C507.852FE72D.DA78B690.IP) (Quit: ashughes)
- # [20:21] * mattwoodrow|away is now known as mattwoodrow
- # [20:22] * bnicholson|afk is now known as bnicholson
- # [20:25] * Quits: jhorak (jhorak@moz-59813FB4.cust.nbox.cz) (Ping timeout)
- # [20:25] * Joins: protz (jonathan@moz-7F6750F6.xulforum.org)
- # [20:25] * Quits: mjschranz (mjschranz@moz-6FE6B833.cpe.net.cable.rogers.com) (Ping timeout)
- # [20:26] * mdas is now known as mdas|afk
- # [20:26] * Joins: akeybl (akeybl@moz-BBE3ABD.mv.mozilla.com)
- # [20:26] * Joins: smontagu (chatzilla@moz-D5E67D96.red.bezeqint.net)
- # [20:29] * Quits: peregrino (peregrino@moz-D0CB2FAA.telecom.net.ar) (Quit: peregrino)
- # [20:30] * Joins: mjschranz (mjschranz@moz-6FE6B833.cpe.net.cable.rogers.com)
- # [20:30] * Joins: jhorak (jhorak@moz-59813FB4.cust.nbox.cz)
- # [20:31] * Quits: smontagu (chatzilla@moz-D5E67D96.red.bezeqint.net) (Ping timeout)
- # [20:31] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [20:32] * Joins: anky (anky@3921E49A.68D1775A.A3D1B221.IP)
- # [20:32] * Joins: smontagu (chatzilla@moz-D5E67D96.red.bezeqint.net)
- # [20:32] * Joins: cjones (cjones@moz-7B0110AD.mv.mozilla.com)
- # [20:34] <rillian> does fwrite set errno?
- # [20:34] * Joins: Mardak (Mardak@moz-BBE3ABD.mv.mozilla.com)
- # [20:34] <hub> rillian: no
- # [20:34] <hub> rillian: use ferror()
- # [20:35] * Quits: smontagu (chatzilla@moz-D5E67D96.red.bezeqint.net) (Ping timeout)
- # [20:35] <rillian> ferror just checks the error flag through, it doesn't give you a indication of what went wrong?
- # [20:35] * bear-buildduty-afk is now known as bear-buildduty
- # [20:35] <hub> mmm
- # [20:35] <hub> I must be wrong then
- # [20:36] <bsmedberg> You can't know what went wrong, basically.
- # [20:36] <rillian> no wonder no one handles out-of-disk-space gracefully
- # [20:36] <rillian> bsmedberg, thanks
- # [20:37] <hub> bsmedberg: that's worse than I thought
- # [20:37] * coop is now known as coop|mtg
- # [20:37] * Parts: LegNeato (clegnitto@moz-B77DEAEB.mozilla.org)
- # [20:39] <hub> can anybody use twitter with Nightly on Linux? I can't https://bugzilla.mozilla.org/show_bug.cgi?id=712182
- # [20:39] <rillian> hadn't noticed a problem
- # [20:40] * Quits: jet (junglecode@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net) (Quit: jet)
- # [20:40] <rillian> I'm using an official build though, not my own
- # [20:40] <fx9> Twitter works fine here with Firefox 12.0a1 hourly build, Gecko/20111220 Firefox/12.0a1
- # [20:41] * Quits: smaug (chatzilla@moz-DAAE7598.elisa-mobile.fi) (Ping timeout)
- # [20:41] * Quits: Mardak (Mardak@moz-BBE3ABD.mv.mozilla.com) (Quit: Mardak)
- # [20:41] * Joins: smaug (chatzilla@moz-DAAE7598.elisa-mobile.fi)
- # [20:41] * Quits: andreasn_ (andreasn@moz-BB6A8755.bredband.comhem.se) (Ping timeout)
- # [20:41] <hub> there is something wrong then
- # [20:41] <hub> fx9: Linux?
- # [20:42] * Joins: zpao|m (zpaom@moz-CE26C95B.hsd1.ca.comcast.net)
- # [20:42] * Parts: zpao|m (zpaom@moz-CE26C95B.hsd1.ca.comcast.net)
- # [20:42] <fx9> XP SP3
- # [20:42] <smaug> hub: loads fine here
- # [20:42] <smaug> not logged in
- # [20:42] <smaug> using linux/Nightly
- # [20:42] <hub> fx9: it works on Mac too :-/
- # [20:42] * Joins: rs (rs@moz-217F02CE.lightspeed.sntcca.sbcglobal.net)
- # [20:43] <hub> smaug: damn
- # [20:43] * Joins: Mardak (Mardak@moz-BBE3ABD.mv.mozilla.com)
- # [20:43] <hub> smaug: and I have no clue how to debug this :-/
- # [20:43] <smaug> hub: connection problems perhaps?
- # [20:43] * jhammel is now known as jhammel|lunch
- # [20:43] <smaug> hub: or, do you have lots of https pages open
- # [20:44] <hub> smaug: works fine in 8.0.1, same profile, same machine
- # [20:44] <hub> smaug: I have a certain number of tabs
- # [20:44] * Joins: gandalf (zbraniecki@moz-3593C9A5.neoplus.adsl.tpnet.pl)
- # [20:44] <smaug> there is something going wrong with https pages, bug 710176
- # [20:44] <hub> BUT, when I test with a different profile it fails too (no tab)
- # [20:44] <hub> let me see that bug
- # [20:44] * Parts: Jake (Jake@moz-CDAFE004.phlapafg.dynamic.covad.net)
- # [20:44] * Joins: smontagu (chatzilla@moz-D5E67D96.red.bezeqint.net)
- # [20:45] * Quits: jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP) (Ping timeout)
- # [20:46] * Quits: cjones (cjones@moz-7B0110AD.mv.mozilla.com) (Ping timeout)
- # [20:46] * Quits: cpearce (chatzilla@moz-55A2BC7D.xdsl.xnet.co.nz) (Ping timeout)
- # [20:47] <smaug> glandium: so, r+ to Bug 711841 ?
- # [20:47] * Joins: jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP)
- # [20:47] * Quits: gmoro (guilherme@3DCBFB93.F520FC74.D159334F.IP) (Quit: Leaving)
- # [20:47] * Joins: jet (junglecode@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net)
- # [20:48] <glandium> smaug: for the way the functions are defined, yes. for the rest, i leave that to bsmedberg or bz
- # [20:48] * Quits: rshetty (quassel@77EBE0C9.CD099EF.C842849F.IP) (Ping timeout)
- # [20:48] * aki is now known as aki|commute
- # [20:49] * jwir3 is now known as jwir3|lunch
- # [20:49] <smaug> glandium: well, bsmedberg said already yes
- # [20:49] <NeilAway> who owns WorkerPrivate.cpp?
- # [20:50] <glandium> smaug: then you have your answer:)
- # [20:50] <smaug> NeilAway: bent
- # [20:50] * Quits: smontagu (chatzilla@moz-D5E67D96.red.bezeqint.net) (Ping timeout)
- # [20:50] <smaug> glandium: well, could you mark r+ ?
- # [20:51] <NeilAway> bent: how would you change ReportError if nsIScriptError2 was folded into nsIScriptError, so that it would be passed directly to LogMessage?
- # [20:51] * Joins: Mnyromyr (Mnyromyr@B2521176.7B0892CB.771966F7.IP)
- # [20:52] * rail is now known as rail_away
- # [20:52] <hub> smaug: I have no idea how to debug that issue if it is bug 710176 or not :-/
- # [20:52] * mdas|afk is now known as mdas
- # [20:53] * Quits: rniwa (rniwa@5CA6DC39.C60FE7DC.4065847B.IP) (Quit: rniwa)
- # [20:53] * rniwa_ is now known as rniwa
- # [20:56] <bent> NeilAway, hm... not sure i understand
- # [20:56] <bent> NeilAway, if you merge nsIScriptError2 then I'd just qi differently?
- # [20:56] <NeilAway> bent: no, then you wouldn't need to QI
- # [20:57] <NeilAway> bent: but then, what do you do if the init fails
- # [20:57] <bent> oh, to nsIConsoleMessage
- # [20:57] <bent> ?
- # [20:57] <NeilAway> bent: well, to nsIScriptError, which inherits from it
- # [20:57] <bent> oh, i see
- # [20:57] <bent> yeah, sounds easy
- # [20:58] * Joins: cjones (cjones@moz-7B0110AD.mv.mozilla.com)
- # [20:59] * rail_away is now known as rail
- # [20:59] * Quits: sheppy (sheppy@moz-F39D62DA.dhcp.kgpt.tn.charter.com) (Quit: sheppy)
- # [21:01] <bent> NeilAway, wonder why nsIScriptError2 doesn't inherit nsIScriptError
- # [21:01] <bent> that seems dumb
- # [21:01] <NeilAway> bent: ask msucan
- # [21:02] <NeilAway> bent: anyway, attachment 583226 for bug 711721 tries to init it, and then still logs it even if the init fails
- # [21:02] * Quits: vladan (vladan@F2D29657.F60B0462.67AC9B1.IP) (Quit: Leaving.)
- # [21:02] * Joins: smontagu (chatzilla@moz-D5E67D96.red.bezeqint.net)
- # [21:02] <NeilAway> bent: which I guess is probably not ideal ;-)
- # [21:02] <msucan> bent: the lack of inheritance is a cause of how it was pushed too late in the process of firefox 4
- # [21:03] <msucan> or something
- # [21:03] <bent> NeilAway, you left an empty if clause i think
- # [21:03] * Quits: khuey (khuey@moz-B77DEAEB.mozilla.org) (Ping timeout)
- # [21:03] <msucan> afaik nsiscripterror2 was added by bz. i don't remember the technical reasons for not inheriting
- # [21:03] <bent> NeilAway, you should just make that if (NS_FAILED)
- # [21:03] * Joins: ddahl (ddahl@moz-6971CF66.hsd1.il.comcast.net)
- # [21:04] * Quits: slowbro (slowpoke@moz-39E36627.pools.arcor-ip.net) (Ping timeout)
- # [21:04] <bent> NeilAway, http://pastebin.mozilla.org/1413811
- # [21:04] <NeilAway> bent: it's not my patch :-P
- # [21:04] <bent> oh! my bad
- # [21:04] * Quits: gandalf (zbraniecki@moz-3593C9A5.neoplus.adsl.tpnet.pl) (Quit: Computer has gone to sleep.)
- # [21:04] <bent> thought it was
- # [21:04] <NeilAway> bent: yeah, my name is on the *other* side of the r? :-P
- # [21:05] <NeilAway> bent: anyway, I have to go, perhaps you should comment in the bug
- # [21:05] * Quits: jhorak (jhorak@moz-59813FB4.cust.nbox.cz) (Ping timeout)
- # [21:05] <NeilAway> bent: thanks anyway
- # [21:05] <NeilAway> smaug: thanks too for pointing me at bent
- # [21:05] * Joins: rshetty (quassel@38B57932.56C78E20.C842849F.IP)
- # [21:06] * Joins: gandalf (zbraniecki@moz-3593C9A5.neoplus.adsl.tpnet.pl)
- # [21:06] * Quits: gandalf (zbraniecki@moz-3593C9A5.neoplus.adsl.tpnet.pl) (Quit: Computer has gone to sleep.)
- # [21:07] * Quits: mjschranz (mjschranz@moz-6FE6B833.cpe.net.cable.rogers.com) (Ping timeout)
- # [21:07] * Joins: khuey (khuey@moz-B77DEAEB.mozilla.org)
- # [21:07] * Joins: slowpoke (slowpoke@moz-F02DAE63.gigabit.perfect-privacy.com)
- # [21:07] * Joins: mjschranz (mjschranz@moz-6FE6B833.cpe.net.cable.rogers.com)
- # [21:08] * Joins: vladan (vladan@F2D29657.F60B0462.67AC9B1.IP)
- # [21:08] * Joins: mgorse (mgorse@B6C068B2.2088E15E.A18F112A.IP)
- # [21:08] * Joins: jhorak (jhorak@moz-59813FB4.cust.nbox.cz)
- # [21:09] <qheaden> ehsan: Ok. I'm still working on the test, but I manually tested it, and the Undo add to dictionary does work for XUL textboxes.
- # [21:09] <ehsan> qheaden: great!
- # [21:10] * Quits: bmoss|2 (bmoss@moz-BBE3ABD.mv.mozilla.com) (Ping timeout)
- # [21:10] <bsmedberg> josh: do you want me to debug the pandora thing some more with those clues, or will you look into it?
- # [21:10] <mgorse> edmorley: Hi. Are you here? So the fix for bug 693343 was causing hangs at shutdown?
- # [21:11] * Mossop is now known as Mossop_lunch
- # [21:12] <qheaden> ehsan: Am I on the right track here with this test: http://pastebin.com/AGuYcAw7
- # [21:13] <qheaden> I'm using that "ok" test just to see if the context menu was found. That won't stay there, its just for my purposes.
- # [21:13] * Quits: jstraus (Adium@moz-C7B4D9FC.hsd1.ma.comcast.net) (Connection reset by peer)
- # [21:13] * Quits: smontagu (chatzilla@moz-D5E67D96.red.bezeqint.net) (Ping timeout)
- # [21:13] * Joins: jstraus (Adium@moz-C7B4D9FC.hsd1.ma.comcast.net)
- # [21:13] * Joins: jlebar (jlebar@moz-858D624E.dyn.columbia.edu)
- # [21:13] * Joins: bmoss|2 (bmoss@moz-BBE3ABD.mv.mozilla.com)
- # [21:13] * Quits: priya (priya@moz-BBE3ABD.mv.mozilla.com) (Quit: This computer has gone to sleep)
- # [21:14] <ehsan> qheaden: yes, this looks like a good start
- # [21:14] <qheaden> Ok
- # [21:15] * Joins: brendan (brendaneic@moz-BBE3ABD.mv.mozilla.com)
- # [21:15] * jlebar is now known as jlebar|mac
- # [21:15] * Joins: TheOne (one@moz-E54CA067.dip.t-dialin.net)
- # [21:16] * Joins: wolfiR (wolfiR@moz-9F2DACD5.dip0.t-ipconnect.de)
- # [21:16] * Quits: gcp (gpascutto@moz-D0E475EA.access.telenet.be) (Quit: Make a new plan, Stan!)
- # [21:16] * philor changes topic to 'm-c: CLOSED m-i: CLOSED for infra || Next aurora uplift: Today! \o/ || If you are new or want to help, see irc://irc.mozilla.org/#introduction || "if you like the way it's working, just you wait five minutes"'
- # [21:17] * khuey wonders how often the tree is closed for infra problems
- # [21:17] * Quits: kdcw (kdc@moz-F7413045.pk.shawcable.net) (Quit: HydraIRC -> http://www.hydrairc.com <- Organize your IRC)
- # [21:17] <jbuck> hmm... I've got an nsCAutoString which is already converted to UTF16. Is it safe to cast that to a PRUnichar, or am I shooting myself in the foot?
- # [21:17] <mccr8> khuey: when one tree closes, another opens.
- # [21:18] <jlebar|mac> mccr8++
- # [21:18] * lurking_work thinks lately its been a weekly occurrence, or maybe even twice / week
- # [21:18] <smaug> jbuck: why do you get nsCString which is in UTF16? Sounds like a bug
- # [21:19] <smaug> jbuck: or are you using CString as a random data container?
- # [21:20] <qheaden> Hmm. I can't seem to access that XUL context menu via document.getElementById. Is there another method have have to use?
- # [21:20] * Joins: ashughes (ashughes@6202C507.852FE72D.DA78B690.IP)
- # [21:20] <smaug> hmm, m-c closed just when I was going to land something
- # [21:21] * Joins: Jake (Jake@moz-CDAFE004.phlapafg.dynamic.covad.net)
- # [21:21] * philor marks one point for himself
- # [21:21] * philor changes topic to 'm-c: CLOSED m-i: CLOSED for bug 712384 || Next aurora uplift: Today! \o/ || If you are new or want to help, see irc://irc.mozilla.org/#introduction || "if you like the way it's working, just you wait five minutes"'
- # [21:21] <smaug> qheaden: document == contextmenuitem.ownerDocument ?
- # [21:22] * Joins: bholley (bholley@moz-17B89992.tmodns.net)
- # [21:22] * Joins: florian (florian@moz-87C33FDA.kimsufi.com)
- # [21:22] * Joins: Fallen|mac (kewisch@moz-51AFBD92.adsl.alicedsl.de)
- # [21:22] <qheaden> smaug: I remember that advice from last time. :) But this time, I am having trouble accessing the actual context menu, not an element from it.
- # [21:23] * Quits: jesup (chatzilla@moz-DECFDD00.phlapa.fios.verizon.net) (Ping timeout)
- # [21:23] * Quits: mdr (chatzilla@moz-DECFDD00.phlapa.fios.verizon.net) (Ping timeout)
- # [21:23] <jbuck> smaug: http://pastebin.mozilla.org/1413821
- # [21:23] * Joins: djc (djc@moz-E26330E3.xavamedia.nl)
- # [21:23] * dholbert is now known as dholbert|lunch
- # [21:23] <jbuck> just trying to report an error to the console, but I can't get it typed properly.
- # [21:23] <djc> when I use a nightly build, does it use the same profile as my normal Aurora?
- # [21:24] <djc> (it's a debug build, my first try at doing my own build)
- # [21:24] <smaug> yes
- # [21:24] <bholley> djc: unless you use the ProfileManager
- # [21:24] <bmoss|2> johnath: ping
- # [21:24] <bmoss|2> jprmc: ping
- # [21:24] <djc> will that change stuff so that aurora doesn't understand it anymore?
- # [21:24] * Quits: jhorak (jhorak@moz-59813FB4.cust.nbox.cz) (Ping timeout)
- # [21:24] <josh> bsmedberg: If you're able to continue helping that would be great, I'm not sure when I'll get a chance to dig in again. I'm trying to make time though.
- # [21:24] <jbuck> I was looking at other examples of ReportToConsole, and they converted to UTF16 first, http://mxr.mozilla.org/mozilla-central/source/content/base/src/nsCSPService.cpp#304
- # [21:25] <smaug> nsCAutoString uriSpec;
- # [21:25] <smaug> element->GetCurrentSrc(uriSpec);
- # [21:25] <bholley> djc: it might
- # [21:25] <smaug> that shouldn't even compile
- # [21:25] <bholley> djc: sometimes there's profile migration code
- # [21:25] <bholley> djc: it's safer to use a separate profile
- # [21:25] <smaug> jbuck: GetCurrentSrc takes nsAString, not nsACString
- # [21:25] <djc> bholley: is there an easy way to force it to always use a separate profile?
- # [21:25] <jbuck> oh haha, I didn't even see that compiler error. whoops.
- # [21:25] * Quits: ashughes (ashughes@6202C507.852FE72D.DA78B690.IP) (Quit: ashughes)
- # [21:25] * Joins: smontagu (chatzilla@moz-D5E67D96.red.bezeqint.net)
- # [21:26] * Joins: mcsmurf (mcsmurf@moz-87D0F79.dip.t-dialin.net)
- # [21:26] <bholley> djc: yeah, you can change the command you're running it with to include "-P myprofilename"
- # [21:26] * coop|mtg is now known as coop
- # [21:26] * Quits: jduell (jduell@moz-2D9EDA98.lightspeed.sntcca.sbcglobal.net) (Quit: Leaving)
- # [21:26] * Joins: andreasn (andreasn@moz-3CDFCC6A.a336.corp.bahnhof.se)
- # [21:26] <jhammel|lunch> djc: or -p /path/to/profile
- # [21:27] <djc> bholley: and that will probably also allow me to have aurora and nightly running at the same time?
- # [21:27] <jhammel|lunch> (lowercase vs upper)
- # [21:27] <bholley> djc: yep!
- # [21:27] <djc> cool
- # [21:27] <jhammel|lunch> do you still have to specify -no-remote too, i think?
- # [21:27] <rs> you do
- # [21:28] <jhammel|lunch> that should be automagic, IMHO
- # [21:28] <jhammel|lunch> but i have larger trout to fry
- # [21:28] * Joins: ashughes (ashughes@6202C507.852FE72D.DA78B690.IP)
- # [21:28] * Joins: gandalf (zbraniecki@moz-3593C9A5.neoplus.adsl.tpnet.pl)
- # [21:29] * mcote|lunch is now known as mcote
- # [21:29] <djc> jhammel|lunch: is that -no-remote directed at me, or something else?
- # [21:29] <djc> it seems to work...
- # [21:29] <jprmc> bmoss|2: pong
- # [21:29] <bmoss|2> hey who handles content
- # [21:29] <jprmc> bmoss|2: jst
- # [21:29] <bmoss|2> not rok
- # [21:29] <bmoss|2> roc
- # [21:29] <jprmc> no
- # [21:29] <jprmc> content == dom
- # [21:30] <jprmc> roc == layout
- # [21:30] <bmoss|2> ah ok
- # [21:30] * Quits: smontagu (chatzilla@moz-D5E67D96.red.bezeqint.net) (Ping timeout)
- # [21:30] <jprmc> there is overlap though
- # [21:30] <jprmc> bmoss|2: is there a particular trace to look at?
- # [21:30] <smaug> there is always overlap
- # [21:30] * jwir3|lunch is now known as jwir3
- # [21:31] * Quits: gandalf (zbraniecki@moz-3593C9A5.neoplus.adsl.tpnet.pl) (Quit: Computer has gone to sleep.)
- # [21:31] * Joins: smontagu (chatzilla@moz-D5E67D96.red.bezeqint.net)
- # [21:32] <bmoss|2> yes
- # [21:32] <bmoss|2> bill has it
- # [21:32] <jbuck> smaug: argh that was totally it. Thanks!
- # [21:32] * philor changes topic to 'm-c: OPEN m-i: OPEN || Next aurora uplift: Today! \o/ || If you are new or want to help, see irc://irc.mozilla.org/#introduction || "if you like the way it's working, just you wait five minutes"'
- # [21:34] * Joins: jhorak (jhorak@moz-59813FB4.cust.nbox.cz)
- # [21:36] * Joins: gandalf (zbraniecki@moz-3593C9A5.neoplus.adsl.tpnet.pl)
- # [21:36] * Joins: cpearce (chatzilla@538BABFE.A073F3E.97BBD552.IP)
- # [21:36] * aki|commute is now known as aki
- # [21:36] <djc> so would anyone know a reason why bug 686113 hasn't gotten any traction?
- # [21:37] <djc> is it just an OS bug or should I investigate if the APIs have changed somehow?
- # [21:37] <djc> and if the latter, any recommend files to start digging?
- # [21:38] * Quits: smontagu (chatzilla@moz-D5E67D96.red.bezeqint.net) (Ping timeout)
- # [21:38] * Quits: gandalf (zbraniecki@moz-3593C9A5.neoplus.adsl.tpnet.pl) (Quit: Computer has gone to sleep.)
- # [21:39] * Quits: roc (chatzilla@C0ACF8B.5E1E9EEA.613E47D1.IP) (Ping timeout)
- # [21:39] <smaug> djc: josh might know
- # [21:40] <ehsan> smaug: should I run the try build inside bug 711900?
- # [21:40] * Joins: smontagu (chatzilla@moz-D5E67D96.red.bezeqint.net)
- # [21:41] * Quits: pascalc (chatzilla@moz-15F4ED77.rev.sfr.net) (Ping timeout)
- # [21:41] <qheaden> Are context menus children of the element you right-clicked?
- # [21:41] * jhammel|lunch is now known as jhammel
- # [21:41] <smaug> ehsan: if you see more CC hangs in 10 than 9, then yes, you could try. But it seems that bz' problem is something else
- # [21:41] <smaug> qheaden: no
- # [21:41] <smaug> or can be
- # [21:41] <smaug> but they are just somewhere
- # [21:41] <qheaden> Ok
- # [21:41] <ehsan> smaug: I think my nightly _is_ affected with bz's problem, and has been so for a long time
- # [21:42] <ehsan> qheaden: you want getAnonymousElement...
- # [21:42] <smaug> ehsan: note, strong parent pointer landed trunk late July
- # [21:42] * ehsan doesn't remember the exact name of the API
- # [21:42] <edmorley> armenzg: re bug 673131, I don't have an aurora or beta tree checked out sadly
- # [21:42] <ehsan> smaug: well, I'm getting CC/GCs every 5 seconds or so, and their times vary between less than a second to 2+ seconds...
- # [21:43] * Quits: smontagu (chatzilla@moz-D5E67D96.red.bezeqint.net) (Ping timeout)
- # [21:43] <ehsan> smaug: is that not bz's problem?
- # [21:43] <johnath> bmoss|2: pong
- # [21:43] <qheaden> ehsan: Yeah, I'm trying that function now
- # [21:43] <djc> josh: your input on bug 686113 would be much appreciated
- # [21:43] <bmoss|2> hey was looking for a little help for bill on the crash
- # [21:43] <qheaden> ehsan: getAnonymousElementByAttribute right?
- # [21:43] <ehsan> qheaden: yes
- # [21:43] <armenzg> edmorley: thanks for looking though. I should ask for L3 commit level
- # [21:43] <josh> djc: looking
- # [21:43] <bmoss|2> but I'm not sure who to tap
- # [21:43] <smaug> ehsan: bz didn't have problems with FF9 when it still had strong parent node
- # [21:44] <armenzg> edmorley: do you have 1.9.2?
- # [21:44] <edmorley> mgorse: sorry was eating. tbsaunde is looking at the problem already I believe. It was backed out for turning the linux builds orange: https://tbpl.mozilla.org/?rev=887abec76bca
- # [21:44] <ehsan> smaug: ok, but did we ever came to the conclusion that the strong parent node is the root of the problem?
- # [21:44] <ehsan> my impression was that we don't know yet
- # [21:44] <smaug> ehsan: we don't know
- # [21:44] <ehsan> ok
- # [21:44] <smaug> ehsan: it is a problem for some cases sure, but not all
- # [21:45] <ehsan> so my question was, will me running your try build help determine the cause? :)
- # [21:45] <josh> djc: Would be best to have Steven Micaud look into a fix
- # [21:45] <smaug> ehsan: if you see bad CC times often, and can reproduce easily, please try those builds
- # [21:45] <josh> djc: if I get a chance to look over the holiday break i'll see what I can do
- # [21:45] <djc> josh: I'm ready to start digging myself, could just use a few pointers
- # [21:45] <ehsan> smaug: yep, I do, so I'll do that, thanks :)
- # [21:45] <edmorley> armenzg: I only have m-c and inbound at the moment, I used to have a few more, but at 140,000 files a pop, loads more repos really messes with drive performance (on windows ntfs with flaky non-ssd HD at least)
- # [21:46] <djc> already got a custom Nightly built for the first time...
- # [21:46] * Quits: brendan (brendaneic@moz-BBE3ABD.mv.mozilla.com) (Quit: brendan)
- # [21:46] * Quits: Honza (chatzilla@E07BF19C.5BB5597D.D0083327.IP) (Ping timeout)
- # [21:46] * Joins: Honza (chatzilla@E07BF19C.5BB5597D.D0083327.IP)
- # [21:47] <qheaden> Hmm. If the context menu isn't a child of the textbox, what element do I pass as the first arg to getAnonymousElementByAttribute?
- # [21:47] <josh> djc: what do you want to know, specifically?
- # [21:47] <ehsan> qheaden: it is the anonymous child of the textbox
- # [21:47] <qheaden> ok
- # [21:48] <khuey> bmoss|2: if you can post a stack I can probably tell you who to poke
- # [21:48] <johnath> bmoss|2: from a quick skim, it looks like the stack in bug 711794 is happening during GC of some XUL objects - bz, jst, maybe sicking would be good to poke for cleverer analysis
- # [21:48] <josh> djc: I would maybe start by making Firefox be consistent - making the key repeat work with all keys. Then look at proper accent menu integration in another bug.
- # [21:49] * Quits: Sander (chatzilla@moz-B871F4D3.direct-adsl.nl) (Ping timeout)
- # [21:49] * Quits: mgoodwin (mgoodwin@moz-4BB9E5E9.cable.virginmedia.com) (Ping timeout)
- # [21:50] * Joins: mgoodwin (mgoodwin@moz-4BB9E5E9.cable.virginmedia.com)
- # [21:50] <bmoss|2> khuey: 711794
- # [21:50] * Quits: bsmith (bsmith@moz-364A0C3E.hsd1.ca.comcast.net) (Ping timeout)
- # [21:50] * Joins: Sander (chatzilla@moz-B871F4D3.direct-adsl.nl)
- # [21:50] <johnath> khuey: https://bug711794.bugzilla.mozilla.org/attachment.cgi?id=583237
- # [21:50] <johnath> oh, bob's already said that
- # [21:50] <bmoss|2> johnath: yes, bz and jst are travelling
- # [21:51] * Quits: karl (karl@A5E853A7.333C855E.C8A09C26.IP) (Ping timeout)
- # [21:51] <bmoss|2> and I forgot jonas' irc name
- # [21:51] <bmoss|2> shame on me
- # [21:51] <khuey> sicking
- # [21:51] <bmoss|2> sicking: ping
- # [21:51] <djc> josh: I mean, like, what files to look at
- # [21:51] <djc> since I've never done a m-c patch before
- # [21:51] <khuey> bmoss|2: try sicking or smaug
- # [21:51] <josh> djc: widget/src/cocoa/nsChildView.mm
- # [21:51] * Quits: jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP) (Ping timeout)
- # [21:51] <josh> the fix will almost certainly be in that file
- # [21:52] <khuey> also, that's a fun stack
- # [21:52] * Joins: smontagu (chatzilla@moz-D5E67D96.red.bezeqint.net)
- # [21:52] <josh> that's where the Cocoa key handling code is (most of it, anyway)
- # [21:52] <djc> josh: also, is there a particular reason this bug fell through the cracks for so long?
- # [21:52] <bmoss|2> smaug: ping
- # [21:52] <djc> I'll take a look at nsChildView, thanks
- # [21:52] <smaug> bmoss|2: pong
- # [21:53] <smaug> is Bug 711794 osx only?
- # [21:53] <qheaden> Ok. I really don't get what the problem is. http://pastebin.mozilla.org/1413833
- # [21:53] <bmoss|2> osx and linux
- # [21:53] <qheaden> It keeps saying that contextMenu is null.
- # [21:53] <josh> djc: not that I know of, but it doesn't have very many commenters complaining or duplicate bugs on file, that's all i can think of
- # [21:53] <bmoss|2> could you give bill mccloskey a hand with this
- # [21:53] <sicking> khuey, bmoss|2: pong
- # [21:54] <bmoss|2> hey jonas, 711794
- # [21:54] <johnath> sicking: https://bugzilla.mozilla.org/show_bug.cgi?id=711794#c41
- # [21:54] * Joins: gmoro (guilherme@3DCBFB93.F520FC74.D159334F.IP)
- # [21:54] <bmoss|2> this is between us and shipping ffx9
- # [21:55] * Quits: jhorak (jhorak@moz-59813FB4.cust.nbox.cz) (Ping timeout)
- # [21:55] * Joins: bsmith (bsmith@moz-364A0C3E.hsd1.ca.comcast.net)
- # [21:56] * Quits: smontagu (chatzilla@moz-D5E67D96.red.bezeqint.net) (Ping timeout)
- # [21:56] * Quits: jlebar|mac (jlebar@moz-858D624E.dyn.columbia.edu) (Quit: jlebar|mac)
- # [21:56] * Quits: philipp64|laptop (chatzilla@moz-764C1742.hfc.comcastbusiness.net) (Ping timeout)
- # [21:56] <qheaden> Wow, I'm just now realizing how serious 711794 is.
- # [21:57] * Mossop_lunch is now known as Mossop
- # [21:57] <blizzard> dolske: http://www.streetartutopia.com/wp-content/uploads/2011/12/8-jan-street_art_9_love.jpeg
- # [21:57] <blizzard> dolske: http://www.streetartutopia.com/wp-content/uploads/2011/12/20-street_art_mars_1_2.jpeg
- # [21:59] * Joins: jprmc (jprmc@F2D29657.F60B0462.67AC9B1.IP)
- # [21:59] <sicking> johnath: nothing pops out in the stack trace. Reading whole bug now
- # [22:00] <bmoss|2> sicking: thanks jonas
- # [22:00] <dolske> blizzard: dang hippies!
- # [22:00] * Joins: gandalf (zbraniecki@moz-3593C9A5.neoplus.adsl.tpnet.pl)
- # [22:00] * Quits: gandalf (zbraniecki@moz-3593C9A5.neoplus.adsl.tpnet.pl) (Quit: Computer has gone to sleep.)
- # [22:00] * Joins: jhorak (jhorak@moz-59813FB4.cust.nbox.cz)
- # [22:00] * Joins: stfl (stfl@moz-22F37930.hsi7.kabel-badenwuerttemberg.de)
- # [22:01] * Joins: eflores (AndChat@538BABFE.A073F3E.97BBD552.IP)
- # [22:01] <smaug> bmoss|2: someone who can reproduce the bug needs to find the exact regression range
- # [22:01] <khuey> smaug: I think smichaud is doing that now
- # [22:02] <smaug> hmm, there are different stack traces...always some badness in JS
- # [22:03] <bmoss|2> smaug: the one from bill was created by installing the Nectar toolbar
- # [22:04] <khuey> it looks pretty screwy that deleting properties can cause allocs of gc things
- # [22:04] <khuey> to the "expecting a sane API" part of my brain
- # [22:05] <smaug> well, you may need to create a new shape
- # [22:05] <smaug> I assume shapes are gc things
- # [22:05] * dholbert|lunch is now known as dholbert
- # [22:05] <khuey> well they are judging by this stack
- # [22:05] <khuey> but that means you can't delete properties during finalization
- # [22:06] <khuey> which is what the xbl code in question is doing
- # [22:06] * juanb is now known as juanb|lunch
- # [22:06] * rail is now known as rail_away
- # [22:06] * smaug has a bad feeling that this is something which was hidden before because of strong parent node
- # [22:06] * AaronMT is now known as AaronMT|mtg
- # [22:07] <smaug> something kept perhaps alive longer, and that is why something was gc'ed later or something
- # [22:07] <khuey> well we are destroying an element during finalization
- # [22:08] <khuey> which can't happen with strong parent pointer, since we need the CC to break cycles, right?
- # [22:08] <smaug> but the stack trace shows pretty clearly some problem in JS
- # [22:08] * Joins: lsumar (lsumar@538BABFE.A073F3E.97BBD552.IP)
- # [22:08] <gavin> strong parent node is out of 9, right?
- # [22:08] <khuey> right
- # [22:08] * Quits: bholley (bholley@moz-17B89992.tmodns.net) (Ping timeout)
- # [22:08] <smaug> ofc you can destroy elements without CC
- # [22:08] * Joins: alex (alex@moz-BD8D0A09.lightspeed.sntcca.sbcglobal.net)
- # [22:08] <khuey> smaug: well, elements in the tree ...
- # [22:09] <smaug> that doesn't matter, really
- # [22:09] * Quits: whimboo|afk (whimboo@moz-216F9AFA.superkabel.de) (Quit: Leaving.)
- # [22:09] <khuey> really?
- # [22:10] * rail_away is now known as rail
- # [22:10] <smaug> well, you can always have random elements kept alive by js
- # [22:10] * Quits: jhorak (jhorak@moz-59813FB4.cust.nbox.cz) (Quit: Leaving)
- # [22:10] * Joins: smontagu (chatzilla@moz-D5E67D96.red.bezeqint.net)
- # [22:10] * jdgilbert is now known as jgilbert|lunch
- # [22:13] * Joins: bjarne (bjarne@moz-B436FB98.nextgentel.com)
- # [22:13] <sicking> i thought that we tried to avoid running C++ finalizers during GC
- # [22:14] <sicking> we obviously are here though
- # [22:14] <bent> that's for wrappednatives
- # [22:14] <sicking> mccr8: ping
- # [22:14] <sicking> bent: xpcom objects are wrappednatives, no?
- # [22:14] <bent> i thought these were xbl things?
- # [22:14] <bent> oh, but C++ XBL things
- # [22:15] <smaug> not all the stacks show xbl
- # [22:15] <sicking> the thing getting finalized here is a XUL element
- # [22:15] <sicking> which then tears down a bunch of stuff, including XBL
- # [22:15] <sicking> but the point where we enter XPCOM land is nsXULElement::Release
- # [22:15] * Joins: jlebar (jlebar@moz-3F3A6302.dyn.columbia.edu)
- # [22:16] <bent> surely that is CC'd right?
- # [22:16] <bent> so how are we actually deleting it?
- # [22:17] * KaiRo is now known as KaiRo_away
- # [22:17] <smaug> bent: you don't need CC to delete an element
- # [22:17] * Parts: Jake (Jake@moz-CDAFE004.phlapafg.dynamic.covad.net)
- # [22:18] * Quits: smontagu (chatzilla@moz-D5E67D96.red.bezeqint.net) (Ping timeout)
- # [22:18] <bent> hm
- # [22:20] * Quits: msucan (msucan-@FA9E8863.56E67207.699550A1.IP) (Quit: .)
- # [22:20] * Quits: janv (varga@moz-C1261AFF.flarion.as5628.telecom.sk) (Quit: This computer has gone to sleep)
- # [22:22] <mccr8> sicking: pong
- # [22:22] <sicking> see https://bugzilla.mozilla.org/show_bug.cgi?id=711794#c47
- # [22:22] <sicking> is this something you know anything about?
- # [22:22] <sicking> did we change interaction between GC and XPCOM lately?
- # [22:23] <khuey> smaug: when did strong parent pointer get removed from 9?
- # [22:23] <mccr8> sicking: hmm. not that I can think of.
- # [22:23] <mccr8> I'm not really sure how the GC finalization stuff works.
- # [22:23] <bent> interesting... i think this is peterv's fault
- # [22:24] <bent> calling release manually from finalize is bad
- # [22:24] <bent> https://mxr.mozilla.org/mozilla-central/source/js/xpconnect/src/XPCWrappedNativeJSOps.cpp#631
- # [22:24] <smaug> khuey: it is in the regression range
- # [22:24] <bent> the non-slim path does the deferred release
- # [22:24] <khuey> smaug: the dec 9th to dec 10th range?
- # [22:24] <sicking> bent: was this changed recently?
- # [22:25] <smaug> possibly even that
- # [22:25] <sicking> mccr8: ok, thanks
- # [22:25] <khuey> bent: that code has been in the tree for two years
- # [22:25] <khuey> so something else changed recently that's the more immediate cause
- # [22:26] <bent> something has changed, sure... but this seems like a real problem nonetheless
- # [22:26] * Joins: aja (chatzilla@A8F7EE0.72086529.7880DB15.IP)
- # [22:26] * Joins: roc (chatzilla@538BABFE.A073F3E.97BBD552.IP)
- # [22:27] <sicking> is any of the incremental GC stuff in 9?
- # [22:27] <sicking> is TI affecting GC?
- # [22:27] <bent> mccr8, didn't something just change with shapes and CC?
- # [22:28] <smaug> khuey: I'm worried that if strong parent node back out caused this, it was just hiding some real problem earlier.
- # [22:28] <bent> maybe only on trunk
- # [22:28] * juanb|lunch is now known as juanb
- # [22:28] <khuey> smaug: right
- # [22:28] <khuey> that seems like a plausible theory
- # [22:28] <aja> Mossop: NTT maxversion bump in the works?
- # [22:28] <mccr8> bent: yes, but in 11. this problem is in 9.
- # [22:28] <bent> ok
- # [22:28] <lurking_work> aja: I don't think he maintains NTT anymore
- # [22:29] * Joins: brendan (brendaneic@4F921A8B.21B9FC39.43362C16.IP)
- # [22:29] <NeilAway> bent: anyway, so that patch looks as if it would log a script error that failed to init...
- # [22:29] <aja> lurking_work: k...name's still on it on AMO though
- # [22:29] * lurking_work nods - yep
- # [22:30] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Connection reset by peer)
- # [22:30] <bent> NeilAway, ah, we used to handle that with the other comptr i think
- # [22:31] <NeilAway> bent: right, it was a side-effect of being in the NS_SUCCEEDED branch ;-)
- # [22:31] <bent> yeah
- # [22:31] <NeilAway> qheaden: can't you use event.target?
- # [22:32] * heycam|away is now known as heycam
- # [22:33] <qheaden> NeilAway: ??
- # [22:33] <NeilAway> qheaden: sorry, I thought you were listening for the popupshowing event
- # [22:33] <smaug> grr, beta.mozilla.org gives be a build which doesn't even run on this machine
- # [22:33] * Joins: mib_5qm70f (Mibbit@300E8850.15B7D320.67BABDAE.IP)
- # [22:33] <NeilAway> oh, you'll probably need event.originalTarget
- # [22:33] * Quits: davidb (davidb@F2D29657.F60B0462.67AC9B1.IP) (Quit: davidb)
- # [22:33] * Joins: smontagu (chatzilla@moz-D5E67D96.red.bezeqint.net)
- # [22:34] <qheaden> NeilAway: Is that passed as a parameter to the handler for onpopupshown?
- # [22:34] <NeilAway> qheaden: indeed, event is always passed as a parameter to event listeners
- # [22:35] <qheaden> NeilAway: Oops. Showing my web-dev noobishness. :P
- # [22:35] <NeilAway> the parameter, even
- # [22:35] <NeilAway> qheaden: well, works for event attributes too
- # [22:35] * Quits: smontagu (chatzilla@moz-D5E67D96.red.bezeqint.net) (Ping timeout)
- # [22:36] * Quits: mjschranz (mjschranz@moz-6FE6B833.cpe.net.cable.rogers.com) (Client exited)
- # [22:37] <qheaden> Well. Thanks for all of the help guys. I'll work some more on this later.
- # [22:37] <qheaden> Gotta go. :)
- # [22:37] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [22:37] * Quits: wolfiR (wolfiR@moz-9F2DACD5.dip0.t-ipconnect.de) (Quit: Leaving)
- # [22:37] * Quits: qheaden (qheaden@moz-67E02157.nrflva.fios.verizon.net) (Quit: Leaving)
- # [22:38] * AaronMT|mtg is now known as AaronMT
- # [22:39] * Quits: Boriss (FlyingToas@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net) (Quit: Boriss)
- # [22:41] * gregglind is now known as gregglind_afk
- # [22:42] * Quits: brendan (brendaneic@4F921A8B.21B9FC39.43362C16.IP) (Quit: brendan)
- # [22:43] <rnewman> anyone seeing this in current m-c? ../../netwerk/protocol/about/nsAboutProtocolHandler.o: file not recognized: File truncated
- # [22:43] * Joins: Boriss_ (FlyingToas@moz-C03D0C61.vlan426.asr1.sfo1.gblx.net)
- # [22:44] <aja> "Your Firefox is out of date." on http://www.mozilla.org/en-US/firefox/9.0/whatsnew/ ???
- # [22:44] * anant is now known as anant-away
- # [22:44] * davehunt|away is now known as davehunt
- # [22:44] <bsmedberg> rnewman: that sounds like a disk or network error
- # [22:44] <bsmedberg> rnewman: did you perhaps hit Ctrl-C during a previous build?
- # [22:45] * Quits: clee (clee@moz-BBE3ABD.mv.mozilla.com) (Quit: clee)
- # [22:45] <rnewman> not to my knowledge... trying a clean build now
- # [22:45] <davehunt> hey taras: I have a telemetry question for you. Is it possible to retrieve the latest value added to the histogram?
- # [22:45] <rnewman> I would personally give $200 to someone who dropped our clean build times by half
- # [22:45] <rnewman> *sigh*
- # [22:46] <rnewman> might cover half of gps's beer tab ;)
- # [22:46] * Quits: mib_5qm70f (Mibbit@300E8850.15B7D320.67BABDAE.IP) (Quit: http://www.mibbit.com ajax IRC Client)
- # [22:47] <sicking> johnath, bent: So one solution would be to fix the problem in the slim wrapper code. That a big change for being so late (to say the least) in the release cycle
- # [22:47] <bent> yeah
- # [22:47] <sicking> johnath, bent: Would definitely need peterv's involvement
- # [22:47] <bent> don't know how we could do that
- # [22:47] <sicking> bmoss|2: ^
- # [22:47] * Quits: Enn (enn@moz-DB6467E3.cpe.net.cable.rogers.com) (Ping timeout)
- # [22:47] <bent> that change will need some serious testing
- # [22:47] <sicking> distributed testing
- # [22:47] <khuey> yeah that would be terrifying
- # [22:48] <khuey> to do at this stage
- # [22:48] <sicking> that's not something that we could just put through QA
- # [22:48] <bmoss|2> sicking: sorry what are you looking for?
- # [22:48] <bent> bmoss|2, a miracle ;)
- # [22:48] <bmoss|2> we we do work at mozilla
- # [22:48] <sicking> bmoss|2: "So one solution would be to fix the problem in the slim wrapper code. That a big change for being so late (to say the least) in the release cycle"
- # [22:48] <khuey> bmoss|2: the current theory for 711794 is that someone changed something to tickle an existing bug
- # [22:48] <khuey> bmoss|2: sicking is talking about fixing the underlying problem here
- # [22:49] * Quits: fx9 (blah@EEA1950F.43374906.79496794.IP) (Quit: )
- # [22:49] <sicking> bmoss|2: it's a years-old bug, and in a very central part of the code. So the effects are unknown
- # [22:49] <bent> we can't do that... not for this release, it would be crazy
- # [22:50] <bmoss|2> I understand. My "worry" is now that it appears to be uncovered. How prevalent will it be.
- # [22:50] * merike is now known as merike|away
- # [22:50] * Quits: protz (jonathan@moz-7F6750F6.xulforum.org) (Quit: Leaving)
- # [22:50] <bmoss|2> the fix is scary, not being able to start your browser is scary
- # [22:50] <gps> rnewman: highly unlikely you'll get clobber builds to drop that much just because most of the clean build time is in compiling c/c++
- # [22:50] <bent> let's figure out how to cover it up again ;)
- # [22:51] <jlebar> gps: Depends on how many cores you have.
- # [22:51] <khuey> bent: I know a guy who sells fill dirt
- # [22:51] <khuey> we can get a couple dump trucks full of it
- # [22:51] <khuey> and just dump it on top
- # [22:51] <khuey> problem solved
- # [22:51] <jlebar> gps: If you have an 8-core machine, all 8 cores are not pegged as much as they should be.
- # [22:51] <sicking> bmoss|2: i think we need more investigation to say how prevalent it will be
- # [22:51] <bmoss|2> not knowing what else can cause this is the scariest. I doubt the toolbar is the only "cause"
- # [22:51] <jlebar> gps: In fact, 8 cores provides almost no speedup over 4 cores in our build process.
- # [22:51] <gps> jlebar: I've seen that too, but they are pegged enough that I don't think half wall time would be possible
- # [22:51] <sicking> bent: could you kick off a tryserver build with the fix, just in case?
- # [22:51] <rnewman> gps: likely to be possible improvements in all kinds of places
- # [22:51] <jlebar> gps: So there's a lot of room for improvement. :)
- # [22:52] <rnewman> also, I'd love some kind of ccache for mobile builds
- # [22:52] <bent> sicking, well i don't have a fix yet... just a possible diagnosis
- # [22:52] <rnewman> (I believe the Android build chain doesn't use it)
- # [22:52] <sicking> bmoss|2: i think the bisecting that dmandalin is doing might provide data
- # [22:52] <jlebar> rnewman: --with-ccache in your mozconfig.
- # [22:52] <sicking> bent: we can't use the same mechanism as non-slim-wrappers?
- # [22:52] <jlebar> rnewman: Android is gcc, ccache works with gcc.
- # [22:52] * Joins: DGMurdockIII (dgmurdocki@moz-E933B63.hsd1.il.comcast.net)
- # [22:53] <bmoss|2> sicking: is that different than smichaud's
- # [22:53] * Joins: priya (priya@moz-BBE3ABD.mv.mozilla.com)
- # [22:53] <bmoss|2> I must have missed something
- # [22:53] <bent> sicking, yeah, it's more the mechanics of how we'll call into the runtimeservice
- # [22:53] <bent> different files, etc
- # [22:53] <bent> let me look
- # [22:53] <mwu> rnewman: ccache support in configure was added to speed up android builds
- # [22:54] <gps> rnewman: if it doesn't work, you can always set CC=ccache CXX=ccache in your .mozconfig
- # [22:54] <gps> rather hacky though
- # [22:54] <mwu> don't know if the build machines use them, but developers do
- # [22:55] <bent> sicking, is this on mozilla-release?
- # [22:55] <gps> CC='/usr/local/bin/ccache /usr/local/bin/clang' CXX='/usr/local/bin/ccache /usr/local/bin/clang++'
- # [22:55] <sicking> bmoss|2: oh, i think they're doing the same bisecting
- # [22:55] * liuche is now known as liuche|afk
- # [22:55] <gps> you didn't hear that from me b/c that is very hacky and isn't the right way to do it
- # [22:55] <sicking> bent: i would assume so
- # [22:56] <jlebar> gps: And that's not going to work for mobile builds. :)
- # [22:56] <sicking> johnath, bmoss|2: if we want to try a fix, we'll just pull mozilla-release and apply there? (not check in of course)
- # [22:58] <rnewman> mwu: do I still/also need --enable-ccache ?
- # [22:58] <jlebar> rnewman: --with-ccache.
- # [22:58] <mwu> rnewman: IIRC --with-ccache is enough
- # [22:58] * Joins: mayhemer (Miranda@B3D46202.F87A741B.F23860FD.IP)
- # [22:58] <mwu> and it'll just find ccache and do all the right things no matter what you're building for
- # [22:59] <mwu> as long as you're using gcc or clang
- # [22:59] * Quits: AutomatedTester (AutomatedT@moz-EF4205EF.as13285.net) (Quit: AutomatedTester)
- # [22:59] <rnewman> thanks, chaps!
- # [22:59] * Quits: Honza (chatzilla@E07BF19C.5BB5597D.D0083327.IP) (Ping timeout)
- # [22:59] * Joins: njn (chatzilla@32788AE8.60066DFE.8660782D.IP)
- # [23:01] * Quits: bjacob (bjacob@F2D29657.F60B0462.67AC9B1.IP) (Connection reset by peer)
- # [23:01] * Joins: bjacob (bjacob@F2D29657.F60B0462.67AC9B1.IP)
- # [23:04] <firebot> Check-in: http://hg.mozilla.org/mozilla-central/rev/3328809425d2 - Olli Pettay - Bug 711841, Null(C)String(), r=bsmedberg,glandium
- # [23:05] * Joins: brendan (brendaneic@moz-A286C218.hsd1.ca.comcast.net)
- # [23:05] * Quits: Unfocused (u2622@moz-160C58C6.com) (Max SendQ exceeded)
- # [23:05] * philor is now known as philor|away
- # [23:05] * Joins: Honza (chatzilla@E07BF19C.5BB5597D.D0083327.IP)
- # [23:06] * Joins: Unfocused (u2622@moz-160C58C6.com)
- # [23:06] <njn> memshrink meeting in 2 minutes
- # [23:06] * Quits: mgoodwin (mgoodwin@moz-4BB9E5E9.cable.virginmedia.com) (Ping timeout)
- # [23:07] * Quits: bjacob (bjacob@F2D29657.F60B0462.67AC9B1.IP) (Quit: Konversation terminated!)
- # [23:07] * Joins: bjacob (bjacob@F2D29657.F60B0462.67AC9B1.IP)
- # [23:07] * Joins: sheppy (sheppy@moz-F52A95D1.mycingular.net)
- # [23:07] * Joins: mgoodwin (mgoodwin@moz-4BB9E5E9.cable.virginmedia.com)
- # [23:08] * Joins: clee (clee@moz-BBE3ABD.mv.mozilla.com)
- # [23:08] * Quits: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP) (Ping timeout)
- # [23:08] * philor|away is now known as philor
- # [23:09] * Quits: clee (clee@moz-BBE3ABD.mv.mozilla.com) (Quit: clee)
- # [23:10] <sicking> smaug: where's the rev where you backed out strong-parent-pointer?
- # [23:10] * Joins: clee (clee@moz-BBE3ABD.mv.mozilla.com)
- # [23:10] <bent> also... why did we back that out in the first place?
- # [23:11] <smaug> sicking: what you mean?
- # [23:11] <bent> oh gc pause
- # [23:11] <smaug> bent: cc pause
- # [23:11] <bent> cc pause >= cc crash!
- # [23:11] <khuey> yeah
- # [23:11] <khuey> I agree
- # [23:11] <khuey> strong parent pointer has also been tested sufficiently imo
- # [23:12] <dholbert> looks like that backout was in https://bugzilla.mozilla.org/show_bug.cgi?id=708572#c8
- # [23:12] <smaug> it has been tested quite a bit
- # [23:12] * jmaher is now known as jmaher|afk
- # [23:12] <smaug> sicking: if I backout something, I put the code I backout to the bug
- # [23:12] * Joins: bmoss (bmoss@moz-BBE3ABD.mv.mozilla.com)
- # [23:13] * Quits: bmoss|2 (bmoss@moz-BBE3ABD.mv.mozilla.com) (Ping timeout)
- # [23:13] <smaug> so hg changeset and the patch in the bug are the same
- # [23:13] <sicking> smaug: ah, cool, thanks
- # [23:13] <sicking> smaug: so why did you back out the strong-parent-pointer? Were there actual issues?
- # [23:14] <smaug> see Bug 702813
- # [23:14] * Joins: rjohnson19 (rjohnson19@moz-9148485F.hsd1.ma.comcast.net)
- # [23:14] <smaug> sicking: what is worrying is that something else has changed in FF9
- # [23:15] <smaug> FF8 doesn't have strong parent node, and the crash doesn't happen there (at least not so often)
- # [23:17] * Quits: mgoodwin (mgoodwin@moz-4BB9E5E9.cable.virginmedia.com) (Ping timeout)
- # [23:18] <mccr8> sicking: it basically seems like on leaky pages, strong pointer makes it worse.
- # [23:19] <khuey> yeah
- # [23:19] <sicking> smaug: so strong parent pointers are still in 10?
- # [23:19] * Joins: mgoodwin (mgoodwin@moz-4BB9E5E9.cable.virginmedia.com)
- # [23:19] <khuey> but slow > crash
- # [23:19] <khuey> sicking: yes
- # [23:19] <sicking> mccr8: what do you mean by "leaky"?
- # [23:19] <mccr8> sicking: pages that creates DOM nodes that aren't in documents.
- # [23:20] <sicking> mccr8: yeah. That's the canonical case for why strong parent pointers are "bad"
- # [23:20] <smaug> sicking: yes
- # [23:20] * Quits: bsmith (bsmith@moz-364A0C3E.hsd1.ca.comcast.net) (Ping timeout)
- # [23:21] <sicking> smaug: do we have any other mitigations in 10 for the perf issue?
- # [23:22] <smaug> sicking: nope
- # [23:22] <sicking> ok
- # [23:22] <smaug> sicking: though, seems like 10 has some other regressions
- # [23:22] <smaug> related to CC/GC
- # [23:23] <bent> mrbkap, bug 711794 is holding up FF9
- # [23:23] <mrbkap> bent: is this the review that smaug sent me?
- # [23:23] <bent> mrbkap, see https://bugzilla.mozilla.org/show_bug.cgi?id=711794#c53 in particular
- # [23:24] <mrbkap> oh
- # [23:24] * Quits: bbondy (bbondy@moz-28CF6D1C.home.cgocable.net) (Ping timeout)
- # [23:24] <bent> but we need to figure out what changed since that bug has been there forever
- # [23:24] <bent> well
- # [23:24] <bent> 2 years
- # [23:24] <sicking> mccr8: peterv made a suggestion in one of the bugs to not cc-traverse nodes that have a black js-wrapper
- # [23:24] <sicking> mccr8: do you think that's something we could fix for FF10?
- # [23:24] <jlebar> Is test pilot installed by default in aurora or beta?
- # [23:24] * Quits: ashughes (ashughes@6202C507.852FE72D.DA78B690.IP) (Quit: ashughes)
- # [23:25] <mccr8> sicking: smaug has been looking into that a little, though his solution is a bit more complex than just doing that.
- # [23:25] <mccr8> sicking: it isn't clear exactly what that will help with or not.
- # [23:25] <smaug> sicking: I doubt just skipping black objects is enough
- # [23:25] <sicking> mccr8: what's the concern? I.e. why are we worried it might not help?
- # [23:25] <smaug> in many cases purple buffer has gray objects
- # [23:25] <bent> mrbkap, http://pastebin.mozilla.org/1413897 look ok?
- # [23:26] <sicking> smaug: in the case of irccloud it sounds like they are holding strong references to the actual JS objects. Wouldn't that make them black?
- # [23:26] <gavin> jlebar: yes
- # [23:26] <gavin> jlebar: in both
- # [23:26] <jlebar> gavin: thanks.
- # [23:26] * Quits: Sander (chatzilla@moz-B871F4D3.direct-adsl.nl) (Quit: And back he spurred like a madman, shrieking a curse to the sky.)
- # [23:26] <smaug> sicking: yes, there is some black object, but rest of the subtree can be gray
- # [23:26] <philikon> does printf() somehow not work when i call the code from xpcshell-tests ?
- # [23:27] <gavin> philikon: the harness redirects stdout IIRC
- # [23:27] <smaug> sicking: I have a patch which removes certainly black dom subtrees from CC
- # [23:27] <gavin> philikon: you need to check a .log file that gets created or something
- # [23:27] <philikon> gavin: yeah, but it should print it on --verbose
- # [23:27] <philikon> which is set by check-one
- # [23:27] <philikon> hmm ok
- # [23:27] <smaug> it is not that complicated, but would certainly need review from peterv
- # [23:27] <sicking> smaug: so i'm trying to figure out if there's anything that's safe enough that we can do it for 9
- # [23:28] * coop is now known as coop|afk
- # [23:28] * Joins: alexp (alexp@6BFC7CE9.2CABD6FE.22C20A9F.IP)
- # [23:28] <smaug> sicking: for 9 ?
- # [23:28] <sicking> smaug: yes
- # [23:28] <smaug> sicking: I guess you mean 10
- # [23:28] <sicking> smaug: no
- # [23:28] <smaug> for 9, no, we should not change CC handling
- # [23:28] <mrbkap> bent: I've *never* understood why we do an eager release if there's no rt.
- # [23:28] <smaug> either we backout the backout, or fix the actual bug
- # [23:28] * Joins: jhk (jiggy@8E6C34C1.A3F9767A.1C37C358.IP)
- # [23:28] <bent> smaug, you had no idea how crazy sicking was until this moment, did you? ;)
- # [23:28] <bent> mrbkap, i know...
- # [23:28] <dao> or skip 9 ;)
- # [23:29] <bent> mrbkap, but we do it everywhere else
- # [23:29] <sicking> dao: yes, that's definitely an option
- # [23:29] <sicking> dao: i'm trying to figure out what our options are
- # [23:29] <mrbkap> bent: yeah.
- # [23:29] <sicking> smaug: i think fixing the actual bug (i.e. that we're not deferring releases) would be higher risk than not traversing black objects
- # [23:30] <smaug> I still wonder what has changed in 9 to make this problem happen...
- # [23:30] <mrbkap> bent: r=me on that.
- # [23:30] <bent> ok!
- # [23:30] <khuey> making parent pointers strong again will cover up the bug and stick us with known consequences, right?
- # [23:30] * mrbkap agrees with sicking though.
- # [23:30] <khuey> that seems like the best option at the moment
- # [23:30] <bent> for sure
- # [23:30] <sicking> khuey: "that" being what?
- # [23:30] * Quits: mayhemer (Miranda@B3D46202.F87A741B.F23860FD.IP) (Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org)
- # [23:30] <bent> "who" is what
- # [23:31] <mccr8> we didn't see many actual cases of strong parent slowing down the CC. It seemed mostly like it was IRCcloud, which is allocating millions of orphan DOM nodes.
- # [23:31] <khuey> sicking: relanding strong parent pointer on 9
- # [23:31] <sicking> khuey: i agree
- # [23:31] <khuey> and respinning
- # [23:31] * catlee is now known as catlee-away
- # [23:31] <smaug> I think relanding sounds the safest option
- # [23:31] <sicking> mccr8: cool, that's good to know
- # [23:31] <bent> and i'll push this fix to trunk
- # [23:31] * davehunt is now known as davehunt|away
- # [23:32] <sicking> bent: awesome
- # [23:32] <mccr8> sicking: and it seems like a really leaky page, so hard to know.
- # [23:32] * Joins: bholley (bholley@moz-520BB7B.tmodns.net)
- # [23:32] * Parts: mgorse (mgorse@B6C068B2.2088E15E.A18F112A.IP)
- # [23:32] * armenzg is now known as armenzg_subway
- # [23:32] <khuey> bent: "this fix" being deferred release
- # [23:32] <bent> yes
- # [23:32] <mrbkap> yeah
- # [23:32] <smaug> is that really scary?
- # [23:32] <khuey> ok
- # [23:32] <bent> and if it works magically maybe we can do 10 & 11
- # [23:33] <khuey> bmoss: so we think we have a plan
- # [23:33] <smaug> bent: did you test whether it fixes the problem?
- # [23:33] <khuey> idk how much you'll like it
- # [23:33] <khuey> but we have a plan
- # [23:33] <bmoss> say more, I'm in a meeting about this right now
- # [23:33] <bent> smaug, it's going to fix a this specific problem
- # [23:33] <khuey> bmoss: we exposed this bug by backing out a change
- # [23:33] <khuey> bmoss: we think we should reland that change, respin, and ship
- # [23:34] <bent> releasing an element during gc
- # [23:34] <smaug> bent: right, but have you actually tested it ;)
- # [23:34] <khuey> bmoss: that change has had lots of testing (it was in 9 until b5 or so) and we understand what it does pretty well
- # [23:34] <bent> can't promise more than that
- # [23:34] <bent> no
- # [23:34] <bent> it's just clearly wrong
- # [23:35] <mccr8> kind of weird that non-strong-pointer would expose this, given that that is also old code.
- # [23:35] <khuey> mccr8: something else is clearly at work
- # [23:35] <smaug> yes, it is strange
- # [23:35] <mccr8> yeah
- # [23:35] <khuey> but strong parent pointer hides it for hte most part
- # [23:35] <smaug> something else has changed in 9
- # [23:35] <khuey> which is nice
- # [23:36] <bent> was brendan's patch not fingered correctly?
- # [23:36] <smaug> and btw, I hope someone else than mats also verifies that it is the strong parent node
- # [23:36] <sicking> smaug: can you prepare a patch to reland strong-pointers in FF9?
- # [23:36] * Joins: jdm (jdm@moz-9AEDE212.cpe.net.cable.rogers.com)
- # [23:37] <smaug> I have the patch for that in my beta tree
- # [23:37] <smaug> not sure which tree to use
- # [23:37] <brendan> bent: which brendan?
- # [23:37] <khuey> brendan: you brendan
- # [23:37] * Quits: armenzg_subway (armenzg@F2D29657.F60B0462.67AC9B1.IP) (Input/output error)
- # [23:37] <brendan> which patch?
- # [23:37] <khuey> brendan: https://bugzilla.mozilla.org/show_bug.cgi?id=711794#c50
- # [23:37] * Quits: sheppy (sheppy@moz-F52A95D1.mycingular.net) (Quit: Leaving)
- # [23:38] <brendan> bent: latent bug exposed?
- # [23:38] <khuey> brendan: most definitely
- # [23:39] <brendan> closure optimizations previously exposed latent finalization order dependency bugs in xpconnect
- # [23:39] <bent> seems logical at least
- # [23:39] * Quits: mgoodwin (mgoodwin@moz-4BB9E5E9.cable.virginmedia.com) (Ping timeout)
- # [23:40] <bent> so we have two backout options maybe
- # [23:40] * Joins: mgoodwin (mgoodwin@moz-4BB9E5E9.cable.virginmedia.com)
- # [23:40] * Boriss_ is now known as Boriss
- # [23:40] <khuey> potentially
- # [23:40] <khuey> I don't think anyone has tried to build without brendan's patch
- # [23:40] * Joins: janv (varga@moz-C1261AFF.flarion.as5628.telecom.sk)
- # [23:41] <bent> yeah
- # [23:41] <brendan> how about a fix instead of backout? ;-)
- # [23:41] <khuey> brendan: the fix is terrifying
- # [23:41] <bent> so far it sounds like it's only reproducible on os x?
- # [23:41] <bent> brendan, oh, the problem is that the fix could be dangerous
- # [23:41] <khuey> at least for chucking it into a release with no testing and shipping it
- # [23:41] <brendan> my fix is for an s-s bug
- # [23:42] <brendan> don't back it out lightly
- # [23:42] * Quits: TheOne (one@moz-E54CA067.dip.t-dialin.net) (Input/output error)
- # [23:42] <bent> no, we wouldn't
- # [23:42] <khuey> yeah
- # [23:42] <bent> just keeping options on table
- # [23:42] <khuey> is somebody in this meeting with bmoss and co?
- # [23:42] <smaug> can anyone access http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ ?
- # [23:42] <jprmc> khuey: yes
- # [23:43] * zpao is now known as zpao|detached
- # [23:43] <bent> smaug, timing out here...
- # [23:43] * Joins: merinui (merinui@moz-61C7235E.osk2.eonet.ne.jp)
- # [23:43] <jprmc> khuey: you can dial into warp core if you want
- # [23:43] <khuey> jprmc: ok, I'll do that
- # [23:43] * Joins: darktrojan (geoff@moz-BC95E278.dsl.telstraclear.net)
- # [23:44] <lurking_work> were the crashes in b5 ? Any consideration of just respinning on b5 for this release ?
- # [23:44] <khuey> smaug: no
- # [23:44] <khuey> it's not working for me
- # [23:44] * jgilbert|lunch is now known as jgilbert
- # [23:45] <khuey> jprmc: ok, I'm on the call, I can recap what we've determined here if you think that's useful
- # [23:45] <smaug> khuey: bent's fix?
- # [23:45] <khuey> smaug: no the ftp
- # [23:45] <bent> he meant ftp
- # [23:45] <smaug> ah
- # [23:45] <mbrubeck> lurking_work: That would lose some other crash fixes that landed for 9.0b6, like bug 709369
- # [23:45] * Quits: Waldo (waldo@moz-104CC309.mv.mozilla.com) (Quit: probably back later)
- # [23:45] <lurking_work> ahhh
- # [23:47] <smaug> who knows about ftp server?
- # [23:47] <NeilAway> smaug: who would know which button (if any) form.submit() submits?
- # [23:48] * Quits: mconley (mconley@F2D29657.F60B0462.67AC9B1.IP) (Input/output error)
- # [23:48] <smaug> NeilAway: don't remember
- # [23:48] <smaug> NeilAway: check what the spec says ;)
- # [23:49] <sicking> johnath, bmoss: I put a summary in the bug
- # [23:49] * Quits: rwaldron (rwaldron@moz-BDCCF091.hfc.comcastbusiness.net) (Quit: Leaving...)
- # [23:49] <NeilAway> smaug: couldn't find one :-(
- # [23:49] * Joins: billm (billm@moz-BBE3ABD.mv.mozilla.com)
- # [23:49] * Quits: stfl (stfl@moz-22F37930.hsi7.kabel-badenwuerttemberg.de) (Ping timeout)
- # [23:50] <NeilAway> smaug: or at least, not one which covered that point
- # [23:52] <sicking> bear-buildduty: should http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ still be working?
- # [23:53] <bear-buildduty> sicking - let me lok
- # [23:53] * Quits: florian (florian@moz-87C33FDA.kimsufi.com) (Quit: Instantbird 1.2a1pre)
- # [23:53] <bent> sicking, dinner time here, patch pushed to inbound
- # [23:53] <bent> bugs updated
- # [23:53] <sicking> bent: for slim-wrapper issue?
- # [23:53] * Quits: mccr8 (mccr8@moz-BBE3ABD.mv.mozilla.com) (Quit: mccr8)
- # [23:53] <bent> anything else you need from me in the next little bit?
- # [23:53] <bent> yes
- # [23:53] <sicking> holy moly, that was quick
- # [23:54] <sicking> thanks
- # [23:54] <bent> simple patch
- # [23:54] <sicking> no, i think that's it
- # [23:54] <bent> with totally unknowable consequences!
- # [23:54] <bmoss> sicking: thank you
- # [23:55] * Joins: diogogmt (kvirc@moz-4D628198.cpe.net.cable.rogers.com)
- # [23:56] * Quits: mgoodwin (mgoodwin@moz-4BB9E5E9.cable.virginmedia.com) (Input/output error)
- # [23:56] * Joins: willy1234x1 (willy1234x@moz-7A550E65.slkc.qwest.net)
- # [23:56] <bear-buildduty> sicking - i'm looking into that - it should be working AIUI
- # [23:56] <smaug> could someone push bent's patch to try using current beta repo
- # [23:56] <NeilAway> whoa, C-style casts ignore access control
- # [23:56] <philor> smaug: roll your own, and https://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/opettay@mozilla.com-c7bf93c5aa2c/ works
- # [23:56] <bent> smaug, i can, you want it on beta though?
- # [23:56] <bent> (not release?)
- # [23:57] <sicking> bear-buildduty: other ftp directories are working, but that one never responds
- # [23:57] * Joins: mccr8 (mccr8@moz-BBE3ABD.mv.mozilla.com)
- # [23:57] <bear-buildduty> yea, that's what i'm looking into
- # [23:57] <smaug> bent: I want someone to verify it fixes the problem
- # [23:57] <bear-buildduty> I do see a load warning from nagios - but double checking with ops folk
- # [23:57] <bent> smaug, right... but won't that be on mozilla-release?
- # [23:57] <smaug> bent: on trunk strong parent pointer hides the problem
- # [23:58] <smaug> bent: beta has the same code as release, I think
- # [23:58] <njn> edmorley: thanks for starring my try builds yesterday -- that's above and beyond the call of duty
- # [23:58] * Quits: mwu (mwu@moz-59435430.hsd1.nj.comcast.net) (Quit: This computer has gone to sleep)
- # [23:58] <bent> ok, well, i have both trees so i'll do both
- # [23:58] * Joins: karl (karl@538BABFE.A073F3E.97BBD552.IP)
- # [23:59] <edmorley> njn: :-)
- # Session Close: Wed Dec 21 00:00:00 2011
The end :)