/irc-logs / mozilla / #accessibility / 2015-07-22 / end

Options:

Previous day, Next day

  1. # Session Start: Wed Jul 22 00:00:00 2015
  2. # Session Ident: #accessibility
  3. # [00:17] * wlach is now known as wlach|afk
  4. # [00:28] * Quits: LJWatson (chatzilla@moz-fo6im4.leme.vk5s.0000.2620.IP) (Connection closed)
  5. # [00:31] * Joins: LJWatson (chatzilla@moz-1g9h1e.leme.vk5s.0000.2620.IP)
  6. # [00:48] * Quits: Justin_o (uid14648@moz-pd2b8l.charlton.irccloud.com) (Quit: Connection closed for inactivity)
  7. # [00:53] <@firebot> wkocher@mozilla.com changed the Resolution on bug 1185726 from --- to FIXED.
  8. # [00:53] <@firebot> wkocher@mozilla.com changed the Status on bug 1185726 from NEW to RESOLVED.
  9. # [00:53] <@firebot> wkocher@mozilla.com set status-firefox42 to fixed on bug 1185726.
  10. # [00:53] <@firebot> wkocher@mozilla.com changed the Target Milestone on bug 1185726 from --- to mozilla42.
  11. # [00:53] <@firebot> https://bugzil.la/1185726 — FIXED, tbsaunde+mozbugs@tbsaunde.org — Mysterious crashes in nsIFrame in Nightly 42
  12. # [01:12] * Joins: surkov (surkov@moz-v8g78c.cpe.teksavvy.com)
  13. # [01:12] * ChanServ sets mode: +o surkov
  14. # [01:18] * Joins: davidb (davidb@moz-6sj6p2.dsl.bell.ca)
  15. # [01:18] * ChanServ sets mode: +qo davidb davidb
  16. # [01:50] * Quits: LJWatson (chatzilla@moz-1g9h1e.leme.vk5s.0000.2620.IP) (Connection closed)
  17. # [02:03] * Quits: @surkov (surkov@moz-v8g78c.cpe.teksavvy.com) (Client exited)
  18. # [02:04] * Joins: surkov (surkov@moz-v8g78c.cpe.teksavvy.com)
  19. # [02:04] * ChanServ sets mode: +o surkov
  20. # [02:12] * Quits: ~davidb (davidb@moz-6sj6p2.dsl.bell.ca) (Quit: Blah blah blah)
  21. # [02:37] * Quits: satdav (uid15780@moz-avs1e8.highgate.irccloud.com) (Quit: Connection closed for inactivity)
  22. # [02:39] * Quits: @surkov (surkov@moz-v8g78c.cpe.teksavvy.com) (Client exited)
  23. # [02:40] <@firebot> New Core - Disability Access APIs bug 1186267 filed by ehsan@mozilla.com.
  24. # [02:40] <@firebot> https://bugzil.la/1186267 — NEW, nobody@mozilla.org — Add a keyboard shortcut for toggling the tab mute state
  25. # [02:47] * Quits: smaug (chatzilla@moz-omj15l.elisa-laajakaista.fi) (Ping timeout: 121 seconds)
  26. # [02:54] * Joins: surkov (surkov@moz-v8g78c.cpe.teksavvy.com)
  27. # [02:54] * ChanServ sets mode: +o surkov
  28. # [02:56] * Quits: alex_mayorga (uid4422@moz-39oq95.charlton.irccloud.com) (Quit: Connection closed for inactivity)
  29. # [03:11] * Quits: @surkov (surkov@moz-v8g78c.cpe.teksavvy.com) (Client exited)
  30. # [04:01] * Quits: gavin (gavin@irc.mozilla.org) (Ping timeout: 121 seconds)
  31. # [04:01] * Joins: gavin_ (gavin@irc.mozilla.org)
  32. # [04:05] * Joins: gavin (gavin@irc.mozilla.org)
  33. # [04:05] * Quits: gavin_ (gavin@irc.mozilla.org) (A TLS packet with unexpected length was received.)
  34. # [04:10] * Quits: gavin (gavin@irc.mozilla.org) (Connection closed)
  35. # [04:10] * Joins: gavin (gavin@irc.mozilla.org)
  36. # [09:44] * Joins: fredw (Icedove@moz-fv4cpk.abo.wanadoo.fr)
  37. # [11:29] * Joins: smaug (chatzilla@moz-omj15l.elisa-laajakaista.fi)
  38. # [11:30] * Quits: fredw (Icedove@moz-fv4cpk.abo.wanadoo.fr) (Client exited)
  39. # [12:30] * Joins: webatou (Thunderbird@moz-bf6ald.b7kb.8e10.2788.2a02.IP)
  40. # [12:52] * Quits: webatou (Thunderbird@moz-bf6ald.b7kb.8e10.2788.2a02.IP) (Client exited)
  41. # [13:12] * Quits: smaug (chatzilla@moz-omj15l.elisa-laajakaista.fi) (Ping timeout: 121 seconds)
  42. # [13:55] * Joins: smaug (chatzilla@moz-omj15l.elisa-laajakaista.fi)
  43. # [14:00] * Quits: smaug (chatzilla@moz-omj15l.elisa-laajakaista.fi) (Ping timeout: 121 seconds)
  44. # [14:14] * Joins: Justin_o (uid14648@moz-pd2b8l.charlton.irccloud.com)
  45. # [14:29] * Joins: smaug (chatzilla@moz-omj15l.elisa-laajakaista.fi)
  46. # [14:42] * Joins: davidb (davidb@moz-i5m.05u.207.66.IP)
  47. # [14:42] * ChanServ sets mode: +qo davidb davidb
  48. # [14:42] <~davidb> heyo
  49. # [14:43] * davidb is now known as davidb|afk
  50. # [14:48] * Joins: alex_mayorga (uid4422@moz-39oq95.charlton.irccloud.com)
  51. # [14:52] * davidb|afk is now known as davidb
  52. # [15:02] * wlach|afk is now known as wlach
  53. # [15:06] * Quits: smaug (chatzilla@moz-omj15l.elisa-laajakaista.fi) (Ping timeout: 121 seconds)
  54. # [15:20] * Joins: surkov (surkov@moz-v8g78c.cpe.teksavvy.com)
  55. # [15:20] * ChanServ sets mode: +o surkov
  56. # [15:28] * Joins: smaug (chatzilla@moz-omj15l.elisa-laajakaista.fi)
  57. # [15:45] * Quits: smaug (chatzilla@moz-omj15l.elisa-laajakaista.fi) (Ping timeout: 121 seconds)
  58. # [15:47] * Joins: smaug (chatzilla@moz-omj15l.elisa-laajakaista.fi)
  59. # [15:50] * Joins: anvk (anovak@moz-871.mvk.11.204.IP)
  60. # [15:55] * Quits: smaug (chatzilla@moz-omj15l.elisa-laajakaista.fi) (Ping timeout: 121 seconds)
  61. # [16:00] <@firebot> dbolter@mozilla.com changed the Assignee on bug 1185550 from nobody@mozilla.org to tbsaunde+mozbugs@tbsaunde.org.
  62. # [16:01] <@firebot> https://bugzil.la/1185550 — FIXED, tbsaunde+mozbugs@tbsaunde.org — crash in mozilla::a11y::DocAccessibleParent::AddChildDoc(mozilla::a11y::DocAccessibleParent*, unsign
  63. # [16:01] <@firebot> dbolter@mozilla.com changed the Assignee on bug 1159722 from nobody@mozilla.org to tbsaunde+mozbugs@tbsaunde.org.
  64. # [16:01] <@firebot> https://bugzil.la/1159722 — FIXED, tbsaunde+mozbugs@tbsaunde.org — make atk expose more interfaces for proxied accessibles
  65. # [16:02] <@firebot> dbolter@mozilla.com changed the Assignee on bug 1172053 from nobody@mozilla.org to tbsaunde+mozbugs@tbsaunde.org.
  66. # [16:02] <@firebot> https://bugzil.la/1172053 — FIXED, tbsaunde+mozbugs@tbsaunde.org — use malloc a little less when dispatching atk events
  67. # [16:02] <@firebot> dbolter@mozilla.com changed the Assignee on bug 1162621 from nobody@mozilla.org to tbsaunde+mozbugs@tbsaunde.org.
  68. # [16:02] <@firebot> https://bugzil.la/1162621 — FIXED, tbsaunde+mozbugs@tbsaunde.org — proxy Accessible::IndexOfEmbeddedChild
  69. # [16:02] <@firebot> dbolter@mozilla.com changed the Assignee on bug 1164976 from nobody@mozilla.org to tbsaunde+mozbugs@tbsaunde.org.
  70. # [16:03] <@firebot> https://bugzil.la/1164976 — FIXED, tbsaunde+mozbugs@tbsaunde.org — fire caret move and state change events for proxies[
  71. # [16:03] <@firebot> dbolter@mozilla.com changed the Assignee on bug 1155829 from nobody@mozilla.org to tbsaunde+mozbugs@tbsaunde.org.
  72. # [16:03] <@firebot> https://bugzil.la/1155829 — FIXED, tbsaunde+mozbugs@tbsaunde.org — Refactor atk hyperlink code
  73. # [16:03] <@firebot> dbolter@mozilla.com changed the Assignee on bug 1169376 from nobody@mozilla.org to tbsaunde+mozbugs@tbsaunde.org.
  74. # [16:03] <@firebot> https://bugzil.la/1169376 — FIXED, tbsaunde+mozbugs@tbsaunde.org — Allow getting the OuterDocAccessible for the tab's top level document
  75. # [16:03] <@firebot> dbolter@mozilla.com changed the Assignee on bug 1162543 from nobody@mozilla.org to tbsaunde+mozbugs@tbsaunde.org.
  76. # [16:03] <@firebot> https://bugzil.la/1162543 — FIXED, tbsaunde+mozbugs@tbsaunde.org — fixup getting accessibles from ids
  77. # [16:04] <@firebot> dbolter@mozilla.com changed the Assignee on bug 1164193 from nobody@mozilla.org to tbsaunde+mozbugs@tbsaunde.org.
  78. # [16:04] <@firebot> https://bugzil.la/1164193 — FIXED, tbsaunde+mozbugs@tbsaunde.org — emit a few more events on proxied accessibles for atk
  79. # [16:04] <@firebot> dbolter@mozilla.com changed the Assignee on bug 1151402 from nobody@mozilla.org to tbsaunde+mozbugs@tbsaunde.org.
  80. # [16:04] <@firebot> https://bugzil.la/1151402 — FIXED, tbsaunde+mozbugs@tbsaunde.org — make IAccessibleText and IAccessibleEditableText use proxies
  81. # [16:04] <@firebot> dbolter@mozilla.com changed the Assignee on bug 1168204 from nobody@mozilla.org to tbsaunde+mozbugs@tbsaunde.org.
  82. # [16:04] <@firebot> https://bugzil.la/1168204 — FIXED, tbsaunde+mozbugs@tbsaunde.org — Expose more interfaces to windows for proxied accessibles
  83. # [16:04] <@firebot> dbolter@mozilla.com changed the Assignee on bug 1159850 from nobody@mozilla.org to tbsaunde+mozbugs@tbsaunde.org.
  84. # [16:04] <@firebot> https://bugzil.la/1159850 — FIXED, tbsaunde+mozbugs@tbsaunde.org — make ia2Accessiblevalue use proxies
  85. # [16:05] <@firebot> dbolter@mozilla.com changed the Assignee on bug 1164135 from nobody@mozilla.org to tbsaunde+mozbugs@tbsaunde.org.
  86. # [16:05] <@firebot> https://bugzil.la/1164135 — FIXED, tbsaunde+mozbugs@tbsaunde.org — fix AtkHyperlink::GetStartIndex
  87. # [16:05] * Joins: clown (clown@moz-v6m.c3o.211.205.IP)
  88. # [16:05] <@firebot> dbolter@mozilla.com changed the Assignee on bug 1149772 from nobody@mozilla.org to tbsaunde+mozbugs@tbsaunde.org.
  89. # [16:05] <@firebot> https://bugzil.la/1149772 — FIXED, tbsaunde+mozbugs@tbsaunde.org — Make nsWinUtils::MaybeStartWindowEmulation and related code match our new plan for e10s a11y.
  90. # [16:08] <@firebot> dbolter@mozilla.com changed the Assignee on bug 1168202 from nobody@mozilla.org to tbsaunde+mozbugs@tbsaunde.org.
  91. # [16:08] <@firebot> https://bugzil.la/1168202 — FIXED, tbsaunde+mozbugs@tbsaunde.org — ia2AccessibleHyperlink::get_anchor needs to give the caller a reference to the anchor
  92. # [16:08] <@firebot> dbolter@mozilla.com changed the Assignee on bug 1159828 from nobody@mozilla.org to tbsaunde+mozbugs@tbsaunde.org.
  93. # [16:08] <@firebot> https://bugzil.la/1159828 — FIXED, tbsaunde+mozbugs@tbsaunde.org — make ia2Hyperlink use proxies
  94. # [16:08] <@firebot> dbolter@mozilla.com changed the Assignee on bug 1163070 from nobody@mozilla.org to tbsaunde+mozbugs@tbsaunde.org.
  95. # [16:08] <@firebot> https://bugzil.la/1163070 — FIXED, tbsaunde+mozbugs@tbsaunde.org — fix AtkHyperlinkImpl::getHyperlink after bug 1146518
  96. # [16:08] <@firebot> dbolter@mozilla.com changed the Assignee on bug 1146518 from nobody@mozilla.org to tbsaunde+mozbugs@tbsaunde.org.
  97. # [16:08] <@firebot> https://bugzil.la/1146518 — FIXED, tbsaunde+mozbugs@tbsaunde.org — Make AtkHyperlink to deal with IPC proxies
  98. # [16:09] <@firebot> dbolter@mozilla.com changed the Assignee on bug 1167604 from nobody@mozilla.org to tbsaunde+mozbugs@tbsaunde.org.
  99. # [16:09] <@firebot> https://bugzil.la/1167604 — FIXED, tbsaunde+mozbugs@tbsaunde.org — don't hide ProxyAccessible::Parent() with DocAccessibleParent::Parent
  100. # [16:09] <@firebot> dbolter@mozilla.com changed the Assignee on bug 1159741 from nobody@mozilla.org to tbsaunde+mozbugs@tbsaunde.org.
  101. # [16:09] <@firebot> https://bugzil.la/1159741 — FIXED, tbsaunde+mozbugs@tbsaunde.org — make ia2HyperText use proxies
  102. # [16:09] <@firebot> dbolter@mozilla.com changed the Assignee on bug 1173876 from nobody@mozilla.org to tbsaunde+mozbugs@tbsaunde.org.
  103. # [16:09] <@firebot> https://bugzil.la/1173876 — FIXED, tbsaunde+mozbugs@tbsaunde.org — make getText{At,After,Before}OffsetCB work with proxies
  104. # [16:10] <@firebot> dbolter@mozilla.com changed the Assignee on bug 1162654 from nobody@mozilla.org to tbsaunde+mozbugs@tbsaunde.org.
  105. # [16:10] <@firebot> https://bugzil.la/1162654 — FIXED, tbsaunde+mozbugs@tbsaunde.org — allow proxies to implement the document interface
  106. # [16:10] <@firebot> dbolter@mozilla.com changed the Assignee on bug 1023509 from nobody@mozilla.org to tbsaunde+mozbugs@tbsaunde.org.
  107. # [16:10] <@firebot> https://bugzil.la/1023509 — FIXED, tbsaunde+mozbugs@tbsaunde.org — only initialize platform accessibility in the main process
  108. # [16:10] <@firebot> dbolter@mozilla.com changed the Assignee on bug 1167358 from nobody@mozilla.org to tbsaunde+mozbugs@tbsaunde.org.
  109. # [16:10] <@firebot> https://bugzil.la/1167358 — FIXED, tbsaunde+mozbugs@tbsaunde.org — use ProxyAccessible::Parent() a little more
  110. # [16:14] <~davidb> firebot, you chatty
  111. # [16:14] <@firebot> davidb: Sorry, I've no idea what 'you chatty' might be.
  112. # [16:15] <@lsocks> firebot: fortune cookie?
  113. # [16:15] <@firebot> A successful man is one who makes more money than his wife can spend.
  114. # [16:19] * ~davidb puts a note in firebot's file
  115. # [16:19] * Joins: smaug (chatzilla@moz-omj15l.elisa-laajakaista.fi)
  116. # [16:38] * @tbsaunde looks up and fears the bug spam
  117. # [16:39] <~davidb> sorry - decided to rip the bandaid off
  118. # [16:43] * davidb is now known as davidb|afk
  119. # [16:44] * @tbsaunde shrugs if having that administrivia correct makes you happy somehow
  120. # [16:50] * Quits: smaug (chatzilla@moz-omj15l.elisa-laajakaista.fi) (Ping timeout: 121 seconds)
  121. # [16:50] <@firebot> New Core - Disability Access APIs bug 1186427 filed by lorien@lorienhu.com.
  122. # [16:50] * davidb|afk is now known as davidb
  123. # [16:50] <@firebot> https://bugzil.la/1186427 — NEW, nobody@mozilla.org — Add more checks to ensure that proxy tree structure is valid
  124. # [16:51] <@firebot> lorien@lorienhu.com changed the Assignee on bug 1186427 from nobody@mozilla.org to lorien@lorienhu.com.
  125. # [17:04] * Joins: fredw (Icedove@moz-fv4cpk.abo.wanadoo.fr)
  126. # [17:12] <@firebot> fred.wang@free.fr changed the Assignee on bug 1182469 from fred.wang@free.fr to nobody@mozilla.org.
  127. # [17:12] * Joins: mwcampbell (matt@moz-njddpp.ok.cox.net)
  128. # [17:12] <@firebot> https://bugzil.la/1182469 — NEW, nobody@mozilla.org — The mathvariant transformation is not visible in the accessible tree
  129. # [17:13] * Quits: mwcampbell (matt@moz-njddpp.ok.cox.net) (Quit: Leaving)
  130. # [17:14] <@tbsaunde> davidb: I guess the crash people are happier now?
  131. # [17:14] <~davidb> that'd be my guess
  132. # [17:14] <~davidb> all is silent in #crashkill :)
  133. # [17:14] <~davidb> but we need to stay in front of these crashes
  134. # [17:14] <@tbsaunde> davidb: well I suppose we don't have much data yet actually
  135. # [17:15] * ~davidb nods
  136. # [17:16] <@tbsaunde> davidb: well, I'm pretty close to turning the public bits of the dom fuzzer loose
  137. # [17:16] <@tbsaunde> hopefully that will find some test cases
  138. # [17:16] * ~davidb puts on his helmet
  139. # [17:28] * Joins: smaug (chatzilla@moz-omj15l.elisa-laajakaista.fi)
  140. # [17:40] <@firebot> tbsaunde+mozbugs@tbsaunde.org cancelled needinfo?(tbsaunde+mozbugs@tbsaunde.org) on bug 1173876.
  141. # [17:40] <@firebot> https://bugzil.la/1173876 — FIXED, tbsaunde+mozbugs@tbsaunde.org — make getText{At,After,Before}OffsetCB work with proxies
  142. # [17:42] <~davidb> tbsaunde, lsocks, do you guys want any new telemetry? (let me know if it comes up)
  143. # [17:48] <@tbsaunde> davidb: I don't think so? why?
  144. # [17:49] <~davidb> tbsaunde, just something to keep in mind
  145. # [17:56] <joanie> fredw: wrt the mathvariants, are you saying in the bug comment that Orca reads them with your patch (not committed), or in nightly?
  146. # [17:56] <fredw> joanie: with the patch
  147. # [17:57] <joanie> ok thanks!
  148. # [18:00] <fredw> surkov: tbsaunde: is there a bug entry about the fact that surrogate pairs / char + combining char should be treated as a single char or should I file a new bug?
  149. # [18:01] * clown is now known as clown_mtg
  150. # [18:01] <fredw> i.e. all of these should be treated as one char "A grave" when determining the char offset => A, &#x1D49C;, A&#x300, &#x1D49C&#x300
  151. # [18:03] <@firebot> New Core - Disability Access APIs bug 1186459 filed by eitan@monotonous.org.
  152. # [18:03] <@firebot> https://bugzil.la/1186459 — NEW, eitan@monotonous.org — [AccessFu] Automove after show when vc is position is dead
  153. # [18:03] <@firebot> eitan@monotonous.org changed the Assignee on bug 1186459 from nobody@mozilla.org to eitan@monotonous.org.
  154. # [18:05] <@tbsaunde> fredw: it might be responsible for an open bug, but I'm not aware of a bug specifically about that
  155. # [18:05] <@tbsaunde> fredw: that said I'm not sure how the text api should behave here
  156. # [18:05] * @tbsaunde -> food
  157. # [18:06] <fredw> tbsaunde: I think we asked Joanie and Jamie (private mails) and at least Jamie seems to agree for surrogate pairs.
  158. # [18:06] <joanie> fredw: I'm behind on email
  159. # [18:06] <joanie> also, there is code where Orca assumes a character is a character
  160. # [18:07] <joanie> and calls get_text rather than get_text_at_offset
  161. # [18:08] <fredw> joanie: what is a "character" in Python. Is a surrogate pairs one character or two characters?
  162. # [18:08] <joanie> fredw: in a meeting now
  163. # [18:08] <joanie> can we talk later?
  164. # [18:09] <fredw> joanie: yes no problem. I'll log off soon anyway.
  165. # [18:13] * Quits: fredw (Icedove@moz-fv4cpk.abo.wanadoo.fr) (Connection closed)
  166. # [18:14] * davidb is now known as davidb|afk
  167. # [18:17] * davidb|afk is now known as davidb
  168. # [18:57] * davidb is now known as davidb|afk
  169. # [19:03] * davidb|afk is now known as davidb
  170. # [19:41] * Joins: satdav (uid15780@moz-avs1e8.highgate.irccloud.com)
  171. # [19:59] <@tbsaunde> smaug: so are you looking for stuff to do yet?
  172. # [20:05] <smaug> tbsaunde: I'm looking for to be on vacation ;)
  173. # [20:05] <smaug> until Sunday at least
  174. # [20:06] <@tbsaunde> smaug: oh, you don't seem to be doing a good job of that ;p
  175. # [20:08] * smaug would be less online if the weather in Finland was a bit nicer this summer. It is like we missed the whole summer. First autumn storm coming on Sunday and it has been raining all the time anyhow. But probably traveling to Central Europe at some point.
  176. # [20:21] <@firebot> New Core - Disability Access APIs bug 1186528 filed by dbolter@mozilla.com.
  177. # [20:21] <@firebot> https://bugzil.la/1186528 — NEW, nobody@mozilla.org — crash in mozalloc_abort(char const* const) | NS_DebugBreak | mozilla::a11y::PDocAccessible::Transiti
  178. # [20:32] <~davidb> sorry just want to get bugs filed for some crashes that appear on a crashkill report
  179. # [20:32] <@firebot> New Core - Disability Access APIs bug 1186536 filed by dbolter@mozilla.com.
  180. # [20:32] <@firebot> https://bugzil.la/1186536 — NEW, nobody@mozilla.org — crash in mozilla::a11y::Accessible::HasGenericType(mozilla::a11y::AccGenericType)
  181. # [20:32] <~davidb> and maybe they'll be interesting or spark ideas
  182. # [20:35] * Quits: smaug (chatzilla@moz-omj15l.elisa-laajakaista.fi) (Ping timeout: 121 seconds)
  183. # [20:36] <~davidb> tbsaunde, did you intend me as reviewer (or lsocks)? on bug 1185122
  184. # [20:36] <@firebot> https://bugzil.la/1185122 — NEW, nobody@mozilla.org — Assertion failure in -[mozRootAccessible representedView] "can't return root accessible's native par
  185. # [20:37] <@tbsaunde> davidb: I think a third opinion might be nice
  186. # [20:37] <~davidb> okee
  187. # [20:38] <~davidb> tbsaunde, did we ever have root accessibles per tab pre e10s?
  188. # [20:41] <~davidb> i suppose in windows emulation mode maybe
  189. # [20:41] <~davidb> (window per tab)
  190. # [20:41] <@tbsaunde> davidb: we used to have them for xul windows only afaik
  191. # [20:41] <@tbsaunde> so you'd get a normal DocAccessible for the top level content document
  192. # [20:41] <~davidb> k
  193. # [20:42] <@tbsaunde> if you look at what RootAccessible does its mostly xul crap
  194. # [20:53] <~davidb> tbsaunde, does "if (XRE_IsParentProcess())" succeed in non-e10s?
  195. # [20:54] <@tbsaunde> davidb: I would expect so
  196. # [20:54] <~davidb> k wasn't sure
  197. # [20:55] <~davidb> yeah we use this pattern elsewhere
  198. # [20:56] <~davidb> !8ball
  199. # [20:56] * ~davidb slaps firebot
  200. # [20:56] * @firebot fights back
  201. # [20:57] <~davidb> !8ball will the patch work?
  202. # [20:57] <@firebot> davidb: It shall be.
  203. # [20:59] <~davidb> tbsaunde, don't forget to add r=firebot
  204. # [21:01] <@tbsaunde> davidb: joking?
  205. # [21:03] <~davidb> yes :)
  206. # [21:04] <~davidb> i almost nitted about adding a comment but the if else if else block is sort of self documenting
  207. # [21:04] <~davidb> lgtm
  208. # [22:02] * Joins: smaug (chatzilla@moz-omj15l.elisa-laajakaista.fi)
  209. # [22:08] * Quits: ~davidb (davidb@moz-i5m.05u.207.66.IP) (Quit: Blah blah blah)
  210. # [22:56] * Joins: davidb (davidb@moz-6sj6p2.dsl.bell.ca)
  211. # [22:56] * ChanServ sets mode: +qo davidb davidb
  212. # [22:57] * Quits: clown_mtg (clown@moz-v6m.c3o.211.205.IP) (Quit: Leaving.)
  213. # [23:08] * Quits: anvk (anovak@moz-871.mvk.11.204.IP) (Quit: Leaving.)
  214. # [23:11] * Quits: @surkov (surkov@moz-v8g78c.cpe.teksavvy.com) (Client exited)
  215. # [23:16] * Quits: ~davidb (davidb@moz-6sj6p2.dsl.bell.ca) (Quit: Blah blah blah)
  216. # [23:55] * Joins: surkov (surkov@moz-v8g78c.cpe.teksavvy.com)
  217. # [23:55] * ChanServ sets mode: +o surkov
  218. # Session Close: Thu Jul 23 00:00:00 2015

Previous day, Next day

Think these logs are useful? Then please donate to show your gratitude (and keep them up, of course). Thanks! — Krijn