/irc-logs / mozilla / #accessibility / 2015-08-04 / end
Options:
Previous day, Next day
- # Session Start: Tue Aug 04 00:00:00 2015
- # Session Ident: #accessibility
- # [01:41] * Quits: alex_mayorga (uid4422@moz-lffp2u.ealing.irccloud.com) (Quit: Connection closed for inactivity)
- # [01:57] * Quits: smaug (chatzilla@moz-ef8gi3.bb.dnainternet.fi) (Ping timeout: 121 seconds)
- # [04:18] * Quits: satdav (uid15780@moz-sljh5r.tooting.irccloud.com) (Quit: Connection closed for inactivity)
- # [05:07] * Joins: fxa90id (fxa90id@moz-0gilgp.l3aj.nhs4.0647.2601.IP)
- # [06:30] * Quits: fxa90id (fxa90id@moz-0gilgp.l3aj.nhs4.0647.2601.IP) (Ping timeout: 121 seconds)
- # [07:14] * Joins: fxa90id (fxa90id@moz-0gilgp.l3aj.nhs4.0647.2601.IP)
- # [08:17] * Joins: ioanachiorean (ioanachiore@moz-q23.52n.2.5.IP)
- # [08:18] * Quits: fxa90id (fxa90id@moz-0gilgp.l3aj.nhs4.0647.2601.IP) (Ping timeout: 121 seconds)
- # [09:55] * Joins: fredw (Icedove@moz-fv4cpk.abo.wanadoo.fr)
- # [10:05] * Joins: satdav (uid15780@moz-sljh5r.tooting.irccloud.com)
- # [10:48] * Joins: Gijs (chatzilla@moz-v0lust.cable.virginm.net)
- # [12:34] * Quits: fredw (Icedove@moz-fv4cpk.abo.wanadoo.fr) (Client exited)
- # [13:13] * st3fan_pto is now known as st3fan
- # [14:17] * Joins: surkov (surkov@moz-v8g78c.cpe.teksavvy.com)
- # [14:17] * ChanServ sets mode: +o surkov
- # [14:26] * Joins: Justin_o (uid14648@moz-c6vipl.ealing.irccloud.com)
- # [14:29] * Joins: sixtyten (quassel@moz-ulpjmu.sentoris.de)
- # [14:35] * Quits: @surkov (surkov@moz-v8g78c.cpe.teksavvy.com) (Client exited)
- # [14:46] * Joins: anvk (anovak@moz-871.mvk.11.204.IP)
- # [15:45] * Joins: davidb (davidb@moz-i5m.05u.207.66.IP)
- # [15:45] * ChanServ sets mode: +qo davidb davidb
- # [15:45] <~davidb> heyo
- # [15:48] <&MarcoZ> Heyo davidb!
- # [16:01] * Joins: yzen (yzen@moz-i5m.05u.207.66.IP)
- # [16:01] * ChanServ sets mode: +o yzen
- # [16:02] <@firebot> guijoselito@gmail.com requested needinfo from tbsaunde+mozbugs@tbsaunde.org on bug 1185726.
- # [16:02] <@firebot> https://bugzil.la/1185726 — FIXED, tbsaunde+mozbugs@tbsaunde.org — Mysterious crashes in nsIFrame in Nightly 42
- # [16:05] * davidb is now known as davidb|afk
- # [16:06] * Joins: fxa90id (fxa90id@moz-0gilgp.l3aj.nhs4.0647.2601.IP)
- # [16:16] * Quits: fxa90id (fxa90id@moz-0gilgp.l3aj.nhs4.0647.2601.IP) (A TLS packet with unexpected length was received.)
- # [16:23] <@firebot> guijoselito@gmail.com cancelled needinfo?(tbsaunde+mozbugs@tbsaunde.org) on bug 1185726.
- # [16:23] <@firebot> https://bugzil.la/1185726 — FIXED, tbsaunde+mozbugs@tbsaunde.org — Mysterious crashes in nsIFrame in Nightly 42
- # [16:31] * davidb|afk is now known as davidb
- # [16:32] * davidb is now known as davidb|afk
- # [16:32] * davidb|afk is now known as davidb
- # [16:32] * davidb is now known as davidb|afk
- # [17:07] <@firebot> New Core - Disability Access APIs bug 1190882 filed by jdiggs@igalia.com.
- # [17:07] <@firebot> https://bugzil.la/1190882 — NEW, nobody@mozilla.org — No accessibility events for re-focused object after ARIA dialog dismissed
- # [17:08] * davidb|afk is now known as davidb
- # [17:08] * wlach|afk is now known as wlach
- # [17:28] <~davidb> tbsaunde, groan
- # [17:28] * ~davidb goes to crash-stats
- # [17:32] <~davidb> tbsaunde, found an example of each, and commented
- # [17:37] <@tbsaunde> davidb: did you check build id each happened with?
- # [17:48] <~davidb> tbsaunde, sorry was chatting IRL. I was checking Aug 3 nightly
- # [17:49] <~davidb> tbsaunde, 20150803030207
- # [17:51] * Joins: surkov (surkov@moz-v8g78c.cpe.teksavvy.com)
- # [17:51] * ChanServ sets mode: +o surkov
- # [17:52] <@tbsaunde> davidb: ok so we can conclude RecvHideEvent sometimes screws up the tree, but maybe something else can two I wonder what
- # [17:54] <@tbsaunde> anyone interested in going out to get food likely with meat?
- # [17:54] <~davidb> i'm actually good with lentils
- # [17:55] <@lsocks> meatless tuesday doesn't even alliterate
- # [17:55] <~davidb> lol. I wouldn't mind skipping meatballs tomorrow
- # [17:55] * @tbsaunde suspects that one will actually be pretty ok
- # [17:56] <~davidb> i need to WFH thurs/fri
- # [17:59] <joanie> MarcoZ: I don't understand your comment. Are you saying the test case (which I lifted from the WCAG wiki) is bogus? Or something else? Related aside, that test case is to replicate the same bug seen in the wild on a site.
- # [17:59] * Joins: smaug (chatzilla@moz-ef8gi3.bb.dnainternet.fi)
- # [18:03] <~davidb> Gijs, it sounded like you offered to set up a meeting for bug 670928 ?
- # [18:03] <@firebot> https://bugzil.la/670928 — REOPENED, eitan@monotonous.org — HTML5 element and WAI-ARIA landmark roles easily navigable in Firefox
- # [18:03] <~davidb> that sounds good to me
- # [18:04] <~davidb> going AFK for lunch
- # [18:04] * davidb is now known as davidb|afk
- # [18:04] <&MarcoZ> Joanie, the principle is correct, the test file is just broken/has coding snafnafus.
- # [18:04] <joanie> MarcoZ: broken enough to interfere with fixing the bug?
- # [18:05] <&MarcoZ> Off work now.
- # [18:05] <joanie> ?
- # [18:06] <&MarcoZ> Broken enough to yield bogus results.
- # [18:06] <joanie> heh
- # [18:08] <&MarcoZ> Correct dialog impls exist and fire correct a11y events. Google, FB, Twitter.
- # [18:08] <joanie> I'm seeing the same issue on a blog and without the errors you cite
- # [18:09] <joanie> but the a11y events I want are from the document frame and link
- # [18:09] <joanie> at least
- # [18:09] <joanie> the firefox window too
- # [18:09] <joanie> I actually get the expected events from the ARIA dialog
- # [18:14] <joanie> aha, I see the errors I'll fix those
- # [18:20] <Gijs> davidb|afk: I'd like to discuss that bug with you before deciding who to set up a meeting with, I think
- # [18:21] <Gijs> davidb|afk: can you ping me when you get back? (in a mtg myself right now)
- # [18:38] * Quits: ioanachiorean (ioanachiore@moz-q23.52n.2.5.IP) (Ping timeout: 121 seconds)
- # [18:44] * davidb|afk is now known as davidb
- # [18:45] <~davidb> Gijs, back.
- # [18:50] * Quits: sixtyten (quassel@moz-ulpjmu.sentoris.de) (Ping timeout: 121 seconds)
- # [19:04] <@firebot> gavin.sharp@gmail.com changed the Resolution on bug 1187282 from --- to DUPLICATE.
- # [19:04] <@firebot> gavin.sharp@gmail.com changed the Status on bug 1187282 from NEW to RESOLVED.
- # [19:04] <@firebot> https://bugzil.la/1187282 — DUPLICATE, nobody@mozilla.org — Ctrl+k no longer focuses search bar if location bar or an in-page input element is currently focused
- # [19:40] * davidb is now known as davidb|afk
- # [19:49] * mconley is now known as mconley|food
- # [19:59] * davidb|afk is now known as davidb
- # [20:03] * Gijs is now known as Gijs_away
- # [20:10] * Quits: ~davidb (davidb@moz-i5m.05u.207.66.IP) (Connection closed)
- # [20:11] * Joins: davidb (davidb@moz-i5m.05u.207.66.IP)
- # [20:11] * ChanServ sets mode: +qo davidb davidb
- # [20:21] <@lsocks> surkov: do you know how I might be able to ignore a dup reorder event? I'm trying to fix broken tests in the patch for bug 1175913 in test_textleaf and I get 2 reorders. One is from recreating on listener change, and the other called directly from JS on an attribute change
- # [20:21] <@firebot> https://bugzil.la/1175913 — NEW, lorien@lorienhu.com — Crash in mozilla::a11y::DocAccessibleParent::RemoveAccessible(ProxyAccessible* aAccessible)
- # [20:21] <@lsocks> this is in the setOnClickNRoleAttrs test where it sets both role and onclick
- # [20:23] <@surkov> lsocks: having them both in the queue doens’t help?
- # [20:24] <@surkov> otherwise you may want to add a new flag into events.js to not fail for duping (aka todo option)
- # [20:27] <@lsocks> it still fails if the event sequence has 2 reorders expected
- # [20:35] * wlach is now known as wlach|mtg
- # [20:53] * mconley|food is now known as mconley
- # [21:00] <@tbsaunde> surkov: can you explain https://bugzilla.mozilla.org/show_bug.cgi?id=545465#c11 ?
- # [21:00] <@firebot> Bug 545465 — FIXED, surkov.alexander@gmail.com — clean up the code of accessible initialization and binding to the tree
- # [21:01] <@surkov> tbsaunde: which part?
- # [21:04] <@tbsaunde> surkov: the whole thing? I don't see what the point of changing both role and onlcik attributes is
- # [21:06] <@surkov> tbsaunde: I can do interpretation I guess, I’m not sure if that’s applicable to current behavior though. If @onclick is changed then the whole tree is recreated, in case of setting @role we create new accessible and adopt a subtree
- # [21:08] <@tbsaunde> surkov: but isn't recreation not supposed to happen
- # [21:08] <@surkov> tbsaunde: it seems it happens, at least to keep things updated
- # [21:08] <@tbsaunde> surkov: besides which that's not what we do, we recreate whole tree for role change accept document case
- # [21:09] <@tbsaunde> surkov: sure, but I'm interested in what happens in correct behavior, not the result of bugs
- # [21:11] <@surkov> about @role: I think that was a case when inaccessible node gets accessible, so there’s nothing to recreate here
- # [21:15] <@tbsaunde> surkov: I don't understnad how that answers the question
- # [21:15] <@surkov> tbsaunde: which one?
- # [21:16] <@tbsaunde> surkov: what is the point of test_textleaf.html changing both role and onclick at the same time
- # [21:17] <@lsocks> also whether that test is still useful given that it currently just calls recreateaccessible twice
- # [21:20] <@surkov> tbsaunde: I guess it’s supposed to test that new accessible is created and it gets text accessible that has linkable state
- # [21:22] <@surkov> I’m not sure what happens internally, perhaps accessible is created, it adopts kids, then the subtree including new accessible is recreated
- # [21:22] <@surkov> or if 2nd is not true, then it just updates actions
- # [21:23] <@tbsaunde> surkov: but why is that any different from just testing setting onclick
- # [21:25] <@surkov> on inaccessible node? that may be quite close if not the same
- # [21:27] <@tbsaunde> surkov: well, presumably there is some reason the test was written the way it is?
- # [21:30] * wlach|mtg is now known as wlach
- # [21:34] <@surkov> tbsaunde: that was years ago, but in general not trivial tests make sense
- # [21:37] <@tbsaunde> surkov: I guess, but I'm not sure it makes sense to have tests that do random slightly nontrivial things with no clear logic as to why
- # [21:38] <@surkov> why not, as long as you know it produces correct output
- # [21:41] <@tbsaunde> surkov: well, you need to define "correct" and its nice to be able to reason about if changes to it are meaningful or not
- # [21:43] <@surkov> gecko’s tree update code is not trivial, thus having a richer set of tests (including crazy tests) is better for us, in this case “correct” means we know the accessible is created and text leaf has wanted states
- # [21:47] * Joins: alex_mayorga (uid4422@moz-lffp2u.ealing.irccloud.com)
- # [21:47] * Gijs_away is now known as Gijs
- # [21:47] * Quits: Gijs (chatzilla@moz-v0lust.cable.virginm.net) (Quit: poof)
- # [22:16] * Quits: anvk (anovak@moz-871.mvk.11.204.IP) (Quit: Leaving.)
- # [22:20] <@firebot> lorien@lorienhu.com changed the Assignee on bug 1189108 from nobody@mozilla.org to lorien@lorienhu.com.
- # [22:20] <@firebot> https://bugzil.la/1189108 — NEW, lorien@lorienhu.com — LinkableAccessible actionable parent and action count return wrong result when event listeners are c
- # [22:43] * Quits: ~davidb (davidb@moz-i5m.05u.207.66.IP) (Quit: Blah blah blah)
- # [23:09] * Quits: @yzen (yzen@moz-i5m.05u.207.66.IP) (Ping timeout: 121 seconds)
- # [23:35] * Joins: kkus (kkus@moz-oqbbml.fios.verizon.net)
- # [23:49] * Quits: Justin_o (uid14648@moz-c6vipl.ealing.irccloud.com) (Quit: Connection closed for inactivity)
- # Session Close: Wed Aug 05 00:00:00 2015
Previous day, Next day
Think these logs are useful? Then please donate to show your gratitude (and keep them up, of course). Thanks! — Krijn