/irc-logs / mozilla / #accessibility / 2015-08-29 / end

Options:

Previous day, Next day

  1. # Session Start: Sat Aug 29 00:00:00 2015
  2. # Session Ident: #accessibility
  3. # [00:00] * Quits: Gijs (chatzilla@moz-v0lust.cable.virginm.net) (Quit: sleep + pto - see you in september!)
  4. # [00:39] * Quits: zippo^ (Zippo@moz-73oup6.ip.telfort.nl) (Quit: Leaving)
  5. # [00:42] * Joins: yzen (yzen@moz-ql1r6k.cpe.pppoe.ca)
  6. # [00:42] * ChanServ sets mode: +o yzen
  7. # [00:48] * Joins: zippo^ (Zippo@moz-73oup6.ip.telfort.nl)
  8. # [01:16] <smaug> tbsaunde: you there?
  9. # [01:16] <smaug> I don't understand when one can get AtkObject from AtkComponent
  10. # [01:16] <smaug> and when AtkSocket
  11. # [01:24] <@tbsaunde> smaug: one minute
  12. # [01:26] <@tbsaunde> smaug: well so the way gobject does inheritnace an AtkSocket is a AtkObject
  13. # [01:26] <smaug> ahaa
  14. # [01:26] <smaug> I see
  15. # [01:26] <smaug> ATK_OBJECT(AtkSocket)
  16. # [01:27] <smaug> tbsaunde: and MAI_ATK_SOCKET(aComponent)->accWrap == GetAccessibleWrap(ATK_OBJECT(MAI_ATK_SOCKET(aComponent))) ?
  17. # [01:30] <smaug> I guess I could add some assertion for that
  18. # [01:30] <@tbsaunde> smaug: I don't think you can do GetAtkObject(ATK_OBJECT(MAI_ATK_SOCKET())) because GetAtkObject() relies on the object being a different subclass of AtkObject
  19. # [01:31] <smaug> tbsaunde: you mean GetAccessibleWrap?
  20. # [01:31] <@tbsaunde> smaug: yes sorry
  21. # [01:32] <smaug> hmm, I don't then understand the setup
  22. # [01:32] <smaug> I haev AtkObject, but I can't pass it to GetAccessibleWrap which takes AtkObject as a param
  23. # [01:32] <@tbsaunde> my first reaction is to just not care about AtkSocket that's only used for accessible plugins which there are afaik 0 of
  24. # [01:32] <smaug> s/haev/have/
  25. # [01:33] <smaug> well, AtkSocket code happens to use the code I'm modifying
  26. # [01:33] <smaug> but I guess I can do this differently
  27. # [01:33] <smaug> somehow...
  28. # [01:33] <smaug> hmm
  29. # [01:34] <smaug> I don't have the wrapper
  30. # [01:34] <@tbsaunde> smaug: well, you could just modify the stuff in nsMaiComponent that calls those helpers
  31. # [01:34] <@tbsaunde> smaug: yeah, GetAccessibleWrap downcasts to MaiAtkObject*
  32. # [01:34] <smaug> tbsaunde: well, the helpers take wrapper
  33. # [01:34] <smaug> and I'd like to be able to pass AtkObject
  34. # [01:35] <@tbsaunde> smaug: I'm not sure I understand
  35. # [01:35] * yzen is now known as yzen_
  36. # [01:36] <smaug> tbsaunde: the helper methods in nsMaiComponent take AccessibleWrap objects as params
  37. # [01:36] <smaug> but I don't have such in case of proxies
  38. # [01:36] <smaug> so, I'd like to change the helper to take AtkObject as param
  39. # [01:36] <@tbsaunde> smaug: oh, so I think I'm suggesting you leave the helpers alone and just modify the things that call them
  40. # [01:36] <smaug> and then inside the helper either access wrapper or proxy
  41. # [01:37] <smaug> hmm
  42. # [01:37] <smaug> that would be a bit weird
  43. # [01:37] <@tbsaunde> smaug: yeah kind of I guess
  44. # [01:37] <smaug> but sure, one option
  45. # [01:39] <@tbsaunde> smaug: ok let me think about what we might do with this socket stuff
  46. # [01:39] * Quits: @yzen_ (yzen@moz-ql1r6k.cpe.pppoe.ca) (Ping timeout: 121 seconds)
  47. # [01:39] <smaug> tbsaunde: why does GetAccessibleWrap need to care about MaiAtkObject ?
  48. # [01:40] <smaug> socket stuff has also accWrap set
  49. # [01:40] <smaug> hmm, should GetAccessibleWrap support also AtkSocket
  50. # [01:40] <smaug> not only MaiAtkObject
  51. # [01:40] <smaug> I guess that setup would work here
  52. # [01:43] <smaug> yeah, I'll do it that way
  53. # [01:43] <@tbsaunde> smaug: both MaiAtkObject and MaiAtkSocket have accWrap members, but they are at different offsets
  54. # [01:43] <smaug> oh, crap
  55. # [01:43] <smaug> hm
  56. # [01:43] <smaug> doesn't matter
  57. # [01:43] <smaug> actually
  58. # [01:43] <@tbsaunde> smaug: you could still do this
  59. # [01:44] <smaug> tbsaunde: I would just make GetAccessibleWrap have on code path for MaiAtkObject, and one for MaiAtkSocket
  60. # [01:44] <@tbsaunde> you'd just do if (MAI_IS_ATK_SOCKET()) MIA_ATK_SOCKET()->accWrap else MAI_ATK_OBJECT()->accWrap
  61. # [01:44] <smaug> right
  62. # [01:44] <@tbsaunde> accept I think you'd want to reverse that because MaiAtkObject is far more common
  63. # [01:45] <smaug> and then if GetAccessibleWrap can deal with both types, the helper methods in nsMaiComponent can take AtkObject and try to access the wrapper there
  64. # [01:45] <@tbsaunde> you'd make the case that its not eitherslightly slower but I doubt it really matters
  65. # [01:45] <smaug> and if not wrapper, try to access procy
  66. # [01:45] <smaug> proxy
  67. # [01:46] <smaug> ok, I think that works
  68. # [01:46] <smaug> thanks
  69. # [01:46] <smaug> but getting late here now
  70. # [01:46] <@tbsaunde> smaug: np
  71. # [01:47] <@tbsaunde> smaug: yeah, and fwiw I could probably live with killing the socket stuff if necessary
  72. # [01:48] <@tbsaunde> it hasn't been in anyone's way before, so I've just figured might as well wait and let it be well and truelly dead before rming
  73. # [01:51] * Quits: smaug (chatzilla@moz-kn7naf.elisa-laajakaista.fi) (Ping timeout: 121 seconds)
  74. # [01:58] * Joins: erkan^ (zippo@moz-73oup6.ip.telfort.nl)
  75. # [02:03] * Joins: satdav (uid15780@moz-sljh5r.tooting.irccloud.com)
  76. # [02:40] * Joins: surkov (surkov@moz-an5vm5.cable.teksavvy.com)
  77. # [02:40] * ChanServ sets mode: +o surkov
  78. # [02:41] * stephend is now known as stephend|offline
  79. # [02:56] * Quits: erkan^ (zippo@moz-73oup6.ip.telfort.nl) (Quit: My Mac has gone to sleep. ZZZzzz…)
  80. # [03:00] * Quits: @surkov (surkov@moz-an5vm5.cable.teksavvy.com) (Client exited)
  81. # [03:02] * wlach is now known as wlach|afk
  82. # [03:37] * Joins: erkan^ (zippo@moz-73oup6.ip.telfort.nl)
  83. # [04:14] * Joins: surkov (surkov@moz-an5vm5.cable.teksavvy.com)
  84. # [04:14] * ChanServ sets mode: +o surkov
  85. # [04:36] * Quits: alex_mayorga (uid4422@moz-lffp2u.ealing.irccloud.com) (Quit: Connection closed for inactivity)
  86. # [04:38] * Joins: yzen (yzen@moz-ql1r6k.cpe.pppoe.ca)
  87. # [04:38] * ChanServ sets mode: +o yzen
  88. # [04:38] * Quits: satdav (uid15780@moz-sljh5r.tooting.irccloud.com) (Quit: Connection closed for inactivity)
  89. # [05:09] * yzen is now known as yzen_
  90. # [05:10] * yzen_ is now known as yzen
  91. # [05:13] * yzen is now known as yzen_
  92. # [05:17] * Quits: @yzen_ (yzen@moz-ql1r6k.cpe.pppoe.ca) (Ping timeout: 121 seconds)
  93. # [05:35] * Quits: @surkov (surkov@moz-an5vm5.cable.teksavvy.com) (Ping timeout: 121 seconds)
  94. # [05:38] * Joins: surkov (surkov@moz-an5vm5.cable.teksavvy.com)
  95. # [05:38] * ChanServ sets mode: +o surkov
  96. # [05:41] * Quits: @surkov (surkov@moz-an5vm5.cable.teksavvy.com) (Client exited)
  97. # [06:32] <@firebot> New Core - Disability Access APIs bug 1199884 filed by eitan@monotonous.org.
  98. # [06:32] <@firebot> https://bugzil.la/1199884 — NEW, nobody@mozilla.org — [AccessFu] Landmark traversal rule does not work
  99. # [06:35] <@firebot> eitan@monotonous.org changed the Assignee on bug 1199884 from nobody@mozilla.org to eitan@monotonous.org.
  100. # [06:39] * Quits: erkan^ (zippo@moz-73oup6.ip.telfort.nl) (Quit: My Mac has gone to sleep. ZZZzzz…)
  101. # [08:23] * Quits: funnel (hegel@moz-hmd.ddu.4.81.IP) (Ping timeout: 121 seconds)
  102. # [08:43] * Joins: funnel (hegel@moz-hmd.ddu.4.81.IP)
  103. # [09:30] * Quits: kkus (kkus@moz-oqbbml.fios.verizon.net) (Connection closed)
  104. # [10:36] * Quits: a-865 (fmcz@moz-ipbm7f.cable.mindspring.com) (Ping timeout: 121 seconds)
  105. # [11:25] * Quits: zippo^ (Zippo@moz-73oup6.ip.telfort.nl) (Quit: Leaving)
  106. # [11:28] * Joins: zippo^ (Zippo@moz-73oup6.ip.telfort.nl)
  107. # [12:01] * Quits: zippo^ (Zippo@moz-73oup6.ip.telfort.nl) (Quit: Leaving)
  108. # [12:03] * Joins: zippo^ (Zippo@moz-73oup6.ip.telfort.nl)
  109. # [14:01] * Quits: zippo^ (Zippo@moz-73oup6.ip.telfort.nl) (Quit: Leaving)
  110. # [14:05] * Joins: zippo^ (Zippo@moz-73oup6.ip.telfort.nl)
  111. # [14:34] * Joins: a-865 (fmcz@moz-ipbm7f.cable.mindspring.com)
  112. # [14:54] * Joins: satdav (uid15780@moz-sljh5r.tooting.irccloud.com)
  113. # [14:56] * Joins: smaug (chatzilla@moz-kn7naf.elisa-laajakaista.fi)
  114. # [15:18] * Quits: smaug (chatzilla@moz-kn7naf.elisa-laajakaista.fi) (Ping timeout: 121 seconds)
  115. # [16:02] * Quits: zippo^ (Zippo@moz-73oup6.ip.telfort.nl) (Quit: Leaving)
  116. # [16:09] * Joins: zippo^ (Zippo@moz-73oup6.ip.telfort.nl)
  117. # [16:47] * Quits: zippo^ (Zippo@moz-73oup6.ip.telfort.nl) (Quit: Leaving)
  118. # [16:48] * Joins: zippo^ (Zippo@moz-73oup6.ip.telfort.nl)
  119. # [16:53] * Joins: smaug (chatzilla@moz-kn7naf.elisa-laajakaista.fi)
  120. # [17:12] * Quits: smaug (chatzilla@moz-kn7naf.elisa-laajakaista.fi) (Ping timeout: 121 seconds)
  121. # [17:17] * Joins: smaug (chatzilla@moz-kn7naf.elisa-laajakaista.fi)
  122. # [17:22] * Quits: smaug (chatzilla@moz-kn7naf.elisa-laajakaista.fi) (Ping timeout: 121 seconds)
  123. # [17:52] * Joins: erkan^ (zippo@moz-73oup6.ip.telfort.nl)
  124. # [18:04] * Quits: erkan^ (zippo@moz-73oup6.ip.telfort.nl) (Quit: Textual IRC Client: www.textualapp.com)
  125. # [18:29] * Quits: satdav (uid15780@moz-sljh5r.tooting.irccloud.com) (Quit: )
  126. # [18:37] * Quits: krit (sid15081@moz-at7k9q.ealing.irccloud.com) (Ping timeout: 121 seconds)
  127. # [18:37] * Quits: m_khvoinitsky (quassel@moz-c4esiv.mp2c.6dnu.04f8.2a01.IP) (Quit: No Ping reply in 180 seconds.)
  128. # [18:37] * Joins: m_khvoinitsky (quassel@moz-c4esiv.mp2c.6dnu.04f8.2a01.IP)
  129. # [18:38] * Joins: krit (sid15081@moz-7klpau.kkpo.i718.8300.2604.IP)
  130. # [19:06] * Joins: smaug (chatzilla@moz-kn7naf.elisa-laajakaista.fi)
  131. # [19:11] * Quits: smaug (chatzilla@moz-kn7naf.elisa-laajakaista.fi) (Ping timeout: 121 seconds)
  132. # [22:39] * Joins: smaug (chatzilla@moz-kn7naf.elisa-laajakaista.fi)
  133. # [22:42] * Joins: ugly_cat_ (quassel@moz-0s097l.wa.comcast.net)
  134. # [22:42] * Quits: ugly_cat (quassel@moz-0s097l.wa.comcast.net) (Ping timeout: 121 seconds)
  135. # [23:31] * Quits: smaug (chatzilla@moz-kn7naf.elisa-laajakaista.fi) (Ping timeout: 121 seconds)
  136. # Session Close: Sun Aug 30 00:00:00 2015

Previous day, Next day

Think these logs are useful? Then please donate to show your gratitude (and keep them up, of course). Thanks! — Krijn