/irc-logs / mozilla / #accessibility / 2015-11-20 / end

Options:

Previous day, Next day

  1. # Session Start: Fri Nov 20 00:00:00 2015
  2. # Session Ident: #accessibility
  3. # [00:00] * Quits: @surkov (surkov@moz-an5vm5.cable.teksavvy.com) (Client exited)
  4. # [00:04] * Joins: surkov (surkov@moz-an5vm5.cable.teksavvy.com)
  5. # [00:04] * ChanServ sets mode: +o surkov
  6. # [00:09] * Quits: @surkov (surkov@moz-an5vm5.cable.teksavvy.com) (Client exited)
  7. # [00:10] * Gijs_away is now known as Gijs
  8. # [00:10] * Quits: Gijs (chatzilla@moz-q1tdpu.cable.virginm.net) (Quit: sleep)
  9. # [00:17] * Joins: yzen (yzen@moz-rjb4dr.cable.teksavvy.com)
  10. # [00:17] * ChanServ sets mode: +o yzen
  11. # [00:25] * yzen is now known as yzen_
  12. # [00:29] * Quits: @yzen_ (yzen@moz-rjb4dr.cable.teksavvy.com) (Ping timeout: 121 seconds)
  13. # [01:27] * Joins: kkus (kkus@moz-7u2hvh.fios.verizon.net)
  14. # [01:40] * Joins: yzen (yzen@moz-rjb4dr.cable.teksavvy.com)
  15. # [01:40] * ChanServ sets mode: +o yzen
  16. # [01:43] * yzen is now known as yzen_
  17. # [01:47] * Quits: @yzen_ (yzen@moz-rjb4dr.cable.teksavvy.com) (Ping timeout: 121 seconds)
  18. # [02:46] * Joins: surkov (surkov@moz-an5vm5.cable.teksavvy.com)
  19. # [02:46] * ChanServ sets mode: +o surkov
  20. # [03:09] * Quits: @surkov (surkov@moz-an5vm5.cable.teksavvy.com) (Client exited)
  21. # [03:54] * Joins: surkov (surkov@moz-an5vm5.cable.teksavvy.com)
  22. # [03:54] * ChanServ sets mode: +o surkov
  23. # [04:50] <@firebot> New Firefox - Disability Access bug 1226473 filed by mcaceres@mozilla.com.
  24. # [04:50] <@firebot> https://bugzil.la/1226473 — NEW, nobody@mozilla.org — Firefox does not read selected text
  25. # [05:28] * Quits: @surkov (surkov@moz-an5vm5.cable.teksavvy.com) (Ping timeout: 121 seconds)
  26. # [05:58] * Tomcat|afk is now known as Tomcat
  27. # [07:19] * Quits: @tbsaunde (tbsaunde@moz-t72n9g.org) (A TLS packet with unexpected length was received.)
  28. # [07:54] * Tomcat is now known as Tomcat|sheriffduty
  29. # [08:18] * Joins: minot2 (kkus@moz-7u2hvh.fios.verizon.net)
  30. # [08:20] * Quits: kkus (kkus@moz-7u2hvh.fios.verizon.net) (Ping timeout: 121 seconds)
  31. # [08:22] * Joins: tbsaunde (tbsaunde@moz-t72n9g.org)
  32. # [08:22] * ChanServ sets mode: +o tbsaunde
  33. # [09:00] * Joins: ioanachiorean (ioanachiore@moz-q23.52n.2.5.IP)
  34. # Session Close: Fri Nov 20 09:08:12 2015
  35. #
  36. # Session Start: Fri Nov 20 09:10:53 2015
  37. # Session Ident: #accessibility
  38. # [09:10] * Now talking in #accessibility
  39. # [09:10] * Topic is 'build the web for everyone | http://logbot.glob.com.au/?c=accessibility'
  40. # [09:10] * Set by tbsaunde on Wed May 06 15:22:49
  41. # [09:29] * Quits: ioanachiorean (ioanachiore@moz-q23.52n.2.5.IP) (Connection closed)
  42. # [09:53] * Joins: Gijs (chatzilla@moz-q1tdpu.cable.virginm.net)
  43. # [10:28] * Joins: ioanachiorean (ioanachiore@moz-q23.52n.2.5.IP)
  44. # [10:52] * Quits: ioanachiorean (ioanachiore@moz-q23.52n.2.5.IP) (A TLS packet with unexpected length was received.)
  45. # [10:56] * Joins: ioanachiorean (ioanachiore@moz-q23.52n.2.5.IP)
  46. # [12:23] * Joins: sixtyten (quassel@moz-ulpjmu.sentoris.de)
  47. # [12:40] * Quits: a-865 (fmcz@moz-ipbm7f.cable.mindspring.com) (Ping timeout: 121 seconds)
  48. # [13:13] * Tomcat|sheriffduty is now known as Tomcat|lunch
  49. # [13:46] * Joins: smaug (chatzilla@moz-6kbmhh.rev.dnainternet.fi)
  50. # [13:51] * Joins: askalski (akuda@moz-v1i1sc.ffa0.hkcg.06a0.2001.IP)
  51. # [13:52] * Quits: askalski (akuda@moz-v1i1sc.ffa0.hkcg.06a0.2001.IP) (A TLS packet with unexpected length was received.)
  52. # [13:57] * Tomcat|lunch is now known as Tomcat|sheriffduty
  53. # [14:41] * Joins: yzen (yzen@moz-rjb4dr.cable.teksavvy.com)
  54. # [14:41] * ChanServ sets mode: +o yzen
  55. # [14:44] * wlach|afk is now known as wlach
  56. # [15:50] * yzen is now known as yzen_
  57. # [15:54] * Quits: @yzen_ (yzen@moz-rjb4dr.cable.teksavvy.com) (Ping timeout: 121 seconds)
  58. # [16:00] * Joins: clown (clown@moz-v6m.c3o.211.205.IP)
  59. # [16:05] * Quits: smaug (chatzilla@moz-6kbmhh.rev.dnainternet.fi) (Ping timeout: 121 seconds)
  60. # [16:06] * Joins: yzen (yzen@66.207.193.21)
  61. # [16:06] * ChanServ sets mode: +o yzen
  62. # [16:25] * Quits: sixtyten (quassel@moz-ulpjmu.sentoris.de) (A TLS packet with unexpected length was received.)
  63. # [16:37] * Joins: a-865 (fmcz@moz-ipbm7f.cable.mindspring.com)
  64. # [16:56] * Quits: @yzen (yzen@66.207.193.21) (Connection closed)
  65. # [16:56] * Joins: yzen (yzen@66.207.193.21)
  66. # [16:56] * ChanServ sets mode: +o yzen
  67. # [17:06] * Tomcat|sheriffduty is now known as Tomcat
  68. # [17:11] * Tomcat is now known as Tomcat|afk
  69. # [17:15] * Joins: smaug (chatzilla@moz-6kbmhh.rev.dnainternet.fi)
  70. # [17:54] * Quits: ioanachiorean (ioanachiore@moz-q23.52n.2.5.IP) (Ping timeout: 121 seconds)
  71. # [18:57] <smaug> eeejay: ping
  72. # [18:58] <smaug> eeejay: want to explain the ipc race ?
  73. # [18:58] <smaug> eeejay: like, where are we crashing?
  74. # [18:59] <@eeejay> smaug: in a call. will be around in an hour?
  75. # [18:59] <smaug> k
  76. # [20:06] <@eeejay> smaug: the race is as follows:
  77. # [20:07] <@eeejay> 1. child process calls speak()
  78. # [20:07] <@eeejay> 2. Protocol is created
  79. # [20:07] <@eeejay> 3. Parent starts and finishes speech very quickly
  80. # [20:07] <@eeejay> 4. Protocol is destroyed by parent on completion
  81. # [20:08] <@eeejay> 5. Child calls cancel/pause before Recv__delete__
  82. # [20:08] <@eeejay> 6. Crash: protocol is dead
  83. # [20:09] <smaug> 3. is still async, so 4. happens some time later
  84. # [20:10] <@eeejay> true, but it is still possible for the child to send something on the protocol before getting __delete__
  85. # [20:10] <smaug> ah, on child side we want to not delete the protocol ...
  86. # [20:10] <smaug> just mark mCurrentTask null
  87. # [20:10] <smaug> hmm, but that happens after cancel() call
  88. # [20:10] <@eeejay> __delete__ will also happen after the utterance is done or on error
  89. # [20:11] <@eeejay> so it can be initiated by the parent.
  90. # [20:11] * Quits: @yzen (yzen@66.207.193.21) (Connection closed)
  91. # [20:12] * Joins: yzen (yzen@66.207.193.21)
  92. # [20:12] * ChanServ sets mode: +o yzen
  93. # [20:12] <@eeejay> the way i see it, the delete should happen after parent/child are 100% not going to be sending any more messages
  94. # [20:12] <smaug> so we want to make sure that if mCurrentTask is non-null, the protocol is up and running and we're not in process to delete it?
  95. # [20:13] <@eeejay> ie. after RecvOnEnd
  96. # [20:13] <@eeejay> smaug: exactly
  97. # [20:15] <@eeejay> RecvOnEnd -> nsSpeechTask::DispatchEndImpl -> SpeechSynthesis::OnEnd -> mCurrentTask = nullptr
  98. # [20:15] <smaug> yup
  99. # [20:15] * yzen is now known as yzen_
  100. # [20:15] <smaug> and calling cancel after that is no-op
  101. # [20:15] <smaug> and right before is sent to parent
  102. # [20:15] <@eeejay> right
  103. # [20:15] <smaug> and does something if there is something to cancel
  104. # [20:16] <smaug> what if there is cancel from child to parent sent when we're sending onend from parent to child...
  105. # [20:16] <smaug> I guess that should work too
  106. # [20:16] <smaug> since cancel is received before __delete__
  107. # [20:16] <smaug> ok
  108. # [20:16] <smaug> thanks
  109. # [20:16] <@eeejay> smaug: in the test file, i dispatch events sync in speak(), but that is just to simulate a very quick conclusion of the protocol
  110. # [20:16] <smaug> it just wasn't clear from the bug which issue we're dealing with there
  111. # [20:18] <@eeejay> smaug: yup. the dependent bug was dispatching events for speechd in sync, which is bad, like you said. but i still think this patch eliminates a possible race condition.
  112. # [20:27] * Quits: Gijs (chatzilla@moz-q1tdpu.cable.virginm.net) (Quit: poof)
  113. # [20:55] * Joins: jongund (chatzilla@moz-emft4q.dres.uiuc.edu)
  114. # [21:41] * yzen_ is now known as yzen
  115. # [22:50] * Quits: smaug (chatzilla@moz-6kbmhh.rev.dnainternet.fi) (Ping timeout: 121 seconds)
  116. # [23:07] * Quits: clown (clown@moz-v6m.c3o.211.205.IP) (Quit: Leaving.)
  117. # [23:15] * yzen is now known as yzen_
  118. # [23:19] * Quits: @yzen_ (yzen@66.207.193.21) (Ping timeout: 121 seconds)
  119. # [23:39] <@firebot> wkocher@mozilla.com changed the Resolution on bug 1218762 from --- to FIXED.
  120. # [23:39] <@firebot> wkocher@mozilla.com changed the Status on bug 1218762 from NEW to RESOLVED.
  121. # [23:39] <@firebot> wkocher@mozilla.com set status-firefox45 to fixed on bug 1218762.
  122. # [23:39] <@firebot> wkocher@mozilla.com changed the Target Milestone on bug 1218762 from --- to mozilla45.
  123. # [23:39] <@firebot> https://bugzil.la/1218762 — FIXED, tbsaunde+mozbugs@tbsaunde.org — [E10S] crash in mozilla::a11y::ia2Accessible::scrollTo
  124. # [23:47] * Quits: jongund (chatzilla@moz-emft4q.dres.uiuc.edu) (Connection closed)
  125. # Session Close: Sat Nov 21 00:00:00 2015

Previous day, Next day

Think these logs are useful? Then please donate to show your gratitude (and keep them up, of course). Thanks! — Krijn