Options:
- # Session Start: Mon Nov 24 00:00:00 2014
- # Session Ident: #microformats
- # [00:41] * Quits: KartikPrabhu (~kartik@108-69-72-147.lightspeed.cicril.sbcglobal.net) (Ping timeout: 258 seconds)
- # [00:54] * Joins: KartikPrabhu (~kartik@108-69-72-147.lightspeed.cicril.sbcglobal.net)
- # [01:03] * Quits: Ryuno (~Ryuno-Ki@p2003006B0F62F040360804FFFE307BDE.dip0.t-ipconnect.de) (Quit: WeeChat 1.0.1)
- # [01:37] * Quits: KartikPrabhu (~kartik@108-69-72-147.lightspeed.cicril.sbcglobal.net) (Read error: Connection reset by peer)
- # [01:55] * Joins: KartikPrabhu (~kartik@108-69-72-147.lightspeed.cicril.sbcglobal.net)
- # [02:13] <aaronpk> this channel isn't dead, just sleeping
- # [04:03] * Joins: KevinMarks__ (~yaaic@2607:fb90:675:43f:3333:678b:c9e0:52f4)
- # [04:03] * ChanServ sets mode: +o KevinMarks__
- # [06:29] * Quits: gRegor` (~me@71.201.46.159) (Ping timeout: 255 seconds)
- # [07:17] * Quits: @KevinMarks (~yaaic@c-67-164-14-200.hsd1.ca.comcast.net) (Remote host closed the connection)
- # [07:27] * Quits: Rastus_Vernon (uid15187@wikimedia/Rastus-Vernon) (Quit: Connection closed for inactivity)
- # [08:56] * Joins: ChiefRA (~RA@unaffiliated/chiefra)
- # [09:18] * Joins: chiui (~chiui@h-213.61.228.26.host.de.colt.net)
- # [09:26] * Joins: krendil (~krendil@218.53.96.58.static.exetel.com.au)
- # [09:46] * Quits: @KevinMarks__ (~yaaic@2607:fb90:675:43f:3333:678b:c9e0:52f4) (Ping timeout: 258 seconds)
- # [09:49] * Joins: KevinMarks (~yaaic@c-67-164-14-200.hsd1.ca.comcast.net)
- # [09:49] * ChanServ sets mode: +o KevinMarks
- # [10:00] * Quits: @KevinMarks (~yaaic@c-67-164-14-200.hsd1.ca.comcast.net) (Ping timeout: 264 seconds)
- # [10:01] * Joins: KevinMarks (~yaaic@c-67-164-14-200.hsd1.ca.comcast.net)
- # [10:01] * ChanServ sets mode: +o KevinMarks
- # [10:26] * Quits: @KevinMarks (~yaaic@c-67-164-14-200.hsd1.ca.comcast.net) (Ping timeout: 244 seconds)
- # [10:33] * Joins: adactio (~adactio@212.42.170.121)
- # [10:33] * ChanServ sets mode: +o adactio
- # [10:39] * Quits: netweb (~netweb@unaffiliated/netweb) (Ping timeout: 240 seconds)
- # [10:39] * Joins: netweb (~netweb@CPE-124-181-32-165.lns2.win.bigpond.net.au)
- # [10:39] * Quits: netweb (~netweb@CPE-124-181-32-165.lns2.win.bigpond.net.au) (Changing host)
- # [10:39] * Joins: netweb (~netweb@unaffiliated/netweb)
- # [11:16] * Joins: eschnou (~eschnou@91.183.153.169)
- # [11:42] * Quits: eschnou (~eschnou@91.183.153.169) (Read error: Connection reset by peer)
- # [11:42] * Joins: eschnou (~eschnou@91.183.153.169)
- # [11:48] * Quits: eschnou (~eschnou@91.183.153.169) (Remote host closed the connection)
- # [12:01] * Joins: alanpearce (~alanpearc@141.0.61.154)
- # [12:10] * Joins: eschnou (~eschnou@91.183.153.169)
- # [12:13] * Quits: eschnou (~eschnou@91.183.153.169) (Remote host closed the connection)
- # [12:18] * Joins: eschnou (~eschnou@91.183.153.169)
- # [12:26] * Quits: eschnou (~eschnou@91.183.153.169) (Remote host closed the connection)
- # [12:49] * Joins: Musk (~Musk@unaffiliated/musk)
- # [12:49] * Quits: Musk (~Musk@unaffiliated/musk) (Client Quit)
- # [13:11] * Joins: eschnou (~eschnou@91.183.153.169)
- # [14:01] * Quits: krendil (~krendil@218.53.96.58.static.exetel.com.au) (Ping timeout: 256 seconds)
- # [14:24] * Quits: voxpelli (sid31634@gateway/web/irccloud.com/x-luoweqmpxgirbuhi) (Read error: Connection reset by peer)
- # [14:24] * Quits: benward____ (sid523@gateway/web/irccloud.com/x-ylrbeedtglavevue) (Read error: Connection reset by peer)
- # [14:24] * Joins: voxpelli (sid31634@gateway/web/irccloud.com/x-ioprsvhseudcawgq)
- # [14:24] * Quits: iwaim (~iwaim@2001:2c0:40e:2002:0:4:14:80) (Ping timeout: 265 seconds)
- # [14:25] * Joins: benward_____ (sid523@gateway/web/irccloud.com/x-stvkasbqixgzbmbb)
- # [14:25] * Quits: tommorris (sid639@wikimedia/Tom-Morris) (Ping timeout: 265 seconds)
- # [14:25] * Quits: Garbee (uid21171@gateway/web/irccloud.com/x-wnbhcvapczrffanx) (Ping timeout: 265 seconds)
- # [14:25] * Quits: bret (sid12421@gateway/web/irccloud.com/x-bmonioyditadhloa) (Ping timeout: 265 seconds)
- # [14:26] * Joins: Garbee (uid21171@gateway/web/irccloud.com/x-auaznnmdpvejjlnb)
- # [14:26] * Joins: tommorris (sid639@wikimedia/Tom-Morris)
- # [14:26] * Joins: bret (sid12421@gateway/web/irccloud.com/x-gmrhowwjskacwgfd)
- # [14:27] * Joins: iwaim (~iwaim@2001:2c0:40e:2002:0:4:14:80)
- # [15:38] * Joins: Musk (~Musk@unaffiliated/musk)
- # [16:02] * Joins: TallTed (~Thud@63.119.36.36)
- # [16:50] * Joins: mko (~mko@50.240.205.146)
- # [17:00] * Quits: KartikPrabhu (~kartik@108-69-72-147.lightspeed.cicril.sbcglobal.net) (Ping timeout: 272 seconds)
- # [17:01] * Joins: gRegor` (~me@71.201.46.159)
- # [17:25] * Quits: alanpearce (~alanpearc@141.0.61.154)
- # [17:32] * Quits: ChiefRA (~RA@unaffiliated/chiefra) (Ping timeout: 272 seconds)
- # [17:37] * Quits: eschnou (~eschnou@91.183.153.169) (Ping timeout: 258 seconds)
- # [17:47] * Quits: chiui (~chiui@h-213.61.228.26.host.de.colt.net) (Quit: Leaving)
- # [18:39] * Quits: gRegor` (~me@71.201.46.159) (Ping timeout: 255 seconds)
- # [18:52] * Parts: @adactio (~adactio@212.42.170.121)
- # [19:01] * Joins: gRegor` (~me@71.201.46.159)
- # [19:19] * Joins: KevinMarks (~yaaic@c-67-164-14-200.hsd1.ca.comcast.net)
- # [19:19] * ChanServ sets mode: +o KevinMarks
- # [19:26] * Quits: @KevinMarks (~yaaic@c-67-164-14-200.hsd1.ca.comcast.net) (Ping timeout: 264 seconds)
- # [19:28] * Joins: KevinMarks (~yaaic@2607:fb90:507:5559:7147:25f7:5c9:cf1d)
- # [19:28] * ChanServ sets mode: +o KevinMarks
- # [20:15] * Joins: KartikPrabhu (~kartik@nsit-dhcp-205-208-056-199.uchicago.edu)
- # [20:19] * Joins: tantek (~tantek@70.0.126.128)
- # [20:19] * ChanServ sets mode: +o tantek
- # [20:33] <@tantek> ben_thatmust left me a message earlier today: does this seem to be correct in its parsing? the category and h-card ending up nested seems odd, but looks to be correct for the algo. Want to double check it is correct before i build on it. https://gist.github.com/dissolve/2911540317b48514f4c6
- # [20:34] * Joins: ben_thatmustbeme (~ben@152.179.134.254)
- # [20:34] <@tantek> ben_thatmustbeme: great test case, it's an interesting challenge of both implying property names and minimal parent/child microformats objects
- # [20:34] <@tantek> here's a general principle - the same markup for a property should not be causing that property to occur in *both* a microformat and one embedded inside - such a property should only be showing up on one.
- # [20:36] <@tantek> thus it's up to the parsing algorithm to be tightened up to prevent that
- # [20:36] <@tantek> it looks like mostly this is happening due to implied properties
- # [20:36] <@tantek> starting with name
- # [20:37] <@tantek> this rule is triggering an extra property/name for the parent " else if .h-x>area:only-child[alt] then use that area alt for name "
- # [20:37] <@tantek> in this case, that should only be triggered if the area itself is NOT a microformat
- # [20:37] <@tantek> and since <area> can't have children itself, this is relatively easy to test
- # [20:39] <Loqi> [[microformats2-parsing]] http://microformats.org/wiki/index.php?title=microformats2-parsing&diff=64687&oldid=64686&rcid=101050 * Tantek * (+40) /* parsing for implied properties */ fix nested img and area implying a name property to not do so for a parent/ancestor if they themselves are the root of a microformat
- # [20:40] <@tantek> that should fix the extra "Person Bee" on the parent h-entry
- # [20:40] <@tantek> (fix as in prevent)
- # [20:41] <mko> Cleaned up the Gist to be easily readable https://gist.github.com/mko/2c481e1bb5d2deb9d2f8
- # [20:41] <@tantek> the same problem can also occur to implying a photo via a child img element, which itself is a microformat, thus we should prevent that as well
- # [20:41] <mko> If someone wants to provide what the "result_expected.json" would look like, I can update that as well.
- # [20:42] <@tantek> I should say, not "we should prevent", but rather, "we already prevent"
- # [20:42] <@tantek> lastly there is the implied url property
- # [20:42] <Loqi> fo sho
- # [20:42] <@tantek> which already has the ":not[.h-*]" test in it
- # [20:42] <@tantek> e.g. this statement
- # [20:43] <@tantek> " else if .h-x>area[href]:only-of-type:not[.h-*] then use that [href] for url "
- # [20:43] <@tantek> thus that duplication of property into parent and child is a bug in the parser, not the spec
- # [20:44] <@tantek> and with that, I have verified by review that the spec says the right thing
- # [20:44] <@tantek> per mko's request
- # [20:46] <@tantek> the only changes to go from result_actual to result_expected:
- # [20:47] <@tantek> the last "name": ["Person Bee"], should be "name": [""],
- # [20:47] <@tantek> and the last "url": ["http://personB.example.com"] should simpliy not be there at all
- # [20:48] <@tantek> the "name" fix is the change I just made to the wiki above
- # [20:48] <@tantek> the "url" fix should have already worked per the "if .h-x>area[href]:only-of-type:not[.h-*]" rule quoted above
- # [20:48] <mko> ben_thatmustbeme: that was parsed originally via php-mf2, yes?
- # [20:48] <mko> Thanks tantek
- # [20:49] <ben_thatmustbeme> slightly modified php-mf2 I added a bit to put in area support
- # [20:49] <@tantek> mko - oops one more fix
- # [20:49] <@tantek> the "type" values should all be arrays
- # [20:49] <@tantek> e.g. "type": "h-entry", should be "type": ["h-entry"],
- # [20:50] <mko> Oh. Right. That was my bad in translating the PHP object explain
- # [20:50] * @tantek checks the PHP object dump
- # [20:50] <@tantek> yup - that's correct in the PHP dump
- # [20:50] <mko> Fixed.
- # [20:51] <@tantek> thanks mko. looks good
- # [20:51] <@tantek> thanks ben_thatmustbeme - do those spec details make sense to you?
- # [20:52] * ben_thatmustbeme reads back
- # [20:52] * @tantek goes to add a note about the general principle noted above
- # [20:55] <Loqi> [[microformats2-parsing]] http://microformats.org/wiki/index.php?title=microformats2-parsing&diff=64688&oldid=64687&rcid=101051 * Tantek * (+298) /* parsing for implied properties */ note about general principle of property markup should not cause that microformat on both a microformat and an embedded child microformat.
- # [20:55] <@tantek> ok that should do it. microformats2-parsing updated to handle test case and incorporate essential commentary above.
- # [20:56] <ben_thatmustbeme> yeah, i see that fixing the one issue, need to look up the bug in the parser too
- # [21:01] * Joins: chiui (~chiui@2001:470:71:41b:b99b:ad05:72cd:e181)
- # [21:02] * Joins: eschnou (~eschnou@165.47-247-81.adsl-dyn.isp.belgacom.be)
- # [21:20] * Quits: KartikPrabhu (~kartik@nsit-dhcp-205-208-056-199.uchicago.edu) (Ping timeout: 255 seconds)
- # [21:21] * Joins: KartikPrabhu (~kartik@nsit-dhcp-205-208-056-199.uchicago.edu)
- # [21:24] * Quits: @tantek (~tantek@70.0.126.128) (Read error: Connection reset by peer)
- # [21:25] * Joins: EsoRottica (~quassel@pool-173-60-255-46.lsanca.fios.verizon.net)
- # [21:26] * Quits: EsoRottica (~quassel@pool-173-60-255-46.lsanca.fios.verizon.net) (Read error: Connection reset by peer)
- # [21:26] * Joins: EsoRottica (~quassel@pool-173-60-255-46.lsanca.fios.verizon.net)
- # [21:29] * Quits: KartikPrabhu (~kartik@nsit-dhcp-205-208-056-199.uchicago.edu) (Ping timeout: 245 seconds)
- # [21:31] <ben_thatmustbeme> looks like that bug exists in php-mf2 before, it doesn't check the :not[.h-*
- # [21:32] * Joins: krendil (~krendil@218.53.96.58.static.exetel.com.au)
- # [21:34] * Joins: KartikPrabhu (~kartik@nsit-dhcp-205-208-056-199.uchicago.edu)
- # [21:37] * Joins: caseorganic (~caseorgan@12.180.47.153)
- # [21:44] * Quits: EsoRottica (~quassel@pool-173-60-255-46.lsanca.fios.verizon.net) (Ping timeout: 244 seconds)
- # [21:47] * Quits: eschnou (~eschnou@165.47-247-81.adsl-dyn.isp.belgacom.be) (Ping timeout: 240 seconds)
- # [21:47] <ben_thatmustbeme> https://gist.github.com/dissolve/a08b0891b04110e63f43
- # [21:47] <ben_thatmustbeme> https://github.com/dissolve/php-mf2
- # [21:48] <ben_thatmustbeme> this looks to have fixed the issue now
- # [21:48] <ben_thatmustbeme> also have that version of php-mf2 up on github
- # [21:59] * Quits: Musk (~Musk@unaffiliated/musk) (Quit: Linkinus - http://linkinus.com)
- # [22:01] * Joins: tantek (~tantek@184.194.155.214)
- # [22:01] * ChanServ sets mode: +o tantek
- # [22:07] * Quits: @tantek (~tantek@184.194.155.214) (Ping timeout: 272 seconds)
- # [22:13] * Quits: krendil (~krendil@218.53.96.58.static.exetel.com.au) (Ping timeout: 255 seconds)
- # [22:15] * Joins: tantek (~tantek@107.25.224.42)
- # [22:15] * ChanServ sets mode: +o tantek
- # [22:25] * Quits: @KevinMarks (~yaaic@2607:fb90:507:5559:7147:25f7:5c9:cf1d) (Ping timeout: 258 seconds)
- # [22:28] * Quits: chiui (~chiui@2001:470:71:41b:b99b:ad05:72cd:e181) (Quit: Leaving)
- # [22:33] * Quits: TallTed (~Thud@63.119.36.36)
- # [22:38] * Joins: KevinMarks (~yaaic@c-67-164-14-200.hsd1.ca.comcast.net)
- # [22:38] * ChanServ sets mode: +o KevinMarks
- # [22:55] <ben_thatmustbeme> i have a feeling there may be other bugs in php-mf2 i'll have to deal with, but for now i sent a pull req to the main trunk. On to the next level in handling tagging
- # [22:57] * Quits: @tantek (~tantek@107.25.224.42) (Ping timeout: 255 seconds)
- # [23:15] * Joins: tantek (~tantek@63.249.55.20)
- # [23:15] * ChanServ sets mode: +o tantek
- # Session Close: Tue Nov 25 00:00:00 2014
The end :)