/irc-logs / w3c / #testing / 2013-06-27 / end

Options:

  1. # Session Start: Thu Jun 27 00:00:00 2013
  2. # Session Ident: #testing
  3. # [00:03] <zcorpan> sstewart6: yes. do a pull request (with a feature branch in your fork)
  4. # [00:04] <zcorpan> sstewart6: http://www.w3.org/wiki/Webapps/Submitting_tests#How_to_Submit_a_New_Test_-_The_Short_Version
  5. # [00:04] <andreastt> sstewart6: What are you attempting to do?
  6. # [00:20] * Quits: tobie (tobie@public.cloak)
  7. # [00:26] <jgraham> sstewart6: The general policy is review-then-commit, using pull requests to indicate that review is required, and either github or critic (https://critic.hoppipolla.co.uk) to do the actual review
  8. # [00:26] <jgraham> We can get you real commit access of course for merging PRs and so on
  9. # [00:27] <jgraham> (fwiw I think that the workflow github encourages here is... suboptimal)
  10. # [00:27] <jgraham> Is there anything else that you want to know?
  11. # [00:29] * Joins: tobie (tobie@public.cloak)
  12. # [00:34] <andreastt> critic <3
  13. # [00:50] <sstewart6> andreastt: move the webdriver tests from hg to git
  14. # [00:50] <sstewart6> as we agreed in the face to face
  15. # [00:51] <sstewart6> Right. I'll set up the PR now
  16. # [00:55] <andreastt> sstewart6: In the F2F when I wasn't there, but jgraham informed me.
  17. # [00:55] * Joins: gitbot (~gitbot@public.cloak)
  18. # [00:55] -gitbot:#testing- [web-platform-tests] shs96c opened pull request #228: webdriver: relocate tests from hg to git and the webplatform tests. (master...submission/sstewart6) https://github.com/w3c/web-platform-tests/pull/228
  19. # [00:55] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  20. # [00:55] <sstewart6> Ah. ok
  21. # [00:55] <sstewart6> PR created: https://github.com/w3c/web-platform-tests/pull/228
  22. # [00:56] <andreastt> jgraham: So FWIW I meant to rewrite those tests to use nosetests and asserts instead of unittest. But never got around to agree with Dave Burns on how to run them.
  23. # [00:56] * Quits: glenn (~gadams@public.cloak) (Client closed connection)
  24. # [00:56] <sstewart6> heh
  25. # [00:57] <sstewart6> We can land and fix
  26. # [00:57] <andreastt> Indeed we can. (-
  27. # [00:57] <andreastt> (-:
  28. # [01:25] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  29. # [01:26] * Joins: zcorpan (~zcorpan@public.cloak)
  30. # [01:33] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  31. # [02:32] * Quits: ArtB (~abarsto@public.cloak) ("Leaving.")
  32. # [02:34] * Quits: tobie (tobie@public.cloak)
  33. # [02:43] * Joins: tobie (tobie@public.cloak)
  34. # [02:53] * Quits: tobie (tobie@public.cloak)
  35. # [03:08] * Quits: sstewart6 (~simons@public.cloak) (sstewart6)
  36. # [03:11] * heycam is now known as heycam|away
  37. # [03:38] * heycam|away is now known as heycam
  38. # [05:23] * Joins: glenn (~gadams@public.cloak)
  39. # [05:26] * Joins: zcorpan (~zcorpan@public.cloak)
  40. # [05:33] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  41. # [05:57] * Joins: gitbot (~gitbot@public.cloak)
  42. # [05:57] -gitbot:#testing- [web-platform-tests] hayatoito pushed 2 new commits to master: https://github.com/w3c/web-platform-tests/compare/baee8577060d...08547ad4d8ac
  43. # [05:57] -gitbot:#testing- web-platform-tests/master 838fcf6 Yuta Kitamura: shadow-dom: Update a test for encapsulation of Selector API....
  44. # [05:57] -gitbot:#testing- web-platform-tests/master 08547ad Hayato Ito: Merge pull request #225 from yutak/shadow-dom/selectors-api...
  45. # [05:57] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  46. # [07:24] * heycam is now known as heycam|away
  47. # [07:36] * heycam|away is now known as heycam
  48. # [08:23] * Joins: tobie (tobie@public.cloak)
  49. # [08:45] * Quits: tobie (tobie@public.cloak)
  50. # [09:29] * Joins: tobie (tobie@public.cloak)
  51. # [09:48] * Joins: Ms2ger (~Ms2ger@public.cloak)
  52. # [09:53] * Joins: zcorpan (~zcorpan@public.cloak)
  53. # [10:38] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  54. # [10:43] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  55. # [10:51] * Joins: zcorpan_ (~zcorpan@public.cloak)
  56. # [10:51] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  57. # [10:57] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  58. # [11:27] * heycam is now known as heycam|away
  59. # [11:31] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  60. # [12:08] * Quits: glenn (~gadams@public.cloak) (Client closed connection)
  61. # [12:10] * Joins: abarsto (~abarsto@public.cloak)
  62. # [12:10] * abarsto is now known as ArtB
  63. # [12:27] * Quits: zcorpan_ (~zcorpan@public.cloak) (Client closed connection)
  64. # [12:28] * Joins: zcorpan (~zcorpan@public.cloak)
  65. # [12:35] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  66. # [12:36] * Joins: zcorpan (~zcorpan@public.cloak)
  67. # [13:22] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  68. # [13:28] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  69. # [14:04] * Joins: darobin (rberjon@public.cloak)
  70. # [14:38] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  71. # [14:40] * Joins: Automate_ (~AutomatedTester@public.cloak)
  72. # [14:40] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  73. # [14:44] * Quits: Automate_ (~AutomatedTester@public.cloak) (Client closed connection)
  74. # [14:59] * Joins: Lachy (~Lachy@public.cloak)
  75. # [15:15] <jgraham> andreastt: https://critic.hoppipolla.co.uk/r/191 seems like something you should be reviewing
  76. # [15:22] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  77. # [15:23] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  78. # [15:23] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  79. # [15:37] <Ms2ger> AutomatedTester, https://critic.hoppipolla.co.uk/r/191 would be something for you too
  80. # [15:40] * Joins: glenn (~gadams@public.cloak)
  81. # [15:41] <jgraham> Indeed
  82. # [15:43] * Joins: glenn_ (~gadams@public.cloak)
  83. # [15:44] * Quits: glenn (~gadams@public.cloak) (Client closed connection)
  84. # [15:46] <AutomatedTester> merge it, doesnt really need review
  85. # [15:47] <AutomatedTester> jgraham: do I need to do something to use critic?
  86. # [15:47] <Ms2ger> You should be able to log in through github
  87. # [15:49] <AutomatedTester> I logged in but what now?
  88. # [15:49] <AutomatedTester> write a not and thats it?
  89. # [15:49] <Ms2ger> Try if you can review now?
  90. # [15:51] <AutomatedTester> I cant add myself as a reviewer
  91. # [15:51] <AutomatedTester> says I am not in the database
  92. # [15:51] <AutomatedTester> now it works
  93. # [15:51] <AutomatedTester> I hate computers sometimes
  94. # [15:52] <Ms2ger> That's because I added you as a reviewer :)
  95. # [15:52] <AutomatedTester> I hate you sometimes
  96. # [15:52] <AutomatedTester> but not today :)
  97. # [15:52] <Ms2ger> <3
  98. # [15:54] <AutomatedTester> ok I am being stupid how does one "review" on critic
  99. # [15:55] <AutomatedTester> or do I just click the rebase button
  100. # [15:55] <AutomatedTester> found it
  101. # [15:55] * AutomatedTester mutters about computers again
  102. # [15:56] * AutomatedTester notices that that andreastt chap left left spaces in the files....
  103. # [15:57] <AutomatedTester> ok, its reviewed
  104. # [15:57] <AutomatedTester> what now?
  105. # [15:58] <Ms2ger> "Hurry up and close it before anyone has a change of heart."
  106. # [15:59] <Ms2ger> I.e., go to github and merge
  107. # [15:59] <AutomatedTester> are merge commits ok?
  108. # [16:00] <AutomatedTester> or do we want --amend --signoff
  109. # [16:00] <Ms2ger> jgraham?
  110. # [16:00] <AutomatedTester> green button == merge commits
  111. # [16:13] <zcorpan> the green button has been used in the past, at least. i don't know what --amend --signoff does :-)
  112. # [16:17] <AutomatedTester> zcorpan: it says that I signed off the last commit in my tree :)
  113. # [16:17] <AutomatedTester> which could be the merge after a rebase :)
  114. # [16:18] <AutomatedTester> some people get pedantic about commit history
  115. # [16:18] * Quits: andreastt (~ato@public.cloak) (Client closed connection)
  116. # [16:25] * Joins: andreastt (~ato@public.cloak)
  117. # [17:03] * Quits: Lachy (~Lachy@public.cloak) ("Bye")
  118. # [17:07] * Joins: zcorpan_ (~zcorpan@public.cloak)
  119. # [17:07] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  120. # [17:21] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
  121. # [17:21] * Joins: mdas (~mdas@public.cloak)
  122. # [17:28] * Quits: mdas (~mdas@public.cloak) (Ping timeout: 180 seconds)
  123. # [17:32] * Quits: andreastt (~ato@public.cloak) (Client closed connection)
  124. # [17:33] * Joins: andreastt (~ato@public.cloak)
  125. # [17:44] * Joins: mdas (~mdas@public.cloak)
  126. # [17:48] * Joins: Automate_ (~AutomatedTester@public.cloak)
  127. # [17:51] * Quits: tobie (tobie@public.cloak)
  128. # [17:54] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Ping timeout: 180 seconds)
  129. # [17:58] * Quits: zcorpan_ (~zcorpan@public.cloak) (Client closed connection)
  130. # [17:58] * Joins: zcorpan (~zcorpan@public.cloak)
  131. # [18:06] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  132. # [18:08] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  133. # [18:08] * Quits: Automate_ (~AutomatedTester@public.cloak) (Client closed connection)
  134. # [18:15] * Joins: sstewart6 (~simons@public.cloak)
  135. # [18:29] * Joins: zcorpan (~zcorpan@public.cloak)
  136. # [18:41] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  137. # [18:43] * Joins: mdas_ (~mdas@public.cloak)
  138. # [18:44] * Quits: darobin (rberjon@public.cloak) (Client closed connection)
  139. # [18:49] * Quits: mdas (~mdas@public.cloak) (Ping timeout: 180 seconds)
  140. # [19:13] * Joins: Automate_ (~AutomatedTester@public.cloak)
  141. # [19:13] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  142. # [19:15] * Joins: jhammel (~jhammel@public.cloak)
  143. # [19:17] * Parts: jhammel (~jhammel@public.cloak) (jhammel)
  144. # [20:49] * Quits: mdas_ (~mdas@public.cloak) (Client closed connection)
  145. # [20:50] * Joins: mdas (~mdas@public.cloak)
  146. # [20:54] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  147. # [20:54] * Quits: Automate_ (~AutomatedTester@public.cloak) (Client closed connection)
  148. # [20:57] * Quits: mdas (~mdas@public.cloak) (Ping timeout: 180 seconds)
  149. # [21:04] * Joins: darobin (rberjon@public.cloak)
  150. # [21:04] * Quits: darobin (rberjon@public.cloak) (Client closed connection)
  151. # [21:09] * Quits: Ms2ger (~Ms2ger@public.cloak) (Ping timeout: 180 seconds)
  152. # [21:11] * Joins: zcorpan (~zcorpan@public.cloak)
  153. # [21:31] * Joins: mdas (~mdas@public.cloak)
  154. # [21:35] * Joins: tobie (tobie@public.cloak)
  155. # [21:38] * Quits: tobie (tobie@public.cloak) (Client closed connection)
  156. # [21:40] * Quits: glenn_ (~gadams@public.cloak) (Client closed connection)
  157. # [21:41] * Joins: tobie (tobie@public.cloak)
  158. # [21:46] * Joins: glenn (~gadams@public.cloak)
  159. # [22:16] * Quits: ArtB (~abarsto@public.cloak) (Ping timeout: 180 seconds)
  160. # [22:17] * Joins: gitbot (~gitbot@public.cloak)
  161. # [22:17] -gitbot:#testing- [web-platform-tests] AutomatedTester pushed 2 new commits to master: https://github.com/w3c/web-platform-tests/compare/08547ad4d8ac...510f1a89b6a0
  162. # [22:17] -gitbot:#testing- web-platform-tests/master a6862d0 Simon Stewart: webdriver: relocate tests from hg to git and the webplatform tests....
  163. # [22:17] -gitbot:#testing- web-platform-tests/master 510f1a8 David Burns: Merge pull request #228 from shs96c/submission/sstewart6...
  164. # [22:17] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  165. # [22:20] <tobie> sstewart6: you're around?
  166. # [22:25] <sstewart6> Here now
  167. # [22:25] <sstewart6> 'sup?
  168. # [22:25] <sstewart6> (Next meeting in 5 minutes)
  169. # [22:27] <tobie> hey
  170. # [22:27] <sstewart6> 'sup?
  171. # [22:28] <tobie> Was wondering if you had a preferred mailing list to send GitHub notifications to for the test repo.
  172. # [22:28] <sstewart6> For the webdriver spec?
  173. # [22:28] <tobie> sstewart6: see: http://www.w3.org/wiki/Testing/Infra/NotificationHell
  174. # [22:28] <tobie> yes
  175. # [22:30] <sstewart6> Probably: public-browser-tools-testing@w3.org
  176. # [22:30] * Quits: glenn (~gadams@public.cloak) (Client closed connection)
  177. # [22:30] * Joins: abarsto (~abarsto@public.cloak)
  178. # [22:30] * abarsto is now known as ArtB
  179. # [22:30] <sstewart6> Right. Back in about 15 minutes
  180. # [22:32] <tobie> sstewart6: you have 10 min long meetings?
  181. # [22:32] <tobie> How do you do it?
  182. # [22:35] <AutomatedTester> tobie: its quite easy
  183. # [22:35] <AutomatedTester> set meeting time
  184. # [22:35] <AutomatedTester> times up, walk out
  185. # [22:35] <AutomatedTester> job done
  186. # [22:35] <AutomatedTester> :)
  187. # [22:36] <tobie> I can't really walk out. I'm remote.
  188. # [22:36] <tobie> Usually getting a connection working takes longer than that.
  189. # [22:36] <tobie> But yeah. Good point.
  190. # [22:40] <sstewart6> tobie: in this case it's just a quick greeting
  191. # [22:44] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  192. # [22:44] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  193. # [22:52] * Quits: mdas (~mdas@public.cloak) ("Leaving...")
  194. # [23:17] <jgraham> AutomatedTester: Sorry, I was on a plane
  195. # [23:18] <AutomatedTester> excuses excuses :D
  196. # [23:18] <jgraham> Anyway, you pass critic 101
  197. # [23:18] <jgraham> Well done :)
  198. # [23:19] <jgraham> If you didn't already, you can set yourself as a reviewer for /webdriver by using the filters on the front page
  199. # [23:19] <jgraham> At the bottom there's a button marked "Add Filter"
  200. # [23:19] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  201. # [23:19] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  202. # [23:20] <AutomatedTester> *sigh* stupid connection
  203. # [23:20] <jgraham> 21:17 < jgraham> If you didn't already, you can set yourself as a reviewer for /webdriver by using the filters on the front page
  204. # [23:20] <jgraham> 21:18 < jgraham> At the bottom there's a button marked "Add Filter"
  205. # [23:21] <jgraham> Select the web-platform-tests repo
  206. # [23:21] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  207. # [23:22] <jgraham> and /webdriver as the filter path
  208. # [23:22] * Joins: zcorpan (~zcorpan@public.cloak)
  209. # [23:22] <AutomatedTester> done
  210. # [23:23] <jgraham> Great
  211. # [23:23] <AutomatedTester> sstewart6: ^ you'll want to do that too
  212. # [23:24] * sstewart6 goes digging for the link to critic
  213. # [23:24] <AutomatedTester> sstewart6: https://critic.hoppipolla.co.uk/home
  214. # [23:25] <sstewart6> Done.
  215. # [23:26] <sstewart6> I caused an unexpected error, which is very exciting
  216. # [23:26] <sstewart6> Apparently the sysadmin has been warned.
  217. # [23:26] <jgraham> Yeah, I just got an email :)
  218. # [23:26] <sstewart6> Does that mean we can land the webdriver tests?
  219. # [23:26] <sstewart6> Ohh!
  220. # [23:27] <AutomatedTester> sstewart6: I already landed them
  221. # [23:27] <sstewart6> heh
  222. # [23:27] <sstewart6> ok
  223. # [23:29] <sstewart6> I'd held off doing that until I'd review had been done :)
  224. # [23:29] <sstewart6> s/I'd//
  225. # [23:29] <sstewart6> s/review/the review/
  226. # [23:29] <AutomatedTester> sstewart6: I reviewed them in critic
  227. # [23:29] <AutomatedTester> and then merged them
  228. # [23:30] <sstewart6> So I saw
  229. # [23:30] <sstewart6> Next time I'll just Land That Stuff ;)
  230. # [23:30] <AutomatedTester> lets review all the tests going in
  231. # [23:30] * jgraham doesn't exactly know what that error is, but doesn't think it's generally very important
  232. # [23:30] <jgraham> I will ask jl
  233. # [23:31] <jgraham> Or debug it myself
  234. # [23:32] <sstewart6> k
  235. # [23:32] <sstewart6> I'll not worry
  236. # [23:40] * Joins: gitbot (~gitbot@public.cloak)
  237. # [23:40] -gitbot:#testing- [web-platform-tests] plehegar pushed 5 new commits to master: https://github.com/w3c/web-platform-tests/compare/510f1a89b6a0...da2a2a4fb8a1
  238. # [23:40] -gitbot:#testing- web-platform-tests/master 66fe3fd plehegar: From Page Visibility test suite
  239. # [23:40] -gitbot:#testing- web-platform-tests/master baca0ca plehegar: Cleaned up the prefixes
  240. # [23:40] -gitbot:#testing- web-platform-tests/master cc716ed plehegar: Fixed directory name
  241. # [23:40] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  242. # [23:40] <jgraham> sstewart6, AutomatedTester: Ah you need to write webdriver/
  243. # [23:40] <jgraham> With the / at the end
  244. # [23:40] * Joins: gitbot (~gitbot@public.cloak)
  245. # [23:40] -gitbot:#testing- [web-platform-tests] plehegar pushed 5 new commits to master: https://github.com/w3c/web-platform-tests/compare/da2a2a4fb8a1...f93af8095582
  246. # [23:40] -gitbot:#testing- web-platform-tests/master 8af0572 plehegar: Tests for Page Visibility
  247. # [23:40] -gitbot:#testing- web-platform-tests/master 030157a plehegar: Merge branch 'master' of github.com:w3c/web-platform-tests into submissions/pagevisibility
  248. # [23:40] -gitbot:#testing- web-platform-tests/master a7b1ddd plehegar: Fixed resources
  249. # [23:40] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  250. # [23:41] <jgraham> Seems that the error handling here is broken
  251. # [23:41] <sstewart6> jgraham: "webdriver/"? No leading slash?
  252. # [23:41] <AutomatedTester> updated
  253. # [23:45] * Joins: Automate_ (~AutomatedTester@public.cloak)
  254. # [23:45] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  255. # [23:46] <jgraham> sstewart6: Yes, I think so. I am reading https://critic.hoppipolla.co.uk/tutorial?item=filters
  256. # [23:46] <sstewart6> OK. Updated as "webdriver/" with no leading slash
  257. # [23:47] <jgraham> Sorry for the hiccups
  258. # [23:48] <sstewart6> np
  259. # Session Close: Fri Jun 28 00:00:00 2013

The end :)