/irc-logs / w3c / #testing / 2013-07-09 / end

Options:

  1. # Session Start: Tue Jul 09 00:00:01 2013
  2. # Session Ident: #testing
  3. # [00:09] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  4. # [02:15] * heycam|away is now known as heycam
  5. # [04:22] * Quits: jhammel_ (~jhammel@public.cloak) ("leaving")
  6. # [08:27] * Quits: mcr (~mcr@public.cloak) (Ping timeout: 180 seconds)
  7. # [08:39] * Joins: dom (dom@public.cloak)
  8. # [08:42] * Joins: Lachy (~Lachy@public.cloak)
  9. # [09:22] * Quits: Lachy (~Lachy@public.cloak) ("Computer has gone to sleep.")
  10. # [09:39] * heycam is now known as heycam|away
  11. # [09:44] <jgraham> Anyone here want to OK a trivial fix?
  12. # [09:44] <jgraham> https://critic.hoppipolla.co.uk/r/209
  13. # [09:52] <dom> jgraham, what should I do to OK it in critic?
  14. # [09:53] * Joins: Lachy (~Lachy@public.cloak)
  15. # [09:53] <dom> or should I just merge it?
  16. # [09:54] <jgraham> dom: Click the checkbox by the file that you reviewed (there is only one in this case) and then click "submit" at the top
  17. # [09:54] <jgraham> It will automatically set the status to Accepted if there are 0 issues and all code is marked as reviewed
  18. # [09:55] <dom> I don't see checkboxes or a submit button... do I have the right privileges?
  19. # [09:56] <jgraham> dom: Oh, you might not be a reviewer
  20. # [09:56] <jgraham> Let me fix
  21. # [09:56] <jgraham> OK, you are now a reviewer for that change
  22. # [09:57] <jgraham> (if you want to set which things you can review in general, add some filters on the front page)
  23. # [09:58] <dom> I'm still not seeing a checkbox... I'm not sure I'm being helpful here :)
  24. # [09:59] <dom> oh I see https://critic.hoppipolla.co.uk/showcommit?review=209&filter=pending now
  25. # [09:59] <jgraham> Yep. Looks like you just need to press submit?
  26. # [10:00] <jgraham> Perfect, thanks for the help :)
  27. # [10:29] * Joins: darobin (rberjon@public.cloak)
  28. # [11:21] * Joins: darobin_ (rberjon@public.cloak)
  29. # [11:21] * Quits: darobin (rberjon@public.cloak) (Client closed connection)
  30. # [11:39] * darobin_ is now known as darobin
  31. # [12:47] * Joins: abarsto (~abarsto@public.cloak)
  32. # [12:47] * abarsto is now known as ArtB
  33. # [13:29] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  34. # [13:29] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  35. # [13:29] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  36. # [14:47] * Joins: gitbot (~gitbot@public.cloak)
  37. # [14:47] -gitbot:#testing- [web-platform-tests] hallvors created hallvors/xhr_stop_abort_test (+1 new commit): https://github.com/w3c/web-platform-tests/commit/c1ab344ad704
  38. # [14:47] -gitbot:#testing- web-platform-tests/hallvors/xhr_stop_abort_test c1ab344 Hallvord Reiar M. Steen: new test for window.stop() and the abort event, thanks @Yaffle
  39. # [14:47] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  40. # [14:50] * Joins: gitbot (~gitbot@public.cloak)
  41. # [14:50] -gitbot:#testing- [web-platform-tests] hallvors opened pull request #242: new test for window.stop() and the abort event, thanks @Yaffle (master...hallvors/xhr_stop_abort_test) https://github.com/w3c/web-platform-tests/pull/242
  42. # [14:50] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  43. # [15:13] * Joins: gitbot (~gitbot@public.cloak)
  44. # [15:13] -gitbot:#testing- [web-platform-tests] hayatoito pushed 2 new commits to master: https://github.com/w3c/web-platform-tests/compare/48d2b8424a10...4571618997ea
  45. # [15:13] -gitbot:#testing- web-platform-tests/master b048635 Yuta Kitamura: shadow-dom: Update a test for shadow root's accessors....
  46. # [15:13] -gitbot:#testing- web-platform-tests/master 4571618 Hayato Ito: Merge pull request #237 from yutak/shadow-dom/shadow-root-accessors...
  47. # [15:13] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  48. # [17:03] * Joins: glenn (~gadams@public.cloak)
  49. # [17:25] * Joins: Automate_ (~AutomatedTester@public.cloak)
  50. # [17:26] * Quits: Automate_ (~AutomatedTester@public.cloak) (Client closed connection)
  51. # [17:31] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Ping timeout: 180 seconds)
  52. # [17:43] * Quits: Lachy (~Lachy@public.cloak) ("Computer has gone to sleep.")
  53. # [17:54] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  54. # [18:02] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  55. # [18:13] * Joins: Ms2ger (~Ms2ger@public.cloak)
  56. # [18:25] * Joins: jhammel (~jhammel@public.cloak)
  57. # [18:26] * Parts: jhammel (~jhammel@public.cloak) (jhammel)
  58. # [18:32] * Joins: Lachy (~Lachy@public.cloak)
  59. # [18:38] * Quits: Lachy (~Lachy@public.cloak) (Client closed connection)
  60. # [18:39] * Joins: Lachy (~Lachy@public.cloak)
  61. # [18:45] * Quits: dom (dom@public.cloak) ("")
  62. # [18:55] * Quits: darobin (rberjon@public.cloak) (Client closed connection)
  63. # [19:27] * Joins: gitbot (~gitbot@public.cloak)
  64. # [19:27] -gitbot:#testing- [web-platform-tests] annevk opened pull request #243: collapse() now has an optional argument and detach() is a no-op (master...patch-1) https://github.com/w3c/web-platform-tests/pull/243
  65. # [19:27] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  66. # [20:12] * Joins: jhammel (~jhammel@public.cloak)
  67. # [20:12] * Quits: jhammel (~jhammel@public.cloak) ("leaving")
  68. # [20:13] * Joins: jhammel (~jhammel@public.cloak)
  69. # [20:14] * Parts: jhammel (~jhammel@public.cloak) (jhammel)
  70. # [20:55] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  71. # [21:16] * Quits: bhill (~Brad@public.cloak) (Client closed connection)
  72. # [21:30] * Joins: bhill (~Brad@public.cloak)
  73. # [21:32] * Quits: Lachy (~Lachy@public.cloak) ("Computer has gone to sleep.")
  74. # [21:39] * Joins: Lachy (~Lachy@public.cloak)
  75. # [21:52] * Joins: gitbot (~gitbot@public.cloak)
  76. # [21:52] -gitbot:#testing- [web-platform-tests] annevk opened pull request #244: sync with DOM (master...patch-2) https://github.com/w3c/web-platform-tests/pull/244
  77. # [21:52] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  78. # [21:58] * Joins: gitbot (~gitbot@public.cloak)
  79. # [21:58] -gitbot:#testing- [web-platform-tests] Ms2ger closed pull request #244: sync with DOM (master...patch-2) https://github.com/w3c/web-platform-tests/pull/244
  80. # [21:58] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  81. # [22:04] * Quits: ArtB (~abarsto@public.cloak) ("Leaving.")
  82. # [22:44] * Quits: glenn (~gadams@public.cloak) (Client closed connection)
  83. # [22:55] * Quits: Ms2ger (~Ms2ger@public.cloak) ("nn")
  84. # Session Close: Wed Jul 10 00:00:01 2013

The end :)