/irc-logs / w3c / #testing / 2013-08-12 / end

Options:

  1. # Session Start: Mon Aug 12 00:00:00 2013
  2. # Session Ident: #testing
  3. # [00:11] * Joins: gitbot (~gitbot@public.cloak)
  4. # [00:11] -gitbot:#testing- [web-platform-tests] heycam opened pull request #271: Remainder of my tests (master...submission/heycam/WebIDL-tests-1) https://github.com/w3c/web-platform-tests/pull/271
  5. # [00:11] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  6. # [00:23] * Joins: gitbot (~gitbot@public.cloak)
  7. # [00:23] -gitbot:#testing- [web-platform-tests] heycam synchronize pull request #271: Remainder of my tests (master...submission/heycam/WebIDL-tests-1) https://github.com/w3c/web-platform-tests/pull/271
  8. # [00:23] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  9. # [00:55] * Quits: timeless (~uid4015@public.cloak) ("Connection closed for inactivity")
  10. # [02:27] * heycam is now known as heycam|away
  11. # [03:19] * heycam|away is now known as heycam
  12. # [06:58] * Joins: shepazu (schepers@public.cloak)
  13. # [06:59] * Joins: zcorpan (~zcorpan@public.cloak)
  14. # [08:21] * heycam is now known as heycam|away
  15. # [09:44] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  16. # [09:46] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  17. # [10:01] * Joins: dom (dom@public.cloak)
  18. # [10:16] * Quits: Lachy (~Lachy@public.cloak) ("Computer has gone to sleep.")
  19. # [10:31] * Joins: Ms2ger (~Ms2ger@public.cloak)
  20. # [10:33] * Joins: darobin (rberjon@public.cloak)
  21. # [10:41] * Joins: Lachy (~Lachy@public.cloak)
  22. # [11:06] * heycam|away is now known as heycam
  23. # [11:32] * Joins: gitbot (~gitbot@public.cloak)
  24. # [11:32] -gitbot:#testing- [web-platform-tests] jgraham pushed 1 new commit to master: https://github.com/w3c/web-platform-tests/commit/4d2a2b6cb44dbdfa19d2f46dd848c8df0faab85c
  25. # [11:32] -gitbot:#testing- web-platform-tests/master 4d2a2b6 Aryeh Gregor: Add tests for reflection of content attributes in IDL attributes....
  26. # [11:32] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  27. # [11:34] * Joins: gitbot (~gitbot@public.cloak)
  28. # [11:34] -gitbot:#testing- [web-platform-tests] jgraham closed pull request #1: Aryeh's submission (master...submission/AryehGregor) https://github.com/w3c/web-platform-tests/pull/1
  29. # [11:34] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  30. # [12:22] * Joins: abarsto (~abarsto@public.cloak)
  31. # [12:22] * abarsto is now known as ArtB
  32. # [12:26] * Joins: tobie (tobie@public.cloak)
  33. # [13:09] * heycam is now known as heycam|away
  34. # [14:05] <jgraham> So, if I were writing a python server for testing, how would people like advanced (php-replacing) functionality to work?
  35. # [14:05] <jgraham> One option is that people write .py files with a number of predefined globals
  36. # [14:06] <jgraham> Like "request", "response" and "utils"
  37. # [14:06] <jgraham> Where "utils" might contain e.g. a function to take a file/string and return it piece by piece
  38. # [14:07] <jgraham> Or
  39. # [14:07] <jgraham> We could do something else
  40. # [14:07] <jgraham> Not sure what makes reusing the common things easiest
  41. # [14:08] <jgraham> Of course each funciton in utils could be exposed in some way as a url + query string
  42. # [14:10] <jgraham> so maybe you could do /utils/delayed?path=/foo/bar&parts=1d2b1d
  43. # [14:11] <wilhelm> Without answering your question: Note that the Mozilla Python HTTP server is already in use by the WebDriver tests.
  44. # [14:24] * Joins: jimevans (~jimevans@public.cloak)
  45. # [14:46] * Quits: jimevans (~jimevans@public.cloak) ("Colloquy for iPhone - http://colloquy.mobi")
  46. # [14:49] <tobie> jgraham: I see two kind of services: one that is standalone (e.g. an echo server)...
  47. # [14:49] <tobie> and one which isn't (eg delaying a regular response)
  48. # [14:50] <tobie> The latter I'd add a params of a regular request
  49. # [14:50] <tobie> e.g.: /foo/bar.html returns /foo/bar.html
  50. # [14:51] <tobie> e.g.: /foo/bar.html?delay=2 returns /foo/bar.html after 2 seconds
  51. # [14:51] <tobie> etc.
  52. # [15:11] <gsnedders> Note that some of jgraham's tests I'm currently getting out use a script currently called slice-and-dice, which allows to delays at arbitrary byte offsets in the file.
  53. # [15:24] <tobie> gsnedders: pointers?
  54. # [15:27] <jgraham> gsnedders: I plan to port slice-and-dice
  55. # [15:27] <jgraham> being able to implement that is a requirement
  56. # [15:27] <jgraham> wilhelm: I investigated that and it's not enough
  57. # [15:27] <jgraham> It doesn't allow you to do things like override the headers
  58. # [15:27] <jgraham> +required
  59. # [15:28] <jgraham> So you can't even do things like mod_asis
  60. # [15:37] <gsnedders> tobie: There's a PHP rewrite in my repo, op_browsing branch
  61. # [15:37] <tobie> gsnedders: which is?
  62. # [15:38] <gsnedders> https://github.com/gsnedders/web-platform-tests/blob/4aed7c6d584beb610d6ab04b6e483528aa497e87/html/browsers/browsing-the-web/navigating-across-documents/slice-and-dice.php
  63. # [15:40] <tobie> ty
  64. # [15:40] <tobie> so that falls in the second category I was suggesting
  65. # [15:40] <gsnedders> Right
  66. # [15:41] <jgraham> I don't think there should be two categories
  67. # [15:41] <jgraham> I think there should be /utils
  68. # [15:41] <tobie> so the only difference between Jame's proposal and mine is his is backwards compatible and mine is nicer :D
  69. # [15:42] <jgraham> Where each file contains a function which is registered as a handler for a particular url string in a well defined way
  70. # [15:42] <jgraham> So if you had /utils/slice-and-dice it might have a signature like
  71. # [15:42] <tobie> jgraham: yeah, the problem with that is that is you can't combine them.
  72. # [15:43] <jgraham> def slice_and_dice(file=file, parts=parts):
  73. # [15:43] <jgraham> pass
  74. # [15:43] <jgraham> And then more complex behaviour would require that you write your own .py file
  75. # [15:43] <jgraham> Where utils would be avaliable
  76. # [15:43] <tobie> sure, you'd still want to think of them as middleware which you could combine
  77. # [15:44] <jgraham> so you could use utils.slice_and_dice("foo/bar.html", "1,2d")
  78. # [15:44] <tobie> yeah, I mean't in the url itself
  79. # [15:45] <jgraham> I don't know how you would compose them in a url
  80. # [15:45] <tobie> e.g. foo/bar.html?delay=3&responseStatus=200
  81. # [15:45] <jgraham> That would mean that you could only have one parameter per function or something
  82. # [15:45] <tobie> jgraham: ^
  83. # [15:45] <tobie> not necessarily.
  84. # [15:46] <jgraham> Or at least you would need unique naming
  85. # [15:46] <jgraham> And order isn't very obvious
  86. # [15:46] <jgraham> But sure, I guess it is possible to invent some scheme that you could write in a URL
  87. # [15:47] <tobie> these are valid concerns
  88. # [15:47] <jgraham> After a point, it's likely just easier to write a custom .py file
  89. # [15:47] <tobie> that too
  90. # [15:47] <jgraham> Which you need for lots of things anyway
  91. # [15:47] * jgraham needs to look at all the requirements that mozilla have in Mochitests
  92. # [15:47] <tobie> I just liked the liked the idea that you could abritraly modify the behaviour of a url by passing in params
  93. # [15:48] <tobie> feels very intuitive
  94. # [15:48] <jgraham> Well I don't disagree that something like that could work for simple cases
  95. # [15:48] <tobie> more than passing said url as a param to a function
  96. # [15:48] <tobie> yeah, a list of more complex requirements would be useful
  97. # [15:49] <tobie> (haven't dug much there)
  98. # [15:51] <jgraham> foo/bar?pipe=slice("1,d1,2000")|status(200) or something
  99. # [15:51] <jgraham> Seems like it might be nice or might be too complex
  100. # [15:54] <tobie> lets look at the reqs, then we see if we can come up with a nice dsl
  101. # [15:54] <tobie> else we'll go for something simpler
  102. # [15:54] <tobie> might be useful to be able to set http headers that way too
  103. # [15:54] <tobie> for one offs
  104. # [15:54] <jgraham> Well I'm 100% sure a nice dsl won't work for all use cases
  105. # [15:54] <jgraham> Because there are tests that need conditional logic
  106. # [15:55] <jgraham> (e.g. tests where things change after a resource has been loaded once)
  107. # [15:55] <jgraham> So far, for headers, I was considering a .headers file
  108. # [15:56] <tobie> Well I'm 100% sure a nice dsl won't work for all use cases -> agreed
  109. # [15:57] <tobie> So far, for headers, I was considering a .headers file -> yup, me too. Might still be useful to be able to override those through url params
  110. # [15:57] <jgraham> Fair enough
  111. # [15:57] <tobie> … let's do .headers first, then we can see for the rest
  112. # [15:57] <jgraham> Well first I will see if I can serve plain files :)
  113. # [15:57] <tobie> :)
  114. # [15:58] <jgraham> (*very* simple things work, so maybe I can)
  115. # [15:59] * Joins: jimevans (~jimevans@public.cloak)
  116. # [16:06] <tobie> Catching up on last week's threads. Decided to create a FAQ to answer some common questions. Help welcomed.
  117. # [16:06] <tobie> https://github.com/w3c/testtwf-website/pull/67/files
  118. # [16:09] * Quits: jimevans (~jimevans@public.cloak) ("Colloquy for iPhone - http://colloquy.mobi")
  119. # [17:10] <ArtB> some of the eventsource tests e.g. view-source:http://w3c-test.org/web-platform-tests/master/eventsource/eventsource-cross-origin.htm try to access crosssite.w3c-test.org
  120. # [17:13] <ArtB> darobin, mikesmith, dom - is crosssite.w3c-test.org down?
  121. # [17:15] <darobin> ArtB: has it ever existed?
  122. # [17:15] <jgraham> I don't remember that being one that the W3C had
  123. # [17:15] <darobin> we have www2 for that; I don't recall there being a crosssite.
  124. # [17:15] <ArtB> beats me
  125. # [17:16] <jgraham> Opera had it, so it is possible that it made it into some of our tests
  126. # [17:16] <ArtB> ok, thanks, I'll start a thread on the list
  127. # [17:21] <odinho> It's just changing it.
  128. # [17:21] * Quits: Lachy (~Lachy@public.cloak) ("Computer has gone to sleep.")
  129. # [17:21] <odinho> I had a support.js file with that URL as a variable.
  130. # [17:21] <odinho> Also, we got www2 internally so that we could rather use the W3C urls.
  131. # [17:23] <ArtB> odinho not sure what you you mean by "It's just changing it"
  132. # [17:24] <odinho> The tests
  133. # [17:24] <odinho> That has crosssite written in them. :-) Change that to "www2"
  134. # [17:25] <ArtB> So, s/crosssite/www2/ ?
  135. # [17:25] <odinho> Yeah, something like that :)
  136. # [17:26] <jgraham> You get to play with sed :)
  137. # [17:30] * Joins: gitbot (~gitbot@public.cloak)
  138. # [17:30] -gitbot:#testing- [web-platform-tests] AFBarstow opened pull request #272: Change crosssite host name to www2 (master...master) https://github.com/w3c/web-platform-tests/pull/272
  139. # [17:30] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  140. # [17:32] * Joins: gitbot (~gitbot@public.cloak)
  141. # [17:32] -gitbot:#testing- [web-platform-tests] Velmont closed pull request #272: Change crosssite host name to www2 (master...master) https://github.com/w3c/web-platform-tests/pull/272
  142. # [17:32] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  143. # [17:32] * Joins: gitbot (~gitbot@public.cloak)
  144. # [17:32] -gitbot:#testing- [web-platform-tests] Velmont pushed 2 new commits to master: https://github.com/w3c/web-platform-tests/compare/4d2a2b6cb44d...8bf21c32d628
  145. # [17:32] -gitbot:#testing- web-platform-tests/master ec1a757 Arthur Barstow: Change crosssite host name to www2
  146. # [17:32] -gitbot:#testing- web-platform-tests/master 8bf21c3 Odin Hørthe Omdal: Merge pull request #272 from AFBarstow/master...
  147. # [17:32] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  148. # [17:32] <jgraham> odinho: Bah, I did the review first
  149. # [17:37] <odinho> jgraham: lol, I used github's tool.
  150. # [17:37] <odinho> It was 3 lines
  151. # [17:37] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  152. # [17:37] <jgraham> there's no evidence that you did anything at all :)
  153. # [17:46] * Joins: jhammel (~jhammel@public.cloak)
  154. # [18:08] * Disconnected
  155. # [18:09] * Attempting to rejoin channel #testing
  156. # [18:09] * Rejoined channel #testing
  157. # [18:17] * Joins: rhauck (~Adium@public.cloak)
  158. # [18:18] <jgraham> Anyone object if I create github.com/w3c/wptserve and fork it to work on?
  159. # [18:19] * jgraham realises he doesn't really mind if anyone cares
  160. # [18:22] * Quits: rhauck (~Adium@public.cloak) ("Leaving.")
  161. # [18:22] * Joins: rhauck (~Adium@public.cloak)
  162. # [18:22] <jgraham> (done)
  163. # [18:23] * Quits: rhauck (~Adium@public.cloak) (Client closed connection)
  164. # [18:24] <jgraham> ArtB: I don't know what you are doing, but github seems to think that you keep pushing new commits to old PRs
  165. # [18:24] * Joins: rhauck (~Adium@public.cloak)
  166. # [18:24] <jgraham> Well, actually
  167. # [18:24] <jgraham> I think the problem is that you have used the master branch for multiple things
  168. # [18:25] <jgraham> and so when critic updates it, it gets a bunch of extra stuff
  169. # [18:25] <jgraham> Generally one branch per PR is a good idea
  170. # [18:28] <ArtB> (I don't know why I keep getting critic emails so I've just been deleting them ;-))
  171. # [18:28] <jgraham> Well there are two problems :)
  172. # [18:29] <jgraham> One is that critic doesn't seem to be getting notified by github when PRs are closed
  173. # [18:29] <jgraham> Or it is getting notified, but doesn't close the review, although the code to do that is clearly there
  174. # [18:29] <jgraham> the other problem is that you are creating reviews from the master branch
  175. # [18:29] <jgraham> Which isn't very hygenic
  176. # [18:38] <darobin> oooh, some jgraham hot action on the server side
  177. # [18:41] <darobin> I wish GitHub kept people from making PRs from their master branch
  178. # [18:41] <tobie> ^ +1
  179. # [18:45] <ArtB> sorry for my ignorance here re branches but why is this a (big?) problem?
  180. # [18:45] <jgraham> darobin: well feel free to look at the work so far, but there isn't much
  181. # [18:45] <jgraham> I expect ~100% of the code to be rewritten :)
  182. # [18:45] * jgraham away
  183. # [18:52] <darobin> jgraham: it looks pretty good so far, almost usable
  184. # [18:59] * Quits: darobin (rberjon@public.cloak) (Client closed connection)
  185. # [19:15] <tobie> ArtB: because every pull request you make also starts containing the other pull requests you made and so accepting one implies accepting the previous ones too.
  186. # [19:18] <tobie> ArtB: consider if you made commits 1,2, 3 into PR A, then continuing from the same branch you now make PR B with commit 4
  187. # [19:18] <tobie> PR B will infact reference commits 1,2,3 and 4.
  188. # [19:19] <tobie> So merging B also merges A. Except PR A still stays there.
  189. # [19:19] <tobie> No imagine, if in the meantime, you backed out of A or added commits 5 there. Everything quickly gets out of hand.
  190. # [19:19] <ArtB> oh, I see; thanks tobie; I'll try to do do-the-right-thing going fwd
  191. # [19:21] <tobie> ArtB: as a primer to our doc effort: https://github.com/w3c/testtwf-website/blob/gh-pages/docs/github-101.md
  192. # [19:40] * Joins: Lachy (~Lachy@public.cloak)
  193. # [19:42] * Quits: dom (dom@public.cloak) (Ping timeout: 180 seconds)
  194. # [19:43] * Joins: zcorpan_ (~zcorpan@public.cloak)
  195. # [19:44] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  196. # [20:08] * Joins: timeless (~uid4015@public.cloak)
  197. # [21:47] * Quits: tobie (tobie@public.cloak)
  198. # [22:04] * Joins: tobie (tobie@public.cloak)
  199. # [22:19] * Quits: Ms2ger (~Ms2ger@public.cloak) ("nn")
  200. # [22:27] * Quits: ArtB (~abarsto@public.cloak) (Ping timeout: 180 seconds)
  201. # [22:30] * Joins: abarsto (~abarsto@public.cloak)
  202. # [22:30] * abarsto is now known as ArtB
  203. # [22:43] * Quits: zcorpan_ (~zcorpan@public.cloak) (Client closed connection)
  204. # [22:43] * Joins: zcorpan (~zcorpan@public.cloak)
  205. # [22:51] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  206. # [23:12] * heycam|away is now known as heycam
  207. # Session Close: Tue Aug 13 00:00:00 2013

The end :)