/irc-logs / w3c / #testing / 2013-10-14 / end

Options:

  1. # Session Start: Mon Oct 14 00:00:00 2013
  2. # Session Ident: #testing
  3. # [00:24] * heycam|away is now known as heycam
  4. # [01:40] * Joins: shepazu (schepers@public.cloak)
  5. # [03:35] * heycam is now known as heycam|away
  6. # [04:09] * heycam|away is now known as heycam
  7. # [04:39] * Joins: mdas (~mdas@public.cloak)
  8. # [04:39] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
  9. # [04:40] * Joins: mdas (~mdas@public.cloak)
  10. # [04:41] * Joins: mdas_ (~mdas@public.cloak)
  11. # [04:41] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
  12. # [04:45] * Quits: mdas_ (~mdas@public.cloak) (Client closed connection)
  13. # [04:45] * Joins: mdas (~mdas@public.cloak)
  14. # [04:48] * Joins: mdas_ (~mdas@public.cloak)
  15. # [04:48] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
  16. # [04:52] * Quits: mdas_ (~mdas@public.cloak) (Client closed connection)
  17. # [04:52] * Joins: mdas (~mdas@public.cloak)
  18. # [04:59] * Quits: mdas (~mdas@public.cloak) (Ping timeout: 180 seconds)
  19. # [06:12] * Joins: denis (denis@public.cloak)
  20. # [06:13] * Quits: glenn (~gadams@public.cloak) (Client closed connection)
  21. # [06:13] * Joins: glenn (~gadams@public.cloak)
  22. # [06:21] * Quits: glenn (~gadams@public.cloak) (Ping timeout: 180 seconds)
  23. # [07:07] * heycam is now known as heycam|away
  24. # [07:35] * Joins: glenn (~gadams@public.cloak)
  25. # [08:43] * Joins: Ms2ger (~Ms2ger@public.cloak)
  26. # [08:47] * Joins: dom (dom@public.cloak)
  27. # [09:27] * Quits: glenn (~gadams@public.cloak) (Client closed connection)
  28. # [09:28] * Joins: glenn (~gadams@public.cloak)
  29. # [09:31] * Quits: denis (denis@public.cloak) (Ping timeout: 180 seconds)
  30. # [09:35] * Quits: glenn (~gadams@public.cloak) (Ping timeout: 180 seconds)
  31. # [09:42] * Joins: denis (denis@public.cloak)
  32. # [09:43] * Joins: zqzhang (~zqzhang@public.cloak)
  33. # [09:50] * Quits: zqzhang (~zqzhang@public.cloak) (Ping timeout: 180 seconds)
  34. # [09:57] * Joins: glenn (~gadams@public.cloak)
  35. # [10:18] * Quits: glenn (~gadams@public.cloak) (Client closed connection)
  36. # [10:19] * Joins: glenn (~gadams@public.cloak)
  37. # [10:26] * Quits: glenn (~gadams@public.cloak) (Ping timeout: 180 seconds)
  38. # [10:33] * Quits: Ms2ger (~Ms2ger@public.cloak) ("bbl")
  39. # [10:41] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  40. # [11:27] * Joins: Ms2ger (~Ms2ger@public.cloak)
  41. # [11:29] * Joins: glenn (~gadams@public.cloak)
  42. # [11:36] * Quits: glenn (~gadams@public.cloak) (Ping timeout: 180 seconds)
  43. # [12:18] * Joins: darobin (rberjon@public.cloak)
  44. # [12:19] * Quits: Ms2ger (~Ms2ger@public.cloak) ("bbl")
  45. # [12:26] * Quits: dom (dom@public.cloak) ("")
  46. # [12:27] * Joins: abarsto (~abarsto@public.cloak)
  47. # [12:27] * abarsto is now known as ArtB
  48. # [12:35] * Quits: ArtB (~abarsto@public.cloak) ("Leaving.")
  49. # [12:36] * Joins: abarsto (~abarsto@public.cloak)
  50. # [12:36] * abarsto is now known as ArtB
  51. # [12:44] * Quits: darobin (rberjon@public.cloak) (Client closed connection)
  52. # [13:20] * Joins: Automate_ (~AutomatedTester@public.cloak)
  53. # [13:20] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  54. # [13:22] * Joins: darobin (rberjon@public.cloak)
  55. # [13:25] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  56. # [13:25] * Quits: Automate_ (~AutomatedTester@public.cloak) (Client closed connection)
  57. # [13:29] * Joins: Automate_ (~AutomatedTester@public.cloak)
  58. # [13:33] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Ping timeout: 180 seconds)
  59. # [13:33] * Joins: Ms2ger (~Ms2ger@public.cloak)
  60. # [13:35] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  61. # [13:35] * Quits: Automate_ (~AutomatedTester@public.cloak) (Client closed connection)
  62. # [13:42] * Joins: Automate_ (~AutomatedTester@public.cloak)
  63. # [13:42] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  64. # [13:45] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  65. # [13:45] * Quits: Automate_ (~AutomatedTester@public.cloak) (Client closed connection)
  66. # [14:47] * Joins: mdas (~mdas@public.cloak)
  67. # [14:58] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Ping timeout: 180 seconds)
  68. # [15:00] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  69. # [15:02] * Joins: Automate_ (~AutomatedTester@public.cloak)
  70. # [15:02] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  71. # [15:04] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  72. # [15:08] * Quits: Automate_ (~AutomatedTester@public.cloak) (Client closed connection)
  73. # [15:08] * Joins: Automate_ (~AutomatedTester@public.cloak)
  74. # [15:11] * Joins: gitbot (~gitbot@public.cloak)
  75. # [15:11] -gitbot:#testing- [web-platform-tests] darobin pushed 1 new commit to fix-canvas-generator: https://github.com/w3c/web-platform-tests/commit/5129b1631076bdbaeb234cd9d2e365e8dcb5f0f5
  76. # [15:11] -gitbot:#testing- web-platform-tests/fix-canvas-generator 5129b16 Robin Berjon: implement mapping with file renaming
  77. # [15:11] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  78. # [15:14] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Ping timeout: 180 seconds)
  79. # [15:17] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  80. # [15:17] * Quits: Automate_ (~AutomatedTester@public.cloak) (Client closed connection)
  81. # [15:22] * Joins: Automate_ (~AutomatedTester@public.cloak)
  82. # [15:22] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  83. # [16:26] * Joins: gitbot (~gitbot@public.cloak)
  84. # [16:26] -gitbot:#testing- [web-platform-tests] darobin pushed 3 new commits to fix-canvas-generator: https://github.com/w3c/web-platform-tests/compare/5129b1631076...1aa8a5f76b60
  85. # [16:26] -gitbot:#testing- web-platform-tests/fix-canvas-generator 6647673 Robin Berjon: files now output to the correct locations
  86. # [16:26] -gitbot:#testing- web-platform-tests/fix-canvas-generator 22b64c8 Robin Berjon: change templates to stop linking to index and annotated spec, neither of which are generated
  87. # [16:26] -gitbot:#testing- web-platform-tests/fix-canvas-generator 1aa8a5f Robin Berjon: generated cleaned of index and spec links
  88. # [16:26] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  89. # [16:29] * Joins: gitbot (~gitbot@public.cloak)
  90. # [16:29] -gitbot:#testing- [web-platform-tests] darobin opened pull request #367: Fix canvas generator (master...fix-canvas-generator) https://github.com/w3c/web-platform-tests/pull/367
  91. # [16:29] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  92. # [16:30] <darobin> jgraham, Ms2ger, MikeSmith: the above is the PR that endeavours to fix the generation of canvas tests
  93. # [16:31] <darobin> review by someone who gets Python is likely better :)
  94. # [16:31] <Ms2ger> I'll do it, I guess
  95. # [16:31] * Ms2ger adds to his todo list
  96. # [16:32] <jgraham> Actually I care about it and am currently running tests so can't really rebase my repo
  97. # [16:32] <jgraham> So I can do it now :)
  98. # [16:33] <darobin> sweet
  99. # [16:34] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  100. # [16:34] * Quits: Automate_ (~AutomatedTester@public.cloak) (Client closed connection)
  101. # [16:46] * Joins: Automate_ (~AutomatedTester@public.cloak)
  102. # [16:47] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Ping timeout: 180 seconds)
  103. # [16:55] <jgraham> darobin: Review comments on critic
  104. # [16:55] <jgraham> Some are drive by cleanup
  105. # [16:55] <jgraham> Basically it all looks OK to me
  106. # [16:56] <jgraham> (I didn't carefully examine your choice of mappings)
  107. # [16:56] <darobin> for the mappings I used what was already in place
  108. # [16:56] <jgraham> Oh, OK
  109. # [16:56] <darobin> on the assumption, possibly false, that the previous mapping was ok, or at least agreed upon
  110. # [16:56] <darobin> there's only one file that I moved, because it was obviously crazy
  111. # [16:58] <Ms2ger> Nah, the previous mapping was just what you did ;)
  112. # [16:58] <darobin> jgraham: re newlines after : I can't say I care, I just followed the style already in use
  113. # [16:58] <darobin> Ms2ger: yeah, but no one has complained in 10 months :)
  114. # [16:58] <jgraham> darobin: I can say I care and the style already in use seems to be "mixed"
  115. # [16:59] <jgraham> (it's pretty poor python style not to have newlines after : always)
  116. # [17:07] * Joins: gitbot (~gitbot@public.cloak)
  117. # [17:07] -gitbot:#testing- [web-platform-tests] darobin pushed 3 new commits to fix-canvas-generator: https://github.com/w3c/web-platform-tests/compare/1aa8a5f76b60...d57fdef66db1
  118. # [17:07] -gitbot:#testing- web-platform-tests/fix-canvas-generator e2f58eb Robin Berjon: newlines after :
  119. # [17:07] -gitbot:#testing- web-platform-tests/fix-canvas-generator 9187c68 Robin Berjon: unnecessary variables
  120. # [17:07] -gitbot:#testing- web-platform-tests/fix-canvas-generator d57fdef Robin Berjon: better header comments
  121. # [17:07] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  122. # [17:08] <darobin> jgraham: responded with fixes
  123. # [17:09] <jgraham> The best kind of response, I fell
  124. # [17:09] <jgraham> *feel
  125. # [17:09] <darobin> depends on the fixes :)
  126. # [17:10] <Ms2ger> darobin, drive-by nit: "HTML5 test suite", get rid of the HTML5 bit
  127. # [17:10] <jgraham> darobin: Rewriting history in-place like that makes critic sad, and that makes me sad
  128. # [17:10] * Quits: ArtB (~abarsto@public.cloak) ("Leaving.")
  129. # [17:10] * Joins: glenn (~gadams@public.cloak)
  130. # [17:10] <darobin> jgraham: I rewrote history?
  131. # [17:10] <darobin> I just pushed new changes!
  132. # [17:10] <jgraham> You didn't?
  133. # [17:11] <jgraham> Then why is critic sad?
  134. # [17:11] <jgraham> OK, it doesn't look like it's your fault
  135. # [17:11] <jgraham> Sorry :)
  136. # [17:11] <darobin> now *I* am sad
  137. # [17:11] <darobin> Ms2ger: that part wasn't me :)
  138. # [17:11] <darobin> but yeah, fixing
  139. # [17:13] <jgraham> darobin: Oh, seems to have been some kind of locking issue that has fixed itself now
  140. # [17:14] <jgraham> (and you don't need to say that you fixed all the issues, it can figure that out for itself)
  141. # [17:14] <darobin> I didn't say anything, I just commented
  142. # [17:16] * Joins: gitbot (~gitbot@public.cloak)
  143. # [17:16] -gitbot:#testing- [web-platform-tests] darobin pushed 1 new commit to fix-canvas-generator: https://github.com/w3c/web-platform-tests/commit/9b6138ded12fcefce860a77ac9419e547e1217fb
  144. # [17:16] -gitbot:#testing- web-platform-tests/fix-canvas-generator 9b6138d Robin Berjon: political cleanup of HTML name
  145. # [17:16] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  146. # [17:17] <darobin> Ms2ger: I replaced as many instances of "HTML5" as viable, I had to leave philip.html5.org as is though :)
  147. # [17:17] * Quits: Ms2ger (~Ms2ger@public.cloak) (Ping timeout: 180 seconds)
  148. # [17:17] <jgraham> Right, comments like "Fixed in e2f58eb" are usually redundant since critic works that out for itself
  149. # [17:19] <darobin> ah, gotcha
  150. # [17:29] * Joins: Ms2ger (~Ms2ger@public.cloak)
  151. # [17:33] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
  152. # [17:34] * Joins: mdas (~mdas@public.cloak)
  153. # [17:37] <jgraham> darobin: (one more comment)
  154. # [17:37] <darobin> yes Detective
  155. # [17:37] <jgraham> (and you know, if you added your email address to critic, I wouldn't have to ping you here)
  156. # [17:39] <darobin> mmm, I thought I'd done that
  157. # [17:39] <darobin> maybe it was before you resetted it?
  158. # [17:40] <darobin> anyway, done too
  159. # [17:41] * Quits: mdas (~mdas@public.cloak) (Ping timeout: 180 seconds)
  160. # [17:42] <jgraham> darobin: OK, Accepted
  161. # [17:42] <darobin> \o/
  162. # [17:42] <jgraham> I'll let you merge in case you want to edit history or something
  163. # [17:42] <darobin> nah
  164. # [17:43] <darobin> but I'll do it, ta
  165. # [17:43] * Joins: gitbot (~gitbot@public.cloak)
  166. # [17:43] -gitbot:#testing- [web-platform-tests] darobin closed pull request #367: Fix canvas generator (master...fix-canvas-generator) https://github.com/w3c/web-platform-tests/pull/367
  167. # [17:43] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  168. # [17:43] * Joins: gitbot (~gitbot@public.cloak)
  169. # [17:43] -gitbot:#testing- [web-platform-tests] darobin pushed 1 new commit to master: https://github.com/w3c/web-platform-tests/commit/4ae8b1b73d7ef905fb9d3303cd19917af66812a9
  170. # [17:43] -gitbot:#testing- web-platform-tests/master 4ae8b1b Robin Berjon: Merge pull request #367 from w3c/fix-canvas-generator...
  171. # [17:43] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  172. # [17:44] <darobin> jgraham: just for my instruction, is converting to a set not the proper way of getting a list with unique items?
  173. # [17:45] <jgraham> darobin: No, that's fine. I just didn't realise the items were non-unique
  174. # [17:45] <darobin> ah, k
  175. # [17:45] <jgraham> (it might not be the *best*, way, I'm not sure)
  176. # [17:45] <darobin> I thought Python only had one way of doing anything
  177. # [17:46] <jgraham> Preferably only one obvious way, in fact
  178. # [17:46] <jgraham> "There should be one-- and preferably only one --obvious way to do it."
  179. # [17:47] <jgraham> (not sure what's going on with the punctuation there)
  180. # [17:47] <darobin> I stared at it for a few seconds wondering what the pun with decrements was
  181. # [17:49] * Joins: michou1 (~mibalan@public.cloak)
  182. # [17:53] * Joins: abarsto (~abarsto@public.cloak)
  183. # [17:53] * abarsto is now known as ArtB
  184. # [17:58] * Quits: Automate_ (~AutomatedTester@public.cloak) (Client closed connection)
  185. # [17:58] * Quits: michou1 (~mibalan@public.cloak) ("Leaving.")
  186. # [18:05] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  187. # [18:16] * Joins: mdas (~mdas@public.cloak)
  188. # [18:27] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  189. # [18:28] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  190. # [18:38] <jgraham> Hmm 165 timeouts to investigate
  191. # [18:38] <jgraham> Fun fun fun
  192. # [18:39] <Ms2ger> See, this is easier in servo
  193. # [18:39] <Ms2ger> They all time out
  194. # [18:39] <jgraham> :)
  195. # [18:40] <jgraham> Actually, I should probably rebase my branch first
  196. # [18:40] <jgraham> But that seems like suffering incarnate
  197. # [18:51] * Quits: darobin (rberjon@public.cloak) (Client closed connection)
  198. # [18:57] * Joins: jhammel (~jhammel@public.cloak)
  199. # [19:05] * Quits: denis (denis@public.cloak) ("Bye")
  200. # [19:22] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
  201. # [19:22] * Joins: mdas (~mdas@public.cloak)
  202. # [19:23] * Joins: mdas_ (~mdas@public.cloak)
  203. # [19:23] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
  204. # [19:46] * Quits: ArtB (~abarsto@public.cloak) ("Leaving.")
  205. # [19:56] * Joins: michou (~Adium@public.cloak)
  206. # [20:00] * Quits: glenn (~gadams@public.cloak) (Client closed connection)
  207. # [20:00] * Joins: glenn (~gadams@public.cloak)
  208. # [20:07] * Quits: glenn (~gadams@public.cloak) (Ping timeout: 180 seconds)
  209. # [20:27] <michou> plinss: ping?
  210. # [20:28] <plinss> pong
  211. # [20:28] <michou> could you help me a hg-git merge problem?
  212. # [20:28] <plinss> sure
  213. # [20:29] <michou> I'm closely following http://wiki.csswg.org/test/pullrequests while trying to merge some of Rebecca's multicol tests
  214. # [20:29] <plinss> ok
  215. # [20:30] <michou> the problem is, after doing hg pull git://github.com/rhauck/csswg-test.git in step 6
  216. # [20:30] <michou> in step 7 I get a *WHOLE* bunch of commits, going back as far as July, from multiple people, not just Rebecca
  217. # [20:31] <plinss> is a "whole bunch" on the order of 2000 or so?
  218. # [20:31] <michou> yeah, something like that
  219. # [20:31] <plinss> what version of hg0git do you have installed?
  220. # [20:31] <michou> I don't have a precise count, but I remember seeing something about fetching ~1700 objects
  221. # [20:31] <michou> i'm not sure, how do I check?
  222. # [20:32] <michou> it should be 0.3.4 IIRC
  223. # [20:32] <plinss> the only way I know is to look in the python lib directory
  224. # [20:32] <plinss> yeah, it needs to be 0.3.4, v0.4.0 has a bug that causes a weird branch and a few thousand extra changesets
  225. # [20:34] <plinss> what os are you using?
  226. # [20:34] <michou> ok, lemme just find that lib directory
  227. # [20:36] <michou> plinss: any idea where that lib directory is on a Mac? :D
  228. # [20:37] <plinss> depends on if you're using the built in python or installed another version
  229. # [20:37] <plinss> I'm using a python installed by macports, so mine is in /opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages
  230. # [20:39] <plinss> if you're using the os provided python it'll be in /Library/Python/2.7/site-packages
  231. # [20:39] <plinss> (I think)
  232. # [20:39] <plinss> you're looking for a directory called: hg_git-0.3.4-py2.7.egg or hg_git-0.4.0-py2.7.egg
  233. # [20:40] <michou> yup, it's hggit 0.3.4
  234. # [20:40] <plinss> hmm
  235. # [20:41] <michou> the only thing that comes to my mind is that i didn't do a hg pull -u before doing the pull from github
  236. # [20:41] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  237. # [20:41] <plinss> how far out of date was your local hg repo?
  238. # [20:42] <michou> I'm not really sure
  239. # [20:42] <michou> it could have been a couple of months old
  240. # [20:44] <plinss> I suppose it's possible that could be the issue if hg-git didn't match the changeset hashes properly
  241. # [20:44] <plinss> which PR are you trying to merge? I'll try it here
  242. # [20:44] <michou> https://github.com/w3c/csswg-test/pull/89
  243. # [20:45] <plinss> ok, I'm pulling it now
  244. # [20:49] <michou> ok
  245. # [20:52] <plinss> I get about 40 changesets that are new
  246. # [20:52] <michou> sounds more like it
  247. # [20:53] <plinss> My guess is that you got messed up by not being in sync
  248. # [20:53] <plinss> I'd delete your repo so it doesn't get pushed
  249. # [20:53] <plinss> I'll go ahead an push rebecca's PR
  250. # [20:54] <michou> ok, so basically i should remove the test-github repo that gets created in step 5, right?
  251. # [20:55] <plinss> which ever one you pulled form github into that has all the extra changesets
  252. # [20:55] <michou> yeah, that one
  253. # [20:55] <michou> ok, I'll do that
  254. # [20:56] <michou> well, thanks a lot for the help :)
  255. # [20:56] <plinss> ok, that PR is landed in the hg repo, it should sync to GH in a few minutes
  256. # [20:56] <plinss> np
  257. # [20:56] <plinss> fwiw, I'm working on automating the whole process in Shepherd right now and having it sync bi-directionally with GitHub, so this shouldn't be an issue soon
  258. # [20:56] <michou> awesome! :D
  259. # [20:57] <michou> having to do all this voodoo was nothing I was necessarily fond of :)
  260. # [20:57] <plinss> if it all works, you should just be able to merge PRs in GH
  261. # [20:57] <michou> can't wait!
  262. # [20:58] <michou> I'm off; again, thanks a lot & have a great day!
  263. # [20:58] <plinss> np
  264. # [21:00] * Quits: Ms2ger (~Ms2ger@public.cloak) (Ping timeout: 180 seconds)
  265. # [21:01] * Quits: michou (~Adium@public.cloak) ("Leaving.")
  266. # [21:11] * Joins: glenn (~gadams@public.cloak)
  267. # [21:12] * Joins: Ms2ger (~Ms2ger@public.cloak)
  268. # [21:13] * Joins: zcorpan (~zcorpan@public.cloak)
  269. # [21:18] * Joins: zcorpan_ (~zcorpan@public.cloak)
  270. # [21:19] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  271. # [21:37] * Quits: Ms2ger (~Ms2ger@public.cloak) ("nn")
  272. # [22:22] * Quits: jhammel (~jhammel@public.cloak) (Ping timeout: 180 seconds)
  273. # [22:24] * Joins: jhammel (~jhammel@public.cloak)
  274. # [23:25] * Quits: zcorpan_ (~zcorpan@public.cloak) (Client closed connection)
  275. # [23:25] * Joins: zcorpan (~zcorpan@public.cloak)
  276. # [23:32] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  277. # [23:55] * Quits: mdas_ (~mdas@public.cloak) (Client closed connection)
  278. # [23:56] * Joins: mdas (~mdas@public.cloak)
  279. # Session Close: Tue Oct 15 00:00:00 2013

The end :)