Options:
- # Session Start: Mon Oct 21 00:00:00 2013
- # Session Ident: #testing
- # [02:44] * Quits: tobie (tobie@public.cloak)
- # [08:05] * Joins: zcorpan (~zcorpan@public.cloak)
- # [08:42] * Joins: Ms2ger (~Ms2ger@public.cloak)
- # [09:15] * Joins: tobie (tobie@public.cloak)
- # [09:18] * Joins: dom (dom@public.cloak)
- # [09:40] * heycam|away is now known as heycam
- # [10:08] * Joins: michou (~Adium@public.cloak)
- # [10:20] * Quits: Ms2ger (~Ms2ger@public.cloak) ("bbl")
- # [10:21] * Quits: shepazu (schepers@public.cloak) ("is sleepy")
- # [10:48] * Joins: kennyluck (~kennyluck@public.cloak)
- # [11:13] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
- # [11:22] * Joins: Ms2ger (~Ms2ger@public.cloak)
- # [11:26] <jgraham> So I'm thinking that I should just start a review for my python branch
- # [11:26] <Ms2ger> Go for it
- # [11:27] <jgraham> What would people prefer? A single commit? A large number of messy commits? Me to spend some time trying to clean up the commits a little bit so it is slightly messy rather than very messy?
- # [11:27] <AutomatedTester> commits dont matter code does
- # [11:27] <AutomatedTester> we can always --squash it when it lands
- # [11:28] <Ms2ger> For reviews, commits matter a lot
- # [11:29] <jgraham> Well
- # [11:29] <AutomatedTester> as long as critic sees that the issue is resolved I dont see how 5 commits vs 3 commits makes any difference
- # [11:29] <jgraham> Not that much with critic, perhaps
- # [11:30] <jgraham> Since you can filter yourself to changes on particular paths and mark each file reviewed when it's done
- # [11:30] <Ms2ger> Anyway, multiple commits are only useful if they're well delineated
- # [11:34] <jgraham> Yeah
- # [11:34] <jgraham> Well first I will try to work out how to rebase, which seems to be harder than I expected
- # [11:35] <jgraham> Oooh, it's a bug in git
- # [11:36] <Ms2ger> Duh :)
- # [11:39] * jgraham cowers from the scorn of Ms2ger
- # [11:39] <Ms2ger> :D
- # [11:39] <jgraham> (and then subtly drops in the fact that "mach bootstrap" has to install the latest version of hg to avoid badness in older versions)
- # [11:43] <Ms2ger> Heh
- # [12:17] * Joins: denis (denis@public.cloak)
- # [12:26] * Quits: denis (denis@public.cloak) ("Bye")
- # [12:27] * Joins: abarsto (~abarsto@public.cloak)
- # [12:27] * abarsto is now known as ArtB
- # [12:28] * Joins: denis (denis@public.cloak)
- # [12:34] * Joins: darobin (rberjon@public.cloak)
- # [12:42] * Quits: Ms2ger (~Ms2ger@public.cloak) ("bbl")
- # [12:51] * Joins: gitbot (~gitbot@public.cloak)
- # [12:51] -gitbot:#testing- [web-platform-tests] jgraham created jgraham/python_review (+1 new commit): https://github.com/w3c/web-platform-tests/commit/319516d2a235
- # [12:51] -gitbot:#testing- web-platform-tests/jgraham/python_review 319516d James Graham: Make tests self-hosting...
- # [12:51] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [12:56] * Joins: gitbot (~gitbot@public.cloak)
- # [12:56] -gitbot:#testing- [web-platform-tests] jgraham opened pull request #378: Make tests self-hosting (master...jgraham/python_review) https://github.com/w3c/web-platform-tests/pull/378
- # [12:56] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [13:13] <MikeSmith> wow that's a big changeset
- # [13:13] <jgraham> :)
- # [13:13] <jgraham> MikeSmith: I'll assign the whole thing to you ;)
- # [13:13] <MikeSmith> heh
- # [13:32] * Joins: Ms2ger (~Ms2ger@public.cloak)
- # [13:37] <jgraham> Anyone want to be a reviewer on the self-hosting review?
- # [13:38] <jgraham> I guess I should ping public-test-infra
- # [13:39] <Ms2ger> Yeah
- # [13:41] <zcorpan> i can help reviewing, but first i want to install the server
- # [13:41] <Ms2ger> jgraham, what's up with the timeout changes?
- # [13:43] <jgraham> Ms2ger: I guess that's also on this branch :)
- # [13:44] <jgraham> It moves to a system where tests either have a normal or long timeout, specified in a meta element
- # [13:44] <jgraham> That, perhaps should have been a seperate review or something
- # [13:45] <Ms2ger> I thought I already reviewed that
- # [13:45] <Ms2ger> https://critic.hoppipolla.co.uk/r/320
- # [13:47] <Ms2ger> No, not that one
- # [13:47] <Ms2ger> https://critic.hoppipolla.co.uk/r/322
- # [13:48] <jgraham> Oh
- # [13:48] <jgraham> Ah, that didn't get merged
- # [13:48] <jgraham> Sorry :(
- # [13:49] <jgraham> I totally forgot about that
- # [13:49] <jgraham> The critic dashboard isn't so useful when there are hundreds of reviews open
- # [13:50] <Ms2ger> Really? ;)
- # [13:50] <jgraham> So now I don't know what to do :)
- # [13:51] <jgraham> I think that most of the issues in that review are non-issues
- # [13:51] <Ms2ger> Sure
- # [13:51] <jgraham> So I would be happy to merge it
- # [13:52] <jgraham> I could merge that to master, rebase the other review on master and tell critic about the rebase
- # [13:52] <Ms2ger> That would be nice, I think
- # [13:52] <jgraham> Which might get us into a better state. But I'm not sure that you can squash across rebases in critic
- # [13:53] <jgraham> So the other option is to merge that and drop the new review, making odinho redo some work
- # [13:53] <jgraham> I think that's probably best
- # [13:53] <jgraham> (sorry odinho)
- # [13:53] <zcorpan> or drop the old meta change?
- # [13:54] <jgraham> You mean r/322?
- # [13:54] <jgraham> That works too I guess
- # [13:54] <Ms2ger> I'd rather keep those two separate
- # [13:54] <zcorpan> jgraham: right
- # [13:55] <jgraham> Ms2ger: Fancy finishing off the first review?
- # [13:56] <Ms2ger> Sure
- # [13:56] * Ms2ger makes himself a reviewer
- # [13:58] <Ms2ger> I wonder why these idb tests need such long timeout
- # [13:58] <Ms2ger> s
- # [14:00] <jgraham> I don't know
- # [14:00] <jgraham> Maybe they don't
- # [14:00] <jgraham> odinho: &
- # [14:00] <jgraham> s/&/^/
- # [14:02] <Ms2ger> Hmm, script scheduling tests
- # [14:07] <Ms2ger> jgraham, done
- # [14:16] <jgraham> Ms2ger: Awesome, thanks
- # [14:17] <Ms2ger> Now enjoy rebasing that :)
- # [14:18] <jgraham> Yeah, there is that :)
- # [14:19] * Joins: gitbot (~gitbot@public.cloak)
- # [14:19] -gitbot:#testing- [web-platform-tests] jgraham closed pull request #378: Make tests self-hosting (master...jgraham/python_review) https://github.com/w3c/web-platform-tests/pull/378
- # [14:19] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [14:23] <zcorpan> jgraham: cors/003.html fails on webplatform.test and w3c-test.org but passes on t/ (in presto)
- # [14:24] <zcorpan> and the failures are different
- # [14:32] * Quits: denis (denis@public.cloak) ("Bye")
- # [14:32] <jgraham> Yeah, I noticed that sometimes the fails are different
- # [14:32] <jgraham> I suspect it's a bug in wptserve or in the .py script
- # [14:34] * Joins: denis (denis@public.cloak)
- # [14:34] <jgraham> (I think the cookie stuff is broken, but I'm not sure if that's what's causing the bug)
- # [14:38] <zcorpan> GET /old-tests/submission/Opera/media/track/track-element/cors/support/cors-tester.py?read=true&id=22423f1a-c227-4de2-b775-6182bd241dfa HTTP/1.1
- # [14:39] <zcorpan> HTTP/1.0 404 Not Found
- # [14:40] <jgraham> Oh
- # [14:40] <jgraham> That seems wrong
- # [14:44] <zcorpan> jgraham: also GET /old-tests/submission/Opera/media/track/track-element/cors/support/cors-tester.py?id=22423f1a-c227-4de2-b775-6182bd241dfa HTTP/1.1 seems to have no response at all
- # [14:44] * Quits: Ms2ger (~Ms2ger@public.cloak) ("bbl")
- # [14:44] <jgraham> zcorpan: OK, I need to look at this again. Which I will do as soon as I fix the issues on the timeout branch
- # [14:45] <zcorpan> ok
- # [14:51] * Quits: denis (denis@public.cloak) ("Bye")
- # [15:05] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
- # [15:05] * Joins: mdas (~mdas@public.cloak)
- # [15:05] <jgraham> No Ms2ger? :(
- # [15:06] <jgraham> Anyone want to review r/322? The last push was just a lot of delete-trailing-whitespace
- # [15:07] * Joins: denis (denis@public.cloak)
- # [15:12] * Quits: mdas (~mdas@public.cloak) (Ping timeout: 180 seconds)
- # [15:21] <zcorpan> sure
- # [15:23] <zcorpan> done
- # [15:30] * Joins: gitbot (~gitbot@public.cloak)
- # [15:30] -gitbot:#testing- [web-platform-tests] jgraham pushed 1 new commit to jgraham/python_review: https://github.com/w3c/web-platform-tests/commit/94af471f72054570eef9043480da1d341e95cd57
- # [15:30] -gitbot:#testing- web-platform-tests/jgraham/python_review 94af471 James Graham: fixup! Make tests self-hosting
- # [15:30] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [15:35] * Joins: gitbot (~gitbot@public.cloak)
- # [15:35] -gitbot:#testing- [web-platform-tests] jgraham pushed 1 new commit to jgraham/python_review: https://github.com/w3c/web-platform-tests/commit/dacec8926d81054dae84fbaabb946cfe97e87444
- # [15:35] -gitbot:#testing- web-platform-tests/jgraham/python_review dacec89 James Graham: fixup! Make tests self-hosting
- # [15:35] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [15:35] <jgraham> zcorpan: Pushed a fix to cors-tester.py
- # [15:36] <jgraham> Things still don't work right, but you get responses now
- # [15:37] * Joins: mdas (~mdas@public.cloak)
- # [15:38] <jgraham> Oh, but I think I probably broke things in a different way
- # [15:38] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
- # [15:38] * Joins: mdas (~mdas@public.cloak)
- # [15:38] <jgraham> Or maybe not?
- # [15:39] * Joins: gitbot (~gitbot@public.cloak)
- # [15:39] -gitbot:#testing- [web-platform-tests] jgraham pushed 1 new commit to jgraham/python_review: https://github.com/w3c/web-platform-tests/commit/a08c91ca56dec4c953b669c69ad4c0162e0b30fc
- # [15:39] -gitbot:#testing- web-platform-tests/jgraham/python_review a08c91c James Graham: fixup! Make tests self-hosting
- # [15:39] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [15:39] * jgraham reverts the status code to 404
- # [15:41] * Joins: mdas_ (~mdas@public.cloak)
- # [15:41] <zcorpan> jgraham: should i be using the _review branch?
- # [15:41] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
- # [15:45] <jgraham> zcorpan: I think that makes sense
- # [15:45] <jgraham> But I will make a _review_2 branch once I rebase onto the timeout changes branch (which I will do now)
- # [15:46] <jgraham> Or just force push to that branch, but gh might not like that
- # [15:46] <zcorpan> ok now i get a different result. "requests": [{}, {}, {}, {}]
- # [15:48] <zcorpan> and assert_object_equals: unexpected property "WEBVTT"
- # [15:53] <zcorpan> so the read=true request gets a WEBVTT file as response
- # [15:55] * Quits: denis (denis@public.cloak) (Ping timeout: 180 seconds)
- # [15:56] <jgraham> What's supposed to happen?
- # [15:56] <jgraham> It should return the data that was set?
- # [15:57] <zcorpan> yeah
- # [15:57] <jgraham> OK, with that change it looks better
- # [15:57] <odinho> jgraham: You can both move base, and change history in critic.
- # [15:57] <odinho> jgraham: ONly thing is that you have to do it in two steps.
- # [15:57] <odinho> One at a time.
- # [15:57] <odinho> Don't know about the github integration though.
- # [15:57] <odinho> It was always less powerful :)
- # [15:58] <jgraham> odinho: But you can't squash the review across a rebase
- # [15:58] <jgraham> (unless modern critic gained that ability; the gh branch is some way behind)
- # [15:59] <odinho> But do you need to do both at the same time?
- # [16:01] <jgraham> odinho: No, I mean you can't *view* it squashed
- # [16:01] <jgraham> So if you have
- # [16:01] <jgraham> New commit
- # [16:01] <jgraham> Equivalent Merge Commit
- # [16:01] <jgraham> old commit
- # [16:02] <jgraham> You can't view all three commits at once
- # [16:02] <jgraham> in a squashed view
- # [16:03] * Joins: gitbot (~gitbot@public.cloak)
- # [16:03] -gitbot:#testing- [web-platform-tests] jgraham pushed 1 new commit to jgraham/python_review: https://github.com/w3c/web-platform-tests/commit/b1486aa82b4174df577bb00f1796fe4a5bc5bffc
- # [16:03] -gitbot:#testing- web-platform-tests/jgraham/python_review b1486aa James Graham: fixup! Make tests self-hosting
- # [16:03] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [16:03] <jgraham> zcorpan: Pushed some more fixes
- # [16:04] <zcorpan> jgraham: ok, i'll check it later
- # [16:04] <jgraham> Thanks
- # [16:04] * Joins: denis (denis@public.cloak)
- # [16:08] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
- # [16:08] * Joins: zcorpan (~zcorpan@public.cloak)
- # [16:15] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
- # [16:30] <jgraham> Anyone want to finish off r/322 for me?
- # [16:30] <jgraham> i.e. review it
- # [16:30] <jgraham> I will ignore the remaining open issues
- # [16:46] * Quits: mdas_ (~mdas@public.cloak) (Client closed connection)
- # [16:47] * Joins: mdas (~mdas@public.cloak)
- # [16:47] * Joins: mdas_ (~mdas@public.cloak)
- # [16:47] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
- # [17:05] * Joins: Ms2ger (~Ms2ger@public.cloak)
- # [17:10] * Quits: kennyluck (~kennyluck@public.cloak) (kennyluck)
- # [17:14] * heycam is now known as heycam|away
- # [17:18] * Joins: zcorpan (~zcorpan@public.cloak)
- # [17:25] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
- # [18:02] * Quits: darobin (rberjon@public.cloak) (Client closed connection)
- # [18:11] * Joins: gitbot (~gitbot@public.cloak)
- # [18:11] -gitbot:#testing- [web-platform-tests] jgraham closed pull request #340: Update tests to use normal/long harness timeouts (master...timeout_update) https://github.com/w3c/web-platform-tests/pull/340
- # [18:11] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [18:11] * Joins: gitbot (~gitbot@public.cloak)
- # [18:11] -gitbot:#testing- [web-platform-tests] jgraham pushed 4 new commits to master: https://github.com/w3c/web-platform-tests/compare/bf217ebec0e3...76e0d1ba75c9
- # [18:11] -gitbot:#testing- web-platform-tests/master 08b9f36 James Graham: Update tests to use normal/long harness timeouts
- # [18:11] -gitbot:#testing- web-platform-tests/master 966f8f2 James Graham: Fix review issues
- # [18:11] -gitbot:#testing- web-platform-tests/master 5d49347 James Graham: Give all reflection tests long timeouts
- # [18:11] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [18:27] * Joins: kennyluck (~kennyluck@public.cloak)
- # [18:41] * Quits: Ms2ger (~Ms2ger@public.cloak) (Ping timeout: 180 seconds)
- # [18:43] * Joins: jhammel (~jhammel@public.cloak)
- # [18:43] * Parts: jhammel (~jhammel@public.cloak) (jhammel)
- # [18:43] * Quits: dom (dom@public.cloak) ("")
- # [18:49] * Joins: zcorpan (~zcorpan@public.cloak)
- # [19:07] * Joins: zcorpan_ (~zcorpan@public.cloak)
- # [19:12] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
- # [19:12] * Quits: zcorpan_ (~zcorpan@public.cloak) (Client closed connection)
- # [19:13] * Joins: zcorpan (~zcorpan@public.cloak)
- # [19:20] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
- # [19:22] * Joins: zcorpan (~zcorpan@public.cloak)
- # [19:30] * Quits: denis (denis@public.cloak) ("Bye")
- # [19:38] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
- # [19:38] * Joins: zcorpan (~zcorpan@public.cloak)
- # [19:45] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
- # [20:04] * Joins: zcorpan (~zcorpan@public.cloak)
- # [20:12] * Quits: michou (~Adium@public.cloak) ("Leaving.")
- # [20:18] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
- # [20:18] * Joins: zcorpan (~zcorpan@public.cloak)
- # [20:19] * Joins: zcorpan_ (~zcorpan@public.cloak)
- # [20:19] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
- # [20:38] * Quits: zcorpan_ (~zcorpan@public.cloak) (Client closed connection)
- # [20:38] * Joins: zcorpan (~zcorpan@public.cloak)
- # [20:42] * Joins: zcorpan_ (~zcorpan@public.cloak)
- # [20:42] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
- # [20:42] * Joins: gitbot (~gitbot@public.cloak)
- # [20:42] -gitbot:#testing- [web-platform-tests] jgraham created jgraham/python_review_2 (+1 new commit): https://github.com/w3c/web-platform-tests/commit/f3c2bffd9588
- # [20:42] -gitbot:#testing- web-platform-tests/jgraham/python_review_2 f3c2bff James Graham: Make tests self-hosting...
- # [20:42] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [20:46] * Joins: gitbot (~gitbot@public.cloak)
- # [20:46] -gitbot:#testing- [web-platform-tests] jgraham opened pull request #379: Make tests self-hosting (master...jgraham/python_review_2) https://github.com/w3c/web-platform-tests/pull/379
- # [20:46] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [20:59] * Joins: Ms2ger (~Ms2ger@public.cloak)
- # [21:03] * Joins: gitbot (~gitbot@public.cloak)
- # [21:03] -gitbot:#testing- [web-platform-tests] jgraham pushed 1 new commit to jgraham/python_review_2: https://github.com/w3c/web-platform-tests/commit/5bfcf7010d34996d347bdfeaa9d7a163ef4dc6b6
- # [21:03] -gitbot:#testing- web-platform-tests/jgraham/python_review_2 5bfcf70 James Graham: fixup! Make tests self-hosting
- # [21:03] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [21:34] * Quits: Ms2ger (~Ms2ger@public.cloak) ("nn")
- # [21:35] * Joins: plh (plehegar@public.cloak)
- # [21:43] * Quits: zcorpan_ (~zcorpan@public.cloak) (Client closed connection)
- # [21:43] * Quits: mdas_ (~mdas@public.cloak) (Client closed connection)
- # [21:43] * Joins: zcorpan (~zcorpan@public.cloak)
- # [21:44] * Joins: mdas (~mdas@public.cloak)
- # [21:46] * Quits: ArtB (~abarsto@public.cloak) ("Leaving.")
- # [21:48] <tobie> Trying to review jgraham's awesome pull request in critic. Really trying my best to figure out the UI, but utterly unsuccessful so far. I just don't get it. Should have been called cryptic.
- # [21:50] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
- # [21:51] * Quits: mdas (~mdas@public.cloak) (Ping timeout: 180 seconds)
- # [22:11] * Joins: abarsto (~abarsto@public.cloak)
- # [22:11] * abarsto is now known as ArtB
- # [22:12] * Joins: zcorpan (~zcorpan@public.cloak)
- # [22:15] <jgraham> tobie: What problem are you having?
- # [22:16] <jgraham> tobie: Maybe the confusion is that I added you as a watcher rather than a reviewer?
- # [22:16] <jgraham> So all the files are marked "pending"
- # [22:17] <jgraham> I can change that
- # [22:17] <tobie> jgraham: honestly, I don't know.
- # [22:17] <tobie> I have no idea what I'm supposed to do.
- # [22:25] <jgraham> tobie: On https://critic.hoppipolla.co.uk/r/368 the commits are listed under "Commits". You click the commit that you want to review (or click down on one commit and drag to the last commit to review several commits at once). If you click on the "Make tests self hosting" commit, you should end up at https://critic.hoppipolla.co.uk/f3c2bffd?review=368 which will give you a list of files that were changed in that commit. If you click on a file you see th[CUT]
- # [22:25] <jgraham> ... an issue, click on the line (or drag across the lines) to which the issue applies. Then there should be a popup dialog that allows you to fill in the issue description. "issues" must be addressed before the review is complete "notes" are optional or informative. Once you have reviewed a file, even if there were issues, you tick the checkbox next to the filename in the list of files changed to indicate that this file has been reviewed. Changes are n[CUT]
- # [22:25] <jgraham> ... submitted; after you have made some changes you need to click "submit changes" (or something) at the top of the page.
- # [22:25] <jgraham> Oh, and I'm told it is quite buggy in IE so don't use that until I upgrade and take the fixes
- # [22:26] <tobie> I don't use IE
- # [22:26] <tobie> I'll give it a try
- # [22:26] <tobie> thanks for the info
- # [22:26] <jgraham> (there is a tutorial at the top where all of this is explained in more detail, but some of that is not relevant to our usage)
- # [22:32] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
- # [22:32] * Joins: zcorpan (~zcorpan@public.cloak)
- # [22:35] * Joins: mdas (~mdas@public.cloak)
- # [22:39] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
- # [22:46] * Joins: zcorpan (~zcorpan@public.cloak)
- # [22:50] * Joins: jhammel_ (~jhammel@public.cloak)
- # [23:57] * Quits: tobie (tobie@public.cloak) (Ping timeout: 180 seconds)
- # Session Close: Tue Oct 22 00:00:00 2013
The end :)