Options:
- # Session Start: Mon Jan 27 00:00:01 2014
- # Session Ident: #testing
- # [00:04] * Quits: smfr (~smfr@public.cloak) (smfr)
- # [00:12] * Joins: florian (~Adium@public.cloak)
- # [00:15] <nebu> Anyone know if there's anything in the ECMAScript spec that says what should happens with an uncaught exception? E.g. is it *required* by spec for a stack trace to be printed or something like that?
- # [00:19] <yankhates_cb> *shrug* doesnt seem like a stacktrace should be printed
- # [00:19] <yankhates_cb> unless just to console
- # [00:22] <nebu> Well, what *should* happen?
- # [00:25] <gsnedders> Execution should stop.
- # [00:25] <gsnedders> It's rather hard to define anything else given a language with no IO.
- # [00:28] <nebu> Got a citation for that in the spec somewhere?
- # [00:30] <gsnedders> It's hard to find a citation for something that isn't stated. That execution is stopped comes of it returning from the global scope in an abnormal state.
- # [00:31] <gsnedders> http://es5.github.io/#x14 defines it, though
- # [00:34] <nebu> Thanks
- # [00:42] * Quits: koji (~koji@public.cloak) (Client closed connection)
- # [00:43] * Joins: koji (~koji@public.cloak)
- # [00:45] * Joins: koji_ (~koji@public.cloak)
- # [00:45] * Quits: koji (~koji@public.cloak) (Client closed connection)
- # [00:48] * Joins: TTWF_SEATTLE (~TTWF_SEATTLE@public.cloak)
- # [00:59] * Quits: outcoldman (~outcoldman@public.cloak) ("Leaving")
- # [01:06] * Joins: gitbot (~gitbot@public.cloak)
- # [01:06] -gitbot:#testing- [web-platform-tests] angrytoast opened pull request #569: Adding tests for data-* attributes (master...angrytoast/html-global-data-attributes) https://github.com/w3c/web-platform-tests/pull/569
- # [01:06] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [01:14] * Joins: ggao (~ggao@public.cloak)
- # [01:15] <krisk> yes #testing is now on the big screen at the event!
- # [01:16] <astearns> in tiny tiny text on the far side of the room
- # [01:17] * Joins: gitbot (~gitbot@public.cloak)
- # [01:17] -gitbot:#testing- [web-platform-tests] ericorange closed pull request #567: Tests for disabled elements (master...ericorange/disabled-elements) https://github.com/w3c/web-platform-tests/pull/567
- # [01:17] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [01:17] * Joins: gitbot (~gitbot@public.cloak)
- # [01:17] -gitbot:#testing- [web-platform-tests] ericorange reopened pull request #567: Tests for disabled elements (master...ericorange/disabled-elements) https://github.com/w3c/web-platform-tests/pull/567
- # [01:17] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [01:22] <bterlson> I'm on TV!!!
- # [01:24] * Joins: smfr (~smfr@public.cloak)
- # [01:27] * Quits: florian (~Adium@public.cloak) ("Leaving.")
- # [01:33] <nebu> Test case for Number.isFinite: assert(Number.isFinite(new Number(2)) === false); //spec says if typeof returns 'object', must return false.
- # [01:34] * Joins: gitbot (~gitbot@public.cloak)
- # [01:34] -gitbot:#testing- [web-platform-tests] timdenney opened pull request #570: Timdenney/disabled form (master...timdenney/disabled-form) https://github.com/w3c/web-platform-tests/pull/570
- # [01:34] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [01:36] * Quits: smfr (~smfr@public.cloak) (smfr)
- # [01:39] * Joins: smfr (~smfr@public.cloak)
- # [01:50] * Joins: ecasler (~ecasler@public.cloak)
- # [01:51] * Joins: florian (~Adium@public.cloak)
- # [01:51] * Quits: florian (~Adium@public.cloak) ("Leaving.")
- # [01:57] * Joins: florian (~Adium@public.cloak)
- # [02:22] <bterlson> If anyone wants to chat about EcmaScript or test262 development on IRC, irc.mozilla.org#jslang is full of implementers at all times of day
- # [02:28] * Quits: koji_ (~koji@public.cloak) (Client closed connection)
- # [02:28] * Joins: koji (~koji@public.cloak)
- # [02:31] * Quits: ecasler (~ecasler@public.cloak) (ecasler)
- # [02:33] * Quits: koji (~koji@public.cloak) (Client closed connection)
- # [02:33] * Joins: ecasler (~ecasler@public.cloak)
- # [02:34] * Joins: koji (~koji@public.cloak)
- # [02:35] * Quits: koji (~koji@public.cloak) (Client closed connection)
- # [02:36] * Joins: koji (~koji@public.cloak)
- # [02:36] * Quits: yankhates_cb (~yankhatescb@public.cloak) (Ping timeout: 180 seconds)
- # [02:52] * Quits: smfr (~smfr@public.cloak) (smfr)
- # [02:55] * Joins: smfr (~smfr@public.cloak)
- # [03:12] * Quits: koji (~koji@public.cloak) (Client closed connection)
- # [03:13] * Joins: gitbot (~gitbot@public.cloak)
- # [03:13] -gitbot:#testing- [web-platform-tests] Revlin opened pull request #571: Test media element load algorithm sequence (master...revlin/html) https://github.com/w3c/web-platform-tests/pull/571
- # [03:13] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [03:13] * Joins: koji (~koji@public.cloak)
- # [03:14] * Quits: revlin (~revlin@public.cloak) ("Page closed")
- # [03:14] * Joins: revlin (~revlin@public.cloak)
- # [03:15] <revlin> I just submitted https://github.com/w3c/web-platform-tests/pull/571 which I wanted to test asynchronously, but the async_test functions were timing out
- # [03:16] <revlin> I left them in the source, just commented out, so can anyone tell just by looking what I may have been doing wrong?
- # [03:20] * Quits: koji (~koji@public.cloak) (Ping timeout: 180 seconds)
- # [03:24] * Quits: ecasler (~ecasler@public.cloak) (ecasler)
- # [03:24] * Joins: yankhates_cb (~yankhatescb@public.cloak)
- # [03:26] * Joins: ecasler (~ecasler@public.cloak)
- # [03:27] <revlin> anyone using async_test() ?
- # [03:27] * Parts: ecasler (~ecasler@public.cloak) (ecasler)
- # [03:28] <nebu> Not me, sorry.
- # [03:29] <revlin> no need to appologize
- # [03:29] <revlin> for personal failings
- # [03:30] <revlin> ;)
- # [03:32] * Joins: mgmeyers (~mgmeyers@public.cloak)
- # [03:32] * Quits: ryanmurakami (~ryanmurakami@public.cloak) ("Page closed")
- # [03:34] * Quits: krisk (~krisk@public.cloak) (Ping timeout: 180 seconds)
- # [03:35] * Quits: madasu (~madasu@public.cloak) ("Page closed")
- # [03:35] <dauwhe> I submitted some tests for GCPM: https://github.com/w3c/csswg-test/pull/433
- # [03:37] * Quits: dauwhe (~dauwhe@public.cloak) (Client closed connection)
- # [03:38] <TTWF_SEATTLE> closing connection.... going on with some drinks here in Seattle!
- # [03:38] <TTWF_SEATTLE> thanks alll.... till the next one!
- # [03:38] * Quits: TTWF_SEATTLE (~TTWF_SEATTLE@public.cloak) ("Page closed")
- # [03:39] * Quits: mgmeyers (~mgmeyers@public.cloak) ("Page closed")
- # [03:40] * Quits: florian (~Adium@public.cloak) ("Leaving.")
- # [03:40] * Quits: smfr (~smfr@public.cloak) (smfr)
- # [03:44] * Quits: ptressel (~chatzilla@public.cloak) ("bbl")
- # [03:46] * Quits: shepazu (schepers@public.cloak) ("is sleepy")
- # [03:47] * Quits: nebu (~nebu@public.cloak) (Ping timeout: 180 seconds)
- # [03:49] * Quits: kawabata2 (~kawabata@public.cloak) (Ping timeout: 180 seconds)
- # [03:50] * Quits: ggao (~ggao@public.cloak) (Ping timeout: 180 seconds)
- # [03:53] * Quits: revlin (~revlin@public.cloak) (Ping timeout: 180 seconds)
- # [04:01] * Quits: yankhates_cb (~yankhatescb@public.cloak) (Ping timeout: 180 seconds)
- # [04:30] * Joins: yankhates_cb (~yankhatescb@public.cloak)
- # [04:38] * Joins: dauwhe (~dauwhe@public.cloak)
- # [04:40] * Quits: yankhates_cb (~yankhatescb@public.cloak) (Ping timeout: 180 seconds)
- # [04:45] * Quits: dauwhe (~dauwhe@public.cloak) (Ping timeout: 180 seconds)
- # [04:58] * Joins: dauwhe (~dauwhe@public.cloak)
- # [05:17] * Quits: dauwhe (~dauwhe@public.cloak) (Client closed connection)
- # [06:17] * Joins: dauwhe (~dauwhe@public.cloak)
- # [06:24] * Quits: dauwhe (~dauwhe@public.cloak) (Ping timeout: 180 seconds)
- # [06:42] * Joins: zcorpan (~zcorpan@public.cloak)
- # [06:44] * Joins: zcorpan_ (~zcorpan@public.cloak)
- # [06:49] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
- # [07:01] * Joins: zcorpan (~zcorpan@public.cloak)
- # [07:01] * Quits: zcorpan_ (~zcorpan@public.cloak) (Client closed connection)
- # [07:05] * Joins: ptressel (~chatzilla@public.cloak)
- # [07:10] * Joins: zcorpan_ (~zcorpan@public.cloak)
- # [07:15] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
- # [07:17] * Joins: dauwhe (~dauwhe@public.cloak)
- # [07:30] * Joins: smfr (~smfr@public.cloak)
- # [07:34] * Joins: shepazu (schepers@public.cloak)
- # [07:44] * Joins: florian (~Adium@public.cloak)
- # [07:44] * Quits: smfr (~smfr@public.cloak) (smfr)
- # [07:52] * Quits: florian (~Adium@public.cloak) ("Leaving.")
- # [08:00] * Quits: lmcliste_ (~lmclister@public.cloak) ("")
- # [08:06] * Quits: dauwhe (~dauwhe@public.cloak) (Client closed connection)
- # [08:36] * Joins: dauwhe (~dauwhe@public.cloak)
- # [08:47] * Quits: ptressel (~chatzilla@public.cloak) ("zzz")
- # [08:47] * Quits: dauwhe (~dauwhe@public.cloak) (Ping timeout: 180 seconds)
- # [08:59] * Joins: Ms2ger (~Ms2ger@public.cloak)
- # [09:13] * Joins: dom (dom@public.cloak)
- # [09:25] * Quits: zcorpan_ (~zcorpan@public.cloak) (Client closed connection)
- # [09:25] * Joins: gitbot (~gitbot@public.cloak)
- # [09:25] -gitbot:#testing- [web-platform-tests] deniak pushed 1 new commit to deniak/ttfw-paris: https://github.com/w3c/web-platform-tests/commit/1d51f10d4d0adbfe03b82183c93e54cd2743c7d3
- # [09:25] -gitbot:#testing- web-platform-tests/deniak/ttfw-paris 1d51f10 Denis Ah-Kang: updates from pythonication
- # [09:25] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [09:25] * Joins: zcorpan (~zcorpan@public.cloak)
- # [09:26] * Joins: zcorpan_ (~zcorpan@public.cloak)
- # [09:26] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
- # [09:27] * Joins: zcorpan (~zcorpan@public.cloak)
- # [09:27] * Quits: zcorpan_ (~zcorpan@public.cloak) (Client closed connection)
- # [09:30] * Joins: gitbot (~gitbot@public.cloak)
- # [09:30] -gitbot:#testing- [web-platform-tests] deniak closed pull request #477: Tests from TTWF Paris (master...deniak/ttfw-paris) https://github.com/w3c/web-platform-tests/pull/477
- # [09:30] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [09:30] * Joins: gitbot (~gitbot@public.cloak)
- # [09:30] -gitbot:#testing- [web-platform-tests] deniak deleted deniak/ttfw-paris at 1d51f10: https://github.com/w3c/web-platform-tests/commit/1d51f10
- # [09:30] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [09:31] * Joins: gitbot (~gitbot@public.cloak)
- # [09:31] -gitbot:#testing- [web-platform-tests] zqzhang closed pull request #280: draggable_attribute, dropzone_attribute and dragevent (master...submission/ibelem/draganddrop) https://github.com/w3c/web-platform-tests/pull/280
- # [09:31] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [09:34] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
- # [09:41] * Joins: dauwhe (~dauwhe@public.cloak)
- # [09:49] * Quits: dauwhe (~dauwhe@public.cloak) (Ping timeout: 180 seconds)
- # [09:56] * Joins: zcorpan (~zcorpan@public.cloak)
- # [09:57] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
- # [09:57] * Joins: zcorpan (~zcorpan@public.cloak)
- # [10:21] * Joins: darobin (rberjon@public.cloak)
- # [10:35] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
- # [10:42] * Joins: dauwhe (~dauwhe@public.cloak)
- # [10:49] * Joins: gitbot (~gitbot@public.cloak)
- # [10:49] -gitbot:#testing- [web-platform-tests] deniak opened pull request #572: move TTWF tests (master...ttfw-paris) https://github.com/w3c/web-platform-tests/pull/572
- # [10:49] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [10:49] * Quits: dauwhe (~dauwhe@public.cloak) (Ping timeout: 180 seconds)
- # [10:53] * Joins: Lachy (~Lachy@public.cloak)
- # [11:28] * Joins: zcorpan (~zcorpan@public.cloak)
- # [11:35] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
- # [11:43] * Joins: dauwhe (~dauwhe@public.cloak)
- # [11:49] * Quits: dauwhe (~dauwhe@public.cloak) (Ping timeout: 180 seconds)
- # [11:59] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
- # [12:04] * Quits: Lachy (~Lachy@public.cloak) ("My MacBook Pro has gone to sleep. ZZZzzz…")
- # [12:17] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
- # [12:17] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
- # [12:17] * Joins: gitbot (~gitbot@public.cloak)
- # [12:17] -gitbot:#testing- [web-platform-tests] jgraham closed pull request #557: fixes on MS async tests + rm trailing ws (master...ms-async) https://github.com/w3c/web-platform-tests/pull/557
- # [12:17] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [12:20] <jgraham> Not much of a "TestTWF bump" this time. Was everyone doing CSS tests?
- # [12:20] <jgraham> Or was Ms2ger just on top of everything?
- # [12:21] <MikeSmith> maybe combination of both
- # [12:25] <Ms2ger> We got 4 or 5 PRs
- # [12:27] <Ms2ger> Looks like css got 7 or so
- # [12:27] <jgraham> Is anyone here other than Ms2ger and I going to FOSDEM?
- # [12:28] <Ms2ger> Not that I heard of
- # [12:28] <jgraham> I am doing a talk about web-platform-tests
- # [12:28] <jgraham> Or about testing the web in general
- # [12:29] * Joins: zcorpan (~zcorpan@public.cloak)
- # [12:30] * Ms2ger suspects zcorpan not either
- # [12:31] <jgraham> No, the only person who seemed reasonably likely was darobin
- # [12:31] <jgraham> But I assume he likes to spend some time at home occasionally
- # [12:32] * Joins: abarsto (~abarsto@public.cloak)
- # [12:32] * abarsto is now known as ArtB
- # [12:33] <darobin> mmmm, you know, I'd promised myself I'd make Fosdem this year
- # [12:33] <darobin> but I guess it'll be next year :(
- # [12:33] <Ms2ger> It's not over yet ;)
- # [12:33] <darobin> Ms2ger: yeah but I'm already at TakeOff the two days before
- # [12:33] <darobin> as jgraham says, it's nice to be home once in a while
- # [12:34] <Ms2ger> Pff
- # [12:34] <Ms2ger> Not even for a unique opportunity to meet me? ;)
- # [12:36] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
- # [12:36] <darobin> damn
- # [12:36] <darobin> hadn't thought of that
- # [12:36] <darobin> well, you could come to TakeOff :)
- # [12:37] <Ms2ger> Not really, I've got an exam to take on Friday :)
- # [12:38] <darobin> bah
- # [12:38] <darobin> you'd learn a hell of a lot more at TakeOff
- # [12:39] <Ms2ger> Plausible :)
- # [12:39] <darobin> last year we learnt the emergency manoeuvre to disable a Parrot drone while in air
- # [12:39] <Ms2ger> Is that some kind of euphemism?
- # [12:40] * Joins: Lachy (~Lachy@public.cloak)
- # [12:40] <jgraham> Did you end up with a dead parrot?
- # [12:40] <Ms2ger> In a cage?
- # [12:40] <jgraham> Sounds sketchy
- # [12:40] <Ms2ger> Very clever
- # [12:40] <Ms2ger> I didn't see that coming at all
- # [12:43] * Joins: dauwhe (~dauwhe@public.cloak)
- # [12:45] * Joins: plh (plehegar@public.cloak)
- # [12:50] * Quits: dauwhe (~dauwhe@public.cloak) (Ping timeout: 180 seconds)
- # [12:56] * Joins: gitbot (~gitbot@public.cloak)
- # [12:56] -gitbot:#testing- [web-platform-tests] Ms2ger closed pull request #559: Remove some useless tests. (master...ms-interface) https://github.com/w3c/web-platform-tests/pull/559
- # [12:56] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [12:56] * Joins: gitbot (~gitbot@public.cloak)
- # [12:56] -gitbot:#testing- [web-platform-tests] jgraham created pr/80 (+2 new commits): https://github.com/w3c/web-platform-tests/compare/9d6d562b4e76^...d3f0acd504e3
- # [12:56] -gitbot:#testing- web-platform-tests/pr/80 9d6d562 Dan Druta: new test files from TestTWF
- # [12:56] -gitbot:#testing- web-platform-tests/pr/80 d3f0acd Dan Druta: Updated the tests with the recommended changes
- # [12:56] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [12:59] * Joins: gitbot (~gitbot@public.cloak)
- # [12:59] -gitbot:#testing- [web-platform-tests] jgraham opened pull request #573: Add document.all tests (master...pr/80) https://github.com/w3c/web-platform-tests/pull/573
- # [12:59] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [13:00] * Joins: gitbot (~gitbot@public.cloak)
- # [13:00] -gitbot:#testing- [web-platform-tests] jgraham pushed 1 new commit to pr/80: https://github.com/w3c/web-platform-tests/commit/e40d463e525121b8e381e9f0fa3ac1950d86de1c
- # [13:00] -gitbot:#testing- web-platform-tests/pr/80 e40d463 James Graham: Update formatting
- # [13:00] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [13:00] * Joins: gitbot (~gitbot@public.cloak)
- # [13:00] -gitbot:#testing- [web-platform-tests] jgraham closed pull request #80: new test files from TestTWF (master...submissions/DanDruta) https://github.com/w3c/web-platform-tests/pull/80
- # [13:00] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [13:00] * Joins: gitbot (~gitbot@public.cloak)
- # [13:00] -gitbot:#testing- [web-platform-tests] jgraham closed pull request #573: Add document.all tests (master...pr/80) https://github.com/w3c/web-platform-tests/pull/573
- # [13:00] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [13:11] * Joins: koji (~koji@public.cloak)
- # [13:29] <odinho> Bah, I forgot FOSDEM too.
- # [13:29] * Joins: zcorpan (~zcorpan@public.cloak)
- # [13:30] <jgraham> odinho: Start walking now and you could make it in time?
- # [13:30] <jgraham> Well actually probably not
- # [13:31] <jgraham> 1400km. Too far to cycle in 5 days even
- # [13:35] <Ms2ger> Maybe cycling 15h a day... But it's already too late for that
- # [13:36] <odinho> Such problem. Very hard.
- # [13:36] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
- # [13:37] <Ms2ger> Only 25 hours by train
- # [13:39] <Ms2ger> Could leave Friday morning and still be in time for the welcome: )
- # [13:43] * Joins: dauwhe (~dauwhe@public.cloak)
- # [13:49] <Ms2ger> btw, darobin...
- # [13:49] <Ms2ger> You introduced a lot of <script /resources/testharnessreport.js></script>s at some point
- # [13:50] <Ms2ger> Care to fix them?
- # [13:50] * Quits: dauwhe (~dauwhe@public.cloak) (Ping timeout: 180 seconds)
- # [13:51] <denis> I can fix that Ms2ger
- # [13:51] <Ms2ger> That works too :)
- # [13:52] <Ms2ger> Or you could review https://critic.hoppipolla.co.uk/r/611?
- # [13:52] * Joins: gitbot (~gitbot@public.cloak)
- # [13:52] -gitbot:#testing- [web-platform-tests] Ms2ger closed pull request #560: Move and rewrite Microsoft's test for the range input type. (master...ms-range) https://github.com/w3c/web-platform-tests/pull/560
- # [13:52] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [13:53] <denis> will take a look
- # [13:54] <darobin> Ms2ger: I'm pretty sure I had fixed those
- # [13:54] <darobin> maybe it's lost in a PR somewhere?
- # [13:54] <Ms2ger> Not impossible
- # [13:54] <Ms2ger> darobin, maybe hidden in the pile of PRs you could review ;)
- # [13:56] * Joins: gitbot (~gitbot@public.cloak)
- # [13:56] -gitbot:#testing- [web-platform-tests] Ms2ger opened pull request #574: Add a test for methods that do nothing. (master...capture-releaseEvents) https://github.com/w3c/web-platform-tests/pull/574
- # [13:56] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [13:56] <darobin> no, it looks like that fix wasn't made, sorry
- # [13:56] <darobin> funny, I was sure I'd fixed that
- # [13:56] <darobin> maybe I did it and forgot part of the tree
- # [13:57] <darobin> anyway, denis let me know in case you don't fix it so that I do
- # [13:57] <darobin> that's what perl -p -i -e was invented for :)
- # [13:57] <denis> darobin, I'll take care of it in a min
- # [13:57] <darobin> denis: you're a star
- # [13:57] <denis> :)
- # [13:59] * Ms2ger approves of pie, not so much of perl
- # [13:59] <Ms2ger> Why can't we have apple -pie?
- # [14:02] <darobin> Ms2ger: I always knew you were a sell-out to Cupertino
- # [14:02] <Ms2ger> Clearly :)
- # [14:08] * Joins: gitbot (~gitbot@public.cloak)
- # [14:08] -gitbot:#testing- [web-platform-tests] deniak pushed 1 new commit to master: https://github.com/w3c/web-platform-tests/commit/5aa219e934e4bfa710cde1e01f2dfafb4434d7e7
- # [14:08] -gitbot:#testing- web-platform-tests/master 5aa219e Denis Ah-Kang: fix import /resources/testharnessreport.js
- # [14:08] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [14:22] <Ms2ger> denis, hadn't I seen https://critic.hoppipolla.co.uk/r/658 before?
- # [14:24] <denis> Ms2ger, I messed up my PR and started a new one but I took all you comments into consideration
- # [14:24] <denis> https://critic.hoppipolla.co.uk/r/484
- # [14:25] <denis> sorry about that
- # [14:30] * Joins: zcorpan (~zcorpan@public.cloak)
- # [14:33] <MikeSmith> I wonder what the blue bar on the left of each PR in https://github.com/w3c/web-platform-tests/pulls means
- # [14:34] <MikeSmith> well blue bar all except for just one of those PRs
- # [14:34] <MikeSmith> https://github.com/w3c/web-platform-tests/pull/520 is the only one that's bluebar-less
- # [14:36] <MikeSmith> oh
- # [14:36] <MikeSmith> it means I haven't read it I guess
- # [14:37] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
- # [14:39] * Quits: koji (~koji@public.cloak) (Client closed connection)
- # [14:40] * Joins: koji (~koji@public.cloak)
- # [14:47] * Quits: koji (~koji@public.cloak) (Ping timeout: 180 seconds)
- # [14:49] * Quits: Lachy (~Lachy@public.cloak) ("My MacBook Pro has gone to sleep. ZZZzzz…")
- # [14:55] * Joins: koji (~koji@public.cloak)
- # [15:01] <Ms2ger> MikeSmith, given that it depends on the "unread" class, plausible :)
- # [15:02] <jgraham> Understanding the github UI, classname by classname
- # [15:06] <Ms2ger> darobin, I bet you'd like to review https://critic.hoppipolla.co.uk/r/660
- # [15:07] <jgraham> MikeSmith: https://critic.hoppipolla.co.uk/showcommit?review=615&filter=files&file=35039,35040,35041,35042,35043,35044,35045,35046,35047,35048,35049,35050,35051,35052,35053,35054,35055,35056,35057,35058,35059,35060,35061,35062,35063,35064,35065,35066,35067,35068,35069,35070,35071,35072,35073,35074,35075,35076,35077,35078,35079,35080,35081,35082,35083,35084,35085,35086,35120,35121,35122,35123,35124,35125,35131,35135,35136,35137,35138,35139,35140,35141,3[CUT]
- # [15:07] <jgraham> Oh, that was quite long
- # [15:07] <jgraham> ... 47,35148,35149,35150,35151,35152,35153,35154,35155,35156,35157,35158,35159,35160,35161,35162,35163,35164,35165,35166,35167,35168,35169,35170,35171,35172,35173,35174,35175,35176,35177,35178,35179,35180,35181,35182,35183,35210,35211,35212,35213,35214,35215,35216,35217,35218,35219,35220,35221,35222,35223,35224,35225,35226,35227,35228,35229,35230,35231,35232,35233,35234,35235,35236,35237,35238,35239,35240,35241,35242,35243,35649,35650,35651,35652,35653[CUT]
- # [15:07] <MikeSmith> yow
- # [15:08] * Ms2ger suggests some kind of url shortener
- # [15:08] * Joins: Lachy (~Lachy@public.cloak)
- # [15:08] <Ms2ger> Or put the URL in a pastebin :)
- # [15:10] <jgraham> https://pastebin.mozilla.org/4111851
- # [15:11] <MikeSmith> btw this Web UI marking things "unread" idea would make a lot more sense in a world where e-mail didn't exist
- # [15:11] <jgraham> Yeah, it's hopeless
- # [15:11] <Ms2ger> Email? What are you, a caveman?
- # [15:13] <MikeSmith> "I'm just a caveman.. Your Web UI frightens and confuses me"
- # [15:14] <MikeSmith> jgraham: so what am I looking at with this critic URL?
- # [15:14] <MikeSmith> Squashed History
- # [15:14] <MikeSmith> oh
- # [15:14] <MikeSmith> stuff or me to review?
- # [15:14] * Joins: dauwhe (~dauwhe@public.cloak)
- # [15:15] <MikeSmith> if so now I am genuintely frightenged
- # [15:15] <odinho> It seems to make sense for critic to support ranges in its file= query param :)
- # [15:15] <jgraham> MikeSmith: Yes, foolip did a s/\r\n/\n/
- # [15:15] <MikeSmith> ah ok good
- # [15:16] <MikeSmith> yeahah sorry my bad I should have fixed that crap at the time I imported those tests
- # [15:16] <MikeSmith> along with the spaces in the filenames
- # [15:17] <MikeSmith> jgraham: problem though: I don't know how to assign those all to myself from that page
- # [15:17] <jgraham> MikeSmith: You don't actually need to assign it to yourself
- # [15:18] <jgraham> Just do the review
- # [15:18] <MikeSmith> OK but there's no checkboxes next to them
- # [15:18] <MikeSmith> no way for it to save the state about the review
- # [15:18] <MikeSmith> from that page I mean
- # [15:19] <jgraham> Oh, I have checkboxes
- # [15:19] <jgraham> Does it just say pending for you?
- # [15:19] <MikeSmith> yeah
- # [15:19] <MikeSmith> I guess I just need to be designated as a reviewer for that path
- # [15:19] <MikeSmith> or something
- # [15:20] <MikeSmith> I know to hwo to assign sets of stuff to myself in critic but I guess that's not the most efficient way
- # [15:21] <jgraham> MikeSmith: Should be fixed for that one review now, but you should add a filter on the front page
- # [15:21] <jgraham> So that you are a reviewr for /conformance-checkers at least
- # [15:21] * Quits: dauwhe (~dauwhe@public.cloak) (Ping timeout: 180 seconds)
- # [15:22] * Joins: dauwhe (~dauwhe@public.cloak)
- # [15:26] <MikeSmith> right
- # [15:26] <MikeSmith> will do
- # [15:29] <MikeSmith> hmm well
- # [15:30] <jgraham> ?
- # [15:30] <MikeSmith> as far as reviewing the resutls of the s/\r\n/\n/ changes to the actual files, the critic UI doesn't add much value
- # [15:30] * Quits: koji (~koji@public.cloak) (Client closed connection)
- # [15:30] <odinho> No, the value is in keeping track as a todo-list of what is done and what is not. But yea, the diff viewer doesnlt help too much.
- # [15:30] * Joins: koji (~koji@public.cloak)
- # [15:30] <MikeSmith> I guess I need to check out the branh to do it properly
- # [15:30] <jgraham> The value is that you can do the review incrementally rather than all or nothing
- # [15:30] <MikeSmith> ok
- # [15:31] <MikeSmith> but you know, how do I confirm the actual change was made?
- # [15:31] <jgraham> But it does seem a bit inconsistent about when it displays a trailing CR as a whitespace error
- # [15:31] <MikeSmith> act of faith?
- # [15:31] * Joins: zcorpan (~zcorpan@public.cloak)
- # [15:31] <MikeSmith> I mean I realize it was done by a script
- # [15:31] <Ms2ger> I sure hope so
- # [15:32] <MikeSmith> heh
- # [15:32] <jgraham> Yes, it was :)
- # [15:32] <MikeSmith> well I mean,if I know the proper changes were made by the script to one file, I can trust the rest were changed in the same way
- # [15:33] <jgraham> MikeSmith: Go to config and ensure that you have "highlight illegal whitespace" enabled
- # [15:33] <MikeSmith> ah
- # [15:33] <MikeSmith> so yeah I got that already
- # [15:33] <jgraham> I don't think it works for all file types though
- # [15:33] <MikeSmith> "angry"
- # [15:34] <MikeSmith> ok
- # [15:34] <jgraham> It might be something pygments related
- # [15:35] <MikeSmith> are you saying there should be a color difference? for me it's just the same red on both sides
- # [15:36] <jgraham> I'm saying that on textfiles on one side you will see
- # [15:36] <jgraham> foo^M
- # [15:36] <jgraham> With the ^M in red
- # [15:36] <jgraham> but for html/js that doesn't seem to happen
- # [15:37] <MikeSmith> ah I see
- # [15:37] <MikeSmith> yeah
- # [15:37] <jgraham> Presumably because pygments swallows the CR during syntax highlighting
- # [15:37] <MikeSmith> it would be very nice to have those ^M shows
- # [15:37] * Joins: zcorpan_ (~zcorpan@public.cloak)
- # [15:37] <MikeSmith> ah
- # [15:37] <MikeSmith> OK
- # [15:37] <Ms2ger> Mm, lots of knobs
- # [15:37] * Quits: zcorpan_ (~zcorpan@public.cloak) (Client closed connection)
- # [15:37] * Quits: koji (~koji@public.cloak) (Ping timeout: 180 seconds)
- # [15:37] <jgraham> Ms2ger: Been reading EME discussions again?
- # [15:37] <Ms2ger> No, looking at critic
- # [15:38] * Joins: zcorpan_ (~zcorpan@public.cloak)
- # [15:38] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
- # [15:43] <MikeSmith> Ms2ger: next jgraham will ask you if you've been reading through the list of reviewers in critic
- # [15:45] * Quits: zcorpan_ (~zcorpan@public.cloak) (Client closed connection)
- # [15:45] * Joins: zcorpan (~zcorpan@public.cloak)
- # [15:46] * Ms2ger assigns all reviews to MikeSmith
- # [15:47] <MikeSmith> hah
- # [15:52] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
- # [15:53] * Joins: koji (~koji@public.cloak)
- # [16:06] * Joins: florian (~Adium@public.cloak)
- # [16:12] * Joins: zcorpan (~zcorpan@public.cloak)
- # [16:19] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
- # [16:34] * Quits: florian (~Adium@public.cloak) ("Leaving.")
- # [16:46] * Quits: dauwhe (~dauwhe@public.cloak) (Client closed connection)
- # [16:47] * Joins: florian (~Adium@public.cloak)
- # [16:48] * Quits: koji (~koji@public.cloak) (Client closed connection)
- # [16:49] * Joins: koji (~koji@public.cloak)
- # [16:53] * Joins: gitbot (~gitbot@public.cloak)
- # [16:53] -gitbot:#testing- [web-platform-tests] jgraham closed pull request #574: Add a test for methods that do nothing. (master...capture-releaseEvents) https://github.com/w3c/web-platform-tests/pull/574
- # [16:53] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [16:56] * Quits: koji (~koji@public.cloak) (Ping timeout: 180 seconds)
- # [16:56] * Quits: florian (~Adium@public.cloak) ("Leaving.")
- # [16:58] * Joins: koji (~koji@public.cloak)
- # [17:16] * Quits: plh (plehegar@public.cloak) (Ping timeout: 180 seconds)
- # [17:22] * Quits: shepazu (schepers@public.cloak) ("is sleepy")
- # [17:22] * Joins: zcorpan (~zcorpan@public.cloak)
- # [17:29] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
- # [17:32] * Quits: darobin (rberjon@public.cloak) (Client closed connection)
- # [17:33] * heycam|away is now known as heycam
- # [17:38] * Quits: koji (~koji@public.cloak) (Client closed connection)
- # [17:39] * Joins: koji (~koji@public.cloak)
- # [17:41] * Joins: dauwhe (~dauwhe@public.cloak)
- # [17:46] * Quits: koji (~koji@public.cloak) (Ping timeout: 180 seconds)
- # [17:47] * Joins: glenn (~gadams@public.cloak)
- # [17:52] * Quits: Lachy (~Lachy@public.cloak) ("My MacBook Pro has gone to sleep. ZZZzzz…")
- # [17:56] * Quits: tobie_ (~sid5692@public.cloak) (Client closed connection)
- # [17:56] * Quits: astearns (~sid15080@public.cloak) (Client closed connection)
- # [17:56] * Joins: tobie_ (~sid5692@public.cloak)
- # [17:57] * Joins: astearns (~sid15080@public.cloak)
- # [18:00] * Joins: smfr (~smfr@public.cloak)
- # [18:02] * Joins: lmcliste_ (~lmclister@public.cloak)
- # [18:07] * Quits: smfr (~smfr@public.cloak) (smfr)
- # [18:12] * Quits: ArtB (~abarsto@public.cloak) ("Leaving.")
- # [18:17] * Joins: koji (~koji@public.cloak)
- # [18:17] * Joins: smfr (~smfr@public.cloak)
- # [18:24] * Quits: koji (~koji@public.cloak) (Ping timeout: 180 seconds)
- # [18:24] * Joins: florian (~Adium@public.cloak)
- # [18:24] * Parts: florian (~Adium@public.cloak) (florian)
- # [18:29] * Joins: plh (plehegar@public.cloak)
- # [18:32] * Joins: shepazu (schepers@public.cloak)
- # [18:32] * Joins: kawabata2 (~kawabata@public.cloak)
- # [18:36] * Joins: abarsto (~abarsto@public.cloak)
- # [18:36] * abarsto is now known as ArtB
- # [18:43] * Joins: ptressel (~chatzilla@public.cloak)
- # [18:45] * Quits: shepazu (schepers@public.cloak) ("is probably traveling...")
- # [18:46] * Joins: koji (~koji@public.cloak)
- # [18:46] * Joins: edoyle (~edoyle@public.cloak)
- # [18:47] * Quits: edoyle (~edoyle@public.cloak) ("")
- # [18:48] * Joins: shepazu (schepers@public.cloak)
- # [19:11] <MikeSmith> so fwiw I ended up reviewing the CRLF changes by doing "git diff master: . > DIFF" and looking at the DIFF file in vim
- # [19:17] <jgraham> MikeSmith: Have some points for effort
- # [19:18] * MikeSmith eats the points from jgraham and washes them down with beer from Ms2ger the other day
- # [19:19] * Quits: dom (dom@public.cloak) ("")
- # [19:19] * Joins: yankhates_cb (~yankhatescb@public.cloak)
- # [19:26] * Quits: dauwhe (~dauwhe@public.cloak) (Client closed connection)
- # [19:26] * Joins: dauwhe (~dauwhe@public.cloak)
- # [19:52] * Quits: koji (~koji@public.cloak) (Client closed connection)
- # [19:52] * Joins: koji (~koji@public.cloak)
- # [19:57] * Quits: dauwhe (~dauwhe@public.cloak) (Client closed connection)
- # [19:59] * Quits: koji (~koji@public.cloak) (Ping timeout: 180 seconds)
- # [20:00] * Joins: koji (~koji@public.cloak)
- # [20:03] * Joins: dauwhe (~dauwhe@public.cloak)
- # [20:22] * Quits: smfr (~smfr@public.cloak) (smfr)
- # [20:25] * Joins: smfr (~smfr@public.cloak)
- # [20:28] * Parts: smfr (~smfr@public.cloak) (smfr)
- # [20:29] * Joins: rhauck (~Adium@public.cloak)
- # [21:05] * Joins: Lachy (~Lachy@public.cloak)
- # [21:13] * Quits: kawabata2 (~kawabata@public.cloak) (Ping timeout: 180 seconds)
- # [21:27] * Quits: koji (~koji@public.cloak) (Client closed connection)
- # [21:27] * Joins: koji (~koji@public.cloak)
- # [21:27] * Quits: koji (~koji@public.cloak) (Client closed connection)
- # [21:27] * Joins: koji (~koji@public.cloak)
- # [21:28] * Quits: koji (~koji@public.cloak) (Client closed connection)
- # [21:28] * Joins: koji (~koji@public.cloak)
- # [21:35] * Quits: koji (~koji@public.cloak) (Ping timeout: 180 seconds)
- # [21:48] * Joins: smfr (~smfr@public.cloak)
- # [21:50] * Joins: koji (~koji@public.cloak)
- # [22:24] * Quits: smfr (~smfr@public.cloak) (smfr)
- # [22:28] * Joins: smfr (~smfr@public.cloak)
- # [22:30] * Quits: koji (~koji@public.cloak) (Ping timeout: 180 seconds)
- # [22:33] * Joins: koji (~koji@public.cloak)
- # [22:40] * Quits: Ms2ger (~Ms2ger@public.cloak) ("nn")
- # [22:52] * Quits: smfr (~smfr@public.cloak) (smfr)
- # [22:55] * Joins: smfr (~smfr@public.cloak)
- # [22:59] * Quits: yankhates_cb (~yankhatescb@public.cloak) (Ping timeout: 180 seconds)
- # [23:06] * heycam is now known as heycam|away
- # [23:28] * Joins: yankhates_cb (~yankhatescb@public.cloak)
- # [23:28] * Joins: kawabata2 (~kawabata@public.cloak)
- # [23:44] * Quits: ArtB (~abarsto@public.cloak) ("Leaving.")
- # [23:44] * Quits: ptressel (~chatzilla@public.cloak) ("bbl")
- # Session Close: Tue Jan 28 00:00:00 2014
The end :)