/irc-logs / w3c / #testing / 2014-03-27 / end

Options:

  1. # Session Start: Thu Mar 27 00:00:00 2014
  2. # Session Ident: #testing
  3. # [00:01] * Quits: plh (plehegar@public.cloak) ("Leaving")
  4. # [00:03] * Quits: lukeis (~Adium@public.cloak) ("Leaving.")
  5. # [00:12] * Quits: lmclister (~lmclister@public.cloak) ("")
  6. # [00:46] * Joins: zcorpan (~zcorpan@public.cloak)
  7. # [00:53] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  8. # [01:08] * Joins: MK (kawamori@public.cloak)
  9. # [01:39] * Quits: glenn (~gadams@public.cloak) (Client closed connection)
  10. # [01:40] * Joins: glenn (~gadams@public.cloak)
  11. # [01:46] * Joins: zcorpan (~zcorpan@public.cloak)
  12. # [01:47] * Quits: glenn (~gadams@public.cloak) (Ping timeout: 180 seconds)
  13. # [01:54] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  14. # [02:12] * heycam is now known as heycam|away
  15. # [02:12] * Joins: glenn (~gadams@public.cloak)
  16. # [02:45] * Quits: glenn (~gadams@public.cloak) (Client closed connection)
  17. # [02:47] * Joins: zcorpan (~zcorpan@public.cloak)
  18. # [02:54] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  19. # [03:09] * Joins: yankhates_cb (~yankhatescb@public.cloak)
  20. # [03:47] * Quits: MK (kawamori@public.cloak) (Ping timeout: 180 seconds)
  21. # [03:48] * Joins: zcorpan (~zcorpan@public.cloak)
  22. # [03:55] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  23. # [04:20] * Joins: glenn (~gadams@public.cloak)
  24. # [04:21] * Quits: glenn (~gadams@public.cloak) ("Leaving...")
  25. # [04:36] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
  26. # [04:37] * Joins: mdas (~mdas@public.cloak)
  27. # [04:39] * Joins: MK (kawamori@public.cloak)
  28. # [04:42] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
  29. # [04:42] * Quits: yankhates_cb (~yankhatescb@public.cloak) (Ping timeout: 180 seconds)
  30. # [04:48] * Quits: MK (kawamori@public.cloak) (Ping timeout: 180 seconds)
  31. # [04:49] * Joins: zcorpan (~zcorpan@public.cloak)
  32. # [04:56] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  33. # [05:00] * heycam|away is now known as heycam
  34. # [05:00] * Joins: MK (kawamori@public.cloak)
  35. # [05:49] * Joins: zcorpan (~zcorpan@public.cloak)
  36. # [05:56] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  37. # [06:35] * heycam is now known as heycam|away
  38. # [06:50] * Joins: zcorpan (~zcorpan@public.cloak)
  39. # [06:57] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  40. # [07:11] * Joins: zcorpan (~zcorpan@public.cloak)
  41. # [07:11] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  42. # [07:12] * Joins: zcorpan (~zcorpan@public.cloak)
  43. # [07:24] * Joins: ptressel (~chatzilla@public.cloak)
  44. # [07:38] * Quits: MK (kawamori@public.cloak) (Ping timeout: 180 seconds)
  45. # [08:06] * Joins: MK (kawamori@public.cloak)
  46. # [08:18] * sangwhan__ is now known as sangwhan
  47. # [09:19] <sangwhan> denis: need to update the ttwf seoul page focus points - any input?
  48. # [09:19] <sangwhan> currently just a copy and paste of the tokyo event, which is gonna end up in a boatload of duplicates of the currently stale reviews
  49. # [09:20] * Joins: dom (dom@public.cloak)
  50. # [09:27] * Joins: darobin (rberjon@public.cloak)
  51. # [09:35] <@denis> sangwhan, you should get in touch with rebecca. I think she's the one responsible for all the ttfw events pages
  52. # [09:35] * Quits: Lachy (~Lachy@public.cloak) ("My MacBook Pro has gone to sleep. ZZZzzz…")
  53. # [09:40] * Quits: MK (kawamori@public.cloak) (Ping timeout: 180 seconds)
  54. # [09:40] * Joins: Lachy (~Lachy@public.cloak)
  55. # [09:43] * Joins: Ms2ger (~Ms2ger@public.cloak)
  56. # [09:44] <sangwhan> denis: was more of a question of what is missing in web-platform-tests, actually
  57. # [09:44] * Quits: Lachy (~Lachy@public.cloak) ("My MacBook Pro has gone to sleep. ZZZzzz…")
  58. # [09:44] <Ms2ger> All the things
  59. # [09:45] <sangwhan> denis: i don't think we should have people sitting around and creating more stale PRs
  60. # [09:47] <sangwhan> denis: right now the page has the same objectives as the tokyo event (and quite likely the shenzhen event) so we're gonna end up with dupes if we keep it that way
  61. # [09:48] <Ms2ger> We made a list of useful tests to write once
  62. # [09:48] <Ms2ger> I don't know where it ended up
  63. # [09:48] <@denis> sangwhan, I can't talk for the other specs but for HTML5, it would be nice to have more tests on www.whatwg.org/html/#browsers
  64. # [09:50] <Ms2ger> True
  65. # [09:50] <sangwhan> denis: that's actually very useful information, will note
  66. # [09:50] <Ms2ger> Not sure how useful tests for that by inexperienced contributors would be
  67. # [09:50] <sangwhan> (other wishlists are welcome)
  68. # [09:50] <@denis> jgraham, zcorpan, darobin, MikeSmith may have more ideas
  69. # [09:52] <Ms2ger> sangwhan, I think we sent that list to rhauck... Maybe she can find it
  70. # [10:10] <sangwhan> Ms2ger: this probably isn't the first time the inexperienced contributor discussion has popped up, it's a tricky topic
  71. # [10:11] <sangwhan> Ms2ger: at least there is a chance of digging up a couple good people who aren't visible atm out
  72. # [10:16] <sangwhan> how about having some people take a look at the stale reviews and see if they can address the issues raised that were never followed up on?
  73. # [10:19] * Joins: Lachy (~Lachy@public.cloak)
  74. # [10:26] <sangwhan> denis: Right now the page for Seoul mentions HTML5 Forms, CSS Basic User Interface, CSS Shapes, CSS Masking, SPARQL Query Language for RDF which I think is outdated
  75. # [10:28] <@denis> I think HTML5 forms is ok now. Of course we can always have more tests but it's not a priority
  76. # [10:28] <@denis> I can't speak for CSS and sparql
  77. # [10:34] <sangwhan> denis: i agree on forms, last couple events all did forms. not sure who put in sparql, but i guess that hasn't been covered
  78. # [10:36] * Joins: MK (kawamori@public.cloak)
  79. # [10:37] <darobin> do we actually want to have sparql tests in WPT?
  80. # [10:37] <darobin> I would see that as more adapted to, say, a semantic-platform-tests repo
  81. # [10:38] <sangwhan> not sure if that's a web platform feature, looking at the specs
  82. # [10:38] <jgraham> Yeah, no
  83. # [10:38] <sangwhan> and it's not a browser feature in any way from what i see
  84. # [10:38] <sangwhan> question is who put it in there i guess
  85. # [10:38] <darobin> right
  86. # [10:38] <darobin> well, I don't care about who
  87. # [10:38] <darobin> and I'm happy for people to test SPARQL if they want to
  88. # [10:39] <darobin> it's actually a pretty good way of getting JSON out of unusable RDF data sources :)
  89. # [10:39] <darobin> but I reckon there should be a separate repo for that
  90. # [10:41] <sangwhan> but that's going to be a library test unless it's natively implemented in the browser (which it isn't), no?
  91. # [10:41] <sangwhan> jgraham: any way to take over critic reviews from someone else without having to reopen a review?
  92. # [10:42] <jgraham> sangwhan: You mean push more commits to the review?
  93. # [10:42] <jgraham> If so the answer is "no due to the suckiness of GitHub"
  94. # [10:43] <sangwhan> jgraham: yes, push more commits to someone else's review
  95. # [10:43] <sangwhan> cool, that's what i thought too
  96. # [10:43] <darobin> sangwhan: actually it's probably a test calling a SPARQL endpoint over the internets; but certainly not browser
  97. # [10:44] <sangwhan> so i have to be a massively intrusive person and steal the commits from his/her repo and open a new pr and suggest to close the old one i assume...
  98. # [10:44] <jgraham> Yes, I hate GitHub
  99. # [10:44] <sangwhan> darobin: i skimmed through the spec, i think i need something to calm myself down
  100. # [10:45] <sangwhan> sadly, everyone else loves GH
  101. # [10:46] <Ms2ger> I never figured out why
  102. # [10:47] <sangwhan> jgraham: i might have asked this before, but any chance critic@hoppipolla will get support for FiddleAndTweak?
  103. # [10:47] <jgraham> sangwhan: I don't think it can
  104. # [10:47] <jgraham> Evn if I enabled extensions, it wouldn't have the right permissions to push to the original repo
  105. # [10:48] <sangwhan> jgraham: that makes me a sad panda, i guess that's the downside of being dependent on github
  106. # [10:48] * sangwhan <3 history rewrites
  107. # [10:50] * Ms2ger disapproves of rewriting history
  108. # [10:50] * sangwhan assumes Ms2ger never writes profanity in commit messages
  109. # [10:52] <Ms2ger> I avoid it :)
  110. # [10:52] <jgraham> Hmm, there's nothing wrong with rewriting history
  111. # [10:53] <jgraham> It's a very positive thing
  112. # [10:53] <sangwhan> Depends on your workflow, but if you rewrite history on master you should be shot
  113. # [10:53] <jgraham> Rewriting *published* history is the only problematic thing
  114. # [10:53] <jgraham> Sure
  115. # [10:53] <Ms2ger> sangwhan, oh :(
  116. # [10:53] <Ms2ger> I was thinking of doing that recently
  117. # [10:54] <sangwhan> Opera style history rewriting is fine, but if you rewrite history on a shared branch with a backlog everyone has you should be shot
  118. # [10:56] <jgraham> Yeah, in general the way Opera use VCS is very smooth and productive
  119. # [10:56] <sangwhan> ("Opera style" is doing it on a seperate repo, isolated branch, rewriting there, and merging it into the main repo's shared branch)
  120. # [10:56] <sangwhan> downside - it has a learning curve..
  121. # [10:57] <sangwhan> jgraham: darobin any test wishlists? going to make a PR for the page changes in about a hour
  122. # [10:57] <sangwhan> apart from "don't write crap tests"
  123. # [11:05] <Ms2ger> sangwhan, yeah, somewhere
  124. # [11:06] <Ms2ger> https://etherpad.mozilla.org/VkkW1BU54C
  125. # [11:07] <sangwhan> Ms2ger: thanks, looks like this is more than enough
  126. # [11:07] * sangwhan blankly stares at the line "* Rewrite the tests in [8] from the WebKit repository to be in testharness.js format"
  127. # [11:20] * Joins: abarsto (~abarsto@public.cloak)
  128. # [11:20] * abarsto is now known as ArtB
  129. # [11:27] * Joins: gitbot (~gitbot@public.cloak)
  130. # [11:27] -gitbot:#testing- [web-platform-tests] AFBarstow closed pull request #794: This is the test suite for the Touch Events spec <http://www.w3.org/TR/t... (master...AFBarstow/touch-events) https://github.com/w3c/web-platform-tests/pull/794
  131. # [11:27] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  132. # [11:42] * Quits: MK (kawamori@public.cloak) (Ping timeout: 180 seconds)
  133. # [12:00] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  134. # [12:00] * Joins: MK (kawamori@public.cloak)
  135. # [12:08] * Quits: MK (kawamori@public.cloak) (Ping timeout: 180 seconds)
  136. # [12:11] <jgraham> sangwhan: That would actually be one of the more useful things in that document
  137. # [12:20] <sangwhan> jgraham: it's also not a trivial task
  138. # [12:20] <jgraham> No
  139. # [12:21] <jgraham> But writing good tests generally isn't
  140. # [12:22] <Ms2ger> Who'd have thought
  141. # [12:22] <jgraham> Unfortunately this exposes the main failing of TTWF
  142. # [12:23] <jgraham> So far we have had roughly a 0% retention rate
  143. # [12:23] <jgraham> And although we have got some good tests it hasn't been that many compared to the number of first-time participants
  144. # [12:24] <sangwhan> low retention rate doesn't surprise me at all, writing tests is not fun after all
  145. # [12:24] <jgraham> Umm, it can be
  146. # [12:25] <jgraham> I think it depends on the situation
  147. # [12:25] <sangwhan> one way to try to increase retention rate might be to try to create some sort of local discussion/interest group and herd the people who are interested there, want me to try that?
  148. # [12:25] <jgraham> I don't really enjoy writing tests for my own code
  149. # [12:25] <sangwhan> my code never needs tests, it's always perfect (cough)
  150. # [12:25] <jgraham> But writing tests with the explicit aim of finding bugs in someone else's code is quite different
  151. # [12:25] <jgraham> That could be interesting
  152. # [12:26] <sangwhan> lemme put that on the list of things to bring up during the event then
  153. # [12:27] <jgraham> I think one problem we've had in the past is that we've concentrated hard on number of participants rather than on finding participants who are unusually likely to have the right skillset
  154. # [12:27] <jgraham> I think it would be a neat idea to host a TTWF at a major js conf. or similar
  155. # [12:29] <sangwhan> yes, i agree on that bit - tokyo was actually pretty good imho, but seoul is a bit risky as it's a extension of some other event that focuses more on academia related matters (search for www2014)
  156. # [12:29] <sangwhan> also: https://etherpad.mozilla.org/sHzr5W5imP
  157. # [12:32] <jgraham> I think getting people to review is a bit hopeless
  158. # [12:33] <Ms2ger> Right
  159. # [12:34] <Ms2ger> sangwhan, if you're there, please do ask people to reply to review comments, even if they come in after the event is done
  160. # [12:34] <Ms2ger> And make them add their email address on critic
  161. # [12:35] <sangwhan> Ms2ger: i have always asked for the people i have helped in place, but what for some reason "pretty please with sugar on top" wasn't enough for that to happen
  162. # [12:35] <sangwhan> jgraham: ok, i'll scratch that
  163. # [12:36] <Ms2ger> Maybe during the initial presentation, stop and tell them you'll continue when they've done it :)
  164. # [12:36] <sangwhan> I'll have to note that most people hate critic
  165. # [12:37] <jgraham> That isn't my experience
  166. # [12:37] <sangwhan> It's targeted for a very narrow spectrum of audience, and it's a pretty hard sell if you come from a background where Github is the best thing after Google Code SVN
  167. # [12:37] <MikeSmith> are there no appcache tests in presto-testo?
  168. # [12:38] <jgraham> Most people think that it's ugly and confusing for a while and then appreciate it
  169. # [12:38] <sangwhan> jgraham: maybe you and i i think have been dealing with a similar demographic?
  170. # [12:38] <jgraham> The problem is people that never get past the first stage
  171. # [12:38] <sangwhan> MikeSmith: good question, find -name doesn't give you anything?
  172. # [12:38] <MikeSmith> nope
  173. # [12:39] <MikeSmith> for "*cache*" or "*offline*"
  174. # [12:39] <MikeSmith> sangwhan: do you know like critic yourself?
  175. # [12:40] * Quits: Ms2ger (~Ms2ger@public.cloak) ("bbl")
  176. # [12:40] <MikeSmith> I wonder what other better real code-review systems exist that are any better
  177. # [12:40] <MikeSmith> I know many that are lot worse
  178. # [12:40] <jgraham> Right, my experience is that critic is the worst code review system apart from all the others
  179. # [12:41] <MikeSmith> yeah
  180. # [12:41] <MikeSmith> I think somebody who's never had to use a real code-review system are never going to like the first one they use the first times they use it
  181. # [12:42] <MikeSmith> but then after they use that one for 3 months they will claim it's the best one there is and every one they try after that they'll hate more
  182. # [12:43] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  183. # [12:44] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  184. # [12:45] <sangwhan> MikeSmith: while i have found some tests internally, seems like those tests are not a part of what is called presto-testo
  185. # [12:45] <MikeSmith> ok
  186. # [12:46] <MikeSmith> well we have some tests that infraware submitted
  187. # [12:46] <sangwhan> yeah, that could do
  188. # [12:46] <MikeSmith> which are not total disasters
  189. # [12:46] <MikeSmith> but nobody has really reviewed them yet
  190. # [12:46] <sangwhan> odinho might know better
  191. # [12:46] <MikeSmith> ok
  192. # [12:47] <jgraham> I think appcache has the problem that it's hard to write automatic tests for
  193. # [12:47] <MikeSmith> denis has reviewed the infraware ones and sanified them some and opened a PR but nobody's reviewed that PR yet
  194. # [12:47] <jgraham> Because you need a way to go offline
  195. # [12:47] <MikeSmith> yeah
  196. # [12:48] <jgraham> I guess WebDriver doesn't have a way to do that, but maybe it should have
  197. # [12:48] <jgraham> It seems like it would be super useful for our testing and for testing actual offline apps
  198. # [12:48] <jgraham> AutomatedTester: ^
  199. # [12:50] <jgraham> In other news, testharness.js has a problem
  200. # [12:51] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Ping timeout: 180 seconds)
  201. # [12:51] <jgraham> If a test causes an exception that isn't caught it sets the harness status to Error and aborts the run
  202. # [12:51] <jgraham> But aborting the run tends to lead to race conditions
  203. # [12:52] <jgraham> e.g. if you have two async tests and one raises a bogus exception then the other one may or may not complete
  204. # [12:52] <jgraham> So I wonder if it should set the status to error but let the other tests keep running as long as possible
  205. # [12:53] <jgraham> It isn't possible to be *sure* that won't lead to races, but it at least makes it a bit less likely
  206. # [12:53] <MikeSmith> speaking of appcache, Somebody should respond to http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2014-March/084588.html
  207. # [12:53] <jgraham> zcorpan: ^
  208. # [12:53] <jgraham> (the tests thing, not the appecache thing)
  209. # [12:56] <zcorpan> jgraham: bogus exception here is one that isn't caught by step() ?
  210. # [12:57] <jgraham> Yes
  211. # [12:57] <jgraham> So in this case a worker is raising an error that is propogating to Window
  212. # [12:57] <zcorpan> jgraham: how do you know which test is responsible?
  213. # [12:57] <jgraham> But the step() can't catch that because we don't have step() inside the worker
  214. # [12:58] <jgraham> zcorpan: You don't
  215. # [12:58] <jgraham> (in general, in this case I do)
  216. # [12:58] <zcorpan> yeah i meant how does testharness know :-)
  217. # [12:58] <zcorpan> ok
  218. # [12:59] <jgraham> *Hopefully* if the test is raising an exception it doesn't come back as PASS
  219. # [12:59] <zcorpan> so what's the idea, set global result to "error" but continue running in case some tests carry on fine?
  220. # [12:59] <jgraham> Yeah
  221. # [12:59] <jgraham> Well specifically in case some tests have already started
  222. # [12:59] * Joins: plh (plehegar@public.cloak)
  223. # [12:59] <zcorpan> that seems like a good idea. i guess it increases the run time but this seems like a rare thing anyway
  224. # [12:59] <jgraham> In which case abruptly stopping them is racy
  225. # [13:02] <jgraham> zcorpan: Totally unrelated, but when you are in Linköping next there should be chocolate for you
  226. # [13:02] <zcorpan> jgraham: oooooh!
  227. # [13:02] <zcorpan> on monday actually
  228. # [13:02] <zcorpan> thanks!
  229. # [13:06] <jgraham> Hmm, so that solved one problem
  230. # [13:07] <jgraham> But it's still racy whether or not I get the harness ERROR before all the other tests are finished
  231. # [13:09] <jgraham> I don't have any good ideas on how to solve that
  232. # [14:22] <odinho> No, I didn't look very much into AppCache, so I don't know.
  233. # [14:23] <odinho> Saw that only very few of my tests were in jgraham's flaky list though. They were more flaky before, but running it in Spartan (Opera Test system that jgraham worked on) nagged me about their unstableness so they were stable in Spartan in the end.
  234. # [14:24] <odinho> So I guess that's why only a very few popped up here now. -- Not immediately obvious why though (haven't looked at anything else than the report)
  235. # [14:27] <odinho> Microsoft-idb-port is 100% now. With 37 issues. Work to be done.
  236. # [14:33] <jgraham> odinho: Nice
  237. # [14:34] <odinho> jgraham: all zqzhang, lest you think it was me. :P
  238. # [14:34] <jgraham> And he's not even here so I can thank him :(
  239. # [14:38] * Joins: mdas (~mdas@public.cloak)
  240. # [14:56] * Joins: glenn (~gadams@public.cloak)
  241. # [14:57] * Joins: anssik (~uid10742@public.cloak)
  242. # [14:59] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
  243. # [14:59] * Joins: gitbot (~gitbot@public.cloak)
  244. # [14:59] -gitbot:#testing- [web-platform-tests] zcorpan closed pull request #712: Tests for the named access on the window object (master...submission/xiaojunwu/window-named-objects) https://github.com/w3c/web-platform-tests/pull/712
  245. # [14:59] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  246. # [15:16] * Joins: mdas (~mdas@public.cloak)
  247. # [15:41] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  248. # [15:59] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  249. # [15:59] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  250. # [16:03] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  251. # [16:03] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  252. # [16:10] * Joins: gitbot (~gitbot@public.cloak)
  253. # [16:10] -gitbot:#testing- [web-platform-tests] dontcallmedom closed pull request #376: Submission/ldeluca (master...submission/ldeluca) https://github.com/w3c/web-platform-tests/pull/376
  254. # [16:10] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  255. # [16:15] * Quits: scott_gonzalez (~scott_gonzalez@public.cloak) (scott_gonzalez)
  256. # [16:19] * Joins: lukeis (~Adium@public.cloak)
  257. # [16:24] * Joins: kawai (~kawai@public.cloak)
  258. # [16:24] * Joins: abarsto (~abarsto@public.cloak)
  259. # [16:26] * Quits: ArtB (~abarsto@public.cloak) ("Leaving.")
  260. # [16:30] * Joins: gitbot (~gitbot@public.cloak)
  261. # [16:30] -gitbot:#testing- [web-platform-tests] jgraham created jgraham/worker_terminate_fixup (+1 new commit): https://github.com/w3c/web-platform-tests/commit/eb67b371f0b9
  262. # [16:30] -gitbot:#testing- web-platform-tests/jgraham/worker_terminate_fixup eb67b37 James Graham: Change terminate test not to spam the event loop with so many messages
  263. # [16:30] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  264. # [16:31] * Joins: gitbot (~gitbot@public.cloak)
  265. # [16:31] -gitbot:#testing- [web-platform-tests] jgraham opened pull request #804: Change terminate test not to spam the event loop with so many messages (master...jgraham/worker_terminate_fixup) https://github.com/w3c/web-platform-tests/pull/804
  266. # [16:31] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  267. # [16:49] * Joins: lmclister (~lmclister@public.cloak)
  268. # [16:55] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  269. # [16:55] * Joins: zcorpan (~zcorpan@public.cloak)
  270. # [17:02] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  271. # [17:20] * Quits: ptressel (~chatzilla@public.cloak) ("zzz")
  272. # [17:26] * Joins: zcorpan (~zcorpan@public.cloak)
  273. # [17:28] * Joins: zcorpan_ (~zcorpan@public.cloak)
  274. # [17:28] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  275. # [17:30] * Quits: darobin (rberjon@public.cloak) (Client closed connection)
  276. # [17:35] * Quits: zcorpan_ (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  277. # [17:36] <odinho> jgraham + everyone: So in the IDB tests. If indexedDB doesn't exist. Should I just /not/ do something. Or assert_unreached("tis' not supported")?
  278. # [17:37] <jgraham> odinho: Well
  279. # [17:37] <jgraham> It's good to still run all the tests
  280. # [17:37] <jgraham> Or at least still declare all the tests
  281. # [17:37] <jgraham> But it's OK to bail early within a test
  282. # [17:38] <jgraham> so doing test(function() {assert_true(IndexedDB in window); test(function(){ /*only run this test if the other one passed})}) is not really OK
  283. # [17:40] <jgraham> But doing test(function() {var supported = IndexedDB in window; assert_true(supported)}); test(function() {assert_true(supported); /*rest of test*/}) is fine
  284. # [17:44] * Joins: gitbot (~gitbot@public.cloak)
  285. # [17:44] -gitbot:#testing- [web-platform-tests] jgraham created jgraham/websocket_wss_disable (+1 new commit): https://github.com/w3c/web-platform-tests/commit/4c7514843600
  286. # [17:44] -gitbot:#testing- web-platform-tests/jgraham/websocket_wss_disable 4c75148 James Graham: Don't pretend like we support wss for now
  287. # [17:44] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  288. # [17:45] * Joins: gitbot (~gitbot@public.cloak)
  289. # [17:45] -gitbot:#testing- [web-platform-tests] jgraham opened pull request #805: Don't pretend like we support wss for now (master...jgraham/websocket_wss_disable) https://github.com/w3c/web-platform-tests/pull/805
  290. # [17:45] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  291. # [17:45] <glenn> random input: it would be nice feature on test runner to deselect tests known to regularly time out on the platform under test, e.g., by using a previously generated (and updated) JSON file containing a list of such tests
  292. # [17:46] <odinho> jgraham: Yeah, -- this was not really a question about that. It was if I should let the result be NOT RUN or FAILED.
  293. # [17:47] <jgraham> glenn: Yeah having a way to select exactly which tests to include/exclude could be be useful. Patches welcome, I guess.
  294. # [17:47] <jgraham> odinho: I don't think there's a preference
  295. # [17:47] <odinho> I'm creating async_test anyway, I could just never actually start it to get not run, -- though I don't really like it to always time out. I can just fail it directly.
  296. # [17:47] <odinho> OK, so I'll fail.
  297. # [17:48] <odinho> And, it's been long since I did testing, -- what's the ideomatic JS way to test whether something is truthish? I have it as a precursor to quite a few tests, because I don't want them to pass if the exception they get is due to some other reason.
  298. # [17:48] <glenn> jgraham: i'm beginning a project that will have me using the WPT regularly, so perhaps I'll create and post a pull request; it would certainly help for smoke test scenarios; when i ran with the WPT runner recently it spent a couple of hours (seemingly) in time out mode
  299. # [17:48] <odinho> assert_true(!!cursor) <?
  300. # [17:49] <jgraham> odinho: Yeah, I suppose if you don't already know that it's actually a bool
  301. # [17:49] <jgraham> But I might question why you don't know
  302. # [17:51] <odinho> It's not a bool.
  303. # [17:51] <odinho> It's a IDBCursor or null.
  304. # [17:51] <odinho> Guess that's a good answer then :P
  305. # [17:53] <odinho> assert_true(cursor instanceof IDBCursor) nicer
  306. # [17:53] * Quits: glenn (~gadams@public.cloak) (Client closed connection)
  307. # [17:53] <jgraham> Yeah or !== null if you might have cross-window IDBCursor
  308. # [17:54] * Joins: glenn (~gadams@public.cloak)
  309. # [18:00] * Joins: Ms2ger (~Ms2ger@public.cloak)
  310. # [18:01] <jgraham> Ms2ger: !
  311. # [18:01] * Quits: glenn (~gadams@public.cloak) (Ping timeout: 180 seconds)
  312. # [18:01] <jgraham> Ms2ger: https://critic.hoppipolla.co.uk/showcomment?chain=3515
  313. # [18:02] * Quits: abarsto (~abarsto@public.cloak) ("Leaving.")
  314. # [18:07] <Ms2ger> I sure hope that isn't innerHTML again :)
  315. # [18:07] * Ms2ger kicks his mouse
  316. # [18:07] <Ms2ger> brb
  317. # [18:08] <Ms2ger> back
  318. # [18:08] <jgraham> Not innerHTML
  319. # [18:08] <jgraham> Although now you mention it…
  320. # [18:09] <Ms2ger> I know, right
  321. # [18:09] <Ms2ger> Is that the workers intermittent timeout?
  322. # [18:09] <jgraham> Ms2ger: Yeah, but specifically I wonder if you have any ideas for the issue in that comment
  323. # [18:11] <Ms2ger> s/before the test fails/before the test finishes/?
  324. # [18:12] <Ms2ger> I don't have any bright ideas right now
  325. # [18:13] <jgraham> Yeah s/fails/finishes/ if you like
  326. # [18:17] * Joins: gitbot (~gitbot@public.cloak)
  327. # [18:17] -gitbot:#testing- [web-platform-tests] Velmont pushed 1 new commit to Velmont/move_ported_idb_tests: https://github.com/w3c/web-platform-tests/commit/024366e5fb2104cee4490e25befa6f4bab28f714
  328. # [18:17] -gitbot:#testing- web-platform-tests/Velmont/move_ported_idb_tests 024366e Odin Hørthe Omdal: IndexedDB review fixes
  329. # [18:17] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  330. # [18:23] * Joins: abarsto (~abarsto@public.cloak)
  331. # [18:23] * abarsto is now known as ArtB
  332. # [18:23] * Quits: dom (dom@public.cloak) ("")
  333. # [18:24] * Joins: glenn (~gadams@public.cloak)
  334. # [18:27] * Joins: rhauck (~Adium@public.cloak)
  335. # [18:29] * Quits: kawai (~kawai@public.cloak) (Client closed connection)
  336. # [18:30] * Joins: gitbot (~gitbot@public.cloak)
  337. # [18:30] -gitbot:#testing- [web-platform-tests] jgraham created jgraham/remove_external_url (+1 new commit): https://github.com/w3c/web-platform-tests/commit/0fa8f70f31f1
  338. # [18:30] -gitbot:#testing- web-platform-tests/jgraham/remove_external_url 0fa8f70 James Graham: Using external URLs isn't allowed
  339. # [18:30] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  340. # [18:31] * Quits: glenn (~gadams@public.cloak) (Ping timeout: 180 seconds)
  341. # [18:32] <jgraham> Ms2ger: Maybe we'll just have to put allow_uncaucht_exceptions in a bunch of workers tests that *could* fail. I'm not sure what great alternatives there are
  342. # [18:32] <Ms2ger> Yeah
  343. # [18:33] * jgraham wonders what kind of punishment Lucifer has in store for people that try to depend on external servers in tests
  344. # [18:57] * Joins: glenn (~gadams@public.cloak)
  345. # [19:01] * Quits: glenn (~gadams@public.cloak) (Client closed connection)
  346. # [19:02] * Joins: glenn (~gadams@public.cloak)
  347. # [19:02] * Quits: glenn (~gadams@public.cloak) (Client closed connection)
  348. # [19:02] * Joins: glenn_ (~gadams@public.cloak)
  349. # [19:02] * Quits: glenn_ (~gadams@public.cloak) (Client closed connection)
  350. # [19:03] * Joins: glenn (~gadams@public.cloak)
  351. # [19:10] * Quits: glenn (~gadams@public.cloak) (Ping timeout: 180 seconds)
  352. # [19:29] * Joins: zcorpan (~zcorpan@public.cloak)
  353. # [19:36] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  354. # [19:55] * Joins: gitbot (~gitbot@public.cloak)
  355. # [19:55] -gitbot:#testing- [web-platform-tests] Velmont pushed 1 new commit to Velmont/move_ported_idb_tests: https://github.com/w3c/web-platform-tests/commit/244fd997d2b0db1279175b84f29cd3b30f5921d6
  356. # [19:55] -gitbot:#testing- web-platform-tests/Velmont/move_ported_idb_tests 244fd99 Odin Hørthe Omdal: fixup! IndexedDB review fixes
  357. # [19:55] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  358. # [20:03] * Joins: glenn (~gadams@public.cloak)
  359. # [20:05] * Quits: glenn (~gadams@public.cloak) (Client closed connection)
  360. # [20:05] * Joins: glenn (~gadams@public.cloak)
  361. # [20:06] * Quits: anssik (~uid10742@public.cloak) ("Connection closed for inactivity")
  362. # [20:24] * Quits: glenn (~gadams@public.cloak) (Client closed connection)
  363. # [20:24] * Joins: glenn (~gadams@public.cloak)
  364. # [20:25] * Quits: glenn (~gadams@public.cloak) (Client closed connection)
  365. # [20:30] * Joins: zcorpan (~zcorpan@public.cloak)
  366. # [20:31] * Joins: zcorpan_ (~zcorpan@public.cloak)
  367. # [20:31] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  368. # [20:39] * Quits: zcorpan_ (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  369. # [20:40] * Joins: glenn (~gadams@public.cloak)
  370. # [20:40] * Quits: glenn (~gadams@public.cloak) (Client closed connection)
  371. # [20:40] * Joins: glenn (~gadams@public.cloak)
  372. # [20:42] * Joins: gitbot (~gitbot@public.cloak)
  373. # [20:42] -gitbot:#testing- [web-platform-tests] Velmont pushed 2 new commits to Velmont/move_ported_idb_tests: https://github.com/w3c/web-platform-tests/compare/244fd997d2b0...6b963cf489c3
  374. # [20:42] -gitbot:#testing- web-platform-tests/Velmont/move_ported_idb_tests 89512d6 Odin Hørthe Omdal: fixup! IndexedDB review fixes
  375. # [20:42] -gitbot:#testing- web-platform-tests/Velmont/move_ported_idb_tests 6b963cf Odin Hørthe Omdal: IndexedDB: Whitespace cleanup
  376. # [20:42] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  377. # [20:47] * Quits: glenn (~gadams@public.cloak) (Ping timeout: 180 seconds)
  378. # [20:56] * Quits: rhauck (~Adium@public.cloak) ("Leaving.")
  379. # [20:56] * Joins: rhauck (~Adium@public.cloak)
  380. # [20:58] <odinho> omfg
  381. # [20:58] * Quits: rhauck (~Adium@public.cloak) ("Leaving.")
  382. # [20:58] <odinho> That newline fix reeeeeeeeeaally messed things up
  383. # [20:58] <odinho> This rebase is extreme. Need to trick it I guess.
  384. # [21:03] * Joins: rhauck (~Adium@public.cloak)
  385. # [21:06] * Joins: gitbot (~gitbot@public.cloak)
  386. # [21:06] -gitbot:#testing- [web-platform-tests] Velmont force-pushed Velmont/move_ported_idb_tests from 6b963cf to b7261d2: https://github.com/w3c/web-platform-tests/commits/Velmont/move_ported_idb_tests
  387. # [21:06] -gitbot:#testing- web-platform-tests/Velmont/move_ported_idb_tests 200ae6f Odin Hørthe Omdal: IndexedDB: Delete the Opera-ported Microsoft IDB tests
  388. # [21:06] -gitbot:#testing- web-platform-tests/Velmont/move_ported_idb_tests c8092c8 Odin Hørthe Omdal: IndexedDB: Ressurect the rewritten tests
  389. # [21:06] -gitbot:#testing- web-platform-tests/Velmont/move_ported_idb_tests 641a57b Odin Hørthe Omdal: IndexedDB review fixes
  390. # [21:06] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  391. # [21:09] <odinho> Monster merge commit.
  392. # [21:09] <odinho> (fake, but yeah)
  393. # [21:10] <odinho> I don't think we should review it. But can someone else just randomly go through it and click OK on everything? :P
  394. # [21:10] <AutomatedTester> odinho: whats that? you want to review it
  395. # [21:11] <AutomatedTester> one sec while I update critic for you
  396. # [21:11] <odinho> Huh?
  397. # [21:11] <AutomatedTester> 20:11 odinho: I don't think we should review it. But can someone else just randomly go through it and click OK on everything? :P
  398. # [21:11] <odinho> Yeah, because it's mostly just fake conflicts.
  399. # [21:12] <odinho> It'll be like doing the whole review again.
  400. # [21:12] <AutomatedTester> odinho: thats where my, failed, joke came in
  401. # [21:12] <odinho> Because of philipj's huge whitespace sweep a while ago.
  402. # [21:12] <odinho> OK, didn't take it :P
  403. # [21:13] <AutomatedTester> I promise to limit my jokes even more now
  404. # [21:13] <Ms2ger> Oh, it was a joke?
  405. # [21:13] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
  406. # [21:17] * Joins: gitbot (~gitbot@public.cloak)
  407. # [21:17] -gitbot:#testing- [web-platform-tests] Velmont pushed 1 new commit to Velmont/move_ported_idb_tests: https://github.com/w3c/web-platform-tests/commit/159257b28909f508c5b6912ba416b8158e3779a5
  408. # [21:17] -gitbot:#testing- web-platform-tests/Velmont/move_ported_idb_tests 159257b Odin Hørthe Omdal: fixup! IndexedDB: Delete the Opera-ported Microsoft IDB tests
  409. # [21:17] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  410. # [21:18] * Joins: mdas (~mdas@public.cloak)
  411. # [21:20] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
  412. # [21:21] * Quits: plh (plehegar@public.cloak) ("Leaving")
  413. # [21:24] * Joins: glenn (~gadams@public.cloak)
  414. # [21:24] * heycam|away is now known as heycam
  415. # [21:26] * Joins: gitbot (~gitbot@public.cloak)
  416. # [21:26] -gitbot:#testing- [web-platform-tests] Velmont pushed 1 new commit to Velmont/move_ported_idb_tests: https://github.com/w3c/web-platform-tests/commit/765c68ffba263f8dd05eda098482ad0ae08568b5
  417. # [21:26] -gitbot:#testing- web-platform-tests/Velmont/move_ported_idb_tests 765c68f Odin Hørthe Omdal: fixup! IndexedDB: Whitespace cleanup
  418. # [21:26] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  419. # [21:28] * Quits: Lachy (~Lachy@public.cloak) ("My MacBook Pro has gone to sleep. ZZZzzz…")
  420. # [21:31] * Quits: glenn (~gadams@public.cloak) (Ping timeout: 180 seconds)
  421. # [21:32] * Joins: zcorpan (~zcorpan@public.cloak)
  422. # [21:39] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  423. # [21:55] * Joins: dom (dom@public.cloak)
  424. # [22:02] * Joins: zcorpan (~zcorpan@public.cloak)
  425. # [22:02] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  426. # [22:02] * Joins: zcorpan (~zcorpan@public.cloak)
  427. # [22:25] * Joins: glenn (~gadams@public.cloak)
  428. # [22:27] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  429. # [22:27] * Joins: zcorpan (~zcorpan@public.cloak)
  430. # [22:30] * Quits: rhauck (~Adium@public.cloak) ("Leaving.")
  431. # [22:32] * Quits: glenn (~gadams@public.cloak) (Ping timeout: 180 seconds)
  432. # [22:33] * Joins: rhauck (~Adium@public.cloak)
  433. # [22:34] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  434. # [22:46] * Quits: Ms2ger (~Ms2ger@public.cloak) (Ping timeout: 180 seconds)
  435. # [22:54] * Joins: Lachy (~Lachy@public.cloak)
  436. # [23:03] * Quits: rhauck (~Adium@public.cloak) ("Leaving.")
  437. # [23:03] * Joins: rhauck (~Adium@public.cloak)
  438. # [23:05] * Joins: rhauck1 (~Adium@public.cloak)
  439. # [23:05] * Quits: rhauck (~Adium@public.cloak) (Client closed connection)
  440. # [23:26] * Joins: glenn (~gadams@public.cloak)
  441. # [23:33] * Quits: glenn (~gadams@public.cloak) (Ping timeout: 180 seconds)
  442. # [23:39] * heycam is now known as heycam|away
  443. # [23:39] * Quits: dom (dom@public.cloak) ("")
  444. # [23:43] * heycam|away is now known as heycam
  445. # [23:43] * Quits: lukeis (~Adium@public.cloak) ("Leaving.")
  446. # Session Close: Fri Mar 28 00:00:00 2014

The end :)