/irc-logs / w3c / #testing / 2014-05-11 / end

Options:

  1. # Session Start: Sun May 11 00:00:00 2014
  2. # Session Ident: #testing
  3. # [00:03] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  4. # [00:05] * Quits: lmclister (~lmclister@public.cloak) ("")
  5. # [00:21] * Quits: koji (~koji@public.cloak) (Client closed connection)
  6. # [00:21] * Joins: koji (~koji@public.cloak)
  7. # [00:28] * Quits: koji (~koji@public.cloak) (Ping timeout: 180 seconds)
  8. # [01:30] * Joins: lmclister (~lmclister@public.cloak)
  9. # [01:37] * Quits: lmclister (~lmclister@public.cloak) ("")
  10. # [01:37] <jgraham> MikeSmith: It's generating the wrong URLs I think. Or at least could do. Before the code assumed that all URLs were relative to the server. Now it assumes that they are all relative to the file, or something
  11. # [01:52] * Joins: koji (~koji@public.cloak)
  12. # [02:57] * Quits: koji (~koji@public.cloak) (Client closed connection)
  13. # [02:57] * Joins: koji (~koji@public.cloak)
  14. # [03:04] * Quits: koji (~koji@public.cloak) (Ping timeout: 180 seconds)
  15. # [03:29] * Joins: gitbot (~gitbot@public.cloak)
  16. # [03:29] -gitbot:#testing- [web-platform-tests] caitp opened pull request #983: assert 4th argument is a non-specific number (master...patch-2) https://github.com/w3c/web-platform-tests/pull/983
  17. # [03:29] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  18. # [03:57] * Joins: koji (~koji@public.cloak)
  19. # [05:32] * Joins: koji_ (~koji@public.cloak)
  20. # [05:36] * Joins: gitbot (~gitbot@public.cloak)
  21. # [05:36] -gitbot:#testing- [web-platform-tests] caitp opened pull request #984: URLUtils.search returns empty string, not '?' (master...patch-3) https://github.com/w3c/web-platform-tests/pull/984
  22. # [05:36] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  23. # [05:38] * Quits: koji (~koji@public.cloak) (Ping timeout: 180 seconds)
  24. # [06:01] <MikeSmith> jgraham: it actually seems to be generating the right URLs, as far as I can tell
  25. # [06:05] * Joins: koji (~koji@public.cloak)
  26. # [06:08] <MikeSmith> jgraham: I mean at least for the current tests. As far as if it could generate wrong ones, I guess I haven't thought it through enough to consider properly
  27. # [06:09] <MikeSmith> jgraham: fwiw a diff of what that change added to the manifest file is at https://gist.github.com/sideshowbarker/8284404#file-pr911-diff
  28. # [06:11] * Quits: koji_ (~koji@public.cloak) (Ping timeout: 180 seconds)
  29. # [06:15] * Quits: koji (~koji@public.cloak) (Client closed connection)
  30. # [06:15] * Joins: koji (~koji@public.cloak)
  31. # [06:22] * Quits: koji (~koji@public.cloak) (Ping timeout: 180 seconds)
  32. # [07:02] * Joins: koji (~koji@public.cloak)
  33. # [07:11] * Quits: koji (~koji@public.cloak) (Ping timeout: 180 seconds)
  34. # [07:21] * Joins: lmclister (~lmclister@public.cloak)
  35. # [07:59] * Quits: lmclister (~lmclister@public.cloak) ("")
  36. # [09:04] * Joins: koji (~koji@public.cloak)
  37. # [09:12] * Quits: koji (~koji@public.cloak) (Ping timeout: 180 seconds)
  38. # [09:17] * Joins: Ms2ger (~Ms2ger@public.cloak)
  39. # [10:06] * Joins: koji (~koji@public.cloak)
  40. # [10:13] * Quits: koji (~koji@public.cloak) (Ping timeout: 180 seconds)
  41. # [10:20] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  42. # [10:58] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  43. # [12:21] <jgraham> MikeSmith: If the link had was in /foo/bar.html and had href="/baz" it woulf generate /foo//baz for the refurl, which is wrong. Similarly if it was ../baz it would generate /foo/../baz
  44. # [12:21] <jgraham> (it was also wrong before, and I apologise for missing this PR)
  45. # [12:39] <MikeSmith> jgraham: ah yeah, I see
  46. # [12:41] * Joins: zcorpan (~zcorpan@public.cloak)
  47. # [12:50] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  48. # [13:15] * Disconnected
  49. # [13:17] * Attempting to rejoin channel #testing
  50. # [13:17] * Rejoined channel #testing
  51. # [13:17] * Topic is '"also, I hope no one actually reads this, but I have to admit that I've kind of gotten used to Critic" --darobin'
  52. # [13:17] * Set by plh on Mon Mar 31 21:50:34
  53. # [13:19] * Quits: krijnhoetmer (~krijnhoetmer@public.cloak) (Ping timeout: 180 seconds)
  54. # [13:32] <MikeSmith> jgraham: can't we just do ref_url = urlparse.urljoin("/" + rel_path, item.attrib["href"])
  55. # [13:38] <MikeSmith> jgraham: or I guess urlparse.urljoin(os.path.sep + rel_path, item.attrib["href"]) since it's not really a URL to begin with
  56. # [13:43] * Quits: Lachy (~Lachy@public.cloak) ("My MacBook Pro has gone to sleep. ZZZzzz…")
  57. # [14:12] * Joins: Lachy (~Lachy@public.cloak)
  58. # [15:04] * Joins: koji (~koji@public.cloak)
  59. # [15:11] * Quits: koji (~koji@public.cloak) (Ping timeout: 180 seconds)
  60. # [15:51] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  61. # [16:05] * Joins: koji (~koji@public.cloak)
  62. # [16:12] * Quits: koji (~koji@public.cloak) (Ping timeout: 180 seconds)
  63. # [16:38] <jgraham> MikeSmith: I can make a fix
  64. # [17:05] * Joins: gitbot (~gitbot@public.cloak)
  65. # [17:05] -gitbot:#testing- [web-platform-tests] jgraham created jgraham/fix_refurl (+2 new commits): https://github.com/w3c/web-platform-tests/compare/2d91b20b2b38^...2a9be8ee5070
  66. # [17:05] -gitbot:#testing- web-platform-tests/jgraham/fix_refurl 2d91b20 James Graham: Figure out refurl correctly in manifest parser.
  67. # [17:05] -gitbot:#testing- web-platform-tests/jgraham/fix_refurl 2a9be8e James Graham: Update to latest testharness.js
  68. # [17:05] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  69. # [17:06] * Joins: gitbot (~gitbot@public.cloak)
  70. # [17:06] -gitbot:#testing- [web-platform-tests] jgraham opened pull request #985: Fix computation of reftest reference url in manifest. (master...jgraham/fix_refurl) https://github.com/w3c/web-platform-tests/pull/985
  71. # [17:06] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  72. # [17:06] <jgraham> MikeSmith: https://critic.hoppipolla.co.uk/r/1534
  73. # [17:14] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  74. # [17:17] <MikeSmith> jgraham: trying to review in critic on my mobile and realizing that critic doesn't seem to beusable on mobile with a soft keyboard due to relying on keyboard shortcuts
  75. # [17:17] <jgraham> MikeSmith: Hmm, I don't think it is very usable on a mobile, but which keyboard shortcuts? I think most things are possible without the keyboard
  76. # [17:18] * MikeSmith tries to figure out out there's a way to force keyboard to appear
  77. # [17:18] <MikeSmith> jgraham: e and s keys
  78. # [17:18] <MikeSmith> to show the actual changes
  79. # [17:19] <jgraham> MikeSmith: You can just click on the path though
  80. # [17:19] <MikeSmith> ah
  81. # [17:19] <MikeSmith> didn't know
  82. # [17:20] <jgraham> :|
  83. # [17:21] <jgraham> Would be really nice to get someone with a UX bent to contribute to critic and improve the visual affordances so people aren't always so surprised about how it works
  84. # [17:22] <MikeSmith> jgraham: yeah
  85. # [17:25] <MikeSmith> jgraham: So I'm looking at the change. question: the runner doesn't expect the value of ref_url to start with a slash? or doesn't care? I ask because I notice that all the existing ref_url values in the manifest do seem to start with a slash.
  86. # [17:27] <jgraham> MikeSmith: Yeah, it should start with a / I think. Although I don't exactly remember the implementation, so it's quite possible it will work if it doesn't
  87. # [17:28] * Quits: Lachy (~Lachy@public.cloak) ("My MacBook Pro has gone to sleep. ZZZzzz…")
  88. # [17:28] <jgraham> But url always starts with a / so ref_url will always start with a / too
  89. # [17:30] <MikeSmith> jgraham: are you sure you don't have that the other way around? I thought the code constructed url from ref_url
  90. # [17:32] <MikeSmith> line 238 I mean
  91. # [17:33] <jgraham> MikeSmith: If you load a test file that sets the url for the test (assuming no query string, which isn't supported yet)
  92. # [17:33] <MikeSmith> Ok
  93. # [17:33] <jgraham> At that point you don't know if a file is a test file or not, but later on, if you find a <meta> with the right properties it is, by definition
  94. # [17:34] <jgraham> so url is the url of the test file and the ref url is resolved relative to the test file url
  95. # [17:34] <jgraham> i.e. ref_url = urlparse.urljoin(url, item.attrib["href"])
  96. # [17:42] <MikeSmith> jgraham: yeah, sorry, I misread initially. I thought you had urlparse.urljoin(rel_path, item.attrib["href"])
  97. # [18:04] * Joins: koji (~koji@public.cloak)
  98. # [18:13] * Quits: koji (~koji@public.cloak) (Ping timeout: 180 seconds)
  99. # [18:29] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  100. # [18:36] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Ping timeout: 180 seconds)
  101. # [18:37] * Joins: koji (~koji@public.cloak)
  102. # [18:48] * Joins: Lachy (~Lachy@public.cloak)
  103. # [18:56] * Quits: Lachy (~Lachy@public.cloak) ("My MacBook Pro has gone to sleep. ZZZzzz…")
  104. # [18:57] * Joins: lmclister (~lmclister@public.cloak)
  105. # [19:19] <jgraham> MikeSmith: Thanks for the review
  106. # [19:19] * Joins: gitbot (~gitbot@public.cloak)
  107. # [19:19] -gitbot:#testing- [web-platform-tests] jgraham closed pull request #985: Fix computation of reftest reference url in manifest. (master...jgraham/fix_refurl) https://github.com/w3c/web-platform-tests/pull/985
  108. # [19:19] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  109. # [19:37] * Joins: darobin (rberjon@public.cloak)
  110. # [19:55] * Quits: darobin (rberjon@public.cloak) (Client closed connection)
  111. # [20:01] * Quits: lmclister (~lmclister@public.cloak) ("")
  112. # [20:04] * Joins: darobin (rberjon@public.cloak)
  113. # [20:11] * Joins: ptressel (~chatzilla@public.cloak)
  114. # [21:12] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  115. # [21:53] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  116. # [21:59] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  117. # [22:03] * Joins: Lachy (~Lachy@public.cloak)
  118. # [22:10] * Quits: darobin (rberjon@public.cloak) ("Leaving...")
  119. # [22:12] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  120. # [22:16] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  121. # [22:16] * Joins: zcorpan (~zcorpan@public.cloak)
  122. # [22:20] * Quits: koji (~koji@public.cloak) (Client closed connection)
  123. # [22:21] * Joins: koji (~koji@public.cloak)
  124. # [22:21] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  125. # [22:22] * Joins: zcorpan (~zcorpan@public.cloak)
  126. # [22:28] * Quits: koji (~koji@public.cloak) (Ping timeout: 180 seconds)
  127. # [22:29] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  128. # [22:30] * Quits: Lachy (~Lachy@public.cloak) ("My MacBook Pro has gone to sleep. ZZZzzz…")
  129. # [22:31] * Joins: Lachy (~Lachy@public.cloak)
  130. # [22:34] * Joins: zcorpan (~zcorpan@public.cloak)
  131. # [22:36] * Joins: zcorpan_ (~zcorpan@public.cloak)
  132. # [22:36] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  133. # [22:36] * Joins: zcorpan (~zcorpan@public.cloak)
  134. # [22:36] * Quits: zcorpan_ (~zcorpan@public.cloak) (Client closed connection)
  135. # [22:43] * Quits: Ms2ger (~Ms2ger@public.cloak) ("nn")
  136. # [22:44] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  137. # [23:01] * Joins: koji (~koji@public.cloak)
  138. # [23:05] * Joins: zcorpan (~zcorpan@public.cloak)
  139. # [23:10] * Quits: Lachy (~Lachy@public.cloak) ("My MacBook Pro has gone to sleep. ZZZzzz…")
  140. # [23:12] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  141. # [23:15] * Joins: Lachy (~Lachy@public.cloak)
  142. # [23:28] * Quits: koji (~koji@public.cloak) (Client closed connection)
  143. # [23:28] * Joins: koji (~koji@public.cloak)
  144. # [23:29] * Quits: Lachy (~Lachy@public.cloak) ("Textual IRC Client: www.textualapp.com")
  145. # [23:31] * Joins: Lachy (~Lachy@public.cloak)
  146. # [23:35] * Quits: koji (~koji@public.cloak) (Ping timeout: 180 seconds)
  147. # [23:50] * Quits: Lachy (~Lachy@public.cloak) ("My MacBook Pro has gone to sleep. ZZZzzz…")
  148. # [23:55] * Joins: Lachy (~Lachy@public.cloak)
  149. # [23:56] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  150. # Session Close: Mon May 12 00:00:00 2014

The end :)