/irc-logs / w3c / #testing / 2014-05-28 / end

Options:

  1. # Session Start: Wed May 28 00:00:01 2014
  2. # Session Ident: #testing
  3. # [00:10] * Joins: rhauck (~Adium@public.cloak)
  4. # [00:27] * Joins: ptressel (~chatzilla@public.cloak)
  5. # [00:29] * Joins: gitbot (~gitbot@public.cloak)
  6. # [00:29] -gitbot:#testing- [web-platform-tests] omo opened pull request #1024: HTML Imports: Removing old tests. (master...old-removal) https://github.com/w3c/web-platform-tests/pull/1024
  7. # [00:29] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  8. # [00:30] * Joins: gitbot (~gitbot@public.cloak)
  9. # [00:30] -gitbot:#testing- [web-platform-tests] omo closed pull request #1024: HTML Imports: Removing old tests. (master...old-removal) https://github.com/w3c/web-platform-tests/pull/1024
  10. # [00:30] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  11. # [00:31] * Joins: gitbot (~gitbot@public.cloak)
  12. # [00:31] -gitbot:#testing- [web-platform-tests] omo opened pull request #1025: HTML Imports: Removing old tests. (master...html-imports-old-removal) https://github.com/w3c/web-platform-tests/pull/1025
  13. # [00:31] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  14. # [00:33] * Joins: gitbot (~gitbot@public.cloak)
  15. # [00:33] -gitbot:#testing- [web-platform-tests] dglazkov pushed 2 new commits to master: https://github.com/w3c/web-platform-tests/compare/77f8216282cb...0d02c98240fa
  16. # [00:33] -gitbot:#testing- web-platform-tests/master 99faa06 Hajime Morrita: HTML Imports: Removing old tests....
  17. # [00:33] -gitbot:#testing- web-platform-tests/master 0d02c98 Dimitri Glazkov: Merge pull request #1025 from omo/html-imports-old-removal...
  18. # [00:33] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  19. # [00:33] * Joins: gitbot (~gitbot@public.cloak)
  20. # [00:33] -gitbot:#testing- [web-platform-tests] dglazkov closed pull request #1025: HTML Imports: Removing old tests. (master...html-imports-old-removal) https://github.com/w3c/web-platform-tests/pull/1025
  21. # [00:33] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  22. # [01:02] * Joins: MK (kawamori@public.cloak)
  23. # [01:44] * Quits: Automate_ (~AutomatedTester@public.cloak) (Client closed connection)
  24. # [01:46] * Joins: zcorpan (~zcorpan@public.cloak)
  25. # [01:50] * Quits: lmclister (~lmclister@public.cloak) ("")
  26. # [01:53] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  27. # [02:12] * Quits: ptressel (~chatzilla@public.cloak) ("bbl")
  28. # [02:19] * Joins: gitbot (~gitbot@public.cloak)
  29. # [02:19] -gitbot:#testing- [web-platform-tests] omo opened pull request #1026: HTML Imports: Cover "Extensions to HTMLLinkElement Interface" (master...html-import-html-link-element) https://github.com/w3c/web-platform-tests/pull/1026
  30. # [02:19] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  31. # [02:23] * Quits: rhauck (~Adium@public.cloak) ("Leaving.")
  32. # [02:24] * Joins: rhauck (~Adium@public.cloak)
  33. # [02:31] * Quits: rhauck (~Adium@public.cloak) (Ping timeout: 180 seconds)
  34. # [02:58] * Joins: gitbot (~gitbot@public.cloak)
  35. # [02:58] -gitbot:#testing- [web-platform-tests] omo opened pull request #1027: HTML Imports: Cover "Extensions to Document Interface" section. (master...html-imports-document) https://github.com/w3c/web-platform-tests/pull/1027
  36. # [02:58] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  37. # [03:27] * Joins: hank (~hank@public.cloak)
  38. # [04:00] * Joins: plh (plehegar@public.cloak)
  39. # [04:36] * Quits: hank (~hank@public.cloak) (Ping timeout: 180 seconds)
  40. # [05:01] * Joins: gitbot (~gitbot@public.cloak)
  41. # [05:01] -gitbot:#testing- [web-platform-tests] yuanyuanzou opened pull request #1028: Should pop up a dialog with "no case found" ,if there is no case to test. (master...no_case_found) https://github.com/w3c/web-platform-tests/pull/1028
  42. # [05:01] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  43. # [05:33] * Joins: lmclister (~lmclister@public.cloak)
  44. # [05:55] <MikeSmith> plh, jgraham: I wonder if we should have the linter check to make sure there's whitespace before and after "{" and "}" braces
  45. # [06:18] * Quits: lmclister (~lmclister@public.cloak) ("")
  46. # [06:31] * Joins: lmclister (~lmclister@public.cloak)
  47. # [06:52] * Joins: MK_ (kawamori@public.cloak)
  48. # [06:58] * Quits: MK (kawamori@public.cloak) (Ping timeout: 180 seconds)
  49. # [07:01] * Quits: plh (plehegar@public.cloak) ("Leaving")
  50. # [07:03] * Joins: gitbot (~gitbot@public.cloak)
  51. # [07:03] -gitbot:#testing- [web-platform-tests] hayatoito pushed 2 new commits to master: https://github.com/w3c/web-platform-tests/compare/0d02c98240fa...4d2767be1e35
  52. # [07:03] -gitbot:#testing- web-platform-tests/master a90c2e1 Hajime Morrita: HTML Imports: Cover "Extensions to Document Interface" section.
  53. # [07:03] -gitbot:#testing- web-platform-tests/master 4d2767b Hayato Ito: Merge pull request #1027 from omo/html-imports-document...
  54. # [07:03] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  55. # [07:03] * Joins: gitbot (~gitbot@public.cloak)
  56. # [07:03] -gitbot:#testing- [web-platform-tests] hayatoito closed pull request #1026: HTML Imports: Cover "Extensions to HTMLLinkElement Interface" (master...html-import-html-link-element) https://github.com/w3c/web-platform-tests/pull/1026
  57. # [07:03] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  58. # [07:20] * Quits: MK_ (kawamori@public.cloak) (Ping timeout: 180 seconds)
  59. # [07:21] * Quits: lmclister (~lmclister@public.cloak) ("")
  60. # [07:21] * Joins: lmclister (~lmclister@public.cloak)
  61. # [07:24] * Joins: MK (kawamori@public.cloak)
  62. # [07:59] * Joins: zcorpan (~zcorpan@public.cloak)
  63. # [08:16] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  64. # [08:26] * Quits: MK (kawamori@public.cloak) (Ping timeout: 180 seconds)
  65. # [08:54] * Joins: ptressel (~chatzilla@public.cloak)
  66. # [09:00] * Quits: Lachy (~Lachy@public.cloak) ("My MacBook Pro has gone to sleep. ZZZzzz…")
  67. # [09:02] * Joins: hank (~hank@public.cloak)
  68. # [09:05] * Joins: Ms2ger (~Ms2ger@public.cloak)
  69. # [09:09] * Joins: zcorpan (~zcorpan@public.cloak)
  70. # [09:10] * Quits: zcorpan (~zcorpan@public.cloak) ("Leaving...")
  71. # [09:16] * Joins: zcorpan (~zcorpan@public.cloak)
  72. # [09:22] * Joins: Lachy (~Lachy@public.cloak)
  73. # [09:40] * Joins: dom (dom@public.cloak)
  74. # [09:45] * Joins: MK (kawamori@public.cloak)
  75. # [09:49] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  76. # [10:09] * Joins: gitbot (~gitbot@public.cloak)
  77. # [10:09] -gitbot:#testing- [web-platform-tests] coonsta closed pull request #1003: fixing share-registry-import-document.html test (master...submission/unipro-custom-elements-17) https://github.com/w3c/web-platform-tests/pull/1003
  78. # [10:09] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  79. # [10:23] * Quits: MK (kawamori@public.cloak) (Ping timeout: 180 seconds)
  80. # [10:45] * Joins: darobin (rberjon@public.cloak)
  81. # [10:46] * Joins: gitbot (~gitbot@public.cloak)
  82. # [10:46] -gitbot:#testing- [web-platform-tests] hayatoito pushed 3 new commits to master: https://github.com/w3c/web-platform-tests/compare/f95a1ac45819...581754f88212
  83. # [10:46] -gitbot:#testing- web-platform-tests/master 05a43d0 iseki: shadow dom: modify description and createSR(el) wrapper to el.createShadowRoot
  84. # [10:46] -gitbot:#testing- web-platform-tests/master f0bad6b iseki: Rename test-008.html to activeElement-confirm-return-null.html
  85. # [10:46] -gitbot:#testing- web-platform-tests/master 581754f Hayato Ito: Merge pull request #900 from iseki-masaya/submissions/iseki-masaya-host...
  86. # [10:46] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  87. # [10:48] * Quits: hank (~hank@public.cloak) (Ping timeout: 180 seconds)
  88. # [10:55] * Joins: gitbot (~gitbot@public.cloak)
  89. # [10:55] -gitbot:#testing- [web-platform-tests] hayatoito closed pull request #881: shadow dom: confirm shadowRoot is readonly (master...submissions/iseki-masaya-shadowRoot) https://github.com/w3c/web-platform-tests/pull/881
  90. # [10:55] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  91. # [10:55] * Quits: ptressel (~chatzilla@public.cloak) (Client closed connection)
  92. # [11:00] * Joins: hank (~hank@public.cloak)
  93. # [11:00] <jgraham> MikeSmith: Well "after" seems wrong (if you have f(function() { /*stuff*/ }) I don't think you want a space), and adding lots of js linting seems hard. I'd rather reenable some of the rules that we already have.
  94. # [11:01] <jgraham> And add some wpt-specific rules like "must include testharnessreport.js if you included testharness.js"
  95. # [11:11] <MikeSmith> jgraham: ah yeah true
  96. # [11:12] * Quits: Ms2ger (~Ms2ger@public.cloak) ("bbl")
  97. # [11:13] <MikeSmith> jgraham: btw in other news I notice that sync.py doesn't seem to sync a PR branch when you push additional new commits to it
  98. # [11:13] <MikeSmith> denis: ↑☃
  99. # [11:14] <denis> MikeSmith, any particular PR?
  100. # [11:16] <MikeSmith> denis: #1013
  101. # [11:17] <MikeSmith> hmm wait maybe it actually does
  102. # [11:18] * Quits: hank (~hank@public.cloak) (Ping timeout: 180 seconds)
  103. # [11:20] <MikeSmith> nah, on second-second thought, no it doesn't sync the PR branch
  104. # [11:21] <MikeSmith> denis: trying git log in /u/www.w3c-test.org/web-platform-tests/submissions/1013
  105. # [11:24] <denis> the last commit doesn't show up
  106. # [11:27] <denis> MikeSmith,
  107. # [11:27] <denis> [[
  108. # [11:27] <denis> We couldn’t deliver this payload: Service Timeout
  109. # [11:27] <denis> ]]
  110. # [11:28] <denis> from the webhooks list on gh
  111. # [11:33] <MikeSmith> denis: oh
  112. # [11:37] * Joins: ptressel (~chatzilla@public.cloak)
  113. # [11:42] * Joins: gitbot (~gitbot@public.cloak)
  114. # [11:42] -gitbot:#testing- [web-platform-tests] sideshowbarker closed pull request #447: Fix tests for parsing template elements inside XHTML documents (master...fix-xhtml-template-element-parsing-tests) https://github.com/w3c/web-platform-tests/pull/447
  115. # [11:42] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  116. # [11:42] * Joins: gitbot (~gitbot@public.cloak)
  117. # [11:42] -gitbot:#testing- [web-platform-tests] sideshowbarker deleted fix-xhtml-template-element-parsing-tests at 8e31397: https://github.com/w3c/web-platform-tests/commit/8e31397
  118. # [11:42] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  119. # [11:51] * Joins: gitbot (~gitbot@public.cloak)
  120. # [11:51] -gitbot:#testing- [web-platform-tests] hayatoito pushed 3 new commits to master: https://github.com/w3c/web-platform-tests/compare/581754f88212...064788d70ce6
  121. # [11:51] -gitbot:#testing- web-platform-tests/master c5414c9 Naoki Muramatsu: shadow dom: no entry corresponding to the test in specification
  122. # [11:51] -gitbot:#testing- web-platform-tests/master e43f4fa Naoki Muramatsu: shadow dom: remove test for currentScript.
  123. # [11:51] -gitbot:#testing- web-platform-tests/master 064788d Hayato Ito: Merge pull request #883 from Stryfe/Stryfe/currentScript-in-shadowRoot...
  124. # [11:51] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  125. # [11:56] <denis> jgraham, you have a min to help debug something with sync.py ?
  126. # [12:15] * Joins: gitbot (~gitbot@public.cloak)
  127. # [12:15] -gitbot:#testing- [web-platform-tests] hayatoito closed pull request #156: new test files about custome pseudo elemens of shadow dom from TestTWF (master...submissions/kumatronik) https://github.com/w3c/web-platform-tests/pull/156
  128. # [12:15] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  129. # [12:21] * Joins: dsr (dsr@public.cloak)
  130. # [12:21] * Parts: dsr (dsr@public.cloak) (dsr)
  131. # [12:23] * Joins: gitbot (~gitbot@public.cloak)
  132. # [12:23] -gitbot:#testing- [web-platform-tests] hayatoito closed pull request #143: nested shadow dom test (master...submission/thujikun) https://github.com/w3c/web-platform-tests/pull/143
  133. # [12:23] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  134. # [12:28] <jgraham> denis: Have now I'm online again :)
  135. # [12:29] <denis> jgraham: one of MikeSmith's comit on PR #1013 didn't get synced on w3c-test.org
  136. # [12:29] <denis> because of the json GH sent to sync.py
  137. # [12:30] <jgraham> Oh?
  138. # [12:30] <denis> see: https://gist.github.com/deniak/a383fbf7d5449fee8756
  139. # [12:30] <jgraham> What was the error?
  140. # [12:30] <denis> the commit simply removes a file: https://github.com/w3c/web-platform-tests/commit/53168510e48239ff4f78e8b4129a970cd26b20f2
  141. # [12:31] <denis> no error actually, just that the json doesn't have "pull_request" key
  142. # [12:31] <denis> for instance, look at the previous json: https://gist.github.com/deniak/ecba2b0ea81f372c8610
  143. # [12:31] <denis> that one worked
  144. # [12:34] <denis> it supposed to be more or less the same thing, i.e. simple commits on a PR
  145. # [12:35] <denis> not sure if it helps but when sync.py see the key "commits", it simply updates the master
  146. # [12:37] <denis> oh wait
  147. # [12:38] <denis> MikeSmith, you also added a comment to the commit
  148. # [12:39] * denis sees the hook was triggered twice at the same time
  149. # [12:39] <denis> and the one that was supposed to update the PR failed
  150. # [12:40] <jgraham> That JSON doesn't look much like the documentation for any event type
  151. # [12:41] <jgraham> I guess sync.py should key off X-GitHub-Event rather than looking at the event
  152. # [12:41] <jgraham> + body
  153. # [12:41] <MikeSmith> jgraham: yeah it seems like that might be more reliable
  154. # [12:42] <jgraham> But that doesn't explain why it failed in this case, I don't think
  155. # [12:43] <denis> jgraham, MikeSmith: https://github.com/w3c/web-platform-tests/settings/hooks/1932908
  156. # [12:44] <denis> look for a9e9339a-e560-11e3-8213-99b2c051aaa6
  157. # [12:44] <denis> and for a9d24e00-e560-11e3-90cb-a17570e2ded0
  158. # [12:45] <denis> they were both called at the same time
  159. # [12:45] <jgraham> denis: I'm not allowed to see that page
  160. # [12:46] <denis> a9e9339a-e560-11e3-8213-99b2c051aaa6 … 2014-05-27 05:35:06
  161. # [12:46] <denis> a9d24e00-e560-11e3-90cb-a17570e2ded0 … 2014-05-27 05:35:08
  162. # [12:46] <denis> the first one delivered the json with the "commits" key and it worked
  163. # [12:47] <denis> the second one delivered the json that was supposed to update the PR ("pull_request" key) but it failed
  164. # [12:48] <denis> must be a race condition
  165. # [12:49] <jgraham> Yeah, could be. It isn't really clear what would race though. They both do update_master() which fetches the remote… maybe runnign checkout twice simultaneously doesn't work
  166. # [12:51] <jgraham> Anyway we could create a lockfile uding e.g. http://pythonhosted.org//lockfile/lockfile.html
  167. # [12:54] <denis> ok, I'll try to submit a PR soon
  168. # [12:57] <denis> MikeSmith, I hit "redeliver" again for your payload
  169. # [12:57] <denis> it should be synced now
  170. # [12:58] <denis> sorry it's not running smoothly. hopefully it'll be better with the lockfile jgraham suggested
  171. # [13:03] <denis> jgraham, thanks for helping debug the issue
  172. # [13:05] * Joins: zcorpan (~zcorpan@public.cloak)
  173. # [13:05] <jgraham> denis: np, thank you
  174. # [13:30] <MikeSmith> sorry stepped out for a bit
  175. # [13:31] * MikeSmith looks through scrollback
  176. # [13:32] <MikeSmith> oh good a lockfile should help
  177. # [13:40] <MikeSmith> jgraham: I wonder if you might could have critic create a review for https://github.com/w3c/web-platform-tests/pull/875
  178. # [13:42] * Joins: gitbot (~gitbot@public.cloak)
  179. # [13:42] -gitbot:#testing- [web-platform-tests] jgraham closed pull request #875: add window.open arguments test (master...tb_create_browsing_context) https://github.com/w3c/web-platform-tests/pull/875
  180. # [13:42] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  181. # [13:42] * Joins: gitbot (~gitbot@public.cloak)
  182. # [13:42] -gitbot:#testing- [web-platform-tests] jgraham reopened pull request #875: add window.open arguments test (master...tb_create_browsing_context) https://github.com/w3c/web-platform-tests/pull/875
  183. # [13:42] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  184. # [13:43] <jgraham> MikeSmith: Done
  185. # [13:43] <MikeSmith> thanks
  186. # [13:51] * Joins: Lachy_ (~Lachy@public.cloak)
  187. # [13:51] * Quits: Lachy (~Lachy@public.cloak) (Client closed connection)
  188. # [14:17] <MikeSmith> security is Failure, wrong key. The right key is 5f17aca1ae2edea0f145e884116371a5
  189. # [14:26] <jgraham> ?
  190. # [14:29] <MikeSmith> jgraham: https://www.portcullis-security.com/security-research-and-downloads/security-advisories/cve-2014-3445/
  191. # [14:40] <jgraham> heh
  192. # [15:00] * Joins: gitbot (~gitbot@public.cloak)
  193. # [15:00] -gitbot:#testing- [web-platform-tests] sideshowbarker closed pull request #1028: Should pop up a dialog with "no case found" ,if there is no case to test. (master...no_case_found) https://github.com/w3c/web-platform-tests/pull/1028
  194. # [15:00] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  195. # [15:00] * Joins: gitbot (~gitbot@public.cloak)
  196. # [15:00] -gitbot:#testing- [web-platform-tests] sideshowbarker pushed 3 new commits to master: https://github.com/w3c/web-platform-tests/compare/064788d70ce6...85318fdb00e2
  197. # [15:00] -gitbot:#testing- web-platform-tests/master 5b19d16 yuanyuan.zou: If there no case found ,pop up a dialog with "no case found"
  198. # [15:00] -gitbot:#testing- web-platform-tests/master a87a7f2 yuanyuan.zou: --amend
  199. # [15:00] -gitbot:#testing- web-platform-tests/master 85318fd Michael[tm] Smith: Merge pull request #1028 from yuanyuanzou/no_case_found...
  200. # [15:00] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  201. # [15:23] * Joins: gitbot (~gitbot@public.cloak)
  202. # [15:23] -gitbot:#testing- [web-platform-tests] sideshowbarker pushed 3 new commits to master: https://github.com/w3c/web-platform-tests/compare/85318fdb00e2...edf0c1038a2c
  203. # [15:23] -gitbot:#testing- web-platform-tests/master fba6678 yuanyuan.zou: Need clean or hide the area of dump result json after clicking start button again
  204. # [15:23] -gitbot:#testing- web-platform-tests/master 2f1ef20 yuanyuan.zou: --amend
  205. # [15:23] -gitbot:#testing- web-platform-tests/master edf0c10 yuanyuan.zou: Need to clear the progressbar to 0% when start the test
  206. # [15:23] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  207. # [15:33] * Joins: gitbot (~gitbot@public.cloak)
  208. # [15:33] -gitbot:#testing- [web-platform-tests] sideshowbarker closed pull request #1006: Need clean or hide the area of dump result json after clicking start button again (master...intel_cross_walk) https://github.com/w3c/web-platform-tests/pull/1006
  209. # [15:33] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  210. # [15:44] * Joins: gitbot (~gitbot@public.cloak)
  211. # [15:44] -gitbot:#testing- [web-platform-tests] sideshowbarker closed pull request #412: Submission/cosmichut (master...submission/cosmichut) https://github.com/w3c/web-platform-tests/pull/412
  212. # [15:44] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  213. # [15:44] * Joins: gitbot (~gitbot@public.cloak)
  214. # [15:44] -gitbot:#testing- [web-platform-tests] sideshowbarker pushed 4 new commits to master: https://github.com/w3c/web-platform-tests/compare/edf0c1038a2c...0626aeb31ea1
  215. # [15:44] -gitbot:#testing- web-platform-tests/master 30e3d31 justin.shen: test id with none pure alpha characters
  216. # [15:44] -gitbot:#testing- web-platform-tests/master 253ae1f justin.shen: test id with none pure alpha characters
  217. # [15:44] -gitbot:#testing- web-platform-tests/master ce13ba7 justin.shen: id with non-pure alpha characters - updated
  218. # [15:44] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  219. # [15:50] * Joins: gitbot (~gitbot@public.cloak)
  220. # [15:50] -gitbot:#testing- [web-platform-tests] sideshowbarker pushed 1 new commit to master: https://github.com/w3c/web-platform-tests/commit/8a96f28b0724090150a26d87f6b614c65a921d3d
  221. # [15:50] -gitbot:#testing- web-platform-tests/master 8a96f28 Michael[tm] Smith: Dropped unnecessary help link (cleanup #412).
  222. # [15:50] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  223. # [16:15] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  224. # [16:18] * Joins: MK (kawamori@public.cloak)
  225. # [16:26] * Joins: hank (~hank@public.cloak)
  226. # [16:29] * Quits: MK (kawamori@public.cloak) (Ping timeout: 180 seconds)
  227. # [16:32] * Quits: lmclister (~lmclister@public.cloak) ("")
  228. # [16:34] <darobin> MikeSmith++ # shaking the PR tree
  229. # [16:35] <jgraham> Is that some kind of youtube dance craze?
  230. # [16:35] <jgraham> I have trouble keeping up
  231. # [16:50] * Quits: hank (~hank@public.cloak) (Ping timeout: 180 seconds)
  232. # [17:02] <MikeSmith> sorry for party rocking
  233. # [17:02] <MikeSmith> blame plh
  234. # [17:03] <MikeSmith> I'll take a beer break for now
  235. # [17:12] * Joins: MK (kawamori@public.cloak)
  236. # [17:23] <darobin> I reckon "Shake That PR Tree" could be a nice cover of https://www.youtube.com/watch?v=dcz0h5fBSuw
  237. # [17:28] * Quits: Lachy_ (~Lachy@public.cloak) ("My MacBook Pro has gone to sleep. ZZZzzz…")
  238. # [17:29] * Joins: Lachy (~Lachy@public.cloak)
  239. # [17:31] * Quits: Lachy (~Lachy@public.cloak) ("My MacBook Pro has gone to sleep. ZZZzzz…")
  240. # [17:35] * Joins: gitbot (~gitbot@public.cloak)
  241. # [17:35] -gitbot:#testing- [web-platform-tests] gsnedders closed pull request #304: Add whole load of tests for "Loading Web Pages". (master...op_browsing) https://github.com/w3c/web-platform-tests/pull/304
  242. # [17:35] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  243. # [17:39] * Joins: lmclister (~lmclister@public.cloak)
  244. # [17:41] * Quits: ptressel (~chatzilla@public.cloak) ("zzz")
  245. # [17:41] * Quits: MK (kawamori@public.cloak) (Ping timeout: 180 seconds)
  246. # [17:44] * Joins: Lachy (~Lachy@public.cloak)
  247. # [17:47] <odinho> MikeSmith: The PR's are not "mine" by any standard. We had a dugnad where everyone created PR's from whatever was in submissions/ directories :)
  248. # [17:48] <odinho> So I could probably review some of them myself in spare time :)
  249. # [17:51] * Quits: Lachy (~Lachy@public.cloak) ("My MacBook Pro has gone to sleep. ZZZzzz…")
  250. # [17:53] <darobin> yeah, same for me
  251. # [17:53] <darobin> some of those are pretty big though
  252. # [18:04] <ato> odinho: Didn't you learn that if you touch something, you own it? (-;
  253. # [18:21] * Quits: darobin (rberjon@public.cloak) (Client closed connection)
  254. # [18:33] * Joins: rhauck (~Adium@public.cloak)
  255. # [18:39] * Joins: Ms2ger (~Ms2ger@public.cloak)
  256. # [18:48] * Ms2ger mumbles something about emails from MikeSmith
  257. # [18:54] * Joins: gitbot (~gitbot@public.cloak)
  258. # [18:54] -gitbot:#testing- [web-platform-tests] Ms2ger closed pull request #87: Removing tests for Khronos specs. (master...rm-khronos-tests) https://github.com/w3c/web-platform-tests/pull/87
  259. # [18:54] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  260. # [19:04] <MikeSmith> apologies for all the love
  261. # [19:04] <MikeSmith> tough love
  262. # [19:05] <Ms2ger> There's a fair chance I'll deal with the page loading stuff this summer
  263. # [19:06] <MikeSmith> that's a big chunk of work I guess
  264. # [19:07] <jgraham> MikeSmith: BTW, expecting me to read GitHub mail is… optimistic
  265. # [19:07] <jgraham> I need to figure out a better system there
  266. # [19:08] <jgraham> If I had just made a seperate PR for my innerHTML tests they would have landed by now
  267. # [19:08] <jgraham> Bundling it with the other DOM Parsing tests was a mistake
  268. # [19:09] <Ms2ger> Yes :)
  269. # [19:09] <jgraham> Not only because the W3C and WHATWG specs are different
  270. # [19:10] <MikeSmith> jgraham: my system it to let my inbox eventually reach some couple few thousand unread bugmail/notification messages and then I just take pretty much a whole day during some week to just garden it back down
  271. # [19:10] <jgraham> My system so far is to assume that all mail from GitHub is unwanted spam due to their broken notification system
  272. # [19:10] <jgraham> That's about 80% right
  273. # [19:11] <MikeSmith> odinho: btw as far as those CSP tests, I think the webappsec WG has their own test repo and I'd think those PRs just duplicate whatever CSP tests they have in their test suite at this point
  274. # [19:11] * Joins: gitbot (~gitbot@public.cloak)
  275. # [19:11] -gitbot:#testing- [web-platform-tests] jgraham reopened pull request #304: Add whole load of tests for "Loading Web Pages". (master...op_browsing) https://github.com/w3c/web-platform-tests/pull/304
  276. # [19:11] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  277. # [19:14] <jgraham> MikeSmith: I am morally opposed to closing PRs that we want to merge but haven't got time to look at at the moment
  278. # [19:14] <jgraham> It's optimising for the wrong things
  279. # [19:14] <MikeSmith> jgraham: I don't feel strongly about closing them but I think it's a bad idea for them to have no owner if they're remaining open
  280. # [19:15] <jgraham> The problem is not generally lack of owners, it's lack of reviewers
  281. # [19:17] <MikeSmith> yeah, understood
  282. # [19:20] <jgraham> Ms2ger: So I see the Window changes made it to cedar: https://tbpl.mozilla.org/php/getParsedLog.php?id=40558387
  283. # [19:20] <Ms2ger> Yep
  284. # [19:21] <Ms2ger> And bz's empty-string-in-HTMLCollection change
  285. # [19:21] <MikeSmith> jgraham: but anyway, even for PRs that basically look merge-worthy, if they stay open for N months, at some point the people who submitted them may pretty much lose interest in following up on them even if somebody does get back around to finishing the review on them
  286. # [19:21] <Ms2ger> The history one is interesting
  287. # [19:21] <jgraham> MikeSmith: Yeah, so in that case someone needs to take over responsibility
  288. # [19:22] <jgraham> It's no problem if the reviewer fixes their own issues for example
  289. # [19:22] <jgraham> of course GitHub makes this hard
  290. # [19:23] * Quits: dom (dom@public.cloak) ("")
  291. # [19:23] <MikeSmith> jgraham: btw about the "Not tests found" thing being an alert -- yeah, sorry, I thought the same thing when I reviewed it and I probably should have waited to merge it but at the time I didn't have anything concrete to suggest as an alternative. But now I do so I'll submit a new PR for it
  292. # [19:24] <MikeSmith> jgraham: and yeah GitHub seems to make review management harder than it should be
  293. # [19:24] <jgraham> MikeSmith: np, probably better to merge it and encourage us to make it even better than push back too hard
  294. # [19:26] <MikeSmith> jgraham: yeah in general but on that one I should have pubshed back because I think he's quite capable of coming up with something integrated into the runner UI, since he's already made a number of changes to it and seems to be pretty familiar with it by now
  295. # [19:55] * Joins: gitbot (~gitbot@public.cloak)
  296. # [19:55] -gitbot:#testing- [web-platform-tests] sideshowbarker pushed 1 new commit to master: https://github.com/w3c/web-platform-tests/commit/c84392a9931e6e9dcf57bd30a2b235b1abd1af2a
  297. # [19:55] -gitbot:#testing- web-platform-tests/master c84392a Michael[tm] Smith: Cleaned up my flubbed merge of PR #1006.
  298. # [19:55] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  299. # [20:29] * Quits: lmclister (~lmclister@public.cloak) ("")
  300. # [20:30] <odinho> MikeSmith: Nope, webappsec uses WPT. I think I sent out an email about a year ago that we'd move. Or it was rather a "anyone opposed, if not it defaults to yay cool". And it went to "yay cool".
  301. # [20:31] * Joins: lmclister (~lmclister@public.cloak)
  302. # [20:44] * Quits: botie (botie@public.cloak) (Client closed connection)
  303. # [20:59] * Joins: darobin (rberjon@public.cloak)
  304. # [21:31] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  305. # [21:34] * Joins: Automate_ (~AutomatedTester@public.cloak)
  306. # [21:34] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  307. # [21:35] * Quits: rhauck (~Adium@public.cloak) ("Leaving.")
  308. # [21:38] * Quits: darobin (rberjon@public.cloak) ("Leaving...")
  309. # [21:59] * Quits: Ms2ger (~Ms2ger@public.cloak) ("nn")
  310. # [22:00] * Joins: rhauck (~Adium@public.cloak)
  311. # [22:37] * Quits: rhauck (~Adium@public.cloak) ("Leaving.")
  312. # [22:40] * Joins: rhauck (~Adium@public.cloak)
  313. # [23:00] * Quits: Automate_ (~AutomatedTester@public.cloak) (Client closed connection)
  314. # [23:29] * Joins: MK (kawamori@public.cloak)
  315. # Session Close: Thu May 29 00:00:00 2014

The end :)