/irc-logs / w3c / #testing / 2014-06-09 / end

Options:

  1. # Session Start: Mon Jun 09 00:00:00 2014
  2. # Session Ident: #testing
  3. # [00:15] * Joins: shepazu (schepers@public.cloak)
  4. # [00:26] * Quits: shepazu (schepers@public.cloak) ("is sleepy")
  5. # [05:41] * Joins: ptressel (~chatzilla@public.cloak)
  6. # [08:35] * Joins: gitbot (~gitbot@public.cloak)
  7. # [08:35] -gitbot:#testing- [web-platform-tests] zqzhang pushed 1 new commit to master: https://github.com/w3c/web-platform-tests/commit/11eb63c60fc2d4ed8e4f0c93a8dccc226417ad04
  8. # [08:35] -gitbot:#testing- web-platform-tests/master 11eb63c plehegar: RT MS test
  9. # [08:35] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  10. # [08:37] * Joins: Ms2ger (~Ms2ger@public.cloak)
  11. # [08:38] * Joins: gitbot (~gitbot@public.cloak)
  12. # [08:38] -gitbot:#testing- [web-platform-tests] zqzhang closed pull request #426: Submissions/microsoft resource timing test (master...submissions/microsoft-resource-timing-test) https://github.com/w3c/web-platform-tests/pull/426
  13. # [08:38] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  14. # [08:48] * Joins: zcorpan (~zcorpan@public.cloak)
  15. # [08:49] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  16. # [09:54] * Joins: zcorpan (~zcorpan@public.cloak)
  17. # [10:26] * Joins: zcorpan_ (~zcorpan@public.cloak)
  18. # [10:26] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  19. # [11:03] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  20. # [11:46] * Joins: zcorpan (~zcorpan@public.cloak)
  21. # [11:46] * Quits: zcorpan_ (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  22. # [12:13] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  23. # [12:24] * Joins: zcorpan (~zcorpan@public.cloak)
  24. # [13:50] <jgraham> These battery-status tests look like they should probably be marked as manual
  25. # [13:50] <jgraham> Anyone know if dom is around?
  26. # [13:57] <Ms2ger> Yeah, they should
  27. # [14:53] * Joins: plh (plehegar@public.cloak)
  28. # [14:53] * Joins: abarsto (~abarsto@public.cloak)
  29. # [14:53] * abarsto is now known as ArtB
  30. # [15:07] * Joins: gitbot (~gitbot@public.cloak)
  31. # [15:07] -gitbot:#testing- [web-platform-tests] jgraham created jgraham/testharness_lint (+1 new commit): https://github.com/w3c/web-platform-tests/commit/e1cdaed26a39
  32. # [15:07] -gitbot:#testing- web-platform-tests/jgraham/testharness_lint e1cdaed James Graham: Add lint for common testharness.js mistakes and clean up tests that make those mistakes.
  33. # [15:07] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  34. # [15:07] * Joins: gitbot (~gitbot@public.cloak)
  35. # [15:07] -gitbot:#testing- [web-platform-tests] jgraham opened pull request #1049: Add lint for common testharness.js mistakes and clean up tests that make those mistakes. (master...jgraham/testharness_lint) https://github.com/w3c/web-platform-tests/pull/1049
  36. # [15:07] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  37. # [15:08] <jgraham> https://critic.hoppipolla.co.uk/r/1776 r?
  38. # [15:08] <jgraham> Fixes a bunch of broken tests
  39. # [15:13] * Joins: shepazu (schepers@public.cloak)
  40. # [15:16] <plh> jgraham, done
  41. # [15:18] <jgraham> plh: Thanks. BTW your "RT MS test" commit instroduced a bunch of whitespace errors
  42. # [15:18] <jgraham> Which I have also fixed now
  43. # [15:19] <plh> oh, I've been working on further updates for those as well
  44. # [15:19] * Joins: gitbot (~gitbot@public.cloak)
  45. # [15:19] -gitbot:#testing- [web-platform-tests] jgraham pushed 1 new commit to master: https://github.com/w3c/web-platform-tests/commit/a3d9d8ef2bd878cb710a2f845258be4a40da2cc1
  46. # [15:19] -gitbot:#testing- web-platform-tests/master a3d9d8e James Graham: Add lint for common testharness.js mistakes and clean up tests that make those mistakes.
  47. # [15:19] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  48. # [15:20] <plh> I have a few PR that needs my attention
  49. # [15:20] <jgraham> I just pushed the change to replace the \r\n with \n in those files
  50. # [15:20] <plh> thank you
  51. # [15:20] * Joins: gitbot (~gitbot@public.cloak)
  52. # [15:20] -gitbot:#testing- [web-platform-tests] jgraham closed pull request #1049: Add lint for common testharness.js mistakes and clean up tests that make those mistakes. (master...jgraham/testharness_lint) https://github.com/w3c/web-platform-tests/pull/1049
  53. # [15:20] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  54. # [15:39] <MikeSmith> r? https://github.com/w3c/web-platform-tests/pull/1047
  55. # [15:41] <jgraham> MikeSmith: Looks fine, but why?
  56. # [15:42] <jgraham> There isn't a way that I'm not thinking of to get the underlying property on a window object if it's been shadowed by a global variable, is there?
  57. # [15:45] * Joins: gitbot (~gitbot@public.cloak)
  58. # [15:45] -gitbot:#testing- [web-platform-tests] chrislo pushed 2 new commits to master: https://github.com/w3c/web-platform-tests/compare/a3d9d8ef2bd8...5d0a3e50a307
  59. # [15:45] -gitbot:#testing- web-platform-tests/master 235968b Andy Harman: WebAudio: Fix for WaveShaper "huge curve" test...
  60. # [15:45] -gitbot:#testing- web-platform-tests/master 5d0a3e5 Chris Lowis: Merge pull request #1048 from pendragon-andyh/master...
  61. # [15:45] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  62. # [15:45] <MikeSmith> jgraham: the why is because Hixie opened an issue for it, and because Blink and WebKit fail that test
  63. # [15:47] <MikeSmith> jgraham: https://www.w3.org/Bugs/Public/show_bug.cgi?id=25460#c14 from foolip: "Instead of setting the IDL attribute when the attributes have been set by the parser... it does it when its children finish parsing"
  64. # [15:48] <jgraham> :-o
  65. # [15:48] <jgraham> OK
  66. # [15:48] * Joins: gitbot (~gitbot@public.cloak)
  67. # [15:48] -gitbot:#testing- [web-platform-tests] jgraham pushed 1 new commit to master: https://github.com/w3c/web-platform-tests/commit/0d36c9b76aad0066fb0cfef837c282aa2a7866a8
  68. # [15:48] -gitbot:#testing- web-platform-tests/master 0d36c9b jgraham: Merge pull request #1047 from w3c/submission/sideshowbarker/input-checked...
  69. # [15:48] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  70. # [15:48] * Joins: gitbot (~gitbot@public.cloak)
  71. # [15:48] -gitbot:#testing- [web-platform-tests] jgraham closed pull request #1047: Test that input@checked is immediately reflected. (master...submission/sideshowbarker/input-checked) https://github.com/w3c/web-platform-tests/pull/1047
  72. # [15:48] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  73. # [15:49] <MikeSmith> jgraham: thanks~
  74. # [15:49] * Joins: gitbot (~gitbot@public.cloak)
  75. # [15:49] -gitbot:#testing- [web-platform-tests] sideshowbarker deleted submission/sideshowbarker/input-checked at 5f6fd2c: https://github.com/w3c/web-platform-tests/commit/5f6fd2c
  76. # [15:49] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  77. # [15:50] <zcorpan> MikeSmith: how was the flight?
  78. # [15:51] * jgraham wonders where MikeSmith was flying
  79. # [15:51] <MikeSmith> zcorpan: had no wifi but I managed to get a bit done on srcset
  80. # [15:51] <MikeSmith> flew from Tokyo to Boston
  81. # [15:51] <zcorpan> MikeSmith: ok cool
  82. # [15:52] <MikeSmith> plh and I are at the W3C AC meeting
  83. # [15:53] <MikeSmith> zcorpan: unfortunately I didn't realize until I was on the plane that I had no local copy of the CSS Syntax spec
  84. # [15:53] <zcorpan> MikeSmith: for sizes huh
  85. # [15:53] <MikeSmith> yeah
  86. # [15:54] <jgraham> Oh right, makes sense
  87. # [15:56] <MikeSmith> zcorpan: btw I think for srcset we need a conformance-checker test for multiple trailing commas -- "x,,,"
  88. # [15:57] <zcorpan> MikeSmith: ah yeah, i thought i had tested that but it looks like i had just a single comma
  89. # [16:03] <MikeSmith> zcorpan: btw what error message do you think should be emitted for the trailing-comma case?
  90. # [16:04] <MikeSmith> zcorpan: I'm inclined to have it just say "Found empty image candidate string."
  91. # [16:05] <MikeSmith> zcorpan: at least I don't think "URLs in image candidate strings can't end with commas." or whatever would be the right message from a user perspective
  92. # [16:06] <zcorpan> MikeSmith: yeah agree
  93. # [16:06] <MikeSmith> ok
  94. # [16:07] * Quits: shepazu (schepers@public.cloak) ("is sleepy")
  95. # [16:08] <zcorpan> MikeSmith: https://critic.hoppipolla.co.uk/b10678a7?review=1739
  96. # [16:09] * Quits: ArtB (~abarsto@public.cloak) ("Leaving.")
  97. # [16:26] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  98. # [16:38] * Joins: gitbot (~gitbot@public.cloak)
  99. # [16:38] -gitbot:#testing- [web-platform-tests] jgraham created jgraham/parent_rename (+1 new commit): https://github.com/w3c/web-platform-tests/commit/a466ea47bac5
  100. # [16:38] -gitbot:#testing- web-platform-tests/jgraham/parent_rename a466ea4 James Graham: Rename parent->parentNode to prevent clash with testharness.js
  101. # [16:38] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  102. # [16:39] * Joins: abarsto (~abarsto@public.cloak)
  103. # [16:39] * abarsto is now known as ArtB
  104. # [16:41] * Joins: gitbot (~gitbot@public.cloak)
  105. # [16:41] -gitbot:#testing- [web-platform-tests] jgraham opened pull request #1050: Rename parent->parentNode to prevent clash with testharness.js (master...jgraham/parent_rename) https://github.com/w3c/web-platform-tests/pull/1050
  106. # [16:41] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  107. # [16:41] <jgraham> https://critic.hoppipolla.co.uk/r/1777 if anyone is bored for 20 seconds
  108. # [16:43] <Ms2ger> Oh, my test
  109. # [16:43] <Ms2ger> jgraham, what's the clash?
  110. # [16:43] * Quits: plh (plehegar@public.cloak) (Ping timeout: 180 seconds)
  111. # [16:46] <jgraham> w.parent
  112. # [16:47] <jgraham> s/w/window/
  113. # [16:48] * Joins: gitbot (~gitbot@public.cloak)
  114. # [16:48] -gitbot:#testing- [web-platform-tests] jgraham pushed 1 new commit to jgraham/parent_rename: https://github.com/w3c/web-platform-tests/commit/35cde990c1230d6a24774521c3e09b3f7ffedfa0
  115. # [16:48] -gitbot:#testing- web-platform-tests/jgraham/parent_rename 35cde99 James Graham: fixup! Rename parent->parentNode to prevent clash with testharness.js
  116. # [16:48] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  117. # [16:49] <Ms2ger> jgraham, did your first commit fix it? :)
  118. # [16:50] <jgraham> Ms2ger: I thought so! But maybe I didn't actually test :)
  119. # [16:50] * Joins: plh (plehegar@public.cloak)
  120. # [16:50] * Joins: gitbot (~gitbot@public.cloak)
  121. # [16:50] -gitbot:#testing- [web-platform-tests] jgraham closed pull request #1050: Rename parent->parentNode to prevent clash with testharness.js (master...jgraham/parent_rename) https://github.com/w3c/web-platform-tests/pull/1050
  122. # [16:50] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  123. # [16:51] <Ms2ger> I guess maybe parent now was falsy, so it thought it reached top rather than thinking a node was a window
  124. # [16:51] * Joins: gitbot (~gitbot@public.cloak)
  125. # [16:51] -gitbot:#testing- [web-platform-tests] Ms2ger deleted jgraham/parent_rename at 35cde99: https://github.com/w3c/web-platform-tests/commit/35cde99
  126. # [16:51] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  127. # [16:59] <ArtB> These are good points about coordination and review. Perhaps all of the TransReq stuff should be moved from Member only chairs list to some Public list.
  128. # [17:00] <jgraham> ArtB: Wrong channel?
  129. # [17:00] <ArtB> oops; sorry jgraham, All!
  130. # [17:01] <Ms2ger> ArtB, was that MO? In that case W3C'll have to sue you ;)
  131. # [17:06] <MikeSmith> Ms2ger: under control. ArtB has been escorted out of the room by armed security
  132. # [17:09] <jgraham> I guess we should phone up the Yew York Times and tell him to prep his obituary
  133. # [17:09] <jgraham> *them
  134. # [17:09] <Ms2ger> Yew York?
  135. # [17:09] <jgraham> Oh ffs
  136. # [17:10] <jgraham> It's like the city
  137. # [17:10] <jgraham> But with a tree
  138. # [17:10] <Ms2ger> https://etherpad.mozilla.org/MeHiumCufk
  139. # [17:10] <Ms2ger> Do we need that still?
  140. # [17:10] <jgraham> No
  141. # [17:11] * ArtB damn those handcuffs hurt ...
  142. # [17:18] * Joins: lmclister (~lmclister@public.cloak)
  143. # [17:18] * Joins: shepazu (schepers@public.cloak)
  144. # [17:29] <MikeSmith> I found this pretty useful: https://github.com/tiimgreen/github-cheat-sheet#checking-out-pull-requests
  145. # [18:06] * Quits: ArtB (~abarsto@public.cloak) ("Leaving.")
  146. # [18:24] <MikeSmith> so btw I noticed it's a bad idea for somebody to change the file format of a file (that is, from dos to unix) while the file is being reviewed in critic
  147. # [18:25] <MikeSmith> because it causes any comments that are tied to a line in the file to be marked as addressed
  148. # [18:27] <jgraham> MikeSmith: Well you would have to reopen those comments
  149. # [18:27] <jgraham> But yeah
  150. # [18:28] <MikeSmith> jgraham: yeah I had to do that for a PR the other day (reopen the comments). Thankfully it was just for one file that had maybe 10 comments. I wouldn't want to have to do it for a bigger review
  151. # [18:29] <jgraham> Yeah, it's a tradeoff. The other workflow would require you to manually resolve all comments
  152. # [18:32] <jgraham> odinho: Did I already ask you if you have any theories about why /cors/redirect-origin.htm would randomly fail on mac?
  153. # [18:36] * Quits: shepazu (schepers@public.cloak) ("is sleepy")
  154. # [18:36] * Quits: plh (plehegar@public.cloak) ("Leaving")
  155. # [19:23] * Joins: rhauck (~Adium@public.cloak)
  156. # [19:34] * Joins: rhauck1 (~Adium@public.cloak)
  157. # [19:35] * Quits: rhauck (~Adium@public.cloak) (Client closed connection)
  158. # [20:03] * Joins: shepazu (schepers@public.cloak)
  159. # [20:07] * Joins: abarsto (~abarsto@public.cloak)
  160. # [20:07] * abarsto is now known as ArtB
  161. # [20:09] <MikeSmith> jgraham: so looking at https://travis-ci.org/w3c/web-platform-tests/builds/27112090 I'm wondering why it's complaining about those files in the resource-timing dir. Because that PR doesn't make any changes to files in that dir, afaict
  162. # [20:10] <MikeSmith> jgraham: and to be clear I wasn't faulting critic. Any other code-review system would have the same issue, I think
  163. # [20:23] * Joins: plh (plehegar@public.cloak)
  164. # [20:32] <jgraham> MikeSmith: Blame plh
  165. # [20:32] <jgraham> MikeSmith: Master was broken at that point
  166. # [20:32] <jgraham> (I guess I should also have pulled before testing the lint changes)
  167. # [20:33] <jgraham> (so also blame me)
  168. # [20:35] <MikeSmith> jgraham: ok
  169. # [20:36] <MikeSmith> I see there actually is no resource-timing dir
  170. # [20:37] <ArtB> What specific things need to be done to "take the W3C document license more seriously"?
  171. # [20:37] <Ms2ger> ArtB, wrong again
  172. # [20:37] <ArtB> darn; so sorry Ms2ger!
  173. # [20:38] <Ms2ger> ArtB, and I'll suggest making it only as strict as the licenses W3C uses to fork specs ;)
  174. # [20:38] * MikeSmith calls the security guards
  175. # [20:42] * Parts: ArtB (~abarsto@public.cloak) (ArtB)
  176. # [21:04] * Joins: shepazutu (schepers@public.cloak)
  177. # [21:08] * Joins: zcorpan (~zcorpan@public.cloak)
  178. # [21:10] * Quits: shepazu (schepers@public.cloak) (Ping timeout: 180 seconds)
  179. # [21:10] * shepazutu is now known as shepazu
  180. # [21:57] * Quits: rhauck1 (~Adium@public.cloak) ("Leaving.")
  181. # [22:08] * Quits: Ms2ger (~Ms2ger@public.cloak) ("nn")
  182. # [22:11] * Quits: plh (plehegar@public.cloak) (Ping timeout: 180 seconds)
  183. # [22:21] * Joins: plh (plehegar@public.cloak)
  184. # [22:42] * Joins: rhauck (~Adium@public.cloak)
  185. # [23:02] * Joins: rhauck1 (~Adium@public.cloak)
  186. # [23:02] * Quits: rhauck (~Adium@public.cloak) (Client closed connection)
  187. # [23:35] * heycam|away is now known as heycam
  188. # [23:47] * Quits: plh (plehegar@public.cloak) ("Leaving")
  189. # [23:49] * Quits: shepazu (schepers@public.cloak) ("is sleepy")
  190. # Session Close: Tue Jun 10 00:00:00 2014

The end :)