Options:
- # Session Start: Wed Jul 16 00:00:00 2014
- # Session Ident: #testing
- # [00:34] * Quits: plh (plehegar@public.cloak) ("Leaving")
- # [02:07] * Quits: darobin (rberjon@public.cloak) (Client closed connection)
- # [02:32] * Joins: mdas (~mdas@public.cloak)
- # [02:56] * Quits: lmclister (~lmclister@public.cloak) ("")
- # [03:13] * heycam is now known as heycam|away
- # [04:12] * Quits: mdas (~mdas@public.cloak) (Ping timeout: 180 seconds)
- # [04:28] * Joins: MK (kawamori@public.cloak)
- # [04:32] * Joins: mdas (~mdas@public.cloak)
- # [04:44] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
- # [04:48] * Joins: mdas_ (~mdas@public.cloak)
- # [05:03] * Joins: lmclister (~lmclister@public.cloak)
- # [05:08] * Joins: darobin (rberjon@public.cloak)
- # [05:08] * Joins: ptressel (~chatzilla@public.cloak)
- # [05:13] * Joins: plh (plehegar@public.cloak)
- # [05:15] * Quits: darobin (rberjon@public.cloak) (Ping timeout: 180 seconds)
- # [05:45] * Quits: plh (plehegar@public.cloak) (Client closed connection)
- # [06:02] * Quits: mdas_ (~mdas@public.cloak) (Client closed connection)
- # [06:05] * Quits: lmclister (~lmclister@public.cloak) ("")
- # [06:10] * heycam|away is now known as heycam
- # [06:11] * Joins: mdas (~mdas@public.cloak)
- # [06:29] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
- # [06:37] * Joins: lmclister (~lmclister@public.cloak)
- # [07:00] * Joins: glenn_ (~gadams@public.cloak)
- # [07:04] * Quits: glenn (~gadams@public.cloak) (Ping timeout: 180 seconds)
- # [07:05] * Joins: glenn (~gadams@public.cloak)
- # [07:08] * Quits: glenn_ (~gadams@public.cloak) (Ping timeout: 180 seconds)
- # [07:14] * Quits: lmclister (~lmclister@public.cloak) ("")
- # [07:18] * Joins: glenn_ (~gadams@public.cloak)
- # [07:19] * Joins: glenn__ (~gadams@public.cloak)
- # [07:22] * Quits: glenn (~gadams@public.cloak) (Ping timeout: 180 seconds)
- # [07:25] * Quits: glenn_ (~gadams@public.cloak) (Ping timeout: 180 seconds)
- # [07:27] * Quits: MK (kawamori@public.cloak) (Ping timeout: 180 seconds)
- # [07:32] * Quits: ArtB (~abarsto@public.cloak) ("Leaving.")
- # [07:33] * Joins: glenn (~gadams@public.cloak)
- # [07:38] * Quits: glenn__ (~gadams@public.cloak) (Ping timeout: 180 seconds)
- # [07:56] * Joins: glenn_ (~gadams@public.cloak)
- # [08:01] * Quits: glenn (~gadams@public.cloak) (Ping timeout: 180 seconds)
- # [08:04] * Quits: glenn_ (~gadams@public.cloak) (Ping timeout: 180 seconds)
- # [08:05] * Joins: glenn (~gadams@public.cloak)
- # [09:36] * heycam is now known as heycam|away
- # [09:45] * Joins: darobin (rberjon@public.cloak)
- # [09:54] * Joins: MK (kawamori@public.cloak)
- # [10:03] * Quits: glenn (~gadams@public.cloak) (Client closed connection)
- # [10:11] * Joins: Ms2ger (~Ms2ger@public.cloak)
- # [10:33] <jgraham> Ms2ger: Got a moment to look at https://critic.hoppipolla.co.uk/r/2056 ? It's -7 +14 so not huge.
- # [10:33] <jgraham> s| |/|
- # [10:34] * Joins: glenn (~gadams@public.cloak)
- # [10:35] <Ms2ger> jgraham, is there nothing in subprocess that does what you're doing in get_git_func?
- # [10:36] * Joins: glenn_ (~gadams@public.cloak)
- # [10:36] * Quits: glenn (~gadams@public.cloak) (Client closed connection)
- # [10:39] <jgraham> Ms2ger: check_call is close, but it returns the status code
- # [10:40] <jgraham> Oh wait, check_output
- # [10:41] <ato> There's also a few unnecessary calls to get_repo_root.
- # [10:41] <jgraham> ato: Hmm?
- # [10:41] <ato> See issue.
- # [10:43] <jgraham> Yeah, it does get called there. It could memorize the result or something if that's a problem
- # [10:43] * Quits: glenn_ (~gadams@public.cloak) (Ping timeout: 180 seconds)
- # [10:43] <ato> That comment isn't an issue, but it calls get_repo_root twice in main and assigns the first to an unused variable.
- # [10:44] <ato> Or, a variable that could be sent to create_parser, sorry.
- # [10:57] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
- # [11:00] <jgraham> Yeah, that was the intention, of course.
- # [11:11] <ato> Why?
- # [11:11] <jgraham> Why what?
- # [11:12] <jgraham> Why was it the intention to send it to create_parser()?
- # [11:14] * Quits: MK (kawamori@public.cloak) (Ping timeout: 180 seconds)
- # [11:21] <ato> https://critic.hoppipolla.co.uk/showcomment?chain=6459
- # [11:21] <ato> Why first assign it to repo_root, then not pass it to create_parser?
- # [11:23] <Ms2ger> ato, "Yeah, [passing it to create_parser] to was the intention, of course."
- # [11:24] <ato> Sorry if I was being intentionally thick (-:
- # [11:24] * ato is multitasking folding napkins and code reviewing
- # [11:28] <jgraham> heh
- # [11:32] * Joins: MK (kawamori@public.cloak)
- # [11:37] * Joins: glenn (~gadams@public.cloak)
- # [11:44] * Quits: glenn (~gadams@public.cloak) (Ping timeout: 180 seconds)
- # [11:46] <AutomatedTester> i wish respec would tell you where the error was when it complains about a reference
- # [11:53] * Quits: MK (kawamori@public.cloak) (Ping timeout: 180 seconds)
- # [12:16] * Joins: abarsto (~abarsto@public.cloak)
- # [12:16] * abarsto is now known as ArtB
- # [12:24] * Joins: MK (kawamori@public.cloak)
- # [13:37] <darobin> AutomatedTester: if you can think of an easy way to do that that is usable by humans I'm all ears
- # [13:37] <darobin> by which I mean: it's reasonably easy to generate a selector/xpath to a given context, but that rarely helps that much
- # [13:37] <darobin> AutomatedTester: note though, if the reference doesn't exist normally just grepping for its name should be enough, no?
- # [13:39] * Joins: glenn (~gadams@public.cloak)
- # [13:39] * Joins: dom (dom@public.cloak)
- # [13:46] * Quits: glenn (~gadams@public.cloak) (Ping timeout: 180 seconds)
- # [14:00] * Joins: plh (plehegar@public.cloak)
- # [14:07] <MikeSmith> any opinions on https://github.com/w3c/web-platform-tests/pull/285#issuecomment-47893559 ?
- # [14:08] <MikeSmith> specifically, is that change worth merging after further review?
- # [14:20] <AutomatedTester> darobin: in this case I had the wrong casing
- # [14:20] <AutomatedTester> so find wasn't working
- # [14:21] <AutomatedTester> since it was easily overlooked
- # [14:21] <darobin> AutomatedTester: well, if you have suggestions to improve error reporting I'm all ears
- # [14:22] <darobin> the DOM isn't great at giving line numbers
- # [14:22] <AutomatedTester> I will add it to my todo list
- # [14:22] <AutomatedTester> there is code, at least in Firefox that create unique selectors to elements
- # [14:23] <AutomatedTester> I will see what I can borrow from that
- # [14:39] * Joins: glenn (~gadams@public.cloak)
- # [14:45] * Joins: dom_ (dom@public.cloak)
- # [14:47] * Quits: glenn (~gadams@public.cloak) (Ping timeout: 180 seconds)
- # [14:47] * Quits: dom (dom@public.cloak) (Ping timeout: 180 seconds)
- # [14:51] <MikeSmith> AutomatedTester wilhelm TPAC schedule has been updated to reflect the date change for the Browser Testing WG f2f http://www.w3.org/2014/11/TPAC/#Thursday/Friday%20Groups but I'm still waiting for the registration form to be updated
- # [14:56] <wilhelm> MikeSmith: Woho! Thanks.
- # [14:59] <AutomatedTester> MikeSmith: \o/
- # [15:21] * Joins: gitbot (~gitbot@public.cloak)
- # [15:21] -gitbot:#testing- [web-platform-tests] plehegar opened pull request #1110: Added template and picture elements. Added DataCue. Updated other ... (master...plh/html-idl-updates) https://github.com/w3c/web-platform-tests/pull/1110
- # [15:21] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [15:23] * Quits: plh (plehegar@public.cloak) ("Leaving")
- # [15:36] * dom_ is now known as dom
- # [15:40] * Joins: glenn (~gadams@public.cloak)
- # [15:47] * Quits: glenn (~gadams@public.cloak) (Ping timeout: 180 seconds)
- # [15:49] * Joins: abarsto (~abarsto@public.cloak)
- # [15:49] * Quits: ArtB (~abarsto@public.cloak) (Client closed connection)
- # [15:49] * abarsto is now known as ArtB
- # [15:51] * Joins: gitbot (~gitbot@public.cloak)
- # [15:51] -gitbot:#testing- [web-platform-tests] jgraham pushed 1 new commit to master: https://github.com/w3c/web-platform-tests/commit/95d351e59ad62441769022e198bc692b9ee5ae9d
- # [15:51] -gitbot:#testing- web-platform-tests/master 95d351e jgraham: Merge pull request #1109 from w3c/jgraham/manifest_no_git...
- # [15:51] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [15:54] * Joins: mdas (~mdas@public.cloak)
- # [15:55] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
- # [15:55] * Joins: mdas (~mdas@public.cloak)
- # [16:37] * Joins: glenn (~gadams@public.cloak)
- # [16:41] <AutomatedTester> wilhelm: can I close bug 24793 as a duplicate of bug 26275 ?
- # [16:42] <wilhelm> AutomatedTester: Yes.
- # [16:43] <AutomatedTester> thanks!
- # [16:43] <wilhelm> 26275 is better. (c:
- # [16:43] <AutomatedTester> yea
- # [16:43] <AutomatedTester> we only have 66 open bugs... that means we can go to LC right?
- # [16:44] <wilhelm> Just delete all the bugs.
- # [16:44] <wilhelm> THen we'll be fine.
- # [16:44] <wilhelm> NO OPEN ISSUES LALALALA
- # [16:44] * Ms2ger reopens them all
- # [16:46] <AutomatedTester> I feel there was a w3c meme around this already
- # [16:47] <Ms2ger> Well, "NO OPEN ISSUES LALALALA" has a long tradition at W3C
- # [16:59] <wilhelm> Yes, we'd be in line with the vererable Process.
- # [17:01] <Ms2ger> Or "We'll fix it in the next version", and then shut down the WG
- # [17:04] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
- # [17:12] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
- # [17:13] <wilhelm> LALALALA
- # [17:32] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
- # [17:39] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
- # [17:43] * Joins: lmclister (~lmclister@public.cloak)
- # [18:02] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
- # [18:02] * Joins: mdas (~mdas@public.cloak)
- # [18:02] * Quits: dom (dom@public.cloak) ("")
- # [18:09] * Quits: mdas (~mdas@public.cloak) (Ping timeout: 180 seconds)
- # [18:16] * Quits: darobin (rberjon@public.cloak) (Client closed connection)
- # [18:31] * Joins: mdas (~mdas@public.cloak)
- # [18:32] * Quits: MK (kawamori@public.cloak) (Ping timeout: 180 seconds)
- # [20:20] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Ping timeout: 180 seconds)
- # [20:23] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
- # [20:49] * Quits: ptressel (~chatzilla@public.cloak) ("zzz")
- # [21:24] * Joins: abarsto (~abarsto@public.cloak)
- # [21:24] * Quits: ArtB (~abarsto@public.cloak) (Client closed connection)
- # [21:24] * abarsto is now known as ArtB
- # [21:35] * Quits: Ms2ger (~Ms2ger@public.cloak) (Ping timeout: 180 seconds)
- # [21:42] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
- # [21:46] * Joins: mdas (~mdas@public.cloak)
- # [21:47] * Joins: Ms2ger (~Ms2ger@public.cloak)
- # [22:12] * Joins: gitbot (~gitbot@public.cloak)
- # [22:12] -gitbot:#testing- [web-platform-tests] plehegar pushed 4 new commits to master: https://github.com/w3c/web-platform-tests/compare/95d351e59ad6...fbc6d6683fe7
- # [22:12] -gitbot:#testing- web-platform-tests/master 81e73b0 plehegar: Added template and picture elements. Added DataCue. Updated other interfaces
- # [22:12] -gitbot:#testing- web-platform-tests/master 51ade06 plehegar: s/ /\t
- # [22:12] -gitbot:#testing- web-platform-tests/master f3bf1f4 plehegar: s/ $//
- # [22:12] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [22:17] * Quits: Ms2ger (~Ms2ger@public.cloak) ("nn")
- # [22:27] * timeless___ is now known as timeless
- # [22:32] * Quits: glenn (~gadams@public.cloak) (Ping timeout: 180 seconds)
- # [22:58] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
- # [23:12] * Joins: plh (plehegar@public.cloak)
- # [23:21] * Joins: glenn (~gadams@public.cloak)
- # [23:36] * heycam|away is now known as heycam
- # [23:43] * Joins: glenn_ (~gadams@public.cloak)
- # [23:47] * Quits: glenn (~gadams@public.cloak) (Ping timeout: 180 seconds)
- # Session Close: Thu Jul 17 00:00:00 2014
The end :)