Options:
- # Session Start: Thu Jul 31 00:00:01 2014
- # Session Ident: #testing
- # [00:23] * Quits: Lachy (~Lachy@public.cloak) ("My MacBook Pro has gone to sleep. ZZZzzz…")
- # [00:25] * Joins: glenn_ (~gadams@public.cloak)
- # [00:30] * Joins: Lachy (~Lachy@public.cloak)
- # [00:30] * Quits: glenn (~gadams@public.cloak) (Ping timeout: 180 seconds)
- # [00:32] * Quits: glenn_ (~gadams@public.cloak) (Ping timeout: 180 seconds)
- # [00:32] * scheib_____ is now known as scheib
- # [01:02] * Joins: lmcliste_ (~lmclister@public.cloak)
- # [01:02] * Quits: lmclister (~lmclister@public.cloak) (Client closed connection)
- # [01:35] * Quits: lmcliste_ (~lmclister@public.cloak) ("")
- # [02:07] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
- # [02:59] * Joins: glenn (~gadams@public.cloak)
- # [03:30] * Joins: mdas (~mdas@public.cloak)
- # [03:30] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
- # [03:31] * Joins: mdas (~mdas@public.cloak)
- # [03:36] * Joins: mdas_ (~mdas@public.cloak)
- # [03:36] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
- # [03:39] * Quits: mdas_ (~mdas@public.cloak) (Client closed connection)
- # [03:40] * Joins: mdas (~mdas@public.cloak)
- # [03:47] * Quits: mdas (~mdas@public.cloak) (Ping timeout: 180 seconds)
- # [04:00] * Joins: mdas (~mdas@public.cloak)
- # [04:01] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
- # [04:02] * Joins: mdas (~mdas@public.cloak)
- # [04:06] * Joins: mdas_ (~mdas@public.cloak)
- # [04:07] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
- # [04:08] * Quits: mdas_ (~mdas@public.cloak) (Client closed connection)
- # [04:08] * Joins: mdas (~mdas@public.cloak)
- # [04:13] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
- # [04:13] * Joins: mdas (~mdas@public.cloak)
- # [04:20] * Quits: mdas (~mdas@public.cloak) (Ping timeout: 180 seconds)
- # [04:26] * Joins: mdas (~mdas@public.cloak)
- # [04:28] * Joins: mdas_ (~mdas@public.cloak)
- # [04:28] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
- # [04:28] * Quits: mdas_ (~mdas@public.cloak) (Client closed connection)
- # [04:28] * Joins: mdas (~mdas@public.cloak)
- # [04:29] * heycam is now known as heycam|away
- # [04:30] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
- # [04:30] * Joins: mdas_ (~mdas@public.cloak)
- # [04:35] * Quits: mdas_ (~mdas@public.cloak) (Client closed connection)
- # [04:36] * Joins: mdas (~mdas@public.cloak)
- # [04:43] * Quits: mdas (~mdas@public.cloak) (Ping timeout: 180 seconds)
- # [05:04] * heycam|away is now known as heycam
- # [05:06] * Joins: mdas (~mdas@public.cloak)
- # [05:06] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
- # [05:06] * Joins: mdas (~mdas@public.cloak)
- # [05:13] * Quits: mdas (~mdas@public.cloak) (Ping timeout: 180 seconds)
- # [05:35] * Joins: ptressel (~chatzilla@public.cloak)
- # [05:36] * Joins: lmclister (~lmclister@public.cloak)
- # [05:46] * Disconnected
- # [05:47] * Attempting to rejoin channel #testing
- # [05:47] * Rejoined channel #testing
- # [05:47] * Topic is '"also, I hope no one actually reads this, but I have to admit that I've kind of gotten used to Critic" --darobin'
- # [05:47] * Set by plh on Mon Mar 31 21:50:34
- # [06:13] * Quits: ptressel (~chatzilla@public.cloak) ("back in an hour")
- # [06:23] * Joins: mdas (~mdas@public.cloak)
- # [06:24] * Quits: glenn (~gadams@public.cloak) (Client closed connection)
- # [06:24] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
- # [06:25] * Joins: glenn (~gadams@public.cloak)
- # [06:25] * Joins: mdas (~mdas@public.cloak)
- # [06:26] * Joins: mdas_ (~mdas@public.cloak)
- # [06:26] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
- # [06:28] * Quits: mdas_ (~mdas@public.cloak) (Client closed connection)
- # [06:32] * Quits: glenn (~gadams@public.cloak) (Ping timeout: 180 seconds)
- # [06:44] * Joins: glenn (~gadams@public.cloak)
- # [06:45] * Joins: mdas (~mdas@public.cloak)
- # [06:47] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
- # [06:47] * Joins: mdas (~mdas@public.cloak)
- # [06:54] * Joins: mdas_ (~mdas@public.cloak)
- # [06:55] * Quits: mdas (~mdas@public.cloak) (Ping timeout: 180 seconds)
- # [06:57] * Quits: mdas_ (~mdas@public.cloak) (Client closed connection)
- # [06:57] * Joins: mdas (~mdas@public.cloak)
- # [06:58] * Joins: mdas_ (~mdas@public.cloak)
- # [06:58] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
- # [07:07] * Quits: mdas_ (~mdas@public.cloak) (Client closed connection)
- # [07:08] * Joins: mdas (~mdas@public.cloak)
- # [07:09] * Joins: mdas_ (~mdas@public.cloak)
- # [07:09] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
- # [07:10] * Quits: mdas_ (~mdas@public.cloak) (Client closed connection)
- # [07:10] * Joins: mdas (~mdas@public.cloak)
- # [07:16] * heycam is now known as heycam|away
- # [07:17] * Quits: mdas (~mdas@public.cloak) (Ping timeout: 180 seconds)
- # [07:24] * heycam|away is now known as heycam
- # [07:35] * Joins: mdas (~mdas@public.cloak)
- # [07:45] * Quits: lmclister (~lmclister@public.cloak) ("")
- # [07:54] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
- # [07:54] * Joins: mdas (~mdas@public.cloak)
- # [08:01] * Quits: mdas (~mdas@public.cloak) (Ping timeout: 180 seconds)
- # [08:12] * Joins: gitbot (~gitbot@public.cloak)
- # [08:12] -gitbot:#testing- [web-platform-tests] zqzhang pushed 2 new commits to master: https://github.com/w3c/web-platform-tests/compare/ea11544ed414...7501e4228fbf
- # [08:12] -gitbot:#testing- web-platform-tests/master 051dbd2 Jorik Tangelder: fix undefined function check_starting_element...
- # [08:12] -gitbot:#testing- web-platform-tests/master 7501e42 Zhiqiang Zhang: Merge pull request #1117 from jtangelder/patch-1...
- # [08:12] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [09:06] * Joins: ptressel (~chatzilla@public.cloak)
- # [09:20] * Joins: Ms2ger (~Ms2ger@public.cloak)
- # [09:20] * Quits: glenn (~gadams@public.cloak) (Client closed connection)
- # [09:21] * Joins: glenn (~gadams@public.cloak)
- # [09:28] * Quits: glenn (~gadams@public.cloak) (Ping timeout: 180 seconds)
- # [10:08] * Quits: Lachy (~Lachy@public.cloak) ("My MacBook Pro has gone to sleep. ZZZzzz…")
- # [10:20] * heycam is now known as heycam|away
- # [10:49] * Joins: Lachy (~Lachy@public.cloak)
- # [10:50] * Joins: gitbot (~gitbot@public.cloak)
- # [10:50] -gitbot:#testing- [web-platform-tests] jmajnert closed pull request #1128: In current spec send() may be called after abort() (master...master) https://github.com/w3c/web-platform-tests/pull/1128
- # [10:50] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [11:48] * Joins: plh (plehegar@public.cloak)
- # [12:13] * Joins: gitbot (~gitbot@public.cloak)
- # [12:13] -gitbot:#testing- [web-platform-tests] Ms2ger opened pull request #1134: Move Microsoft's progress element test into place. (master...move-progress) https://github.com/w3c/web-platform-tests/pull/1134
- # [12:13] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [12:26] * Joins: gitbot (~gitbot@public.cloak)
- # [12:26] -gitbot:#testing- [web-platform-tests] foolip pushed 3 new commits to master: https://github.com/w3c/web-platform-tests/compare/7501e4228fbf...900872f3b2ac
- # [12:26] -gitbot:#testing- web-platform-tests/master 2be648d Ms2ger: Cleanup Document-adoptNode.html a bit.
- # [12:26] -gitbot:#testing- web-platform-tests/master 39bb75b Ms2ger: Test that children of adopted nodes are handled correctly.
- # [12:26] -gitbot:#testing- web-platform-tests/master 900872f Philip Jägenstedt: Merge pull request #1129 from Ms2ger/adopt...
- # [12:26] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [13:20] * Joins: gitbot (~gitbot@public.cloak)
- # [13:20] -gitbot:#testing- [web-platform-tests] foolip pushed 2 new commits to master: https://github.com/w3c/web-platform-tests/compare/900872f3b2ac...4668382d0ac9
- # [13:20] -gitbot:#testing- web-platform-tests/master a7eb0dd Ms2ger: Move Microsoft's progress element test into place.
- # [13:20] -gitbot:#testing- web-platform-tests/master 4668382 Philip Jägenstedt: Merge pull request #1134 from Ms2ger/move-progress...
- # [13:20] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [13:23] * Quits: ptressel (~chatzilla@public.cloak) ("zzz")
- # [13:25] * Quits: Ms2ger (~Ms2ger@public.cloak) (Ping timeout: 180 seconds)
- # [13:38] * Joins: Ms2ger (~Ms2ger@public.cloak)
- # [14:02] * Quits: plh (plehegar@public.cloak) ("Leaving")
- # [14:35] * heycam|away is now known as heycam
- # [14:57] * Joins: gitbot (~gitbot@public.cloak)
- # [14:57] -gitbot:#testing- [web-platform-tests] Ms2ger pushed 2 new commits to master: https://github.com/w3c/web-platform-tests/compare/4668382d0ac9...a49178ce8a5c
- # [14:57] -gitbot:#testing- web-platform-tests/master 6a8dddd Ms2ger: Add some tests for img hspace/vspace.
- # [14:57] -gitbot:#testing- web-platform-tests/master a49178c Ms2ger: Merge pull request #1102 from Ms2ger/img-space...
- # [14:57] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [15:06] * Quits: Lachy (~Lachy@public.cloak) ("Textual IRC Client: www.textualapp.com")
- # [15:07] * Joins: mdas (~mdas@public.cloak)
- # [15:07] * Joins: Lachy (~Lachy@public.cloak)
- # [15:10] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
- # [15:11] * Joins: mdas (~mdas@public.cloak)
- # [15:13] * Joins: mdas_ (~mdas@public.cloak)
- # [15:13] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
- # [15:17] * Quits: mdas_ (~mdas@public.cloak) (Client closed connection)
- # [15:18] * Joins: mdas (~mdas@public.cloak)
- # [15:24] * Joins: mdas_ (~mdas@public.cloak)
- # [15:24] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
- # [15:31] * heycam is now known as heycam|away
- # [15:43] * Joins: glenn (~gadams@public.cloak)
- # [15:45] * Quits: Lachy (~Lachy@public.cloak) ("My MacBook Pro has gone to sleep. ZZZzzz…")
- # [15:54] * Joins: Lachy (~Lachy@public.cloak)
- # [17:08] * Quits: Ms2ger (~Ms2ger@public.cloak) (Ping timeout: 180 seconds)
- # [17:21] * Joins: Ms2ger (~Ms2ger@public.cloak)
- # [17:22] * Joins: gitbot (~gitbot@public.cloak)
- # [17:22] -gitbot:#testing- [web-platform-tests] Ms2ger opened pull request #1135: Expand the test for document.embeds/plugins. (master...embeds-plugins) https://github.com/w3c/web-platform-tests/pull/1135
- # [17:22] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
- # [17:39] * Joins: lmclister (~lmclister@public.cloak)
- # [17:55] * Joins: kawai (~kawai@public.cloak)
- # [17:57] * Quits: kawai (~kawai@public.cloak) (Client closed connection)
- # [18:01] * Joins: lmcliste_ (~lmclister@public.cloak)
- # [18:01] * Quits: lmclister (~lmclister@public.cloak) (Client closed connection)
- # [18:02] * Joins: lmclister (~lmclister@public.cloak)
- # [18:02] * Quits: lmcliste_ (~lmclister@public.cloak) (Client closed connection)
- # [18:06] * Quits: mdas_ (~mdas@public.cloak) (Client closed connection)
- # [18:07] * Joins: mdas (~mdas@public.cloak)
- # [18:12] * Quits: Lachy (~Lachy@public.cloak) ("My MacBook Pro has gone to sleep. ZZZzzz…")
- # [18:14] * Quits: mdas (~mdas@public.cloak) (Ping timeout: 180 seconds)
- # [18:35] * Joins: mdas (~mdas@public.cloak)
- # [18:48] * Joins: kawai (~kawai@public.cloak)
- # [18:49] * Quits: kawai (~kawai@public.cloak) (Client closed connection)
- # [18:59] * Joins: lmcliste_ (~lmclister@public.cloak)
- # [18:59] * Quits: lmclister (~lmclister@public.cloak) (Client closed connection)
- # [19:13] * Joins: lmclister (~lmclister@public.cloak)
- # [19:13] * Quits: lmcliste_ (~lmclister@public.cloak) (Client closed connection)
- # [19:25] * Joins: lmcliste_ (~lmclister@public.cloak)
- # [19:25] * Quits: lmclister (~lmclister@public.cloak) (Client closed connection)
- # [19:34] * Quits: lmcliste_ (~lmclister@public.cloak) (Client closed connection)
- # [19:34] * Joins: lmclister (~lmclister@public.cloak)
- # [19:39] * Quits: glenn (~gadams@public.cloak) (Client closed connection)
- # [19:40] * Joins: glenn (~gadams@public.cloak)
- # [19:47] * Quits: glenn (~gadams@public.cloak) (Ping timeout: 180 seconds)
- # [20:09] * Joins: bhill2 (~Adium@public.cloak)
- # [20:09] <bhill2> This is a cry for help
- # [20:10] <bhill2> Can anyone here complete the following review?
- # [20:10] <bhill2> https://critic.hoppipolla.co.uk/r/2137
- # [20:10] <bhill2> Six weeks ago I announced a Test the Web Forward event for CSP
- # [20:10] <bhill2> I allowed myself to be convinced to abandon _months_ of work on creating a turnkey environment for PHP development for my volunteers
- # [20:11] <bhill2> and use wptserve instead
- # [20:11] <bhill2> now I'm 3 days from the event, and after learning the new framework, rewriting all my infrastructure code, working through broken documentation and improving the tools themselves
- # [20:11] <bhill2> I haven't been able to land even a single PR so the volunteers will have something to work with on Sunday
- # [20:11] <bhill2> and really, I'd like to give them a working day to set up their environment
- # [20:12] <bhill2> This PR has only 26 lines of Python. The rest is just static HTML and JS
- # [20:12] <bhill2> can anyone PLEASE merge it? I'm desperate here.
- # [20:18] * Quits: bhill2 (~Adium@public.cloak) ("Leaving.")
- # [20:22] * Quits: lmclister (~lmclister@public.cloak) ("")
- # [21:06] * Joins: glenn (~gadams@public.cloak)
- # [21:09] * Joins: mdas_ (~mdas@public.cloak)
- # [21:09] * Quits: mdas (~mdas@public.cloak) (Client closed connection)
- # [21:14] * Joins: bhill2 (~Adium@public.cloak)
- # [21:17] * Quits: bhill2 (~Adium@public.cloak) ("Leaving.")
- # [21:25] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
- # [21:51] * Quits: glenn (~gadams@public.cloak) (Client closed connection)
- # [21:51] * Joins: glenn (~gadams@public.cloak)
- # [22:14] * Joins: lmclister (~lmclister@public.cloak)
- # [22:16] * Joins: bhill2 (~Adium@public.cloak)
- # [22:38] * Quits: bhill2 (~Adium@public.cloak) ("Leaving.")
- # [22:41] <Ms2ger> Despair no more
- # [22:42] * Joins: bhill2 (~Adium@public.cloak)
- # [22:44] <jgraham> Ms2ger: You are doing the rest of the review?
- # [22:44] <Ms2ger> I finished it
- # [22:44] <jgraham> Oh
- # [22:44] <jgraham> YEs, I just got email
- # [22:46] <jgraham> Ms2ger: Thanks
- # [22:46] <Ms2ger> Np
- # [22:52] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
- # [22:57] * Joins: Lachy (~Lachy@public.cloak)
- # [23:03] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
- # [23:08] * Quits: Lachy (~Lachy@public.cloak) ("My MacBook Pro has gone to sleep. ZZZzzz…")
- # [23:09] <bhill2> Thanks.
- # [23:09] <bhill2> So, it's at 100%, but with new issues.
- # [23:09] <Ms2ger> Yep
- # [23:09] <bhill2> Should it get merged as-is, or do I need to address those issues and restart the review before merge?
- # [23:18] * Joins: Lachy (~Lachy@public.cloak)
- # [23:19] <bhill2> ??
- # [23:20] <ato> bhill2: You should fixup those issues pointed out in the review before it can be integrated, but you don't have to restart a new review.
- # [23:20] <ato> bhill2: When you make a new commit to your branch and push it, critic will automatically pick up the changes and resolve some of the issues for you.
- # [23:22] <bhill2> thanks
- # [23:49] <bhill2> sigh, addressing one of the comments about why a positive test case existed to test positive functionality required adding a new file,
- # [23:49] <bhill2> so now review is back to 85%
- # [23:49] <bhill2> :(
- # Session Close: Fri Aug 01 00:00:00 2014
The end :)