/irc-logs / w3c / #testing / 2014-12-29 / end

Options:

Previous day, Next day

  1. # Session Start: Mon Dec 29 00:00:00 2014
  2. # Session Ident: #testing
  3. # [00:04] * heycam|away is now known as heycam
  4. # [00:08] * Quits: Lachy (~Lachy@public.cloak) ("My MacBook Pro has gone to sleep. ZZZzzz…")
  5. # [01:21] * Joins: Lachy (~Lachy@public.cloak)
  6. # [03:26] * heycam is now known as heycam|away
  7. # [04:12] * heycam|away is now known as heycam
  8. # [07:21] * Joins: ptressel (~chatzilla@public.cloak)
  9. # [08:00] * Quits: ptressel (~chatzilla@public.cloak) (Client closed connection)
  10. # [08:25] * Joins: ptressel (~chatzilla@public.cloak)
  11. # [08:33] * heycam is now known as heycam|away
  12. # [09:22] * Quits: ptressel (~chatzilla@public.cloak) ("zzz")
  13. # [09:45] * Joins: Ms2ger (~Ms2ger@public.cloak)
  14. # [10:07] * Joins: gitbot (~gitbot@public.cloak)
  15. # [10:07] -gitbot:#testing- [web-platform-tests] Ms2ger closed pull request #1479: wrong expected namespace for XML elements (master...wrong-ns) https://github.com/w3c/web-platform-tests/pull/1479
  16. # [10:07] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  17. # [10:10] <MikeSmith> Ms2ger: I thought the spec says that if you use createElementNS for a non-HTML element and don't explicitly specify a namespace, then namespaceURI is set to null. And it stays that way.
  18. # [10:10] <Ms2ger> dom/common.js: xmlElement = xmlDoc.createElement("igiveuponcreativenames");
  19. # [10:10] * MikeSmith looks again
  20. # [10:16] <MikeSmith> Ms2ger: thanks
  21. # [10:17] <Ms2ger> Np
  22. # [10:17] <MikeSmith> when I reviewed it I guess I just read createElementNS there because that's what I was assuming was intended
  23. # [10:18] * MikeSmith removes his "I'm a good reviewer!" badge
  24. # [10:19] <Ms2ger> I tend to assume Aryeh knows his stuff :)
  25. # [10:19] <MikeSmith> yep
  26. # [10:20] <MikeSmith> in hindsight I thought the same when I was looking it
  27. # [10:20] <MikeSmith> I should have trusted my instinct
  28. # [10:21] <MikeSmith> anyway I now need to perform some kind of appropriate careless-reviewer penance
  29. # [10:21] * Ms2ger looks if he's got anything for MikeSmith to review
  30. # [10:22] <Ms2ger> Apparently not :)
  31. # [10:22] * MikeSmith puts on his "Dodged that bullet!" badge
  32. # [10:23] <Ms2ger> I'll find something, don't worry :)
  33. # [10:23] <Ms2ger> You could do https://critic.hoppipolla.co.uk/r/3591
  34. # [10:23] <Ms2ger> It already has resounding support:
  35. # [10:23] <Ms2ger> <jgraham> I guess it's OK. I really want assert_rejects, but that doesn't work if you have to pass in the test, which I think you do
  36. # [10:24] * MikeSmith looks, hopes it's for a spec he's already read
  37. # [10:26] <Ms2ger> Prooooooomiiiiiiiiiiiiiiiseeeeeeeeeeeeeees
  38. # [10:26] <MikeSmith> yeah that looks somewhat like a bullet to me
  39. # [10:28] <MikeSmith> my first review comment is that you should also write some tests that use this promise_rejects function
  40. # [10:28] <MikeSmith> or a complete set of unit tests for testharness.js
  41. # [10:29] <MikeSmith> your choice
  42. # [10:29] <MikeSmith> anyway I actually already looked at the PR but didn't figure I was the best reviewer to accept it
  43. # [10:31] <MikeSmith> but if jgraham already looked at it and didn't poo-poo it I can look more
  44. # [10:36] * Joins: gitbot (~gitbot@public.cloak)
  45. # [10:36] -gitbot:#testing- [testharness.js] sideshowbarker closed pull request #99: Implement a promise_rejects function to match assert_throws. (master...rejection) https://github.com/w3c/testharness.js/pull/99
  46. # [10:36] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  47. # [10:36] * Joins: gitbot (~gitbot@public.cloak)
  48. # [10:36] -gitbot:#testing- [testharness.js] sideshowbarker pushed 4 new commits to master: https://github.com/w3c/testharness.js/compare/142b7cd2fbd4...bdb36d2e548c
  49. # [10:36] -gitbot:#testing- testharness.js/master 322fd4e Ms2ger: Ensure Test.set_status is not called with a non-string message argument....
  50. # [10:36] -gitbot:#testing- testharness.js/master 91db5ba Ms2ger: Don't assume the exception is an object in assert_throws.
  51. # [10:36] -gitbot:#testing- testharness.js/master 83ab6e5 Ms2ger: Implement a promise_rejects function to match assert_throws.
  52. # [10:36] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  53. # [10:38] * Quits: Lachy (~Lachy@public.cloak) ("My MacBook Pro has gone to sleep. ZZZzzz…")
  54. # [10:41] <MikeSmith> I now I notice https://critic.hoppipolla.co.uk/r/3406 that nobody's reviewed yet and that also has no corresponding wpt PR with tests that use it, nor unit tests
  55. # [10:42] <MikeSmith> somebody looking at this operation from the outside might find it ironic that we don't write tests for our code
  56. # [10:43] <MikeSmith> shoemaker's children going to school barefoot
  57. # [10:43] <Ms2ger> https://critic.hoppipolla.co.uk/r/3406 is on my plate :)
  58. # [10:44] <Ms2ger> MikeSmith, there's apisample*, too
  59. # [10:44] <Ms2ger> But I don't disagree
  60. # [10:50] <Ms2ger> MikeSmith, I wonder if we could run tests in-browser on Travis
  61. # [10:51] <MikeSmith> Ms2ger: how would that work? I mean it's all headless, right?
  62. # [10:51] <MikeSmith> oh you mean with wptrunner?
  63. # [10:51] <Ms2ger> No, I was thinking for th.js unit tests
  64. # [10:52] <Ms2ger> Maybe the xvfb thing
  65. # [10:54] <Ms2ger> But then we still need to get results out somehow
  66. # [10:55] <Ms2ger> Maybe wptrunner isn't such a bad idea
  67. # [10:59] <jgraham> That seems plausible at least
  68. # [11:02] * Ms2ger might try something like that later
  69. # [11:25] * Joins: Lachy (~Lachy@public.cloak)
  70. # [11:54] * Ms2ger finds http://docs.travis-ci.com/user/gui-and-headless-browsers/
  71. # [12:02] <Ms2ger> jgraham, I don't suppose wptrunner works with an out-of-the-box Fx build?
  72. # [12:10] <MikeSmith> Ms2ger: it does if you also have a profiles directory to point it to
  73. # [12:29] * Joins: gitbot (~gitbot@public.cloak)
  74. # [12:29] -gitbot:#testing- [wptrunner] Ms2ger created pip (+1 new commit): https://github.com/w3c/wptrunner/commit/508066f9a012
  75. # [12:29] -gitbot:#testing- wptrunner/pip 508066f Ms2ger: Pass the -r argument to pip in the documentation.
  76. # [12:29] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  77. # [12:29] * Joins: gitbot (~gitbot@public.cloak)
  78. # [12:29] -gitbot:#testing- [wptrunner] Ms2ger opened pull request #62: Pass the -r argument to pip in the documentation. (master...pip) https://github.com/w3c/wptrunner/pull/62
  79. # [12:29] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  80. # [12:40] * Joins: gitbot (~gitbot@public.cloak)
  81. # [12:40] -gitbot:#testing- [wptrunner] sideshowbarker pushed 1 new commit to master: https://github.com/w3c/wptrunner/commit/7d8509e2596b0ce05296320071996c724af9eae9
  82. # [12:40] -gitbot:#testing- wptrunner/master 7d8509e Michael[tm] Smith: Merge pull request #62 from w3c/pip...
  83. # [12:40] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  84. # [12:40] * Joins: gitbot (~gitbot@public.cloak)
  85. # [12:40] -gitbot:#testing- [wptrunner] sideshowbarker deleted pip at 508066f: https://github.com/w3c/wptrunner/commit/508066f
  86. # [12:40] * Parts: gitbot (~gitbot@public.cloak) (gitbot)
  87. # [14:59] <jgraham> Ms2ger: Yeah, so you need certutil (when https lands) and some profile settings (although we could hardcode more of those)
  88. # [15:53] * Quits: Lachy (~Lachy@public.cloak) ("Textual IRC Client: www.textualapp.com")
  89. # [17:51] * Joins: plh (plehegar@public.cloak)
  90. # [18:54] * Quits: Ms2ger (~Ms2ger@public.cloak) ("nn")
  91. # [22:48] * Quits: plh (plehegar@public.cloak) ("Leaving")
  92. # [23:51] * heycam|away is now known as heycam
  93. # Session Close: Tue Dec 30 00:00:00 2014

Previous day, Next day

Think these logs are useful? Then please donate to show your gratitude (and keep them up, of course). Thanks! — Krijn