/irc-logs / w3c / #testing / 2015-06-02 / end

Options:

Previous day, Next day

  1. # Session Start: Tue Jun 02 00:00:00 2015
  2. # Session Ident: #testing
  3. # [00:54] * Joins: heycam|away (~cam@public.cloak)
  4. # [00:58] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  5. # [01:47] * Joins: bhill2 (~bhill2@public.cloak)
  6. # [02:17] * terri is now known as terri_offline
  7. # [03:01] * Quits: bhill2 (~bhill2@public.cloak) (Client closed connection)
  8. # [03:19] * Joins: kawai (~kawai@public.cloak)
  9. # [03:59] * Quits: ArtB (~ArtB@public.cloak) ("Leaving.")
  10. # [04:02] * Joins: bhill2 (~bhill2@public.cloak)
  11. # [04:09] * Quits: bhill2 (~bhill2@public.cloak) (Ping timeout: 180 seconds)
  12. # [04:28] * heycam|away is now known as heycam|away|away
  13. # [04:56] * Joins: bhill2 (~bhill2@public.cloak)
  14. # [05:05] * Quits: bhill2 (~bhill2@public.cloak) (Client closed connection)
  15. # [05:13] * Quits: kawai (~kawai@public.cloak) (Ping timeout: 180 seconds)
  16. # [05:17] * heycam|away|away is now known as heycam|away
  17. # [05:18] * heycam|away is now known as heycam
  18. # [05:35] * Joins: playjax (~chatzilla@public.cloak)
  19. # [06:06] * Joins: bhill2 (~bhill2@public.cloak)
  20. # [06:13] * Quits: bhill2 (~bhill2@public.cloak) (Ping timeout: 180 seconds)
  21. # [08:13] * Quits: playjax (~chatzilla@public.cloak) (Ping timeout: 180 seconds)
  22. # [08:44] * Joins: darobin (rberjon@public.cloak)
  23. # [08:46] * Quits: darobin (rberjon@public.cloak) (Client closed connection)
  24. # [08:53] * Joins: bhill2 (~bhill2@public.cloak)
  25. # [09:00] * Quits: bhill2 (~bhill2@public.cloak) (Ping timeout: 180 seconds)
  26. # [09:49] * Joins: darobin (rberjon@public.cloak)
  27. # [10:02] * Joins: dom (dom@public.cloak)
  28. # [10:23] * Joins: Ms2ger (~Ms2ger@public.cloak)
  29. # [10:41] * heycam is now known as heycam|away
  30. # [11:54] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  31. # [12:03] * Joins: ArtB (~ArtB@public.cloak)
  32. # [12:22] * Quits: darobin (rberjon@public.cloak) (Client closed connection)
  33. # [13:12] * Joins: darobin (rberjon@public.cloak)
  34. # [13:13] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  35. # [13:42] * Joins: kawai (~kawai@public.cloak)
  36. # [14:08] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  37. # [14:26] * Quits: kawai (~kawai@public.cloak) (Ping timeout: 180 seconds)
  38. # [14:42] * Joins: gitbot (~gitbot@public.cloak)
  39. # [14:42] -gitbot:#testing- [web-platform-tests] sideshowbarker created sideshowbarker/notifications (+3 new commits): https://github.com/w3c/web-platform-tests/compare/6c4a3a7d9129^...a8d5f0411b88
  40. # [14:42] -gitbot:#testing- web-platform-tests/sideshowbarker/notifications 6c4a3a7 Edward O'Connor: Update Notifications event tests. Add tests for the remaining events.
  41. # [14:43] -gitbot:#testing- web-platform-tests/sideshowbarker/notifications 08ad1cb Edward O'Connor: Add tests for the Notifications lang property.
  42. # [14:43] -gitbot:#testing- web-platform-tests/sideshowbarker/notifications a8d5f04 Michael[tm] Smith: fixup! Update Notifications event tests. Add tests for the remaining events.
  43. # [14:43] * Parts: gitbot (~gitbot@public.cloak)
  44. # [14:44] * Joins: gitbot (~gitbot@public.cloak)
  45. # [14:44] -gitbot:#testing- [web-platform-tests] sideshowbarker opened pull request #1864: Add missing notifications tests (master...sideshowbarker/notifications) https://github.com/w3c/web-platform-tests/pull/1864
  46. # [14:44] * Parts: gitbot (~gitbot@public.cloak)
  47. # [14:47] * Joins: gitbot (~gitbot@public.cloak)
  48. # [14:47] -gitbot:#testing- [web-platform-tests] sideshowbarker pushed 1 new commit to sideshowbarker/notifications: https://github.com/w3c/web-platform-tests/commit/5fe0446befcadbd01071cbf5e6df412a587581bc
  49. # [14:47] -gitbot:#testing- web-platform-tests/sideshowbarker/notifications 5fe0446 Michael[tm] Smith: fixup! Update Notifications event tests. Add tests for the remaining events.
  50. # [14:47] * Parts: gitbot (~gitbot@public.cloak)
  51. # [14:48] * Joins: plh (plehegar@public.cloak)
  52. # [14:52] * Joins: gitbot (~gitbot@public.cloak)
  53. # [14:52] -gitbot:#testing- [web-platform-tests] sideshowbarker closed pull request #1699: Add missing notifications tests. (master...master) https://github.com/w3c/web-platform-tests/pull/1699
  54. # [14:52] * Parts: gitbot (~gitbot@public.cloak)
  55. # [14:54] <MikeSmith> when I do the "fixup!" thing, does git later autosquash those commits when I do the final merge to master?
  56. # [14:55] <Ms2ger> No, just when you git rebase --autosquash
  57. # [14:55] <MikeSmith> ok, thanks
  58. # [15:01] <AutomatedTester> I didnt know about the autosquash command
  59. # [15:01] <AutomatedTester> I normall just rebase -i
  60. # [15:03] <darobin> I always thought "autosquash" was the name of the ultimate trick that a gang of superheroes would yell to get rid of the big boss monster every week
  61. # [15:03] <darobin> you know, that weapon you always wonder why they didn't just use it from the start
  62. # [15:11] <MikeSmith> I guess you can only use autosquash if you've previously committed with "--fixup"
  63. # [15:16] <Ms2ger> Yep
  64. # [15:21] * Joins: kawai (~kawai@public.cloak)
  65. # [15:22] <MikeSmith> about https://github.com/w3c/web-platform-tests/pull/1699#discussion_r28487088 is it true that test should use explicit_done?
  66. # [15:22] <MikeSmith> the docs say "implicitly true for single page tests"
  67. # [15:23] <jgraham> Which test?
  68. # [15:25] <MikeSmith> jgraham: https://github.com/w3c/web-platform-tests/blob/c5e598fdc160a3c2a59fb91b8d1eee372c392157/notifications/notification-lang.html
  69. # [15:25] <jgraham> MikeSmith: That isn't a single page test
  70. # [15:25] <MikeSmith> oh
  71. # [15:26] <MikeSmith> what's the definition of a single-page test?
  72. # [15:26] <MikeSmith> (I guess I should actually read the whole test)
  73. # [15:27] <jgraham> One that doesn't call [async_|promise_|]test() anywhere
  74. # [15:27] <MikeSmith> ah OK
  75. # [15:28] <jgraham> I don't know why that test puts the test_lang() stuff in the event callback
  76. # [15:28] <jgraham> If that was at the top level it wouldn't have to be a single-page test
  77. # [15:34] <MikeSmith> yeah I didn't write the test
  78. # [15:34] <MikeSmith> hober did
  79. # [15:35] <jgraham> MikeSmith: Right, I thought you were reviewing it, I was trying to be helpful :)
  80. # [15:35] <MikeSmith> yeah I'm just reviewing the review comments
  81. # [15:36] <MikeSmith> I would prefer to assign it back to hober
  82. # [15:36] <MikeSmith> I opened a new PR for it because he had accidentally included a big merge commit in his original PR
  83. # [15:36] <MikeSmith> anyway I realize now that test will just hang indefinitely if it doesn't have explicit_done set
  84. # [15:37] <MikeSmith> there's no way we can make it instead timeout in this case?
  85. # [15:38] <jgraham> Hmm?
  86. # [15:39] <jgraham> The only way to stop the test timing out is to hang the browser or set {explicit_timeout:true}
  87. # [15:40] <MikeSmith> it wasn't timing out for me
  88. # [15:40] <MikeSmith> unless maybe it was doing 20 seconds times 37 before timing out
  89. # [15:40] <jgraham> That is quite surprising
  90. # [15:40] <MikeSmith> maybe I just didn't wait long enough
  91. # [15:40] * MikeSmith tries again
  92. # [15:41] <jgraham> Should only be 10s
  93. # [15:41] <MikeSmith> yeah waited 30+ seconds and I still get no timeout notice
  94. # [15:42] <MikeSmith> in Firefox
  95. # [15:42] * MikeSmith tries in Chrome
  96. # [15:42] <jgraham> What's the PR number?
  97. # [15:42] <MikeSmith> 1699 I think
  98. # [15:42] <MikeSmith> yeah I'm getting the same thing in Chrome
  99. # [15:43] <MikeSmith> "Running, 1 complete, 37 remain"
  100. # [15:43] <MikeSmith> https://github.com/w3c/web-platform-tests/pull/1699 is the original PR
  101. # [15:43] <MikeSmith> https://github.com/w3c/web-platform-tests/pull/1864 is the new one I opened for it
  102. # [15:49] * Joins: gitbot (~gitbot@public.cloak)
  103. # [15:49] -gitbot:#testing- [web-platform-tests] sideshowbarker pushed 1 new commit to sideshowbarker/notifications: https://github.com/w3c/web-platform-tests/commit/c1d41c85f7464527683efb5c82fcb2fb037f27ab
  104. # [15:49] -gitbot:#testing- web-platform-tests/sideshowbarker/notifications c1d41c8 Michael[tm] Smith: fixup! Add tests for the Notifications lang property.
  105. # [15:49] * Parts: gitbot (~gitbot@public.cloak)
  106. # [15:50] <jgraham> MikeSmith: Curious. Could be a testharnes.js bug
  107. # [15:51] <jgraham> Anyway that's the right fix
  108. # [15:51] <MikeSmith> k
  109. # [15:55] * Joins: gitbot (~gitbot@public.cloak)
  110. # [15:55] -gitbot:#testing- [wptserve] jgraham pushed 1 new commit to master: https://github.com/w3c/wptserve/commit/67d7f70dca5e9e24f873f7ba79706bd994642b32
  111. # [15:55] -gitbot:#testing- wptserve/master 67d7f70 James Graham: Update version number for release
  112. # [15:55] * Parts: gitbot (~gitbot@public.cloak)
  113. # [15:59] <MikeSmith> this comment from Hallvord makes sense, right? https://critic.hoppipolla.co.uk/showcomment?chain=11761
  114. # [16:00] <MikeSmith> replace assert_equals(Object.prototype.toString.call(e), "[object Event]", "the type of event"); with assert_equals(e.type, "show")
  115. # [16:01] <jgraham> MikeSmith: That seems to be testing two entirely different things
  116. # [16:01] <jgraham> Both seem correct
  117. # [16:01] <jgraham> (I guess Hallvord's is more useful)
  118. # [16:02] <MikeSmith> yeah I don't know why we'd want to test the other thing
  119. # [16:02] <MikeSmith> should I have it test both?
  120. # [16:02] <jgraham> I don't think it's bad to
  121. # [16:02] <MikeSmith> k
  122. # [16:14] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  123. # [16:24] * Joins: gitbot (~gitbot@public.cloak)
  124. # [16:24] -gitbot:#testing- [web-platform-tests] sideshowbarker pushed 1 new commit to sideshowbarker/notifications: https://github.com/w3c/web-platform-tests/commit/361a7e5cba730da9d95637cb3b30de6b8d9ad83f
  125. # [16:24] -gitbot:#testing- web-platform-tests/sideshowbarker/notifications 361a7e5 Michael[tm] Smith: fixup! Update Notifications event tests. Add tests for the remaining events.
  126. # [16:24] * Parts: gitbot (~gitbot@public.cloak)
  127. # [16:30] <hallvord> jgraham: this is naturally a matter of taste, but IMHO it's better if a person reading the test understands the point of every statement
  128. # [16:30] <hallvord> if the test isn't about stringifying event objects, I'd take that out.. ;)
  129. # [16:31] * hallvord will try to write more explanatory review comments
  130. # [16:32] <jgraham> hallvord: Well given a particular event object, testing that it stringifies correctly is a reasonable (if mostly not that useful) thing to do
  131. # [16:34] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  132. # [16:44] * Quits: plh (plehegar@public.cloak) ("Leaving")
  133. # [16:53] <MikeSmith> I guess it's not really a test that's specific to this particular feature
  134. # [16:55] <MikeSmith> I mean, while it's maybe useful to have a test that checks to see if a browser stringifies some event objects, it seems like it would be sufficient to have enough that you can just say you've got tests for general event-object stringification
  135. # [16:56] <MikeSmith> because I'd think we can assume the engine is using the same code to stringify any particular event object, and not different code each time
  136. # [16:57] <MikeSmith> and we don't need every single test of some specific event to include a stringification test
  137. # [16:59] <MikeSmith> anyway I left those tests in there because I default to not removing tests unless they're plainly just bad tests or duplicate/redundant tests
  138. # [16:59] <MikeSmith> though I guess these could be considered redundant
  139. # [17:02] * Joins: scott_gonzalez (~scott_gonzalez@public.cloak)
  140. # [17:05] * Quits: scott_gonzalez (~scott_gonzalez@public.cloak) (scott_gonzalez)
  141. # [17:19] <Ms2ger> assert_class_string!
  142. # [17:21] <MikeSmith> heh
  143. # [17:21] <MikeSmith> good brainstorming
  144. # [17:22] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  145. # [17:34] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  146. # [18:05] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  147. # [18:17] * terri_offline is now known as terri
  148. # [18:23] * Joins: plh (plehegar@public.cloak)
  149. # [18:37] * Quits: darobin (rberjon@public.cloak) (Client closed connection)
  150. # [18:48] * Quits: dom (dom@public.cloak) ("")
  151. # [19:01] <ato> MikeSmith: You might be interested in this line: https://github.com/andreastt/dotfiles/blob/master/config/git/config#L24
  152. # [19:02] <ato> MikeSmith: And the next one, which basically allows you to do `git fixup -a` to mark the previous commit as the one your fixing up automatically.
  153. # [19:02] <ato> you’re*@
  154. # [19:02] <ato> s/@// because I can’t write.
  155. # [19:05] * Quits: plh (plehegar@public.cloak) ("Leaving")
  156. # [19:11] * Quits: kawai (~kawai@public.cloak) (Ping timeout: 180 seconds)
  157. # [19:39] * Joins: plh (plehegar@public.cloak)
  158. # [19:43] * Joins: bhill2 (~bhill2@public.cloak)
  159. # [20:03] * terri is now known as terri_offline
  160. # [20:06] * Joins: kawai (~kawai@public.cloak)
  161. # [20:13] * Quits: kawai (~kawai@public.cloak) (Ping timeout: 180 seconds)
  162. # [20:17] * terri_offline is now known as terri
  163. # [20:30] * Quits: plh (plehegar@public.cloak) ("Leaving")
  164. # [20:37] * Joins: plh (plehegar@public.cloak)
  165. # [20:41] * Quits: bhill2 (~bhill2@public.cloak) (Client closed connection)
  166. # [20:42] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  167. # [20:44] * Joins: kawai (~kawai@public.cloak)
  168. # [21:37] * Joins: darobin (rberjon@public.cloak)
  169. # [22:11] * Quits: kawai (~kawai@public.cloak) (Client closed connection)
  170. # [22:11] * Joins: kawai (~kawai@public.cloak)
  171. # [22:18] * Joins: gitbot (~gitbot@public.cloak)
  172. # [22:18] -gitbot:#testing- [wptrunner] jgraham pushed 1 new commit to jgraham/equal_chunker_2: https://github.com/w3c/wptrunner/commit/d0956277935070f717a424115ed36c97d56d5be6
  173. # [22:18] -gitbot:#testing- wptrunner/jgraham/equal_chunker_2 d095627 James Graham: fixup! fixup! Change implementation of EqualTimeChunker.
  174. # [22:18] * Parts: gitbot (~gitbot@public.cloak)
  175. # [22:30] * Quits: darobin (rberjon@public.cloak) (Client closed connection)
  176. # [22:48] * Quits: kawai (~kawai@public.cloak) (Ping timeout: 180 seconds)
  177. # [23:09] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  178. # [23:41] * Quits: Ms2ger (~Ms2ger@public.cloak) (Ping timeout: 180 seconds)
  179. # [23:47] * Quits: plh (plehegar@public.cloak) ("Leaving")
  180. # Session Close: Wed Jun 03 00:00:00 2015

Previous day, Next day

Think these logs are useful? Then please donate to show your gratitude (and keep them up, of course). Thanks! — Krijn