/irc-logs / w3c / #testing / 2015-07-07 / end

Options:

Previous day, Next day

  1. # Session Start: Tue Jul 07 00:00:00 2015
  2. # Session Ident: #testing
  3. # [00:02] * terri is now known as terri_offline
  4. # [00:02] * terri_offline is now known as terri
  5. # [00:27] * Joins: bhill2 (~bhill2@public.cloak)
  6. # [00:40] * heycam|away is now known as heycam
  7. # [00:45] * Quits: darobin (rberjon@public.cloak) (Client closed connection)
  8. # [01:22] * Joins: playjax (~chatzilla@public.cloak)
  9. # [02:33] * Joins: gitbot (~gitbot@public.cloak)
  10. # [02:33] -gitbot:#testing- [testharness.js] inexorabletash opened pull request #139: assert_object_equals: Check property ownership (master...inexorabletash/object-equals-own) https://github.com/w3c/testharness.js/pull/139
  11. # [02:33] * Parts: gitbot (~gitbot@public.cloak)
  12. # [03:08] * Quits: bhill2 (~bhill2@public.cloak) (Client closed connection)
  13. # [03:22] * Quits: playjax (~chatzilla@public.cloak) (Ping timeout: 180 seconds)
  14. # [03:43] * heycam is now known as heycam|away
  15. # [03:48] * terri is now known as terri_offline
  16. # [04:05] * Joins: gitbot (~gitbot@public.cloak)
  17. # [04:05] -gitbot:#testing- [web-platform-tests] zqzhang closed pull request #1971: Avoid timeouts in quota tests by putting bigger data chunks (master...inexorabletash/webstorage-quotaexceeded-timeouts) https://github.com/w3c/web-platform-tests/pull/1971
  18. # [04:05] * Parts: gitbot (~gitbot@public.cloak)
  19. # [04:59] * heycam|away is now known as heycam
  20. # [05:30] * terri_offline is now known as terri
  21. # [06:28] * terri is now known as terri_offline
  22. # [07:01] * heycam is now known as heycam|away
  23. # [07:31] * heycam|away is now known as heycam
  24. # [09:14] * Joins: Ms2ger (~Ms2ger@public.cloak)
  25. # [09:33] <MikeSmith> about https://critic.hoppipolla.co.uk/4abfeec5?review=5430 in what cases does get_script_url() fail?
  26. # [09:33] <MikeSmith> I mean such that get_script_url() || "\\btestharness.js" is needed
  27. # [09:34] <Ms2ger> Workers
  28. # [09:35] <Ms2ger> The question whether we should call get_script_url() at all
  29. # [09:35] <MikeSmith> ah OK
  30. # [09:35] <MikeSmith> ah yeah I didn't bother to look was the PR was about
  31. # [09:37] <MikeSmith> yeah since we're not going to be changing the name of the testharness.js script it would seem like we don't need to use get_script_url() to reference it anywhere
  32. # [09:45] * Joins: dom (dom@public.cloak)
  33. # [10:02] * Quits: dom (dom@public.cloak) (Client closed connection)
  34. # [10:03] * Joins: dom (dom@public.cloak)
  35. # [10:37] * heycam is now known as heycam|away
  36. # [10:38] <jgraham> The "problem" is if someone writes a file called "helper-testharness.js" then that will mysteriously get stripped from stack traces
  37. # [10:39] <jgraham> I agree it's a pretty weird thing to do, but I don't see why we would intentionally add an avoidable edge case
  38. # [10:39] <MikeSmith> ah yeah
  39. # [10:39] <Ms2ger> In that case, I guess r+
  40. # [10:40] <jgraham> Well r- for not using braces correctly :)
  41. # [10:50] <Ms2ger> I wonder what would happen if we made async_test.done() go through the event loop again before finishing for real
  42. # [10:50] <jgraham> That's a testable question, but I wonder why you wonder
  43. # [10:52] <Ms2ger> Not sure how I came up with it
  44. # [10:53] * Joins: darobin (rberjon@public.cloak)
  45. # [11:18] * Joins: todo (~todo@public.cloak)
  46. # [11:19] * todo slaps Yves around a bit with a large fishbot
  47. # [11:21] * todo slaps dom around a bit with a large fishbot
  48. # [11:21] * todo slaps AutomatedTester around a bit with a large fishbot
  49. # [11:29] * Quits: todo (~todo@public.cloak) (Ping timeout: 180 seconds)
  50. # [12:31] <AutomatedTester> o.O
  51. # [14:58] * Joins: plh (plehegar@public.cloak)
  52. # [15:11] * Quits: dom (dom@public.cloak) (Ping timeout: 180 seconds)
  53. # [15:22] * Joins: dom (dom@public.cloak)
  54. # [15:25] <gsnedders> Ms2ger: can you r/5480?
  55. # [15:25] <gsnedders> or jgraham, but he never reviews anything for me nowadays :(
  56. # [15:33] * Quits: dom (dom@public.cloak) (Ping timeout: 180 seconds)
  57. # [15:37] <MikeSmith> I wonder how our test coverage for Workers is at this point
  58. # [15:37] <MikeSmith> I mean just roughly
  59. # [15:37] <MikeSmith> like, there are lots of things we're not testing yet
  60. # [15:43] * Joins: dom (dom@public.cloak)
  61. # [16:03] <Ms2ger> MikeSmith, I've been trying to share tests with the main thread tests, but that's pretty limited still
  62. # [16:03] <MikeSmith> ok
  63. # [16:04] <Ms2ger> I need to implement my magic-run-everywhere idea
  64. # [16:47] <Ms2ger> jgraham, you okay with removing unused tests in https://critic.hoppipolla.co.uk/r/5480 ?
  65. # [17:00] <plh> those removal sound good to me
  66. # [17:40] * Quits: darobin (rberjon@public.cloak) (Client closed connection)
  67. # [17:52] * Joins: bhill2 (~bhill2@public.cloak)
  68. # [18:28] * Quits: bhill2 (~bhill2@public.cloak) (Client closed connection)
  69. # [18:33] * Joins: bhill2 (~bhill2@public.cloak)
  70. # [18:33] * Joins: gitbot (~gitbot@public.cloak)
  71. # [18:33] -gitbot:#testing- [web-platform-tests] Ms2ger opened pull request #1972: More base url tests. (master...base) https://github.com/w3c/web-platform-tests/pull/1972
  72. # [18:33] * Parts: gitbot (~gitbot@public.cloak)
  73. # [18:33] <Ms2ger> r?
  74. # [18:38] * Joins: darobin (rberjon@public.cloak)
  75. # [18:55] * Quits: dom (dom@public.cloak) ("")
  76. # [18:56] <MikeSmith> Ms2ger: are you sure the expected result of that "about:blank with a base element" test is right?
  77. # [19:00] * Joins: bhill2_ (~bhill2@public.cloak)
  78. # [19:00] * Quits: bhill2 (~bhill2@public.cloak) (Client closed connection)
  79. # [19:01] * Quits: bhill2_ (~bhill2@public.cloak) (Client closed connection)
  80. # [19:03] * Joins: bhill2 (~bhill2@public.cloak)
  81. # [19:03] <MikeSmith> hmm, Chrome and Safari do one thing with that case, IE does something different
  82. # [19:04] <MikeSmith> and Firefox has the expected result
  83. # [19:04] <MikeSmith> oh, no, Firefox doesn't either
  84. # [19:05] <MikeSmith> so we have no UAs that give the expected result
  85. # [19:05] * Quits: bhill2 (~bhill2@public.cloak) (Client closed connection)
  86. # [19:08] <MikeSmith> Ms2ger: https://critic.hoppipolla.co.uk/a0051858?review=5485 "It does not work properly in Chrome and Safari."?
  87. # [19:10] <MikeSmith> that test causes a bunch of 404s in Chrome and Safari
  88. # [19:10] <jgraham> gsnedders, Ms2ger: Yeah, the only person that might use those is hsivonen/MikeSmith
  89. # [19:11] <MikeSmith> you mean the html5lib tests?
  90. # [19:11] <jgraham> Yeah
  91. # [19:12] <MikeSmith> yeah, the validator ones, I looked at those a long time ago and ported whichever ones we needed
  92. # [19:12] <MikeSmith> so yeah we don't need any of those as far as testing the parser in the context of the validator
  93. # [19:16] <jgraham> gsnedders: r+
  94. # [19:18] <Ms2ger> MikeSmith, ?
  95. # [19:24] <MikeSmith> Ms2ger: if it doesn't work properly in Chrome and Safari how come we're gonna put it into the suite.. ?
  96. # [19:25] <Ms2ger> MikeSmith, baseURI already is in the suite
  97. # [19:25] <MikeSmith> and if it doesn't work properly in Chrome and Safari shouldn't we have the test do NOTRUN or forced timeout instead of claiming to fail
  98. # [19:25] <Ms2ger> Uh
  99. # [19:25] <Ms2ger> The point of tests is to fail if the feature isn't implemented correctly
  100. # [19:26] <MikeSmith> I realize that :)
  101. # [19:27] <MikeSmith> I thought your comment meant the test didn't run properly in Chrome and Blink
  102. # [19:27] <MikeSmith> since that's what your comment says
  103. # [19:27] * Quits: darobin (rberjon@public.cloak) (Client closed connection)
  104. # [19:28] * Joins: darobin (rberjon@public.cloak)
  105. # [19:28] <Ms2ger> "[...] the baseURI getter. It does not work properly in Chrome and Safari."
  106. # [19:28] <MikeSmith> instead of, say, "This test fails in Chrome and Safari as expected since they don't impelemtnt the feature properly"
  107. # [19:29] <Ms2ger> I'm trying to say that these additional tests are useful because the existing test doesn't necessarily catch bugs
  108. # [19:29] <MikeSmith> ah
  109. # [19:31] <gsnedders> jgraham: there was a long discussion on the bug about validator.nu, FWIW
  110. # [19:32] <MikeSmith> Ms2ger: Hixie is right that you and Anne are too succinct sometimes :)
  111. # [19:32] <MikeSmith> gsnedders: which bug?
  112. # [19:32] <Ms2ger> Fair enough :)
  113. # [19:34] <MikeSmith> speaking of Anne I wish he would do more test-case review
  114. # [19:35] <MikeSmith> but I guess he can't do everything
  115. # [19:35] * Quits: darobin (rberjon@public.cloak) (Ping timeout: 180 seconds)
  116. # [19:35] <Ms2ger> It'd be great if he could :)
  117. # [19:35] <MikeSmith> well I tried to talk Hixie into doing test review as well
  118. # [19:35] <MikeSmith> and I think his exact words were "Ha!"
  119. # [19:35] <Ms2ger> I'd rather Hixie did spec work right now
  120. # [19:35] <MikeSmith> well yeah
  121. # [19:36] <MikeSmith> people can't everything
  122. # [19:36] <MikeSmith> we all have our own different ponies to trot around the farmyard
  123. # [19:38] <Ms2ger> Also, don't we have w3c staff who could do code review?
  124. # [19:38] <gsnedders> jgraham: one of the ones linked to r/5480
  125. # [19:39] <gsnedders> sorry, MikeSmith ^^
  126. # [19:40] <MikeSmith> Ms2ger: well plh does some, darobin does some, dom does some, and xiaoqian writes some
  127. # [19:40] <Ms2ger> And you
  128. # [19:40] <Ms2ger> Still
  129. # [19:40] <MikeSmith> well I should do more
  130. # [19:40] <Ms2ger> Can't hurt to bug :)
  131. # [19:41] <MikeSmith> I could stop everything else and just review and write test cases all day I would actually feel very good about myself if I did
  132. # [19:42] <MikeSmith> Ms2ger: anyway for now I'm fairly blazed atm so I think I can't properly review that PR. Will take a look in the morning if nobody else has got to it first
  133. # [19:43] * Ms2ger sets a cronjob for MikeSmith's mornings to bug him about code review
  134. # [19:44] <MikeSmith> heh
  135. # [19:45] <MikeSmith> gsnedders: so yeah I just re-read https://github.com/html5lib/html5lib-tests/issues/33 and can re-confirm that it's OK to just drop those tests
  136. # [19:45] <MikeSmith> gsnedders: about Henri's comment there, we actually have a lot more validator tests that before, at https://github.com/w3c/web-platform-tests/tree/master/conformance-checkers
  137. # [19:46] <MikeSmith> including a few specific parser tests at https://github.com/w3c/web-platform-tests/tree/master/conformance-checkers/html/parser
  138. # [19:47] <MikeSmith> but some other tests in that conformance-checkers tree are also effectively parser tests, in that they are expected to fail with a message that gets emitted by the parser
  139. # [19:47] <MikeSmith> and I wrote a test harness for validator.nu that checks for those expected parser messages
  140. # [19:51] <Ms2ger> MikeSmith, since you're around, wanna give me a second opinion?
  141. # [19:53] <MikeSmith> Ms2ger: sure
  142. # [19:53] <Ms2ger> https://html.spec.whatwg.org/multipage/semantics.html#following-hyperlinks-2
  143. # [19:53] * MikeSmith looks
  144. # [19:53] <Ms2ger> I think step 6 should come before step 4-5
  145. # [19:54] * MikeSmith reads
  146. # [19:56] <MikeSmith> Ms2ger: are there cases where it actually would make a difference if it were re-ordered?
  147. # [19:57] <MikeSmith> otherwise it wouldn't hurt at least to re-order it I guess
  148. # [19:57] <Ms2ger> Well, I dunno what "append" means for a URL and a string
  149. # [19:57] <Ms2ger> So... maybe?
  150. # [19:58] <MikeSmith> hmm yeah, "append" a string to a URL (object) isn't really defined
  151. # [19:59] <MikeSmith> or even define-able
  152. # [19:59] <MikeSmith> not in that simple way at least
  153. # [19:59] <MikeSmith> so that kind of seems like a spec bug to begin with
  154. # [19:59] <MikeSmith> ah but yeah I get your point now
  155. # [19:59] <MikeSmith> yeah
  156. # [20:00] <MikeSmith> should definitely be before step 4 where it's saying to resolve it
  157. # [20:00] <MikeSmith> yeah
  158. # [20:01] <Ms2ger> <3
  159. # [20:01] <MikeSmith> with that I will retire for the evening satisfied that I've helped accomplish something (marginally) useful today
  160. # [20:02] <MikeSmith> nn
  161. # [20:02] <Ms2ger> Night
  162. # [20:04] * Joins: bhill2 (~bhill2@public.cloak)
  163. # [20:11] * terri_offline is now known as terri
  164. # [21:33] * Quits: Ms2ger (~Ms2ger@public.cloak) ("nn")
  165. # [22:26] * Joins: gitbot (~gitbot@public.cloak)
  166. # [22:26] -gitbot:#testing- [testharness.js] jgraham closed pull request #136: Fix handling of assertions in workers (master...inexorabletash/worker-script-url) https://github.com/w3c/testharness.js/pull/136
  167. # [22:26] * Parts: gitbot (~gitbot@public.cloak)
  168. # [22:46] * Joins: gitbot (~gitbot@public.cloak)
  169. # [22:46] -gitbot:#testing- [web-platform-tests] inexorabletash opened pull request #1973: Update to latest testharness.js (master...inexorabletash/update-resources-1a6f3bca) https://github.com/w3c/web-platform-tests/pull/1973
  170. # [22:46] * Parts: gitbot (~gitbot@public.cloak)
  171. # [22:46] * plinss is now known as plinss_away
  172. # [22:56] * Joins: gitbot (~gitbot@public.cloak)
  173. # [22:56] -gitbot:#testing- [web-platform-tests] Ms2ger closed pull request #1973: Update to latest testharness.js (master...inexorabletash/update-resources-1a6f3bca) https://github.com/w3c/web-platform-tests/pull/1973
  174. # [22:56] * Parts: gitbot (~gitbot@public.cloak)
  175. # [22:59] * Quits: bhill2 (~bhill2@public.cloak) (Client closed connection)
  176. # [23:01] * Joins: bhill2 (~bhill2@public.cloak)
  177. # [23:09] * Quits: plh (plehegar@public.cloak) ("Leaving")
  178. # [23:33] * plinss_away is now known as plinss
  179. # Session Close: Wed Jul 08 00:00:00 2015

Previous day, Next day

Think these logs are useful? Then please donate to show your gratitude (and keep them up, of course). Thanks! — Krijn