/irc-logs / w3c / #testing / 2015-08-04 / end

Options:

Previous day, Next day

  1. # Session Start: Tue Aug 04 00:00:00 2015
  2. # Session Ident: #testing
  3. # [01:11] * Quits: bhill2 (~bhill2@public.cloak) (Client closed connection)
  4. # [01:16] * heycam|away is now known as heycam
  5. # [01:38] * Joins: playjax (~chatzilla@public.cloak)
  6. # [02:15] * terri is now known as terri_offline
  7. # [02:21] * Quits: jyasskin (~textual@public.cloak) ("My computer has gone to sleep. ZZZzzz…")
  8. # [02:26] * Joins: jyasskin (~textual@public.cloak)
  9. # [03:31] * Quits: ArtB (~ArtB@public.cloak) ("Leaving.")
  10. # [03:31] * Quits: jyasskin (~textual@public.cloak) ("My computer has gone to sleep. ZZZzzz…")
  11. # [04:04] * Joins: bhill2 (~bhill2@public.cloak)
  12. # [04:32] * Quits: playjax (~chatzilla@public.cloak) (Ping timeout: 180 seconds)
  13. # [04:41] * heycam is now known as heycam|away
  14. # [05:15] * heycam|away is now known as heycam
  15. # [05:36] * Quits: bhill2 (~bhill2@public.cloak) (Client closed connection)
  16. # [05:52] * Joins: jyasskin (~textual@public.cloak)
  17. # [06:02] * heycam is now known as heycam|away
  18. # [06:05] * heycam|away is now known as heycam
  19. # [07:16] * Quits: jyasskin (~textual@public.cloak) ("My computer has gone to sleep. ZZZzzz…")
  20. # [07:52] * Joins: gamekathu (~gamekathu@public.cloak)
  21. # [07:57] <gamekathu> hi. i would like to contribute in this project.. where to start?
  22. # [08:05] * heycam is now known as heycam|away
  23. # [08:09] * heycam|away is now known as heycam
  24. # [08:36] <MikeSmith> hi gamekathu
  25. # [08:37] <MikeSmith> http://testthewebforward.org/docs/ is a good place to start
  26. # [08:37] <gamekathu> hi mike
  27. # [08:37] <MikeSmith> hey there
  28. # [08:38] <gamekathu> yes i have read the manual. my question is, how do you identify what to write tests on?
  29. # [08:38] <MikeSmith> ah
  30. # [08:38] <MikeSmith> hang on
  31. # [08:38] <gamekathu> ok
  32. # [08:38] <MikeSmith> https://github.com/w3c/web-platform-tests/issues?q=is%3Aopen+is%3Aissue+label%3Adifficulty%3Aeasy
  33. # [08:38] <MikeSmith> those are issues tagged "difficulty: easy"
  34. # [08:39] <MikeSmith> but for which we don't yet have anybody who's written a PR
  35. # [08:39] <gamekathu> cool.. will start working on these :)
  36. # [08:39] <gamekathu> thanks! :)
  37. # [08:41] <gamekathu> actually i was fascinated by the mozilla servo project, and would like to contribute in it... so figured out to start writing tests from here
  38. # [08:42] <gamekathu> this proj would also help servo in setting up tests?
  39. # [08:51] <MikeSmith> gamekathu: yes, absolutely
  40. # [08:51] <MikeSmith> we have a number of people from the servo project who've been involved some already
  41. # [08:54] <gamekathu> great!
  42. # [08:54] <gamekathu> thanks fr the help btw.. will hang around this channel frm now :)
  43. # [09:18] <MikeSmith> gamekathu: cool
  44. # [09:21] * Joins: Ms2ger (~Ms2ger@public.cloak)
  45. # [10:03] * heycam is now known as heycam|away
  46. # [10:09] * Joins: gitbot (~gitbot@public.cloak)
  47. # [10:09] -gitbot:#testing- [web-platform-tests] zqzhang closed pull request #1843: Contributing Blink's Screen Orientation layout tests (master...screen-orientation) https://github.com/w3c/web-platform-tests/pull/1843
  48. # [10:09] * Parts: gitbot (~gitbot@public.cloak)
  49. # [10:09] * Joins: gitbot (~gitbot@public.cloak)
  50. # [10:09] -gitbot:#testing- [web-platform-tests] zqzhang pushed 8 new commits to master: https://github.com/w3c/web-platform-tests/compare/2bd8c7dcf2e2...e084e100b409
  51. # [10:09] -gitbot:#testing- web-platform-tests/master cab194d Li Hao: Contributing Blink's Screen Orientation layout tests...
  52. # [10:09] -gitbot:#testing- web-platform-tests/master 6c0ac73 Li Hao: lock() implemented in screen.orientation, not screen...
  53. # [10:09] -gitbot:#testing- web-platform-tests/master e62ab52 Li Hao: Fix wrong steps in lockOrientation-basic.html...
  54. # [10:09] * Parts: gitbot (~gitbot@public.cloak)
  55. # [10:14] * Quits: Ms2ger (~Ms2ger@public.cloak) (Ping timeout: 180 seconds)
  56. # [11:03] <gamekathu> MikeSmith : why am I getting 'Uncaught Error: Manifest generation failed' when running the test suite?
  57. # [11:13] * Joins: gitbot (~gitbot@public.cloak)
  58. # [11:13] -gitbot:#testing- [wptrunner] jgraham pushed 1 new commit to jgraham/executorservo_reftest_debug: https://github.com/w3c/wptrunner/commit/92c4b2e546c3796bac6f3bcf091c22cae000ca51
  59. # [11:13] -gitbot:#testing- wptrunner/jgraham/executorservo_reftest_debug 92c4b2e James Graham: fixup! Support running reftests under a debugger with the servo executor
  60. # [11:13] * Parts: gitbot (~gitbot@public.cloak)
  61. # [11:14] <jgraham> gamekathu: Did you |git submodule update --init --recursive| in your wpt checkout?
  62. # [11:15] <gamekathu> ya did it, but i think i missed to add -recursive flag in the git clone itself
  63. # [11:29] * Joins: Ms2ger (~Ms2ger@public.cloak)
  64. # [11:39] * Quits: Ms2ger (~Ms2ger@public.cloak) (Ping timeout: 180 seconds)
  65. # [11:49] * Joins: Ms2ger (~Ms2ger@public.cloak)
  66. # [12:01] * Quits: Ms2ger (~Ms2ger@public.cloak) (Ping timeout: 180 seconds)
  67. # [12:10] * Joins: Ms2ger (~Ms2ger@public.cloak)
  68. # [12:44] * Joins: ArtB (~ArtB@public.cloak)
  69. # [13:15] <gamekathu> jgraham: ok made a fresh rcursive clone and updated submodules, now when I launch the index.html in wpt/tools/runner by a python simpleHttpServer, I get this error : Failed to load resource: the server responded with a status of 501 (Unsupported method ('POST'))
  70. # [13:41] <Ms2ger> gamekathu, try running our custom server, ./serve in the root of your wpt clone
  71. # [13:42] <gamekathu> ok Ms2ger will do that
  72. # [14:02] * Quits: gamekathu (~gamekathu@public.cloak) ("Page closed")
  73. # [14:09] * Quits: Ms2ger (~Ms2ger@public.cloak) (Ping timeout: 180 seconds)
  74. # [14:17] * Joins: Ms2ger (~Ms2ger@public.cloak)
  75. # [16:47] * Joins: gamekathu (~gamekathu@public.cloak)
  76. # [16:51] * Joins: Kyle (~Kyle@public.cloak)
  77. # [16:51] <Kyle> Hey
  78. # [16:52] * Quits: Kyle (~Kyle@public.cloak) ("Page closed")
  79. # [17:07] * Joins: jyasskin (~textual@public.cloak)
  80. # [17:15] <Ms2ger> Bye
  81. # [17:37] * Quits: Ms2ger (~Ms2ger@public.cloak) ("Leaving")
  82. # [17:41] * Joins: Ms2ger (~Ms2ger@public.cloak)
  83. # [17:42] * Joins: gamekathu_ (~gamekathu@public.cloak)
  84. # [17:45] * Quits: hgl (~hgl@public.cloak) (Ping timeout: 180 seconds)
  85. # [17:46] * Quits: gamekathu (~gamekathu@public.cloak) (Ping timeout: 180 seconds)
  86. # [17:47] * Joins: hgl (~hgl@public.cloak)
  87. # [17:59] <gamekathu_> MikeSmith: hi, as per your suggestion I am trying out the issues. now while creating a separate local branch, it is advised in the webpage to give it a test topic name. now can i give it the issue number itself? just want to know the standards
  88. # [17:59] <jgraham> gamekathu_: You can really give it any name you want, it doesn't matter
  89. # [18:00] <gamekathu_> jgraham: cool.
  90. # [18:01] <gamekathu_> jgraham: is there any doc explaining how to write yaml test cases?
  91. # [18:04] * Joins: bhill2 (~bhill2@public.cloak)
  92. # [18:05] <jgraham> The 2dcontext ones? Only the source code
  93. # [18:07] <gamekathu_> okay
  94. # [18:09] * Disconnected
  95. # [18:10] * Attempting to rejoin channel #testing
  96. # [18:10] * Rejoined channel #testing
  97. # [18:10] * Quits: krijnhoetmer (~krijnhoetmer@public.cloak) (Client closed connection)
  98. # [18:29] * Quits: bhill2 (~bhill2@public.cloak) (Client closed connection)
  99. # [18:33] * Joins: bhill2 (~bhill2@public.cloak)
  100. # [18:35] <gamekathu_> jgraham: ok I have changed the yaml file, now as given in the issue #1602 I run python gentest.py. Now a lot of files are being modified / created. do I need to add them all to the repo or just my change?
  101. # [18:39] <jgraham> gamekathu_: Well your change there should presumably modify at least one output file, so you need more than just the YAML change
  102. # [18:39] <Ms2ger> But probably also not "a lot"
  103. # [18:40] <jgraham> Yeah, I would add the yaml change and the output file corresponding to that addition, and ignore any other changes
  104. # [18:42] <gamekathu_> well as per the issue i added a case to test toDataUrl 'image/jpg' . but after running the gentest i can see the respective changed file (most probably '/html/semantics/embedded-content/the-canvas-element/toDataURL.jpg.html'), but along with it lots of other modifications / additions of files as well
  105. # [18:45] <gamekathu_> paste -> https://pastebin.mozilla.org/8841596
  106. # [18:45] <jgraham> So I think regenerating the png files can change metadata or something in the files; I don't think this is worth worring about
  107. # [18:45] <jgraham> I'm not sure why those files in ../../html changed
  108. # [18:46] <jgraham> It's also possible that someone has edited the yaml file and not actually regenererated the tests
  109. # [18:47] <gamekathu_> ok then i think i should add tests.yaml and the file '.../toDataURL.jpg.html' which is relevant to the test case
  110. # [18:47] <jgraham> gamekathu_: Yeah, I get a similar result to you running on a clean copy
  111. # [18:48] <jgraham> So I think there's a problem here and it's not your fault
  112. # [18:48] <gamekathu_> ok..
  113. # [18:48] <jgraham> But your plan is good, just ignore the other changes
  114. # [18:49] <gamekathu_> okay :)
  115. # [18:59] <gamekathu_> jgraham: another issue, i have added the test case and generated the file. now when I run the test runner with the correct folder, that html file is not tested.
  116. # [18:59] <jgraham> gamekathu_: You need to regenerate the manifest
  117. # [18:59] <gamekathu_> how to do that?
  118. # [18:59] <jgraham> ./manifest in the test root directory
  119. # [18:59] <gamekathu_> ok
  120. # [19:00] * Quits: bhill2 (~bhill2@public.cloak) (Client closed connection)
  121. # [19:02] * Joins: bhill2 (~bhill2@public.cloak)
  122. # [19:06] <gamekathu_> jgraham: updated manifest, still nothing. :(
  123. # [19:06] <jgraham> Oh
  124. # [19:06] <jgraham> Well what does the file look like?
  125. # [19:07] <gamekathu_> jgraham: https://pastebin.mozilla.org/8841597
  126. # [19:08] <gamekathu_> location: html/semantics/embedded-content/the-canvas-element/toDataURL.jpg.html
  127. # [19:12] <jgraham> Well that looks reasonably plausible
  128. # [19:13] <jgraham> I don't know why the runner isn't picking it up for you
  129. # [19:13] <jgraham> I suggest submitting the PR
  130. # [19:17] * terri_offline is now known as terri
  131. # [19:19] <gamekathu_> ok will do that
  132. # [19:27] * Joins: gitbot (~gitbot@public.cloak)
  133. # [19:27] -gitbot:#testing- [web-platform-tests] koustuvsinha opened pull request #2047: Test for toDataURL('image/jpg') (master...test#1602) https://github.com/w3c/web-platform-tests/pull/2047
  134. # [19:27] * Parts: gitbot (~gitbot@public.cloak)
  135. # [19:28] <gamekathu_> jgraham: https://github.com/w3c/web-platform-tests/pull/2047 my first PR in this repo :)
  136. # [19:32] <jgraham> gamekathu_: Thanks! I've reviewed your PR on a tool called critic https://critic.hoppipolla.co.uk/r/5690
  137. # [19:33] <jgraham> Please ask if you have any questions
  138. # [19:34] <gamekathu_> ok, first should i amend my last commit to change the commit msg?
  139. # [19:35] <jgraham> gamekathu_: No, do that last
  140. # [19:36] <jgraham> Generally altering the history upsets critic
  141. # [19:36] <jgraham> So avoid doing anything that requires a push -f until the review is otherwise ready to land
  142. # [19:36] <gamekathu_> ok. second, Ms2ger commented on the issue #1602 to put in jpg instead of jpeg
  143. # [19:37] <jgraham> Oh!
  144. # [19:37] <jgraham> Well I could well be wrong then
  145. # [19:37] <Ms2ger> I did?
  146. # [19:37] <jgraham> Oh, no, I see
  147. # [19:37] <gamekathu_> yeah.. :)
  148. # [19:38] <jgraham> I think he means toDataURL("image/jpg") on the input
  149. # [19:38] <jgraham> I guess I should check the spec now :)
  150. # [19:40] <jgraham> gamekathu_: From the spec it seems like the method should do nothing…
  151. # [19:40] <gamekathu_> can you give me the link of the spec?
  152. # [19:41] <gamekathu_> also, what should I change then
  153. # [19:42] <jgraham> Apparently I lost my ability to read
  154. # [19:42] <jgraham> It should create a PNG file
  155. # [19:42] <jgraham> https://html.spec.whatwg.org/#a-serialisation-of-the-bitmap-as-a-file
  156. # [19:42] <jgraham> "[...] If the user agent does not support the requested type, it must create the file using the PNG format. [PNG]"
  157. # [19:43] <jgraham> image/jpg isn't a type representing jpeg images (image/jpeg is)
  158. # [19:43] <jgraham> So theoretically a browser could do anything
  159. # [19:43] <jgraham> But im practice it should create png files
  160. # [19:45] <gamekathu_> the test was for jpg files, and according to spec : "the value "image/jpeg" would mean to generate a JPEG image"
  161. # [19:45] <gamekathu_> i think png test cases were covered earlier?
  162. # [19:45] <jgraham> gamekathu_: The test is for image/jpg (no e)
  163. # [19:46] <jgraham> Which != image/jpeg
  164. # [19:46] <gamekathu_> exactly.. thats why i did a regex jpg
  165. # [19:47] <jgraham> But it doesn't create a image/jpg data url because that format doesn't exist
  166. # [19:47] <jgraham> It creates an image/png data url
  167. # [19:47] <gamekathu_> ohh .. yes now i undestand
  168. # [19:48] <gamekathu_> yes it should return png..
  169. # [19:48] <gamekathu_> so this test case is actually an edge case for jpeg, such that if user string misses an 'e' it should return default png
  170. # [19:48] <gamekathu_> ?
  171. # [19:52] <jgraham> Yes
  172. # [19:54] <gamekathu_> jgraham: ok, then why this should be a separate test case when there is a toDataURL.bogustype case? https://github.com/w3c/web-platform-tests/blob/master/2dcontext/tools/tests.yaml#L486-L492
  173. # [19:59] <jgraham> gamekathu_: Because implementors are much more likely to get this specific case wrong than many others
  174. # [19:59] <jgraham> Especially since jpeg is commonly given the file extension jpg
  175. # [20:00] <gamekathu_> yes. okay understood it, sorry for asking too many questions :P
  176. # [20:00] <gamekathu_> will update my PR
  177. # [20:02] * Quits: bhill2 (~bhill2@public.cloak) (Client closed connection)
  178. # [20:03] <jgraham> asking questions is good :)
  179. # [20:04] <gamekathu_> updated PR, please review :)
  180. # [20:06] * Joins: bhill2 (~bhill2@public.cloak)
  181. # [20:10] <jgraham> gamekathu_: You didn't regenerate the test
  182. # [20:10] <gamekathu_> oh my.. totally forgot!!! :( sorry updating it
  183. # [20:15] <gamekathu_> jgraham: updated PR
  184. # [20:26] <jgraham> gamekathu_: OK, looks good apart from the commit message. Squash into one commit, reword the message and I'll merge when I get home (going afk now)
  185. # [20:26] <gamekathu_> ok :)
  186. # [20:38] <gamekathu_> done :) will work on the rest test cases tomorrow.. gd nt
  187. # [20:38] * Quits: gamekathu_ (~gamekathu@public.cloak) ("Page closed")
  188. # [20:38] * Quits: Ms2ger (~Ms2ger@public.cloak) (Ping timeout: 180 seconds)
  189. # [20:47] * Joins: ArtB1 (~ArtB@public.cloak)
  190. # [20:52] * Quits: ArtB (~ArtB@public.cloak) (Ping timeout: 180 seconds)
  191. # [21:14] * ArtB1 is now known as ArtB
  192. # [21:17] <ArtB> any w3c staff people available here and able to add @martinthomson to https://github.com/orgs/w3c/teams/webapps ?
  193. # [22:30] * Quits: jyasskin (~textual@public.cloak) ("My computer has gone to sleep. ZZZzzz…")
  194. # [22:41] * Joins: gitbot (~gitbot@public.cloak)
  195. # [22:41] -gitbot:#testing- [web-platform-tests] jgraham closed pull request #2047: Test for toDataURL('image/jpg') (master...test#1602) https://github.com/w3c/web-platform-tests/pull/2047
  196. # [22:41] * Parts: gitbot (~gitbot@public.cloak)
  197. # [22:44] * Joins: jyasskin (~textual@public.cloak)
  198. # Session Close: Wed Aug 05 00:00:00 2015

Previous day, Next day

Think these logs are useful? Then please donate to show your gratitude (and keep them up, of course). Thanks! — Krijn