/irc-logs / w3c / #testing / 2015-08-07 / end

Options:

Previous day, Next day

  1. # Session Start: Fri Aug 07 00:00:00 2015
  2. # Session Ident: #testing
  3. # [00:23] <bhill2> so...
  4. # [00:24] <bhill2> given that I've seen the comment "squash?" in some of my recent PRs
  5. # [00:24] <bhill2> what is the preferred way to squash in git that Critic won't get upset about?
  6. # [00:25] <bhill2> I've been doing "git rebase -i HEAD~N" and then "push --force" but that doesn't seem to be the right incantation
  7. # [00:27] <jgraham> that's fine as long as the review is all finifhed
  8. # [00:27] <jgraham> *finished
  9. # [00:27] <jgraham> we don't care about critic getting upset then
  10. # [00:28] <bhill2> ok
  11. # [00:28] <bhill2> so no squashing until review is accepted?
  12. # [00:33] * heycam is now known as heycam|away
  13. # [00:45] * Quits: playjax (~chatzilla@public.cloak) ("ChatZilla 0.9.91.1 [Firefox 32.0.1/20140911151253]")
  14. # [00:58] * Quits: bhill2 (~bhill2@public.cloak) (Client closed connection)
  15. # [02:01] * Joins: cvrebert (~cvrebert@public.cloak)
  16. # [02:02] <cvrebert> botie: tell MikeSmith As requested, this is a reminder regarding migrating the CSS Validator to GitHub
  17. # [02:02] <botie> will do
  18. # [02:21] * Quits: cvrebert (~cvrebert@public.cloak) (cvrebert)
  19. # [02:58] * Joins: playjax (~chatzilla@public.cloak)
  20. # [04:22] * Quits: kochi (~kochi@public.cloak) ("Leaving.")
  21. # [04:23] * Quits: ArtB (~ArtB@public.cloak) ("Leaving.")
  22. # [04:30] * Joins: kochi (~kochi@public.cloak)
  23. # [05:45] * Quits: playjax (~chatzilla@public.cloak) (Client closed connection)
  24. # [05:52] * Joins: jyasskin (~textual@public.cloak)
  25. # [06:07] * Quits: jyasskin (~textual@public.cloak) ("My computer has gone to sleep. ZZZzzz…")
  26. # [06:08] * Joins: playjax (~chatzilla@public.cloak)
  27. # [06:24] * Quits: hgl (~hgl@public.cloak) ("Quit")
  28. # [06:54] * Joins: jyasskin (~textual@public.cloak)
  29. # [07:41] * Quits: jyasskin (~textual@public.cloak) ("My computer has gone to sleep. ZZZzzz…")
  30. # [08:24] * Quits: playjax (~chatzilla@public.cloak) (Ping timeout: 180 seconds)
  31. # [08:51] * Joins: cvrebert (~cvrebert@public.cloak)
  32. # [08:53] <cvrebert> MikeSmith: CSS Validator?
  33. # [08:56] * Joins: Ms2ger (~Ms2ger@public.cloak)
  34. # [09:05] * Quits: cvrebert (~cvrebert@public.cloak) (cvrebert)
  35. # [10:17] * Quits: kochi (~kochi@public.cloak) ("Leaving.")
  36. # [10:18] * Joins: playjax (~chatzilla@public.cloak)
  37. # [10:27] * Joins: kochi (~kochi@public.cloak)
  38. # [10:33] * Quits: kochi (~kochi@public.cloak) (Client closed connection)
  39. # [10:34] * Joins: foo (~foo@public.cloak)
  40. # [10:37] * Joins: kochi (~kochi@public.cloak)
  41. # [10:40] * Joins: nick (~nick@public.cloak)
  42. # [10:47] * Quits: nick (~nick@public.cloak) (Ping timeout: 180 seconds)
  43. # [10:57] * Quits: playjax (~chatzilla@public.cloak) (Client closed connection)
  44. # [11:25] * Joins: kochi1 (~kochi@public.cloak)
  45. # [11:27] * Quits: kochi (~kochi@public.cloak) (Ping timeout: 180 seconds)
  46. # [11:32] * Quits: foo (~foo@public.cloak) (Ping timeout: 180 seconds)
  47. # [11:42] * Quits: kochi1 (~kochi@public.cloak) (Client closed connection)
  48. # [11:45] * Joins: playjax (~chatzilla@public.cloak)
  49. # [11:46] * Joins: kochi (~kochi@public.cloak)
  50. # [12:52] * Joins: ArtB (~ArtB@public.cloak)
  51. # [14:29] * Joins: hgl (~hgl@public.cloak)
  52. # [15:31] * Quits: Ms2ger (~Ms2ger@public.cloak) (Ping timeout: 180 seconds)
  53. # [15:43] * Joins: Ms2ger (~Ms2ger@public.cloak)
  54. # [16:49] * Quits: playjax (~chatzilla@public.cloak) (Client closed connection)
  55. # [17:29] * Joins: jyasskin (~textual@public.cloak)
  56. # [17:32] * Joins: gamekathu (~gamekathu@public.cloak)
  57. # [18:00] <gamekathu> jgraham: hi its me again! would like to take on this issue : https://github.com/w3c/web-platform-tests/issues/1636
  58. # [18:01] * Joins: bhill2 (~bhill2@public.cloak)
  59. # [18:01] <gamekathu> its quite big, so im gonna take one by one
  60. # [18:01] <jgraham> gamekathu: Excellent!
  61. # [18:02] <gamekathu> ok for starters i figured out need to add tests in this file : https://github.com/w3c/web-platform-tests/blob/master/html/dom/documents/dom-tree-accessors/Document.currentScript.html
  62. # [18:02] <gamekathu> do i add it here directly or there is any automated system like the previous yaml case?
  63. # [18:03] <jgraham> No, there's no automated system
  64. # [18:03] <jgraham> Just adding it there directly seems fine
  65. # [18:04] <jgraham> You can also start a new file if that's easier for any specific cases
  66. # [18:04] <gamekathu> ok. for verifying scripts i will use this one only
  67. # [18:07] <jgraham> I look forward to your PRs :)
  68. # [18:09] <gamekathu> sure :)
  69. # [18:09] * Joins: gitbot (~gitbot@public.cloak)
  70. # [18:09] -gitbot:#testing- [web-platform-tests] hillbrad closed pull request #2054: fix broken reference to mock plugin at 127.0.0.1 (master...hillbrad/fix-mock-plugin) https://github.com/w3c/web-platform-tests/pull/2054
  71. # [18:09] * Parts: gitbot (~gitbot@public.cloak)
  72. # [18:09] * Joins: gitbot (~gitbot@public.cloak)
  73. # [18:09] -gitbot:#testing- [web-platform-tests] hillbrad pushed 2 new commits to master: https://github.com/w3c/web-platform-tests/compare/836b4c036a23...ad9d403e01b0
  74. # [18:09] -gitbot:#testing- web-platform-tests/master 74d27b9 Brad Hill: remove nonsensical tests (nonsense in original blink repo, still nonsense after conversion)
  75. # [18:09] -gitbot:#testing- web-platform-tests/master ad9d403 Brad Hill: Merge pull request #2054 from hillbrad/hillbrad/fix-mock-plugin...
  76. # [18:09] * Parts: gitbot (~gitbot@public.cloak)
  77. # [18:34] <gamekathu> jgraham: since the issue has lot of test cases, can I file one PR and add the commits in that as and when done? this way you can review them easily
  78. # [18:54] * Quits: jyasskin (~textual@public.cloak) ("My computer has gone to sleep. ZZZzzz…")
  79. # [18:59] <jgraham> gamekathu: Sounds fine
  80. # [19:03] * Joins: gitbot (~gitbot@public.cloak)
  81. # [19:03] -gitbot:#testing- [web-platform-tests] koustuvsinha opened pull request #2056: Tests for Document#currentScript (master...test#1636) https://github.com/w3c/web-platform-tests/pull/2056
  82. # [19:03] * Parts: gitbot (~gitbot@public.cloak)
  83. # [19:05] <gamekathu> jgraham: https://github.com/w3c/web-platform-tests/pull/2056
  84. # [19:10] <jgraham> 'K I will look at it in a while
  85. # [19:10] <jgraham> Thanks
  86. # [19:11] <gamekathu> yes sure, i will continue on other test cases
  87. # [19:15] * Quits: hober (~ted@public.cloak) (Client closed connection)
  88. # [19:15] * Quits: bret (~sid12421@public.cloak) (Ping timeout: 180 seconds)
  89. # [19:15] * Quits: hallvord (~sid83@public.cloak) (Client closed connection)
  90. # [19:15] * Quits: tobie (~sid5692@public.cloak) (Ping timeout: 180 seconds)
  91. # [19:15] * Quits: birtles (~sid16523@public.cloak) (Ping timeout: 180 seconds)
  92. # [19:15] * Quits: timeless (~sid4015@public.cloak) (Ping timeout: 180 seconds)
  93. # [19:15] * Joins: hallvord (~sid83@public.cloak)
  94. # [19:15] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Ping timeout: 180 seconds)
  95. # [19:16] * Joins: birtles (~sid16523@public.cloak)
  96. # [19:16] * Quits: frewsxcv (~sid86219@public.cloak) (Ping timeout: 180 seconds)
  97. # [19:16] * Joins: lmclister_______ (~sid13822@public.cloak)
  98. # [19:16] * Joins: bret (~sid12421@public.cloak)
  99. # [19:16] * Joins: timeless (~sid4015@public.cloak)
  100. # [19:16] * Joins: frewsxcv (~sid86219@public.cloak)
  101. # [19:16] * Joins: tobie (~sid5692@public.cloak)
  102. # [19:16] * Joins: AutomatedTester (~AutomatedTester@public.cloak)
  103. # [19:16] * Joins: hober (~ted@public.cloak)
  104. # [19:17] * Joins: jyasskin (~textual@public.cloak)
  105. # [19:18] * Quits: lmclister______ (~sid13822@public.cloak) (Ping timeout: 180 seconds)
  106. # [19:18] * lmclister_______ is now known as lmclister______
  107. # [19:42] * Quits: Ms2ger (~Ms2ger@public.cloak) ("nn")
  108. # [20:03] * Quits: jyasskin (~textual@public.cloak) ("My computer has gone to sleep. ZZZzzz…")
  109. # [20:19] * Quits: gamekathu (~gamekathu@public.cloak) (Ping timeout: 180 seconds)
  110. # [20:37] * Joins: jyasskin (~textual@public.cloak)
  111. # [21:57] * Joins: playjax (~chatzilla@public.cloak)
  112. # [22:08] * Quits: playjax (~chatzilla@public.cloak) (Ping timeout: 180 seconds)
  113. # [23:08] * Quits: jyasskin_w (~jyasskin@public.cloak) (Ping timeout: 180 seconds)
  114. # [23:35] * Joins: gitbot (~gitbot@public.cloak)
  115. # [23:35] -gitbot:#testing- [web-platform-tests] jgraham closed pull request #2039: Remove use of assert_object_equals() from IndexedDB tests. (master...inexorabletash/indexeddb-no-obj-eq) https://github.com/w3c/web-platform-tests/pull/2039
  116. # [23:35] * Parts: gitbot (~gitbot@public.cloak)
  117. # [23:35] * Joins: gitbot (~gitbot@public.cloak)
  118. # [23:35] -gitbot:#testing- [web-platform-tests] jgraham pushed 2 new commits to master: https://github.com/w3c/web-platform-tests/compare/ad9d403e01b0...080ca80f41e7
  119. # [23:35] -gitbot:#testing- web-platform-tests/master ab1556f Joshua Bell: Remove use of assert_object_equals() from IndexedDB tests....
  120. # [23:35] -gitbot:#testing- web-platform-tests/master 080ca80 jgraham: Merge pull request #2039 from inexorabletash/inexorabletash/indexeddb-no-obj-eq...
  121. # [23:35] * Parts: gitbot (~gitbot@public.cloak)
  122. # [23:54] * Joins: gitbot (~gitbot@public.cloak)
  123. # [23:54] -gitbot:#testing- [web-platform-tests] hillbrad opened pull request #2057: remove uses of console.log, console.info and spurious <pre> (master...hillbrad/no-console-use-for-csp-testsclear) https://github.com/w3c/web-platform-tests/pull/2057
  124. # [23:54] * Parts: gitbot (~gitbot@public.cloak)
  125. # [23:55] * Quits: bhill2 (~bhill2@public.cloak) ("Leaving...")
  126. # [23:57] * Joins: bhill2 (~bhill2@public.cloak)
  127. # [23:59] * Joins: bhill2_ (~bhill2@public.cloak)
  128. # Session Close: Sat Aug 08 00:00:00 2015

Previous day, Next day

Think these logs are useful? Then please donate to show your gratitude (and keep them up, of course). Thanks! — Krijn