/irc-logs / w3c / #testing / 2015-08-31 / end

Options:

Previous day, Next day

  1. # Session Start: Mon Aug 31 00:00:00 2015
  2. # Session Ident: #testing
  3. # [03:13] * Quits: AutomatedTester (~AutomatedTester@public.cloak) (Client closed connection)
  4. # [04:21] <gsnedders> hmm, how to deal with a testsuite that needs to build lots of XML documents… I guess it makes the most sense to load them all via XHR rather than store them in strings.
  5. # [04:38] * Quits: jyasskin (~textual@public.cloak) ("My computer has gone to sleep. ZZZzzz…")
  6. # [05:26] <MikeSmith> gsnedders: yes
  7. # [05:53] <gsnedders> The big problem is where to put the XPath queries. One per XML document.
  8. # [06:07] * Joins: gitbot (~gitbot@public.cloak)
  9. # [06:07] -gitbot:#testing- [web-platform-tests] gsnedders opened pull request #2124: Import Opera XPath tests. (master...opera_xpath) https://github.com/w3c/web-platform-tests/pull/2124
  10. # [06:07] * Parts: gitbot (~gitbot@public.cloak)
  11. # [06:24] <gsnedders> see that PR for the evilness
  12. # [07:06] <MikeSmith> holy moley
  13. # [07:07] <MikeSmith> gsnedders: what would should a proper review of those focus on doing?
  14. # [07:07] <MikeSmith> beyond just confirming that they actually run
  15. # [07:08] <MikeSmith> I am happy to spend some time reviewing them if I know what I should be checking for
  16. # [07:48] * Joins: jyasskin (~textual@public.cloak)
  17. # [07:56] * Joins: Ms2ger (~Ms2ger@public.cloak)
  18. # [09:00] * Joins: gitbot (~gitbot@public.cloak)
  19. # [09:00] -gitbot:#testing- [web-platform-tests] Ms2ger closed pull request #2123: Add tests for all obsolete reflecting IDL/content attributes (master...obsolete-reflect-attributes) https://github.com/w3c/web-platform-tests/pull/2123
  20. # [09:00] * Parts: gitbot (~gitbot@public.cloak)
  21. # [09:05] * Quits: jyasskin (~textual@public.cloak) ("My computer has gone to sleep. ZZZzzz…")
  22. # [09:09] <gsnedders> MikeSmith: I'm mostly interested in the runner
  23. # [09:09] <gsnedders> MikeSmith: and the high-level approach of how they're run
  24. # [09:09] <gsnedders> MikeSmith: they all pass in WebKit/Blink/Gecko, so they're presumably right
  25. # [09:14] * Joins: dom (dom@public.cloak)
  26. # [09:15] <gsnedders> (I'm not convinced they're great tests, but they're better than our existing zero tests)
  27. # [09:19] <gsnedders> I mean ideally we'd have a testsuite where we tests edge-cases with similar sets of elements in the document being queried and make sure we got the right ones back, etc
  28. # [09:26] <Ms2ger> "ideally" "xpath"
  29. # [09:30] <gsnedders> eh, I still think it's more worth spending time on than XSLT tests ;)
  30. # [09:36] <Ms2ger> :)
  31. # [09:36] <Ms2ger> gsnedders, r? https://github.com/w3c/csswg-test/pull/836
  32. # [09:38] <gsnedders> Ms2ger: idk about current csswg-test policies to know if that's expected or not :(
  33. # [09:39] <gsnedders> Ms2ger: it used to be the case that for some reason it was expected to have duplicate identical files lying around…
  34. # [09:40] <Ms2ger> Maybe in suites for different specs?
  35. # [09:41] <gsnedders> oh, it was /within suites/ as well
  36. # [09:42] <gsnedders> I think because of the whole owner mess
  37. # [09:42] <Ms2ger> At least that's been killed
  38. # [09:43] <gsnedders> I fear I'm soon going to war on the CSS WG
  39. # [09:43] <gsnedders> Also, is there any good summary of current policies before I start reviewing all the PRs open on wpt?
  40. # [09:43] * Ms2ger shall grab the popcorn
  41. # [09:44] <gsnedders> Because we have too damn many
  42. # [09:45] <Ms2ger> "Put one empty line between test()s"
  43. # [09:45] <Ms2ger> I think that's about it
  44. # [09:45] <gsnedders> anything about number of asserts per test?
  45. # [09:46] <Ms2ger> "Try to keep a test a somewhat logical grouping"
  46. # [09:46] <Ms2ger> Could mean one assert, could mean a hundred
  47. # [09:47] <gsnedders> but multiple asserts that coule trivially be split up in one test is fine if they're related?
  48. # [09:47] <Ms2ger> Yeah
  49. # [09:47] <gsnedders> e.g., https://github.com/w3c/web-platform-tests/commit/a426a86ef8d3e3f846e8b746cef342385c994c5d
  50. # [09:48] <Ms2ger> Hm, I'd probably split those up, for the sake of unicorn^WUAs that don't support __proto__
  51. # [09:48] <Ms2ger> But in general, we try to keep the bar pretty low
  52. # [09:49] <gsnedders> see, stuff is hard
  53. # [09:49] <gsnedders> I'd split it up, but is that a reason to kick it back?
  54. # [09:49] <Ms2ger> If it's in a PR from me or jgraham, yes
  55. # [09:50] <Ms2ger> From someone you don't see around often, merge and do a followup yourself if you care enough
  56. # [09:50] <gsnedders> a followup PR?
  57. # [09:51] <Ms2ger> gsnedders, but we're sorely lacking reviewers, so whatever you do is welcome :)
  58. # [09:52] * gsnedders is planning on later this week trying to convince someone to pay him to work on testing stuff
  59. # [09:53] <Ms2ger> Need a letter from me saying "you should totes hire gsnedders"?
  60. # [09:53] <Ms2ger> Anyway, I need to catch a train
  61. # [09:53] <Ms2ger> ttyl
  62. # [09:54] <gsnedders> Ms2ger: probably not :)
  63. # [09:58] <gsnedders> I need to work on web dev and cursing the terribleness of the web platform today anyway :)
  64. # [10:00] * Quits: Ms2ger (~Ms2ger@public.cloak) (Ping timeout: 180 seconds)
  65. # [11:02] <gsnedders> also who do I need to ask to get added to the repo so I can do stuff like label PRs?
  66. # [11:02] <gsnedders> MikeSmith: ^^
  67. # [11:07] <MikeSmith> gsnedders: Ms2er or jgraham can also add you
  68. # [11:07] <MikeSmith> (where did Ms2er go?)
  69. # [11:08] <gsnedders> a train
  70. # [11:08] <gsnedders> and it's a bank holiday in the UK, so I suppose jgraham might not be around
  71. # [11:08] <gsnedders> though it is still early-ish for him :P
  72. # [11:08] <gsnedders> and, like, you're around
  73. # [11:08] <MikeSmith> ok
  74. # [11:08] <MikeSmith> will do it right now
  75. # [11:10] <MikeSmith> gsnedders: OK, I made you an admin
  76. # [11:10] <gsnedders> MWHAHAHA, I HAVE THE POWER.
  77. # [11:10] <MikeSmith> or at least, you should get an invitation
  78. # [11:10] <MikeSmith> heh
  79. # [11:10] <gsnedders> oh, sorry
  80. # [11:10] <gsnedders> I think the little devil on my shoulder wants out.
  81. # [11:10] <MikeSmith> please don't do any crazy shit that will make Ms2ger and jgraham kill me for having given you the keys
  82. # [11:11] <MikeSmith> you got your own devil
  83. # [11:11] <MikeSmith> cool
  84. # [11:11] <gsnedders> I got it back in my FreeBSD days
  85. # [11:14] <MikeSmith> heh
  86. # [11:43] * Joins: playjax (~chatzilla@public.cloak)
  87. # [11:49] * Quits: dom (dom@public.cloak) ("")
  88. # [11:53] * Joins: dom (dom@public.cloak)
  89. # [12:05] * Joins: rego (~smuxi@public.cloak)
  90. # [12:05] * Quits: playjax (~chatzilla@public.cloak) (Client closed connection)
  91. # [12:18] * Joins: gamekathu (~smuxi@public.cloak)
  92. # [12:36] * Joins: Ms2ger (~Ms2ger@public.cloak)
  93. # [12:38] * Joins: playjax (~chatzilla@public.cloak)
  94. # [12:45] * Joins: ArtB (~ArtB@public.cloak)
  95. # [13:36] <Ms2ger> MikeSmith, thanks :)
  96. # [13:37] * Joins: hgl_ (~hgl@public.cloak)
  97. # [13:40] * Quits: hgl (~hgl@public.cloak) (Ping timeout: 180 seconds)
  98. # [14:20] * Joins: zcorpan (~zcorpan@public.cloak)
  99. # [14:28] * Quits: hgl_ (~hgl@public.cloak) (hgl_)
  100. # [14:29] * Joins: hgl (~hgl@public.cloak)
  101. # [14:30] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
  102. # [14:31] * Quits: Ms2ger (~Ms2ger@public.cloak) (Ping timeout: 180 seconds)
  103. # [14:38] * Joins: rego (~smuxi@public.cloak)
  104. # [14:49] * Quits: dom (dom@public.cloak) ("")
  105. # [14:49] * Joins: dom (dom@public.cloak)
  106. # [14:55] * Quits: rego (~smuxi@public.cloak) (Ping timeout: 180 seconds)
  107. # [14:57] * Joins: rego (~smuxi@public.cloak)
  108. # [14:59] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
  109. # [15:06] * Joins: rego (~smuxi@public.cloak)
  110. # [15:08] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
  111. # [15:15] * Joins: rego (~smuxi@public.cloak)
  112. # [15:17] * Quits: hgl (~hgl@public.cloak) (hgl)
  113. # [15:17] * Joins: hgl (~hgl@public.cloak)
  114. # [15:17] * Joins: plh (plehegar@public.cloak)
  115. # [15:20] <majidvp> I have a pull request for a new test for scroll restoration order. Being my first pull request I want to make sure nothing is missing: https://github.com/w3c/web-platform-tests/pull/2103
  116. # [15:21] * Quits: playjax (~chatzilla@public.cloak) (Client closed connection)
  117. # [15:21] <majidvp> jgraham: ^^ this is based on your suggestion here https://lists.w3.org/Archives/Public/public-whatwg-archive/2015Aug/0017.html
  118. # [15:25] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
  119. # [15:31] * Joins: renyan (~renyan@public.cloak)
  120. # [15:32] * Joins: rego (~smuxi@public.cloak)
  121. # [15:32] * Parts: renyan (~renyan@public.cloak)
  122. # [15:36] <MikeSmith> majidvp: sorry that nobody's responded to that yet, but the response time on getting reviews is not always super-fast
  123. # [15:36] <MikeSmith> majidvp: but it's 100% OK to ping people to ask for review
  124. # [15:37] <MikeSmith> e.g., here, as you've just done :)
  125. # [15:41] <jgraham> Also today is a holiday in the UK
  126. # [15:41] <jgraham> majidvp: Thanks!
  127. # [15:41] <jgraham> I'll take a look
  128. # [15:41] <majidvp> Sounds good. To be fair, there was a note in docs that review may take a while. Just wanted to be sure I have not missed something and it is in a queue.
  129. # [15:42] <majidvp> jgraham: It is nothing urgent. Please take you time and enjoy your holiday.
  130. # [16:09] * Quits: hgl (~hgl@public.cloak) (hgl)
  131. # [16:09] * Joins: hgl (~hgl@public.cloak)
  132. # [16:11] * Joins: zcorpan_ (~zcorpan@public.cloak)
  133. # [16:17] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  134. # [16:23] * Joins: zcorpan (~zcorpan@public.cloak)
  135. # [16:28] * Quits: zcorpan_ (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  136. # [16:39] * Quits: hgl (~hgl@public.cloak) (hgl)
  137. # [16:39] * Joins: hgl (~hgl@public.cloak)
  138. # [16:50] * Quits: hgl (~hgl@public.cloak) (hgl)
  139. # [16:50] * Joins: hgl (~hgl@public.cloak)
  140. # [17:14] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
  141. # [17:18] * Joins: jyasskin (~textual@public.cloak)
  142. # [17:21] * Joins: rego (~smuxi@public.cloak)
  143. # [17:23] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
  144. # [17:32] * Joins: rego (~smuxi@public.cloak)
  145. # [17:39] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
  146. # [17:47] * Joins: rego (~smuxi@public.cloak)
  147. # [17:51] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
  148. # [18:00] * Joins: rego (~smuxi@public.cloak)
  149. # [18:00] * Quits: dom (dom@public.cloak) ("")
  150. # [18:00] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
  151. # [18:03] <gsnedders> How do I get a PR on http://w3c-test.org/submissions/?
  152. # [18:04] <gsnedders> "Pull requests that have been checked are automatically mirrored to http://w3c-test.org/submissions/." — how do we mark it as checked?
  153. # [18:09] * Joins: rego (~smuxi@public.cloak)
  154. # [18:11] * Joins: bhill2 (~bhill2@public.cloak)
  155. # [18:45] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  156. # [19:18] <MikeSmith> gsnedders: those are just Web-mirrored copies
  157. # [19:18] <MikeSmith> gsnedders: you can add a line to your .git/config
  158. # [19:18] <MikeSmith> like this:
  159. # [19:18] <MikeSmith> [remote "origin"] url = git@github.com:w3c/web-platform-tests.git fetch = +refs/heads/*:refs/remotes/origin/* fetch = +refs/pull/*/head:refs/remotes/origin/pr/*
  160. # [19:18] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
  161. # [19:19] <MikeSmith> oofs
  162. # [19:19] <MikeSmith> [remote "origin"] url = git@github.com:w3c/web-platform-tests.git fetch = +refs/heads/*:refs/remotes/origin/* fetch = +refs/pull/*/head:refs/remotes/origin/pr/*
  163. # [19:19] <MikeSmith> hmm
  164. # [19:21] <MikeSmith> [remote "origin"] url = git@github.com:w3c/web-platform-tests.git fetch = +refs/heads/*:refs/remotes/origin/* fetch = +refs/pull/*/head:refs/remotes/origin/pr/*
  165. # [19:21] <MikeSmith> well
  166. # [19:22] <MikeSmith> gsnedders: just add `fetch = +refs/pull/*/head:refs/remotes/origin/pr/*` to the end of your [remote "origin"] section
  167. # [19:22] <MikeSmith> (or whatever you else you may have named it)
  168. # [19:22] <MikeSmith> then pull
  169. # [19:23] <MikeSmith> then you can checkout a pr branch just but doing "git checkout pr/nnnn"
  170. # [19:23] <MikeSmith> ph
  171. # [19:23] <MikeSmith> oh
  172. # [19:23] <MikeSmith> nm
  173. # [19:23] <MikeSmith> you were asking a different question...
  174. # [19:24] <MikeSmith> gsnedders: I think maybe I have to add you to a certain other team
  175. # [19:26] * Joins: rego (~smuxi@public.cloak)
  176. # [19:30] <MikeSmith> gsnedders: http://w3c-test.org/submissions/2124/ is there now
  177. # [19:35] * Joins: Lachy (~Lachy@public.cloak)
  178. # [19:35] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
  179. # [19:35] * Quits: Lachy (~Lachy@public.cloak) ("Textual IRC Client: www.textualapp.com")
  180. # [19:35] * Joins: Lachy (~Lachy@public.cloak)
  181. # [19:35] * Quits: Lachy (~Lachy@public.cloak) ("Textual IRC Client: www.textualapp.com")
  182. # [19:45] * Joins: rego (~smuxi@public.cloak)
  183. # [19:45] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
  184. # [19:46] * Joins: zcorpan (~zcorpan@public.cloak)
  185. # [19:46] <gsnedders> MikeSmith: that's the question I was asking :P
  186. # [19:49] * Joins: Ms2ger (~Ms2ger@public.cloak)
  187. # [19:51] <gsnedders> but hey, you got there in the end :P
  188. # [19:53] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  189. # [19:54] * Joins: rego (~smuxi@public.cloak)
  190. # [19:59] <Ms2ger> gsnedders, there's also "w3c-test:mirror" which can be used in a comment to mirror PRs from untrusted people
  191. # [19:59] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
  192. # [20:03] <gsnedders> what happened to Philip`'s canvas tests? are they all gone now, replaced by others?
  193. # [20:05] <MikeSmith> gsnedders: 2dcontext dir
  194. # [20:06] <MikeSmith> http://w3c-test.org/2dcontext/
  195. # [20:06] <gsnedders> ah, takk
  196. # [20:07] <Ms2ger> Also some under canvas
  197. # [20:07] * Joins: rego (~smuxi@public.cloak)
  198. # [20:07] <gsnedders> but those aren't Philip`'s, right?
  199. # [20:10] <gsnedders> is there any easy way to get a list of tests and test type?
  200. # [20:10] <Ms2ger> ./manifest
  201. # [20:11] <Ms2ger> Philip`'s are in there, but they're not uniquely Philip`s
  202. # [20:13] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
  203. # [20:20] * Joins: rego (~smuxi@public.cloak)
  204. # [20:26] * Quits: Ms2ger (~Ms2ger@public.cloak) (Ping timeout: 180 seconds)
  205. # [20:30] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
  206. # [20:37] * Joins: rego (~smuxi@public.cloak)
  207. # [20:39] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
  208. # [20:45] * Joins: zcorpan (~zcorpan@public.cloak)
  209. # [20:46] * Joins: rego (~smuxi@public.cloak)
  210. # [20:48] * Joins: zcorpan_ (~zcorpan@public.cloak)
  211. # [20:52] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  212. # [20:59] * Quits: jyasskin (~textual@public.cloak) ("My computer has gone to sleep. ZZZzzz…")
  213. # [21:14] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
  214. # [21:21] * Joins: rego (~smuxi@public.cloak)
  215. # [21:31] * Joins: zcorpan (~zcorpan@public.cloak)
  216. # [21:32] * Quits: zcorpan_ (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  217. # [21:35] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
  218. # [21:38] * Joins: zcorpan_ (~zcorpan@public.cloak)
  219. # [21:38] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  220. # [21:42] * Joins: rego (~smuxi@public.cloak)
  221. # [21:43] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
  222. # [21:51] * Joins: rego (~smuxi@public.cloak)
  223. # [21:59] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
  224. # [22:06] * Joins: rego (~smuxi@public.cloak)
  225. # [22:12] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
  226. # [22:19] * Joins: rego (~smuxi@public.cloak)
  227. # [22:20] * Quits: plh (plehegar@public.cloak) ("Leaving")
  228. # [22:24] <bhill2> is there a reason why method matters for retrieving static resources?
  229. # [22:25] <bhill2> e.g. why a POST to http://web-platform.test:8000/content-security-policy/support/fail.png is 404, but a GET is 200?
  230. # [22:25] <bhill2> and any way to change that?
  231. # [22:29] * Quits: gamekathu (~smuxi@public.cloak) (Client closed connection)
  232. # [22:59] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
  233. # [23:01] <bhill2> POST seems to route to PythonScriptHandler instead of FileHandler in this case...
  234. # [23:06] * Joins: zcorpan (~zcorpan@public.cloak)
  235. # [23:06] * Joins: rego (~smuxi@public.cloak)
  236. # [23:09] <jgraham> bhill2: Why would a POST GET the resource?
  237. # [23:09] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
  238. # [23:09] <jgraham> That seems like a misunderstanding of HTTP
  239. # [23:12] * Quits: zcorpan_ (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  240. # [23:13] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  241. # [23:16] <bhill2> why wouldn't it?
  242. # [23:17] * Joins: rego (~smuxi@public.cloak)
  243. # [23:19] <bhill2> isn't the standard configuration for pretty much every other webserver int he world to return a static resource for both GET and POST?
  244. # [23:19] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
  245. # [23:20] <jgraham> I don't think so
  246. # [23:20] <jgraham> Empirically google.com doesn't work like that, for example
  247. # [23:20] <bhill2> I have a bog standard Apache config on my site at http://webappsec-test.info/, POST returns the same as GET for static resources.
  248. # [23:20] <bhill2> http://w3.org/ works like that
  249. # [23:21] <jgraham> Anyway, I don't see a compelling reason for wptserve to work like that
  250. # [23:22] <bhill2> so... can we document that it works that way, and what resource types are valid for POST?
  251. # [23:22] <bhill2> what do I need to have to receive a POST?
  252. # [23:23] <jgraham> A python script
  253. # [23:24] <jgraham> If you want to put a script that can recieve a POST and return a specified file in /common, that seems quite OK
  254. # [23:24] <bhill2> ok
  255. # [23:24] <jgraham> https://github.com/w3c/wpt-tools/blob/master/serve/serve.py#L88 is what works by default
  256. # [23:24] <bhill2> thanks
  257. # [23:32] * Joins: rego (~smuxi@public.cloak)
  258. # [23:33] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
  259. # [23:34] * Quits: bhill2 (~bhill2@public.cloak) (Client closed connection)
  260. # [23:41] * Joins: rego (~smuxi@public.cloak)
  261. # Session Close: Tue Sep 01 00:00:00 2015

Previous day, Next day

Think these logs are useful? Then please donate to show your gratitude (and keep them up, of course). Thanks! — Krijn