Options:
Previous day, Next day
- # Session Start: Mon Oct 05 00:00:00 2015
- # Session Ident: #testing
- # [00:42] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
- # [04:06] * Quits: ArtB (~ArtB@public.cloak) ("Leaving.")
- # [07:25] * Joins: gitbot (~gitbot@public.cloak)
- # [07:25] -gitbot:#testing- [web-platform-tests] kojiishi opened pull request #2216: Fix resource URLs for testharness in 3 shadow-dom tests (master...shadow-issue-2215) https://github.com/w3c/web-platform-tests/pull/2216
- # [07:25] * Parts: gitbot (~gitbot@public.cloak)
- # [08:28] * Joins: bhill2 (~bhill2@public.cloak)
- # [08:43] * Joins: gitbot (~gitbot@public.cloak)
- # [08:43] -gitbot:#testing- [web-platform-tests] TakayoshiKochi closed pull request #2216: Fix resource URLs for testharness in 3 shadow-dom tests (master...shadow-issue-2215) https://github.com/w3c/web-platform-tests/pull/2216
- # [08:43] * Parts: gitbot (~gitbot@public.cloak)
- # [08:45] * Joins: zcorpan (~zcorpan@public.cloak)
- # [09:19] * Joins: dom (dom@public.cloak)
- # [09:59] * heycam|away is now known as heycam
- # [10:03] * heycam is now known as heycam|away
- # [10:07] * Joins: Ms2ger (~Ms2ger@public.cloak)
- # [10:09] * Joins: rego (~smuxi@public.cloak)
- # [10:27] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [10:34] * Joins: rego (~smuxi@public.cloak)
- # [11:29] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [11:37] * Joins: rego (~smuxi@public.cloak)
- # [11:52] * Joins: ArtB (~ArtB@public.cloak)
- # [13:23] * Quits: Ms2ger (~Ms2ger@public.cloak) (Ping timeout: 180 seconds)
- # [13:33] * Joins: Ms2ger (~Ms2ger@public.cloak)
- # [13:49] * Joins: plh (plehegar@public.cloak)
- # [15:01] <MikeSmith> Ms2ger: when you have time, can you please take a look at https://github.com/w3c/web-platform-tests/pull/271 and let me know what you think we should do with that at this point
- # [15:05] <jgraham> MikeSmith: Ugh
- # [15:06] <Ms2ger> MikeSmith, I don't think it makes much sense to have tests for specific interfaces under webidl/
- # [15:07] <gsnedders> I agree with Ms2ger.
- # [15:08] <MikeSmith> ok well it sounds like we don't want those tests in the repo
- # [15:08] <gsnedders> Ms2ger: am writing some argument on csswg-test #911
- # [15:08] <MikeSmith> should we close out that PR?
- # [15:09] <MikeSmith> or put a comment, "We have not plans to merge these tests into master."
- # [15:09] <Ms2ger> I'm not sure
- # [15:09] <MikeSmith> ok, I guess it doesn't cost us anything to keep it open
- # [15:10] <jgraham> Ih, why would we have an open PR that we didn't plan to merge?
- # [15:10] <jgraham> *Uh
- # [15:11] <Ms2ger> Because the tests are probably useful, though not in the right place
- # [15:11] <Ms2ger> If it was in the w3c repo, it'd be easy to remove tests from the branch as we add them where they belong
- # [15:12] <jgraham> That sounds like an issue and a branch, but not a PR
- # [15:12] <MikeSmith> we have plenty of other open PRs that are 1 year or 2 years old now, which I think also are effectively "no plan to merge this" PRs
- # [15:12] <jgraham> I don't think they are
- # [15:12] <jgraham> Well some of them are probably dead, but actually some I think we should just merge
- # [15:13] <Ms2ger> Maybe a better solution is an issue with checkboxes for each of those tests
- # [15:15] <gsnedders> I was going to go through all of them at some point, BTW
- # [15:15] <gsnedders> I think a lot of them are things where the person who opened it hasn't responded to feedback on tests
- # [15:16] <jgraham> Yeah, that is a problem with a lot of the TestTWF ones
- # [15:16] <MikeSmith> yeah
- # [15:16] <jgraham> And my DOMParsing tests :(
- # [15:17] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [15:17] <jgraham> Well actually the problem there is that they weren't all mine in the first place. And also I was lazy
- # [15:17] <jgraham> Oh and there were multiple specs
- # [15:17] <jgraham> So many excuses
- # [15:17] <jgraham> anyway there are some big testsuites that I thik we could just land and deal with the fallout
- # [15:18] <jgraham> rather than leave them to rot as PRs
- # [15:24] * Joins: rego (~smuxi@public.cloak)
- # [15:26] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [15:33] * Joins: rego (~smuxi@public.cloak)
- # [15:34] * Joins: gitbot (~gitbot@public.cloak)
- # [15:34] -gitbot:#testing- [csswg-test] frivoal opened pull request #914: Tests for focus :focus-within (master...focus-within) https://github.com/w3c/csswg-test/pull/914
- # [15:34] * Parts: gitbot (~gitbot@public.cloak)
- # [15:34] * Joins: gitbot (~gitbot@public.cloak)
- # [15:34] -gitbot:#testing- [csswg-test] frivoal closed pull request #881: [selectors-4] focus-within tests for basic DOM tree and shadow DOM. (master...master) https://github.com/w3c/csswg-test/pull/881
- # [15:34] * Parts: gitbot (~gitbot@public.cloak)
- # [15:35] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [15:42] * Joins: rego (~smuxi@public.cloak)
- # [15:42] <gsnedders> Is closing the PR helpful, though?
- # [15:42] <gsnedders> I'm not convinced it helps anyone.
- # [15:44] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [15:44] <jgraham> It helps the impression that it's not worth contributing because your PR will be left to rot
- # [15:45] <jgraham> I mean it's an epsilon change there, but still
- # [15:45] <gsnedders> jgraham: are the awaiting-submitter-response labels not good enough for that?
- # [15:46] <jgraham> gsnedders: I imagine there is a set of people who just look at the number of open PRs and go "oh these people don't respond to review requests, I won't bother making a test"
- # [15:46] <gsnedders> jgraham: do you have any evidence for this?
- # [15:46] <jgraham> Well I occasionally hear people ask why we have so many open PRs
- # [15:46] <gsnedders> jgraham: I'm worried about making the closed PRs hard to find if anyone *does* want to fix them up and get them merged
- # [15:47] <jgraham> But it seems like the decision here was that this branch isn't something that will ever merge as-is
- # [15:47] <jgraham> It needs to be entirely refactored
- # [15:47] <gsnedders> I mean I guess if I can just search for is:pr label:awaiting-submitter-response it'll do, provided we only have closed stuff with that label that was closed because dead.
- # [15:47] <gsnedders> yeah, but that's that branch, not all the others
- # [15:47] <jgraham> I'm not saying we should close everything old
- # [15:48] <jgraham> But things that need a fundamental change, are probably better off as an issue + a branch so that the work can be picked up as a GFB or something
- # [15:48] <jgraham> and done piecemeal
- # [15:48] <jgraham> -,
- # [15:49] <gsnedders> OK, that I agree with.
- # [15:51] <jgraham> gsnedders: Speaking of large PRs, there seem to be 3 open issues on your XPath tests
- # [15:51] <jgraham> s/3/2/
- # [15:51] * Joins: rego (~smuxi@public.cloak)
- # [15:53] <gsnedders> Um, uh
- # [15:53] <gsnedders> Yeah, I seem to have forgotten that. Will do.
- # [15:54] <jgraham> https://critic.hoppipolla.co.uk/r/282 seems like a classic example of something we should just clean up minimally and land. Make it pass the lint and nothing more. When the tests turn out to be bogus fix them.
- # [15:55] <gsnedders> I thought we knew the tests were bogus?
- # [15:56] <jgraham> But we also know that no one is going to review them
- # [15:57] <jgraham> OTOH I bet that landing them and woking on the code in Servo would get the bogusness ironed out
- # [15:57] <jgraham> Ms2ger: Thoughts ^
- # [15:57] <gsnedders> True. :)
- # [15:59] <gsnedders> https://critic.hoppipolla.co.uk/r/5798 — r?
- # [15:59] <gsnedders> tiny change toa ddress comments
- # [16:03] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [16:08] * Joins: gitbot (~gitbot@public.cloak)
- # [16:08] -gitbot:#testing- [web-platform-tests] gsnedders closed pull request #2146: Import Opera XPath tests. (master...opera_xpath_2) https://github.com/w3c/web-platform-tests/pull/2146
- # [16:08] * Parts: gitbot (~gitbot@public.cloak)
- # [16:10] * Joins: rego (~smuxi@public.cloak)
- # [16:14] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [16:18] <jgraham> Sigh
- # [16:18] <jgraham> gsnedders: I tried to make a small update to the navigation PR and it turns out that it's in your repo
- # [16:18] <jgraham> So I can't push
- # [16:21] * Joins: rego (~smuxi@public.cloak)
- # [16:22] <Ms2ger> Address the review comments I made on the one test I looked at?
- # [16:22] <jgraham> I can't!
- # [16:23] <gsnedders> jgraham: want me to push it to wpt in some branch?
- # [16:24] <jgraham> gsnedders: Well that still doesn't help because then we need a whole new PR
- # [16:24] <gsnedders> Oh bah :\
- # [16:24] <gsnedders> Github sucks at times.
- # [16:24] <jgraham> Yes
- # [16:24] <gsnedders> jgraham: Open a PR on my repo? :P
- # [16:26] <jgraham> it's probably faster for your to just do the work yourself :p The rebase will lead to two filename conflicts that you can solve however. Then passing the lint seems to be changing the line endings in one file + whatver Ms2ger wanted.
- # [16:26] <gsnedders> jgraham: filename conflicts are a pain, no?
- # [16:27] <gsnedders> jgraham: also gosh you realise I should actually /work/? :P
- # [16:28] <Ms2ger> Or you could give jgraham push access
- # [16:28] <jgraham> gsnedders: The filename conflicts aren't a pain. Thinking of a new filename for the tests in the PR is the hardest part
- # [16:28] <jgraham> But also, what Ms2ger said
- # [16:29] * gsnedders clumsily looks around github
- # [16:29] <gsnedders> You're jgraham, right?
- # [16:29] <gsnedders> Yes, you are.
- # [16:29] <gsnedders> jgraham: you have push access
- # [16:31] <jgraham> Takk
- # [16:31] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
- # [16:31] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [16:32] * Joins: zcorpan (~zcorpan@public.cloak)
- # [16:34] <gsnedders> jgraham: btw, how far behind are you on Critic? You up to date?
- # [16:34] <gsnedders> jgraham: if I start making patches upstream, will they reach your server?
- # [16:34] <jgraham> gsnedders: hahahahaha
- # [16:34] <Ms2ger> hahahahahaha
- # [16:34] * gsnedders takes that as a "no"
- # [16:35] <Ms2ger> It's hopelessly forked at this point
- # [16:36] <gsnedders> So if I send PRs on both jgraham and jenskl's repo I might win?
- # [16:37] <Ms2ger> jgraham has a repo now?
- # [16:38] * Joins: rego (~smuxi@public.cloak)
- # [16:40] <gsnedders> I thought he used to. Bah. :\
- # [16:41] <gsnedders> So how do I get anything onto hoppolita?
- # [16:45] * Quits: bhill2 (~bhill2@public.cloak) (Ping timeout: 180 seconds)
- # [16:45] <jgraham> First register that domain name…
- # [16:45] <gsnedders> pff, you and your Icelandic
- # [16:48] <gsnedders> jgraham: are you gonna do all the work to land op_parsing?
- # [16:50] <jgraham> gsnedders: op_parsing? Do you mean op_browsing?
- # [16:50] <gsnedders> bah, yes
- # [16:50] <jgraham> gsnedders: I seem to be looking at it
- # [17:06] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [17:13] * Joins: rego (~smuxi@public.cloak)
- # [17:16] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [17:19] * Joins: bhill2 (~bhill2@public.cloak)
- # [17:24] * Joins: rego (~smuxi@public.cloak)
- # [17:29] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [17:36] <jgraham> OK, I think the op_browsing stuff should now be landable
- # [17:37] * Joins: rego (~smuxi@public.cloak)
- # [17:37] <Ms2ger> Then land it :)
- # [17:41] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [17:42] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
- # [17:48] * Joins: gitbot (~gitbot@public.cloak)
- # [17:48] -gitbot:#testing- [web-platform-tests] jgraham closed pull request #304: Add whole load of tests for "Loading Web Pages". (master...op_browsing) https://github.com/w3c/web-platform-tests/pull/304
- # [17:48] * Parts: gitbot (~gitbot@public.cloak)
- # [17:48] * jgraham lit the blue touch paper
- # [17:48] * Joins: rego (~smuxi@public.cloak)
- # [17:51] * Quits: dom (dom@public.cloak) ("")
- # [17:54] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [17:56] <Ms2ger> jgraham, wanna update the servo copy? :)
- # [18:03] * Joins: rego (~smuxi@public.cloak)
- # [18:04] <gsnedders> And then get jgraham to fix them and file more bugs on the spec when it turns out the spec still doesn't work with real websites
- # [18:10] * Quits: Ms2ger (~Ms2ger@public.cloak) (Ping timeout: 180 seconds)
- # [18:10] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [18:13] * Joins: gitbot (~gitbot@public.cloak)
- # [18:13] -gitbot:#testing- [web-platform-tests] jgraham created sync_5838fda47464d1a1f6c36db216f17305f4308703 (+1 new commit): https://github.com/w3c/web-platform-tests/commit/5838fda47464
- # [18:13] -gitbot:#testing- web-platform-tests/sync_5838fda47464d1a1f6c36db216f17305f4308703 5838fda Corey Farwell: Implement <option> 'defaultSelected' and 'selected' attributes...
- # [18:13] * Parts: gitbot (~gitbot@public.cloak)
- # [18:13] * Joins: gitbot (~gitbot@public.cloak)
- # [18:13] -gitbot:#testing- [web-platform-tests] jgraham closed pull request #2219: Implement <option> 'defaultSelected' and 'selected' attributes (master...sync_5838fda47464d1a1f6c36db216f17305f4308703) https://github.com/w3c/web-platform-tests/pull/2219
- # [18:13] * Parts: gitbot (~gitbot@public.cloak)
- # [18:13] * Joins: gitbot (~gitbot@public.cloak)
- # [18:13] -gitbot:#testing- [web-platform-tests] jgraham deleted sync_5838fda47464d1a1f6c36db216f17305f4308703 at 5838fda: https://github.com/w3c/web-platform-tests/commit/5838fda
- # [18:13] * Parts: gitbot (~gitbot@public.cloak)
- # [18:13] * Joins: gitbot (~gitbot@public.cloak)
- # [18:13] -gitbot:#testing- [web-platform-tests] jgraham created sync_4c43f60d813e38183533c32f6b4d0b64f91756b0 (+1 new commit): https://github.com/w3c/web-platform-tests/commit/4c43f60d813e
- # [18:13] -gitbot:#testing- web-platform-tests/sync_4c43f60d813e38183533c32f6b4d0b64f91756b0 4c43f60 David Zbarsky: Implement HTMLTableRowElement::Cells...
- # [18:13] * Parts: gitbot (~gitbot@public.cloak)
- # [18:13] * Joins: gitbot (~gitbot@public.cloak)
- # [18:13] -gitbot:#testing- [web-platform-tests] jgraham closed pull request #2220: Implement HTMLTableRowElement::Cells (master...sync_4c43f60d813e38183533c32f6b4d0b64f91756b0) https://github.com/w3c/web-platform-tests/pull/2220
- # [18:13] * Parts: gitbot (~gitbot@public.cloak)
- # [18:13] * Joins: gitbot (~gitbot@public.cloak)
- # [18:13] -gitbot:#testing- [web-platform-tests] jgraham deleted sync_4c43f60d813e38183533c32f6b4d0b64f91756b0 at 4c43f60: https://github.com/w3c/web-platform-tests/commit/4c43f60
- # [18:13] * Parts: gitbot (~gitbot@public.cloak)
- # [18:13] * Joins: gitbot (~gitbot@public.cloak)
- # [18:13] -gitbot:#testing- [web-platform-tests] jgraham created sync_efed5f3ed79faa37719419537a7f5bbcd449117a (+1 new commit): https://github.com/w3c/web-platform-tests/commit/efed5f3ed79f
- # [18:13] -gitbot:#testing- web-platform-tests/sync_efed5f3ed79faa37719419537a7f5bbcd449117a efed5f3 Corey Farwell: HTMLTableSectionElement improvements...
- # [18:13] * Parts: gitbot (~gitbot@public.cloak)
- # [18:14] * Joins: gitbot (~gitbot@public.cloak)
- # [18:14] -gitbot:#testing- [web-platform-tests] jgraham closed pull request #2221: HTMLTableSectionElement improvements (master...sync_efed5f3ed79faa37719419537a7f5bbcd449117a) https://github.com/w3c/web-platform-tests/pull/2221
- # [18:14] * Parts: gitbot (~gitbot@public.cloak)
- # [18:14] * Joins: gitbot (~gitbot@public.cloak)
- # [18:14] -gitbot:#testing- [web-platform-tests] jgraham deleted sync_efed5f3ed79faa37719419537a7f5bbcd449117a at efed5f3: https://github.com/w3c/web-platform-tests/commit/efed5f3
- # [18:14] * Parts: gitbot (~gitbot@public.cloak)
- # [18:14] * Joins: gitbot (~gitbot@public.cloak)
- # [18:14] -gitbot:#testing- [web-platform-tests] jgraham opened pull request #2222: Implement Storage::SupportedPropertyNames (master...sync_cd1cf5f889f8d1b041c02c044a5a4208c25df86f) https://github.com/w3c/web-platform-tests/pull/2222
- # [18:14] * Parts: gitbot (~gitbot@public.cloak)
- # [18:14] * Joins: gitbot (~gitbot@public.cloak)
- # [18:14] -gitbot:#testing- [web-platform-tests] jgraham closed pull request #2222: Implement Storage::SupportedPropertyNames (master...sync_cd1cf5f889f8d1b041c02c044a5a4208c25df86f) https://github.com/w3c/web-platform-tests/pull/2222
- # [18:14] * Parts: gitbot (~gitbot@public.cloak)
- # [18:14] * Joins: gitbot (~gitbot@public.cloak)
- # [18:14] -gitbot:#testing- [web-platform-tests] jgraham deleted sync_cd1cf5f889f8d1b041c02c044a5a4208c25df86f at cd1cf5f: https://github.com/w3c/web-platform-tests/commit/cd1cf5f
- # [18:14] * Parts: gitbot (~gitbot@public.cloak)
- # [18:19] * Joins: rego (~smuxi@public.cloak)
- # [18:22] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [18:29] * Joins: rego (~smuxi@public.cloak)
- # [18:33] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [18:40] * Joins: rego (~smuxi@public.cloak)
- # [18:48] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [18:49] * Joins: zcorpan (~zcorpan@public.cloak)
- # [18:56] * Joins: rego (~smuxi@public.cloak)
- # [18:58] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [19:00] * Quits: bhill2 (~bhill2@public.cloak) (Client closed connection)
- # [19:02] * Joins: bhill2 (~bhill2@public.cloak)
- # [19:07] * Joins: rego (~smuxi@public.cloak)
- # [19:30] * Quits: bhill2 (~bhill2@public.cloak) (Client closed connection)
- # [19:35] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [19:44] * Joins: rego (~smuxi@public.cloak)
- # [19:58] * Joins: bhill2 (~bhill2@public.cloak)
- # [20:02] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
- # [20:32] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [20:39] * Joins: rego (~smuxi@public.cloak)
- # [20:41] * Joins: zcorpan (~zcorpan@public.cloak)
- # [20:43] * terri_offline is now known as terri
- # [20:43] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [20:46] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
- # [20:50] * Joins: rego (~smuxi@public.cloak)
- # [20:58] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [21:02] * Joins: zcorpan (~zcorpan@public.cloak)
- # [21:05] * Joins: rego (~smuxi@public.cloak)
- # [21:05] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [21:09] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
- # [21:14] * Joins: rego (~smuxi@public.cloak)
- # [21:20] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [21:27] * Joins: rego (~smuxi@public.cloak)
- # [21:29] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [21:36] * Joins: rego (~smuxi@public.cloak)
- # [21:38] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [21:45] * Joins: rego (~smuxi@public.cloak)
- # [21:47] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [21:48] * Quits: bhill2 (~bhill2@public.cloak) (Client closed connection)
- # [21:50] * Joins: bhill2 (~bhill2@public.cloak)
- # [21:52] * Quits: bhill2 (~bhill2@public.cloak) (Client closed connection)
- # [21:52] * Joins: bhill2 (~bhill2@public.cloak)
- # [21:54] * Joins: rego (~smuxi@public.cloak)
- # [22:02] * Joins: zcorpan (~zcorpan@public.cloak)
- # [22:10] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
- # [22:20] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [22:27] * Joins: rego (~smuxi@public.cloak)
- # [22:33] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [22:43] * Joins: rego (~smuxi@public.cloak)
- # [22:45] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [22:52] * Joins: rego (~smuxi@public.cloak)
- # [23:08] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [23:13] * Joins: simonstewart (~textual@public.cloak)
- # [23:15] * Joins: rego (~smuxi@public.cloak)
- # [23:17] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
- # [23:24] * Joins: rego (~smuxi@public.cloak)
- # Session Close: Tue Oct 06 00:00:00 2015
Previous day, Next day
Think these logs are useful? Then please donate to show your gratitude (and keep them up, of course). Thanks! — Krijn