/irc-logs / w3c / #testing / 2015-11-06 / end

Options:

Previous day, Next day

  1. # Session Start: Fri Nov 06 00:00:00 2015
  2. # Session Ident: #testing
  3. # [00:05] * Joins: evansjeny (~evansjeny@public.cloak)
  4. # [00:31] * terri is now known as terri_offline
  5. # [00:38] * terri_offline is now known as terri
  6. # [00:40] * heycam is now known as heycam|away
  7. # [00:51] * terri is now known as terri_offline
  8. # [01:01] * heycam|away is now known as heycam
  9. # [01:27] * Quits: evansjeny (~evansjeny@public.cloak) ("Page closed")
  10. # [01:32] * Joins: jyasskin (~textual@public.cloak)
  11. # [02:09] * Quits: plinss (~plinss@public.cloak) (Ping timeout: 180 seconds)
  12. # [02:18] * Joins: plinss (~plinss@public.cloak)
  13. # [02:36] * heycam is now known as heycam|away
  14. # [02:49] * terri_offline is now known as terri
  15. # [02:52] * Quits: plh (plehegar@public.cloak) ("Leaving")
  16. # [02:59] * terri is now known as terri_offline
  17. # [03:07] * Quits: jyasskin (~textual@public.cloak) ("My computer has gone to sleep. ZZZzzz…")
  18. # [03:39] * heycam|away is now known as heycam
  19. # [03:52] * Joins: gitbot (~gitbot@public.cloak)
  20. # [03:52] -gitbot:#testing- [csswg-test] syncbot created robust-get_new_commits at d5069a3 (+0 new commits): https://github.com/w3c/csswg-test/commits/robust-get_new_commits
  21. # [03:52] * Parts: gitbot (~gitbot@public.cloak)
  22. # [03:52] * Joins: gitbot (~gitbot@public.cloak)
  23. # [03:52] -gitbot:#testing- [csswg-test] syncbot created take-2 (+1 new commit): https://github.com/w3c/csswg-test/commit/6d53125d80f8
  24. # [03:52] -gitbot:#testing- csswg-test/take-2 6d53125 Chris Rebert: Try checking for the existence of .hg subdirectory...
  25. # [03:52] * Parts: gitbot (~gitbot@public.cloak)
  26. # [03:53] * Quits: ArtB (~ArtB@public.cloak) ("Leaving.")
  27. # [03:59] * Joins: ArtB (~ArtB@public.cloak)
  28. # [04:04] * Quits: ArtB (~ArtB@public.cloak) ("Leaving.")
  29. # [04:08] * Joins: gitbot (~gitbot@public.cloak)
  30. # [04:08] -gitbot:#testing- [testharness.js] DLehenbauer opened pull request #160: Issue #157: DOM hierarchy error with XHTML and SVG (master...fix-xhtml-svg-dom-hierarchy-error) https://github.com/w3c/testharness.js/pull/160
  31. # [04:08] * Parts: gitbot (~gitbot@public.cloak)
  32. # [04:42] * Joins: gitbot (~gitbot@public.cloak)
  33. # [04:42] -gitbot:#testing- [csswg-test] cvrebert deleted patch-1 at 0538f60: https://github.com/w3c/csswg-test/commit/0538f60
  34. # [04:42] * Parts: gitbot (~gitbot@public.cloak)
  35. # [04:42] * Joins: gitbot (~gitbot@public.cloak)
  36. # [04:42] -gitbot:#testing- [csswg-test] cvrebert deleted fix-submodules at 6b37cc6: https://github.com/w3c/csswg-test/commit/6b37cc6
  37. # [04:42] * Parts: gitbot (~gitbot@public.cloak)
  38. # [04:42] * Joins: gitbot (~gitbot@public.cloak)
  39. # [04:42] -gitbot:#testing- [csswg-test] cvrebert deleted seed-directory at dc0ab3f: https://github.com/w3c/csswg-test/commit/dc0ab3f
  40. # [04:42] * Parts: gitbot (~gitbot@public.cloak)
  41. # [05:03] * Joins: mixbabii (~mixbabii@public.cloak)
  42. # [05:09] * Quits: kochi (~kochi@public.cloak) (Ping timeout: 180 seconds)
  43. # [05:10] * Quits: kochi1 (~kochi@public.cloak) (Ping timeout: 180 seconds)
  44. # [05:18] * Joins: kochi (~kochi@public.cloak)
  45. # [05:20] * Joins: kochi1 (~kochi@public.cloak)
  46. # [05:31] * Quits: mixbabii (~mixbabii@public.cloak) (Ping timeout: 180 seconds)
  47. # [07:37] * heycam is now known as heycam|away
  48. # [08:29] * Joins: jyasskin (~textual@public.cloak)
  49. # [08:57] * Joins: zcorpan (~zcorpan@public.cloak)
  50. # [09:01] * Joins: rego (~smuxi@public.cloak)
  51. # [09:04] * Quits: jyasskin (~textual@public.cloak) ("My computer has gone to sleep. ZZZzzz…")
  52. # [09:07] * Quits: rego (~smuxi@public.cloak) (Client closed connection)
  53. # [09:14] * Joins: dom (dom@public.cloak)
  54. # [09:35] * Joins: Ms2ger (~Ms2ger@public.cloak)
  55. # [09:59] <Ms2ger> Whoa, a Gecko dev writing a csswg test: https://hg.mozilla.org/integration/mozilla-inbound/rev/97e3492d6080a0a3d2eda07a4e36208b92758469
  56. # [10:01] <jgraham> Miracles, they happen?
  57. # [11:02] <gsnedders> I thought that didn't happen?
  58. # [11:08] <AutomatedTester> would css-om tests be in wpt or csswg tests?
  59. # [11:08] <AutomatedTester> I am guessing the latter
  60. # [11:15] <gsnedders> the latter
  61. # [11:15] <gsnedders> if you're testing the a CSS WG spec, it should be in csswg-test
  62. # [11:20] <Ms2ger> AutomatedTester, though depending on how annoyed I am by the csswg, I could accept it into wpt too :)
  63. # [11:22] <AutomatedTester> Ms2ger: it's against zcorpan's spec and he is a nice chap so...
  64. # [11:26] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  65. # [11:28] * Joins: zcorpan (~zcorpan@public.cloak)
  66. # [11:34] <jgraham> You can ask zcorpan then :)
  67. # [11:35] <gsnedders> AutomatedTester: also I'm increasingly inclined to just take things into csswg-test and ask for forgiveness later
  68. # [11:35] <AutomatedTester> I can't find elementFromPoint specific tests
  69. # [11:36] <gsnedders> CSSOM ain't that well tested, so…
  70. # [11:36] <gsnedders> cssom-view-1/elementFromPosition.html
  71. # [11:45] <jgraham> https://github.com/w3c/web-platform-tests/issues/2304 fwiw
  72. # [11:48] <zcorpan> AutomatedTester: would be awesome with more cssom and cssom-view tests. i'll probably be writing tests myself as well over the next 12 months
  73. # [11:49] <zcorpan> AutomatedTester: i haven't really looked at the existing tests
  74. # [11:49] <AutomatedTester> zcorpan: where would you like them?
  75. # [11:49] <AutomatedTester> zcorpan: wpt or csswg tests?
  76. # [11:49] <AutomatedTester> zcorpan: I am looking to implement elementsFromPoint and want to know where to put tests
  77. # [11:50] <zcorpan> AutomatedTester: doesn't matter for me personally, but i suppose csswg makes more sense. i think tests in csswg also magically get linked in the spec itself with bikeshed (we should have that working for wpt too though)
  78. # [11:50] <AutomatedTester> ok
  79. # [11:50] <zcorpan> AutomatedTester: note that testharness.js can be used in csswg also AIUI
  80. # [11:50] <AutomatedTester> ok
  81. # [11:51] <zcorpan> feel free to ping me for review
  82. # [11:52] <jgraham> The main advantage of wpt is that it will be run in gecko
  83. # [11:52] <jgraham> But csswg test won't
  84. # [11:53] * Joins: ArtB (~ArtB@public.cloak)
  85. # [11:53] <jgraham> In order to fix that I probably need to make the wptrunner reftest harness faster in gecko; apparently the other reftest harness has some special magic
  86. # [11:53] <AutomatedTester> jgraham: if test_run: test_result = "pass" ?
  87. # [11:54] <AutomatedTester> that would make it super fast
  88. # [11:54] <AutomatedTester> :P
  89. # [12:19] * Joins: gitbot (~gitbot@public.cloak)
  90. # [12:19] -gitbot:#testing- [web-platform-tests] martiansideofthemoon opened pull request #2308: adding condition to run LastModified test (master...my-code-fix) https://github.com/w3c/web-platform-tests/pull/2308
  91. # [12:19] * Parts: gitbot (~gitbot@public.cloak)
  92. # [12:22] <gsnedders> jgraham: it's not entirely clear how to do so, given the differences. certainly some need complexity that the normal reftest runner can't provide.
  93. # [12:23] <gsnedders> (ofc that's treating the current reftest runner as an immutable, but I don't think there's any desire to add the complexity needed for cross-origin testing)
  94. # [12:26] <jgraham> gsnedders: I mainly mean in the way it gets the screenshots
  95. # [12:29] <gsnedders> does wptrunner not just use WebDriver?
  96. # [12:30] <jgraham> Yes, which paints to an internal canvas and converts to base64 and sends it back over the wire
  97. # [12:30] <jgraham> Apparently the reftest harness doesn't do that anymore, but does something faster
  98. # [12:30] <gsnedders> whereas you need to move the comparison of the two canvases into the browser
  99. # [12:30] <gsnedders> to match it for speed
  100. # [12:32] <AutomatedTester> webdriver only puts that on an internal canvas for gecko
  101. # [12:33] <AutomatedTester> webdriver does other horrifying things for other browsers
  102. # [12:33] <gsnedders> yeah, but the cost is sending it over the wire, primarily
  103. # [12:33] <jgraham> Well it looks like the reftest harness is also smart about reusing canvases rather than always building new ones
  104. # [12:34] <jgraham> I'm sure this is a possible optimisation but marionette will need to be taught about it
  105. # [12:40] * Joins: gitbot (~gitbot@public.cloak)
  106. # [12:40] -gitbot:#testing- [wptrunner] gsnedders opened pull request #155: Use glob on include/exclude paths (master...glob_paths) https://github.com/w3c/wptrunner/pull/155
  107. # [12:40] * Parts: gitbot (~gitbot@public.cloak)
  108. # [12:45] * Joins: gitbot (~gitbot@public.cloak)
  109. # [12:45] -gitbot:#testing- [wptrunner] jgraham closed pull request #155: Use glob on include/exclude paths (master...glob_paths) https://github.com/w3c/wptrunner/pull/155
  110. # [12:45] * Parts: gitbot (~gitbot@public.cloak)
  111. # [12:45] * Joins: gitbot (~gitbot@public.cloak)
  112. # [12:45] -gitbot:#testing- [wptrunner] jgraham pushed 2 new commits to master: https://github.com/w3c/wptrunner/compare/d1d81bd43763...de53aee43147
  113. # [12:45] -gitbot:#testing- wptrunner/master 1b2f9e6 Geoffrey Sneddon: Use glob on include/exclude paths.
  114. # [12:45] -gitbot:#testing- wptrunner/master de53aee jgraham: Merge pull request #155 from gsnedders/glob_paths...
  115. # [12:45] * Parts: gitbot (~gitbot@public.cloak)
  116. # [12:47] <gsnedders> wait is my patch not broken?
  117. # [12:47] <gsnedders> why does url only get set once in the loop?
  118. # [12:48] <gsnedders> I'm getting more and more confused by this code.
  119. # [12:49] <jgraham> Oh yes, your patch is broken
  120. # [12:49] <jgraham> I sohuld have paid attention to the part of my brain that said "this looks too easy"
  121. # [12:50] <gsnedders> I thought it looked too easy. But I couldn't work out why.
  122. # [12:52] <jgraham> So you can make it work
  123. # [12:53] <jgraham> Also I rather assumed you had tested it before making a PR
  124. # [12:53] <jgraham> Anyway try hoisting the glob out to where add_include is called
  125. # [12:53] <jgraham> If there any any matches, call add_include once for each match, otherwise call add_include with the raw argument
  126. # [12:54] <gsnedders> I had tested it and it appeared to work.
  127. # [12:54] <gsnedders> Which is the really weird part.
  128. # [12:54] <gsnedders> I can't justify how it worked.
  129. # [12:54] <jgraham> It's rather messy, but add_include really does only add one include
  130. # [12:55] <gsnedders> I don't get quite how this fits in with the URL parsing, tbh.
  131. # [12:55] <jgraham> What URL parsing?
  132. # [12:56] <gsnedders> _get_components, etc.
  133. # [12:56] <gsnedders> also the query/fragment special-casing in there
  134. # [12:57] <jgraham> You can have a test that requires a query string to set something
  135. # [12:57] <gsnedders> but does it only take relative URLs?
  136. # [12:58] <jgraham> Relative urls and paths
  137. # [12:58] <jgraham> Well "paths"
  138. # [12:58] <jgraham> path/to/tests/html/sometest.html?foo=bar is valid
  139. # [12:59] <jgraham> and it will strip the query
  140. # [12:59] <jgraham> find that path/to/tests/html/sometest.html is a file
  141. # [12:59] <gsnedders> also what's the expected behaviour of including path/? does *Everything* under path get run, or just the subset in the manifest?
  142. # [12:59] <jgraham> And that html/sometest.html?foo=bar is the test
  143. # [13:00] <jgraham> You can only ever run tests in the manifest
  144. # [13:00] <jgraham> That's rather the point
  145. # [13:00] <gsnedders> That's what I thought.
  146. # [13:00] <gsnedders> But then I included css-fonts-3 and it started trying to run all HTML, XHTMl, and XHTML Print variants of tests.
  147. # [13:01] <jgraham> Well they're all in the manifest
  148. # [13:01] <jgraham> try css-fonts-3/html
  149. # [13:01] <gsnedders> how do they get skipped?
  150. # [13:01] <gsnedders> or ignored?
  151. # [13:01] <jgraham> Servo has an include.ini file to specify the precise directories to run
  152. # [13:02] <jgraham> https://github.com/servo/servo/blob/master/tests/wpt/include_css.ini
  153. # [13:02] <gsnedders> k
  154. # [13:03] <jgraham> The whole code is more defensible if you realise it's basically trying to build that manifest file from the command line arguments
  155. # [13:03] <jgraham> Anyway, lunch
  156. # [13:10] <gsnedders> so what I want is someway to subset the normal include, I guess?
  157. # [13:22] * Joins: gitbot (~gitbot@public.cloak)
  158. # [13:22] -gitbot:#testing- [wptrunner] gsnedders opened pull request #156: Fix the previous commit to actually handle multiple URLs (master...glob_paths_fix) https://github.com/w3c/wptrunner/pull/156
  159. # [13:22] * Parts: gitbot (~gitbot@public.cloak)
  160. # [13:42] * Joins: gitbot (~gitbot@public.cloak)
  161. # [13:42] -gitbot:#testing- [wptrunner] jgraham closed pull request #156: Fix the previous commit to actually handle multiple URLs (master...glob_paths_fix) https://github.com/w3c/wptrunner/pull/156
  162. # [13:42] * Parts: gitbot (~gitbot@public.cloak)
  163. # [13:49] * Joins: fwtnb (~fwtnb@public.cloak)
  164. # [14:03] <gsnedders> "Font names containing any white space need to be quoted. It is also recognized if it is not quoted." — because explicit assertions are useful!
  165. # [15:27] <AutomatedTester> my fork of wpt is only 3.5k commits behind...
  166. # [15:29] <gsnedders> hah
  167. # [15:29] <gsnedders> I know that feel.
  168. # [15:44] * Joins: ShaneM (~ShaneM@public.cloak)
  169. # [15:44] * Quits: ShaneM (~ShaneM@public.cloak) (Client closed connection)
  170. # [15:46] * Joins: ShaneM (~ShaneM@public.cloak)
  171. # [15:54] * Quits: fwtnb (~fwtnb@public.cloak) (Client closed connection)
  172. # [15:58] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  173. # [16:04] * Joins: plh (plehegar@public.cloak)
  174. # [16:30] * Quits: ShaneM (~ShaneM@public.cloak) (Ping timeout: 180 seconds)
  175. # [16:58] * Joins: zcorpan (~zcorpan@public.cloak)
  176. # [17:06] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  177. # [17:08] * Joins: ShaneM (~ShaneM@public.cloak)
  178. # [17:17] * Joins: zcorpan (~zcorpan@public.cloak)
  179. # [17:18] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  180. # [17:58] * Joins: gitbot (~gitbot@public.cloak)
  181. # [17:58] -gitbot:#testing- [web-platform-tests] Ms2ger closed pull request #2306: Validate capture target authenticity (master...pointerevent-capture-target-authenticity) https://github.com/w3c/web-platform-tests/pull/2306
  182. # [17:58] * Parts: gitbot (~gitbot@public.cloak)
  183. # [17:58] * Joins: gitbot (~gitbot@public.cloak)
  184. # [17:58] -gitbot:#testing- [web-platform-tests] Ms2ger pushed 2 new commits to master: https://github.com/w3c/web-platform-tests/compare/2b817486a1b1...f581ba021596
  185. # [17:58] -gitbot:#testing- web-platform-tests/master 597e1ba Marius Stefan Bethge: pointerevents: validate capture target authenticity
  186. # [17:58] -gitbot:#testing- web-platform-tests/master f581ba0 Ms2ger: Merge pull request #2306 from bethge/pointerevent-capture-target-authenticity...
  187. # [17:58] * Parts: gitbot (~gitbot@public.cloak)
  188. # [17:58] * Joins: gitbot (~gitbot@public.cloak)
  189. # [17:58] -gitbot:#testing- [testharness.js] dontcallmedom created promise-throw (+1 new commit): https://github.com/w3c/testharness.js/commit/4676cbf3a77f
  190. # [17:58] -gitbot:#testing- testharness.js/promise-throw 4676cbf Dominique Hazael-Massieux: Adapt throw test for Promise-returning operations
  191. # [17:58] * Parts: gitbot (~gitbot@public.cloak)
  192. # [17:59] * Joins: gitbot (~gitbot@public.cloak)
  193. # [17:59] -gitbot:#testing- [testharness.js] dontcallmedom opened pull request #161: Adapt throw test for Promise-returning operations (master...promise-throw) https://github.com/w3c/testharness.js/pull/161
  194. # [17:59] * Parts: gitbot (~gitbot@public.cloak)
  195. # [18:12] * Joins: gitbot (~gitbot@public.cloak)
  196. # [18:12] -gitbot:#testing- [csswg-test] kojiishi pushed 1 new commit to master: https://github.com/w3c/csswg-test/commit/abaf54a8e7ec8969c9bd8e7b63fe5c1c759eedfd
  197. # [18:12] -gitbot:#testing- csswg-test/master abaf54a Koji Ishii: Fix line-box-height-vlr tests to use vlr as references...
  198. # [18:12] * Parts: gitbot (~gitbot@public.cloak)
  199. # [18:13] * Quits: Ms2ger (~Ms2ger@public.cloak) (Ping timeout: 180 seconds)
  200. # [18:23] * Joins: Ms2ger (~Ms2ger@public.cloak)
  201. # [18:39] * Quits: Ms2ger (~Ms2ger@public.cloak) ("nn")
  202. # [19:38] * Joins: jyasskin (~textual@public.cloak)
  203. # [19:44] * Quits: jyasskin (~textual@public.cloak) ("Textual IRC Client: www.textualapp.com")
  204. # [20:51] * Quits: ShaneM (~ShaneM@public.cloak) (Ping timeout: 180 seconds)
  205. # [21:58] * Joins: jyasskin (~textual@public.cloak)
  206. # [22:08] <AutomatedTester> I thought wpt got rid of the submodules...
  207. # [22:08] <AutomatedTester> I must have remembered incorrectly
  208. # [23:10] * Quits: dom (dom@public.cloak) (Ping timeout: 180 seconds)
  209. # [23:15] * Joins: gitbot (~gitbot@public.cloak)
  210. # [23:15] -gitbot:#testing- [web-platform-tests] AutomatedTester opened pull request #2309: [cssom-view] Add Element From Point tests (master...elementFromPoint) https://github.com/w3c/web-platform-tests/pull/2309
  211. # [23:15] * Parts: gitbot (~gitbot@public.cloak)
  212. # [23:27] * Quits: jyasskin (~textual@public.cloak) ("My computer has gone to sleep. ZZZzzz…")
  213. # Session Close: Sat Nov 07 00:00:00 2015

Previous day, Next day

Think these logs are useful? Then please donate to show your gratitude (and keep them up, of course). Thanks! — Krijn