/irc-logs / w3c / #testing / 2015-11-18 / end

Options:

Previous day, Next day

  1. # Session Start: Wed Nov 18 00:00:00 2015
  2. # Session Ident: #testing
  3. # [00:00] <jgraham> gsnedders: I don't understand what your concern is.
  4. # [00:25] <gsnedders> having multiple testsuites runs the risks that someone will end up only running one of them
  5. # [00:56] <jgraham> I still don't follow
  6. # [00:57] <jgraham> We add CSS to wpt. You run the the CSS tests with the wpt tests. Where is the problem?
  7. # [00:57] <jgraham> Oh, you mean "adding specific subsets of CSS to wpt"
  8. # [00:58] <jgraham> Well that could be solved by it being easier to run CSS tests in general
  9. # [00:59] <jgraham> If the choice is between actual real problems right now and hypothetical future problems, I'll take the latter
  10. # [01:03] * Quits: bhill2_ (~bhill2@public.cloak) (Client closed connection)
  11. # [02:33] * terri is now known as terri_offline
  12. # [02:44] * Joins: fwtnb (~fwtnb@public.cloak)
  13. # [02:55] * Quits: rniwa (~textual@public.cloak) ("My Mac has gone to sleep. ZZZzzz…")
  14. # [04:03] * Quits: hober (~ted@public.cloak) (Client closed connection)
  15. # [04:04] * Joins: hober (~ted@public.cloak)
  16. # [05:11] * Joins: rniwa (~textual@public.cloak)
  17. # [07:51] * Joins: gitbot (~gitbot@public.cloak)
  18. # [07:51] -gitbot:#testing- [csswg-test] kojiishi pushed 1 new commit to master: https://github.com/w3c/csswg-test/commit/b37376c8e9d12775da04ed774ab1fb8bd5e86986
  19. # [07:51] -gitbot:#testing- csswg-test/master b37376c Koji Ishii: [css-writing-modes-3] Add outline-inline-block-vrl-006...
  20. # [07:51] * Parts: gitbot (~gitbot@public.cloak)
  21. # [08:31] * Joins: Ms2ger (~Ms2ger@public.cloak)
  22. # [08:55] * Joins: zcorpan (~zcorpan@public.cloak)
  23. # [08:55] * Joins: rego (~rego@public.cloak)
  24. # [09:01] * Quits: rniwa (~textual@public.cloak) (Ping timeout: 180 seconds)
  25. # [09:03] * Joins: dom (dom@public.cloak)
  26. # [09:13] * Joins: gitbot (~gitbot@public.cloak)
  27. # [09:13] -gitbot:#testing- [web-platform-tests] annevk created noreferrer-cross-origin (+1 new commit): https://github.com/w3c/web-platform-tests/commit/3ef3a70bd468
  28. # [09:13] -gitbot:#testing- web-platform-tests/noreferrer-cross-origin 3ef3a70 Anne van Kesteren: rel=noreferrer cross-origin manual tests
  29. # [09:13] * Parts: gitbot (~gitbot@public.cloak)
  30. # [09:13] * Joins: gitbot (~gitbot@public.cloak)
  31. # [09:13] -gitbot:#testing- [web-platform-tests] annevk opened pull request #2354: rel=noreferrer cross-origin manual tests (master...noreferrer-cross-origin) https://github.com/w3c/web-platform-tests/pull/2354
  32. # [09:13] * Parts: gitbot (~gitbot@public.cloak)
  33. # [09:35] * Joins: gitbot (~gitbot@public.cloak)
  34. # [09:35] -gitbot:#testing- [web-platform-tests] Ms2ger opened pull request #2355: Remove reference to obsolete replaceWholeText method. (master...replaceWholeText) https://github.com/w3c/web-platform-tests/pull/2355
  35. # [09:35] * Parts: gitbot (~gitbot@public.cloak)
  36. # [09:45] <zcorpan> jgraham: href="//天気の良い日.{{location[host]}}/..." does seem nicer than {{domains[...]}}:{{ports[http][0]}}. the only reason i can think of where this would not work is if the test is itself run from a subdomain, but maybe we can assume that will not happen?
  37. # [09:46] * Parts: kochi1 (~kochi@public.cloak)
  38. # [09:47] * Quits: kochi (~kochi@public.cloak) ("Leaving.")
  39. # [09:49] <zcorpan> hmm i think i have my critic email settings backwards
  40. # [09:49] * Joins: kochi (~kochi@public.cloak)
  41. # [09:49] * Joins: kochi1 (~kochi@public.cloak)
  42. # [09:58] <zcorpan> is there a way to make critic not send emails for "new review"? but still send emails for updated reviews where i have reviewed?
  43. # [10:05] * Disconnected
  44. # [10:06] * Attempting to rejoin channel #testing
  45. # [10:06] * Rejoined channel #testing
  46. # [10:06] * Quits: fantasai (~fantasai@public.cloak) (Client closed connection)
  47. # [10:06] * Quits: krijnhoetmer (~krijnhoetmer@public.cloak) (Client closed connection)
  48. # [10:06] * Joins: zcorpan_ (~zcorpan@public.cloak)
  49. # [10:07] * Joins: ShaneM_ (~ShaneM@public.cloak)
  50. # [10:10] * Quits: ShaneM (~ShaneM@public.cloak) (Ping timeout: 180 seconds)
  51. # [10:10] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  52. # [10:11] * Joins: fantasai (~fantasai@public.cloak)
  53. # [10:22] * Joins: gitbot (~gitbot@public.cloak)
  54. # [10:22] -gitbot:#testing- [web-platform-tests] zcorpan closed pull request #2355: Remove reference to obsolete replaceWholeText method. (master...replaceWholeText) https://github.com/w3c/web-platform-tests/pull/2355
  55. # [10:22] * Parts: gitbot (~gitbot@public.cloak)
  56. # [10:25] <zcorpan_> reviewable.io huh
  57. # [10:32] * Joins: gitbot (~gitbot@public.cloak)
  58. # [10:32] -gitbot:#testing- [web-platform-tests] zcorpan closed pull request #2297: update form autocomplete tokens list (master...deniak/form-autocomplete-tokens) https://github.com/w3c/web-platform-tests/pull/2297
  59. # [10:32] * Parts: gitbot (~gitbot@public.cloak)
  60. # [10:33] * Joins: gitbot (~gitbot@public.cloak)
  61. # [10:33] -gitbot:#testing- [web-platform-tests] zcorpan deleted deniak/form-autocomplete-tokens at 3e3b90c: https://github.com/w3c/web-platform-tests/commit/3e3b90c
  62. # [10:33] * Parts: gitbot (~gitbot@public.cloak)
  63. # [10:34] <zcorpan_> it looks nice at least
  64. # [11:00] <jgraham> Is that still turned on?
  65. # [11:01] <jgraham> I thought I switched it off
  66. # [11:01] <jgraham> We certainly don't want three review systems, so we should make a decision one way or the other
  67. # [11:01] <jgraham> The main advantage of reviewable is that it handles rebases automatically
  68. # [11:02] <jgraham> In pretty much every other way it's less good, but maybe that's enough
  69. # [11:02] <Ms2ger> Hm
  70. # [11:03] <Ms2ger> I guess it stayed around on PRs from before you turned it off
  71. # [11:03] <jgraham> I kinda-sorta-maybe have a bot to @mention a list of reviewers depending on the paths changed
  72. # [11:04] <jgraham> By which I mean it worked once in a simple test, but needs more refinement
  73. # [12:05] * Joins: ArtB (~ArtB@public.cloak)
  74. # [12:48] * Joins: gitbot (~gitbot@public.cloak)
  75. # [12:48] -gitbot:#testing- [web-platform-tests] annevk created opener-cross-origin (+1 new commit): https://github.com/w3c/web-platform-tests/commit/a1564e828861
  76. # [12:48] -gitbot:#testing- web-platform-tests/opener-cross-origin a1564e8 Anne van Kesteren: Tests for navigating window.opener across origins
  77. # [12:48] * Parts: gitbot (~gitbot@public.cloak)
  78. # [12:48] * Joins: gitbot (~gitbot@public.cloak)
  79. # [12:48] -gitbot:#testing- [web-platform-tests] annevk opened pull request #2356: Tests for navigating window.opener across origins (master...opener-cross-origin) https://github.com/w3c/web-platform-tests/pull/2356
  80. # [12:48] * Parts: gitbot (~gitbot@public.cloak)
  81. # [13:50] * Joins: ShaneM (~ShaneM@public.cloak)
  82. # [13:50] * Quits: ArtB (~ArtB@public.cloak) ("Leaving.")
  83. # [13:50] * Quits: ShaneM_ (~ShaneM@public.cloak) (Ping timeout: 180 seconds)
  84. # [14:03] * Joins: plh (plehegar@public.cloak)
  85. # [14:41] * Joins: gitbot (~gitbot@public.cloak)
  86. # [14:41] -gitbot:#testing- [web-platform-tests] Ms2ger closed pull request #2345: Update some spec links in html/. (master...spec-html) https://github.com/w3c/web-platform-tests/pull/2345
  87. # [14:41] * Parts: gitbot (~gitbot@public.cloak)
  88. # [14:48] <AutomatedTester> zcorpan_: I did a PR for elementsFromPoint https://critic.hoppipolla.co.uk/r/5978 if you want to add it to your todo list :)
  89. # [14:50] <zcorpan_> AutomatedTester: nice
  90. # [15:03] <zcorpan_> AutomatedTester: reviewed
  91. # [15:03] * Quits: fwtnb (~fwtnb@public.cloak) (Client closed connection)
  92. # [15:04] <AutomatedTester> zcorpan_: thanks! I will try get to that later today
  93. # [15:41] * Quits: ShaneM (~ShaneM@public.cloak) (Ping timeout: 180 seconds)
  94. # [16:00] * Quits: hober (~ted@public.cloak) (Client closed connection)
  95. # [16:00] * Joins: hober (~ted@public.cloak)
  96. # [16:21] * Joins: ShaneM (~ShaneM@public.cloak)
  97. # [16:22] * Joins: ShaneM_ (~ShaneM@public.cloak)
  98. # [16:27] * Joins: gitbot (~gitbot@public.cloak)
  99. # [16:27] -gitbot:#testing- [csswg-test] kojiishi pushed 1 new commit to master: https://github.com/w3c/csswg-test/commit/e2f45697e11f7a300660c008bd331cc9f6f8885c
  100. # [16:27] -gitbot:#testing- csswg-test/master e2f4569 Koji Ishii: [css-writing-modes-3] Additional divs to outline-inline(-block)?-006...
  101. # [16:27] * Parts: gitbot (~gitbot@public.cloak)
  102. # [16:28] * Quits: ShaneM (~ShaneM@public.cloak) (Ping timeout: 180 seconds)
  103. # [16:29] * Quits: zcorpan_ (~zcorpan@public.cloak) (Client closed connection)
  104. # [17:17] <MikeSmith> I wonder if it's time we update the wpt docs/guidelines to suggest a "bring your own" reviewer best practice
  105. # [17:18] <MikeSmith> as in, if you are submitting tests here, ideally you have also identified a reviewer for them and gotten a commitment from that person to review the tests
  106. # [17:19] <MikeSmith> because right now it seems a lot of people who submit tests just assume they don't need to do anything more than submit them and wait for a reviewer to appear from somewhere
  107. # [17:20] <MikeSmith> or assume that the core reviewers are going to somehow acquire domain expertise sufficient to review their tests
  108. # [17:21] <dom> MikeSmith, I think one key disappointment is that WGs themselves don't provide contact points for reviewers
  109. # [17:21] <dom> maybe https://lists.w3.org/Archives/Public/public-test-infra/2015AprJun/0009.html could help there though
  110. # [17:21] <MikeSmith> yeah maybe so
  111. # [17:21] <dom> I think many WGs aren't even aware that there are pending pull requests that are relevant to them
  112. # [17:21] <MikeSmith> yeah
  113. # [17:22] <MikeSmith> right now I think we are collectively failing one another one this
  114. # [17:22] <dom> yep
  115. # [17:31] <jgraham> So one thing that zcorpan and I discussed was having a bot that would auto-cc people on the github PR
  116. # [17:32] <jgraham> and do it by path
  117. # [17:32] <jgraham> So if you touched /dom it would cc the whole dom group, that would include the people editing that spec and others who might review it
  118. # [17:32] <jgraham> Kind of like what critic does, but without expecting people to use critic
  119. # [17:33] <dom> jgraham, that's more or less what my tool does by email https://lists.w3.org/Archives/Public/public-test-infra/2015AprJun/0009.html (but on top of the per-wg labeling tool of tobie, if that still works)
  120. # [17:33] <jgraham> dom: Yeah, similar idea but I just dump a pile of @names in a comment
  121. # [17:34] <jgraham> (and don't base it on tobie's labels)
  122. # [17:34] <dom> yeah, that's a reasonable alternative
  123. # [17:34] <dom> where do you get the association between path and @names?
  124. # [17:35] <jgraham> There's a configuration file for that
  125. # [17:36] <jgraham> It's the "update with a PR" theory of the universe
  126. # [17:36] <jgraham> Which isn't a great theory, but there we go
  127. # [17:37] <dom> I like it enough; ideally we would harass groups responsible for specs that don't a matching set of reviewers
  128. # [17:37] <Ms2ger> Maybe this new "group" feature of github? Or does that imply granting push access?
  129. # [17:37] <Ms2ger> Maybe we should grant that anyway
  130. # [17:37] <jgraham> This isn't the group feature, but maybe it could be?
  131. # [17:38] * Joins: ShaneM (~ShaneM@public.cloak)
  132. # [17:38] <dom> what's the new group feature?
  133. # [17:38] <jgraham> Is it possible to opt a whole group at a time into notifications?
  134. # [17:38] * Quits: ShaneM_ (~ShaneM@public.cloak) (Ping timeout: 180 seconds)
  135. # [17:39] * Joins: ShaneM_ (~ShaneM@public.cloak)
  136. # [17:39] <jgraham> Is it the enterprise teams feature? Is that now in public?
  137. # [17:40] <Ms2ger> I think you can do @w3c/dom-reviewers, say
  138. # [17:40] <dom> oh really? neat
  139. # [17:40] <jgraham> That would make my life much easier
  140. # [17:40] <dom> "Use team @mentions (ex. @github/design for the entire team) in any comment, issue, or pull request."
  141. # [17:40] <jgraham> In that I could remove some complexity from the implementation (which I totally stole from highfive)
  142. # [17:40] <dom> (from https://github.com/orgs/w3c/teams )
  143. # [17:41] <Ms2ger> Or "cc @rust-lang/compiler"
  144. # [17:41] <dom> that does sound like a great match
  145. # [17:41] * Joins: gitbot (~gitbot@public.cloak)
  146. # [17:41] -gitbot:#testing- [web-platform-tests] r12a opened pull request #2357: Tests for dir attribute isolation (master...dir-isolation) https://github.com/w3c/web-platform-tests/pull/2357
  147. # [17:41] * Parts: gitbot (~gitbot@public.cloak)
  148. # [17:41] <jgraham> Yeah, this sounds good
  149. # [17:42] <jgraham> It leaves the problem of getting people into the teams ofc
  150. # [17:43] <dom> sure, although we could use a convention here
  151. # [17:43] <dom> (@path-reviewers for instance)
  152. # [17:43] <dom> but maybe that leads to too much duplication of teams
  153. # [17:44] <dom> any way, if we go that way, I'll be happy to find volunteers for reviewers for DAP and WebRTC specs
  154. # [17:44] <jgraham> I just meant ensuding that web-performance or whatever has a non-empty set of reviewers
  155. # [17:44] * Quits: ShaneM (~ShaneM@public.cloak) (Ping timeout: 180 seconds)
  156. # [17:45] <dom> I guess for that we can also use internal-staff coordination and "friendly" pressure :)
  157. # [17:45] <dom> many groups have adopted the notion of "test facilitators", so hopefully we would not start from zero either
  158. # [17:46] <dom> and maybe PRs for which there is no set reviewers should warn the submitters
  159. # [17:46] <jgraham> Yeah, this all seems possible
  160. # [17:47] <jgraham> Need to write more code :)
  161. # [17:48] * ShaneM_ is now known as ShaneM
  162. # [17:58] * Joins: zcorpan (~zcorpan@public.cloak)
  163. # [18:15] * Joins: bhill2 (~bhill2@public.cloak)
  164. # [18:27] * Quits: dom (dom@public.cloak) ("")
  165. # [18:45] * Quits: Ms2ger (~Ms2ger@public.cloak) ("nn")
  166. # [18:46] * Joins: bhill2_ (~bhill2@public.cloak)
  167. # [18:51] * Quits: bhill2 (~bhill2@public.cloak) (Ping timeout: 180 seconds)
  168. # [18:58] * terri_offline is now known as terri
  169. # [19:21] <AutomatedTester> is anyone else seeing hixie's site as down?
  170. # [19:21] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  171. # [19:22] <AutomatedTester> trying to visit http://software.hixie.ch/utilities/js/live-dom-viewer/saved/3754
  172. # [19:31] * Quits: ShaneM (~ShaneM@public.cloak) (Ping timeout: 180 seconds)
  173. # [19:32] <gsnedders> AutomatedTester: down for me
  174. # [19:33] * Joins: waffles (~wafflespeanut@public.cloak)
  175. # [19:43] * Joins: ShaneM (~ShaneM@public.cloak)
  176. # [19:52] <gsnedders> AutomatedTester: back up
  177. # [20:08] * Joins: bhill2 (~bhill2@public.cloak)
  178. # [20:12] * Quits: bhill2 (~bhill2@public.cloak) (Client closed connection)
  179. # [20:12] * Joins: bhill2 (~bhill2@public.cloak)
  180. # [20:14] * Quits: bhill2_ (~bhill2@public.cloak) (Ping timeout: 180 seconds)
  181. # [20:17] * Joins: zcorpan (~zcorpan@public.cloak)
  182. # [20:25] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  183. # [20:44] <ato> I use the Hixie’s data URI kitchen so much it’s ridiculous.
  184. # [20:44] <ato> It can’t be down!
  185. # [20:49] * Quits: ShaneM (~ShaneM@public.cloak) (Ping timeout: 180 seconds)
  186. # [21:00] * Quits: bhill2 (~bhill2@public.cloak) (Client closed connection)
  187. # [21:12] * Joins: ShaneM (~ShaneM@public.cloak)
  188. # [21:13] * Joins: ShaneM_ (~ShaneM@public.cloak)
  189. # [21:13] * Joins: ShaneM__ (~ShaneM@public.cloak)
  190. # [21:19] * Quits: ShaneM (~ShaneM@public.cloak) (Ping timeout: 180 seconds)
  191. # [21:19] * Joins: zcorpan (~zcorpan@public.cloak)
  192. # [21:20] * Quits: ShaneM_ (~ShaneM@public.cloak) (Ping timeout: 180 seconds)
  193. # [21:27] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  194. # [21:36] * Joins: bhill2 (~bhill2@public.cloak)
  195. # [21:40] * Joins: rniwa (~textual@public.cloak)
  196. # [21:40] * Quits: waffles (~wafflespeanut@public.cloak) ("C'yall later...")
  197. # [22:00] * Joins: zcorpan (~zcorpan@public.cloak)
  198. # [22:43] <AutomatedTester> zcorpan: I added that test
  199. # [22:43] <AutomatedTester> I hope I understood what you wanted
  200. # [22:46] <zcorpan> AutomatedTester: yep, looks good. the change to iframe.html is technically not necessary but i suppose it makes the test a bit clearer for people running it, in case the believe the body fills the viewport or something
  201. # [22:46] <zcorpan> which it does in webkit/blink in quirks mode, come to think of it
  202. # [22:47] <zcorpan> which is a bug
  203. # [22:47] <zcorpan> but that has a test already in quirks-mode/ iirc
  204. # [22:48] <AutomatedTester> for the style in iframe i thought it made it painfully obvious
  205. # [22:50] <zcorpan> AutomatedTester: review is accepted, i'll let you squash and merge :-)
  206. # [22:51] <AutomatedTester> awesome, doing that now then
  207. # [22:54] <tobie> jgraham, dom: fwiw, adding @-mentions to the label tool would be trivial (one the label tool is repaired).
  208. # [22:55] * Joins: gitbot (~gitbot@public.cloak)
  209. # [22:55] -gitbot:#testing- [web-platform-tests] AutomatedTester pushed 1 new commit to master: https://github.com/w3c/web-platform-tests/commit/68823b89d97b51927051a73161a43a72181edc54
  210. # [22:55] -gitbot:#testing- web-platform-tests/master 68823b8 AutomatedTester: [cssom-view] Add elementsFromPoint tests
  211. # [22:55] * Parts: gitbot (~gitbot@public.cloak)
  212. # [22:55] <tobie> s/one/once
  213. # [22:55] * heycam|away is now known as heycam
  214. # [22:56] * Joins: gitbot (~gitbot@public.cloak)
  215. # [22:56] -gitbot:#testing- [web-platform-tests] AutomatedTester closed pull request #2353: [cssom-view] Add elementsFromPoint tests (master...elementsFromPoint) https://github.com/w3c/web-platform-tests/pull/2353
  216. # [22:56] * Parts: gitbot (~gitbot@public.cloak)
  217. # [23:10] * Quits: rego (~rego@public.cloak) ("Leaving")
  218. # [23:41] * Quits: ShaneM__ (~ShaneM@public.cloak) (Client closed connection)
  219. # Session Close: Thu Nov 19 00:00:00 2015

Previous day, Next day

Think these logs are useful? Then please donate to show your gratitude (and keep them up, of course). Thanks! — Krijn