/irc-logs / w3c / #testing / 2015-11-27 / end

Options:

Previous day, Next day

  1. # Session Start: Fri Nov 27 00:00:01 2015
  2. # Session Ident: #testing
  3. # [00:13] * Joins: tobie (~sid5692@public.cloak)
  4. # [00:38] * Joins: koji (~sid53200@public.cloak)
  5. # [00:40] * Joins: gitbot (~gitbot@public.cloak)
  6. # [00:40] -gitbot:#testing- [web-platform-tests] nox opened pull request #2379: Test replaceChild calls where both arguments are equal (master...replacechild-mutation-records) https://github.com/w3c/web-platform-tests/pull/2379
  7. # [00:40] * Parts: gitbot (~gitbot@public.cloak)
  8. # [02:49] * Joins: fwtnb (~fwtnb@public.cloak)
  9. # [04:03] * Quits: hober (~ted@public.cloak) (Client closed connection)
  10. # [04:04] * Joins: gitbot (~gitbot@public.cloak)
  11. # [04:04] -gitbot:#testing- [web-platform-tests] common-nighthawk opened pull request #2380: adds test coverage for the html li@type (master...li-html-add-coverage) https://github.com/w3c/web-platform-tests/pull/2380
  12. # [04:04] * Parts: gitbot (~gitbot@public.cloak)
  13. # [04:04] * Joins: hober (~ted@public.cloak)
  14. # [05:33] * Joins: ShaneM (~ShaneM@public.cloak)
  15. # [05:48] * Quits: fwtnb (~fwtnb@public.cloak) (Client closed connection)
  16. # [06:15] * Joins: fwtnb (~fwtnb@public.cloak)
  17. # [06:16] * Quits: fwtnb (~fwtnb@public.cloak) (fwtnb)
  18. # [06:16] * Joins: fwtnb_ (~fwtnb@public.cloak)
  19. # [06:36] * Quits: ShaneM (~ShaneM@public.cloak) (Ping timeout: 180 seconds)
  20. # [07:32] * Quits: fwtnb_ (~fwtnb@public.cloak) (Client closed connection)
  21. # [08:17] * Joins: fwtnb (~fwtnb@public.cloak)
  22. # [08:17] * Quits: fwtnb (~fwtnb@public.cloak) (Client closed connection)
  23. # [08:17] * Joins: fwtnb (~fwtnb@public.cloak)
  24. # [08:58] * Joins: rego (~rego@public.cloak)
  25. # [09:13] * Joins: Ms2ger (~Ms2ger@public.cloak)
  26. # [09:30] * Joins: zcorpan (~zcorpan@public.cloak)
  27. # [10:02] * Quits: hober (~ted@public.cloak) (Client closed connection)
  28. # [10:49] * Quits: rego (~rego@public.cloak) (Ping timeout: 180 seconds)
  29. # [10:53] * Joins: dom (dom@public.cloak)
  30. # [11:01] * Joins: rego (~rego@public.cloak)
  31. # [11:18] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  32. # [11:25] * Joins: zcorpan (~zcorpan@public.cloak)
  33. # [11:42] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  34. # [11:47] * Joins: zcorpan (~zcorpan@public.cloak)
  35. # [12:50] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  36. # [13:10] * Joins: zcorpan (~zcorpan@public.cloak)
  37. # [13:19] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  38. # [13:33] * Joins: zcorpan (~zcorpan@public.cloak)
  39. # [13:52] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  40. # [14:12] * Quits: tobie (~sid5692@public.cloak) (Client closed connection)
  41. # [14:12] * Quits: koji (~sid53200@public.cloak) (Client closed connection)
  42. # [14:13] * Quits: fwtnb (~fwtnb@public.cloak) (Client closed connection)
  43. # [14:17] * Joins: r12a (rishida@public.cloak)
  44. # [14:21] * Joins: simonstewart (~textual@public.cloak)
  45. # [14:21] * Joins: tobie (~sid5692@public.cloak)
  46. # [14:29] * Joins: zcorpan (~zcorpan@public.cloak)
  47. # [14:51] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  48. # [15:00] * Joins: koji (~sid53200@public.cloak)
  49. # [15:19] * Joins: zcorpan (~zcorpan@public.cloak)
  50. # [15:43] * Joins: gitbot (~gitbot@public.cloak)
  51. # [15:43] -gitbot:#testing- [csswg-test] mrego opened pull request #958: [css-grid] Fixed typo in minimum size tests (master...css-grid-fixed-typo-minimum-size-tests) https://github.com/w3c/csswg-test/pull/958
  52. # [15:43] * Parts: gitbot (~gitbot@public.cloak)
  53. # [15:45] * Joins: fwtnb (~fwtnb@public.cloak)
  54. # [15:45] * Quits: fwtnb (~fwtnb@public.cloak) (Client closed connection)
  55. # [15:45] * Joins: fwtnb (~fwtnb@public.cloak)
  56. # [15:53] <mkwst> jgraham (et al.): Is there a `teardown()` analog to `setup()`?
  57. # [15:54] <mkwst> Is `add_completion_callback()` similar enough to what I think want?
  58. # [15:55] <Ms2ger> Might add_cleanup() work?
  59. # [15:56] <gsnedders> setup is kinda confusing given it's only run once, whereas in most things I know setup/teardown are run for every test
  60. # [16:06] * Quits: rego (~rego@public.cloak) ("Leaving")
  61. # [16:08] <Ms2ger> gsnedders, the solution to the other half of our problems is making fantasai work on test infra :)
  62. # [16:09] <gsnedders> Ms2ger: I think fantasai is trying to let me do that :)
  63. # [16:10] <gsnedders> Ms2ger: also really I think the solution to the other half of our problems lies in the Grid module, but maybe that's just me
  64. # [16:22] <mkwst> Ms2ger: I guess I'm confused then. When does `setup()` run if not for every test?
  65. # [16:23] <mkwst> gsnedders: ^^ Once at the top and then never again?
  66. # [16:23] <Ms2ger> setup(f) calls f synchronously
  67. # [16:23] <mkwst> Is there something that operates like a fixture? Do something before a test, run the test, do something after the test?
  68. # [16:24] <Ms2ger> You could create a wrapper function?
  69. # [16:24] <mkwst> I guess that's an option.
  70. # [16:25] <gsnedders> mkwst: yeah
  71. # [16:26] <gsnedders> mkwst: idk, I know jgraham doesn't look setup/teardown stuff, given I remember saying that when he first wrote testharness.js
  72. # [16:26] <Ms2ger> look?
  73. # [16:26] <mkwst> Actually, this wouldn't work with a fixture anyway, now that I think about it.
  74. # [16:26] <gsnedders> s/look/like/
  75. # [16:26] <mkwst> I want to write a test that pokes at cookies. Which are excitingly global state.
  76. # [16:27] <mkwst> I was thinking I could clear a known cookie before every test, and clear it after every test.
  77. # [16:27] <mkwst> But they're all async, so they'd stomp on each other anyway.
  78. # [16:27] <mkwst> Bleh.
  79. # [16:27] <Ms2ger> I hit something similar recently...
  80. # [16:28] <Ms2ger> https://github.com/Ms2ger/web-platform-tests/blob/697448d29eac4a7d2f114a73627b2f9ad94f182b/webstorage/event_case_sensitive.js
  81. # [16:29] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  82. # [16:29] <gsnedders> mkwst: you just have to have a try { } finally {} in the test, doing the cleanup in the finally block
  83. # [16:29] <gsnedders> which IMO sucks, but hey
  84. # [16:29] <Ms2ger> gsnedders, add_cleanup would work too, no?
  85. # [16:30] <gsnedders> I can't remember what add_cleanup does.
  86. # [16:30] <gsnedders> I don't remember it *existing* :)
  87. # [16:30] <Ms2ger> It's not ancient
  88. # [16:30] <mkwst> Ms2ger: looks like an interesting model. I'll poke at something similar, thanks. :)
  89. # [16:30] * gsnedders points out he abandoned all the non-CSS stuff entirely to jgraham's care years ago :)
  90. # [16:30] <Ms2ger> https://github.com/w3c/testharness.js/blob/master/docs/api.md#cleanup
  91. # [16:31] <Ms2ger> mkwst, let me know if you end up using something like it? I stopped working on it before I was entirely happy with it
  92. # [16:31] <jgraham> add_cleanup should work if you just have one test
  93. # [16:31] <mkwst> Ms2ger: will do.
  94. # [16:31] <Ms2ger> Takk
  95. # [16:31] <jgraham> add_result_callback is good for lots of tests
  96. # [16:32] <Ms2ger> Well, good
  97. # [16:33] <jgraham> There isn't a per-test setup function, but with js it's not hard to write async_test(with_setup(function() {}) where with_setup(f) returns a function that does your setup and then calls f
  98. # [16:37] <Ms2ger> r? https://github.com/w3c/csswg-test/pull/952
  99. # [16:43] * Joins: gitbot (~gitbot@public.cloak)
  100. # [16:43] -gitbot:#testing- [csswg-test] mrego closed pull request #958: [css-grid] Fixed typo in minimum size tests (master...css-grid-fixed-typo-minimum-size-tests) https://github.com/w3c/csswg-test/pull/958
  101. # [16:43] * Parts: gitbot (~gitbot@public.cloak)
  102. # [16:43] * Joins: gitbot (~gitbot@public.cloak)
  103. # [16:43] -gitbot:#testing- [csswg-test] mrego pushed 2 new commits to master: https://github.com/w3c/csswg-test/compare/e9d14141426f...4c618372df4a
  104. # [16:43] -gitbot:#testing- csswg-test/master c69f39e Manuel Rego Casasnovas: [css-grid] Fixed typo in minimum size tests
  105. # [16:43] -gitbot:#testing- csswg-test/master 4c61837 Manuel Rego Casasnovas: Merge pull request #958 from mrego/css-grid-fixed-typo-minimum-size-tests...
  106. # [16:43] * Parts: gitbot (~gitbot@public.cloak)
  107. # [16:47] <mkwst> jgraham: Is the `request.cookies` MultiDict iterable?
  108. # [16:48] <mkwst> I'd like a list of all the cookies sent to the server, dumped as JSON. `json.dumps()` doesn't like that construct.
  109. # [16:49] * Joins: ShaneM (~ShaneM@public.cloak)
  110. # [17:04] <Ms2ger> 369 files that end in .html or .htm and include non-ascii bytes, but not "meta charset"
  111. # [17:06] <mkwst> jgraham: Also, the `value` that's returned from `request.cookies.get_list()` seems to be the name and the value of the cookie. :/
  112. # [17:06] <mkwst> I'll file bugs on Monday. :)
  113. # [17:07] <Ms2ger> Please do
  114. # [17:07] <gsnedders> Ms2ger: where? wpt?
  115. # [17:08] <Ms2ger> csswg-test
  116. # [17:08] <Ms2ger> 87 in wpt
  117. # [17:09] <Ms2ger> Most of those in wpt seem to be IDB tests with odinho's name in it
  118. # [17:09] * Joins: gitbot (~gitbot@public.cloak)
  119. # [17:09] -gitbot:#testing- [web-platform-tests] mikewest created mkwst/draft-west-leave-secure-cookies-alone (+1 new commit): https://github.com/w3c/web-platform-tests/commit/707879e14f98
  120. # [17:09] -gitbot:#testing- web-platform-tests/mkwst/draft-west-leave-secure-cookies-alone 707879e Mike West: WIP: leave-secure-cookies-alone tests.
  121. # [17:09] * Parts: gitbot (~gitbot@public.cloak)
  122. # [17:10] <gsnedders> Ms2ger: how much time to fix?
  123. # [17:11] <Ms2ger> I've fixed 46 in the last few minutes
  124. # [17:11] <gsnedders> Well that's simple :)
  125. # [17:12] <Ms2ger> Fortunately the metadata overload makes people copy-paste
  126. # [17:12] * Joins: gitbot (~gitbot@public.cloak)
  127. # [17:12] -gitbot:#testing- [csswg-test] Ms2ger opened pull request #959: Add missing charset declarations in compositing tests. (master...charset-compositing) https://github.com/w3c/csswg-test/pull/959
  128. # [17:12] * Parts: gitbot (~gitbot@public.cloak)
  129. # [17:14] <gsnedders> I wonder what the easiest way to move the CSS source files to being HTML is without having a massive diff. Worthwhile trying to just rename the subset we can?
  130. # [17:14] <Ms2ger> And have them all be appendix-C-style?
  131. # [17:14] <Ms2ger> I don't know
  132. # [17:15] <gsnedders> yeah
  133. # [17:15] <gsnedders> because otherwise the diff is huge from changing trailing-solidus stuff everywhere
  134. # [17:16] <gsnedders> I wonder if it's worthwhile hacking the HTML output slightly to minimize it.
  135. # [17:17] <Ms2ger> If I ignore the ones I already PR'd and work-in-progress/, down to 108 in css
  136. # [17:20] <Ms2ger> Oh look, utf-16
  137. # [17:24] <Ms2ger> And utf-8 boms
  138. # [17:24] <gsnedders> hey, that means those already work!
  139. # [17:24] * gsnedders hides
  140. # [17:25] <Ms2ger> There's 208 utf-8 boms
  141. # [17:25] <Ms2ger> Very popular in work-in-progress/boland/
  142. # [17:26] <gsnedders> Also be careful around the charset stuff.
  143. # [17:26] <gsnedders> Where stuff like BOMs are deliberate.
  144. # [17:28] <Ms2ger> Fucking smart quotes
  145. # [17:30] <Ms2ger> Okay, ten left outside wip/
  146. # [17:30] * Joins: zcorpan (~zcorpan@public.cloak)
  147. # [17:31] <Ms2ger> And two have http-equiv metas
  148. # [17:31] <Ms2ger> Make that three
  149. # [17:33] * Joins: gitbot (~gitbot@public.cloak)
  150. # [17:33] -gitbot:#testing- [csswg-test] Ms2ger opened pull request #960: Avoid non-ASCII characters in files without charset declarations. (master...stupid-quotes) https://github.com/w3c/csswg-test/pull/960
  151. # [17:33] * Parts: gitbot (~gitbot@public.cloak)
  152. # [17:34] <Ms2ger> My outstanding prs should fix everything outside wip/, I think
  153. # [17:37] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  154. # [17:51] * Quits: Ms2ger (~Ms2ger@public.cloak) ("nn")
  155. # [18:07] * Quits: dom (dom@public.cloak) ("")
  156. # [18:11] * Quits: fwtnb (~fwtnb@public.cloak) (Client closed connection)
  157. # [18:12] * Joins: fwtnb (~fwtnb@public.cloak)
  158. # [18:12] * Quits: fwtnb (~fwtnb@public.cloak) (Client closed connection)
  159. # [18:12] * Joins: fwtnb (~fwtnb@public.cloak)
  160. # [18:22] * Quits: fwtnb (~fwtnb@public.cloak) (Client closed connection)
  161. # [18:22] * Joins: fwtnb (~fwtnb@public.cloak)
  162. # [18:29] * Quits: fwtnb (~fwtnb@public.cloak) (Ping timeout: 180 seconds)
  163. # [18:30] * Joins: zcorpan (~zcorpan@public.cloak)
  164. # [18:38] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  165. # [19:10] * Quits: simonstewart (~textual@public.cloak) ("Textual IRC Client: www.textualapp.com")
  166. # [19:32] * Joins: zcorpan (~zcorpan@public.cloak)
  167. # [19:39] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  168. # [20:33] * Joins: zcorpan (~zcorpan@public.cloak)
  169. # [20:40] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  170. # [21:07] * Joins: rniwa (~textual@public.cloak)
  171. # [21:23] * Joins: fwtnb (~fwtnb@public.cloak)
  172. # [21:30] * Quits: fwtnb (~fwtnb@public.cloak) (Ping timeout: 180 seconds)
  173. # [21:34] * Joins: zcorpan (~zcorpan@public.cloak)
  174. # [21:41] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  175. # [22:34] * Joins: zcorpan (~zcorpan@public.cloak)
  176. # [22:42] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  177. # [23:14] * Disconnected
  178. # [23:18] * Attempting to rejoin channel #testing
  179. # [23:18] * Rejoined channel #testing
  180. # [23:19] * Quits: r12a (rishida@public.cloak) (Ping timeout: 180 seconds)
  181. # [23:19] * Quits: ShaneM (~ShaneM@public.cloak) (Ping timeout: 180 seconds)
  182. # [23:20] * Joins: fantasai (~fantasai@public.cloak)
  183. # Session Close: Sat Nov 28 00:00:00 2015

Previous day, Next day

Think these logs are useful? Then please donate to show your gratitude (and keep them up, of course). Thanks! — Krijn