/irc-logs / w3c / #testing / 2015-12-10 / end

Options:

Previous day, Next day

  1. # Session Start: Thu Dec 10 00:00:00 2015
  2. # Session Ident: #testing
  3. # [00:16] * Quits: Ms2ger (~Ms2ger@public.cloak) (Ping timeout: 180 seconds)
  4. # [00:33] * heycam is now known as heycam|away
  5. # [00:35] * Joins: majidvp (~sid96638@public.cloak)
  6. # [00:42] * heycam|away is now known as heycam|away|away
  7. # [00:46] * Quits: bhill2 (~bhill2@public.cloak) (Client closed connection)
  8. # [01:01] * Joins: rniwa_ (~textual@public.cloak)
  9. # [01:06] * Quits: rniwa (~textual@public.cloak) (Ping timeout: 180 seconds)
  10. # [01:59] * Joins: bhill2 (~bhill2@public.cloak)
  11. # [02:10] * Joins: rniwa (~textual@public.cloak)
  12. # [02:16] * Quits: rniwa_ (~textual@public.cloak) (Ping timeout: 180 seconds)
  13. # [02:41] * terri is now known as terri_offline
  14. # [02:45] * Joins: fwtnb (~fwtnb@public.cloak)
  15. # [02:45] * Quits: fwtnb (~fwtnb@public.cloak) (Client closed connection)
  16. # [02:45] * Joins: fwtnb (~fwtnb@public.cloak)
  17. # [02:46] * Quits: bhill2 (~bhill2@public.cloak) (Client closed connection)
  18. # [02:49] * Joins: bhill2 (~bhill2@public.cloak)
  19. # [02:52] * Quits: bhill2 (~bhill2@public.cloak) (Client closed connection)
  20. # [02:53] * Joins: bhill2 (~bhill2@public.cloak)
  21. # [02:56] * Joins: rniwa_ (~textual@public.cloak)
  22. # [02:57] * Quits: rniwa (~textual@public.cloak) (Client closed connection)
  23. # [03:00] * Quits: bhill2 (~bhill2@public.cloak) (Ping timeout: 180 seconds)
  24. # [04:34] * Quits: plh (plehegar@public.cloak) ("Leaving")
  25. # [05:10] * Quits: frewsxcv (~sid86219@public.cloak) (Ping timeout: 180 seconds)
  26. # [05:11] * Joins: frewsxcv (~sid86219@public.cloak)
  27. # [07:08] * Joins: bhill2 (~bhill2@public.cloak)
  28. # [07:11] * Joins: Ms2ger (~Ms2ger@public.cloak)
  29. # [07:46] * Quits: bhill2 (~bhill2@public.cloak) (Client closed connection)
  30. # [07:46] * Joins: bhill2 (~bhill2@public.cloak)
  31. # [07:51] * Quits: bhill2 (~bhill2@public.cloak) (Client closed connection)
  32. # [07:51] * Joins: bhill2 (~bhill2@public.cloak)
  33. # [07:57] * Quits: Ms2ger (~Ms2ger@public.cloak) (Ping timeout: 180 seconds)
  34. # [08:02] * Quits: bhill2 (~bhill2@public.cloak) (Ping timeout: 180 seconds)
  35. # [08:32] * Joins: zcorpan (~zcorpan@public.cloak)
  36. # [08:49] * Quits: rniwa_ (~textual@public.cloak) ("My Mac has gone to sleep. ZZZzzz…")
  37. # [09:41] * Joins: gitbot (~gitbot@public.cloak)
  38. # [09:41] -gitbot:#testing- [csswg-test] hakatashi opened pull request #979: Revert 55a4412 for white-space tests (master...revert-white-spaces-test) https://github.com/w3c/csswg-test/pull/979
  39. # [09:41] * Parts: gitbot (~gitbot@public.cloak)
  40. # [09:42] * Joins: rego (~rego@public.cloak)
  41. # [09:58] * Quits: rego (~rego@public.cloak) ("Leaving")
  42. # [10:28] <mkwst> Hello #testing. I'd love some help finding someone to review https://github.com/w3c/web-platform-tests/pull/2385.
  43. # [11:21] <zcorpan> mkwst: i suppose this should affect websockets also?
  44. # [11:21] <mkwst> zcorpan: The cookie change? Yes.
  45. # [11:23] <mkwst> Thanks for taking a look. :)
  46. # [11:31] <zcorpan> thank you for fixing cookies :-)
  47. # [12:35] <mkwst> zcorpan: Do you happen to know if I need to do anything special to register a new websocket handler?
  48. # [12:38] <zcorpan> mkwst: it uses py_websocket. i think it should be enough to create a new file in https://github.com/w3c/web-platform-tests/tree/master/websockets/handlers
  49. # [12:39] <mkwst> zcorpan: Yeah, I assumed so as well, but it's giving me 404 errors. I'm sure I'm doing something wrong. :)
  50. # [12:39] <zcorpan> mkwst: check what https://github.com/w3c/web-platform-tests/blob/master/websockets/cookies/001.html does
  51. # [12:41] <zcorpan> mkwst: in particular the path should not include /websockets/handlers/ in the ws: or wss: URL
  52. # [12:41] <mkwst> Ah. I need to kill the server and start it up again.
  53. # [12:42] <zcorpan> yeah, that too
  54. # [12:43] <zcorpan> the documentation doesn't cover websocket tests it seems :-(
  55. # [12:47] <mkwst> I'm noticing. But hey, cargo-culting mostly works.
  56. # [12:48] <zcorpan> filed a bug. maybe i can fix it someday if someone reminds me to :-)
  57. # [12:49] <mkwst> can you add `assert_no_regexp_match` at the same time? :)
  58. # [12:52] * Joins: gitbot (~gitbot@public.cloak)
  59. # [12:52] -gitbot:#testing- [web-platform-tests] mikewest pushed 1 new commit to mkwst/draft-west-leave-secure-cookies-alone: https://github.com/w3c/web-platform-tests/commit/6d58316b3377b36dfc20c77942e5abcc11582cf3
  60. # [12:52] -gitbot:#testing- web-platform-tests/mkwst/draft-west-leave-secure-cookies-alone 6d58316 Mike West: fixup websockets + zcorpan
  61. # [12:52] * Parts: gitbot (~gitbot@public.cloak)
  62. # [12:52] <zcorpan> that would be assert_not_regexp_match, or possibly assert_regexp_not_match
  63. # [12:53] <mkwst> Name it whatever you like. ;)
  64. # [12:53] <mkwst> I added some websocket tests. Mind taking another look while I grab lunch? :)
  65. # [13:04] * Joins: gitbot (~gitbot@public.cloak)
  66. # [13:04] -gitbot:#testing- [testharness.js] zcorpan created assert_not_regexp_match (+1 new commit): https://github.com/w3c/testharness.js/commit/25f65333cd40
  67. # [13:04] -gitbot:#testing- testharness.js/assert_not_regexp_match 25f6533 Simon Pieters: Add assert_not_regexp_match...
  68. # [13:04] * Parts: gitbot (~gitbot@public.cloak)
  69. # [13:08] * Joins: gitbot (~gitbot@public.cloak)
  70. # [13:08] -gitbot:#testing- [testharness.js] zcorpan opened pull request #167: Add assert_not_regexp_match (master...assert_not_regexp_match) https://github.com/w3c/testharness.js/pull/167
  71. # [13:08] * Parts: gitbot (~gitbot@public.cloak)
  72. # [13:12] <zcorpan> mkwst: have to leave now. will try to remember to check tomorrow. otherwise ping me
  73. # [13:12] <mkwst> No worries. Thanks for the review thus far!
  74. # [13:15] <jgraham> What are you using the not_regexp_match for?
  75. # [13:15] <jgraham> In general it seems like a very weak test, but I guess in some cases it could be OK
  76. # [13:19] <zcorpan> jgraham: cookies
  77. # [13:20] <zcorpan> i suppose it really wants to check that a substring is not present, but regexp handles that and more
  78. # [13:20] <zcorpan> actually leaving now
  79. # [13:20] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  80. # [13:23] <jgraham> OK. I am just a little nervous about encouraging people to write tests where there are an infinite number of pass conditions and a small number of fail conditions
  81. # [14:01] * Joins: plh (plehegar@public.cloak)
  82. # [14:01] * Joins: dom (dom@public.cloak)
  83. # [14:21] * Joins: zcorpan (~zcorpan@public.cloak)
  84. # [14:28] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  85. # [14:36] <mkwst> jgraham: Well, in this particular case, I'm verifying that a particular cookie doesn't exist. Since that boils down to a string match (hooray, `document.cookies`!), this seemed like a reasonable approach.
  86. # [14:37] <mkwst> jgraham: If there's a different way you'd like me to write https://github.com/w3c/web-platform-tests/pull/2385/files#diff-41a3813a440607785b744b25f650d221R26, I'm happy to change it.
  87. # [14:38] * Joins: Ms2ger (~Ms2ger@public.cloak)
  88. # [14:59] * heycam|away|away is now known as heycam|away
  89. # [14:59] * Quits: Ms2ger (~Ms2ger@public.cloak) (Ping timeout: 180 seconds)
  90. # [15:00] * Joins: Ms2ger (~Ms2ger@public.cloak)
  91. # [15:00] * heycam|away is now known as heycam
  92. # [15:03] * Joins: gitbot (~gitbot@public.cloak)
  93. # [15:03] -gitbot:#testing- [csswg-test] Ms2ger closed pull request #979: Revert "Remove trailing whitespace" for white-space tests (master...revert-white-spaces-test) https://github.com/w3c/csswg-test/pull/979
  94. # [15:03] * Parts: gitbot (~gitbot@public.cloak)
  95. # [15:13] * Joins: zcorpan (~zcorpan@public.cloak)
  96. # [15:21] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  97. # [15:39] * Quits: fwtnb (~fwtnb@public.cloak) (Client closed connection)
  98. # [15:43] <jgraham> mkwst: Worst API Ever
  99. # [15:43] <jgraham> (well except all the other worst ones)
  100. # [15:43] <mkwst> There are lots of bad APIs. Cookies is up there.
  101. # [15:45] <jgraham> Unrelatedly, I was going to implement the webdriver cookies support in servo recently until I realised that it wants a structured view of cookies and getting anything other than a document.cookies-like string representation from the existing servo APIs would be more work than I had time available right then
  102. # [15:47] <jgraham> But, yeah, I guess I can tolerate using a regexp in that case. But I think I'm -0.5 on adding regexp_not_match to testharness.js because I think it's not something you should do very often, and when you do have to do it it's easy enough
  103. # [16:02] <mkwst> jgraham: As long as you know it doesn't exist, sure. I assumed it did, and wasted a minute or three tracking down my mistake.
  104. # [16:03] <mkwst> *shrug*
  105. # [16:10] * Joins: zcorpan (~zcorpan@public.cloak)
  106. # [16:34] * Joins: abreton (~abreton@public.cloak)
  107. # [16:39] * Joins: hgl_ (~hgl@public.cloak)
  108. # [16:41] * Quits: hgl (~hgl@public.cloak) (Ping timeout: 180 seconds)
  109. # [16:46] * Quits: Ms2ger (~Ms2ger@public.cloak) (Ping timeout: 180 seconds)
  110. # [16:54] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  111. # [17:17] * Joins: zcorpan (~zcorpan@public.cloak)
  112. # [17:27] * Quits: abreton (~abreton@public.cloak) ("Page closed")
  113. # [17:29] * Joins: gitbot (~gitbot@public.cloak)
  114. # [17:29] -gitbot:#testing- [testharness.js] zcorpan closed pull request #167: Add assert_not_regexp_match (master...assert_not_regexp_match) https://github.com/w3c/testharness.js/pull/167
  115. # [17:29] * Parts: gitbot (~gitbot@public.cloak)
  116. # [17:29] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  117. # [17:30] * Joins: zcorpan (~zcorpan@public.cloak)
  118. # [17:30] * heycam is now known as heycam|away
  119. # [17:30] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  120. # [17:30] * Joins: zcorpan (~zcorpan@public.cloak)
  121. # [17:36] * Joins: Ms2ger (~Ms2ger@public.cloak)
  122. # [17:38] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  123. # [18:02] * Joins: bhill2 (~bhill2@public.cloak)
  124. # [18:03] * Joins: fwtnb (~fwtnb@public.cloak)
  125. # [18:03] * Quits: fwtnb (~fwtnb@public.cloak) (Client closed connection)
  126. # [18:03] * Joins: fwtnb_ (~fwtnb@public.cloak)
  127. # [18:15] * Quits: dom (dom@public.cloak) ("")
  128. # [18:17] * Joins: ted (ted@public.cloak)
  129. # [18:30] * Joins: zcorpan (~zcorpan@public.cloak)
  130. # [18:40] * Quits: Ms2ger (~Ms2ger@public.cloak) (Ping timeout: 180 seconds)
  131. # [18:55] * terri_offline is now known as terri
  132. # [18:56] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  133. # [18:56] * Joins: zcorpan (~zcorpan@public.cloak)
  134. # [19:01] * Quits: bhill2 (~bhill2@public.cloak) (Client closed connection)
  135. # [19:03] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  136. # [19:04] * Joins: bhill2 (~bhill2@public.cloak)
  137. # [19:06] * Joins: bhill2_ (~bhill2@public.cloak)
  138. # [19:06] * Quits: bhill2 (~bhill2@public.cloak) (Client closed connection)
  139. # [19:20] * Joins: Ms2ger (~Ms2ger@public.cloak)
  140. # [19:24] * Quits: fwtnb_ (~fwtnb@public.cloak) (Client closed connection)
  141. # [19:38] * heycam|away is now known as heycam
  142. # [19:39] * Quits: Ms2ger (~Ms2ger@public.cloak) (Client closed connection)
  143. # [19:39] * Joins: Ms2ger (~Ms2ger@public.cloak)
  144. # [20:23] * Joins: gitbot (~gitbot@public.cloak)
  145. # [20:23] -gitbot:#testing- [csswg-test] Ms2ger closed pull request #969: Move the DOMPoint test a little closer to the specification. (master...point) https://github.com/w3c/csswg-test/pull/969
  146. # [20:23] * Parts: gitbot (~gitbot@public.cloak)
  147. # [20:28] * Quits: plh (plehegar@public.cloak) ("Leaving")
  148. # [20:36] * Joins: zcorpan (~zcorpan@public.cloak)
  149. # [20:45] * Joins: plh (plehegar@public.cloak)
  150. # [20:46] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  151. # [20:46] * Joins: zcorpan (~zcorpan@public.cloak)
  152. # [21:04] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  153. # [21:05] * Joins: zcorpan (~zcorpan@public.cloak)
  154. # [21:07] * Joins: rniwa (~textual@public.cloak)
  155. # [21:12] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  156. # [21:31] * Joins: zcorpan (~zcorpan@public.cloak)
  157. # [21:31] * Quits: zcorpan (~zcorpan@public.cloak) (Client closed connection)
  158. # [21:31] * Joins: zcorpan (~zcorpan@public.cloak)
  159. # [21:38] * Quits: zcorpan (~zcorpan@public.cloak) (Ping timeout: 180 seconds)
  160. # [21:55] * Quits: plh (plehegar@public.cloak) ("Leaving")
  161. # [21:58] * Quits: Ms2ger (~Ms2ger@public.cloak) (Ping timeout: 180 seconds)
  162. # [21:58] * heycam is now known as heycam|away
  163. # [22:04] * Joins: Ms2ger (~Ms2ger@public.cloak)
  164. # [22:09] * Joins: plh (plehegar@public.cloak)
  165. # [22:13] * Quits: plh (plehegar@public.cloak) ("Leaving")
  166. # [22:22] <ato> mkwst: Cookies is definitely up there. I’ve been spending the last month deciphering the specification(s).
  167. # [22:23] * Quits: Ms2ger (~Ms2ger@public.cloak) (Ping timeout: 180 seconds)
  168. # [22:25] * Joins: fwtnb (~fwtnb@public.cloak)
  169. # [22:32] * Quits: fwtnb (~fwtnb@public.cloak) (Ping timeout: 180 seconds)
  170. # [22:46] * Joins: Ms2ger (~Ms2ger@public.cloak)
  171. # [23:13] * heycam|away is now known as heycam
  172. # [23:20] * heycam is now known as heycam|away
  173. # [23:27] * heycam|away is now known as heycam
  174. # Session Close: Fri Dec 11 00:00:00 2015

Previous day, Next day

Think these logs are useful? Then please donate to show your gratitude (and keep them up, of course). Thanks! — Krijn